Re: [ClojureScript] Keyword Hashing
Yes, I'm only testing Safari on iOS. Which looking at my logs seems to be the only one affected. Only Mobile Safari User Agents were sending maps with duplicate keys. No luck producing a more compact example though. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
Re: [ClojureScript] Keyword Hashing
Created a patch to address that :emit-constants issue. http://dev.clojure.org/jira/browse/CLJS-829 Can't say wether its related to the issue at hand but less duplicate code is always good. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
Re: [ClojureScript] Keyword Hashing
Applied to master thanks. David On Tue, Jul 29, 2014 at 2:29 PM, Thomas Heller th.hel...@gmail.com wrote: Created a patch to address that :emit-constants issue. http://dev.clojure.org/jira/browse/CLJS-829 Can't say wether its related to the issue at hand but less duplicate code is always good. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
Re: [ClojureScript] Keyword Hashing
So you or do not have a minimal case for Mobile Safari that I can test with? Thanks, David On Tue, Jul 29, 2014 at 4:16 PM, Thomas Heller th.hel...@gmail.com wrote: Thanks. I give up. I have no more ideas what to test, whats even more annoying is that when I attach the remote debugger BEFORE navigating to the page producing the faulty maps the bug doesn't show. If I do the exact same steps but attach the remote debugger AFTER loading the page the bug happens. At least I can tell you that the release 0.0-2234 doesn't have this problem. So it was introduced some time after https://github.com/clojure/clojurescript/compare/b8c4a40d9a795899b86fd33e6024a19b899640db...master But since the murmur3 hashing was introduced after 2234 thats no surprise. Happy to test any ideas you might have, but I can't think of anything I haven't tried. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
Re: [ClojureScript] Keyword Hashing
I've heard this from a couple of sources. Minimal case would be very welcome and we'll cut a release as soon as we have a patch. David On Mon, Jul 28, 2014 at 8:16 AM, Thomas Heller th.hel...@gmail.com wrote: Hey, I'm running into alot of java.lang.IllegalArgumentException: Duplicate key: :display-as at clojure.lang.PersistentHashMap.createWithCheck(PersistentHashMap.java:67) at clojure.lang.RT.map(RT.java:1462) at clojure.lang.EdnReader$MapReader.invoke(EdnReader.java:631) at clojure.lang.EdnReader.read(EdnReader.java:142) at clojure.lang.EdnReader.read(EdnReader.java:108) at clojure.lang.EdnReader.readString(EdnReader.java:64) at clojure.edn$read_string.invoke(edn.clj:46) lately with the new clojurescript-0.0-2277 release, I'm reading maps that where pr-str'd on the clojurescript side of things and then transmitted over the wire. It shouldn't happen that cljs prints a map with duplicated keys since there should not be a way to insert the same key twice. I wasn't able to reproduce this yet as it doesn't happen for everybody, I guess its only a subset of browsers or other conditions but the only way I can trace this back is to faulty keyword hashing. Will try to produce a minimal test-case but it seems there is a serious issue somewhere. YMMV, /thomas -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
Re: [ClojureScript] Keyword Hashing
FWIW I started logging User Agents that send the faulty hash-maps and it seems to be related to mobile Safari. Can reproduce it on my iPhone now. Safari 7.0.5 on my mac doesnt show this problem though. Will look some more. Cheers, /thomas PS: Some of the affected user agents Mozilla/5.0 (iPad; CPU OS 7_1_2 like Mac OS X) AppleWebKit/537.51.2 (KHTML, like Gecko) Version/7.0 Mobile/11D257 Safari/9537.53 Mozilla/5.0 (iPhone; CPU iPhone OS 7_1_2 like Mac OS X) AppleWebKit/537.51.2 (KHTML, like Gecko) Version/7.0 Mobile/11D257 Safari/9537.53 Mozilla/5.0 (Linux; U; Android 4.1.2; de-de; GT-N8010 Build/JZO54K) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30 On Monday, July 28, 2014 3:35:49 PM UTC+2, David Nolen wrote: I've heard this from a couple of sources. Minimal case would be very welcome and we'll cut a release as soon as we have a patch. David On Mon, Jul 28, 2014 at 8:16 AM, Thomas Heller th.hel...@gmail.com wrote: Hey, I'm running into alot of java.lang.IllegalArgumentException: Duplicate key: :display-as at clojure.lang.PersistentHashMap.createWithCheck(PersistentHashMap.java:67) at clojure.lang.RT.map(RT.java:1462) at clojure.lang.EdnReader$MapReader.invoke(EdnReader.java:631) at clojure.lang.EdnReader.read(EdnReader.java:142) at clojure.lang.EdnReader.read(EdnReader.java:108) at clojure.lang.EdnReader.readString(EdnReader.java:64) at clojure.edn$read_string.invoke(edn.clj:46) lately with the new clojurescript-0.0-2277 release, I'm reading maps that where pr-str'd on the clojurescript side of things and then transmitted over the wire. It shouldn't happen that cljs prints a map with duplicated keys since there should not be a way to insert the same key twice. I wasn't able to reproduce this yet as it doesn't happen for everybody, I guess its only a subset of browsers or other conditions but the only way I can trace this back is to faulty keyword hashing. Will try to produce a minimal test-case but it seems there is a serious issue somewhere. YMMV, /thomas -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups ClojureScript group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
