[cmake-developers] [CMake 0014494]: Doesn't create .lib for header only targets on Windows.
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14494 == Reported By:icando Assigned To: == Project:CMake Issue ID: 14494 Category: CMake Reproducibility:always Severity: major Priority: high Status: new == Date Submitted: 2013-10-20 03:27 EDT Last Modified: 2013-10-20 03:27 EDT == Summary:Doesn't create .lib for header only targets on Windows. Description: Not sure if it should be a bug report or a feature request. Basically the support for header-only library on Windows is missing. I've tested under Linux and the feature IS actually supported. A header-only library will generate minimum .a file that has nothing in it. However, on Windows, it passes no source file to the 'lib' tool and the tool doesn't generate any files in this case. It would be better to handle it in CMake side as opposed to the CMakeLists.txt side. The simplest fix would be generating an empty source file for windows platform if it is header only. A more complicated fix is when CMake generates Makefile, it doesn't generate dependencies on the .a or .lib if it is header-only target, but generates dependencies on child targets. Steps to Reproduce: Unzip the attached file, and under Windows, run cmake -G NMake Makefiles nmake It will produce: NMAKE : fatal error U1073: don't know how to make 'B.lib' == Issue History Date ModifiedUsername FieldChange == 2013-10-20 03:27 icando New Issue 2013-10-20 03:27 icando File Added: tests.zip == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Ninja: using dependency database
Therefore ninja master is needed, please update your build server. When a particular ninja 'master' is required, it would be great if you could recommend a given snapshot by git commit rather than just saying 'master'. Especially for those of us submitting CMake dashboards using ninja, it would be very helpful to use a consistent ninja, preferably even a tag from their git repo once one becomes available that has the required features in it. For now, would you recommend a given commit? I see this one on github right now: https://github.com/martine/ninja/commit/a3c823c3da70bd46d69341f13184cdae4c77645d Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Ninja: using dependency database
On 20.10.2013 17:13, David Cole wrote: Therefore ninja master is needed, please update your build server. When a particular ninja 'master' is required, it would be great if you could recommend a given snapshot by git commit rather than just saying 'master'. Especially for those of us submitting CMake dashboards using ninja, it would be very helpful to use a consistent ninja, preferably even a tag from their git repo once one becomes available that has the required features in it. For now, would you recommend a given commit? I see this one on github right now: https://github.com/martine/ninja/commit/a3c823c3da70bd46d69341f13184cdae4c77645d This commit is ok, at least 037b0934f929ba17434906fb781aeb1acb583385. Thanks, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014495]: Spurious error about non-existent INTERFACE_INCLUDE_DIRECTORIES of IMPORTED target
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14495
==
Reported By:Nick Hutchinson
Assigned To:
==
Project:CMake
Issue ID: 14495
Category: CMake
Reproducibility:always
Severity: minor
Priority: normal
Status: new
==
Date Submitted: 2013-10-21 05:55 NZDT
Last Modified: 2013-10-21 05:55 NZDT
==
Summary:Spurious error about non-existent
INTERFACE_INCLUDE_DIRECTORIES of IMPORTED target
Description:
CMake seems to demand that the directories referenced by the
INTERFACE_INCLUDE_DIRECTORIES property of an IMPORTED target can be found at
configure-time. This is quite unhelpful if those directories are only generated
generated as part of the build.
You get the following error:
Imported target XXX includes non-existent path
YYY
in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:
* The path was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and references files it does not
provide.
Workaround is add a `file(MAKE_DIRECTORY YYY)` command to the CMakeLists.txt
file.
Steps to Reproduce:
cat -EOF CMakeLists.txt
cmake_minimum_required(VERSION 2.8.12)
add_library(foo STATIC IMPORTED GLOBAL)
set_property(TARGET foo PROPERTY INTERFACE_INCLUDE_DIRECTORIES
${CMAKE_CURRENT_BINARY_DIR}/include)
EOF
cmake -GNinja .
==
Issue History
Date ModifiedUsername FieldChange
==
2013-10-21 05:55 Nick HutchinsonNew Issue
==
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
Am Samstag, 19. Oktober 2013, 18:01:55 schrieb Jed Brown:
I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a
comma ',' appears in a linker flag. Test case below. Note that this is
but one of many reasons for a comma to appear in linker flags.
https://gist.github.com/jedbrown/7062540
$ mkdir build cd build
$ cmake -DDEP_LIBS:STRING='-Wl,--start-group -llapack -lblas
-Wl,--end-group' ..
target_link_libraries(foo ${DEP_LIBS})
target_link_libraries is about libraries. No wonder it breaks if you pass
other stuff in there. I wonder if using FindBLAS and FindLAPACK would help you
out of that.
Eike
signature.asc
Description: This is a digitally signed message part.
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
target_link_libraries() is supposed to work for linker flags as well:
cmake version 2.8.12
target_link_libraries
Link a target to given libraries.
target_link_libraries(target [item1 [item2 [...]]]
[[debug|optimized|general] item] ...)
Specify libraries or flags to use when linking a given target. The
named target must have been created in the current directory by a
command such as add_executable or add_library. The remaining
arguments specify library names or flags.
On 20 Oct 2013, at 09:13, Rolf Eike Beer e...@sf-mail.de wrote:
Am Samstag, 19. Oktober 2013, 18:01:55 schrieb Jed Brown:
I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a
comma ',' appears in a linker flag. Test case below. Note that this is
but one of many reasons for a comma to appear in linker flags.
https://gist.github.com/jedbrown/7062540
$ mkdir build cd build
$ cmake -DDEP_LIBS:STRING='-Wl,--start-group -llapack -lblas
-Wl,--end-group' ..
target_link_libraries(foo ${DEP_LIBS})
target_link_libraries is about libraries. No wonder it breaks if you pass
other stuff in there. I wonder if using FindBLAS and FindLAPACK would help
you
out of that.
Eike--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
Nick Hutchinson nshutchin...@gmail.com writes: target_link_libraries() is supposed to work for linker flags as well: cmake version 2.8.12 target_link_libraries Link a target to given libraries. target_link_libraries(target [item1 [item2 [...]]] [[debug|optimized|general] item] ...) Specify libraries or flags to use when linking a given target. The named target must have been created in the current directory by a command such as add_executable or add_library. The remaining arguments specify library names or flags. Exactly, and the next paragraph is: If a library name matches that of another target in the project a dependency will automatically be added in the build system to make sure the library being linked is up-to-date before the target links. Item names starting with '-', but not '-l' or '-framework', are treated as linker flags. This all works with earlier versions of CMake. Did 2.8.12 intentionally break compatibility and forget to document it? pgpOuyec4TPPZ.pgp Description: PGP signature -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
Am Sonntag, 20. Oktober 2013, 08:48:36 schrieb Jed Brown: Nick Hutchinson nshutchin...@gmail.com writes: target_link_libraries() is supposed to work for linker flags as well: This all works with earlier versions of CMake. Did 2.8.12 intentionally break compatibility and forget to document it? This was for sure not intentional. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[CMake] Seeking volunteer to host old dashboard machines
If you can give a home, electricity and a wireless internet connection to mirkwood or carrock (older machines runnings Windows XP), please let me know. I'm moving from a 4-bedroom house with a full basement to a 2-bedroom apartment with NO basement so my basement machines have to go to a new home or be retired/sold for scrap parts. So, if you can save a dashboard machine, please reply to me directly, and we'll figure out a way to get one or both of them to you. If you do host it, I would still be happy to take care of maintaining the dashboards on it, if you'll give me a port through your router to access the VNC servers running on them. Also: I have two other OLD machines available for free to the first claimer: (1) I have an old laptop with a busted screen that still works if you plug it into a monitor. Free if you want it, but probably not capable enough to run any significant dashboards. And (2), a Compaq desktop unit from circa ~2003 whose hard drive may or may not bite the dust in the next 100 reboot cycles. ;-) Thanks, David C. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
Jed Brown wrote: I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. I've pushed a fix candidate: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3eeb83d147030 Remember that the way to avoid bugs like this in the release is to test a release candidate. Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. ... Remember that the way to avoid bugs like this in the release is to test a release candidate. Nice to see that you've added something to the test suite to prevent this same problem from being re-introduced during future development. :-) One question about the test, though: are those linker flags simply ignored by non-gcc compilers? I don't see anything in the CMakeLists file for the test that determines whether the linker interprets -Wl,--start-group etc. properly...? Thx, D -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
Stephen Kelly steve...@gmail.com writes:
Jed Brown wrote:
I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a
comma ',' appears in a linker flag. Test case below. Note that this is
but one of many reasons for a comma to appear in linker flags.
I've pushed a fix candidate:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3eeb83d147030
Thanks. Did the test case here really reproduce the problem on your
end? Putting essentially that line
target_link_libraries(staticlib1 LINK_PRIVATE -L${CMAKE_CURRENT_BINARY_DIR}
-Wl,--start-group -lstaticlib3 -Wl,--end-group)
in my test case did not trigger the error.
I guess this will be in 2.8.12.1, whenever that is released?
Remember that the way to avoid bugs like this in the release is to test a
release candidate.
None of my current projects use CMake. I encountered this issue while
updating an interface to someone else's project that uses CMake. I
reduced the test case to rule out the possibility that it was a usage
problem on his part and to make sure it was easy for you to reproduce so
that it could be fixed quickly, but I don't see it as my responsibility
to test release candidates of software that I don't use.
pgpJqqylobEVo.pgp
Description: PGP signature
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma
David, your reply failed to set In-Reply-To or References headers, and is thus not threaded with the conversation it purports to reply to, meaning that it skipped my inbox. If this was not intentional, you may want to check your mail client settings. David Cole dlrd...@aol.com writes: One question about the test, though: are those linker flags simply ignored by non-gcc compilers? I don't see anything in the CMakeLists file for the test that determines whether the linker interprets -Wl,--start-group etc. properly...? No, this is not a portable linker flag. A more portable flag that is also sufficient to trigger the bug is -L/directory,with,commas pgp0LqKY3Nbs5.pgp Description: PGP signature -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[CMake] Components not recognized with FindHDF5.cmake
Hello I try to find the hdf5 libraries, but it seems that the components are not recognized. I use FIND_PACKAGE(HDF5 COMPONENTS C CXX HL REQUIRED) but it only comes up with the libhdf5.so and doesn't detect libhdf5_cpp.so and libhdf5_hl.so. I also cleaned the whole build directory but without success. It seems that it doesn't even look for the libraries because in the find script the execution already skips the components at the beginning IF (NOT HDF%_FIND_COMPONENTS) SET(HDF5_LANGUAGE_BINDINGS C) ELSE () # This part is not executed ENDIF() Thanks for any hints Cheers Reza -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
[Cmake-commits] CMake branch, next, updated. v2.8.12-4188-geb90fae
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.
The branch, next has been updated
via eb90faebc07dc28fe839d68e89e68255b8e9f7cd (commit)
via 4fa1f07ca28ca9259971f2880ade6c201e0f7d24 (commit)
from 0d9c91f449bd744bb7662b6227e719ea80fdc91b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eb90faebc07dc28fe839d68e89e68255b8e9f7cd
commit eb90faebc07dc28fe839d68e89e68255b8e9f7cd
Merge: 0d9c91f 4fa1f07
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 05:30:19 2013 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Sun Oct 20 05:30:19 2013 -0400
Merge topic 'INTERFACE_LIBRARY-build-targets' into next
4fa1f07 Add hack for Borland makefiles.
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4fa1f07ca28ca9259971f2880ade6c201e0f7d24
commit 4fa1f07ca28ca9259971f2880ade6c201e0f7d24
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 11:29:27 2013 +0200
Commit: Stephen Kelly steve...@gmail.com
CommitDate: Sun Oct 20 11:29:27 2013 +0200
Add hack for Borland makefiles.
diff --git a/Source/cmGlobalUnixMakefileGenerator3.cxx
b/Source/cmGlobalUnixMakefileGenerator3.cxx
index 3a261e2..ce95c08 100644
--- a/Source/cmGlobalUnixMakefileGenerator3.cxx
+++ b/Source/cmGlobalUnixMakefileGenerator3.cxx
@@ -776,6 +776,10 @@ cmGlobalUnixMakefileGenerator3
depends.clear();
}
this-AppendGlobalTargetDepends(depends,t-second);
+ if(depends.empty() this-EmptyRuleHackDepends != )
+{
+depends.push_back(this-EmptyRuleHackDepends);
+}
lg-WriteMakeRule(ruleFileStream, All Build rule for target.,
localName.c_str(), depends, commands, true);
---
Summary of changes:
Source/cmGlobalUnixMakefileGenerator3.cxx |4
1 files changed, 4 insertions(+), 0 deletions(-)
hooks/post-receive
--
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.12-4190-g1dfe0df
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 1dfe0df433d80bda91ec4feeedccb545ed249f0c (commit) via 187385a8edaaf907e449478706240236a84cd266 (commit) from eb90faebc07dc28fe839d68e89e68255b8e9f7cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1dfe0df433d80bda91ec4feeedccb545ed249f0c commit 1dfe0df433d80bda91ec4feeedccb545ed249f0c Merge: eb90fae 187385a Author: Stephen Kelly steve...@gmail.com AuthorDate: Sun Oct 20 06:30:09 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Sun Oct 20 06:30:09 2013 -0400 Merge topic 'minor-cleanups' into next 187385a cmCoreTryCompile: Fix typo in comments. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=187385a8edaaf907e449478706240236a84cd266 commit 187385a8edaaf907e449478706240236a84cd266 Author: Stephen Kelly steve...@gmail.com AuthorDate: Sun Oct 20 12:29:15 2013 +0200 Commit: Stephen Kelly steve...@gmail.com CommitDate: Sun Oct 20 12:29:15 2013 +0200 cmCoreTryCompile: Fix typo in comments. Add 'S' to match actual variable names. diff --git a/Source/cmCoreTryCompile.cxx b/Source/cmCoreTryCompile.cxx index bc4bf18..0ac969b 100644 --- a/Source/cmCoreTryCompile.cxx +++ b/Source/cmCoreTryCompile.cxx @@ -372,8 +372,8 @@ int cmCoreTryCompile::TryCompileCode(std::vectorstd::string const argv) } /* for the TRY_COMPILEs we want to be able to specify the architecture. - So the user can set CMAKE_OSX_ARCHITECTURE to i386;ppc and then set - CMAKE_TRY_COMPILE_OSX_ARCHITECTURE first to i386 and then to ppc to + So the user can set CMAKE_OSX_ARCHITECTURES to i386;ppc and then set + CMAKE_TRY_COMPILE_OSX_ARCHITECTURES first to i386 and then to ppc to have the tests run for each specific architecture. Since cmLocalGenerator doesn't allow building for the other architecture only via CMAKE_OSX_ARCHITECTURES. --- Summary of changes: Source/cmCoreTryCompile.cxx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.12-357-gf040840
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via f040840f9b4c3c431b327b167fdbfb5df6c3ec8f (commit) via 1b7117a8248da32038c6f3503ffebe38089f8610 (commit) from 2e685168181db59dc9004524ac6c44b4244e1127 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f040840f9b4c3c431b327b167fdbfb5df6c3ec8f commit f040840f9b4c3c431b327b167fdbfb5df6c3ec8f Merge: 2e68516 1b7117a Author: Brad King brad.k...@kitware.com AuthorDate: Sun Oct 20 07:37:38 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Sun Oct 20 07:37:38 2013 -0400 Merge topic 'vs-intel-compiler' 1b7117a VS 6: Do not try Intel Fortran .vfproj file with msdev --- Summary of changes: Modules/CMakeDetermineCompilerId.cmake |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.12-4195-gc86761a
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via c86761aa864d0db1bc03edac220e6244f9e8f76b (commit) via 936dec32e54156c1a1e42f09938dc04573381640 (commit) via f040840f9b4c3c431b327b167fdbfb5df6c3ec8f (commit) via 2e685168181db59dc9004524ac6c44b4244e1127 (commit) via 0645d74118603991dae3aa76787873fe7fb3948f (commit) from 1dfe0df433d80bda91ec4feeedccb545ed249f0c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c86761aa864d0db1bc03edac220e6244f9e8f76b commit c86761aa864d0db1bc03edac220e6244f9e8f76b Merge: 1dfe0df 936dec3 Author: Brad King brad.k...@kitware.com AuthorDate: Sun Oct 20 07:38:11 2013 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Sun Oct 20 07:38:11 2013 -0400 Merge branch 'master' into next --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.12-359-g936dec3
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via 936dec32e54156c1a1e42f09938dc04573381640 (commit) via abfebefbb981a95837ffe88f98956785d936306d (commit) from f040840f9b4c3c431b327b167fdbfb5df6c3ec8f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=936dec32e54156c1a1e42f09938dc04573381640 commit 936dec32e54156c1a1e42f09938dc04573381640 Merge: f040840 abfebef Author: Brad King brad.k...@kitware.com AuthorDate: Sun Oct 20 07:37:48 2013 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Sun Oct 20 07:37:48 2013 -0400 Merge topic 'target-LOCATION-policy' abfebef Cygwin: Avoid legacy warnings in RunCMake.CMP0026 test --- Summary of changes: Tests/RunCMake/CMP0026/CMakeLists.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.12-4197-g3d63217
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.
The branch, next has been updated
via 3d63217d93e1f9aee8084836415faad9aaa6f88d (commit)
via ff1a03680bc1dcf2294789ad041b8717b91e6b51 (commit)
from c86761aa864d0db1bc03edac220e6244f9e8f76b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d63217d93e1f9aee8084836415faad9aaa6f88d
commit 3d63217d93e1f9aee8084836415faad9aaa6f88d
Merge: c86761a ff1a036
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 08:57:18 2013 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Sun Oct 20 08:57:18 2013 -0400
Merge topic 'INTERFACE_LIBRARY-build-targets' into next
ff1a036 Make INTERFACE_LIBRARY targets part of the all target by default.
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ff1a03680bc1dcf2294789ad041b8717b91e6b51
commit ff1a03680bc1dcf2294789ad041b8717b91e6b51
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Wed Oct 16 13:30:51 2013 +0200
Commit: Stephen Kelly steve...@gmail.com
CommitDate: Sun Oct 20 14:56:35 2013 +0200
Make INTERFACE_LIBRARY targets part of the all target by default.
Test this by building the all target and making the expected library
EXCLUDE_FROM_ALL.
diff --git a/Source/cmGlobalUnixMakefileGenerator3.cxx
b/Source/cmGlobalUnixMakefileGenerator3.cxx
index 8ee7b44..ce95c08 100644
--- a/Source/cmGlobalUnixMakefileGenerator3.cxx
+++ b/Source/cmGlobalUnixMakefileGenerator3.cxx
@@ -771,23 +771,26 @@ cmGlobalUnixMakefileGenerator3
progressDir += t-first;
lg-AppendEcho(commands,progressDir.c_str());
}
-
+ else
+{
+depends.clear();
+}
this-AppendGlobalTargetDepends(depends,t-second);
-
+ if(depends.empty() this-EmptyRuleHackDepends != )
+{
+depends.push_back(this-EmptyRuleHackDepends);
+}
lg-WriteMakeRule(ruleFileStream, All Build rule for target.,
localName.c_str(), depends, commands, true);
- if(t-second.GetType() != cmTarget::INTERFACE_LIBRARY)
+ // add the all/all dependency
+ if(!this-IsExcluded(this-LocalGenerators[0], t-second))
{
-// add the all/all dependency
-if(!this-IsExcluded(this-LocalGenerators[0], t-second))
- {
- depends.clear();
- depends.push_back(localName);
- commands.clear();
- lg-WriteMakeRule(ruleFileStream, Include target in all.,
-all, depends, commands, true);
- }
+depends.clear();
+depends.push_back(localName);
+commands.clear();
+lg-WriteMakeRule(ruleFileStream, Include target in all.,
+ all, depends, commands, true);
}
// Write the rule.
diff --git a/Tests/CMakeLists.txt b/Tests/CMakeLists.txt
index d779cdb..198ce04 100644
--- a/Tests/CMakeLists.txt
+++ b/Tests/CMakeLists.txt
@@ -273,7 +273,6 @@ if(BUILD_TESTING)
--build-two-config
${build_generator_args}
--build-project InterfaceBuildTargets
- --build-target iface
--test-command ${CMAKE_CMAKE_COMMAND} -E touch_nocreate
${InterfaceBuildTargets_libname}
)
list(APPEND TEST_BUILD_DIRS
${CMake_BINARY_DIR}/Tests/InterfaceBuildTargets)
diff --git a/Tests/InterfaceBuildTargets/CMakeLists.txt
b/Tests/InterfaceBuildTargets/CMakeLists.txt
index 630259d..a00e5d5 100644
--- a/Tests/InterfaceBuildTargets/CMakeLists.txt
+++ b/Tests/InterfaceBuildTargets/CMakeLists.txt
@@ -1,6 +1,6 @@
project(InterfaceBuildTargets)
-add_library(testlib testlib.cxx)
+add_library(testlib EXCLUDE_FROM_ALL testlib.cxx)
set_property(TARGET testlib PROPERTY PREFIX )
if(CMAKE_GENERATOR MATCHES Borland|Watcom)
# These librarians add the .lib suffix anyway.
---
Summary of changes:
hooks/post-receive
--
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v2.8.12-4199-g0c02d83
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.
The branch, next has been updated
via 0c02d8327cf6be5dd364f43790d6d2044e84c3c0 (commit)
via 3eeb83d1470309fab44bea65c669ba27b1818796 (commit)
from 3d63217d93e1f9aee8084836415faad9aaa6f88d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0c02d8327cf6be5dd364f43790d6d2044e84c3c0
commit 0c02d8327cf6be5dd364f43790d6d2044e84c3c0
Merge: 3d63217 3eeb83d
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 14:40:57 2013 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Sun Oct 20 14:40:57 2013 -0400
Merge topic 'fix-tll-static-private' into next
3eeb83d Don't add invalid content to static lib INTERFACE_LINK_LIBRARIES.
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3eeb83d1470309fab44bea65c669ba27b1818796
commit 3eeb83d1470309fab44bea65c669ba27b1818796
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 20:39:16 2013 +0200
Commit: Stephen Kelly steve...@gmail.com
CommitDate: Sun Oct 20 20:39:16 2013 +0200
Don't add invalid content to static lib INTERFACE_LINK_LIBRARIES.
Only valid target names or generator expressions may appear in
the target field of a LINK_ONLY expression.
diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx
index b6182ab..24978d9 100644
--- a/Source/cmTarget.cxx
+++ b/Source/cmTarget.cxx
@@ -985,15 +985,20 @@ void cmTarget::MergeLinkLibraries( cmMakefile mf,
i += this-PrevLinkedLibraries.size();
for( ; i != libs.end(); ++i )
{
+const char *lib = i-first.c_str();
// We call this so that the dependencies get written to the cache
-this-AddLinkLibrary( mf, selfname, i-first.c_str(), i-second );
+this-AddLinkLibrary( mf, selfname, lib, i-second );
if (this-GetType() == cmTarget::STATIC_LIBRARY)
{
- this-AppendProperty(INTERFACE_LINK_LIBRARIES,
-($LINK_ONLY: +
-this-GetDebugGeneratorExpressions(i-first.c_str(), i-second) +
-).c_str());
+ if (cmGeneratorExpression::IsValidTargetName(lib)
+ || cmGeneratorExpression::Find(lib) != std::string::npos)
+{
+this-AppendProperty(INTERFACE_LINK_LIBRARIES,
+ ($LINK_ONLY: +
+ this-GetDebugGeneratorExpressions(lib, i-second)
+ + ).c_str());
+}
}
}
this-PrevLinkedLibraries = libs;
diff --git a/Source/cmTargetLinkLibrariesCommand.cxx
b/Source/cmTargetLinkLibrariesCommand.cxx
index 0707c62..d3db514 100644
--- a/Source/cmTargetLinkLibrariesCommand.cxx
+++ b/Source/cmTargetLinkLibrariesCommand.cxx
@@ -395,10 +395,14 @@ cmTargetLinkLibrariesCommand::HandleLibrary(const char*
lib,
{
if (this-Target-GetType() == cmTarget::STATIC_LIBRARY)
{
-this-Target-AppendProperty(INTERFACE_LINK_LIBRARIES,
+if (cmGeneratorExpression::IsValidTargetName(lib)
+|| cmGeneratorExpression::Find(lib) != std::string::npos)
+ {
+ this-Target-AppendProperty(INTERFACE_LINK_LIBRARIES,
($LINK_ONLY: +
this-Target-GetDebugGeneratorExpressions(lib, llt) +
).c_str());
+ }
}
// Not a 'public' or 'interface' library. Do not add to interface
// property.
diff --git a/Tests/CMakeCommands/target_link_libraries/cmp0022/CMakeLists.txt
b/Tests/CMakeCommands/target_link_libraries/cmp0022/CMakeLists.txt
index 07d7c43..7a5c621 100644
--- a/Tests/CMakeCommands/target_link_libraries/cmp0022/CMakeLists.txt
+++ b/Tests/CMakeCommands/target_link_libraries/cmp0022/CMakeLists.txt
@@ -21,7 +21,10 @@ add_library(staticlib1 STATIC staticlib1.cpp)
generate_export_header(staticlib1)
add_library(staticlib2 STATIC staticlib2.cpp)
generate_export_header(staticlib2)
+add_library(staticlib3 STATIC staticlib3.cpp)
+generate_export_header(staticlib3)
target_link_libraries(staticlib1 LINK_PUBLIC staticlib2)
+target_link_libraries(staticlib1 LINK_PRIVATE -L${CMAKE_CURRENT_BINARY_DIR}
-Wl,--start-group -lstaticlib3 -Wl,--end-group)
add_executable(staticlib_exe staticlib_exe.cpp)
target_link_libraries(staticlib_exe staticlib1)
---
Summary of changes:
Source/cmTarget.cxx| 15 ++-
Source/cmTargetLinkLibrariesCommand.cxx|6 +-
.../target_link_libraries/cmp0022/CMakeLists.txt |3 +++
3 files changed, 18 insertions(+), 6 deletions(-)
hooks/post-receive
--
CMake
___
Cmake-commits mailing list
[Cmake-commits] CMake branch, next, updated. v2.8.12-4201-g4a9d26b
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project CMake.
The branch, next has been updated
via 4a9d26b5eb5f46d9f09cfe5366bddb43fd48ec0d (commit)
via 9bc39bfc9de89654fb6b965391a4190a4dbc966a (commit)
from 0c02d8327cf6be5dd364f43790d6d2044e84c3c0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4a9d26b5eb5f46d9f09cfe5366bddb43fd48ec0d
commit 4a9d26b5eb5f46d9f09cfe5366bddb43fd48ec0d
Merge: 0c02d83 9bc39bf
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 14:54:25 2013 -0400
Commit: CMake Topic Stage kwro...@kitware.com
CommitDate: Sun Oct 20 14:54:25 2013 -0400
Merge topic 'fix-tll-static-private' into next
9bc39bf Add missing files.
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9bc39bfc9de89654fb6b965391a4190a4dbc966a
commit 9bc39bfc9de89654fb6b965391a4190a4dbc966a
Author: Stephen Kelly steve...@gmail.com
AuthorDate: Sun Oct 20 20:53:03 2013 +0200
Commit: Stephen Kelly steve...@gmail.com
CommitDate: Sun Oct 20 20:53:24 2013 +0200
Add missing files.
diff --git a/Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.cpp
b/Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.cpp
new file mode 100644
index 000..570a911
--- /dev/null
+++ b/Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.cpp
@@ -0,0 +1,2 @@
+
+int staticlib3() { return 0; }
diff --git a/Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.h
b/Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.h
new file mode 100644
index 000..9c88522
--- /dev/null
+++ b/Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.h
@@ -0,0 +1,4 @@
+#ifdef _WIN32
+__declspec(dllexport)
+#endif
+int staticlib3();
---
Summary of changes:
.../target_link_libraries/cmp0022/staticlib3.cpp |2 ++
.../cmp0022/{staticlib1.h = staticlib3.h} |2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
create mode 100644
Tests/CMakeCommands/target_link_libraries/cmp0022/staticlib3.cpp
copy Tests/CMakeCommands/target_link_libraries/cmp0022/{staticlib1.h =
staticlib3.h} (70%)
hooks/post-receive
--
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v2.8.12-360-gecfcce4
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via ecfcce44b31ad7a6a39088e950ba36a0d8abc517 (commit) from 936dec32e54156c1a1e42f09938dc04573381640 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ecfcce44b31ad7a6a39088e950ba36a0d8abc517 commit ecfcce44b31ad7a6a39088e950ba36a0d8abc517 Author: Kitware Robot kwro...@kitware.com AuthorDate: Mon Oct 21 00:01:08 2013 -0400 Commit: Kitware Robot kwro...@kitware.com CommitDate: Mon Oct 21 00:01:08 2013 -0400 CMake Nightly Date Stamp diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index 64ec644..a44f362 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -2,5 +2,5 @@ set(CMake_VERSION_MAJOR 2) set(CMake_VERSION_MINOR 8) set(CMake_VERSION_PATCH 12) -set(CMake_VERSION_TWEAK 20131020) +set(CMake_VERSION_TWEAK 20131021) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-commits
