Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
On 06/19/2016 03:36 AM, Rolf Eike Beer wrote: > Version without stupid typo: > > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8345c6463d813fb39ee6a6dee5259ee18525c62c Thanks. I've queued this for merge to 'release' for 3.6. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
Am Samstag, 18. Juni 2016, 14:41:34 schrieb Rolf Eike Beer:
> Ben Boeckel wrote:
> > Hi,
> >
> > Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks
> > for that. However, it is hidden behind the check that pkg_check_modules
> >
> > uses to see if it already ran:
> > if (NOT DEFINED __pkg_config_checked_${_prefix} OR
> >
> > __pkg_config_checked_${_prefix} LESS ${PKG_CONFIG_VERSION} OR
> > NOT ${_prefix}_FOUND)
> >
> > which means that on the second configure, the target is not created
> > causing build faiures. Could you please look at reordering the logic so
> > that the imported target is always created (if requested)? Thanks.
> >
> > Brad, this is in the rc releases; what should be done? Block the
> > release, undocument the feature, or wait for a patch?
>
> Please check if
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3213b747a84a4e584e9edc6b
> d8c114b809b18bec fixes it for you.
Version without stupid typo:
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8345c6463d813fb39ee6a6dee5259ee18525c62c
signature.asc
Description: This is a digitally signed message part.
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
Ben Boeckel wrote:
> Hi,
>
> Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks
> for that. However, it is hidden behind the check that pkg_check_modules
> uses to see if it already ran:
>
> if (NOT DEFINED __pkg_config_checked_${_prefix} OR
> __pkg_config_checked_${_prefix} LESS ${PKG_CONFIG_VERSION} OR
> NOT ${_prefix}_FOUND)
>
> which means that on the second configure, the target is not created
> causing build faiures. Could you please look at reordering the logic so
> that the imported target is always created (if requested)? Thanks.
>
> Brad, this is in the rc releases; what should be done? Block the
> release, undocument the feature, or wait for a patch?
Please check if
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3213b747a84a4e584e9edc6bd8c114b809b18bec
fixes it for you.
Eike
--
signature.asc
Description: This is a digitally signed message part.
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
On Fri, Jun 17, 2016 at 15:40:45 +0200, Nils Gladitz wrote: > I have not been involved in that development. > From what I can tell this is Eike's work. Ack, sorry. Should have double checked. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
On 06/17/2016 09:40 AM, Nils Gladitz wrote: > On 06/17/2016 03:36 PM, Ben Boeckel wrote: >> Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks >> for that. However, it is hidden behind the check that pkg_check_modules >> uses to see if it already ran: > > From what I can tell this is Eike's work. Yes. On 06/17/2016 09:36 AM, Ben Boeckel wrote: > Brad, this is in the rc releases; what should be done? Block the > release, undocument the feature, or wait for a patch? Since it is a bug in a new feature a fix qualifies for inclusion in the release. If Eike can solve it soon (which is likely) then I'll include the fix. Otherwise I'd revert the feature. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
Am 2016-06-17 15:36, schrieb Ben Boeckel:
Hi,
Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks
for that. However, it is hidden behind the check that pkg_check_modules
uses to see if it already ran:
if (NOT DEFINED __pkg_config_checked_${_prefix} OR
__pkg_config_checked_${_prefix} LESS ${PKG_CONFIG_VERSION} OR
NOT ${_prefix}_FOUND)
which means that on the second configure, the target is not created
causing build faiures. Could you please look at reordering the logic so
that the imported target is always created (if requested)? Thanks.
Brad, this is in the rc releases; what should be done? Block the
release, undocument the feature, or wait for a patch?
I also have another todo for FindFreetype open which I must handle. I'll
do both over the weekend.
Greetings,
Eike
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
On 06/17/2016 03:36 PM, Ben Boeckel wrote: Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks for that. However, it is hidden behind the check that pkg_check_modules uses to see if it already ran: I have not been involved in that development. From what I can tell this is Eike's work. Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0
Hi,
Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks
for that. However, it is hidden behind the check that pkg_check_modules
uses to see if it already ran:
if (NOT DEFINED __pkg_config_checked_${_prefix} OR
__pkg_config_checked_${_prefix} LESS ${PKG_CONFIG_VERSION} OR
NOT ${_prefix}_FOUND)
which means that on the second configure, the target is not created
causing build faiures. Could you please look at reordering the logic so
that the imported target is always created (if requested)? Thanks.
Brad, this is in the rc releases; what should be done? Block the
release, undocument the feature, or wait for a patch?
--Ben
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
