Re: [cmake-developers] I: I want to become a maintainer of several modules.

2012-10-11 Thread Aleksey Avdeev 
05.10.2012 21:06, Brad King пишет:
> On 10/05/2012 08:29 AM, Aleksey Avdeev wrote:
>> I modified the proposed modules.
> 
> Thanks for working on them.  Let's start with FindIcotool since it
> is pretty simple and doesn't depend on the other modules.  After
> that we can move on to the others.  Please proceed with step 5
> of the new maintainer instructions:
> 
>  http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer
> 
> to get Git access.

  In the form of , who
is defined in the Reference (Name of someone who can verify that you
deserve the access you're requesting)?

> 
 1. FindIcotool
>> http://git.altlinux.org/people/solo/public/cmake-modules.git?p=cmake-modules.git;a=blob;f=Modules/FindIcotool.cmake;h=97543113756a72e59175c778eace0dc00220a1e0;hb=ea809d0c5b1cd36b83437043d916fd6eacc1dc5f
> 
> Good.  Please tweak the documentation:
> 
> (1) Remove the leading/first "#" line that is otherwise empty.

  Done.

> (2) Remove the " (since CMake 2.8.8)" note since the module was
> not in CMake 2.8.8.

  Done.

> 
> Also when the module is put in CMake the line
> 
>  include(FindPackageHandleStandardArgs)
> 
> will need to be
> 
>  include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)

  Done.

> 
>> Done. Value ICOTOOL_VERSION_STRING up over the output:
>>
>> icotool --version
> 
> The output parsing can be a bit simpler if you use the CMAKE_MATCH_1
> variable result from the "if(... MATCHES ...)" command.  It is
> mentioned at the bottom of the regex documentation in string():
> 
>  http://www.cmake.org/cmake/help/v2.8.9/cmake.html#command:string

  Yes, that is really better. Done.

  I ask to see the modified version:
.

-- 

Sincerely. Alex.




signature.asc
Description: OpenPGP digital signature
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] I: I want to become a maintainer of several modules.

2012-10-05 Thread Alan W. Irwin 

On 2012-10-05 13:06-0400 Brad King wrote:


The output parsing can be a bit simpler if you use the CMAKE_MATCH_1
variable result from the "if(... MATCHES ...)" command.  It is
mentioned at the bottom of the regex documentation in string():

http://www.cmake.org/cmake/help/v2.8.9/cmake.html#command:string


Hi Brad:

I was just looking over that documentation (obtained with
--help--full for CMake-2.8.9) when I spotted this
line which seemed to be problematic to me

  -Matches any character in range on either side of a dash

I assume this is meant to refer to regex bracket expressions such as
"[0-9]".  If so, some reference to square brackets should be included
so that regex newbies don't attempt to treat the "-" character like
the "+" character which can appear outside square brackets. Here is
one alternative to the above that addresses that issue:

  -Matches any character in range on either side of a dash
within square brackets, e.g.,
[abcx-z] matches "a", "b", "c", "x", "y", or "z", as does [a-cx-z]

(I took that example from the Wikipedia article on regular expressions).

But I am sure (from past experience) you will figure out something
shorter that still gets the idea across that - can only appear within
brackets.

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] I: I want to become a maintainer of several modules.

2012-10-05 Thread Brad King 
On 10/05/2012 08:29 AM, Aleksey Avdeev wrote:
> I modified the proposed modules.

Thanks for working on them.  Let's start with FindIcotool since it
is pretty simple and doesn't depend on the other modules.  After
that we can move on to the others.  Please proceed with step 5
of the new maintainer instructions:

 http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer

to get Git access.

>>> 1. FindIcotool
> http://git.altlinux.org/people/solo/public/cmake-modules.git?p=cmake-modules.git;a=blob;f=Modules/FindIcotool.cmake;h=97543113756a72e59175c778eace0dc00220a1e0;hb=ea809d0c5b1cd36b83437043d916fd6eacc1dc5f

Good.  Please tweak the documentation:

(1) Remove the leading/first "#" line that is otherwise empty.
(2) Remove the " (since CMake 2.8.8)" note since the module was
not in CMake 2.8.8.

Also when the module is put in CMake the line

 include(FindPackageHandleStandardArgs)

will need to be

 include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)

> Done. Value ICOTOOL_VERSION_STRING up over the output:
> 
> icotool --version

The output parsing can be a bit simpler if you use the CMAKE_MATCH_1
variable result from the "if(... MATCHES ...)" command.  It is
mentioned at the bottom of the regex documentation in string():

 http://www.cmake.org/cmake/help/v2.8.9/cmake.html#command:string

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] I: I want to become a maintainer of several modules.

2012-10-05 Thread Aleksey Avdeev 
12.07.2012 18:41, Brad King пишет:
> On 07/10/2012 06:12 PM, Aleksey Avdeev wrote:
>>   I maintainer of ALT Linux Team (see
>> ). Packaging italc2 (see
>> ), I made a few modules to
>> CMake. I think they will be useful not only to me:

  I modified the proposed modules.

> 
> Thanks for your interest in contributing!
> 
> A few general comments:
> 
> (1) Please convert the code in the modules to use lower-case commands.
> We are considering a "flag day" to massively convert all modules in
> CMake anyway, and your "git blame" credit will be preserved if the
> modules start lower case.

  Done.

> 
> (2) Please try putting the modules in CMake's source locally and check
> the output of "bin/cmake --help-module $mod" for each module.  Adjust
> the comments and documentation at the top of them to make the output
> look good.

  Done. Ask to check the result.

> 
>> 1. FindIcotool (see
>> )
>> -- find icotool

  See
.

> 
> Hard-coded paths like
> 
>  /bin
>  /usr/bin
>  /usr/local/bin
>  /sbin
>  /usr/sbin
>  /usr/local/sbin
> 
> should not be necessary.  The find_program() command already searches them.

  OK. Done.

> 
> Also, Eike (CCed) did a wonderful sweep recently to add version support to
> as many find modules as possible.  Please consider adding support to this
> module too, and update "Tests/CMakeOnly/AllFindModules/CMakeLists.txt" to
> verify it.

  Done. Value ICOTOOL_VERSION_STRING up over the output:

icotool --version

> 
>> 2. FreedesktopIconsMacros (see
>> )
>> -- define freedesktop.org standard for icons installation

  See
.

> 
> It looks like this extends the concept of GNUInstallDirs:
> 
>  
> http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/GNUInstallDirs.cmake;hb=v2.8.8

  Yes, variables and CMAKE_INSTALL_FREEDESKTOP_ICONS_BASE
CMAKE_INSTALL_FREEDESKTOP_ICONS_FULL_BASE would be logical to move the
module GNUInstallDirs. (Perhaps it is worth to use other, more standard
loya module variable names.) But I think that this issue is addressed
later, when the proposed unit will already be included in the code CMake.

> 
> Nice.  The documentation of the macros should mention their requirement
> on things like ICOTOOL_FOUND to work.

  Done. The documentation module added a description of its dependencies.

  Well done:

* Description MacOS FREEDESKTOP_INSTALL_ICONS moved to module documentation.

* In macros added checking of arguments.

> 
>> 3. MacroProcessManpages (see
>> )
>> -- find manpages in the given directory and install. (This module is
>> modified
>> .)

  See
.

> 
> Why do the names of the module and macro not match?
> Is the module name meant to include future macros too?

  The module name was inherited from the code Andreas Schneider. Renamed
InstallManpages.cmake.

> 
> The documentation should mention that the install destination
> is controlled by CMAKE_INSTALL_FULL_MANDIR from GNUInstallDirs.

  Done. Ask to check the result.

> 
> The macro should complain if there are extra arguments.  That will
> allow extension in the future with additional options.

  Done.

> 
> The GPL license block needs to be removed for distribution in CMake
> under our pure BSD license.  We'll need Andreas Schneider's permission.

  Done. Permission is obtained:

27.09.2012 16:45, Andreas Schneider wrote:
> You have the permission to license it under BSD.

-- 

Sincerely. Alex.




signature.asc
Description: OpenPGP digital signature
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:

Re: [cmake-developers] I: I want to become a maintainer of several modules.

2012-07-12 Thread Brad King 
On 07/10/2012 06:12 PM, Aleksey Avdeev wrote:
>   I maintainer of ALT Linux Team (see
> ). Packaging italc2 (see
> ), I made a few modules to
> CMake. I think they will be useful not only to me:

Thanks for your interest in contributing!

A few general comments:

(1) Please convert the code in the modules to use lower-case commands.
We are considering a "flag day" to massively convert all modules in
CMake anyway, and your "git blame" credit will be preserved if the
modules start lower case.

(2) Please try putting the modules in CMake's source locally and check
the output of "bin/cmake --help-module $mod" for each module.  Adjust
the comments and documentation at the top of them to make the output
look good.

> 1. FindIcotool (see
> )
> -- find icotool

Hard-coded paths like

 /bin
 /usr/bin
 /usr/local/bin
 /sbin
 /usr/sbin
 /usr/local/sbin

should not be necessary.  The find_program() command already searches them.

Also, Eike (CCed) did a wonderful sweep recently to add version support to
as many find modules as possible.  Please consider adding support to this
module too, and update "Tests/CMakeOnly/AllFindModules/CMakeLists.txt" to
verify it.

> 2. FreedesktopIconsMacros (see
> )
> -- define freedesktop.org standard for icons installation

It looks like this extends the concept of GNUInstallDirs:

 
http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/GNUInstallDirs.cmake;hb=v2.8.8

Nice.  The documentation of the macros should mention their requirement
on things like ICOTOOL_FOUND to work.

> 3. MacroProcessManpages (see
> )
> -- find manpages in the given directory and install. (This module is
> modified
> .)

Why do the names of the module and macro not match?
Is the module name meant to include future macros too?

The documentation should mention that the install destination
is controlled by CMAKE_INSTALL_FULL_MANDIR from GNUInstallDirs.

The macro should complain if there are extra arguments.  That will
allow extension in the future with additional options.

The GPL license block needs to be removed for distribution in CMake
under our pure BSD license.  We'll need Andreas Schneider's permission.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

[cmake-developers] I: I want to become a maintainer of several modules.

2012-07-11 Thread Aleksey Avdeev 
Hi, Team.

  I maintainer of ALT Linux Team (see
). Packaging italc2 (see
), I made a few modules to
CMake. I think they will be useful not only to me:

1. FindIcotool (see
)
-- find icotool

2. FreedesktopIconsMacros (see
)
-- define freedesktop.org standard for icons installation

3. MacroProcessManpages (see
)
-- find manpages in the given directory and install. (This module is
modified
.)

These modules are used in the package italc2-2.0.1-alt5
(see