Re: [cmake-developers] Java support
On 08/21/2015 09:50 AM, Brad King wrote: UseJava: Add support for javah tool http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4476feac There is still one failure on the dashboard but I think it is related to the way the run is configured rather than a problem with the source. Once I've worked that out I'll report back. That has been resolved. I've merged the above change to 'master'. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 08/18/2015 02:57 AM, CHEVRIER, Marc wrote: Unfortunately I don't have access to an HP-UX system. For reference, we worked out the problem off-list with someone that has access to HP-UX. The fix is: HP-UX: Do not use .sl extension for shared libs on Itanium http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=625225bb I've rebased the java topic on a version containing the fix: UseJava: Add support for javah tool http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4476feac There is still one failure on the dashboard but I think it is related to the way the run is configured rather than a problem with the source. Once I've worked that out I'll report back. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Thank you. Unfortunately I don’t have access to an HP-UX system. From what I remember, HP-UX expect shared libraries with same name pattern as Linux except that extension is .sl rather than .so. Marc On 14/08/15 15:45, Brad King brad.k...@kitware.com wrote: On 08/07/2015 04:04 AM, CHEVRIER, Marc wrote: New version of patch attached. Thanks. Applied with a few tweaks: UseJava: Add support for javah tool http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cae7bef9 However, it fails on some HP-UX machines because Java does not know how to load the native library we produce. Does anyone know what name HP-UX is expecting (I don't have access to it myself)? -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 08/07/2015 04:04 AM, CHEVRIER, Marc wrote: New version of patch attached. Thanks. Applied with a few tweaks: UseJava: Add support for javah tool http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cae7bef9 However, it fails on some HP-UX machines because Java does not know how to load the native library we produce. Does anyone know what name HP-UX is expecting (I don't have access to it myself)? -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Hi, New version of patch attached. I added a check on java tool to execute test only if java and shared library built by test have same architecture (32 or 64bit). Marc On 05/08/15 17:49, Brad King brad.k...@kitware.com wrote: On 08/05/2015 03:15 AM, CHEVRIER, Marc wrote: For point 2., The best approach is to install 32 and 64bit versions of Java SDK (Windows versions, not some cygwin or MSYS versions) and ensure JAVA_HOME is NOT set in the environment nor referenced in the PATH. In this case, CMake FindJava.cmake module will look at the registry to retrieve the correct java version. CMake's test suite needs to adapt to the environment in which it is run and not run this test unless the architecture of java and the toolchain match. Certainly we can set up an environment in which it works but we should not fail just because that hasn't been done. On 08/05/2015 06:24 AM, CHEVRIER, Marc wrote: Again, a new version for patch 4. Thanks. I'd prefer not to enable CXX as a language in the project() command such that it affects the other Java tests. Please create a separate source tree for the new test. Sorry I didn't notice this earlier. Meanwhile the other three patches now tested cleanly. Thanks, -Brad 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Hi, For point 1. I completely forgot to test with VS generators… I will work on that ASAP. For point 2., The best approach is to install 32 and 64bit versions of Java SDK (Windows versions, not some cygwin or MSYS versions) and ensure JAVA_HOME is NOT set in the environment nor referenced in the PATH. In this case, CMake FindJava.cmake module will look at the registry to retrieve the correct java version. Marc On 04/08/15 17:42, Brad King brad.k...@kitware.com wrote: On 08/04/2015 04:45 AM, CHEVRIER, Marc wrote: Attached is a new version of patch 4 tested successfully on Linux (SuSE 11.3), Windows (7 64bit) and MacOS (10.10.4) Thanks. This still fails for me on Windows with a VS generator for two reasons: 1. The java.library.path setting points at the build directory but not at the per-configuration subdirectory in which VS generators place the .dll file. I was able to hack around this locally by extending Tests/Java/CMakeLists.txt with: set_property(TARGET B PROPERTY RUNTIME_OUTPUT_DIRECTORY_DEBUG .) though more work may be needed to work with other configs. 2. With the above hack it still fails because java produces 32-bit binaries but I was using a 64-bit toolchain so the plugin cannot load. How are we to control the architecture for which java compiles? Meanwhile I revised the other three commits: FindJava: Add support for idlj and jarsigner tools http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e72806fb UseJava: Teach add_jar to support file syntax for sources http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d287de4 UseJava: Teach install_jar new DESTINATION and COMPONENT options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cc23f0e9 We need to run the tests each in their own build tree or they try to clobber each other during parallel testing. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Hi, Again, a new version for patch 4. I hope I didn’t miss anything this time. :) To handle VS generators, I am relying on generator-expressions supported by add_test function. Marc On 04/08/15 17:42, Brad King brad.k...@kitware.com wrote: On 08/04/2015 04:45 AM, CHEVRIER, Marc wrote: Attached is a new version of patch 4 tested successfully on Linux (SuSE 11.3), Windows (7 64bit) and MacOS (10.10.4) Thanks. This still fails for me on Windows with a VS generator for two reasons: 1. The java.library.path setting points at the build directory but not at the per-configuration subdirectory in which VS generators place the .dll file. I was able to hack around this locally by extending Tests/Java/CMakeLists.txt with: set_property(TARGET B PROPERTY RUNTIME_OUTPUT_DIRECTORY_DEBUG .) though more work may be needed to work with other configs. 2. With the above hack it still fails because java produces 32-bit binaries but I was using a 64-bit toolchain so the plugin cannot load. How are we to control the architecture for which java compiles? Meanwhile I revised the other three commits: FindJava: Add support for idlj and jarsigner tools http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e72806fb UseJava: Teach add_jar to support file syntax for sources http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d287de4 UseJava: Teach install_jar new DESTINATION and COMPONENT options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cc23f0e9 We need to run the tests each in their own build tree or they try to clobber each other during parallel testing. -Brad 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 08/05/2015 03:15 AM, CHEVRIER, Marc wrote: For point 2., The best approach is to install 32 and 64bit versions of Java SDK (Windows versions, not some cygwin or MSYS versions) and ensure JAVA_HOME is NOT set in the environment nor referenced in the PATH. In this case, CMake FindJava.cmake module will look at the registry to retrieve the correct java version. CMake's test suite needs to adapt to the environment in which it is run and not run this test unless the architecture of java and the toolchain match. Certainly we can set up an environment in which it works but we should not fail just because that hasn't been done. On 08/05/2015 06:24 AM, CHEVRIER, Marc wrote: Again, a new version for patch 4. Thanks. I'd prefer not to enable CXX as a language in the project() command such that it affects the other Java tests. Please create a separate source tree for the new test. Sorry I didn't notice this earlier. Meanwhile the other three patches now tested cleanly. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Thanks. I will have a look for the patch 4. Marc On 03/08/15 22:17, Brad King brad.k...@kitware.com wrote: On 07/31/2015 04:08 AM, CHEVRIER, Marc wrote: New version of patches. Thanks. I applied the first three with minor tweaks and merged to 'next' for testing: FindJava: Add support for idlj and jarsigner tools http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e499264 UseJava: Teach add_jar to support file syntax for sources http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=244e9364 UseJava: Teach install_jar new DESTINATION and COMPONENT options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8f8d824d The 0004 patch (create_javah) fails testing for me on Linux: $ ctest -R Java.Javah -V ... 261: Running test command: /usr/lib/jvm/java-7-openjdk-amd64/bin/java -classpath hello3.jar HelloWorld2 261: Test command failed: /usr/lib/jvm/java-7-openjdk-amd64/bin/java 261: Native code library failed to load. 261: java.lang.UnsatisfiedLinkError: no B in java.library.path ... Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Attached is a new version of patch 4 tested successfully on Linux (SuSE 11.3), Windows (7 64bit) and MacOS (10.10.4) Marc On 03/08/15 22:17, Brad King brad.k...@kitware.com wrote: On 07/31/2015 04:08 AM, CHEVRIER, Marc wrote: New version of patches. Thanks. I applied the first three with minor tweaks and merged to 'next' for testing: FindJava: Add support for idlj and jarsigner tools http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e499264 UseJava: Teach add_jar to support file syntax for sources http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=244e9364 UseJava: Teach install_jar new DESTINATION and COMPONENT options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8f8d824d The 0004 patch (create_javah) fails testing for me on Linux: $ ctest -R Java.Javah -V ... 261: Running test command: /usr/lib/jvm/java-7-openjdk-amd64/bin/java -classpath hello3.jar HelloWorld2 261: Test command failed: /usr/lib/jvm/java-7-openjdk-amd64/bin/java 261: Native code library failed to load. 261: java.lang.UnsatisfiedLinkError: no B in java.library.path ... Thanks, -Brad 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 08/04/2015 04:45 AM, CHEVRIER, Marc wrote: Attached is a new version of patch 4 tested successfully on Linux (SuSE 11.3), Windows (7 64bit) and MacOS (10.10.4) Thanks. This still fails for me on Windows with a VS generator for two reasons: 1. The java.library.path setting points at the build directory but not at the per-configuration subdirectory in which VS generators place the .dll file. I was able to hack around this locally by extending Tests/Java/CMakeLists.txt with: set_property(TARGET B PROPERTY RUNTIME_OUTPUT_DIRECTORY_DEBUG .) though more work may be needed to work with other configs. 2. With the above hack it still fails because java produces 32-bit binaries but I was using a 64-bit toolchain so the plugin cannot load. How are we to control the architecture for which java compiles? Meanwhile I revised the other three commits: FindJava: Add support for idlj and jarsigner tools http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e72806fb UseJava: Teach add_jar to support file syntax for sources http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d287de4 UseJava: Teach install_jar new DESTINATION and COMPONENT options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cc23f0e9 We need to run the tests each in their own build tree or they try to clobber each other during parallel testing. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 07/31/2015 04:08 AM, CHEVRIER, Marc wrote: New version of patches. Thanks. I applied the first three with minor tweaks and merged to 'next' for testing: FindJava: Add support for idlj and jarsigner tools http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e499264 UseJava: Teach add_jar to support file syntax for sources http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=244e9364 UseJava: Teach install_jar new DESTINATION and COMPONENT options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8f8d824d The 0004 patch (create_javah) fails testing for me on Linux: $ ctest -R Java.Javah -V ... 261: Running test command: /usr/lib/jvm/java-7-openjdk-amd64/bin/java -classpath hello3.jar HelloWorld2 261: Test command failed: /usr/lib/jvm/java-7-openjdk-amd64/bin/java 261: Native code library failed to load. 261: java.lang.UnsatisfiedLinkError: no B in java.library.path ... Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
OK. New version of patches. There is now a component per extra tool (for now IdlJ and JarSigner as suggested by Brad) to ensure future extensibility. Marc On 30/07/15 16:49, Brad King brad.k...@kitware.com wrote: On 07/30/2015 09:55 AM, CHEVRIER, Marc wrote: here is the correct version. Thanks. The component name Extra sounds too generic and we won't be able to extend it in the future with other extra parts for the same reason these tools could not be made part of Development. Perhaps instead we should have components named IdlJ and JarSigner that applications can use to enforce that they are found. Thanks, -Brad 0001-Add-support-for-idlj-and-jarsigner-tools.patch Description: 0001-Add-support-for-idlj-and-jarsigner-tools.patch 0002-add_jar-now-supports-file-syntax-for-sources.patch Description: 0002-add_jar-now-supports-file-syntax-for-sources.patch 0003-install_jar-add-options-DESTINATION-and-COMPONENT.patch Description: 0003-install_jar-add-options-DESTINATION-and-COMPONENT.patch 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
I just detected a small error introduced in patch 0001, here is the correct version. Sorry for the noise... On 30/07/15 11:32, cmake-developers on behalf of CHEVRIER, Marc cmake-developers-boun...@cmake.org on behalf of marc.chevr...@sap.com wrote: New version of patches taking into account Brad’ remarks. Marc On 29/07/15 15:47, Brad King brad.k...@kitware.com wrote: On 07/29/2015 04:01 AM, CHEVRIER, Marc wrote: here is an updated list of patches. Great. find_package_handle_standard_args(Java REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE + Java_IDLJ_EXECUTABLE Java_JARSIGNER_EXECUTABLE VERSION_VAR Java_VERSION ) Are idlj and jarsigner reliably available whenever the other tools are? Even for older versions? Do these need to be REQUIRED_VARS? I'm concerned this could make a case that previously found java not report it found anymore. - --build-project hello + --build-target hello The tests should still have --build-project as this corresponds to the .sln file name in Visual Studio builds. The --build-target option can be added in addition to it. Thanks, -Brad 0001-Add-support-for-idlj-and-jarsigner-tools.patch Description: 0001-Add-support-for-idlj-and-jarsigner-tools.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 07/30/2015 09:55 AM, CHEVRIER, Marc wrote: here is the correct version. Thanks. The component name Extra sounds too generic and we won't be able to extend it in the future with other extra parts for the same reason these tools could not be made part of Development. Perhaps instead we should have components named IdlJ and JarSigner that applications can use to enforce that they are found. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
New version of patches taking into account Brad’ remarks. Marc On 29/07/15 15:47, Brad King brad.k...@kitware.com wrote: On 07/29/2015 04:01 AM, CHEVRIER, Marc wrote: here is an updated list of patches. Great. find_package_handle_standard_args(Java REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE + Java_IDLJ_EXECUTABLE Java_JARSIGNER_EXECUTABLE VERSION_VAR Java_VERSION ) Are idlj and jarsigner reliably available whenever the other tools are? Even for older versions? Do these need to be REQUIRED_VARS? I'm concerned this could make a case that previously found java not report it found anymore. - --build-project hello + --build-target hello The tests should still have --build-project as this corresponds to the .sln file name in Visual Studio builds. The --build-target option can be added in addition to it. Thanks, -Brad 0001-Add-support-for-idlj-and-jarsigner-tools.patch Description: 0001-Add-support-for-idlj-and-jarsigner-tools.patch 0002-add_jar-now-supports-file-syntax-for-sources.patch Description: 0002-add_jar-now-supports-file-syntax-for-sources.patch 0003-install_jar-add-options-DESTINATION-and-COMPONENT.patch Description: 0003-install_jar-add-options-DESTINATION-and-COMPONENT.patch 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Hi, You are right. @ must be matching at the beginning of the item. But I need .* in the expression because I use regex matching group to retrieve filename. Anyway, here is an updated list of patches. Marc On 29/07/15 09:25, cmake-developers on behalf of Rolf Eike Beer cmake-developers-boun...@cmake.org on behalf of e...@sf-mail.de wrote: Am Dienstag, 28. Juli 2015, 08:15:01 schrieb CHEVRIER, Marc: Hi, 0002 (UseJava.cmake): Extends add_jar command to support @file syntax for java sources specification. You do not need leading or trailing .* in regular expressions. In fact I think your expression should simply be ^@, otherwise you would match an @ at any position in the argument name, which does not look intended. Greetings, Eike 0001-Add-support-for-idlj-and-jarsigner-tools.patch Description: 0001-Add-support-for-idlj-and-jarsigner-tools.patch 0002-add_jar-now-supports-file-syntax-for-sources.patch Description: 0002-add_jar-now-supports-file-syntax-for-sources.patch 0003-install_jar-Add-options-DESTINATION-and-COMPONENT.patch Description: 0003-install_jar-Add-options-DESTINATION-and-COMPONENT.patch 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Am Dienstag, 28. Juli 2015, 08:15:01 schrieb CHEVRIER, Marc: Hi, 0002 (UseJava.cmake): Extends add_jar command to support @file syntax for java sources specification. You do not need leading or trailing .* in regular expressions. In fact I think your expression should simply be ^@, otherwise you would match an @ at any position in the argument name, which does not look intended. Greetings, Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
On 07/29/2015 04:01 AM, CHEVRIER, Marc wrote: here is an updated list of patches. Great. find_package_handle_standard_args(Java REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE + Java_IDLJ_EXECUTABLE Java_JARSIGNER_EXECUTABLE VERSION_VAR Java_VERSION ) Are idlj and jarsigner reliably available whenever the other tools are? Even for older versions? Do these need to be REQUIRED_VARS? I'm concerned this could make a case that previously found java not report it found anymore. - --build-project hello + --build-target hello The tests should still have --build-project as this corresponds to the .sln file name in Visual Studio builds. The --build-target option can be added in addition to it. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Java support
Thanks for your comments. To address your first remark, I propose to introduce a new component (‘Extra', for example) to manage these new tools. For example: find_package (Java COMPONENTS Development Extra) I think it is better than removing new variables as required because this approach will require some explicit check to ensure these tools are found before usage. Regarding your second remark, I will update my patches. Marc On 29/07/15 15:47, Brad King brad.k...@kitware.com wrote: On 07/29/2015 04:01 AM, CHEVRIER, Marc wrote: here is an updated list of patches. Great. find_package_handle_standard_args(Java REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE + Java_IDLJ_EXECUTABLE Java_JARSIGNER_EXECUTABLE VERSION_VAR Java_VERSION ) Are idlj and jarsigner reliably available whenever the other tools are? Even for older versions? Do these need to be REQUIRED_VARS? I'm concerned this could make a case that previously found java not report it found anymore. - --build-project hello + --build-target hello The tests should still have --build-project as this corresponds to the .sln file name in Visual Studio builds. The --build-target option can be added in addition to it. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Java support
Hi, Here are some patches to enhance Java support. 0001 (FindJava.cmake): Defines now two new variables for idlj and jar signer tools: Java_IDLJ_EXECUTABLE and Java_JARSIGNER_EXECUTABLE 0002 (UseJava.cmake): Extends add_jar command to support @file syntax for java sources specification. 0003 (UseJava.cmake): Extends install_jar and install_jni_symlink commands to support options DESTINATION and COMPONENT as alternative to actual syntax. 0004 (UseJava.cmake): Add new command create_javah to wrap java tool javah. I also extends tests to support these extensions. This is my first contribution, so be indulgent if something is wrong… ;) Marc Chevrier 0001-Add-support-for-idlj-and-jarsigner-tools.patch Description: 0001-Add-support-for-idlj-and-jarsigner-tools.patch 0002-add_jar-now-supports-file-syntax-for-sources.patch Description: 0002-add_jar-now-supports-file-syntax-for-sources.patch 0003-install_jar-Add-options-DESTINATION-and-COMPONENT.patch Description: 0003-install_jar-Add-options-DESTINATION-and-COMPONENT.patch 0004-Add-support-for-javah-tool.patch Description: 0004-Add-support-for-javah-tool.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
