Re: [cmake-developers] [RFC] Remove `-i` from the build command for makefile generators
On 05/06/2015 02:32 PM, Ben Boeckel wrote: I really question the old behavior at all (it's not like it made things magically work), but OK :/ . I'd be OK with replacing it with `-k` without a policy though (it does the same thing but makes the exit code...useful). IIRC when use of -i was introduced we actually used -k first and found it to be inadequate for the needs at the time. Since requirements seem to have changed I think switching to -k is okay. Heh. We were setting MAKECOMMAND, but using ctest_build. Seems the documentation could use some sprucing up :) . See the MakeCommand setting here: http://www.cmake.org/cmake/help/v3.2/manual/ctest.1.html#ctest-build-step It explains both CTEST_BUILD_COMMAND and MAKECOMMAND. What is missing is that ctest_build docs: http://www.cmake.org/cmake/help/v3.2/command/ctest_build.html should reference CTEST_BUILD_COMMAND. Please add that. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RFC] Remove `-i` from the build command for makefile generators
On Thu, May 07, 2015 at 13:06:26 -0400, Ben Boeckel wrote: Merged as update-ctest_build-docs. Thanks for the followup commit for clarifying the docs. I hit the problem where CTEST_BUILD_COMMAND makes CTEST_BUILD_FLAGS get ignored. The new wording makes it much clearer :) . --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RFC] Remove `-i` from the build command for makefile generators
On Thu, May 07, 2015 at 09:12:43 -0400, Brad King wrote: IIRC when use of -i was introduced we actually used -k first and found it to be inadequate for the needs at the time. Since requirements seem to have changed I think switching to -k is okay. I've merged this into next as replace-make--i. Heh. We were setting MAKECOMMAND, but using ctest_build. Seems the documentation could use some sprucing up :) . See the MakeCommand setting here: http://www.cmake.org/cmake/help/v3.2/manual/ctest.1.html#ctest-build-step It explains both CTEST_BUILD_COMMAND and MAKECOMMAND. What is missing is that ctest_build docs: http://www.cmake.org/cmake/help/v3.2/command/ctest_build.html should reference CTEST_BUILD_COMMAND. Please add that. Merged as update-ctest_build-docs. Thanks, --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RFC] Remove `-i` from the build command for makefile generators
On Wed, May 06, 2015 at 13:53:42 -0400, Brad King wrote: On 05/05/2015 04:11 PM, Ben Boeckel wrote: Does anyone have any issue with remove `-i` from the implicit flags from makefile generators with the build command (ctest_build)? We can change it with explicit options to the relevant commands and also add a policy to change the default (leaving the explicit options as a way to enable the old behavior). I really question the old behavior at all (it's not like it made things magically work), but OK :/ . I'd be OK with replacing it with `-k` without a policy though (it does the same thing but makes the exit code...useful). There are two places that do this: * The build_command() command is called by the CTest module to initialize the MAKECOMMAND cache entry. This is used by 'ctest -M $mode -T Build' to drive the build of an existing tree. This can be overridden by setting the cache entry manually. * The ctest_build() command generates the build command line. This can be overridden by setting CTEST_BUILD_COMMAND in the script before calling ctest_build(). These days it just needs to be something like cmake --build . --config Debug. Heh. We were setting MAKECOMMAND, but using ctest_build. Seems the documentation could use some sprucing up :) . Both cases call GenerateCMakeBuildCommand on the global generator to generate the cmake --build command line. Yeah, I found that; I have a local branch which excises the `-i` altogether ;) . --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [RFC] Remove `-i` from the build command for makefile generators
On 05/05/2015 04:11 PM, Ben Boeckel wrote: Does anyone have any issue with remove `-i` from the implicit flags from makefile generators with the build command (ctest_build)? We can change it with explicit options to the relevant commands and also add a policy to change the default (leaving the explicit options as a way to enable the old behavior). There are two places that do this: * The build_command() command is called by the CTest module to initialize the MAKECOMMAND cache entry. This is used by 'ctest -M $mode -T Build' to drive the build of an existing tree. This can be overridden by setting the cache entry manually. * The ctest_build() command generates the build command line. This can be overridden by setting CTEST_BUILD_COMMAND in the script before calling ctest_build(). These days it just needs to be something like cmake --build . --config Debug. Both cases call GenerateCMakeBuildCommand on the global generator to generate the cmake --build command line. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
