Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 01:02 PM, David Cole wrote: > We should (maybe I will if I get time to spend on it) write a test that > executes something like this command: > > $ git grep -E "[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9].*cmPolicies" > Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); > Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); > Source/cmPolicies.cxx:2,8,11,20130724, cmPolicies::WARN); > > And make sure the results are empty-ish... Then if somebody does this > later on, it will be a test failure. Robert and I are adding a check like git grep 2.8.11.20.. to the release process to look for cases that need a version comparison update (where 2.8.11 is the existing release). That will catch Source/cmPolicies.cxx lines too. If you can add a test to catch the cmPolicies entries earlier that would be even better. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
We should (maybe I will if I get time to spend on it) write a test that executes something like this command: $ git grep -E "[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9].*cmPolicies" Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); Source/cmPolicies.cxx:2,8,11,20130516, cmPolicies::WARN); Source/cmPolicies.cxx:2,8,11,20130724, cmPolicies::WARN); And make sure the results are empty-ish... Then if somebody does this later on, it will be a test failure. D -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 11:14 AM, Stephen Kelly wrote: > It's not very pretty though for the final release to tell people that they > should install '2.8.11.20130626 or later' instead of '2.8.12 or later', > which is what we really intend to communicate. Okay, I'll bump that version at the same time as the CMakeVersion.cmake information when creating the release branch. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 11:09 AM, Stephen Kelly wrote: > That breaks the ExportImport unit test, because is is used in a > version_greater check and the version bump to 2.8.12 is only in the release > branch. As I hinted in my sibling response this check can remain on a 2.8.11. version. > We sort-of discussed this before: > > http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6442 I think the if(POLICY) testing approach is cleaner than the advice I gave there. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
Brad King wrote: > On 08/14/2013 11:00 AM, Brad King wrote: >> On 08/14/2013 10:59 AM, Stephen Kelly wrote: >>> Brad King wrote: I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. >>> >>> You missed the version in >>> >>> Source/cmExportInstallFileGenerator.cxx >>> >>> See commit 574fec97fd011 >> >> Please extend the topic to fix that. I'll squash it later. > > That version doesn't need to be 2.8.12, does it? It needs only > to be a version new enough to understand the generated content. > The current value should be okay, no? Yes. It's not very pretty though for the final release to tell people that they should install '2.8.11.20130626 or later' instead of '2.8.12 or later', which is what we really intend to communicate. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
Brad King wrote: > On 08/14/2013 10:59 AM, Stephen Kelly wrote: >> Brad King wrote: >>> I added a commit to update the versions: >>> >>> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec >>> >>> I'll have to re-create the release branch tomorrow after this >>> is tested. >>> >> >> You missed the version in >> >> Source/cmExportInstallFileGenerator.cxx >> >> See commit 574fec97fd011 > > Please extend the topic to fix that. I'll squash it later. That breaks the ExportImport unit test, because is is used in a version_greater check and the version bump to 2.8.12 is only in the release branch. We sort-of discussed this before: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6442 Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 11:00 AM, Brad King wrote: > On 08/14/2013 10:59 AM, Stephen Kelly wrote: >> Brad King wrote: >>> I added a commit to update the versions: >>> >>> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec >>> >>> I'll have to re-create the release branch tomorrow after this >>> is tested. >>> >> >> You missed the version in >> >> Source/cmExportInstallFileGenerator.cxx >> >> See commit 574fec97fd011 > > Please extend the topic to fix that. I'll squash it later. That version doesn't need to be 2.8.12, does it? It needs only to be a version new enough to understand the generated content. The current value should be okay, no? -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 10:59 AM, Stephen Kelly wrote: > Brad King wrote: >> I added a commit to update the versions: >> >> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec >> >> I'll have to re-create the release branch tomorrow after this >> is tested. >> > > You missed the version in > > Source/cmExportInstallFileGenerator.cxx > > See commit 574fec97fd011 Please extend the topic to fix that. I'll squash it later. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
Brad King wrote: > I added a commit to update the versions: > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec > > I'll have to re-create the release branch tomorrow after this > is tested. > You missed the version in Source/cmExportInstallFileGenerator.cxx See commit 574fec97fd011 Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Version number updates for 2.8.12
On 08/14/2013 09:14 AM, Stephen Kelly wrote: > I pushed a branch updating the version number of new policies and a version > number generated in export files a few months ago. I just left it as a > reminder to bump merge the bumps at RC time. The branch was deleted soon > after though. > > Is the release branch going to get a similar change for the RC1? The policies should have been added with 2.8.12 as their version originally. The way to test that in other projects is to add if(POLICY CMP0023) cmake_policy(SET CMP0023 NEW) endif() to your code instead of depending on cmake_minimum_required to set it. I should have caught that during review but forgot. I added a commit to update the versions: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07c16eec I'll have to re-create the release branch tomorrow after this is tested. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
