[GitHub] trafodion pull request #1369: TRAFODION-2877 can't restart DCSServer when sw...

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1369#discussion_r159811900
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/master/ServerManager.java ---
@@ -240,15 +240,14 @@ public ScriptContext call() throws Exception {
 }
 }
 } else {
-if (LOG.isDebugEnabled())
-LOG.debug("No restart for "
-+ znodePath
-+ "\nbecause DcsServer start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(serverStartTimestamp))
-+ "] was before DcsMaster start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(startupTimestamp)) + "]");
+LOG.info("No restart for "
--- End diff --

You are right, I should change the log, thanks.


---

[GitHub] trafodion pull request #1368: [TRAFODION-2876] suppress the output of color ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1368


---

[GitHub] trafodion pull request #1369: TRAFODION-2877 can't restart DCSServer when sw...

[DaveBirdsall]

Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1369#discussion_r159806194
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/master/ServerManager.java ---
@@ -240,15 +240,14 @@ public ScriptContext call() throws Exception {
 }
 }
 } else {
-if (LOG.isDebugEnabled())
-LOG.debug("No restart for "
-+ znodePath
-+ "\nbecause DcsServer start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(serverStartTimestamp))
-+ "] was before DcsMaster start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(startupTimestamp)) + "]");
+LOG.info("No restart for "
--- End diff --

RIght... My point was that the text in the logging seems to need updating, 
because the 'if' conditions have changed. What do you think?


---

[GitHub] trafodion pull request #1311: [TRAFODION-2818] For Server 2008, function pow...

[Weixin-Xu]

Github user Weixin-Xu commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1311#discussion_r159803669
  
--- Diff: win-odbc64/odbcclient/drvr35/sqltocconv.cpp ---
@@ -36,6 +36,36 @@
 
 #define MAXCHARLEN 32768 //32K
 
+// for server2008 when using function pow() then throws 
STATUS_ILLEGAL_INSTRUCTION
+double pow(int base, short power, unsigned long *error)
+{
+   DWORD dwVersion = 0;
+   DWORD dwBuild = 0;
+
+   dwVersion = GetVersion();
+
+   // Get the build number.
+
+   if (dwVersion < 0x8000)
+   dwBuild = (DWORD)(HIWORD(dwVersion));
+
+   double retValue = 1;
--- End diff --

Alright, I will change it, but is it return code meaningful when judging 
pow succeeded or not with return Value.


---

[GitHub] trafodion pull request #1297: Add "or edition" to error info 4222

[sumory]

Github user sumory closed the pull request at:

https://github.com/apache/trafodion/pull/1297


---

[GitHub] trafodion pull request #1369: TRAFODION-2877 can't restart DCSServer when sw...

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1369#discussion_r159793870
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/master/ServerManager.java ---
@@ -240,15 +240,14 @@ public ScriptContext call() throws Exception {
 }
 }
 } else {
-if (LOG.isDebugEnabled())
-LOG.debug("No restart for "
-+ znodePath
-+ "\nbecause DcsServer start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(serverStartTimestamp))
-+ "] was before DcsMaster start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(startupTimestamp)) + "]");
+LOG.info("No restart for "
--- End diff --

yes . if backup-master take over from the failed master, then the 
'isFollower' is true, the result will be the code does not run the if 
conditions, and dcs server not restart


---

[GitHub] trafodion pull request #1371: [TRAFODION-2863] Web-page style sheets should ...

[svarnau]

GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1371

[TRAFODION-2863] Web-page style sheets should be protocol relative

To be compatible with http or https

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1371


commit 98a07c3f1e5843b061d197a6427400f521d793dd
Author: Steve Varnau 
Date:   2018-01-04T23:02:01Z

[TRAFODION-2863] Web-page style sheets should be protocol relative

To be compatible with http or https




---

[GitHub] trafodion pull request #1370: [TRAFODION-2861][TRAFODION-2869] Remove incuba...

[svarnau]

GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1370

[TRAFODION-2861][TRAFODION-2869] Remove incubating from release packaging

Remove disclaimer file and incubating string from packaging file names.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion pkg-tlp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1370


commit 34bf83acb40350b646b1e906445423b2c041412f
Author: Steve Varnau 
Date:   2018-01-04T20:07:47Z

[TRAFODION-2861][TRAFODION-2869] Remove incubating from release packaging

Remove disclaimer file and incubating string from packaging file names.




---

[GitHub] trafodion pull request #1366: [TRAFODION-2865] Update Messages Guide for mes...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1366


---

[GitHub] trafodion pull request #1361: [TRAFODION-2866] Add HBase Configuration Chang...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1361


---

[GitHub] trafodion pull request #1369: TRAFODION-2877 can't restart DCSServer when sw...

[DaveBirdsall]

Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1369#discussion_r159730607
  
--- Diff: dcs/src/main/java/org/trafodion/dcs/master/ServerManager.java ---
@@ -240,15 +240,14 @@ public ScriptContext call() throws Exception {
 }
 }
 } else {
-if (LOG.isDebugEnabled())
-LOG.debug("No restart for "
-+ znodePath
-+ "\nbecause DcsServer start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(serverStartTimestamp))
-+ "] was before DcsMaster start time ["
-+ DateFormat.getDateTimeInstance().format(
-new Date(startupTimestamp)) + "]");
+LOG.info("No restart for "
--- End diff --

Looks like there is another reason for no restart, namely 
(master.isFollower() && runningServers.size() < configuredServers.size()) ?


---

[GitHub] trafodion pull request #1311: [TRAFODION-2818] For Server 2008, function pow...

[selvaganesang]

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1311#discussion_r159497520
  
--- Diff: win-odbc64/odbcclient/drvr35/sqltocconv.cpp ---
@@ -36,6 +36,36 @@
 
 #define MAXCHARLEN 32768 //32K
 
+// for server2008 when using function pow() then throws 
STATUS_ILLEGAL_INSTRUCTION
+double pow(int base, short power, unsigned long *error)
+{
+   DWORD dwVersion = 0;
+   DWORD dwBuild = 0;
+
+   dwVersion = GetVersion();
+
+   // Get the build number.
+
+   if (dwVersion < 0x8000)
+   dwBuild = (DWORD)(HIWORD(dwVersion));
+
+   double retValue = 1;
--- End diff --

Please consider setting *error to 0 here for non-error condition


---

[GitHub] trafodion pull request #1361: [TRAFODION-2866] Add HBase Configuration Chang...

[liuyu000]

Github user liuyu000 commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1361#discussion_r159642419
  
--- Diff: docs/provisioning_guide/src/asciidoc/_chapters/requirements.adoc 
---
@@ -331,13 +331,38 @@ default. Depending on the size of a user table, we 
have experienced timeout fail
 from this setting. The underlying issue is the length of the execution of 
the coprocessor within HBase.
  +
 NOTE: HBase uses the smaller of `hbase.rpc.timeout` and 
`hbase.client.scanner.timeout.period` to calculate the scanner timeout. 
-| hbase.snapshot.master.timeoutMillis and hbase.snapshot.region.timeout | 
10 minutes | HBase's default setting is 6 milliseconds. 
+| hbase.snapshot.master.timeoutMillis 
+
+and 
+
+hbase.snapshot.region.timeout | 10 minutes | HBase's default setting is 
6 milliseconds. 
 If you experience timeout issues with HBase snapshots when you use the 
{project-name} Bulk Loader or other statements, 
 you can set the value for these two HBase properties to 10 minutes 
(600,000 milliseconds).
-| hbase.hregion.max.filesize | 107374182400 bytes | HBase's default 
setting is 10737418240 (10 GB). We have increased the setting to 
-107374182400 (100 GB), which reduces the number of HStoreFiles per table 
and appears to reduce disruptions to active transactions from 
+| hbase.hregion.max.filesize | 107374182400 bytes | HBase's default 
setting is 10737418240 bytes (10 GB). You can increased the setting to 
--- End diff --

Oops, sorry, I've corrected, thanks Dave :)


---