[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

2020-05-19 Thread GitBox 


ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427648246



##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
 """Upload a file to Azure Blob Storage."""
 hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
 self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
   Oh gotcha. I mean you are already changing this, so it's going to 
conflict anyway.
   
   Potato potato.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

2020-05-19 Thread GitBox 


ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427586701



##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
 """Upload a file to Azure Blob Storage."""
 hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
 self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
   The fix here is to do
   
   ```python
   self.log.info(
   'Uploading %s to wasb://%s as %s',
   self.file_path, self.container_name, self.blob_name)
   ```
   
   That way if the logging level is disabled, no time is wasted formatting the 
string





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

2020-05-18 Thread GitBox 


ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r426896828



##
File path: .github/workflows/ci.yml
##
@@ -123,7 +123,7 @@ jobs:
 run: ./scripts/ci/ci_free_space_on_ci.sh
   - name: "Build CI image ${{ matrix.python-version }}"
 run: ./scripts/ci/ci_prepare_image_on_ci.sh
-  - name: "Tests"
+  - ame: "Tests"

Review comment:
   Na it's like. oh fu..





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

2020-05-18 Thread GitBox 


ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r426895275



##
File path: .github/workflows/ci.yml
##
@@ -123,7 +123,7 @@ jobs:
 run: ./scripts/ci/ci_free_space_on_ci.sh
   - name: "Build CI image ${{ matrix.python-version }}"
 run: ./scripts/ci/ci_prepare_image_on_ci.sh
-  - name: "Tests"
+  - ame: "Tests"

Review comment:
   Whopsie :)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org