[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[ https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931337#comment-16931337 ] ASF GitHub Bot commented on AIRFLOW-5343: - ashb commented on pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling URL: https://github.com/apache/airflow/pull/6034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > pool_pre_ping support for SQLAlchemy connection > --- > > Key: AIRFLOW-5343 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5343 > Project: Apache Airflow > Issue Type: Task > Components: configuration >Affects Versions: 1.10.4 >Reporter: Igor Khrol >Priority: Minor > Fix For: 1.10.6 > > > SQLalchemy supports connection check while returning it from the pool. There > is a need to allow this parameter (`pool_pre_ping`) while creating the > connection to database. > > [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic] > [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[ https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931338#comment-16931338 ] ASF subversion and git services commented on AIRFLOW-5343: -- Commit bc826070e15658cc182da5091b6a0f26eb2bc141 in airflow's branch refs/heads/master from Igor Khrol [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=bc82607 ] [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling (#6034) Based on discussions in https://github.com/apache/airflow/pull/5949 it was figured out that there is already pessimistic disconnect timeout handling. So instead of hand-written one only SQLAlchemy embedded way should be used. 'sqlalchemy~=1.3' is in `setup.py` requirements and `pool_pre_ping` appeared in SQLAlchemy 1.2. > pool_pre_ping support for SQLAlchemy connection > --- > > Key: AIRFLOW-5343 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5343 > Project: Apache Airflow > Issue Type: Task > Components: configuration >Affects Versions: 1.10.4 >Reporter: Igor Khrol >Priority: Minor > Fix For: 1.10.6 > > > SQLalchemy supports connection check while returning it from the pool. There > is a need to allow this parameter (`pool_pre_ping`) while creating the > connection to database. > > [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic] > [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[
https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924283#comment-16924283
]
ASF GitHub Bot commented on AIRFLOW-5343:
-
Khrol commented on pull request #6034: [AIRFLOW-5343] Remove legacy way of
pessimistic disconnect handling
URL: https://github.com/apache/airflow/pull/6034
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5343
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Based on discussions in https://github.com/apache/airflow/pull/5949
it was figured out that there is already pessimistic disconnect
timeout handling. So instead of hand-written one only SQLAlchemy
embedded way should be used.
'sqlalchemy~=1.3' is in `setup.py` requirements and `pool_pre_ping`
appeared in SQLAlchemy 1.2.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> pool_pre_ping support for SQLAlchemy connection
> ---
>
> Key: AIRFLOW-5343
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5343
> Project: Apache Airflow
> Issue Type: Task
> Components: configuration
>Affects Versions: 1.10.4
>Reporter: Igor Khrol
>Priority: Minor
> Fix For: 1.10.6
>
>
> SQLalchemy supports connection check while returning it from the pool. There
> is a need to allow this parameter (`pool_pre_ping`) while creating the
> connection to database.
>
> [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic]
> [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189]
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[ https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924071#comment-16924071 ] ASF subversion and git services commented on AIRFLOW-5343: -- Commit fdeed0c996b2a32331c99d1d7f59caa42ec2baae in airflow's branch refs/heads/v1-10-test from Igor Khrol [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=fdeed0c ] [AIRFLOW-5343] Add pool_pre_ping to SQLAlchemy (#5949) SQLalchemy supports connection check while returning it from the pool. There is a need to allow this parameter (`pool_pre_ping`) while creating the connection to database. More info here: https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic (cherry picked from commit a44e5762c394b59566e757c9c20cb3f9fd7851eb) > pool_pre_ping support for SQLAlchemy connection > --- > > Key: AIRFLOW-5343 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5343 > Project: Apache Airflow > Issue Type: Task > Components: configuration >Affects Versions: 1.10.4 >Reporter: Igor Khrol >Priority: Minor > > SQLalchemy supports connection check while returning it from the pool. There > is a need to allow this parameter (`pool_pre_ping`) while creating the > connection to database. > > [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic] > [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[ https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924070#comment-16924070 ] ASF subversion and git services commented on AIRFLOW-5343: -- Commit a44e5762c394b59566e757c9c20cb3f9fd7851eb in airflow's branch refs/heads/master from Igor Khrol [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a44e576 ] [AIRFLOW-5343] Add pool_pre_ping to SQLAlchemy (#5949) SQLalchemy supports connection check while returning it from the pool. There is a need to allow this parameter (`pool_pre_ping`) while creating the connection to database. More info here: https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic > pool_pre_ping support for SQLAlchemy connection > --- > > Key: AIRFLOW-5343 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5343 > Project: Apache Airflow > Issue Type: Task > Components: configuration >Affects Versions: 1.10.4 >Reporter: Igor Khrol >Priority: Minor > > SQLalchemy supports connection check while returning it from the pool. There > is a need to allow this parameter (`pool_pre_ping`) while creating the > connection to database. > > [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic] > [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[ https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924069#comment-16924069 ] ASF GitHub Bot commented on AIRFLOW-5343: - ashb commented on pull request #5949: [AIRFLOW-5343] Add pool_pre_ping to SQLAlchemy URL: https://github.com/apache/airflow/pull/5949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > pool_pre_ping support for SQLAlchemy connection > --- > > Key: AIRFLOW-5343 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5343 > Project: Apache Airflow > Issue Type: Task > Components: configuration >Affects Versions: 1.10.4 >Reporter: Igor Khrol >Priority: Minor > > SQLalchemy supports connection check while returning it from the pool. There > is a need to allow this parameter (`pool_pre_ping`) while creating the > connection to database. > > [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic] > [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189] > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection
[
https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918626#comment-16918626
]
ASF GitHub Bot commented on AIRFLOW-5343:
-
Khrol commented on pull request #5949: [AIRFLOW-5343] Add pool_pre_ping to
SQLAlchemy
URL: https://github.com/apache/airflow/pull/5949
SQLalchemy supports connection check while returning it from the pool. There
is a need to allow this parameter (`pool_pre_ping`) while creating the
connection to database.
More info here:
https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> pool_pre_ping support for SQLAlchemy connection
> ---
>
> Key: AIRFLOW-5343
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5343
> Project: Apache Airflow
> Issue Type: Task
> Components: configuration
>Affects Versions: 1.10.4
>Reporter: Igor Khrol
>Priority: Minor
>
> SQLalchemy supports connection check while returning it from the pool. There
> is a need to allow this parameter (`pool_pre_ping`) while creating the
> connection to database.
>
> [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic]
> [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189]
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
