[jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
[
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951263#comment-16951263
]
ASF subversion and git services commented on AIRFLOW-5387:
--
Commit 2ed422a0c969594f52fec6248b617250b8863930 in airflow's branch
refs/heads/v1-10-stable from Alejandro Rojas
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2ed422a ]
[AIRFLOW-5387] Fix show paused pagination bug (#6100)
(cherry picked from commit 93bb5e44d8ede09d3301f29de15121901ba010f4)
> Pagination is broken when the config variable hide_paused_dags_by_default is
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
> Fix For: 1.10.6
>
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
> v = kwargs['showPaused']
> if v or v is None:
> kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True,
> removing the parameter showPaused disable access to the correct paginated
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only
> "active" DAGs are presented.
> Fix:
> - showPaused parameter should not be removed and therefore lines 68 to 71
> (included) could be removed.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
[
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951054#comment-16951054
]
ASF subversion and git services commented on AIRFLOW-5387:
--
Commit 2ed422a0c969594f52fec6248b617250b8863930 in airflow's branch
refs/heads/v1-10-test from Alejandro Rojas
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2ed422a ]
[AIRFLOW-5387] Fix show paused pagination bug (#6100)
(cherry picked from commit 93bb5e44d8ede09d3301f29de15121901ba010f4)
> Pagination is broken when the config variable hide_paused_dags_by_default is
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
> Fix For: 1.10.6
>
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
> v = kwargs['showPaused']
> if v or v is None:
> kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True,
> removing the parameter showPaused disable access to the correct paginated
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only
> "active" DAGs are presented.
> Fix:
> - showPaused parameter should not be removed and therefore lines 68 to 71
> (included) could be removed.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
[
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950935#comment-16950935
]
ASF subversion and git services commented on AIRFLOW-5387:
--
Commit d4f265dc1424f804294943e5b61846a5d077e539 in airflow's branch
refs/heads/v1-10-test from Alejandro Rojas
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d4f265d ]
[AIRFLOW-5387] Fix show paused pagination bug (#6100)
(cherry picked from commit 93bb5e44d8ede09d3301f29de15121901ba010f4)
> Pagination is broken when the config variable hide_paused_dags_by_default is
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
> Fix For: 1.10.6
>
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
> v = kwargs['showPaused']
> if v or v is None:
> kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True,
> removing the parameter showPaused disable access to the correct paginated
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only
> "active" DAGs are presented.
> Fix:
> - showPaused parameter should not be removed and therefore lines 68 to 71
> (included) could be removed.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
[
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947000#comment-16947000
]
ASF subversion and git services commented on AIRFLOW-5387:
--
Commit 93bb5e44d8ede09d3301f29de15121901ba010f4 in airflow's branch
refs/heads/master from Alejandro Rojas
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=93bb5e4 ]
[AIRFLOW-5387] Fix show paused pagination bug (#6100)
> Pagination is broken when the config variable hide_paused_dags_by_default is
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
> v = kwargs['showPaused']
> if v or v is None:
> kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True,
> removing the parameter showPaused disable access to the correct paginated
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only
> "active" DAGs are presented.
> Fix:
> - showPaused parameter should not be removed and therefore lines 68 to 71
> (included) could be removed.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
[
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946999#comment-16946999
]
ASF GitHub Bot commented on AIRFLOW-5387:
-
feluelle commented on pull request #6100: [AIRFLOW-5387] Fix show paused
pagination bug
URL: https://github.com/apache/airflow/pull/6100
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pagination is broken when the config variable hide_paused_dags_by_default is
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
> v = kwargs['showPaused']
> if v or v is None:
> kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True,
> removing the parameter showPaused disable access to the correct paginated
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only
> "active" DAGs are presented.
> Fix:
> - showPaused parameter should not be removed and therefore lines 68 to 71
> (included) could be removed.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5387) Pagination is broken when the config variable hide_paused_dags_by_default is set to True because showPaused variable is removed
[
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929381#comment-16929381
]
ASF GitHub Bot commented on AIRFLOW-5387:
-
alrolorojas commented on pull request #6100: [AIRFLOW-5387] Fix show paused
pagination bug
URL: https://github.com/apache/airflow/pull/6100
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-5387) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5387
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pagination is broken when the config variable hide_paused_dags_by_default is
> set to True because showPaused variable is removed
> ---
>
> Key: AIRFLOW-5387
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.4
>Reporter: Guillem Lefait
>Assignee: Alejandro
>Priority: Minor
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
> if 'showPaused' in kwargs:
> v = kwargs['showPaused']
> if v or v is None:
> kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True,
> removing the parameter showPaused disable access to the correct paginated
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only
> "active" DAGs are presented.
> Fix:
> - showPaused parameter should not be removed and therefore lines 68 to 71
> (included) could be removed.
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
