[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219944#comment-17219944 ] ASF subversion and git services commented on AIRFLOW-6585: -- Commit 24e21528646e05d2776e01ee48554b4990670a20 in airflow's branch refs/heads/master from Marian Cepok [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=24e2152 ] [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader (#11219) Co-authored-by: Jan Brusch Co-authored-by: Marian Cepok > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > Fix For: 2.0.0 > > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219939#comment-17219939 ] ASF GitHub Bot commented on AIRFLOW-6585: - boring-cyborg[bot] commented on pull request #11219: URL: https://github.com/apache/airflow/pull/11219#issuecomment-715595262 Awesome work, congrats on your first merged pull request! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219940#comment-17219940 ] ASF subversion and git services commented on AIRFLOW-6585: -- Commit 24e21528646e05d2776e01ee48554b4990670a20 in airflow's branch refs/heads/master from Marian Cepok [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=24e2152 ] [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader (#11219) Co-authored-by: Jan Brusch Co-authored-by: Marian Cepok > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > Fix For: 2.0.0 > > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219938#comment-17219938 ] ASF GitHub Bot commented on AIRFLOW-6585: - ashb merged pull request #11219: URL: https://github.com/apache/airflow/pull/11219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216525#comment-17216525 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on a change in pull request #11219: URL: https://github.com/apache/airflow/pull/11219#discussion_r507554283 ## File path: airflow/kubernetes/refresh_config.py ## @@ -24,15 +24,22 @@ import logging import os import time -from datetime import datetime from typing import Optional +import pendulum import yaml from kubernetes.client import Configuration from kubernetes.config.exec_provider import ExecProvider from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader +def _parse_timestamp(ts_str: str) -> int: +parsed_dt = pendulum.parse(ts_str) +if isinstance(parsed_dt, pendulum.DateTime): Review comment: Ah, yes, cast sounds like it was made exactly for cases like this. Never heard about it before. I adjusted the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216477#comment-17216477 ] ASF GitHub Bot commented on AIRFLOW-6585: - ashb commented on a change in pull request #11219: URL: https://github.com/apache/airflow/pull/11219#discussion_r507490408 ## File path: airflow/kubernetes/refresh_config.py ## @@ -24,15 +24,22 @@ import logging import os import time -from datetime import datetime from typing import Optional +import pendulum import yaml from kubernetes.client import Configuration from kubernetes.config.exec_provider import ExecProvider from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader +def _parse_timestamp(ts_str: str) -> int: +parsed_dt = pendulum.parse(ts_str) +if isinstance(parsed_dt, pendulum.DateTime): Review comment: Ah, `cast` from the typing module or a `# type:` comment is probably the way to go then This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216458#comment-17216458 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on pull request #11219: URL: https://github.com/apache/airflow/pull/11219#issuecomment-711599501 @ashb is this ok or do you want a different approach regarding pendulum? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[
https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211703#comment-17211703
]
ASF GitHub Bot commented on AIRFLOW-6585:
-
mcepok commented on a change in pull request #11219:
URL: https://github.com/apache/airflow/pull/11219#discussion_r502790203
##
File path: tests/kubernetes/test_refresh_config.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from unittest import TestCase
+
+from airflow.kubernetes.refresh_config import _parse_timestamp
+
+
+class TestRefreshKubeConfigLoader(TestCase):
+
+def test_parse_timestamp_should_convert_z_timezone_to_unix_timestamp(self):
+ts = _parse_timestamp("2020-01-13T13:42:20Z")
+self.assertEqual(1578922940, ts)
+
+def
test_parse_timestamp_should_convert_regular_timezone_to_unix_timestamp(self):
Review comment:
Sure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timestamp bug in RefreshKubeConfigLoader
>
>
> Key: AIRFLOW-6585
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6585
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes, executors, hooks
>Affects Versions: 1.10.7
>Reporter: Jan Brusch
>Assignee: Jan Brusch
>Priority: Major
>
> When using the KubernetesPodOperator on an aws kubernetes cluster, the
> aws-iam-authenticator is used to obtain kubernetes authentication tokens. The
> aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in
> case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting
> the "Z" timezone into a regular "+" format.
> Upon further review this is only a problem with python version <= 3.6. But
> that should not keep the issue from being fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211702#comment-17211702 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on a change in pull request #11219: URL: https://github.com/apache/airflow/pull/11219#discussion_r502790183 ## File path: airflow/kubernetes/refresh_config.py ## @@ -24,15 +24,22 @@ import logging import os import time -from datetime import datetime from typing import Optional +import pendulum import yaml from kubernetes.client import Configuration from kubernetes.config.exec_provider import ExecProvider from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader +def _parse_timestamp(ts_str: str) -> int: +parsed_dt = pendulum.parse(ts_str) +if isinstance(parsed_dt, pendulum.DateTime): Review comment: The problem is, that pendulum.parse type annotations says it return `typing.Union[Date, Time, DateTime, Duration]`, however not all of these implement `timetuple()`. One of the CI tests (I guess it was mypy) yelled at me for not covering the other possible return types. I was not able to find an input string which didn't result in either a parser error or in a return type DateTime so it doesn't really matter I guess. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[
https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211678#comment-17211678
]
ASF GitHub Bot commented on AIRFLOW-6585:
-
ashb commented on a change in pull request #11219:
URL: https://github.com/apache/airflow/pull/11219#discussion_r502780828
##
File path: airflow/kubernetes/refresh_config.py
##
@@ -24,15 +24,22 @@
import logging
import os
import time
-from datetime import datetime
from typing import Optional
+import pendulum
import yaml
from kubernetes.client import Configuration
from kubernetes.config.exec_provider import ExecProvider
from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION,
KubeConfigLoader
+def _parse_timestamp(ts_str: str) -> int:
+parsed_dt = pendulum.parse(ts_str)
+if isinstance(parsed_dt, pendulum.DateTime):
Review comment:
What's this for? Doesn't pendulum throw an error if it can't parse?
##
File path: tests/kubernetes/test_refresh_config.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from unittest import TestCase
+
+from airflow.kubernetes.refresh_config import _parse_timestamp
+
+
+class TestRefreshKubeConfigLoader(TestCase):
+
+def test_parse_timestamp_should_convert_z_timezone_to_unix_timestamp(self):
+ts = _parse_timestamp("2020-01-13T13:42:20Z")
+self.assertEqual(1578922940, ts)
+
+def
test_parse_timestamp_should_convert_regular_timezone_to_unix_timestamp(self):
Review comment:
Could you test an error condition too?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timestamp bug in RefreshKubeConfigLoader
>
>
> Key: AIRFLOW-6585
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6585
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes, executors, hooks
>Affects Versions: 1.10.7
>Reporter: Jan Brusch
>Assignee: Jan Brusch
>Priority: Major
>
> When using the KubernetesPodOperator on an aws kubernetes cluster, the
> aws-iam-authenticator is used to obtain kubernetes authentication tokens. The
> aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in
> case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting
> the "Z" timezone into a regular "+" format.
> Upon further review this is only a problem with python version <= 3.6. But
> that should not keep the issue from being fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207993#comment-17207993 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on pull request #11219: URL: https://github.com/apache/airflow/pull/11219#issuecomment-703555661 @ashb you reviewed this before. Can you have a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205335#comment-17205335 ] ASF GitHub Bot commented on AIRFLOW-6585: - boring-cyborg[bot] commented on pull request #11219: URL: https://github.com/apache/airflow/pull/11219#issuecomment-701949674 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst) Here are some useful points: - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices). Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205334#comment-17205334 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok opened a new pull request #11219: URL: https://github.com/apache/airflow/pull/11219 # Jira https://issues.apache.org/jira/browse/AIRFLOW-6585 # Description This is basically #7153 which I extended by using pendulum to parse time strings as asked in https://github.com/apache/airflow/pull/7153#pullrequestreview-389880157 . Since that PR is closed I opened a new one. **Original description:** When using the KubernetesPodOperator on an aws kubernetes cluster, the aws-iam-authenticator is used to obtain kubernetes authentication tokens. The aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in case of a "Z" (Zulu Time) timezone. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204613#comment-17204613 ] ASF GitHub Bot commented on AIRFLOW-6585: - ramsesrm commented on pull request #7153: URL: https://github.com/apache/airflow/pull/7153#issuecomment-701286290 Hi, this is still an issue on Airflow v1.10.12. Can we reopen the PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194895#comment-17194895 ] ASF GitHub Bot commented on AIRFLOW-6585: - stale[bot] closed pull request #7153: URL: https://github.com/apache/airflow/pull/7153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194854#comment-17194854 ] ASF GitHub Bot commented on AIRFLOW-6585: - stale[bot] closed pull request #7153: URL: https://github.com/apache/airflow/pull/7153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193974#comment-17193974 ] ASF GitHub Bot commented on AIRFLOW-6585: - stale[bot] closed pull request #7153: URL: https://github.com/apache/airflow/pull/7153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189157#comment-17189157 ] ASF GitHub Bot commented on AIRFLOW-6585: - stale[bot] commented on pull request #7153: URL: https://github.com/apache/airflow/pull/7153#issuecomment-685636420 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160600#comment-17160600 ] ASF GitHub Bot commented on AIRFLOW-6585: - potiuk commented on pull request #7153: URL: https://github.com/apache/airflow/pull/7153#issuecomment-660606783 @benjaminsky -> sure, would you mind picking this up? I think this one neds rebase and there is a change requested. Unnless (@Bruschkov wants to do it). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160599#comment-17160599 ] ASF GitHub Bot commented on AIRFLOW-6585: - Bruschkov opened a new pull request #7153: URL: https://github.com/apache/airflow/pull/7153 ## JIRA https://issues.apache.org/jira/browse/AIRFLOW-6585 ## Description When using the KubernetesPodOperator on an aws kubernetes cluster, the aws-iam-authenticator is used to obtain kubernetes authentication tokens. The aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting the "Z" timezone into a regular "+" format. Upon further review this is only a problem with python version <= 3.6. But that should not keep the issue from being fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160247#comment-17160247 ] ASF GitHub Bot commented on AIRFLOW-6585: - benjaminsky commented on pull request #7153: URL: https://github.com/apache/airflow/pull/7153#issuecomment-660366371 This is still an issue with EKS and Airflow v1.10.10. This PR fixes it. Can we reopen this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120372#comment-17120372 ] ASF GitHub Bot commented on AIRFLOW-6585: - stale[bot] closed pull request #7153: URL: https://github.com/apache/airflow/pull/7153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114950#comment-17114950 ] ASF GitHub Bot commented on AIRFLOW-6585: - stale[bot] commented on pull request #7153: URL: https://github.com/apache/airflow/pull/7153#issuecomment-633143064 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks >Affects Versions: 1.10.7 >Reporter: Jan Brusch >Assignee: Jan Brusch >Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
