[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991578#comment-15991578 ] ASF GitHub Bot commented on BEAM-1676: -- Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/2799 > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > Fix For: First stable release > > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990737#comment-15990737 ] ASF GitHub Bot commented on BEAM-1676: -- GitHub user staslev opened a pull request: https://github.com/apache/beam/pull/2799 [BEAM-1676] Internalize ClassPath from Guava 21.0. Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/staslev/beam BEAM-1676-api-surface-tests-fail-with-spaces-in-dir-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2799.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2799 commit 0624a70bd824c82219107e1a1594aafe7383e993 Author: Stas LevinDate: 2017-04-30T10:56:40Z [BEAM-1676] Internalize ClassPath from Guava 21.0 to fix the failures related to having whitespaces in resource names. > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990572#comment-15990572 ] Davor Bonaci commented on BEAM-1676: This is the best path forward, almost certainly. Fixed Guava requires (or, will require) Java 8, which we may not be ready to upgrade to. So, waiting for a Guava fix is not the right strategy, and we should move from the Guava implementation somewhere else. If there's no other good, easy-to-use, lean library that provides this, we should just re-implement/copy-paste Guava's code. No worries from the licensing perspective; it's Apache 2-licensed code. > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990193#comment-15990193 ] Stas Levin commented on BEAM-1676: -- We can internalise (euphemism for copy-paste) the fixed {{ClassPath}} class implementation from the {{Guava}} master, and use it within {{ApiSurface}} (by keeping it private to {{ApiSurface}} it should prevent any clashes with the other {{ClassPath}} class residing in the current {{Guava}} version). I have played with it briefly and it looks ok. What do you think? > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975461#comment-15975461 ] Mark Liu commented on BEAM-1676: [~staslev] Looks like Guava 21.0 (the one we'll upgrade to) only support Java 8 (https://github.com/google/guava/releases). Afaik, Beam Java still supports Java lower version. Is possible to have a walk around solution in Beam? > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952864#comment-15952864 ] Jason Kuster commented on BEAM-1676: Briefly chatted with [~dhalp...@google.com] -- he seemed to be under the impression that grabbing the next version of Guava was going to be difficult for Java8-related issues. Dan, can you elaborate and provide guidance here? > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948913#comment-15948913 ] Stas Levin commented on BEAM-1676: -- This has recently been fixed in {{Guava}}'s [master|https://github.com/google/guava/commit/896c51abd32e136621c13d56b6130d0a72f4957a]. We should probably grab the next release (22?) once it's out. > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1676) SdkCoreApiSurfaceTest Failed When Directory Contains Space
[ https://issues.apache.org/jira/browse/BEAM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931625#comment-15931625 ] Stas Levin commented on BEAM-1676: -- Good catch [~markflyhigh], looks like it has to do with [this issue in the JDK|http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4466485], which comes into play [here|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ApiSurface.java#L353] in {{ApiSurface}} which uses Guava's {{ClassPath}} utility. Further investigation will need to take a deeper look to see if this needs to be fixed on the {{Beam}} level, or the {{Guava}} level. > SdkCoreApiSurfaceTest Failed When Directory Contains Space > -- > > Key: BEAM-1676 > URL: https://issues.apache.org/jira/browse/BEAM-1676 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Mark Liu >Assignee: Stas Levin > > Test failed if build directory contains space. For example: "~/dir with > space/beam/..." > The failure happened on Jenkins and can be reproduced from local. > GcpApiSurfaceTest may have same problem. > error is: > {code} > Failed tests: > SdkCoreApiSurfaceTest.testSdkApiSurface:59 > Expected: API surface to include only: > Classes in package "org.apache.beam" > Classes in package "com.google.api.client" > Classes in package "com.google.api.services.bigquery" > Classes in package "com.google.api.services.cloudresourcemanager" > Classes in package "com.google.api.services.pubsub" > Classes in package "com.google.api.services.storage" > Classes in package "com.google.auth" > Classes in package "com.google.protobuf" > Classes in package "com.fasterxml.jackson.annotation" > Classes in package "com.fasterxml.jackson.core" > Classes in package "com.fasterxml.jackson.databind" > Classes in package "org.apache.avro" > Classes in package "org.hamcrest" > Classes in package "org.codehaus.jackson" > Classes in package "org.joda.time" > Classes in package "org.junit" > > but: The following white-listed scopes did not have matching classes on > the API surface: > No Classes in package "com.fasterxml.jackson.annotation" > No Classes in package "com.fasterxml.jackson.core" > No Classes in package "com.fasterxml.jackson.databind" > No Classes in package "com.google.api.client" > No Classes in package "com.google.api.services.bigquery" > No Classes in package "com.google.api.services.cloudresourcemanager" > No Classes in package "com.google.api.services.pubsub" > No Classes in package "com.google.api.services.storage" > No Classes in package "com.google.auth" > No Classes in package "com.google.protobuf" > No Classes in package "org.apache.avro" > No Classes in package "org.apache.beam" > No Classes in package "org.codehaus.jackson" > No Classes in package "org.hamcrest" > No Classes in package "org.joda.time" > No Classes in package "org.junit" > {code} > Job link from Jenkins: > https://builds.apache.org/job/beam_PostCommit_Java_Version_Test/14/ > One of the Jenkins job uses "JDK 1.8 (latest)" which is also part of project > directory. -- This message was sent by Atlassian JIRA (v6.3.15#6346)