[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219448#comment-16219448
 ] 

Kenneth Knowles commented on BEAM-3092:
---

Sorry, my last comment was incorrect. The problem was not missing exclusions, 
nor was it sensitivity to $PWD. The problem was a combination of these:

1. We previously cloned directly into {{$workspace}} - this caused a bunch of 
funky stuff like {{.repository}} to look like it was part of our codebase, but 
was not
2. We switched to clone into {{$workspace/src}} - this actually worked fine
3. The seed job ran at an old commit, restoring the old behavior of cloning 
into the root - now the {{$workspace/src}} looked like it is part of our 
codebase because it was left in the Jenkins workspace

It is resolved, all jobs are seeded at the latest commit and clone into an 
isolated directory. Probably the changes to the RAT config were not necessary 
as it already had the right exclusions and also seems to read {{.gitignore}}, 
judging by its log output.

> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
> Fix For: Not applicable
>
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218033#comment-16218033
 ] 

ASF GitHub Bot commented on BEAM-3092:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/4027


> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218026#comment-16218026
 ] 

Kenneth Knowles commented on BEAM-3092:
---

As it turns out, the problem was simply missing exclusions. It appeared that 
the prior failures were caused by {{.github/PULL_REQUEST_TEMPLATE.md}} but it 
is demonstrably not the case, since that particular line of exclusion is 
unchanged in successful runs.

> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215916#comment-16215916
 ] 

Kenneth Knowles commented on BEAM-3092:
---

It turns out having Jenkins clone into the same directory as all our other 
stuff made this problem worse. We have exclusions for things like 
{{.repository}} which are not even part of our repository or built artifacts. 
When we discovered that we had to add exclusions for things that were actually 
not part of our source or build tree, that is our hint that we really must 
clone to a directory that Jenkins isn't going to drop random things in.

> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215810#comment-16215810
 ] 

ASF GitHub Bot commented on BEAM-3092:
--

GitHub user kennknowles opened a pull request:

https://github.com/apache/beam/pull/4027

[BEAM-3092] Fix RAT plugin configuration

Follow this checklist to help us incorporate your contribution quickly and 
easily:

 - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
 - [x] Each commit in the pull request should have a meaningful subject 
line and body.
 - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
 - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
 - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
 - [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/beam RAT

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/4027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4027


commit 57c1e57d5e7d78e5b0ca3b1d434ea4b528da036a
Author: Kenneth Knowles 
Date:   2017-10-23T19:36:38Z

Rearrange .gitignore slightly

commit dfb6a6c75ff2fca342bf0695cdd547c03f04148c
Author: Kenneth Knowles 
Date:   2017-10-23T20:26:08Z

Make pom.xml match .gitignore

commit 3e045eeef67a2218559743904099c2e329203481
Author: Kenneth Knowles 
Date:   2017-10-23T20:26:27Z

Manage RAT plugin more centrally; only toggle skipping




> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215706#comment-16215706
 ] 

Kenneth Knowles commented on BEAM-3092:
---

Looks like the universe of files to check respects {{${basedir}}} but the 
exclusions do not.

> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3092) RAT configuration is sensitive to $PWD

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215704#comment-16215704
 ] 

Kenneth Knowles commented on BEAM-3092:
---

The docs on the RAT plugin look like it should default to correctly using 
`${basedir}` so there might be some further thing going on.

> RAT configuration is sensitive to $PWD
> --
>
> Key: BEAM-3092
> URL: https://issues.apache.org/jira/browse/BEAM-3092
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Blocker
>
> This is currently breaking the build, as our Jenkins config does the 
> equivalent of {{mvn -f src/pom.xml}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)