[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105745=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105745
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:49
Start Date: 24/May/18 21:49
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391876253
Merging in the interest of moving things slightly better. _If_ our current
release process is mostly right, _then_ this PR fixes it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105745)
Time Spent: 2h 10m (was: 2h)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105744=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105744
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:49
Start Date: 24/May/18 21:49
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5472: [BEAM-4393]:
Copy root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build_rules.gradle b/build_rules.gradle
index ff070d3aaa8..c3cf20d8ee2 100644
--- a/build_rules.gradle
+++ b/build_rules.gradle
@@ -547,6 +547,10 @@ ext.applyJavaNature = {
shadowJar ({
classifier = "shaded"
mergeServiceFiles()
+into("META-INF/") {
+ from "${rootProject.projectDir}/LICENSE"
+ from "${rootProject.projectDir}/NOTICE"
+}
} << configuration.shadowClosure)
// Always configure the shadowTestJar classifier and merge service files.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105744)
Time Spent: 2h (was: 1h 50m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105742=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105742
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:48
Start Date: 24/May/18 21:48
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391875802
Yea, OK. I didn't mean this PR is wrong. It seems this PR does put the
LICENSE in the actual thing we want to ship to users. I guess the rest has to
do with the release process.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105742)
Time Spent: 1h 50m (was: 1h 40m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105741=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105741
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:46
Start Date: 24/May/18 21:46
Worklog Time Spent: 10m
Work Description: boyuanzz commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391875106
I didn't find any Jar{} closure so far in
https://github.com/apache/beam/blob/master/build_rules.gradle, which means, we
possibly use the default configuration. I'm not sure whether we need LICENSE in
Jar.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105741)
Time Spent: 1h 40m (was: 1.5h)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105736
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:37
Start Date: 24/May/18 21:37
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391870925
That seems like a problem. The shadowJar is the real thing and the "normal"
jar is just an intermediate calculation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105736)
Time Spent: 1.5h (was: 1h 20m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105735=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105735
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:36
Start Date: 24/May/18 21:36
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391870925
That seems wrong. The shadowJar is the real thing and the "normal" jar is
just an intermediate calculation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105735)
Time Spent: 1h 20m (was: 1h 10m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105734=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105734
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:35
Start Date: 24/May/18 21:35
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391870562
I believe we run the jar rule to build a jar with only our code, then we run
the shadowJar rule to bundle that jar with third party code. This only needs to
be in shadowJar, but that leaves our code in jar without a LICENSE file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105734)
Time Spent: 1h 10m (was: 1h)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105732=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105732
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:32
Start Date: 24/May/18 21:32
Worklog Time Spent: 10m
Work Description: boyuanzz commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391869880
Hey @apilloud , my understanding so far is, we use shadowJar to rewrite Jar.
How do you feel like? @lukecwik
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105732)
Time Spent: 1h (was: 50m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105726
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 21:22
Start Date: 24/May/18 21:22
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5472: [BEAM-4393]: Copy
root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472#issuecomment-391867608
LGTM! I verified that this fixes BEAM-4393.
Only one question: should this go in jar instead of shadowJar?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105726)
Time Spent: 50m (was: 40m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105719=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105719
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 20:59
Start Date: 24/May/18 20:59
Worklog Time Spent: 10m
Work Description: boyuanzz opened a new pull request #5472: [BEAM-4393]:
Copy root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472
r: @kennknowles
cc: @apilloud
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105719)
Time Spent: 40m (was: 0.5h)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[ https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105599=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105599 ] ASF GitHub Bot logged work on BEAM-4393: Author: ASF GitHub Bot Created on: 24/May/18 13:55 Start Date: 24/May/18 13:55 Worklog Time Spent: 10m Work Description: kennknowles closed pull request #5461: [BEAM-4393] :Appending lacked LICENSE of shaded dependencies URL: https://github.com/apache/beam/pull/5461 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE b/LICENSE index d6456956733..4dda9e3e5dd 100644 --- a/LICENSE +++ b/LICENSE @@ -200,3 +200,102 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + A part of several convenience binary distributions of this software is licensed as follows: + + Google Protobuf: + Copyright 2008 Google Inc. All rights reserved. + + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions are + met: + + * Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above + copyright notice, this list of conditions and the following disclaimer + in the documentation and/or other materials provided with the + distribution. + * Neither the name of Google Inc. nor the names of its + contributors may be used to endorse or promote products derived from + this software without specific prior written permission. + + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + Code generated by the Protocol Buffer compiler is owned by the owner + of the input file used when generating it. This code is not + standalone and requires a support library to be linked with it. This + support library is itself covered by the above license. + + jsr-305: +Copyright (c) 2007-2009, JSR305 expert group +All rights reserved. + +https://opensource.org/licenses/BSD-3-Clause + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are met: + +* Redistributions of source code must retain the above copyright notice, + this list of conditions and the following disclaimer. +* Redistributions in binary form must reproduce the above copyright notice, + this list of conditions and the following disclaimer in the documentation + and/or other materials provided with the distribution. +* Neither the name of the JSR305 expert group nor the names of its + contributors may be used to endorse or promote products derived from + this software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE +ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR +CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +POSSIBILITY OF SUCH DAMAGE. + + janino-compiler: +Janino - An embedded Java[TM] compiler + +Copyright (c) 2001-2016,
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105598=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105598
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 13:54
Start Date: 24/May/18 13:54
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5461: [BEAM-4393]
:Appending lacked LICENSE of shaded dependencies
URL: https://github.com/apache/beam/pull/5461#issuecomment-391723499
This looks great. Checked with the guidelines at
http://www.apache.org/dev/licensing-howto.html#permissive-deps
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105598)
Time Spent: 20m (was: 10m)
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4393) Missing copyright notices for shaded packages
[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105415
]
ASF GitHub Bot logged work on BEAM-4393:
Author: ASF GitHub Bot
Created on: 24/May/18 00:29
Start Date: 24/May/18 00:29
Worklog Time Spent: 10m
Work Description: boyuanzz opened a new pull request #5461: [BEAM-4393]
:Appending lacked LICENSE of shaded dependencies
URL: https://github.com/apache/beam/pull/5461
Appending lacked LICENSE of shaded dependencies:
Lacked LICENSE and source:
protobuf: https://github.com/google/protobuf/blob/master/LICENSE
jsr-305: https://github.com/amaembo/jsr-305/blob/master/ri/LICENSE
janino: https://github.com/janino-compiler/janino/blob/master/LICENSE
r: @lukecwik
cc: @apilloud
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105415)
Time Spent: 10m
Remaining Estimate: 0h
> Missing copyright notices for shaded packages
> -
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
>Reporter: Scott Wegner
>Assignee: Boyuan Zhang
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
