[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-572903306 Thanks for the kindly reminder @amaliujia , i still want Julian to take a look, let's wait a few days. @julianhyde Would you please give a help here, to see if the latest code is as your expected, i always respected your suggestions ~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568700275 No need to keep my credit, the `if (isTumble)` decision is too hacky for me, so we must solve that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568657741 Here is my re-work based on your code, https://github.com/danny0405/calcite/tree/amaliujia-rw-add_TVF_TUMBLE : - Fix the logic in SqlValidator and SqlToRelConverter - Fix the code generation There are still 2 TODOs left there, hope you can solve that :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568386364 Remove the unnecessary changes in `OperandTypes` and `ReturnTypes`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568383147 I tried to modify based on your PR to treat `Tumble` as a normal table value function: use `SqlKind.OTHER_FUNCTION` to make the code works as the same, still in the progress ~ During the working, i have a feeling that the `Descriptor` should not have a different scope with the table value function, in the table value function's first operand scope, we should have see the referenced table columns. We may also need to add more tests: - For SqlParserTest: to test all the syntax with positive/negative cases - For SqlValidatorTest: test you operands/return type inference defined in the 2 new operators - For SqlToRelConverterTest: test your plan is correct after the conversion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-563974829 Thanks @amaliujia for firing this PR, i'm planning to give a review and can you resolve the conflicts ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
