Re: [I] [CI] - Camel Main Branch Build Failure [camel-quarkus]
github-actions[bot] commented on issue #2927: URL: https://github.com/apache/camel-quarkus/issues/2927#issuecomment-2131809011 The [camel-main](https://github.com/apache/camel-quarkus/tree/camel-main) branch build has failed: * Build ID: 9239152392-1390-147b4f11-002d-4d4c-ab19-651a3762076c * Camel Quarkus Commit: 5585e7c44e23ac88e8e5cafae03a012026c56d97 * Camel Main Commit: a8f4527157769cc01e7f03282d97328b712e31a2 * Link to build: https://github.com/apache/camel-quarkus/actions/runs/9239152392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20794: AWS2 Kinesis producer supports sending batch [camel]
fanyang commented on code in PR #14238:
URL: https://github.com/apache/camel/pull/14238#discussion_r1614645768
##
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Producer.java:
##
@@ -47,11 +53,28 @@ public Kinesis2Endpoint getEndpoint() {
@Override
public void process(Exchange exchange) throws Exception {
+Exception exceptionThrownByPutRecord = this.exceptionThrownByPutRecord;
Review Comment:
Hi Claus, thanks for the comments. This PR keeps using current client and
supports sending batch.
Since sending batch already has a good throughput, and as you said async
process is complex, It seems that we don't really need an async client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CAMEL-20794: AWS2 Kinesis producer supports sending batch [camel]
fanyang commented on code in PR #14238:
URL: https://github.com/apache/camel/pull/14238#discussion_r1614642796
##
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Producer.java:
##
@@ -47,11 +53,28 @@ public Kinesis2Endpoint getEndpoint() {
@Override
public void process(Exchange exchange) throws Exception {
+Exception exceptionThrownByPutRecord = this.exceptionThrownByPutRecord;
+if (exceptionThrownByPutRecord != null) {
+this.exceptionThrownByPutRecord = null;
+throw exceptionThrownByPutRecord;
+}
+
PutRecordRequest request = createRequest(exchange);
-PutRecordResponse putRecordResult =
connection.getClient(getEndpoint()).putRecord(request);
-Message message = getMessageForResponse(exchange);
-message.setHeader(Kinesis2Constants.SEQUENCE_NUMBER,
putRecordResult.sequenceNumber());
-message.setHeader(Kinesis2Constants.SHARD_ID,
putRecordResult.shardId());
+if (getEndpoint().getConfiguration().isAsyncClient()) {
Review Comment:
Thanks for the comments. Keep using synchronous client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(camel) branch regen_bot updated (786bf176856 -> 8bdacf8251a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git from 786bf176856 (chores) camel-paho: disable unreliable test on s390x add 8bdacf8251a (chores) camel-catalog-maven: fixed broken log message No new revisions were added by this update. Summary of changes: .../org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(camel) branch regen_bot updated (6bbe3c299ae -> 786bf176856)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git from 6bbe3c299ae (chores) camel-rocketmq: fix not skipping tests when it should add 49caae1d4ab (chores) camel-direct: cleanup duplicated code add abf2a918b2a (chores) camel-base-engine: use log markers add 637be1735b5 (chores) camel-google-drive: use log markers add 68d51435a02 (chores) camel-itest: use log markers add e5078ec6ba3 (chores) camel-kamelet-main: use log markers add 64bdd4abc20 (chores) camel-base-engine: fix overly complex conversion to String add 24d24933469 (chores) camel-core: fix overly complex conversion to String add ce0a760f808 (chores) camel-cxf: fix overly complex conversion to String add 3c00e0a9ab5 (chores) camel-disruptor: fix overly complex conversion to String add 13db92917cb (chores) camel-elytron: fix overly complex conversion to String add 0a94b2c2144 (chores) camel-http: fix overly complex conversion to String add 8af30f58e57 (chores) camel-ironmq: fix overly complex conversion to String add e4583fb753a (chores) camel-itest: fix overly complex conversion to String add a6ecc46a2d5 (chores) camel-jbang: fix overly complex conversion to String add ccda26faf87 (chores) camel-jetty: fix overly complex conversion to String add 63072ce4071 (chores) camel-jms: fix overly complex conversion to String add 29e6b9cef90 (chores) camel-leveldb: fix overly complex conversion to String add c6a979452c2 (chores) camel-mail: fix overly complex conversion to String add ab206a6a5cc (chores) camel-management: fix overly complex conversion to String add fbe241eeb92 (chores) camel-netty: fix overly complex conversion to String add bb643d235ad (chores) camel-netty-http: fix overly complex conversion to String add 86b078cebef (chores) camel-sjms: fix overly complex conversion to String add 7b9c5256c04 (chores) camel-spring-xml: fix overly complex conversion to String add 16437bb2f37 (chores) camel-sql: fix overly complex conversion to String add 2bda44f93a2 (chores) camel-undertow: fix overly complex conversion to String add 786bf176856 (chores) camel-paho: disable unreliable test on s390x No new revisions were added by this update. Summary of changes: .../component/cxf/jaxws/CxfConsumerPayloadXPathTest.java | 2 +- .../org/apache/camel/component/direct/DirectEndpoint.java| 7 ++- .../disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java | 2 +- .../org/apache/camel/component/elytron/BaseElytronTest.java | 2 +- .../apache/camel/component/google/drive/DriveRepliesIT.java | 2 +- .../org/apache/camel/component/http/HttpProxyServerTest.java | 2 +- .../integrationtest/ConcurrentConsumerLoadManualTest.java| 2 +- .../ironmq/integrationtest/Queue2QueueExampleManualTest.java | 2 +- .../java/org/apache/camel/component/jetty/BaseJettyTest.java | 4 ++-- .../camel/component/jetty/HttpProducerConcurrentTest.java| 2 +- .../jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java | 2 +- .../apache/camel/component/jms/async/AsyncJmsInOutTest.java | 2 +- .../jms/integration/spring/issues/JmsResequencerIT.java | 2 +- .../leveldb/LevelDBAggregateLoadConcurrentTest.java | 2 +- .../camel/component/leveldb/LevelDBAggregateLoadTest.java| 2 +- .../apache/camel/component/mail/MailBatchConsumerTest.java | 2 +- .../camel/component/mail/MailCommitOnCompletionTest.java | 2 +- .../java/org/apache/camel/component/mail/MailCopyToTest.java | 2 +- .../org/apache/camel/component/mail/MailFetchSizeTest.java | 2 +- .../apache/camel/component/mail/MailFetchSizeZeroTest.java | 2 +- .../camel/component/mail/MailMaxMessagesPerPollTest.java | 2 +- .../java/org/apache/camel/component/mail/MailMoveToTest.java | 2 +- .../org/apache/camel/component/mail/MailPollEnrichTest.java | 2 +- .../component/mail/MailShutdownCompleteAllTasksTest.java | 2 +- .../mail/MailShutdownCompleteCurrentTaskOnlyTest.java| 2 +- .../org/apache/camel/component/netty/http/BaseNettyTest.java | 2 +- .../netty/http/NettyHttpProducerConcurrentTest.java | 3 ++- .../java/org/apache/camel/component/netty/BaseNettyTest.java | 2 +- .../camel/component/netty/NettyReuseConnectionTest.java | 2 +- .../camel/component/netty/ObjectSerializationTest.java | 4 ++-- .../org/apache/camel/component/paho/PahoComponentTest.java | 3 +++ .../org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java | 2 +- .../camel/component/sjms/it/AsyncJmsInOutTempDestIT.java | 2 +- .../org/apache/camel/component/sjms/it/SyncJmsInOutIT.java | 2 +- .../camel/component/sjms/it/SyncJmsInOutTempDestIT.java | 2 +- .../TransactedStackSizeParallelProcessingTest.java | 2 +-
(camel) branch main updated: (chores) camel-catalog-maven: fixed broken log message
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 8bdacf8251a (chores) camel-catalog-maven: fixed broken log message
8bdacf8251a is described below
commit 8bdacf8251a6eda9a228955a85ddf28bebfd63db
Author: Otavio Rodolfo Piske
AuthorDate: Sat May 25 14:16:56 2024 +0200
(chores) camel-catalog-maven: fixed broken log message
---
.../org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
b/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
index a896252593f..01c94d7c3b6 100644
---
a/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
+++
b/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
@@ -146,7 +146,7 @@ public class DefaultMavenArtifactProvider implements
MavenArtifactProvider {
if (javaType != null) {
String json = loadComponentJSonSchema(classLoader, scheme, logger);
if (json != null) {
-logger.info("Adding component: " + scheme);
+logger.info("Adding component: {}", scheme);
camelCatalog.addComponent(scheme, javaType, json);
names.add(scheme);
}
(camel) branch main updated: (chores) camel-paho: disable unreliable test on s390x
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 786bf176856 (chores) camel-paho: disable unreliable test on s390x
786bf176856 is described below
commit 786bf176856f92cb87a58c894ccba4ad8508cf61
Author: Otavio Rodolfo Piske
AuthorDate: Sat May 25 14:11:30 2024 +0200
(chores) camel-paho: disable unreliable test on s390x
---
.../test/java/org/apache/camel/component/paho/PahoComponentTest.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
b/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
index e27cae20c12..75af9a0bbd9 100644
---
a/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
+++
b/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
@@ -30,11 +30,14 @@ import org.eclipse.paho.client.mqttv3.MqttMessage;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
import org.junit.jupiter.api.extension.RegisterExtension;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
+@DisabledOnOs(architectures = { "s390x" },
+disabledReason = "This test does not run reliably on s390x")
public class PahoComponentTest extends PahoTestSupport {
@Order(2)
(camel) 14/25: (chores) camel-jbang: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit a6ecc46a2d5ce840b9cf924cc09471297e0e9cc9
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:07:26 2024 +0200
(chores) camel-jbang: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../java/org/apache/camel/dsl/jbang/core/commands/Run.java | 4 ++--
.../apache/camel/dsl/jbang/core/commands/TransformRoute.java | 4 ++--
.../core/commands/action/CamelStartupRecorderAction.java | 2 +-
.../dsl/jbang/core/commands/action/CamelStubAction.java | 12 ++--
.../camel/dsl/jbang/core/commands/process/ListConsumer.java | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
index 5478a0bdda7..0b6f2430588 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
+++
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
@@ -847,7 +847,7 @@ public class Run extends CamelCommand {
protected int runQuarkus() throws Exception {
// create temp run dir
-File runDir = new File(RUN_PLATFORM_DIR, "" +
System.currentTimeMillis());
+File runDir = new File(RUN_PLATFORM_DIR,
Long.toString(System.currentTimeMillis()));
if (!this.background) {
runDir.deleteOnExit();
}
@@ -914,7 +914,7 @@ public class Run extends CamelCommand {
protected int runSpringBoot() throws Exception {
// create temp run dir
-File runDir = new File(RUN_PLATFORM_DIR, "" +
System.currentTimeMillis());
+File runDir = new File(RUN_PLATFORM_DIR,
Long.toString(System.currentTimeMillis()));
if (!this.background) {
runDir.deleteOnExit();
}
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/TransformRoute.java
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/TransformRoute.java
index f1010750513..e45b546307d 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/TransformRoute.java
+++
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/TransformRoute.java
@@ -88,8 +88,8 @@ public class TransformRoute extends CamelCommand {
main.addInitialProperty("camel.main.dumpRoutes", format);
main.addInitialProperty("camel.main.dumpRoutesInclude",
"routes,rests,routeConfigurations,beans");
main.addInitialProperty("camel.main.dumpRoutesLog", "false");
-
main.addInitialProperty("camel.main.dumpRoutesResolvePlaceholders", "" +
resolvePlaceholders);
-
main.addInitialProperty("camel.main.dumpRoutesUriAsParameters", "" +
uriAsParameters);
+
main.addInitialProperty("camel.main.dumpRoutesResolvePlaceholders",
Boolean.toString(resolvePlaceholders));
+
main.addInitialProperty("camel.main.dumpRoutesUriAsParameters",
Boolean.toString(uriAsParameters));
main.addInitialProperty("camel.main.dumpRoutesOutput", target);
main.addInitialProperty("camel.jbang.transform", "true");
main.addInitialProperty("camel.component.properties.ignoreMissingProperty",
"true");
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStartupRecorderAction.java
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStartupRecorderAction.java
index 017868fe456..ddbbfac59b4 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStartupRecorderAction.java
+++
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStartupRecorderAction.java
@@ -125,7 +125,7 @@ public class CamelStartupRecorderAction extends
ActionWatchCommand {
private String getDuration(Row r) {
if (r.duration > 0) {
-return "" + r.duration;
+return Long.toString(r.duration);
}
return "";
}
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStubAction.java
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStubAction.java
index 161f38f8c94..1375fb53343 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelStubAction.java
+++
(camel) 24/25: (chores) camel-sql: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 16437bb2f3703ae7f4065c48311899246f5507ea
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:20:53 2024 +0200
(chores) camel-sql: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../camel/processor/aggregate/jdbc/JdbcAggregationRepository.java | 2 +-
.../java/org/apache/camel/component/sql/SqlProducerConcurrentTest.java | 2 +-
.../camel/processor/aggregate/jdbc/JdbcAggregateLoadConcurrentTest.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java
b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java
index 3c6d2725c9f..9f0d51a00ec 100644
---
a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java
+++
b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java
@@ -624,7 +624,7 @@ public class JdbcAggregationRepository extends
ServiceSupport
}
public String getPropagationBehaviorName() {
-return PROPAGATION_CONSTANTS.asString("" + propagationBehavior);
+return
PROPAGATION_CONSTANTS.asString(Integer.toString(propagationBehavior));
}
/**
diff --git
a/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlProducerConcurrentTest.java
b/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlProducerConcurrentTest.java
index 66b3aca161c..0fed7582d43 100644
---
a/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlProducerConcurrentTest.java
+++
b/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlProducerConcurrentTest.java
@@ -66,7 +66,7 @@ public class SqlProducerConcurrentTest extends
CamelTestSupport {
Future> out = executor.submit(new Callable>() {
public List call() {
int id = (index % 3) + 1;
-return template.requestBody("direct:simple", "" + id,
List.class);
+return template.requestBody("direct:simple",
Integer.toString(id), List.class);
}
});
responses.put(index, out);
diff --git
a/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregateLoadConcurrentTest.java
b/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregateLoadConcurrentTest.java
index 4ec8a3b279e..997604dc0c8 100644
---
a/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregateLoadConcurrentTest.java
+++
b/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregateLoadConcurrentTest.java
@@ -49,7 +49,7 @@ public class JdbcAggregateLoadConcurrentTest extends
AbstractJdbcAggregationTest
public Object call() throws Exception {
char id = KEYS[key];
LOG.debug("Sending {} with id {}", value, id);
-template.sendBodyAndHeader("direct:start", value, "id", ""
+ id);
+template.sendBodyAndHeader("direct:start", value, "id",
Character.toString(id));
// simulate a little delay
Thread.sleep(3);
return null;
(camel) 12/25: (chores) camel-ironmq: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 8af30f58e57524bc6af770df3e61ecc0a3c9d110
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:03:16 2024 +0200
(chores) camel-ironmq: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../ironmq/integrationtest/ConcurrentConsumerLoadManualTest.java| 2 +-
.../component/ironmq/integrationtest/Queue2QueueExampleManualTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/ConcurrentConsumerLoadManualTest.java
b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/ConcurrentConsumerLoadManualTest.java
index f558e35c070..75a62a73104 100644
---
a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/ConcurrentConsumerLoadManualTest.java
+++
b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/ConcurrentConsumerLoadManualTest.java
@@ -59,7 +59,7 @@ public class ConcurrentConsumerLoadManualTest extends
CamelTestSupport {
int noOfBlocks = 0;
ArrayList list = new ArrayList<>();
for (int i = 1; i <= NO_OF_MESSAGES; i++) {
-String payloadToSend = PAYLOAD.replace("#", "" + i);
+String payloadToSend = PAYLOAD.replace("#", Integer.toString(i));
list.add(payloadToSend);
if (i % 100 == 0) {
noOfBlocks++;
diff --git
a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/Queue2QueueExampleManualTest.java
b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/Queue2QueueExampleManualTest.java
index a183c2a05cd..db2b6121a82 100644
---
a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/Queue2QueueExampleManualTest.java
+++
b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/integrationtest/Queue2QueueExampleManualTest.java
@@ -50,7 +50,7 @@ public class Queue2QueueExampleManualTest extends
CamelTestSupport {
public void testSendMessagesBetweenQueues() throws Exception {
getMockEndpoint("mock:result").expectedMessageCount(100);
for (int i = 1; i <= 100; i++) {
-String payloadToSend = PAYLOAD.replace("#", "" + i);
+String payloadToSend = PAYLOAD.replace("#", Integer.toString(i));
template.sendBody("direct:start", payloadToSend);
}
MockEndpoint.assertIsSatisfied(context, 2, TimeUnit.MINUTES);
(camel) 20/25: (chores) camel-netty: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit fbe241eeb92fa418d73bd90e8757b6cb200218a0
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:14:52 2024 +0200
(chores) camel-netty: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../src/test/java/org/apache/camel/component/netty/BaseNettyTest.java | 2 +-
.../org/apache/camel/component/netty/NettyReuseConnectionTest.java| 2 +-
.../org/apache/camel/component/netty/ObjectSerializationTest.java | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/components/camel-netty/src/test/java/org/apache/camel/component/netty/BaseNettyTest.java
b/components/camel-netty/src/test/java/org/apache/camel/component/netty/BaseNettyTest.java
index 589f953fca8..268521681ce 100644
---
a/components/camel-netty/src/test/java/org/apache/camel/component/netty/BaseNettyTest.java
+++
b/components/camel-netty/src/test/java/org/apache/camel/component/netty/BaseNettyTest.java
@@ -78,7 +78,7 @@ public abstract class BaseNettyTest extends CamelTestSupport {
public Properties loadProperties() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
+prop.setProperty("port", Integer.toString(getPort()));
return prop;
}
diff --git
a/components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyReuseConnectionTest.java
b/components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyReuseConnectionTest.java
index 295104fba48..bbf43b8c510 100644
---
a/components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyReuseConnectionTest.java
+++
b/components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyReuseConnectionTest.java
@@ -31,7 +31,7 @@ public class NettyReuseConnectionTest extends BaseNettyTest {
@Test
public void testReuseConnection() {
for (int i = 0; i < 20; i++) {
-String out = template.requestBody(uri, "" + i, String.class);
+String out = template.requestBody(uri, Integer.toString(i),
String.class);
assertEquals("Reply " + i, out);
}
}
diff --git
a/components/camel-netty/src/test/java/org/apache/camel/component/netty/ObjectSerializationTest.java
b/components/camel-netty/src/test/java/org/apache/camel/component/netty/ObjectSerializationTest.java
index d434addaa2b..ce79706a033 100644
---
a/components/camel-netty/src/test/java/org/apache/camel/component/netty/ObjectSerializationTest.java
+++
b/components/camel-netty/src/test/java/org/apache/camel/component/netty/ObjectSerializationTest.java
@@ -71,8 +71,8 @@ public class ObjectSerializationTest extends BaseNettyTest {
public Properties loadProperties() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
-prop.setProperty("port2", "" + port2);
+prop.setProperty("port", Integer.toString(getPort()));
+prop.setProperty("port2", Integer.toString(port2));
return prop;
}
(camel) 23/25: (chores) camel-spring-xml: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 7b9c5256c04cc0890e75ec4b74cd6751519f52bb
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:19:29 2024 +0200
(chores) camel-spring-xml: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../spring/interceptor/TransactedStackSizeParallelProcessingTest.java | 2 +-
.../org/apache/camel/spring/interceptor/TransactedStackSizeTest.java| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeParallelProcessingTest.java
b/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeParallelProcessingTest.java
index e27ff750df4..d4de171d785 100644
---
a/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeParallelProcessingTest.java
+++
b/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeParallelProcessingTest.java
@@ -47,7 +47,7 @@ public class TransactedStackSizeParallelProcessingTest
extends TransactionClient
sb.append(i);
sb.append(",");
}
-template.sendBody("seda:start", "" + sb.toString());
+template.sendBody("seda:start", sb.toString());
assertMockEndpointsSatisfied();
diff --git
a/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeTest.java
b/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeTest.java
index acecced63c9..48daf2cd83b 100644
---
a/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeTest.java
+++
b/components/camel-spring-xml/src/test/java/org/apache/camel/spring/interceptor/TransactedStackSizeTest.java
@@ -36,7 +36,7 @@ public class TransactedStackSizeTest extends
TransactionClientDataSourceSupport
sb.append(i);
sb.append(",");
}
-template.sendBody("seda:start", "" + sb.toString());
+template.sendBody("seda:start", sb.toString());
assertMockEndpointsSatisfied();
(camel) 09/25: (chores) camel-disruptor: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 3c00e0a9ab57d7e05a8d21d6a7d20702c4f348d4
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:00:24 2024 +0200
(chores) camel-disruptor: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../component/disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/components/camel-disruptor/src/test/java/org/apache/camel/component/disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java
b/components/camel-disruptor/src/test/java/org/apache/camel/component/disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java
index b5936a0a8b4..722004e991a 100644
---
a/components/camel-disruptor/src/test/java/org/apache/camel/component/disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java
+++
b/components/camel-disruptor/src/test/java/org/apache/camel/component/disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java
@@ -34,7 +34,7 @@ public class SameDisruptorVmQueueSizeAndNoSizeTest extends
CamelTestSupport {
@Test
void testSameQueue() {
for (int i = 0; i < 128; i++) {
-template.sendBody("disruptor-vm:foo?blockWhenFull=false", "" + i);
+template.sendBody("disruptor-vm:foo?blockWhenFull=false",
Integer.toString(i));
}
try {
(camel) 08/25: (chores) camel-cxf: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit ce0a760f808d1bfbbc20f062d74a0ac0a8124372
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:59:49 2024 +0200
(chores) camel-cxf: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
b/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
index 5f98ff022a9..5b7fe84bfe5 100644
---
a/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
+++
b/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
@@ -201,7 +201,7 @@ public class CxfConsumerPayloadXPathTest extends
CamelTestSupport {
String msgOut = constructSoapMessage(content);
exchange.getMessage().setBody(msgOut);
exchange.getMessage().setHeaders(exchange.getIn().getHeaders());
-exchange.getMessage().setHeader(HEADER_SIZE, "" +
content.length());
+exchange.getMessage().setHeader(HEADER_SIZE,
Integer.toString(content.length()));
}
}
(camel) 17/25: (chores) camel-leveldb: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 29e6b9cef90e666c535459ef3cdbe14037664f64
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:11:30 2024 +0200
(chores) camel-leveldb: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../camel/component/leveldb/LevelDBAggregateLoadConcurrentTest.java | 2 +-
.../org/apache/camel/component/leveldb/LevelDBAggregateLoadTest.java| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadConcurrentTest.java
b/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadConcurrentTest.java
index 02109d97bd3..73dc47cbfa9 100644
---
a/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadConcurrentTest.java
+++
b/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadConcurrentTest.java
@@ -62,7 +62,7 @@ public class LevelDBAggregateLoadConcurrentTest extends
LevelDBTestSupport {
public Object call() throws Exception {
char id = KEYS[key];
LOG.debug("Sending {} with id {}", value, id);
-template.sendBodyAndHeader("direct:start", value, "id", ""
+ id);
+template.sendBodyAndHeader("direct:start", value, "id",
Character.toString(id));
// simulate a little delay
Thread.sleep(3);
return null;
diff --git
a/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadTest.java
b/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadTest.java
index 2a91273c762..b336e76e413 100644
---
a/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadTest.java
+++
b/components/camel-leveldb/src/test/java/org/apache/camel/component/leveldb/LevelDBAggregateLoadTest.java
@@ -54,7 +54,7 @@ public class LevelDBAggregateLoadTest extends
LevelDBTestSupport {
final int value = 1;
char id = 'A';
LOG.debug("Sending {} with id {}", value, id);
-template.sendBodyAndHeader("seda:start?size=" + SIZE, value, "id",
"" + id);
+template.sendBodyAndHeader("seda:start?size=" + SIZE, value, "id",
Character.toString(id));
}
LOG.info("Sending all {} message done. Now waiting for aggregation to
complete.", SIZE);
(camel) 07/25: (chores) camel-core: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 24d24933469057311d75e2aba6709e40b1567b59
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:57:29 2024 +0200
(chores) camel-core: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../java/org/apache/camel/component/bean/BeanConcurrentTest.java| 2 +-
.../apache/camel/component/bean/BeanExpressionConcurrentTest.java | 2 +-
.../camel/component/bean/issues/BeanVsProcessorPerformanceTest.java | 4 ++--
.../apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java | 2 +-
.../java/org/apache/camel/impl/DefaultEndpointRegistryTest.java | 2 +-
.../java/org/apache/camel/issues/SplitterParallelIssueTest.java | 2 +-
.../java/org/apache/camel/processor/PipelineConcurrentTest.java | 2 +-
.../aggregator/AggregateConcurrentPerCorrelationKeyTest.java| 2 +-
.../camel/processor/aggregator/AggregateMultipleSourceTest.java | 6 +++---
.../aggregator/DistributedConcurrentPerCorrelationKeyTest.java | 4 ++--
.../processor/aggregator/DistributedOptimisticLockFailingTest.java | 4 ++--
.../src/test/java/org/apache/camel/util/OrderedComparatorTest.java | 2 +-
12 files changed, 17 insertions(+), 17 deletions(-)
diff --git
a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java
b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java
index 3316c3cbe48..40ea5a403fa 100644
---
a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java
@@ -37,7 +37,7 @@ public class BeanConcurrentTest extends ContextTestSupport {
// start from 1000 to be 4 digit always (easier to string compare)
for (int i = 1000; i < 2000; i++) {
-template.sendBody("seda:foo", "" + i);
+template.sendBody("seda:foo", Integer.toString(i));
}
context.getRouteController().startRoute("foo");
diff --git
a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java
b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java
index 2670f47be83..559df13b55b 100644
---
a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java
@@ -37,7 +37,7 @@ public class BeanExpressionConcurrentTest extends
ContextTestSupport {
// start from 1000 to be 4 digit always (easier to string compare)
for (int i = 1000; i < 2000; i++) {
-template.sendBody("seda:foo", "" + i);
+template.sendBody("seda:foo", Integer.toString(i));
}
context.getRouteController().startRoute("foo");
diff --git
a/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java
b/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java
index 2286c6de58a..a48ebe16a46 100644
---
a/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java
@@ -43,7 +43,7 @@ public class BeanVsProcessorPerformanceTest extends
ContextTestSupport {
StopWatch watch = new StopWatch();
for (int i = 0; i < size; i++) {
-Object out = template.requestBody("direct:a", "" + i);
+Object out = template.requestBody("direct:a", Integer.toString(i));
assertEquals("Bye " + i, out);
}
@@ -55,7 +55,7 @@ public class BeanVsProcessorPerformanceTest extends
ContextTestSupport {
StopWatch watch = new StopWatch();
for (int i = 0; i < size; i++) {
-Object out = template.requestBody("direct:b", "" + i);
+Object out = template.requestBody("direct:b", Integer.toString(i));
assertEquals("Bye " + i, out);
}
diff --git
a/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java
b/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java
index 13659bcda2e..0c347b06da7 100644
---
a/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java
@@ -33,7 +33,7 @@ public class SameSedaQueueSizeAndNoSizeTest extends
ContextTestSupport {
@Test
public void testSameQueue() {
for (int i = 0; i < 100; i++) {
-template.sendBody("seda:foo", "" + i);
+
(camel) 15/25: (chores) camel-jetty: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit ccda26faf8796742c799d7a0480db76be884af82
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:08:03 2024 +0200
(chores) camel-jetty: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../src/test/java/org/apache/camel/component/jetty/BaseJettyTest.java | 4 ++--
.../org/apache/camel/component/jetty/HttpProducerConcurrentTest.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/BaseJettyTest.java
b/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/BaseJettyTest.java
index 8d4cb913eb4..a2057cb6714 100644
---
a/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/BaseJettyTest.java
+++
b/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/BaseJettyTest.java
@@ -61,8 +61,8 @@ public abstract class BaseJettyTest extends CamelTestSupport {
@BindToRegistry("prop")
public Properties loadProp() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
-prop.setProperty("port2", "" + getPort2());
+prop.setProperty("port", Integer.toString(getPort()));
+prop.setProperty("port2", Integer.toString(getPort2()));
return prop;
}
diff --git
a/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpProducerConcurrentTest.java
b/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpProducerConcurrentTest.java
index 04837faca61..5c540e8661d 100644
---
a/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpProducerConcurrentTest.java
+++
b/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpProducerConcurrentTest.java
@@ -59,7 +59,7 @@ public class HttpProducerConcurrentTest extends BaseJettyTest
{
final int index = i;
Future out = executor.submit(new Callable() {
public String call() {
-return
template.requestBody("http://localhost:{{port}}/echo;, "" + index,
String.class);
+return
template.requestBody("http://localhost:{{port}}/echo;, Integer.toString(index),
String.class);
}
});
responses.put(index, out);
(camel) 19/25: (chores) camel-management: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit ab206a6a5cc11cf188bb7f4e88ac6ec156027bb8
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:13:25 2024 +0200
(chores) camel-management: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../test/java/org/apache/camel/management/ManagedLogEndpointTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/core/camel-management/src/test/java/org/apache/camel/management/ManagedLogEndpointTest.java
b/core/camel-management/src/test/java/org/apache/camel/management/ManagedLogEndpointTest.java
index fea8c33df60..614dee88d0a 100644
---
a/core/camel-management/src/test/java/org/apache/camel/management/ManagedLogEndpointTest.java
+++
b/core/camel-management/src/test/java/org/apache/camel/management/ManagedLogEndpointTest.java
@@ -38,7 +38,7 @@ public class ManagedLogEndpointTest extends
ManagementTestSupport {
getMockEndpoint("mock:a").expectedMessageCount(10);
for (int i = 0; i < 10; i++) {
-template.sendBody("direct:start", "" + i);
+template.sendBody("direct:start", Integer.toString(i));
Thread.sleep(100);
}
(camel) 16/25: (chores) camel-jms: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 63072ce4071d9850538e0b8df5b53a47d6c54c44
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:09:40 2024 +0200
(chores) camel-jms: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../component/jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java| 2 +-
.../java/org/apache/camel/component/jms/async/AsyncJmsInOutTest.java| 2 +-
.../camel/component/jms/integration/spring/issues/JmsResequencerIT.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java
index 061e640b748..36fa3b053ad 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java
@@ -85,7 +85,7 @@ public class JmsRequestReplyExclusiveReplyToConcurrentTest
extends AbstractJMSTe
for (int i = 0; i < size; i++) {
final Integer num = i;
executor.submit(() -> {
-String reply = template.requestBody("direct:start", "" + num,
String.class);
+String reply = template.requestBody("direct:start",
Integer.toString(num), String.class);
LOG.info("Sent {} expecting reply 'Hello {}' got --> {}", num,
num, reply);
assertNotNull(reply);
assertEquals("Hello " + num, reply);
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/async/AsyncJmsInOutTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/async/AsyncJmsInOutTest.java
index 2f3a00d728d..0a4ba45e07c 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/async/AsyncJmsInOutTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/async/AsyncJmsInOutTest.java
@@ -61,7 +61,7 @@ public class AsyncJmsInOutTest extends AbstractJMSTest {
StopWatch watch = new StopWatch();
for (int i = 0; i < 100; i++) {
-template.sendBody("seda:start", "" + i);
+template.sendBody("seda:start", Integer.toString(i));
}
// just in case we run on slow boxes
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/integration/spring/issues/JmsResequencerIT.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/integration/spring/issues/JmsResequencerIT.java
index 6c46c342eae..8fd3e6d5976 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/integration/spring/issues/JmsResequencerIT.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/integration/spring/issues/JmsResequencerIT.java
@@ -56,7 +56,7 @@ public class JmsResequencerIT extends
AbstractSpringJMSITSupport {
for (int i = 100; i > 0; i--) {
// send as text messages (not java objects - as they are not
serializable and allowed by JMS brokers like ActiveMQ)
-String text = "" + i;
+String text = Integer.toString(i);
template.sendBodyAndHeader(endpoint, text, "num", (long) i);
}
(camel) 01/25: (chores) camel-direct: cleanup duplicated code
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 49caae1d4abd6ff76d672ea4e7faee5c69e2c63e
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:21:05 2024 +0200
(chores) camel-direct: cleanup duplicated code
Signed-off-by: Otavio R. Piske
---
.../java/org/apache/camel/component/direct/DirectEndpoint.java | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git
a/components/camel-direct/src/main/java/org/apache/camel/component/direct/DirectEndpoint.java
b/components/camel-direct/src/main/java/org/apache/camel/component/direct/DirectEndpoint.java
index 7e881e620bb..274884601ec 100644
---
a/components/camel-direct/src/main/java/org/apache/camel/component/direct/DirectEndpoint.java
+++
b/components/camel-direct/src/main/java/org/apache/camel/component/direct/DirectEndpoint.java
@@ -55,11 +55,8 @@ public class DirectEndpoint extends DefaultEndpoint {
public DirectEndpoint(String uri, DirectComponent component) {
super(uri, component);
this.component = component;
-if (uri.indexOf('?') != -1) {
-this.key = StringHelper.before(uri, "?");
-} else {
-this.key = uri;
-}
+
+this.key = StringHelper.before(uri, "?", uri);
}
@Override
(camel) 25/25: (chores) camel-undertow: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 2bda44f93a245b11dfa2be5edfa83ef60a804f16
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:23:42 2024 +0200
(chores) camel-undertow: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../spring/security/AbstractSpringSecurityBearerTokenTest.java| 2 +-
.../java/org/apache/camel/component/undertow/BaseUndertowTest.java| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/components/camel-undertow-spring-security/src/test/java/org/apache/camel/component/spring/security/AbstractSpringSecurityBearerTokenTest.java
b/components/camel-undertow-spring-security/src/test/java/org/apache/camel/component/spring/security/AbstractSpringSecurityBearerTokenTest.java
index ea16fbbd537..adbb3b2c2bc 100644
---
a/components/camel-undertow-spring-security/src/test/java/org/apache/camel/component/spring/security/AbstractSpringSecurityBearerTokenTest.java
+++
b/components/camel-undertow-spring-security/src/test/java/org/apache/camel/component/spring/security/AbstractSpringSecurityBearerTokenTest.java
@@ -76,7 +76,7 @@ public abstract class AbstractSpringSecurityBearerTokenTest
extends CamelTestSup
public Properties loadProperties() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
+prop.setProperty("port", Integer.toString(getPort()));
return prop;
}
diff --git
a/components/camel-undertow/src/test/java/org/apache/camel/component/undertow/BaseUndertowTest.java
b/components/camel-undertow/src/test/java/org/apache/camel/component/undertow/BaseUndertowTest.java
index 3800440ba57..93f4d47b417 100644
---
a/components/camel-undertow/src/test/java/org/apache/camel/component/undertow/BaseUndertowTest.java
+++
b/components/camel-undertow/src/test/java/org/apache/camel/component/undertow/BaseUndertowTest.java
@@ -59,8 +59,8 @@ public abstract class BaseUndertowTest extends
CamelTestSupport {
public Properties loadProperties() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
-prop.setProperty("port2", "" + getPort2());
+prop.setProperty("port", Integer.toString(getPort()));
+prop.setProperty("port2", Integer.toString(getPort2()));
return prop;
}
(camel) 21/25: (chores) camel-netty-http: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit bb643d235ad17025c88a349991d33f757a826c21
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:16:03 2024 +0200
(chores) camel-netty-http: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../test/java/org/apache/camel/component/netty/http/BaseNettyTest.java | 2 +-
.../camel/component/netty/http/NettyHttpProducerConcurrentTest.java| 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/BaseNettyTest.java
b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/BaseNettyTest.java
index 92a0be0e404..27400abd48d 100644
---
a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/BaseNettyTest.java
+++
b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/BaseNettyTest.java
@@ -77,7 +77,7 @@ public class BaseNettyTest extends CamelTestSupport {
public Properties loadProp() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
+prop.setProperty("port", Integer.toString(getPort()));
return prop;
}
diff --git
a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/NettyHttpProducerConcurrentTest.java
b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/NettyHttpProducerConcurrentTest.java
index 62428afb43a..a35b3784ead 100644
---
a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/NettyHttpProducerConcurrentTest.java
+++
b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/NettyHttpProducerConcurrentTest.java
@@ -58,7 +58,8 @@ public class NettyHttpProducerConcurrentTest extends
BaseNettyTest {
final int index = i;
Future out = executor.submit(new Callable() {
public String call() {
-return
template.requestBody("netty-http:http://localhost:{{port}}/echo;, "" + index,
String.class);
+return
template.requestBody("netty-http:http://localhost:{{port}}/echo;,
Integer.toString(index),
+String.class);
}
});
responses.put(index, out);
(camel) 22/25: (chores) camel-sjms: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 86b078cebefe69dae202ed87686f0ba517762fc5
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:17:37 2024 +0200
(chores) camel-sjms: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java | 2 +-
.../org/apache/camel/component/sjms/it/AsyncJmsInOutTempDestIT.java | 2 +-
.../test/java/org/apache/camel/component/sjms/it/SyncJmsInOutIT.java| 2 +-
.../java/org/apache/camel/component/sjms/it/SyncJmsInOutTempDestIT.java | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java
index 89021ba2c59..d22d7257f28 100644
---
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java
+++
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java
@@ -41,7 +41,7 @@ public class AsyncJmsInOutIT extends JmsTestSupport {
StopWatch watch = new StopWatch();
for (int i = 0; i < 100; i++) {
-template.sendBody("seda:start.queue.AsyncJmsInOutIT", "" + i);
+template.sendBody("seda:start.queue.AsyncJmsInOutIT",
Integer.toString(i));
}
// just in case we run on slow boxes
diff --git
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutTempDestIT.java
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutTempDestIT.java
index 46ce184d6c7..9f1c6075202 100644
---
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutTempDestIT.java
+++
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/AsyncJmsInOutTempDestIT.java
@@ -41,7 +41,7 @@ public class AsyncJmsInOutTempDestIT extends JmsTestSupport {
StopWatch watch = new StopWatch();
for (int i = 0; i < 100; i++) {
-template.sendBody("seda:start.AsyncJmsInOutTempDestIT", "" + i);
+template.sendBody("seda:start.AsyncJmsInOutTempDestIT",
Integer.toString(i));
}
// just in case we run on slow boxes
diff --git
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutIT.java
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutIT.java
index 1ef7567a00d..f36f4bb0ac4 100644
---
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutIT.java
+++
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutIT.java
@@ -41,7 +41,7 @@ public class SyncJmsInOutIT extends JmsTestSupport {
StopWatch watch = new StopWatch();
for (int i = 0; i < 100; i++) {
-template.sendBody("seda:start.SyncJmsInOutIT", "" + i);
+template.sendBody("seda:start.SyncJmsInOutIT",
Integer.toString(i));
}
// just in case we run on slow boxes
diff --git
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutTempDestIT.java
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutTempDestIT.java
index 25a6da25d62..b2e524451ef 100644
---
a/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutTempDestIT.java
+++
b/components/camel-sjms/src/test/java/org/apache/camel/component/sjms/it/SyncJmsInOutTempDestIT.java
@@ -41,7 +41,7 @@ public class SyncJmsInOutTempDestIT extends JmsTestSupport {
StopWatch watch = new StopWatch();
for (int i = 0; i < 100; i++) {
-template.sendBody("seda:start.SyncJmsInOutTempDestIT", "" + i);
+template.sendBody("seda:start.SyncJmsInOutTempDestIT",
Integer.toString(i));
}
// just in case we run on slow boxes
(camel) 10/25: (chores) camel-elytron: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 13db92917cbf4c2e58030c751d0b9e476d291512
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:00:53 2024 +0200
(chores) camel-elytron: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../test/java/org/apache/camel/component/elytron/BaseElytronTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/components/camel-elytron/src/test/java/org/apache/camel/component/elytron/BaseElytronTest.java
b/components/camel-elytron/src/test/java/org/apache/camel/component/elytron/BaseElytronTest.java
index 0d7ef7cd274..1f868a1fd3e 100644
---
a/components/camel-elytron/src/test/java/org/apache/camel/component/elytron/BaseElytronTest.java
+++
b/components/camel-elytron/src/test/java/org/apache/camel/component/elytron/BaseElytronTest.java
@@ -81,7 +81,7 @@ public abstract class BaseElytronTest extends
CamelTestSupport {
public Properties loadProperties() {
Properties prop = new Properties();
-prop.setProperty("port", "" + getPort());
+prop.setProperty("port", Integer.toString(getPort()));
return prop;
}
(camel) 11/25: (chores) camel-http: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 0a94b2c2144547c6a0183d554633953707759b11
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:02:19 2024 +0200
(chores) camel-http: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../test/java/org/apache/camel/component/http/HttpProxyServerTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/components/camel-http/src/test/java/org/apache/camel/component/http/HttpProxyServerTest.java
b/components/camel-http/src/test/java/org/apache/camel/component/http/HttpProxyServerTest.java
index be72bacc06f..dc624e8b97f 100644
---
a/components/camel-http/src/test/java/org/apache/camel/component/http/HttpProxyServerTest.java
+++
b/components/camel-http/src/test/java/org/apache/camel/component/http/HttpProxyServerTest.java
@@ -145,7 +145,7 @@ public class HttpProxyServerTest extends BaseHttpTest {
}
private String getProxyPort() {
-return "" + proxy.getLocalPort();
+return Integer.toString(proxy.getLocalPort());
}
}
(camel) 18/25: (chores) camel-mail: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit c6a979452c294f7c93dafc6dde084b02e79ab00c
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:12:48 2024 +0200
(chores) camel-mail: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../java/org/apache/camel/component/mail/MailBatchConsumerTest.java | 2 +-
.../org/apache/camel/component/mail/MailCommitOnCompletionTest.java | 2 +-
.../src/test/java/org/apache/camel/component/mail/MailCopyToTest.java | 2 +-
.../test/java/org/apache/camel/component/mail/MailFetchSizeTest.java| 2 +-
.../java/org/apache/camel/component/mail/MailFetchSizeZeroTest.java | 2 +-
.../org/apache/camel/component/mail/MailMaxMessagesPerPollTest.java | 2 +-
.../src/test/java/org/apache/camel/component/mail/MailMoveToTest.java | 2 +-
.../test/java/org/apache/camel/component/mail/MailPollEnrichTest.java | 2 +-
.../apache/camel/component/mail/MailShutdownCompleteAllTasksTest.java | 2 +-
.../camel/component/mail/MailShutdownCompleteCurrentTaskOnlyTest.java | 2 +-
10 files changed, 10 insertions(+), 10 deletions(-)
diff --git
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailBatchConsumerTest.java
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailBatchConsumerTest.java
index 1d8c85f56ac..4e32c698b07 100644
---
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailBatchConsumerTest.java
+++
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailBatchConsumerTest.java
@@ -84,7 +84,7 @@ public class MailBatchConsumerTest extends CamelTestSupport {
Message[] messages = new Message[5];
for (int i = 0; i < 5; i++) {
messages[i] = new MimeMessage(sender.getSession());
-messages[i].setHeader("Message-ID", "" + i);
+messages[i].setHeader("Message-ID", Integer.toString(i));
messages[i].setText("Message " + i);
}
folder.appendMessages(messages);
diff --git
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCommitOnCompletionTest.java
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCommitOnCompletionTest.java
index d41154e81b6..615f62bb49a 100644
---
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCommitOnCompletionTest.java
+++
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCommitOnCompletionTest.java
@@ -77,7 +77,7 @@ public class MailCommitOnCompletionTest extends
CamelTestSupport {
Message[] messages = new Message[5];
for (int i = 0; i < 5; i++) {
messages[i] = new MimeMessage(sender.getSession());
-messages[i].setHeader("Message-ID", "" + i);
+messages[i].setHeader("Message-ID", Integer.toString(i));
messages[i].setText("Message " + i);
}
folder.appendMessages(messages);
diff --git
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCopyToTest.java
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCopyToTest.java
index 1d8084f7ad6..43ed40190bf 100644
---
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCopyToTest.java
+++
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCopyToTest.java
@@ -74,7 +74,7 @@ public class MailCopyToTest extends CamelTestSupport {
Message[] messages = new Message[5];
for (int i = 0; i < 5; i++) {
messages[i] = new MimeMessage(sender.getSession());
-messages[i].setHeader("Message-ID", "" + i);
+messages[i].setHeader("Message-ID", Integer.toString(i));
messages[i].setText("Message " + i);
}
folder.appendMessages(messages);
diff --git
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailFetchSizeTest.java
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailFetchSizeTest.java
index 2b7cb187151..42f1863e783 100644
---
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailFetchSizeTest.java
+++
b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailFetchSizeTest.java
@@ -93,7 +93,7 @@ public class MailFetchSizeTest extends CamelTestSupport {
Message[] messages = new Message[5];
for (int i = 0; i < 5; i++) {
messages[i] = new MimeMessage(sender.getSession());
-messages[i].setHeader("Message-ID", "" + i);
+messages[i].setHeader("Message-ID", Integer.toString(i));
messages[i].setText("Message " + i);
}
folder.appendMessages(messages);
diff --git
a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailFetchSizeZeroTest.java
(camel) 05/25: (chores) camel-kamelet-main: use log markers
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit e5078ec6ba360b2bddbf8eaddb606a617242c2fd
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:40:05 2024 +0200
(chores) camel-kamelet-main: use log markers
Signed-off-by: Otavio R. Piske
---
.../org/apache/camel/main/reload/OpenApiGeneratorReloadStrategy.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/reload/OpenApiGeneratorReloadStrategy.java
b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/reload/OpenApiGeneratorReloadStrategy.java
index 5ecbde23b98..3f789f2ae3c 100644
---
a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/reload/OpenApiGeneratorReloadStrategy.java
+++
b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/reload/OpenApiGeneratorReloadStrategy.java
@@ -73,7 +73,7 @@ public class OpenApiGeneratorReloadStrategy extends
FileWatcherResourceReloadStr
String out =
RestDslGenerator.toYaml(document).generate(getCamelContext(), false);
Files.write(Paths.get(OPENAPI_GENERATED_FILE), out.getBytes());
} catch (Exception e) {
-LOG.warn("Error generating open-api rest-dsl due: " +
e.getMessage(), e);
+LOG.warn("Error generating open-api rest-dsl due: {}",
e.getMessage(), e);
}
});
}
(camel) 04/25: (chores) camel-itest: use log markers
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 68d51435a0243aba3d1876d350a3bd8460575a9d
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:38:56 2024 +0200
(chores) camel-itest: use log markers
Signed-off-by: Otavio R. Piske
---
.../src/test/java/org/apache/camel/itest/greeter/PrepareRequest.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/tests/camel-itest/src/test/java/org/apache/camel/itest/greeter/PrepareRequest.java
b/tests/camel-itest/src/test/java/org/apache/camel/itest/greeter/PrepareRequest.java
index 980e00de9f5..d4fa5305279 100644
---
a/tests/camel-itest/src/test/java/org/apache/camel/itest/greeter/PrepareRequest.java
+++
b/tests/camel-itest/src/test/java/org/apache/camel/itest/greeter/PrepareRequest.java
@@ -34,7 +34,7 @@ public class PrepareRequest implements Processor {
params.add(exchange.getIn().getBody(String.class));
exchange.getMessage().setBody(params);
String operation = (String)
exchange.getIn().getHeader(CxfConstants.OPERATION_NAME);
-LOG.info("The operation name is " + operation);
+LOG.info("The operation name is {}", operation);
exchange.getMessage().setHeader(CxfConstants.OPERATION_NAME,
operation);
}
(camel) 13/25: (chores) camel-itest: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit e4583fb753a7c52cb517328f55feaa8c5a9f1afd
Author: Otavio R. Piske
AuthorDate: Fri May 24 20:03:36 2024 +0200
(chores) camel-itest: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../src/test/java/org/apache/camel/itest/jms/JmsJettyAsyncTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/tests/camel-itest/src/test/java/org/apache/camel/itest/jms/JmsJettyAsyncTest.java
b/tests/camel-itest/src/test/java/org/apache/camel/itest/jms/JmsJettyAsyncTest.java
index 15d958c8f3a..6333fae99c7 100644
---
a/tests/camel-itest/src/test/java/org/apache/camel/itest/jms/JmsJettyAsyncTest.java
+++
b/tests/camel-itest/src/test/java/org/apache/camel/itest/jms/JmsJettyAsyncTest.java
@@ -43,7 +43,7 @@ public class JmsJettyAsyncTest extends CamelTestSupport {
getMockEndpoint("mock:result").expectsNoDuplicates(body());
for (int i = 0; i < size; i++) {
-template.sendBody("activemq:queue:inbox", "" + i);
+template.sendBody("activemq:queue:inbox", Integer.toString(i));
}
MockEndpoint.assertIsSatisfied(context, 2, TimeUnit.MINUTES);
(camel) 03/25: (chores) camel-google-drive: use log markers
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 637be1735b566e20075ddb1d9efe4e1b0f4e2056
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:38:17 2024 +0200
(chores) camel-google-drive: use log markers
Signed-off-by: Otavio R. Piske
---
.../java/org/apache/camel/component/google/drive/DriveRepliesIT.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/components/camel-google/camel-google-drive/src/test/java/org/apache/camel/component/google/drive/DriveRepliesIT.java
b/components/camel-google/camel-google-drive/src/test/java/org/apache/camel/component/google/drive/DriveRepliesIT.java
index 87cd61f8223..fc1a4085baa 100644
---
a/components/camel-google/camel-google-drive/src/test/java/org/apache/camel/component/google/drive/DriveRepliesIT.java
+++
b/components/camel-google/camel-google-drive/src/test/java/org/apache/camel/component/google/drive/DriveRepliesIT.java
@@ -65,7 +65,7 @@ public class DriveRepliesIT extends
AbstractGoogleDriveTestSupport {
com.google.api.services.drive.model.CommentList result1 =
requestBody("direct://LIST_COMMENTS", fileId);
assertNotNull(result1.get("items"));
-LOG.debug("list: " + result1);
+LOG.debug("list: {}", result1);
Comment comment2 = result1.getComments().get(0);
String commentId = comment2.getId();
(camel) 06/25: (chores) camel-base-engine: fix overly complex conversion to String
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 64bdd4abc202dd07988910067d18bb78b75bcbe8
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:50:56 2024 +0200
(chores) camel-base-engine: fix overly complex conversion to String
Signed-off-by: Otavio R. Piske
---
.../src/main/java/org/apache/camel/impl/engine/DefaultChannel.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultChannel.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultChannel.java
index 7d7a9815c89..cc14632975f 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultChannel.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultChannel.java
@@ -372,7 +372,7 @@ public class DefaultChannel extends CamelInternalProcessor
implements Channel {
if (loc != null && loc.contains(":")) {
loc = StringHelper.after(loc, ":");
}
-String num = "" + definition.getLineNumber();
+String num =
String.valueOf(definition.getLineNumber());
if (PatternHelper.matchPattern(loc, ploc) &&
pnum.equals(num)) {
match = true;
}
(camel) branch main updated (6bbe3c299ae -> 2bda44f93a2)
This is an automated email from the ASF dual-hosted git repository. orpiske pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/camel.git from 6bbe3c299ae (chores) camel-rocketmq: fix not skipping tests when it should new 49caae1d4ab (chores) camel-direct: cleanup duplicated code new abf2a918b2a (chores) camel-base-engine: use log markers new 637be1735b5 (chores) camel-google-drive: use log markers new 68d51435a02 (chores) camel-itest: use log markers new e5078ec6ba3 (chores) camel-kamelet-main: use log markers new 64bdd4abc20 (chores) camel-base-engine: fix overly complex conversion to String new 24d24933469 (chores) camel-core: fix overly complex conversion to String new ce0a760f808 (chores) camel-cxf: fix overly complex conversion to String new 3c00e0a9ab5 (chores) camel-disruptor: fix overly complex conversion to String new 13db92917cb (chores) camel-elytron: fix overly complex conversion to String new 0a94b2c2144 (chores) camel-http: fix overly complex conversion to String new 8af30f58e57 (chores) camel-ironmq: fix overly complex conversion to String new e4583fb753a (chores) camel-itest: fix overly complex conversion to String new a6ecc46a2d5 (chores) camel-jbang: fix overly complex conversion to String new ccda26faf87 (chores) camel-jetty: fix overly complex conversion to String new 63072ce4071 (chores) camel-jms: fix overly complex conversion to String new 29e6b9cef90 (chores) camel-leveldb: fix overly complex conversion to String new c6a979452c2 (chores) camel-mail: fix overly complex conversion to String new ab206a6a5cc (chores) camel-management: fix overly complex conversion to String new fbe241eeb92 (chores) camel-netty: fix overly complex conversion to String new bb643d235ad (chores) camel-netty-http: fix overly complex conversion to String new 86b078cebef (chores) camel-sjms: fix overly complex conversion to String new 7b9c5256c04 (chores) camel-spring-xml: fix overly complex conversion to String new 16437bb2f37 (chores) camel-sql: fix overly complex conversion to String new 2bda44f93a2 (chores) camel-undertow: fix overly complex conversion to String The 25 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../component/cxf/jaxws/CxfConsumerPayloadXPathTest.java | 2 +- .../org/apache/camel/component/direct/DirectEndpoint.java| 7 ++- .../disruptor/vm/SameDisruptorVmQueueSizeAndNoSizeTest.java | 2 +- .../org/apache/camel/component/elytron/BaseElytronTest.java | 2 +- .../apache/camel/component/google/drive/DriveRepliesIT.java | 2 +- .../org/apache/camel/component/http/HttpProxyServerTest.java | 2 +- .../integrationtest/ConcurrentConsumerLoadManualTest.java| 2 +- .../ironmq/integrationtest/Queue2QueueExampleManualTest.java | 2 +- .../java/org/apache/camel/component/jetty/BaseJettyTest.java | 4 ++-- .../camel/component/jetty/HttpProducerConcurrentTest.java| 2 +- .../jms/JmsRequestReplyExclusiveReplyToConcurrentTest.java | 2 +- .../apache/camel/component/jms/async/AsyncJmsInOutTest.java | 2 +- .../jms/integration/spring/issues/JmsResequencerIT.java | 2 +- .../leveldb/LevelDBAggregateLoadConcurrentTest.java | 2 +- .../camel/component/leveldb/LevelDBAggregateLoadTest.java| 2 +- .../apache/camel/component/mail/MailBatchConsumerTest.java | 2 +- .../camel/component/mail/MailCommitOnCompletionTest.java | 2 +- .../java/org/apache/camel/component/mail/MailCopyToTest.java | 2 +- .../org/apache/camel/component/mail/MailFetchSizeTest.java | 2 +- .../apache/camel/component/mail/MailFetchSizeZeroTest.java | 2 +- .../camel/component/mail/MailMaxMessagesPerPollTest.java | 2 +- .../java/org/apache/camel/component/mail/MailMoveToTest.java | 2 +- .../org/apache/camel/component/mail/MailPollEnrichTest.java | 2 +- .../component/mail/MailShutdownCompleteAllTasksTest.java | 2 +- .../mail/MailShutdownCompleteCurrentTaskOnlyTest.java| 2 +- .../org/apache/camel/component/netty/http/BaseNettyTest.java | 2 +- .../netty/http/NettyHttpProducerConcurrentTest.java | 3 ++- .../java/org/apache/camel/component/netty/BaseNettyTest.java | 2 +- .../camel/component/netty/NettyReuseConnectionTest.java | 2 +- .../camel/component/netty/ObjectSerializationTest.java | 4 ++-- .../org/apache/camel/component/sjms/it/AsyncJmsInOutIT.java | 2 +- .../camel/component/sjms/it/AsyncJmsInOutTempDestIT.java | 2 +- .../org/apache/camel/component/sjms/it/SyncJmsInOutIT.java | 2 +- .../camel/component/sjms/it/SyncJmsInOutTempDestIT.java | 2 +- .../TransactedStackSizeParallelProcessingTest.java | 2 +-
(camel) 02/25: (chores) camel-base-engine: use log markers
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit abf2a918b2a5297ae9925b96a3361a5168987523
Author: Otavio R. Piske
AuthorDate: Fri May 24 19:35:58 2024 +0200
(chores) camel-base-engine: use log markers
Signed-off-by: Otavio R. Piske
---
.../org/apache/camel/impl/debugger/DebuggerJmxConnectorService.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DebuggerJmxConnectorService.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DebuggerJmxConnectorService.java
index 64ad17a51c0..c309e93e976 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DebuggerJmxConnectorService.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DebuggerJmxConnectorService.java
@@ -94,9 +94,8 @@ public class DebuggerJmxConnectorService extends
ServiceSupport implements Camel
cs.stop();
LOG.debug("Stopped Debugger JMX Connector");
} catch (IOException e) {
-LOG.debug("Error occurred during stopping CamelDebugger JMX
Connector: " + cs
- + ". This exception will be ignored.",
-e);
+LOG.debug("Error occurred during stopping CamelDebugger JMX
Connector: {}. This exception will be ignored.",
+cs, e);
}
cs = null;
}
Re: [PR] (chores) multiple small cleanups [camel]
orpiske merged PR #14239: URL: https://github.com/apache/camel/pull/14239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(camel) branch regen_bot updated (bc54c4929bd -> 6bbe3c299ae)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git from bc54c4929bd CAMEL-20803: camel-spring-rabbitmq - Configuring maximumRetryAttempts should accept 0 add 6bbe3c299ae (chores) camel-rocketmq: fix not skipping tests when it should No new revisions were added by this update. Summary of changes: components/camel-rocketmq/pom.xml | 17 - 1 file changed, 4 insertions(+), 13 deletions(-)
(camel) branch main updated: (chores) camel-rocketmq: fix not skipping tests when it should
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 6bbe3c299ae (chores) camel-rocketmq: fix not skipping tests when it
should
6bbe3c299ae is described below
commit 6bbe3c299ae1da7af6fc3d5219ccd8c7baf11e1d
Author: Otavio Rodolfo Piske
AuthorDate: Sat May 25 13:59:13 2024 +0200
(chores) camel-rocketmq: fix not skipping tests when it should
---
components/camel-rocketmq/pom.xml | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/components/camel-rocketmq/pom.xml
b/components/camel-rocketmq/pom.xml
index a70af6d6c89..1fbba4ff570 100644
--- a/components/camel-rocketmq/pom.xml
+++ b/components/camel-rocketmq/pom.xml
@@ -34,10 +34,14 @@
Camel RocketMQ Component
+false
true
true
true
+true
+true
+true
@@ -77,17 +81,4 @@
test
-
-
-
-
-org.apache.maven.plugins
-maven-failsafe-plugin
-
-${skipITs}
-false
-
-
-
-
(camel-website) branch regen_bot updated (bb7e6e24 -> 8ff93c78)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel-website.git from bb7e6e24 Update front page add 8ff93c78 Karavan 4.6.0 (#1186) No new revisions were added by this update. Summary of changes: .../2024/05/camel-karavan-4.6.0/errorhandler.png | Bin 0 -> 214644 bytes content/blog/2024/05/camel-karavan-4.6.0/index.md | 71 + .../2024/05/camel-karavan-4.6.0/loadbalance.png| Bin 0 -> 189917 bytes 3 files changed, 71 insertions(+) create mode 100644 content/blog/2024/05/camel-karavan-4.6.0/errorhandler.png create mode 100644 content/blog/2024/05/camel-karavan-4.6.0/index.md create mode 100644 content/blog/2024/05/camel-karavan-4.6.0/loadbalance.png
(camel-website) branch main updated: Karavan 4.6.0 (#1186)
This is an automated email from the ASF dual-hosted git repository. marat pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-website.git The following commit(s) were added to refs/heads/main by this push: new 8ff93c78 Karavan 4.6.0 (#1186) 8ff93c78 is described below commit 8ff93c78c5553f7e07fdba13e2b9f83dec76c9c3 Author: Marat Gubaidullin AuthorDate: Sat May 25 05:35:42 2024 -0400 Karavan 4.6.0 (#1186) * Karavan 4.0.0 Release announcement * Karavan 4.0.0 Release announcement change date * karavan-4.6.0 --- .../2024/05/camel-karavan-4.6.0/errorhandler.png | Bin 0 -> 214644 bytes content/blog/2024/05/camel-karavan-4.6.0/index.md | 71 + .../2024/05/camel-karavan-4.6.0/loadbalance.png| Bin 0 -> 189917 bytes 3 files changed, 71 insertions(+) diff --git a/content/blog/2024/05/camel-karavan-4.6.0/errorhandler.png b/content/blog/2024/05/camel-karavan-4.6.0/errorhandler.png new file mode 100644 index ..6417825e Binary files /dev/null and b/content/blog/2024/05/camel-karavan-4.6.0/errorhandler.png differ diff --git a/content/blog/2024/05/camel-karavan-4.6.0/index.md b/content/blog/2024/05/camel-karavan-4.6.0/index.md new file mode 100644 index ..9e5a2884 --- /dev/null +++ b/content/blog/2024/05/camel-karavan-4.6.0/index.md @@ -0,0 +1,71 @@ +--- +title: "Karavan 4.6.0: Hidden gems" +date: 2024-05-27 +authors: [mgubaidullin] +categories: ["Tooling", "Karavan"] +preview: "Karavan 4.6.0: Hidden gems" +--- + +We're announcing the release of Apache Camel Karavan 4.6.0, your ultimate toolkit for streamlined and expedited integration development using Apache Camel! + +This new version is aligned with the latest Apache Camel Framework 4.6.0, ensuring compatibility and leveraging the newest features. + +While this release may seem modest, it introduces a series of subtle enhancements aimed at simplifying the daily tasks of integrators. These improvements, though minor at first glance, are designed to reduce the need for frequent documentation lookups, thereby saving significant time and effort in larger projects. + +## Developer Experience Improvements + +1. **ErrorHandler Configuration on Route Level** + + Simplify error handling in your routes with the new configuration options. This allows for more granular control and management of errors, making your integrations more robust and easier to maintain. + +  + +2. **Autostart and ErrorHandler visual indicator on Route Diagram** + +We have introduced visual indicators for Autostart and ErrorHandler statuses on the route diagram. This enhancement allows for quicker and easier identification of route configurations, improving overall workflow efficiency. + +2. **LoadBalance EIP** + + Introducing the LoadBalance Enterprise Integration Pattern (EIP). This feature ensures optimal distribution of workloads across your system, enhancing performance and reliability. + +  + +3. **Container Image and Commit Information in UI for Running Integration Project** + + Gain better visibility into your running projects with the ability to view container image and commit information directly in the UI. This improvement aids in troubleshooting and maintaining your integrations. + +4. **Build Script Simplified Clone Git Repo** + + Cloning Git repositories has never been easier. Our simplified build script streamlines this process, saving you time and reducing complexity in your workflow. + +5. **User Can Create Kamelet in Project** + + Empowering users to create Kamelets within their projects. This feature enhances flexibility and customization, allowing you to define reusable components tailored to your specific needs. + +6. **User Can Configure REST DSL with OpenApi Contract** + + Configure REST DSL seamlessly with OpenApi contracts. This integration ensures your RESTful services are well-documented and adhere to standards, improving both development and API management. + +## Latest Versions + +Stay up to date with the latest versions included in this release: + +**Camel 4.6.0** + + Enjoy the latest features and improvements in Camel 4.6.0, designed to enhance your integration capabilities. + +**Kamelets 4.6.0** + + Utilize the updated Kamelets 4.6.0 for reusable and standardized integration components. + +**Jkube 1.16.2** + + Take advantage of the latest updates in Jkube 1.16.2, offering better Kubernetes integration and management. + +**JBang v0.116.0** + + Experience the enhancements in JBang v0.116.0, facilitating easier scripting and execution of Java applications. + +We invite you to explore these new features and updates, and we look forward to seeing how they enhance your integration projects. Your feedback is invaluable to us, so please share your thoughts and experiences as you dive into this latest release. + +**Happy integrating!**
Re: [PR] Karavan 4.6.0 [camel-website]
mgubaidullin merged PR #1186: URL: https://github.com/apache/camel-website/pull/1186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] CAMEL-20779: Upgrade to SB 3.3.0 [camel-spring-boot]
Croway opened a new pull request, #1153: URL: https://github.com/apache/camel-spring-boot/pull/1153 I think that the only breaking changes are related to Prometheus https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.3-Release-Notes but it is already updated in Camel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add the possibility to change the maven repository used to build the images [camel-karavan]
mgubaidullin commented on issue #1292: URL: https://github.com/apache/camel-karavan/issues/1292#issuecomment-2131142965 `karavan.devmode.image` should be set for Karavan application itself, not for the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(camel-karaf) branch 276/integration-test-framework updated (2a6b444f -> dc7e303b)
This is an automated email from the ASF dual-hosted git repository. nfilotto pushed a change to branch 276/integration-test-framework in repository https://gitbox.apache.org/repos/asf/camel-karaf.git omit 2a6b444f Move camel-seda and camel-file into the same class add dc7e303b Move camel-seda and camel-file into the same class This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (2a6b444f) \ N -- N -- N refs/heads/276/integration-test-framework (dc7e303b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../karaf/camel/itests/AbstractCamelRouteITest.java | 1 + .../AbstractCamelSingleComponentResultFileBasedRoute.java | 4 ++-- .../AbstractCamelSingleComponentResultMockBasedRoute.java | 4 ++-- .../itests/AbstractCamelSingleComponentRouteITest.java| 4 ++-- .../apache/karaf/camel/itests/CamelContextProvider.java | 15 +++ 5 files changed, 22 insertions(+), 6 deletions(-)
(camel) branch regen_bot updated (d19a62947a7 -> bc54c4929bd)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git from d19a62947a7 CAMEL-20785: mark createCamelRegistry as deprecated and cleanup abuses of the API add bc54c4929bd CAMEL-20803: camel-spring-rabbitmq - Configuring maximumRetryAttempts should accept 0 No new revisions were added by this update. Summary of changes: .../org/apache/camel/catalog/components/spring-rabbitmq.json | 2 +- .../apache/camel/component/springrabbit/spring-rabbitmq.json | 2 +- .../springrabbit/DefaultListenerContainerFactory.java | 5 - .../camel/component/springrabbit/SpringRabbitMQEndpoint.java | 2 +- .../endpoint/dsl/SpringRabbitMQEndpointBuilderFactory.java | 10 ++ .../org/apache/camel/kotlin/components/SpringRabbitmqUriDsl.kt | 8 6 files changed, 17 insertions(+), 12 deletions(-)
(camel-spring-boot) branch main updated: Regen
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-spring-boot.git
The following commit(s) were added to refs/heads/main by this push:
new 2b215b42706 Regen
2b215b42706 is described below
commit 2b215b42706573d85ceb8616add82e1a9529938b
Author: Claus Ibsen
AuthorDate: Sat May 25 09:32:42 2024 +0200
Regen
---
.../catalog/components/openstack-neutron.json | 2 +-
.../catalog/components/spring-rabbitmq.json| 2 +-
tooling/camel-spring-boot-dependencies/pom.xml | 67 --
3 files changed, 38 insertions(+), 33 deletions(-)
diff --git
a/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/openstack-neutron.json
b/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/openstack-neutron.json
index 432acd67940..cc5862fee6f 100644
---
a/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/openstack-neutron.json
+++
b/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/openstack-neutron.json
@@ -30,7 +30,7 @@
"tenantId": { "index": 0, "kind": "header", "displayName": "", "group":
"network port router", "label": "network port router", "required": false,
"javaType": "String", "deprecated": false, "deprecationNote": "", "autowired":
false, "secret": false, "description": "Tenant ID.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#TENANT_ID" },
"networkId": { "index": 1, "kind": "header", "displayName": "", "group":
"subnet port", "label": "subnet port", "required": false, "javaType": "String",
"deprecated": false, "deprecationNote": "", "autowired": false, "secret":
false, "description": "Network ID.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#NETWORK_ID" },
"adminStateUp": { "index": 2, "kind": "header", "displayName": "",
"group": "network", "label": "network", "required": false, "javaType":
"Boolean", "deprecated": false, "deprecationNote": "", "autowired": false,
"secret": false, "description": "AdminStateUp header.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#ADMIN_STATE_UP"
},
-"networkType": { "index": 3, "kind": "header", "displayName": "", "group":
"network", "label": "network", "required": false, "javaType":
"org.openstack4j.model.network.NetworkType", "enum": [ "LOCAL", "FLAT", "VLAN",
"VXLAN", "GRE" ], "deprecated": false, "deprecationNote": "", "autowired":
false, "secret": false, "description": "Network type.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#NETWORK_TYPE" },
+"networkType": { "index": 3, "kind": "header", "displayName": "", "group":
"network", "label": "network", "required": false, "javaType":
"org.openstack4j.model.network.NetworkType", "enum": [ "LOCAL", "FLAT", "VLAN",
"VXLAN", "GRE", "GENEVE" ], "deprecated": false, "deprecationNote": "",
"autowired": false, "secret": false, "description": "Network type.",
"constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#NETWORK_TYPE" },
"physicalNetwork": { "index": 4, "kind": "header", "displayName": "",
"group": "network", "label": "network", "required": false, "javaType":
"String", "deprecated": false, "deprecationNote": "", "autowired": false,
"secret": false, "description": "Physical network.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#PHYSICAL_NETWORK"
},
"segmentId": { "index": 5, "kind": "header", "displayName": "", "group":
"network", "label": "network", "required": false, "javaType": "String",
"deprecated": false, "deprecationNote": "", "autowired": false, "secret":
false, "description": "Segment ID.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#SEGMENT_ID" },
"isShared": { "index": 6, "kind": "header", "displayName": "", "group":
"network", "label": "network", "required": false, "javaType": "Boolean",
"deprecated": false, "deprecationNote": "", "autowired": false, "secret":
false, "description": "Is shared.", "constantName":
"org.apache.camel.component.openstack.neutron.NeutronConstants#IS_SHARED" },
diff --git
a/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/spring-rabbitmq.json
b/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/spring-rabbitmq.json
index e6f3f22afa1..4622f92ea46 100644
---
a/catalog/camel-catalog-provider-springboot/src/main/resources/org/apache/camel/springboot/catalog/components/spring-rabbitmq.json
+++
(camel) branch main updated: CAMEL-20803: camel-spring-rabbitmq - Configuring maximumRetryAttempts should accept 0
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new bc54c4929bd CAMEL-20803: camel-spring-rabbitmq - Configuring
maximumRetryAttempts should accept 0
bc54c4929bd is described below
commit bc54c4929bdb58d5d1c56c6563a620d245d1e3a4
Author: Claus Ibsen
AuthorDate: Sat May 25 09:30:51 2024 +0200
CAMEL-20803: camel-spring-rabbitmq - Configuring maximumRetryAttempts
should accept 0
---
.../org/apache/camel/catalog/components/spring-rabbitmq.json | 2 +-
.../apache/camel/component/springrabbit/spring-rabbitmq.json | 2 +-
.../springrabbit/DefaultListenerContainerFactory.java | 5 -
.../camel/component/springrabbit/SpringRabbitMQEndpoint.java | 2 +-
.../endpoint/dsl/SpringRabbitMQEndpointBuilderFactory.java | 10 ++
.../org/apache/camel/kotlin/components/SpringRabbitmqUriDsl.kt | 8
6 files changed, 17 insertions(+), 12 deletions(-)
diff --git
a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/spring-rabbitmq.json
b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/spring-rabbitmq.json
index 3bd85849ae9..d76ff93530a 100644
---
a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/spring-rabbitmq.json
+++
b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/spring-rabbitmq.json
@@ -94,7 +94,7 @@
"autoStartup": { "index": 13, "kind": "parameter", "displayName": "Auto
Startup", "group": "consumer", "label": "consumer", "required": false, "type":
"boolean", "javaType": "boolean", "deprecated": false, "autowired": false,
"secret": false, "defaultValue": true, "description": "Specifies whether the
consumer container should auto-startup." },
"exchangeType": { "index": 14, "kind": "parameter", "displayName":
"Exchange Type", "group": "consumer", "label": "consumer", "required": false,
"type": "string", "javaType": "java.lang.String", "enum": [ "direct", "fanout",
"headers", "topic" ], "deprecated": false, "autowired": false, "secret": false,
"defaultValue": "direct", "description": "The type of the exchange" },
"exclusive": { "index": 15, "kind": "parameter", "displayName":
"Exclusive", "group": "consumer", "label": "consumer", "required": false,
"type": "boolean", "javaType": "boolean", "deprecated": false, "autowired":
false, "secret": false, "defaultValue": false, "description": "Set to true for
an exclusive consumer" },
-"maximumRetryAttempts": { "index": 16, "kind": "parameter", "displayName":
"Maximum Retry Attempts", "group": "consumer", "label": "consumer", "required":
false, "type": "integer", "javaType": "int", "deprecated": false, "autowired":
false, "secret": false, "defaultValue": 5, "description": "How many times a
Rabbitmq consumer will retry the same message if Camel failed to process the
message" },
+"maximumRetryAttempts": { "index": 16, "kind": "parameter", "displayName":
"Maximum Retry Attempts", "group": "consumer", "label": "consumer", "required":
false, "type": "integer", "javaType": "int", "deprecated": false, "autowired":
false, "secret": false, "defaultValue": 5, "description": "How many times a
Rabbitmq consumer will try the same message if Camel failed to process the
message (The number of attempts includes the initial try)" },
"noLocal": { "index": 17, "kind": "parameter", "displayName": "No Local",
"group": "consumer", "label": "consumer", "required": false, "type": "boolean",
"javaType": "boolean", "deprecated": false, "autowired": false, "secret":
false, "defaultValue": false, "description": "Set to true for an no-local
consumer" },
"rejectAndDontRequeue": { "index": 18, "kind": "parameter", "displayName":
"Reject And Dont Requeue", "group": "consumer", "label": "consumer",
"required": false, "type": "boolean", "javaType": "boolean", "deprecated":
false, "autowired": false, "secret": false, "defaultValue": true,
"description": "Whether a Rabbitmq consumer should reject the message without
requeuing. This enables failed messages to be sent to a Dead Letter
Exchange\/Queue, if the broker is so configured." },
"retryDelay": { "index": 19, "kind": "parameter", "displayName": "Retry
Delay", "group": "consumer", "label": "consumer", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "defaultValue": 1000, "description": "Delay in millis a
Rabbitmq consumer will wait before redelivering a message that Camel failed to
process" },
diff --git
a/components/camel-spring-rabbitmq/src/generated/resources/META-INF/org/apache/camel/component/springrabbit/spring-rabbitmq.json
Re: [PR] CAMEL-20794: AWS2 Kinesis producer supports async client [camel]
davsclaus commented on code in PR #14238:
URL: https://github.com/apache/camel/pull/14238#discussion_r1614378502
##
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Producer.java:
##
@@ -47,11 +53,28 @@ public Kinesis2Endpoint getEndpoint() {
@Override
public void process(Exchange exchange) throws Exception {
+Exception exceptionThrownByPutRecord = this.exceptionThrownByPutRecord;
+if (exceptionThrownByPutRecord != null) {
+this.exceptionThrownByPutRecord = null;
+throw exceptionThrownByPutRecord;
+}
+
PutRecordRequest request = createRequest(exchange);
-PutRecordResponse putRecordResult =
connection.getClient(getEndpoint()).putRecord(request);
-Message message = getMessageForResponse(exchange);
-message.setHeader(Kinesis2Constants.SEQUENCE_NUMBER,
putRecordResult.sequenceNumber());
-message.setHeader(Kinesis2Constants.SHARD_ID,
putRecordResult.shardId());
+if (getEndpoint().getConfiguration().isAsyncClient()) {
Review Comment:
This is wrong, as you cannot use async client in a camel producer that is
fully synchronous. Camel needs to be aware that this is async and route
accordingly - this kind of work is complex and takes time to understand how to
do it.
##
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Producer.java:
##
@@ -47,11 +53,28 @@ public Kinesis2Endpoint getEndpoint() {
@Override
public void process(Exchange exchange) throws Exception {
+Exception exceptionThrownByPutRecord = this.exceptionThrownByPutRecord;
Review Comment:
This is not as good as concurrent calls could lead to thread safety issues -
Use AtomicInstance or what the name is.
Also its not understandable why a previous exception should cause the next
to fail. There is no batch stuff here.
I think you should seperate the items you try to help with
- batching (make this work with current client)
- async (much harder - wait with this as its not needed asap)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Github Actions] Periodic Sync Camel Spring Boot (Camel 4) [camel-spring-boot]
davsclaus closed pull request #1152: [Github Actions] Periodic Sync Camel Spring Boot (Camel 4) URL: https://github.com/apache/camel-spring-boot/pull/1152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
