[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1334175107 @oscerd the experimental Kamelets are now included in the catalog. Because of validation scripts I ended up with following naming: - aws-s3-experimental-source - aws-ddb-experimental-sink All checks are green! From my side this is good to be merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333727647 @oscerd @lburgazzoli @davsclaus look at this all checks have passed 😄 So what we have right now is following: - reverted AWS S3 source and AWS DDB sink Kamelet to not use data types and they work as it has been before - introduced experimental Kamelets (in experimental top level folder) that make use of data types utils - add some YAKS test coverage for experimental Kamelets that are also part of the GitHub actions CI jobs Only question is if we should include the experimental Kamelets into the catalog right now or leave them in experimental folder for now. I am happy with both ways but I guess it will be easier for people to give it a try when they are part of the catalog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333648650 @oscerd unfortunately is is still failing after rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-188989 @davsclaus yes, good to know. at the moment the experimental folder is not inside `kamelets` but right next to it as a top level folder. so experimental Kamelets will not be included in the catalog at the moment. @oscerd suggested to add those experimental Kamelets to the catalog. I am fine with it. When thinking about it it might be good to include them because then people can give it a try. I could add `@experimental` tag to the tests for these Kamelets so we can separate the tests, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331920845 The changes should not harm existing runtimes and integrations. The operator may build a new integration kit because of the additional utils dependency but that should be all. The YAKS tests that we have should make sure that the DDB sink Kamelet is still working as it was before. I have not changed the tests and they run successful in this PR. Also we have new YAKS tests for AWS S3 source that also verify the default behavior of the Kamelet as it has been before. @oscerd @lburgazzoli I think we can wait for the end of the day and then make a decision. I can work on some of the open points today so we should only have these left overs that we can tackle in follow-up iterations: - Make factory finder mechanism work in camel-quarkus (may lead to a new Camel K release) - Disable classpath scan by default and use lazy loading via factory finder as a result of the point above - Generate factory finder META-INF files as done in Camel core - Add DataTypeRegistry as singleton to the Camel registry to avoid local instances per Kamelet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1327293062 @oscerd all checks have passed now. I think this is ready for a final review. I have provided some fixes to YAKS tests in general so they are all successful now (before the tests actually have been skipped reporting green jobs). I will backport the YAKS related fixes to 0.9 once this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1326773729 @davsclaus absolutely! IMO this should go to Camel core in the long term. That's why I was adding all those spi and api parts as well as the registry with factory finder lookup as part of this solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1326636455 @oscerd rebase is done. Tomorrow I can have a look at the YAKS tests if you have some more time with the release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1323810108 also I see I need to rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #1162: chore: Introduce Kamelet input/output data types
christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1323809422 @oscerd I was adding some more commits while iterating and improving the PR. Do you want me to squash the shanges to some essential commits first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
