Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
gansheer closed pull request #5321: feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 URL: https://github.com/apache/camel-k/pull/5321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
squakez commented on PR #5321: URL: https://github.com/apache/camel-k/pull/5321#issuecomment-2039553132 @gansheer may I suggest a different strategy? Whenever we upgrade dependency, we better do it one by one instead of doing one shot, in order to understand which is the dependency that really fails. IMO, the first thing to do is to upgrade kubernetes only. We can bump to 1.28 and later to 1.29. Once we are sure that all is stable, we can bump any other dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
gansheer commented on code in PR #5321:
URL: https://github.com/apache/camel-k/pull/5321#discussion_r1553198633
##
pkg/cmd/operator/operator.go:
##
@@ -201,22 +202,27 @@ func Run(healthPort, monitoringPort int32, leaderElection
bool, leaderElectionID
}
}
+ defaultNamespaces := map[string]cache.Config{
+ operatorNamespace: {},
Review Comment:
It's a little more complex than that. As per this
[discussion](https://github.com/kubernetes-sigs/controller-runtime/issues/2456#issuecomment-1774118374)
the CRDs are expected to be installed when we configure the cache.
I think I may need to remove `{}` from the selectors as it
is not always installed. I could do conditional addition of
`{}` but that suppose any change in the presence of the CRD
will mean re-creation of the operator pod(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
gansheer commented on code in PR #5321:
URL: https://github.com/apache/camel-k/pull/5321#discussion_r1553198633
##
pkg/cmd/operator/operator.go:
##
@@ -201,22 +202,27 @@ func Run(healthPort, monitoringPort int32, leaderElection
bool, leaderElectionID
}
}
+ defaultNamespaces := map[string]cache.Config{
+ operatorNamespace: {},
Review Comment:
It's a little more complicated than that. As per this
[discussion](https://github.com/kubernetes-sigs/controller-runtime/issues/2456#issuecomment-1774118374)
the CRDs are expected to be installed when we configure the cache.
I think I may need to remove `{}` from the selectors as it
is not always installed. I could do conditional addition of
`{}` but that suppose any change in the presence of the CRD
will mean re-creation of the operator pod(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
squakez commented on code in PR #5321:
URL: https://github.com/apache/camel-k/pull/5321#discussion_r1553075954
##
pkg/cmd/operator/operator.go:
##
@@ -201,22 +202,27 @@ func Run(healthPort, monitoringPort int32, leaderElection
bool, leaderElectionID
}
}
+ defaultNamespaces := map[string]cache.Config{
+ operatorNamespace: {},
Review Comment:
You're probably missing to include the `watchNamespace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
squakez commented on PR #5321: URL: https://github.com/apache/camel-k/pull/5321#issuecomment-2039140225 I don't think we should backport this to 2.3 as it may pose some compatibility problems with the existing running platform. Ie, the user is running a 2.3.0 version and the upgrade to 2.3.1 should work on the very same platform he's running 2.3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
gansheer commented on PR #5321: URL: https://github.com/apache/camel-k/pull/5321#issuecomment-2038099928 > Is this expected to be merged for Camel K 2.3 ? It would be important to consider [openshift 4.14 uses kubernetes api 1.27](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.14/html-single/release_notes/index#ocp-4-14-about-this-release). For now this is for main, so post 2.3. Before backporting I need to run the test on Openshift 4.14. > According to the [kubernetes-version-compatibility](https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/VERSIONING.md#kubernetes-version-compatibility), it should still be compatible with Kubernetes API version N-3 or N-4 The test needs to run on Openshift 4.14 because other dependency upgrade that come with it, like the one on client-go, could have an impact somewhere, and the compatibility is not 100% (see https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters). After this one is fully done there should be the upgrade for API 1.29 and controller-runtime 0.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
lburgazzoli commented on PR #5321: URL: https://github.com/apache/camel-k/pull/5321#issuecomment-2037164928 > Is this expected to be merged for Camel K 2.3 ? It would be important to consider [openshift 4.14 uses kubernetes api 1.27](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.14/html-single/release_notes/index#ocp-4-14-about-this-release). According to the [kubernetes-version-compatibility](https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/VERSIONING.md#kubernetes-version-compatibility), it should still be compatible with Kubernetes API version N-3 or N-4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
claudio4j commented on PR #5321: URL: https://github.com/apache/camel-k/pull/5321#issuecomment-2036871990 Is this expected to be merged for Camel K 2.3 ? It would be important to consider [openshift 4.14 uses kubernetes api 1.27](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.14/html-single/release_notes/index#ocp-4-14-about-this-release). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
gansheer commented on code in PR #5321:
URL: https://github.com/apache/camel-k/pull/5321#discussion_r1551275458
##
pkg/cmd/operator/operator.go:
##
@@ -201,22 +202,26 @@ func Run(healthPort, monitoringPort int32, leaderElection
bool, leaderElectionID
}
}
+ defaultNamespaces := map[string]cache.Config{
+ operatorNamespace: {},
+ }
+
options := cache.Options{
- ByObject: selectors,
Review Comment:
You are right, something got lost here. I will add it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
squakez commented on code in PR #5321:
URL: https://github.com/apache/camel-k/pull/5321#discussion_r1551252536
##
pkg/cmd/operator/operator.go:
##
@@ -201,22 +202,26 @@ func Run(healthPort, monitoringPort int32, leaderElection
bool, leaderElectionID
}
}
+ defaultNamespaces := map[string]cache.Config{
+ operatorNamespace: {},
+ }
+
options := cache.Options{
- ByObject: selectors,
Review Comment:
We need to include those selector somewhere for caching reason. It seems
this is no longer applied anywhere, or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 [camel-k]
gansheer opened a new pull request, #5321: URL: https://github.com/apache/camel-k/pull/5321 Ref #5211 Ref #5307 Upgrade API kubernetes 1.28 and controller-runtime to 0.16 **Release Note** ```release-note feat(core): Upgrade API kubernetes 1.28 and controller-runtime to 0.16 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
