[jira] [Commented] (CASSANDRA-12151) Audit logging for database activity
[ https://issues.apache.org/jira/browse/CASSANDRA-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030404#comment-17030404 ] Laxmikant Upadhyay commented on CASSANDRA-12151: Alpha-3 is about to release (voting has been done) . Regarding post alpha release you can track by referring to details in mail from Joshua regarding current 4.0 release status. [https://mail.google.com/mail/u/0/#search/label%3Acassandra+alpha/FMfcgxwGDDhhxLTfQtPlFsBhfXKNQSnB] > Audit logging for database activity > --- > > Key: CASSANDRA-12151 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12151 > Project: Cassandra > Issue Type: New Feature >Reporter: stefan setyadi >Assignee: Vinay Chella >Priority: Normal > Labels: fqltool > Fix For: 4.0 > > Attachments: 12151.txt, CASSANDRA_12151-benchmark.html, > DesignProposal_AuditingFeature_ApacheCassandra_v1.docx > > > we would like a way to enable cassandra to log database activity being done > on our server. > It should show username, remote address, timestamp, action type, keyspace, > column family, and the query statement. > it should also be able to log connection attempt and changes to the > user/roles. > I was thinking of making a new keyspace and insert an entry for every > activity that occurs. > Then It would be possible to query for specific activity or a query targeting > a specific keyspace and column family. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15469) IndexInfo/ColumnIndex Refactors & Cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030370#comment-17030370 ] Dinesh Joshi commented on CASSANDRA-15469: -- [~jrwest], LGTM +1. > IndexInfo/ColumnIndex Refactors & Cleanup > - > > Key: CASSANDRA-15469 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15469 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0-beta > > > Changes determined by audit of IndexInfo and ColumnIndex changes for > Cassandra 4.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15469) IndexInfo/ColumnIndex Refactors & Cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15469: - Status: Ready to Commit (was: Review In Progress) > IndexInfo/ColumnIndex Refactors & Cleanup > - > > Key: CASSANDRA-15469 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15469 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0-beta > > > Changes determined by audit of IndexInfo and ColumnIndex changes for > Cassandra 4.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15475) Full Query Logging - New Feature
[ https://issues.apache.org/jira/browse/CASSANDRA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15475: - Status: Ready to Commit (was: Review In Progress) > Full Query Logging - New Feature > > > Key: CASSANDRA-15475 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15475 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added a page on Full Query logging, a new feature. > https://github.com/apache/cassandra/pull/404 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15545: -- Source Control Link: https://github.com/apache/cassandra/commit/2f5db64992d4972c9294568906ce34c9368fa4ca Resolution: Fixed Status: Resolved (was: Ready to Commit) > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Update nodetool repair help command to clarify token ranges
This is an automated email from the ASF dual-hosted git repository.
clohfink pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 2f5db64 Update nodetool repair help command to clarify token ranges
2f5db64 is described below
commit 2f5db64992d4972c9294568906ce34c9368fa4ca
Author: David Capwell
AuthorDate: Tue Feb 4 21:25:46 2020 -0800
Update nodetool repair help command to clarify token ranges
Patch by David Capwell; Reviewed by Chris Lohfink for CASSANDRA-15545
---
src/java/org/apache/cassandra/tools/nodetool/Repair.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/java/org/apache/cassandra/tools/nodetool/Repair.java
b/src/java/org/apache/cassandra/tools/nodetool/Repair.java
index 8347afc..990d241 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/Repair.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/Repair.java
@@ -62,10 +62,10 @@ public class Repair extends NodeToolCmd
@Option(title = "specific_host", name = {"-hosts", "--in-hosts"},
description = "Use -hosts to repair specific hosts")
private List specificHosts = new ArrayList<>();
-@Option(title = "start_token", name = {"-st", "--start-token"},
description = "Use -st to specify a token at which the repair range starts")
+@Option(title = "start_token", name = {"-st", "--start-token"},
description = "Use -st to specify a token at which the repair range starts
(exclusive)")
private String startToken = EMPTY;
-@Option(title = "end_token", name = {"-et", "--end-token"}, description =
"Use -et to specify a token at which repair range ends")
+@Option(title = "end_token", name = {"-et", "--end-token"}, description =
"Use -et to specify a token at which repair range ends (inclusive)")
private String endToken = EMPTY;
@Option(title = "primary_range", name = {"-pr", "--partitioner-range"},
description = "Use -pr to repair only the first range returned by the
partitioner")
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15545: -- Fix Version/s: 4.0 > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[
https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030364#comment-17030364
]
Chris Lohfink commented on CASSANDRA-15545:
---
{code}
NAME
nodetool repair - Repair one or more tables
SYNOPSIS
nodetool [(-h | --host )] [(-p | --port )]
[(-pp | --print-port)] [(-pw | --password
)]
[(-pwf | --password-file )]
[(-u | --username )] repair
[(-dc | --in-dc )...]
[(-dcpar | --dc-parallel)] [(-et | --end-token
)]
[(-force | --force)] [(-full | --full)]
[(-hosts | --in-hosts )...]
[(-j | --job-threads )]
[(-local | --in-local-dc)] [(-os | --optimise-streams)] [(-pl |
--pull)]
[(-pr | --partitioner-range)] [(-prv | --preview)]
[(-seq | --sequential)]
[(-st | --start-token )] [(-tr |
--trace)]
[(-vd | --validate)] [--] [ ...]
OPTIONS
...
-et , --end-token
Use -et to specify a token at which repair range ends (inclusive)
...
-st , --start-token
Use -st to specify a token at which the repair range starts
(exclusive)
...
{code}
> update nodetool repair help command to document when a token is inclusive or
> exclusive
> --
>
> Key: CASSANDRA-15545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15545
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Should add inclusive and exclusive comments in repair to make it clear what
> the range is
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15545: -- Status: Ready to Commit (was: Review In Progress) > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15545: -- Reviewers: Chris Lohfink, Chris Lohfink (was: Chris Lohfink) Chris Lohfink, Chris Lohfink Status: Review In Progress (was: Patch Available) > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030363#comment-17030363 ] Chris Lohfink commented on CASSANDRA-15545: --- +1 > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15546) Operation timeout when creating a keyspace/table.
YCozy created CASSANDRA-15546:
-
Summary: Operation timeout when creating a keyspace/table.
Key: CASSANDRA-15546
URL: https://issues.apache.org/jira/browse/CASSANDRA-15546
Project: Cassandra
Issue Type: Bug
Reporter: YCozy
When testing Cassandra with network partitions, we have observed the following
failure from time to time:
# Start a three-node cluster, say node1, node2, and node3.
# Partition node3 from node1 and node2.
# Use cqlsh to contact node1 to create a keyspace/table. The cqlsh and node1
runs on the same host.
# Notice that cqlsh fails with the following error:
{code:java}
:1:OperationTimedOut: errors={'127.0.0.1': 'Client request timeout. See
Session.execute[_async](timeout)'}, last_host=127.0.0.1{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030316#comment-17030316
]
David Capwell commented on CASSANDRA-10190:
---
Starting review now; looking at the bash script since I know that better
https://github.com/apache/cassandra/compare/trunk...dineshjoshi:10190-trunk-review#diff-6469b081699ab92c53e0513a499ca5ebL18
{code}
$ shellcheck cqlsh
In cqlsh line 53:
version=$(which $interpreter > /dev/null 2>&1 && $interpreter -c
"import os; print('{}.{}'.format(os.sys.version_info.major,
os.sys.version_info.minor))")
^---^ SC2230: which is non-standard. Use builtin 'command -v'
instead.
^--^ SC2086: Double quote to prevent globbing
and word splitting.
Did you mean:
version=$(which "$interpreter" > /dev/null 2>&1 && $interpreter -c
"import os; print('{}.{}'.format(os.sys.version_info.major,
os.sys.version_info.minor))")
In cqlsh line 60:
if [ "$version" = "3.6" -o "$version" = "2.7" ]; then
^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ]
is not well defined.
In cqlsh line 70:
version=$(get_python_version $interpreter)
^--^ SC2086: Double quote to
prevent globbing and word splitting.
Did you mean:
version=$(get_python_version "$interpreter")
In cqlsh line 72:
if [ "$(is_supported_version $version)" = "supported" ]; then
^--^ SC2086: Double quote to
prevent globbing and word splitting.
Did you mean:
if [ "$(is_supported_version "$version")" = "supported" ]; then
In cqlsh line 73:
exec $interpreter "`$interpreter -c "import os;
print(os.path.dirname(os.path.realpath('$0')))"`/cqlsh.py" $params
^--^ SC2086: Double quote to prevent
globbing and word splitting.
^-- SC2006: Use $(...) notation
instead of legacy backticked `...`.
^-^ SC2086: Double quote
to prevent globbing and word splitting.
Did you mean:
exec "$interpreter" "$($interpreter -c "import os;
print(os.path.dirname(os.path.realpath('$0')))")/cqlsh.py" "$params"
For more information:
https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] || [ q ] as [ p -o q...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2230 -- which is non-standard. Use builti...
{code}
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 4.0-alpha
>
> Attachments:
> 0001-Fix-issues-from-version-specific-logic-commit.patch,
> 0001-Update-six-to-1.12.0.patch,
> 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch,
> coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15545: -- Test and Documentation Plan: PR linked. Testing ignored since this is a documentation change; only made sure Nodetool compiled... Status: Patch Available (was: Open) > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15545: --- Labels: pull-request-available (was: ) > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
[ https://issues.apache.org/jira/browse/CASSANDRA-15545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15545: -- Change Category: Code Clarity Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > update nodetool repair help command to document when a token is inclusive or > exclusive > -- > > Key: CASSANDRA-15545 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > > Should add inclusive and exclusive comments in repair to make it clear what > the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15545) update nodetool repair help command to document when a token is inclusive or exclusive
David Capwell created CASSANDRA-15545: - Summary: update nodetool repair help command to document when a token is inclusive or exclusive Key: CASSANDRA-15545 URL: https://issues.apache.org/jira/browse/CASSANDRA-15545 Project: Cassandra Issue Type: Improvement Components: Tool/nodetool Reporter: David Capwell Assignee: David Capwell Should add inclusive and exclusive comments in repair to make it clear what the range is -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[
https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030302#comment-17030302
]
David Capwell commented on CASSANDRA-15542:
---
Ran the test with
{code}
.withExamples(50_000_000)
{code}
just to make sure this was stable (ran with higher but qt memory became the
issue).
All comments in GitHub are not blocking but would be good to address.
+1
> In JVM test for repairs on token boundaries
>
>
> Key: CASSANDRA-15542
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15542
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Low
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Putting partitions on each token range +-1 and making sure the logic end to
> end with repairs correctly handle inclusive and exclusivity of the bounds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030297#comment-17030297 ] David Capwell commented on CASSANDRA-15542: --- left comments in PR. Overall LGTM. I plan to run the property test a few times locally to make sure it doesn't fail later. > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15475) Full Query Logging - New Feature
[ https://issues.apache.org/jira/browse/CASSANDRA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15475: - Reviewers: Dinesh Joshi, Yifan Cai, Dinesh Joshi (was: Dinesh Joshi, Yifan Cai) Dinesh Joshi, Yifan Cai, Dinesh Joshi (was: Dinesh Joshi, Yifan Cai) Status: Review In Progress (was: Patch Available) > Full Query Logging - New Feature > > > Key: CASSANDRA-15475 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15475 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added a page on Full Query logging, a new feature. > https://github.com/apache/cassandra/pull/404 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030214#comment-17030214 ] Chris Lohfink commented on CASSANDRA-15542: --- | [pull request|https://github.com/apache/cassandra/pull/435] | [circleci|https://circleci.com/gh/clohfink/cassandra/656] | > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15544) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables
Brandon Williams created CASSANDRA-15544:
Summary: Fix flakey test -
org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables
Key: CASSANDRA-15544
URL: https://issues.apache.org/jira/browse/CASSANDRA-15544
Project: Cassandra
Issue Type: Bug
Components: Test/unit
Reporter: Brandon Williams
{code}
[junit-timeout] Testcase:
testMultiExpressionQueriesWhereRowSplitBetweenSSTables(org.apache.cassandra.index.sasi.SASIIndexTest):
FAILED
[junit-timeout] []
[junit-timeout] junit.framework.AssertionFailedError: []
[junit-timeout] at
org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:589)
[junit-timeout] at
org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:468)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test org.apache.cassandra.index.sasi.SASIIndexTest FAILED
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030193#comment-17030193 ] David Capwell commented on CASSANDRA-10190: --- was asked to help out with review. I don't know python well so won't be able to help too much there, so ill focus more on automation within the context of CI and help get this tested. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-10190: -- Reviewers: Andy Tolbert, David Capwell, Dinesh Joshi (was: Andy Tolbert, Dinesh Joshi) > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15542: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell Status: Review In Progress (was: Patch Available) adding self for reviewer so I don't forget. > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15475) Full Query Logging - New Feature
[ https://issues.apache.org/jira/browse/CASSANDRA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030162#comment-17030162 ] Yifan Cai commented on CASSANDRA-15475: --- LGTM +1 > Full Query Logging - New Feature > > > Key: CASSANDRA-15475 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15475 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added a page on Full Query logging, a new feature. > https://github.com/apache/cassandra/pull/404 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030151#comment-17030151
]
Brandon Williams edited comment on CASSANDRA-15313 at 2/4/20 10:01 PM:
---
This is mostly due to the two places where a rather large example size is used,
500. I did many runs lowering this number until I could be sure there were no
timeouts, and that number is 35. However, once the test was not always timing
out (at around 40 examples) it discovered a seed that always fails:
{code:java}
[junit-timeout] Seed was 552252992721215
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falsify(ExceptionReporter.java:43)
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falisification(ExceptionReporter.java:37)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.reportFalsification(TheoryRunner.java:48)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:37)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
[junit-timeout] at
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:88)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest FAILED
{code}
Sometimes instead of failing the test, it will crash the jvm here:
{code:java}
[junit-timeout] # C [liblz4-java4100719362944375598.so+0x5eb7]
LZ4_decompress_fast+0x117
{code}
I've reproduced this against lz4 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.7.0, and
1.7.1. I think beyond the flakiness which can be solved by reducing the amount
of examples, we've got a legitimate bug in lz4. I pushed the branch to
reproduce here: [https://github.com/driftx/cassandra/tree/CASSANDRA-15313]
You'll need to override the test timeout as this takes around 7 minutes.
WDYT, [~samt]?
was (Author: brandon.williams):
This is mostly due to the two places where a rather large example size is used,
500. I did many runs lowering this number until I could be sure there were no
timeouts, and that number is 35. However, once the test was not always timing
out (at around 40 examples) it discovered a seed that always fails:
{code:java}
[junit-timeout] Seed was 552252992721215
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falsify(ExceptionReporter.java:43)
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falisification(ExceptionReporter.java:37)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.reportFalsification(TheoryRunner.java:48)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:37)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
[junit-timeout] at
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:88)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest FAILED
{code}
Sometimes instead of failing the test, it will crash the jvm here:
{code:java}
[junit-timeout] # C [liblz4-java4100719362944375598.so+0x5eb7]
LZ4_decompress_fast+0x117
{code}
I've reproduced this against lz4 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.7.0, and
1.7.1. I think beyond the flakiness which can be solved by reducing the amount
of examples, we've got a legitimate bug in lz4. I pushed the branch to
reproduce here: https://github.com/driftx/cassandra/tree/CASSANDRA-15313
WDYT, [~samt]?
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030151#comment-17030151
]
Brandon Williams commented on CASSANDRA-15313:
--
This is mostly due to the two places where a rather large example size is used,
500. I did many runs lowering this number until I could be sure there were no
timeouts, and that number is 35. However, once the test was not always timing
out (at around 40 examples) it discovered a seed that always fails:
{code:java}
[junit-timeout] Seed was 552252992721215
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falsify(ExceptionReporter.java:43)
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falisification(ExceptionReporter.java:37)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.reportFalsification(TheoryRunner.java:48)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:37)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
[junit-timeout] at
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:88)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest FAILED
{code}
Sometimes instead of failing the test, it will crash the jvm here:
{code:java}
[junit-timeout] # C [liblz4-java4100719362944375598.so+0x5eb7]
LZ4_decompress_fast+0x117
{code}
I've reproduced this against lz4 1.4.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.7.0, and
1.7.1. I think beyond the flakiness which can be solved by reducing the amount
of examples, we've got a legitimate bug in lz4. I pushed the branch to
reproduce here: https://github.com/driftx/cassandra/tree/CASSANDRA-15313
WDYT, [~samt]?
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030127#comment-17030127
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
Alright, thanks for checking. I will work on this probably tomorrow morning.
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030124#comment-17030124
]
David Capwell commented on CASSANDRA-15527:
---
I have yet to see it fail on java 8; all failures were java 11.
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030121#comment-17030121
]
David Capwell commented on CASSANDRA-15527:
---
The tests run against 8 and 11 and the first failure I saw was 11; ill double
check to see if I can find it failing on java 8
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12151) Audit logging for database activity
[ https://issues.apache.org/jira/browse/CASSANDRA-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030119#comment-17030119 ] Dhawal Mody commented on CASSANDRA-12151: - [~laxmikant99] and team - when do you think cassandra 4.0 post-alpha will be released? > Audit logging for database activity > --- > > Key: CASSANDRA-12151 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12151 > Project: Cassandra > Issue Type: New Feature >Reporter: stefan setyadi >Assignee: Vinay Chella >Priority: Normal > Labels: fqltool > Fix For: 4.0 > > Attachments: 12151.txt, CASSANDRA_12151-benchmark.html, > DesignProposal_AuditingFeature_ApacheCassandra_v1.docx > > > we would like a way to enable cassandra to log database activity being done > on our server. > It should show username, remote address, timestamp, action type, keyspace, > column family, and the query statement. > it should also be able to log connection attempt and changes to the > user/roles. > I was thinking of making a new keyspace and insert an entry for every > activity that occurs. > Then It would be possible to query for specific activity or a query targeting > a specific keyspace and column family. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova reassigned CASSANDRA-15527:
---
Assignee: Ekaterina Dimitrova
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030097#comment-17030097
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
Hi [~dcapwell],
Just to confirm, this was tested only with 11 or it is not an issue with 8?
My experience is primarily with v8 but I can give it a try.
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14740) BlockingReadRepair does not maintain monotonicity during range movements
[
https://issues.apache.org/jira/browse/CASSANDRA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030054#comment-17030054
]
Sam Tunnicliffe commented on CASSANDRA-14740:
-
Sorry, this broke {{MessageForwardingTest}} by forcing the RF of the test
keyspace to 3; I mistakenly thought that test was already failing before.
Fixed in a follow up commit
[{{cb4314ee96}}|https://github.com/apache/cassandra/commit/cb4314ee96922f870f5b30d6594a42d2007a5bb2]
with CI runs for
[jdk8|https://circleci.com/workflow-run/3e9a34a0-a6b7-4b41-9e7f-667233f858c6]
and
[jdk11|https://circleci.com/workflow-run/442cd66f-25c4-4d39-988b-7bdd3aceae5a]
> BlockingReadRepair does not maintain monotonicity during range movements
>
>
> Key: CASSANDRA-14740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14740
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: Benedict Elliott Smith
>Assignee: Benedict Elliott Smith
>Priority: Urgent
> Labels: correctness
> Fix For: 4.0, 4.0-alpha
>
>
> The BlockingReadRepair code introduced by CASSANDRA-10726 requires that each
> of the queried nodes are written to, but pending nodes are not considered.
> If there is a pending range movement, one of these writes may be ‘lost’ when
> the range movement completes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: ninja correct RF for test keyspace in DistributedTestBase
This is an automated email from the ASF dual-hosted git repository.
samt pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new cb4314e ninja correct RF for test keyspace in DistributedTestBase
cb4314e is described below
commit cb4314ee96922f870f5b30d6594a42d2007a5bb2
Author: Sam Tunnicliffe
AuthorDate: Tue Feb 4 18:15:05 2020 +
ninja correct RF for test keyspace in DistributedTestBase
Follow up fo CASSANDRA-14740
---
.../org/apache/cassandra/distributed/test/DistributedTestBase.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/DistributedTestBase.java
b/test/distributed/org/apache/cassandra/distributed/test/DistributedTestBase.java
index 65224ea..9f46b34 100644
---
a/test/distributed/org/apache/cassandra/distributed/test/DistributedTestBase.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/DistributedTestBase.java
@@ -78,7 +78,7 @@ public class DistributedTestBase
protected static > C init(C cluster)
{
-return init(cluster, Math.min(3, cluster.size()));
+return init(cluster, cluster.size());
}
protected static > C init(C cluster, int
replicationFactor)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14740) BlockingReadRepair does not maintain monotonicity during range movements
[ https://issues.apache.org/jira/browse/CASSANDRA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030047#comment-17030047 ] David Capwell commented on CASSANDRA-14740: --- spoke to sam about this; MessageForwardingTest is a regression and not an existing issue. This test used to fail on java 11 (was stable on java 8) because of a change in behavior of java Streams; Blake fixed that in 1f7e3c2835c79363025a01a8470ee85d17457cf8 and since then the test has been stable. The test is now failing in both java 8 and java 11 and isn't flaky, fails 100% of the time. > BlockingReadRepair does not maintain monotonicity during range movements > > > Key: CASSANDRA-14740 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14740 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Coordination >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Urgent > Labels: correctness > Fix For: 4.0, 4.0-alpha > > > The BlockingReadRepair code introduced by CASSANDRA-10726 requires that each > of the queried nodes are written to, but pending nodes are not considered. > If there is a pending range movement, one of these writes may be ‘lost’ when > the range movement completes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030034#comment-17030034
]
Yifan Cai commented on CASSANDRA-15429:
---
Thanks [~ifesdjeen]! The patch LGTM. +1
Thanks [~dcapwell] for double checking!
I also checked the other branches, 30 and 22. They look good.
{{NodeToolCmd#connect}} uses the probe created from the factory.
> Support NodeTool for in-jvm dtest
> -
>
> Key: CASSANDRA-15429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This
> functionality is wanted in some tests, e.g. constructing an end-to-end test
> scenario that uses nodetool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030030#comment-17030030 ] David Capwell commented on CASSANDRA-15429: --- The patch looks fine to me, but I want a green build before +1 > Support NodeTool for in-jvm dtest > - > > Key: CASSANDRA-15429 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > In-JVM dtest framework does not support nodetool as of now. This > functionality is wanted in some tests, e.g. constructing an end-to-end test > scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030029#comment-17030029 ] David Capwell commented on CASSANDRA-15429: --- The linked Circle run is https://circleci.com/workflow-run/fae0c550-399e-422b-8b56-4b226fc03c22 which is failing for dtests. What it looks like is org.apache.cassandra.distributed.test.NativeProtocolTest#withClientRequests fails and doesn't cleanup resources properly, then withCounters fails. [~ifesdjeen] can you file a JIRA for this and rerun the build? > Support NodeTool for in-jvm dtest > - > > Key: CASSANDRA-15429 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > In-JVM dtest framework does not support nodetool as of now. This > functionality is wanted in some tests, e.g. constructing an end-to-end test > scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030027#comment-17030027
]
David Capwell commented on CASSANDRA-15429:
---
Based off the patch I did the following greps
{code}
[davidcapwell ~/src/github/apache/cassandra] (trunk) $ grep -r 'new NodeProbe'
src/
src//java/org/apache/cassandra/tools/NodeTool.java:System.exit(new
NodeTool(new NodeProbeFactory()).execute(args));
src//java/org/apache/cassandra/tools/INodeProbeFactory.java:return new
NodeProbe(host, port);
src//java/org/apache/cassandra/tools/INodeProbeFactory.java:return new
NodeProbe(host, port, username, password);
[davidcapwell ~/src/github/apache/cassandra] (trunk) $ grep -r 'new NodeProbe'
test/
test//unit/org/apache/cassandra/tools/ClearSnapshotTest.java:probe =
new NodeProbe("127.0.0.1", JMX_PORT);
{code}
{code}
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ grep -r 'new
NodeProbe' src/
src//java/org/apache/cassandra/tools/NodeProbeFactory.java:return new
NodeProbe(host, port);
src//java/org/apache/cassandra/tools/NodeProbeFactory.java:return new
NodeProbe(host, port, username, password);
src//java/org/apache/cassandra/tools/NodeTool.java:System.exit(new
NodeTool(new NodeProbeFactory()).execute(args));
src//java/org/apache/cassandra/tools/NodeTool.java:
nodeClient = new NodeProbe(host, parseInt(port));
src//java/org/apache/cassandra/tools/NodeTool.java:
nodeClient = new NodeProbe(host, parseInt(port), username, password);
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ grep -r 'new
NodeProbe' test/
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $
{code}
After applying the patch
{code}
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ curl -o z.diff
https://github.com/ifesdjeen/cassandra/commit/bc4dc9826396e8e23ded8302fcef2fe39324205e.diff
% Total% Received % Xferd Average Speed TimeTime Time Current
Dload Upload Total SpentLeft Speed
100 15930 15930 0 3034 0 --:--:-- --:--:-- --:--:-- 3028
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) $ patch -p1 <
z.diff
patching file src/java/org/apache/cassandra/tools/NodeTool.java
patching file
test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) grep -r 'new
NodeProbe' src/
src//java/org/apache/cassandra/tools/NodeProbeFactory.java:return new
NodeProbe(host, port);
src//java/org/apache/cassandra/tools/NodeProbeFactory.java:return new
NodeProbe(host, port, username, password);
src//java/org/apache/cassandra/tools/NodeTool.java:System.exit(new
NodeTool(new NodeProbeFactory()).execute(args));
[davidcapwell ~/src/github/apache/cassandra] (cassandra-3.11) grep -r 'new
NodeProbe' test/
{code}
> Support NodeTool for in-jvm dtest
> -
>
> Key: CASSANDRA-15429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This
> functionality is wanted in some tests, e.g. constructing an end-to-end test
> scenario that uses nodetool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15542: -- Test and Documentation Plan: na Status: Patch Available (was: Open) > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15542: -- Change Category: Quality Assurance Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030013#comment-17030013 ] David Capwell commented on CASSANDRA-15429: --- well, as long as help is working... =D Ill take a look at [~ifesdjeen] patch in a few minutes. > Support NodeTool for in-jvm dtest > - > > Key: CASSANDRA-15429 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > In-JVM dtest framework does not support nodetool as of now. This > functionality is wanted in some tests, e.g. constructing an end-to-end test > scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15543) flaky test org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement
David Capwell created CASSANDRA-15543:
-
Summary: flaky test
org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement
Key: CASSANDRA-15543
URL: https://issues.apache.org/jira/browse/CASSANDRA-15543
Project: Cassandra
Issue Type: Bug
Components: Test/dtest
Reporter: David Capwell
This fails infrequently, last seen failure was on java 8
{code}
junit.framework.AssertionFailedError
at
org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement(DistributedReadWritePathTest.java:276)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15543) flaky test org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement
[
https://issues.apache.org/jira/browse/CASSANDRA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15543:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-alpha
Severity: Normal
Status: Open (was: Triage Needed)
> flaky test
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement
>
>
> Key: CASSANDRA-15543
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15543
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> This fails infrequently, last seen failure was on java 8
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest.readWithSchemaDisagreement(DistributedReadWritePathTest.java:276)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15486) Dynamo
[ https://issues.apache.org/jira/browse/CASSANDRA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030011#comment-17030011 ] DeepakVohra commented on CASSANDRA-15486: - Thanks [~jolynch]. I have merged your changes. > Dynamo > -- > > Key: CASSANDRA-15486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15486 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added new sections to Dynamo page. > https://github.com/apache/cassandra/pull/415 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15542: --- Labels: pull-request-available (was: ) > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Labels: pull-request-available > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15542: -- Component/s: Test/dtest > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Normal > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15542) In JVM test for repairs on token boundaries
[ https://issues.apache.org/jira/browse/CASSANDRA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15542: -- Priority: Low (was: Normal) > In JVM test for repairs on token boundaries > > > Key: CASSANDRA-15542 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > > Putting partitions on each token range +-1 and making sure the logic end to > end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15542) In JVM test for repairs on token boundaries
Chris Lohfink created CASSANDRA-15542: - Summary: In JVM test for repairs on token boundaries Key: CASSANDRA-15542 URL: https://issues.apache.org/jira/browse/CASSANDRA-15542 Project: Cassandra Issue Type: New Feature Reporter: Chris Lohfink Assignee: Chris Lohfink Putting partitions on each token range +-1 and making sure the logic end to end with repairs correctly handle inclusive and exclusivity of the bounds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15429:
Status: Open (was: Resolved)
Looks like in 3.11, merge went wrong and nodetool won't work (apart from
{{help}}, which doesn't call out to the nodeprobe).
|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup]|
> Support NodeTool for in-jvm dtest
> -
>
> Key: CASSANDRA-15429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This
> functionality is wanted in some tests, e.g. constructing an end-to-end test
> scenario that uses nodetool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029990#comment-17029990
]
Alex Petrov edited comment on CASSANDRA-15429 at 2/4/20 5:00 PM:
-
Looks like in 3.11, merge went wrong and nodetool won't work (apart from
{{help}}, which doesn't call out to the nodeprobe).
|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup]|
If +1'd, I'll commit a test to all branches, and the patch change only to 3.11.
was (Author: ifesdjeen):
Looks like in 3.11, merge went wrong and nodetool won't work (apart from
{{help}}, which doesn't call out to the nodeprobe).
|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup]|
> Support NodeTool for in-jvm dtest
> -
>
> Key: CASSANDRA-15429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This
> functionality is wanted in some tests, e.g. constructing an end-to-end test
> scenario that uses nodetool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15311) Fix flakey test_13595 - consistency_test.TestConsistency
[
https://issues.apache.org/jira/browse/CASSANDRA-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15311:
Resolution: Cannot Reproduce
Status: Resolved (was: Triage Needed)
Cannot be reproduced anymore on v.4. Looks like there is no issue at the moment
> Fix flakey test_13595 - consistency_test.TestConsistency
> -
>
> Key: CASSANDRA-15311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15311
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Joey Lynch
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15311.txt
>
>
> Example failure:
> [https://circleci.com/gh/jolynch/cassandra/559#tests/containers/29]
> {noformat}
> Your job ran 1007 tests with 1 failure
> test_13595 -
> consistency_test.TestConsistencyconsistency_test.pyAssertionError: assert 9
> == 4 + where 4 = 0x7f9f0775b160>>('org.apache.cassandra.metrics:type=Table,name=ShortReadProtectionRequests,keyspace=test,scope=test',
> 'Count') +where > =
> .read_attribute
> self =
> @since('3.0')
> def test_13595(self):
> """
> @jira_ticket CASSANDRA-13595
> """
> cluster = self.cluster
>
> # disable hinted handoff and set batch commit log so this doesn't
> interfere with the test
> cluster.set_configuration_options(values={'hinted_handoff_enabled':
> False})
> cluster.set_batch_commitlog(enabled=True)
>
> cluster.populate(2)
> node1, node2 = cluster.nodelist()
> remove_perf_disable_shared_mem(node1) # necessary for jmx
> cluster.start(wait_other_notice=True)
>
> session = self.patient_cql_connection(node1)
>
> query = "CREATE KEYSPACE IF NOT EXISTS test WITH replication =
> {'class': 'NetworkTopologyStrategy', 'datacenter1': 2};"
> session.execute(query)
>
> query = 'CREATE TABLE IF NOT EXISTS test.test (id int PRIMARY KEY);'
> session.execute(query)
>
> # populate the table with 10 partitions,
> # then delete a bunch of them on different nodes
> # until we get the following pattern:
>
> #token | k | 1 | 2 |
> # -7509452495886106294 | 5 | n | y |
> # -4069959284402364209 | 1 | y | n |
> # -3799847372828181882 | 8 | n | y |
> # -3485513579396041028 | 0 | y | n |
> # -3248873570005575792 | 2 | n | y |
> # -2729420104000364805 | 4 | y | n |
> # 1634052884888577606 | 7 | n | y |
> # 2705480034054113608 | 6 | y | n |
> # 3728482343045213994 | 9 | n | y |
> # 9010454139840013625 | 3 | y | y |
>
> stmt = session.prepare('INSERT INTO test.test (id) VALUES (?);')
> for id in range(0, 10):
> session.execute(stmt, [id], ConsistencyLevel.ALL)
>
> # delete every other partition on node1 while node2 is down
> node2.stop(wait_other_notice=True)
> session.execute('DELETE FROM test.test WHERE id IN (5, 8, 2, 7, 9);')
> node2.start(wait_other_notice=True, wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node2)
>
> # delete every other alternate partition on node2 while node1 is down
> node1.stop(wait_other_notice=True)
> session.execute('DELETE FROM test.test WHERE id IN (1, 0, 4, 6);')
> node1.start(wait_other_notice=True, wait_for_binary_proto=True)
>
> session = self.patient_exclusive_cql_connection(node1)
>
> # until #13595 the query would incorrectly return [1]
> assert_all(session,
>'SELECT id FROM test.test LIMIT 1;',
>[[3]],
>cl=ConsistencyLevel.ALL)
>
> srp = make_mbean('metrics', type='Table',
> name='ShortReadProtectionRequests', keyspace='test', scope='test')
> with JolokiaAgent(node1) as jmx:
> # 4 srp requests for node1 and 5 for node2, total of 9
> > assert 9 == jmx.read_attribute(srp, 'Count')
> E AssertionError: assert 9 == 4
> E+ where 4 = 0x7f9f0775b160>>('org.apache.cassandra.metrics:type=Table,name=ShortReadProtectionRequests,keyspace=test,scope=test',
> 'Count')
> E+where > =
> .read_attribute
> consistency_test.py:1288: AssertionError {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14740) BlockingReadRepair does not maintain monotonicity during range movements
[
https://issues.apache.org/jira/browse/CASSANDRA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-14740:
Fix Version/s: (was: 4.0-beta)
4.0-alpha
Since Version: 4.0-alpha
Source Control Link:
https://github.com/apache/cassandra/commit/0f22dab1a015cb84d9857f940de5a256bfbee083
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed to trunk in {{0f22dab1a015cb84d9857f940de5a256bfbee083}}. Final CI
run after rebasing with only previously known failures:
[jdk8|https://circleci.com/workflow-run/3cb3c20e-6dea-4fd6-8aff-193e1e7d298b] ;
[jdk11|https://circleci.com/workflow-run/024ba3cd-c112-4f73-a562-b364ea420e3c]
> BlockingReadRepair does not maintain monotonicity during range movements
>
>
> Key: CASSANDRA-14740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14740
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination
>Reporter: Benedict Elliott Smith
>Assignee: Benedict Elliott Smith
>Priority: Urgent
> Labels: correctness
> Fix For: 4.0, 4.0-alpha
>
>
> The BlockingReadRepair code introduced by CASSANDRA-10726 requires that each
> of the queried nodes are written to, but pending nodes are not considered.
> If there is a pending range movement, one of these writes may be ‘lost’ when
> the range movement completes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14740) BlockingReadRepair does not maintain monotonicity during range movements
[ https://issues.apache.org/jira/browse/CASSANDRA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-14740: Status: Ready to Commit (was: Changes Suggested) > BlockingReadRepair does not maintain monotonicity during range movements > > > Key: CASSANDRA-14740 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14740 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Coordination >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Urgent > Labels: correctness > Fix For: 4.0, 4.0-beta > > > The BlockingReadRepair code introduced by CASSANDRA-10726 requires that each > of the queried nodes are written to, but pending nodes are not considered. > If there is a pending range movement, one of these writes may be ‘lost’ when > the range movement completes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Restore monotonic read consistency guarantees
This is an automated email from the ASF dual-hosted git repository.
samt pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 0f22dab1a015cb84d9857f940de5a256bfbee083
Author: Benedict Elliott Smith
AuthorDate: Thu Jul 18 14:46:06 2019 +0100
Restore monotonic read consistency guarantees
patch by Benedict; reviewed by Sam Tunnicliffe for CASSANDRA-14740
---
CHANGES.txt| 1 +
.../org/apache/cassandra/db/ConsistencyLevel.java | 2 +-
.../cassandra/locator/ReplicaCollection.java | 5 +
.../org/apache/cassandra/locator/ReplicaPlan.java | 13 ++-
.../org/apache/cassandra/locator/ReplicaPlans.java | 69 +++-
.../cassandra/service/reads/DigestResolver.java| 8 +-
.../cassandra/service/reads/ResponseResolver.java | 2 +-
.../reads/repair/BlockingPartitionRepair.java | 38 ---
.../service/reads/repair/BlockingReadRepair.java | 24 ++--
.../service/reads/repair/NoopReadRepair.java | 2 +-
.../service/reads/repair/ReadOnlyReadRepair.java | 2 +-
.../cassandra/service/reads/repair/ReadRepair.java | 2 +-
.../reads/repair/RowIteratorMergeListener.java | 123 ++--
.../distributed/impl/AbstractCluster.java | 20
.../distributed/test/DistributedTestBase.java | 7 +-
.../cassandra/distributed/test/ReadRepairTest.java | 125 +
...WritePathTest.java => SimpleReadWriteTest.java} | 4 +-
.../service/reads/AbstractReadResponseTest.java| 19 +++-
.../cassandra/service/reads/DataResolverTest.java | 55 ++---
.../reads/repair/AbstractReadRepairTest.java | 36 ++
.../reads/repair/BlockingReadRepairTest.java | 34 +++---
.../repair/DiagEventsBlockingReadRepairTest.java | 21 ++--
.../reads/repair/ReadOnlyReadRepairTest.java | 7 +-
.../service/reads/repair/ReadRepairTest.java | 30 +++--
.../service/reads/repair/TestableReadRepair.java | 2 +-
25 files changed, 495 insertions(+), 156 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 75fae01..6efa148 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-alpha3
+ * Restore monotonic read consistency guarantees for blocking read repair
(CASSANDRA-14740)
* Separate exceptions for CAS write timeout exceptions caused by contention
and unkown result (CASSANDRA-15350)
* Fix in-jvm dtest java 11 compatibility (CASSANDRA-15463)
* Remove joda time dependency (CASSANDRA-15257)
diff --git a/src/java/org/apache/cassandra/db/ConsistencyLevel.java
b/src/java/org/apache/cassandra/db/ConsistencyLevel.java
index 4973915..e685618 100644
--- a/src/java/org/apache/cassandra/db/ConsistencyLevel.java
+++ b/src/java/org/apache/cassandra/db/ConsistencyLevel.java
@@ -101,7 +101,7 @@ public enum ConsistencyLevel
public static ObjectIntOpenHashMap eachQuorumForRead(Keyspace
keyspace)
{
NetworkTopologyStrategy strategy = (NetworkTopologyStrategy)
keyspace.getReplicationStrategy();
-ObjectIntOpenHashMap perDc = new
ObjectIntOpenHashMap<>(strategy.getDatacenters().size());
+ObjectIntOpenHashMap perDc = new
ObjectIntOpenHashMap<>(((strategy.getDatacenters().size() + 1) * 4) / 3);
for (String dc : strategy.getDatacenters())
perDc.put(dc, ConsistencyLevel.localQuorumFor(keyspace, dc));
return perDc;
diff --git a/src/java/org/apache/cassandra/locator/ReplicaCollection.java
b/src/java/org/apache/cassandra/locator/ReplicaCollection.java
index d870316..ec671d5 100644
--- a/src/java/org/apache/cassandra/locator/ReplicaCollection.java
+++ b/src/java/org/apache/cassandra/locator/ReplicaCollection.java
@@ -125,6 +125,11 @@ public interface ReplicaCollection> extends Itera
public C build();
/**
+ * @return an Immutable clone that assumes this Builder will be
modified again
+ */
+public C snapshot();
+
+/**
* Passed to add() and addAll() as ignoreConflicts parameter. The
meaning of conflict varies by collection type
* (for Endpoints, it is a duplicate InetAddressAndPort; for
RangesAtEndpoint it is a duplicate Range).
*/
diff --git a/src/java/org/apache/cassandra/locator/ReplicaPlan.java
b/src/java/org/apache/cassandra/locator/ReplicaPlan.java
index 861c912..16af58a 100644
--- a/src/java/org/apache/cassandra/locator/ReplicaPlan.java
+++ b/src/java/org/apache/cassandra/locator/ReplicaPlan.java
@@ -52,6 +52,8 @@ public abstract class ReplicaPlan>
public abstract int blockFor();
public E contacts() { return contacts; }
+
+// TODO: should this semantically return true if we contain the endpoint,
not the exact replica?
public boolean contacts(Replica replica) { return
contacts.contains(replica); }
public Keyspace keyspace() { return keyspace; }
public ConsistencyLevel consistencyLevel() { return consistencyLevel; }
@@ -72,17 +74,12 @@ public
[cassandra] branch trunk updated (7c088b9 -> 0f22dab)
This is an automated email from the ASF dual-hosted git repository.
samt pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.
from 7c088b9 Merge branch 'cassandra-3.11' into trunk
new 5ec9e08 Add missing CHANGES.txt entry
new 0f22dab Restore monotonic read consistency guarantees
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt| 2 +
.../org/apache/cassandra/db/ConsistencyLevel.java | 2 +-
.../cassandra/locator/ReplicaCollection.java | 5 +
.../org/apache/cassandra/locator/ReplicaPlan.java | 13 ++-
.../org/apache/cassandra/locator/ReplicaPlans.java | 69 +++-
.../cassandra/service/reads/DigestResolver.java| 8 +-
.../cassandra/service/reads/ResponseResolver.java | 2 +-
.../reads/repair/BlockingPartitionRepair.java | 38 ---
.../service/reads/repair/BlockingReadRepair.java | 24 ++--
.../service/reads/repair/NoopReadRepair.java | 2 +-
.../service/reads/repair/ReadOnlyReadRepair.java | 2 +-
.../cassandra/service/reads/repair/ReadRepair.java | 2 +-
.../reads/repair/RowIteratorMergeListener.java | 123 ++--
.../distributed/impl/AbstractCluster.java | 20
.../distributed/test/DistributedTestBase.java | 7 +-
.../cassandra/distributed/test/ReadRepairTest.java | 125 +
...WritePathTest.java => SimpleReadWriteTest.java} | 4 +-
.../service/reads/AbstractReadResponseTest.java| 19 +++-
.../cassandra/service/reads/DataResolverTest.java | 55 ++---
.../reads/repair/AbstractReadRepairTest.java | 36 ++
.../reads/repair/BlockingReadRepairTest.java | 34 +++---
.../repair/DiagEventsBlockingReadRepairTest.java | 21 ++--
.../reads/repair/ReadOnlyReadRepairTest.java | 7 +-
.../service/reads/repair/ReadRepairTest.java | 30 +++--
.../service/reads/repair/TestableReadRepair.java | 2 +-
25 files changed, 496 insertions(+), 156 deletions(-)
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReadRepairTest.java
rename
test/distributed/org/apache/cassandra/distributed/test/{DistributedReadWritePathTest.java
=> SimpleReadWriteTest.java} (99%)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Add missing CHANGES.txt entry
This is an automated email from the ASF dual-hosted git repository. samt pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 5ec9e081bdfd2bdb2f99f6611022f68570083e6e Author: Sam Tunnicliffe AuthorDate: Tue Feb 4 14:03:21 2020 + Add missing CHANGES.txt entry --- CHANGES.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.txt b/CHANGES.txt index 9554a00..75fae01 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.0-alpha3 + * Separate exceptions for CAS write timeout exceptions caused by contention and unkown result (CASSANDRA-15350) * Fix in-jvm dtest java 11 compatibility (CASSANDRA-15463) * Remove joda time dependency (CASSANDRA-15257) * Exclude purgeable tombstones from repaired data tracking (CASSANDRA-15462) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests
[ https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029722#comment-17029722 ] Alex Petrov commented on CASSANDRA-15497: - Thank you for the review, posting patches and CI for all branches: |2.2|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-2.2]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-2.2]| |3.0|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.0]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.0]| |3.11|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.11]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-3.11]| |trunk|[code|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-trunk]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15497-in-jvm-bootstrap-trunk]| > Implement node bootstrap in in-JVM tests > > > Key: CASSANDRA-15497 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15497 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > > Currently, we do not have an ability to add nodes to the running in-jvm > cluster, either by bootstrap or replacement process. We need to add an > ability to add nodes in inactive state, start them up, and bootstrap to test > streaming, range movements, and operations that occur during these processes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15535) Documentation gives the wrong instruction to activate remote jmx
[ https://issues.apache.org/jira/browse/CASSANDRA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jean carlo rivera ura updated CASSANDRA-15535: -- Test and Documentation Plan: https://github.com/apache/cassandra/pull/434 Status: Patch Available (was: In Progress) > Documentation gives the wrong instruction to activate remote jmx > > > Key: CASSANDRA-15535 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15535 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: jean carlo rivera ura >Assignee: jean carlo rivera ura >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > In this section [jmx acces > |https://cassandra.apache.org/doc/latest/operating/security.html?highlight=local_jmx#jmx-access], > in order to activate the remove jmx acces, it says to change the value of > LOCAL_JMX to *yes*. However the right configuration is *no* -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15535) Documentation gives the wrong instruction to activate remote jmx
[ https://issues.apache.org/jira/browse/CASSANDRA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029718#comment-17029718 ] jean carlo rivera ura commented on CASSANDRA-15535: --- Hello, pull requested created [https://github.com/apache/cassandra/pull/434] > Documentation gives the wrong instruction to activate remote jmx > > > Key: CASSANDRA-15535 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15535 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: jean carlo rivera ura >Assignee: jean carlo rivera ura >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > In this section [jmx acces > |https://cassandra.apache.org/doc/latest/operating/security.html?highlight=local_jmx#jmx-access], > in order to activate the remove jmx acces, it says to change the value of > LOCAL_JMX to *yes*. However the right configuration is *no* -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15535) Documentation gives the wrong instruction to activate remote jmx
[ https://issues.apache.org/jira/browse/CASSANDRA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15535: --- Labels: pull-request-available (was: ) > Documentation gives the wrong instruction to activate remote jmx > > > Key: CASSANDRA-15535 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15535 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: jean carlo rivera ura >Assignee: jean carlo rivera ura >Priority: Normal > Labels: pull-request-available > > In this section [jmx acces > |https://cassandra.apache.org/doc/latest/operating/security.html?highlight=local_jmx#jmx-access], > in order to activate the remove jmx acces, it says to change the value of > LOCAL_JMX to *yes*. However the right configuration is *no* -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15300) 4.0 rpmbuild spec file is missing auditlogviewer and fqltool
[
https://issues.apache.org/jira/browse/CASSANDRA-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuko Sakanaka updated CASSANDRA-15300:
--
Test and Documentation Plan:
>From 95e764f65c736045569a512ce14caa5f2fdb0ecd Mon Sep 17 00:00:00 2001
From: ysakanaka
Date: Tue, 3 Sep 2019 16:08:18 +0900
Subject: [PATCH] Add auditlogviewer and fqltool into rpmbuild spec file. patch
by ysakanaka; for CASSANDRA-15300
---
redhat/cassandra.spec | 2 ++
1 file changed, 2 insertions(+)
diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec
index eaf7565..0aedbd7 100644
--- a/redhat/cassandra.spec
+++ b/redhat/cassandra.spec
@@ -173,6 +173,8 @@ This package contains extra tools for working with
Cassandra clusters.
%attr(755,root,root) %\{_bindir}/sstableofflinerelevel
%attr(755,root,root) %\{_bindir}/sstablerepairedset
%attr(755,root,root) %\{_bindir}/sstablesplit
+%attr(755,root,root) %\{_bindir}/auditlogviewer
+%attr(755,root,root) %\{_bindir}/fqltool
%changelog
--
1.8.3.1
Status: Patch Available (was: In Progress)
> 4.0 rpmbuild spec file is missing auditlogviewer and fqltool
>
>
> Key: CASSANDRA-15300
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15300
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
>Reporter: Yuko Sakanaka
>Assignee: Yuko Sakanaka
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Attachments: 15300-4.0.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The spec file on the current trunk branch (cassandra 4.0) is missing
> auditlogviewer and fqltool.
> I tried rpmbuild on trunk brunch, but it failed with unpacked files error.
> RPM build errors:
> Installed (but unpackaged) file(s) found:
> /usr/bin/auditlogviewer
> /usr/bin/fqltool
> I guess the committers will modify this file in the future because they are
> new features but I suggest that the following lines be added into the spec
> file.
>
> %attr(755,root,root) %\{_bindir}/auditlogviewer
> %attr(755,root,root) %\{_bindir}/fqltool
>
> thanks.
>
> [PATCH] Add auditlogviewer and fqltool into rpmbuild spec file. patch
> by ysakanaka; for CASSANDRA-15300
>
> —
> redhat/cassandra.spec | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec
> index eaf7565..0aedbd7 100644
> — a/redhat/cassandra.spec
> +++ b/redhat/cassandra.spec
> @@ -173,6 +173,8 @@ This package contains extra tools for working with
> Cassandra clusters.
> %attr(755,root,root) %\{_bindir}/sstableofflinerelevel
> %attr(755,root,root) %\{_bindir}/sstablerepairedset
> %attr(755,root,root) %\{_bindir}/sstablesplit
> +%attr(755,root,root) %\{_bindir}/auditlogviewer
> +%attr(755,root,root) %\{_bindir}/fqltool
>
>
> %changelog
> --
> 1.8.3.1
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15300) 4.0 rpmbuild spec file is missing auditlogviewer and fqltool
[
https://issues.apache.org/jira/browse/CASSANDRA-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuko Sakanaka updated CASSANDRA-15300:
--
Status: In Progress (was: Patch Available)
> 4.0 rpmbuild spec file is missing auditlogviewer and fqltool
>
>
> Key: CASSANDRA-15300
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15300
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
>Reporter: Yuko Sakanaka
>Assignee: Yuko Sakanaka
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Attachments: 15300-4.0.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The spec file on the current trunk branch (cassandra 4.0) is missing
> auditlogviewer and fqltool.
> I tried rpmbuild on trunk brunch, but it failed with unpacked files error.
> RPM build errors:
> Installed (but unpackaged) file(s) found:
> /usr/bin/auditlogviewer
> /usr/bin/fqltool
> I guess the committers will modify this file in the future because they are
> new features but I suggest that the following lines be added into the spec
> file.
>
> %attr(755,root,root) %\{_bindir}/auditlogviewer
> %attr(755,root,root) %\{_bindir}/fqltool
>
> thanks.
>
> [PATCH] Add auditlogviewer and fqltool into rpmbuild spec file. patch
> by ysakanaka; for CASSANDRA-15300
>
> —
> redhat/cassandra.spec | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec
> index eaf7565..0aedbd7 100644
> — a/redhat/cassandra.spec
> +++ b/redhat/cassandra.spec
> @@ -173,6 +173,8 @@ This package contains extra tools for working with
> Cassandra clusters.
> %attr(755,root,root) %\{_bindir}/sstableofflinerelevel
> %attr(755,root,root) %\{_bindir}/sstablerepairedset
> %attr(755,root,root) %\{_bindir}/sstablesplit
> +%attr(755,root,root) %\{_bindir}/auditlogviewer
> +%attr(755,root,root) %\{_bindir}/fqltool
>
>
> %changelog
> --
> 1.8.3.1
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15486) Dynamo
[ https://issues.apache.org/jira/browse/CASSANDRA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029635#comment-17029635 ] Joey Lynch edited comment on CASSANDRA-15486 at 2/4/20 8:22 AM: Hi [~dvohra] thank you for contributing this, it is a really good starting point! I've put up some initial edits on my [review/dynamo|https://github.com/jolynch/cassandra/tree/review/dynamo] branch, you can view the [diff so far |https://github.com/dvohra/cassandra/compare/dynamo...jolynch:review/dynamo] I'm still working through all the sections but just a few high level pieces of feedback: * I think that some of the information about scale and general motivation should move to the overview section. I've moved some of it here but I know that there is an in flight PR for the overview as well that we may need to merge in. * I have tried to suggest some edits along the lines of relating how Cassandra uses Dynamo, as opposed to describing Dynamo. For example I think explaining data versioning is a tad counterproductive since Cassandra doesn't use it. * I made two new diagrams to show the ring and vnode setups, let me know what you think of the changes. I will try to get through the rest of the sections tomorrow, if you want to pull in some or all of my changes and squash down I would appreciate that. Thank you again! was (Author: jolynch): Hi [~dvohra] thank you for contributing this, it is a really good starting point! I've put up some initial edits on my [review/dynamo|https://github.com/jolynch/cassandra/tree/review/dynamo] branch, you can view the [diff so far |https://github.com/dvohra/cassandra/compare/dynamo...jolynch:review/dynamo] I'm still working through all the sections but just a few high level pieces of feedback: * I think that some of the information about scale and general motivation should move to the overview section. I've moved some of it here but I know that there is an in flight PR for the overview as well that we may need to merge in. * I have tried to suggest some edits along the lines of relating how Cassandra uses Dynamo, as opposed to describing Dynamo. For example I think explaining data versioning is a tad counterproductive since Cassandra doesn't use it. * I made two new diagrams to show the ring and vnode setups, let me know what you think of the changes. > Dynamo > -- > > Key: CASSANDRA-15486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15486 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added new sections to Dynamo page. > https://github.com/apache/cassandra/pull/415 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15486) Dynamo
[ https://issues.apache.org/jira/browse/CASSANDRA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Lynch updated CASSANDRA-15486: --- Reviewers: Joey Lynch, Joey Lynch (was: Joey Lynch) Joey Lynch, Joey Lynch (was: Joey Lynch) Status: Review In Progress (was: Patch Available) Hi [~dvohra] thank you for contributing this, it is a really good starting point! I've put up some initial edits on my [review/dynamo|https://github.com/jolynch/cassandra/tree/review/dynamo] branch, you can view the [diff so far |https://github.com/dvohra/cassandra/compare/dynamo...jolynch:review/dynamo] I'm still working through all the sections but just a few high level pieces of feedback: * I think that some of the information about scale and general motivation should move to the overview section. I've moved some of it here but I know that there is an in flight PR for the overview as well that we may need to merge in. * I have tried to suggest some edits along the lines of relating how Cassandra uses Dynamo, as opposed to describing Dynamo. For example I think explaining data versioning is a tad counterproductive since Cassandra doesn't use it. * I made two new diagrams to show the ring and vnode setups, let me know what you think of the changes. > Dynamo > -- > > Key: CASSANDRA-15486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15486 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added new sections to Dynamo page. > https://github.com/apache/cassandra/pull/415 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
