[jira] [Comment Edited] (CASSANDRA-15650) Fix flaky test org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest onlyCoordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063718#comment-17063718 ] David Capwell edited comment on CASSANDRA-15650 at 3/21/20, 2:07 AM: - This one is weird. Only one code path skips and that only happens if you ask for a index table, the only other case this could happen is if there are two hosts defined and only one of them is the coordinator. since I only define 1 I don't see how the second case happens, so this only makes sense if we skip, which would require org.apache.cassandra.service.StorageService#getValidColumnFamilies to return a empty list (may be some how possible that the keyspace list is empty some how, and then this defaults to repair all tables, even in this case we should still fail since the coordinator is the only host present) was (Author: dcapwell): This one is weird. Only one code path skips and that only happens if you ask for a index table, the only other case this could happen is if there are two hosts defined and only one of them is the coordinator. since I only define 1 I don't see how the second case happens, so this only makes sense if we skip, which would require org.apache.cassandra.service.StorageService#getValidColumnFamilies to return a empty list. > Fix flaky test > org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest > onlyCoordinator > -- > > Key: CASSANDRA-15650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15650 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > Test failure: > https://app.circleci.com/pipelines/github/dcapwell/cassandra/177/workflows/3dff37a5-9bf4-40e2-8d5b-f127b416dc79/jobs/862 > {code} > [junit-timeout] Testcase: > onlyCoordinator[SEQUENTIAL/true](org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest): > FAILED > [junit-timeout] nodetool command repair was successful but not expected to > be. Actual: 0 > [junit-timeout] junit.framework.AssertionFailedError: nodetool command repair > was successful but not expected to be. Actual: 0 > [junit-timeout] at > org.apache.cassandra.distributed.api.NodeToolResult$Asserts.failure(NodeToolResult.java:76) > [junit-timeout] at > org.apache.cassandra.distributed.test.RepairCoordinatorFast.onlyCoordinator(RepairCoordinatorFast.java:255) > [junit-timeout] at > java.util.concurrent.FutureTask.run(FutureTask.java:266) > [junit-timeout] at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15650) Fix flaky test org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest onlyCoordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063718#comment-17063718 ] David Capwell commented on CASSANDRA-15650: --- This one is weird. Only one code path skips and that only happens if you ask for a index table, the only other case this could happen is if there are two hosts defined and only one of them is the coordinator. since I only define 1 I don't see how the second case happens, so this only makes sense if we skip, which would require org.apache.cassandra.service.StorageService#getValidColumnFamilies to return a empty list. > Fix flaky test > org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest > onlyCoordinator > -- > > Key: CASSANDRA-15650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15650 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > Test failure: > https://app.circleci.com/pipelines/github/dcapwell/cassandra/177/workflows/3dff37a5-9bf4-40e2-8d5b-f127b416dc79/jobs/862 > {code} > [junit-timeout] Testcase: > onlyCoordinator[SEQUENTIAL/true](org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest): > FAILED > [junit-timeout] nodetool command repair was successful but not expected to > be. Actual: 0 > [junit-timeout] junit.framework.AssertionFailedError: nodetool command repair > was successful but not expected to be. Actual: 0 > [junit-timeout] at > org.apache.cassandra.distributed.api.NodeToolResult$Asserts.failure(NodeToolResult.java:76) > [junit-timeout] at > org.apache.cassandra.distributed.test.RepairCoordinatorFast.onlyCoordinator(RepairCoordinatorFast.java:255) > [junit-timeout] at > java.util.concurrent.FutureTask.run(FutureTask.java:266) > [junit-timeout] at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15650) Fix flaky test org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest onlyCoordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15650: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: Unit Test Fix Version/s: 4.0-alpha Severity: Normal Status: Open (was: Triage Needed) > Fix flaky test > org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest > onlyCoordinator > -- > > Key: CASSANDRA-15650 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15650 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > Test failure: > https://app.circleci.com/pipelines/github/dcapwell/cassandra/177/workflows/3dff37a5-9bf4-40e2-8d5b-f127b416dc79/jobs/862 > {code} > [junit-timeout] Testcase: > onlyCoordinator[SEQUENTIAL/true](org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest): > FAILED > [junit-timeout] nodetool command repair was successful but not expected to > be. Actual: 0 > [junit-timeout] junit.framework.AssertionFailedError: nodetool command repair > was successful but not expected to be. Actual: 0 > [junit-timeout] at > org.apache.cassandra.distributed.api.NodeToolResult$Asserts.failure(NodeToolResult.java:76) > [junit-timeout] at > org.apache.cassandra.distributed.test.RepairCoordinatorFast.onlyCoordinator(RepairCoordinatorFast.java:255) > [junit-timeout] at > java.util.concurrent.FutureTask.run(FutureTask.java:266) > [junit-timeout] at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15650) Fix flaky test org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest onlyCoordinator
David Capwell created CASSANDRA-15650: - Summary: Fix flaky test org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest onlyCoordinator Key: CASSANDRA-15650 URL: https://issues.apache.org/jira/browse/CASSANDRA-15650 Project: Cassandra Issue Type: Bug Components: Test/dtest Reporter: David Capwell Assignee: David Capwell Test failure: https://app.circleci.com/pipelines/github/dcapwell/cassandra/177/workflows/3dff37a5-9bf4-40e2-8d5b-f127b416dc79/jobs/862 {code} [junit-timeout] Testcase: onlyCoordinator[SEQUENTIAL/true](org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest): FAILED [junit-timeout] nodetool command repair was successful but not expected to be. Actual: 0 [junit-timeout] junit.framework.AssertionFailedError: nodetool command repair was successful but not expected to be. Actual: 0 [junit-timeout] at org.apache.cassandra.distributed.api.NodeToolResult$Asserts.failure(NodeToolResult.java:76) [junit-timeout] at org.apache.cassandra.distributed.test.RepairCoordinatorFast.onlyCoordinator(RepairCoordinatorFast.java:255) [junit-timeout] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [junit-timeout] at java.lang.Thread.run(Thread.java:748) {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist (CASSANDRA-15508) we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| [Circle CI|https://circleci.com/workflow-run/036bbad1-541a-49dc-a567-cef2300fa847] | TBD | TBD | TBD | CI Failures were flaky tests, below are their links * CASSANDRA-15630 was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| [Circle CI|https://circleci.com/workflow-run/036bbad1-541a-49dc-a567-cef2300fa847] | TBD | TBD | TBD | CI Failures were flaky tests, below are their links * CASSANDRA-15630 > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist (CASSANDRA-15508) we no longer > respect the dtest timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Config||Trunk||3.11||3.0||2.2|| > |LOWER||[Circle > CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | > |HIGHER| [Circle > CI|https://circleci.com/workflow-run/036bbad1-541a-49dc-a567-cef2300fa847] | > TBD | TBD | TBD | > CI Failures were flaky tests, below are their links > * CASSANDRA-15630 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| [Circle CI|https://circleci.com/workflow-run/036bbad1-541a-49dc-a567-cef2300fa847] | TBD | TBD | TBD | CI Failures were flaky tests, below are their links * CASSANDRA-15630 was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| TBD | TBD | TBD | TBD | CI Failures were flaky tests, below are their links * CASSANDRA-15630 > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Config||Trunk||3.11||3.0||2.2|| > |LOWER||[Circle > CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | > |HIGHER| [Circle > CI|https://circleci.com/workflow-run/036bbad1-541a-49dc-a567-cef2300fa847] | > TBD | TBD | TBD | > CI Failures were flaky tests, below are their links > * CASSANDRA-15630 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| TBD | TBD | TBD | TBD | CI Failures were flaky tests, below are their links * CASSANDRA-15630 was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| TBD | TBD | TBD | TBD | > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Config||Trunk||3.11||3.0||2.2|| > |LOWER||[Circle > CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | > |HIGHER| TBD | TBD | TBD | TBD | > CI Failures were flaky tests, below are their links > * CASSANDRA-15630 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| TBD | TBD | TBD | TBD | was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | | TBD | TBD | TBD | TBD | > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > Trunk||3.11||3.0||2.2|| > |LOWER||[Circle CI > LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | > |HIGHER| TBD | TBD | TBD | TBD | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Config||Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| TBD | TBD | TBD | TBD | was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. Trunk||3.11||3.0||2.2|| |LOWER||[Circle CI LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | |HIGHER| TBD | TBD | TBD | TBD | > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Config||Trunk||3.11||3.0||2.2|| > |LOWER||[Circle > CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | > |HIGHER| TBD | TBD | TBD | TBD | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | | TBD | TBD | TBD | TBD | was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Trunk||3.11||3.0||2.2|| > |[Circle CI > LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | > | TBD | TBD | TBD | TBD | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Trunk||3.11||3.0||2.2|| > |[Circle CI > LOWER|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| TBD | TBD | TBD | was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI|https://circleci.com/workflow-run/ca26f4a6-7a87-408d-acb1-8e543236e321]| TBD | TBD | TBD | > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Trunk||3.11||3.0||2.2|| > |[Circle > CI|https://circleci.com/workflow-run/04f7fbe2-1919-4da0-bf72-ba41b41c3072]| > TBD | TBD | TBD | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch master updated: In Jenkins DSL create 'dtest-large' jobs again, post INFRA-19969
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git The following commit(s) were added to refs/heads/master by this push: new 815c997 In Jenkins DSL create 'dtest-large' jobs again, post INFRA-19969 815c997 is described below commit 815c997a0a30157edd056176c910a87311671654 Author: mck AuthorDate: Fri Mar 20 22:07:34 2020 +0100 In Jenkins DSL create 'dtest-large' jobs again, post INFRA-19969 --- jenkins-dsl/cassandra_job_dsl_seed.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy b/jenkins-dsl/cassandra_job_dsl_seed.groovy index bd8481e..699748e 100644 --- a/jenkins-dsl/cassandra_job_dsl_seed.groovy +++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy @@ -47,7 +47,7 @@ if(binding.hasVariable("CASSANDRA_ANT_TEST_TARGETS")) { } // Dtest test targets -def dtestTargets = ['dtest', 'dtest-novnode', 'dtest-offheap' /*, 'dtest-large'*/] // Skipping dtest-large until there are agents with >=32GB ram available +def dtestTargets = ['dtest', 'dtest-novnode', 'dtest-offheap', 'dtest-large'] if(binding.hasVariable("CASSANDRA_DTEST_TEST_TARGETS")) { dtestTargets = "${CASSANDRA_DTEST_TEST_TARGETS}".split(",") } - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Description: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. ||Trunk||3.11||3.0||2.2|| |[Circle CI|https://circleci.com/workflow-run/ca26f4a6-7a87-408d-acb1-8e543236e321]| TBD | TBD | TBD | was: After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. > ||Trunk||3.11||3.0||2.2|| > |[Circle > CI|https://circleci.com/workflow-run/ca26f4a6-7a87-408d-acb1-8e543236e321]| > TBD | TBD | TBD | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Test and Documentation Plan: since this only impacts CircleCI, unit and jvm-dtests are the only tests run Status: Patch Available (was: Open) > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15649: --- Labels: pull-request-available (was: ) > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15649: -- Bug Category: Parent values: Degradation(12984)Level 1 values: Performance Bug/Regression(12997) Complexity: Low Hanging Fruit Discovered By: Unit Test Fix Version/s: 4.0-alpha Severity: Low Status: Open (was: Triage Needed) > test.distributed.timeout no longer respected in CircleCI > > > Key: CASSANDRA-15649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > After switching jvm dtest over testclasslist we no longer respect the dtest > timeout and instead use the unit test timeout (4m vs 6m). > This does not impact Jenkins as I made sure to check that before calling > testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15649) test.distributed.timeout no longer respected in CircleCI
David Capwell created CASSANDRA-15649: - Summary: test.distributed.timeout no longer respected in CircleCI Key: CASSANDRA-15649 URL: https://issues.apache.org/jira/browse/CASSANDRA-15649 Project: Cassandra Issue Type: Bug Components: Build Reporter: David Capwell Assignee: David Capwell After switching jvm dtest over testclasslist we no longer respect the dtest timeout and instead use the unit test timeout (4m vs 6m). This does not impact Jenkins as I made sure to check that before calling testclasslist; though this does impact 2.2, 3.0, and 3.11 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15647) Mismatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15647: - Summary: Mismatching dependencies between cassandra dist and cassandra-all pom (was: Missmatching dependencies between cassandra dist and cassandra-all pom) > Mismatching dependencies between cassandra dist and cassandra-all pom > - > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063610#comment-17063610 ] Jon Meredith commented on CASSANDRA-15647: -- Confirmed the dependencies change as expected with the commit. (Though I had to add {code}./apache-cassandra-4.0-alpha4-SNAPSHOT-parent.pom{code} to the parent element to get it to work - maybe a .m2 settings issue on my end). Before {code} $ mvn dependency:tree -f build/apache-cassandra*-SNAPSHOT.pom -Dverbose -Dincludes=net.java.dev.jna [INFO] Scanning for projects... [INFO] [INFO] -< org.apache.cassandra:cassandra-all >- [INFO] Building Apache Cassandra 4.0-alpha4-SNAPSHOT [INFO] [ jar ]- [WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr5:jar:0.5 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details [WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr6:jar:0.7 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details [WARNING] The POM for org.perfkit.sjk.parsers:sjk-nps:jar:0.5 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details [INFO] [INFO] — maven-dependency-plugin:3.1.1:tree (default-cli) @ cassandra-all — [INFO] Verbose not supported since maven-dependency-plugin 3.0 [INFO] org.apache.cassandra:cassandra-all:jar:4.0-alpha4-SNAPSHOT [INFO] +- net.java.dev.jna:jna:jar:4.2.2:compile [INFO] - net.openhft:chronicle-threads:jar:1.16.0:compile [INFO] - net.openhft:affinity:jar:3.1.7:compile [INFO] - net.java.dev.jna:jna-platform:jar:4.4.0:compile [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1.070 s [INFO] Finished at: 2020-03-20T14:15:14-06:00 [INFO] {code} After {code} $ mvn dependency:tree -f build/apache-cassandra*-SNAPSHOT.pom -Dverbose -Dincludes=net.java.dev.jna [INFO] Scanning for projects... [INFO] [INFO] -< org.apache.cassandra:cassandra-all >- [INFO] Building Apache Cassandra 4.0-alpha4-SNAPSHOT [INFO] [ jar ]- [WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr5:jar:0.5 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details [WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr6:jar:0.7 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details [WARNING] The POM for org.perfkit.sjk.parsers:sjk-nps:jar:0.5 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details [INFO] [INFO] — maven-dependency-plugin:3.1.1:tree (default-cli) @ cassandra-all — [INFO] Verbose not supported since maven-dependency-plugin 3.0 [INFO] org.apache.cassandra:cassandra-all:jar:4.0-alpha4-SNAPSHOT [INFO] - net.java.dev.jna:jna:jar:4.2.2:compile [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1.080 s [INFO] Finished at: 2020-03-20T14:16:26-06:00 [INFO] {code} +1 from me (though I cannot merge). > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063603#comment-17063603 ] Jon Meredith commented on CASSANDRA-15647: -- You're correct, it was *not* intentional. The change was only supposed to prevent the native libraries being called under in-jvm dtests as they prevented Instances from being garbage collected. We should reapply the patch https://github.com/apache/cassandra/pull/240/commits/34d5719ac33826e90e952d92e5204247c611e08f > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15586) 4.0 quality testing: Cluster Setup and Maintenance
[ https://issues.apache.org/jira/browse/CASSANDRA-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063561#comment-17063561 ] Michael Shuler commented on CASSANDRA-15586: As I mentioned on Slack, I used to have access to a large CI infrastructure with some release test automation, but do not have access any longer. The last releases I built, I manually tested the basic install/start/query/stop worked as expected on a couple virtualbox instances, Ubuntu 18.04 and CentOS 7.6. I did not do any manual verification of package upgrades from previous versions, which would be a good thing to test. CI systems at ASF: old, shared (moving to new): https://builds.apache.org/view/A-D/view/Cassandra/ new, dedicated: https://ci-cassandra.apache.org/ > 4.0 quality testing: Cluster Setup and Maintenance > -- > > Key: CASSANDRA-15586 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15586 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Ekaterina Dimitrova >Priority: Normal > Labels: 4.0-QA > Fix For: 4.0-rc > > > We want 4.0 to be easy for users to setup out of the box and just work. This > means having low friction when users download the Cassandra package and start > running it. For example, users should be able to easily configure and start > new 4.0 clusters and have tokens distributed evenly. Another example is > packaging, it should be easy to install Cassandra on all supported platforms > (e.g. packaging) and have Cassandra use standard platform integrations. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15303) drop column statement should not initialize timestamp because of statement cache
[ https://issues.apache.org/jira/browse/CASSANDRA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063523#comment-17063523 ] ZhaoYang edited comment on CASSANDRA-15303 at 3/20/20, 5:04 PM: [~ifesdjeen] thanks.. It looks the fix is required for "testCreateSimpleAlterNTSDefaults()" as well.. I previously made [a fix|https://github.com/jasonstack/cassandra/commits/CASSANDRA-15303-trunk-fix] to move `testCreateAlterNetworkTopologyWithDefaults / testCreateSimpleAlterNTSDefaults ` into another class.. [CI|https://circleci.com/workflow-run/59ea8e29-df8b-40fd-9cfc-1a8d8b78d3a7] unit tests passed, dtest failure is not related.. was (Author: jasonstack): [~ifesdjeen] thanks.. I also made [a fix|https://github.com/jasonstack/cassandra/commits/CASSANDRA-15303-trunk-fix] to move `testCreateAlterNetworkTopologyWithDefaults / testCreateSimpleAlterNTSDefaults ` into another class.. [CI|https://circleci.com/workflow-run/59ea8e29-df8b-40fd-9cfc-1a8d8b78d3a7] unit tests passed, dtest failure is not related.. > drop column statement should not initialize timestamp because of statement > cache > > > Key: CASSANDRA-15303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15303 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: ZhaoYang >Assignee: ZhaoYang >Priority: Normal > Fix For: 4.0 > > > When executing drop-column query without timestamp, > {{AlterTableStatement#Raw}} initializes a default timestamp and then the > prepared statement is cached. The same timestamp will be reused for the same > drop-column query. (related to CASSANDRA-13426) > > The fix is to use NULL timestamp to indicate: using statement execution time > instead. > > patch: > [https://github.com/jasonstack/cassandra/commits/fix-drop-column-timestamp] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15303) drop column statement should not initialize timestamp because of statement cache
[ https://issues.apache.org/jira/browse/CASSANDRA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063523#comment-17063523 ] ZhaoYang edited comment on CASSANDRA-15303 at 3/20/20, 5:00 PM: [~ifesdjeen] thanks.. I also made [a fix|https://github.com/jasonstack/cassandra/commits/CASSANDRA-15303-trunk-fix] to move `testCreateAlterNetworkTopologyWithDefaults / testCreateSimpleAlterNTSDefaults ` into another class.. [CI|https://circleci.com/workflow-run/59ea8e29-df8b-40fd-9cfc-1a8d8b78d3a7] unit tests passed, dtest failure is not related.. was (Author: jasonstack): [~ifesdjeen] thanks.. I also made [a fix|https://github.com/jasonstack/cassandra/commits/CASSANDRA-15303-trunk-fix] to move `testCreateAlterNetworkTopologyWithDefaults / testCreateSimpleAlterNTSDefaults ` into another class.. > drop column statement should not initialize timestamp because of statement > cache > > > Key: CASSANDRA-15303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15303 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: ZhaoYang >Assignee: ZhaoYang >Priority: Normal > Fix For: 4.0 > > > When executing drop-column query without timestamp, > {{AlterTableStatement#Raw}} initializes a default timestamp and then the > prepared statement is cached. The same timestamp will be reused for the same > drop-column query. (related to CASSANDRA-13426) > > The fix is to use NULL timestamp to indicate: using statement execution time > instead. > > patch: > [https://github.com/jasonstack/cassandra/commits/fix-drop-column-timestamp] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15303) drop column statement should not initialize timestamp because of statement cache
[ https://issues.apache.org/jira/browse/CASSANDRA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063523#comment-17063523 ] ZhaoYang commented on CASSANDRA-15303: -- [~ifesdjeen] thanks.. I also made [a fix|https://github.com/jasonstack/cassandra/commits/CASSANDRA-15303-trunk-fix] to move `testCreateAlterNetworkTopologyWithDefaults / testCreateSimpleAlterNTSDefaults ` into another class.. > drop column statement should not initialize timestamp because of statement > cache > > > Key: CASSANDRA-15303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15303 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: ZhaoYang >Assignee: ZhaoYang >Priority: Normal > Fix For: 4.0 > > > When executing drop-column query without timestamp, > {{AlterTableStatement#Raw}} initializes a default timestamp and then the > prepared statement is cached. The same timestamp will be reused for the same > drop-column query. (related to CASSANDRA-13426) > > The fix is to use NULL timestamp to indicate: using statement execution time > instead. > > patch: > [https://github.com/jasonstack/cassandra/commits/fix-drop-column-timestamp] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15303) drop column statement should not initialize timestamp because of statement cache
[ https://issues.apache.org/jira/browse/CASSANDRA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063506#comment-17063506 ] Alex Petrov commented on CASSANDRA-15303: - This commit has broken AlterTest. I've ninja-commited the fix for trunk here [b29af2925cddacb4ab8b429b31917748781fbe5d|https://github.com/apache/cassandra/commit/b29af2925cddacb4ab8b429b31917748781fbe5d] > drop column statement should not initialize timestamp because of statement > cache > > > Key: CASSANDRA-15303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15303 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: ZhaoYang >Assignee: ZhaoYang >Priority: Normal > Fix For: 4.0 > > > When executing drop-column query without timestamp, > {{AlterTableStatement#Raw}} initializes a default timestamp and then the > prepared statement is cached. The same timestamp will be reused for the same > drop-column query. (related to CASSANDRA-13426) > > The fix is to use NULL timestamp to indicate: using statement execution time > instead. > > patch: > [https://github.com/jasonstack/cassandra/commits/fix-drop-column-timestamp] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15528) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testInvalidate
[ https://issues.apache.org/jira/browse/CASSANDRA-15528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063505#comment-17063505 ] Alex Petrov commented on CASSANDRA-15528: - This commit has broken eclipse-warnings check. I've ninja'd the fix for trunk [a01d05d9a73211fb91c068e133d78ef8ccf34b4e|https://github.com/apache/cassandra/commit/a01d05d9a73211fb91c068e133d78ef8ccf34b4e]. > Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testInvalidate > -- > > Key: CASSANDRA-15528 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15528 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Gianluca Righetto >Priority: Normal > Fix For: 4.0-alpha > > Attachments: 15528-4.0-alpha.txt, 15528-dtests-results.png > > > {code} > junit.framework.AssertionFailedError: [key0, key2918, key2919, key2920, > key2921, key2922, key2924, key2926, key2927, key2928] > at > org.apache.cassandra.index.sasi.SASIIndexTest.testInvalidate(SASIIndexTest.java:874) > at > org.apache.cassandra.index.sasi.SASIIndexTest.testInvalidate(SASIIndexTest.java:852) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Ninja fix: Fix unit tests that were broken during CASSANDRA-15303.
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit b29af2925cddacb4ab8b429b31917748781fbe5d Author: Alex Petrov AuthorDate: Fri Mar 20 17:42:15 2020 +0100 Ninja fix: Fix unit tests that were broken during CASSANDRA-15303. --- test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java b/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java index 91a3c64..fc3a61e 100644 --- a/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java +++ b/test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java @@ -316,6 +316,7 @@ public class AlterTest extends CQLTester row("tbl1", map("class", "org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy", "min_threshold", "7", "max_threshold", "32"))); +metadata.clearUnsafe(); } @Test - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (7e739a4 -> b29af29)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 7e739a4 ninja fix: Fix temporal operation validation check new a01d05d Ninja fix: fix eclipse warnings that were broken during CASSANDRA-15528 new b29af29 Ninja fix: Fix unit tests that were broken during CASSANDRA-15303. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java| 1 + src/java/org/apache/cassandra/index/sasi/memory/TrieMemIndex.java| 1 + test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java | 1 + 3 files changed, 3 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Ninja fix: fix eclipse warnings that were broken during CASSANDRA-15528
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a01d05d9a73211fb91c068e133d78ef8ccf34b4e Author: Alex Petrov AuthorDate: Fri Mar 20 11:33:56 2020 +0100 Ninja fix: fix eclipse warnings that were broken during CASSANDRA-15528 --- src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java | 1 + src/java/org/apache/cassandra/index/sasi/memory/TrieMemIndex.java | 1 + 2 files changed, 2 insertions(+) diff --git a/src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java b/src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java index 9e44344..b2cb83f 100644 --- a/src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java +++ b/src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java @@ -63,6 +63,7 @@ public class SkipListMemIndex extends MemIndex return overhead; } +@SuppressWarnings("resource") public RangeIterator search(Expression expression) { ByteBuffer min = expression.lower == null ? null : expression.lower.value; diff --git a/src/java/org/apache/cassandra/index/sasi/memory/TrieMemIndex.java b/src/java/org/apache/cassandra/index/sasi/memory/TrieMemIndex.java index cebd68f..cbdb6b7 100644 --- a/src/java/org/apache/cassandra/index/sasi/memory/TrieMemIndex.java +++ b/src/java/org/apache/cassandra/index/sasi/memory/TrieMemIndex.java @@ -137,6 +137,7 @@ public class TrieMemIndex extends MemIndex return overhead; } +@SuppressWarnings("resource") public RangeIterator search(Expression expression) { ByteBuffer prefix = expression.lower == null ? null : expression.lower.value; - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] 02/02: [maven-release-plugin] prepare release dtest-api-0.0.3
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git commit c3c0b7aabfaa73f144dd24a5f1e329bfa3ae Author: Alex Petrov AuthorDate: Fri Mar 20 17:03:58 2020 +0100 [maven-release-plugin] prepare release dtest-api-0.0.3 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 78f1ff0..05c491a 100644 --- a/pom.xml +++ b/pom.xml @@ -9,7 +9,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.3-SNAPSHOT +0.0.3 In JVM Test API In JVM Test API @@ -93,7 +93,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git -dtest-api-0.0.2 +dtest-api-0.0.3 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] 01/02: A
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git commit befa31df24268b4002b94607220f8d028b043fe2 Author: Alex Petrov AuthorDate: Fri Mar 20 17:03:39 2020 +0100 A --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f2a25ef..78f1ff0 100644 --- a/pom.xml +++ b/pom.xml @@ -92,7 +92,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git -g...@github.com:apache/cassandra-in-jvm-dtests.git + https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git dtest-api-0.0.2 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch CASSANDRA-15539 updated (4aecad3 -> c3c0b7a)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. from 4aecad3 [maven-release-plugin] prepare for next development iteration new befa31d A new c3c0b7a [maven-release-plugin] prepare release dtest-api-0.0.3 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch CASSANDRA-15539 updated: [maven-release-plugin] prepare for next development iteration
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/CASSANDRA-15539 by this push: new 9171565 [maven-release-plugin] prepare for next development iteration 9171565 is described below commit 91715658bba6e2316bbff78df7bb3406ea02958f Author: Alex Petrov AuthorDate: Fri Mar 20 17:04:08 2020 +0100 [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 05c491a..068cfe2 100644 --- a/pom.xml +++ b/pom.xml @@ -9,7 +9,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.3 +0.0.4-SNAPSHOT In JVM Test API In JVM Test API @@ -93,7 +93,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git -dtest-api-0.0.3 +dtest-api-0.0.2 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] annotated tag dtest-api-0.0.3 created (now 2edf0fe)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to annotated tag dtest-api-0.0.3 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. at 2edf0fe (tag) tagging c3c0b7aabfaa73f144dd24a5f1e329bfa3ae (commit) replaces dtest-api-0.0.2 by Alex Petrov on Fri Mar 20 17:04:03 2020 +0100 - Log - [maven-release-plugin] copy for tag dtest-api-0.0.3 --- No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] annotated tag dtest-api-0.0.2 created (now c64dab6)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to annotated tag dtest-api-0.0.2 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. at c64dab6 (tag) tagging 70a779c9f7cd833a9e8f5e9b796b407428c76c5f (commit) replaces 0.0.1-1 by Alex Petrov on Fri Mar 20 17:00:11 2020 +0100 - Log - [maven-release-plugin] copy for tag dtest-api-0.0.2 --- No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch CASSANDRA-15539 updated: [maven-release-plugin] prepare for next development iteration
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/CASSANDRA-15539 by this push: new 4aecad3 [maven-release-plugin] prepare for next development iteration 4aecad3 is described below commit 4aecad3ca6d5d24441b66941c798c94cc11dbf11 Author: Alex Petrov AuthorDate: Fri Mar 20 17:00:16 2020 +0100 [maven-release-plugin] prepare for next development iteration --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c22bcdc..f2a25ef 100644 --- a/pom.xml +++ b/pom.xml @@ -9,7 +9,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.2 +0.0.3-SNAPSHOT In JVM Test API In JVM Test API - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch CASSANDRA-15539 updated: [maven-release-plugin] prepare release dtest-api-0.0.2
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git The following commit(s) were added to refs/heads/CASSANDRA-15539 by this push: new 70a779c [maven-release-plugin] prepare release dtest-api-0.0.2 70a779c is described below commit 70a779c9f7cd833a9e8f5e9b796b407428c76c5f Author: Alex Petrov AuthorDate: Fri Mar 20 17:00:06 2020 +0100 [maven-release-plugin] prepare release dtest-api-0.0.2 --- pom.xml| 4 +- .../cassandra/distributed/test/BootstrapTest.java | 98 -- .../distributed/test/GossipSettlesTest.java| 43 - .../distributed/test/MessageFiltersTest.java | 132 - .../distributed/test/NativeProtocolTest.java | 81 .../distributed/test/NetworkTopologyTest.java | 98 -- .../distributed/test/SimpleReadWriteTest.java | 210 - 7 files changed, 2 insertions(+), 664 deletions(-) diff --git a/pom.xml b/pom.xml index 10bf63d..c22bcdc 100644 --- a/pom.xml +++ b/pom.xml @@ -9,7 +9,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.2-SNAPSHOT +0.0.2 In JVM Test API In JVM Test API @@ -93,7 +93,7 @@ scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git g...@github.com:apache/cassandra-in-jvm-dtests.git -HEAD +dtest-api-0.0.2 diff --git a/src/test/java/org/apache/cassandra/distributed/test/BootstrapTest.java b/src/test/java/org/apache/cassandra/distributed/test/BootstrapTest.java deleted file mode 100644 index 79f5191..000 --- a/src/test/java/org/apache/cassandra/distributed/test/BootstrapTest.java +++ /dev/null @@ -1,98 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.cassandra.distributed.test; - -import java.util.Map; -import java.util.stream.Collectors; -import java.util.stream.IntStream; - -import org.junit.Assert; -import org.junit.Test; - -import org.apache.cassandra.distributed.api.ConsistencyLevel; -import org.apache.cassandra.distributed.api.ICluster; -import org.apache.cassandra.distributed.api.IInstance; -import org.apache.cassandra.distributed.api.IInstanceConfig; -import org.apache.cassandra.distributed.api.TokenSupplier; -import org.apache.cassandra.distributed.api.IInvokableInstance; -import org.apache.cassandra.distributed.shared.Builder; -import org.apache.cassandra.distributed.shared.NetworkTopology; - -import static org.apache.cassandra.distributed.api.Feature.GOSSIP; -import static org.apache.cassandra.distributed.api.Feature.NETWORK; - -public class BootstrapTest extends TestBaseImpl -{ -@Test -public void bootstrapTest() throws Throwable -{ -int originalNodeCount = 2; -int expandedNodeCount = originalNodeCount + 1; -Builder builder = builder().withNodes(originalNodeCount) - .withTokenSupplier(TokenSupplier.evenlyDistributedTokens(expandedNodeCount)) - .withNodeIdTopology(NetworkTopology.singleDcNetworkTopology(originalNodeCount, "dc0", "rack0")) -.withConfig(config -> config.with(NETWORK, GOSSIP)); - -Map withBootstrap = null; -Map naturally = null; -try (ICluster cluster = builder.withNodes(originalNodeCount).start()) -{ -populate(cluster); - -IInstanceConfig config = builder.withNodeIdTopology(NetworkTopology.singleDcNetworkTopology(expandedNodeCount, "dc0", "rack0")) -.newInstanceConfig(cluster); -config.set("auto_bootstrap", true); - -cluster.bootstrap(config).startup(); -withBootstrap = count(cluster); -} - -builder = builder.withNodes(expandedNodeCount) - .withTokenSupplier(TokenSupplier.evenlyDistributedTokens(expandedNodeCount)) -
[cassandra-in-jvm-dtest-api] 01/01: [maven-release-plugin] prepare for next development iteration
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git commit 62574170b0e07ff9ee04093e6bb478fcfd49550a Author: Alex Petrov AuthorDate: Fri Mar 20 16:49:26 2020 +0100 [maven-release-plugin] prepare for next development iteration --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8668fa2..10bf63d 100644 --- a/pom.xml +++ b/pom.xml @@ -9,7 +9,7 @@ 4.0.0 org.apache.cassandra dtest-api -0.0.1-SNAPSHOT +0.0.2-SNAPSHOT In JVM Test API In JVM Test API - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] 01/03: Introduce the extracted in-JVM DTest API
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to annotated tag 0.0.1-1 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git commit 10a3729e259c47101da2c53505177f5159e603da Author: Alex Petrov AuthorDate: Mon Feb 24 12:06:09 2020 +0100 Introduce the extracted in-JVM DTest API Patch by Alex Petrov; reviewed by David Capwell for CASSANDRA-15539. --- pom.xml| 94 +++ .../distributed/api/ConsistencyLevel.java | 34 +++ .../apache/cassandra/distributed/api/Feature.java | 24 ++ .../apache/cassandra/distributed/api/ICluster.java | 41 +++ .../cassandra/distributed/api/ICoordinator.java| 34 +++ .../cassandra/distributed/api/IInstance.java | 66 + .../cassandra/distributed/api/IInstanceConfig.java | 101 +++ .../distributed/api/IInvokableInstance.java| 67 + .../distributed/api/IIsolatedExecutor.java | 128 + .../apache/cassandra/distributed/api/IListen.java | 28 ++ .../apache/cassandra/distributed/api/IMessage.java | 38 +++ .../cassandra/distributed/api/IMessageFilters.java | 56 .../distributed/api/IUpgradeableInstance.java | 29 +++ .../cassandra/distributed/api/TokenSupplier.java | 32 +++ .../cassandra/distributed/shared/Builder.java | 233 + .../distributed/shared/DistributedTestBase.java| 205 +++ .../distributed/shared/InstanceClassLoader.java| 116 + .../distributed/shared/MessageFilters.java | 165 .../distributed/shared/MessageFiltersTest.java | 113 .../distributed/shared/NetworkTopology.java| 216 +++ .../distributed/shared/ThrowingRunnable.java | 38 +++ .../cassandra/distributed/shared/Versions.java | 201 ++ .../cassandra/distributed/test/BootstrapTest.java | 104 .../test/DistributedReadWritePathTest.java | 290 + .../distributed/test/GossipSettlesTest.java| 43 +++ .../distributed/test/LargeColumnTest.java | 96 +++ .../distributed/test/NativeProtocolTest.java | 79 ++ .../distributed/test/NetworkTopologyTest.java | 98 +++ .../distributed/test/SimpleReadWriteTest.java | 270 +++ test/conf/logback-dtest.xml| 77 ++ 30 files changed, 3116 insertions(+) diff --git a/pom.xml b/pom.xml new file mode 100644 index 000..4b92a62 --- /dev/null +++ b/pom.xml @@ -0,0 +1,94 @@ + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +org.apache +apache +10 + + +4.0.0 +org.apache.cassandra +dtest-api +0.0.1-SNAPSHOT +In JVM Test API +In JVM Test API + + +UTF-8 + + + + +Apache License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + + +junit +junit +4.12 + + +org.apache.cassandra +in-jvm-dtest-cassandra-tryout +0.0.7-3.11-SNAPSHOT +test + + + + + +org.apache.maven.plugins +maven-compiler-plugin +3.8.0 + +1.8 +1.8 + + + + + +maven-deploy-plugin +2.8.2 + + +default-deploy +deploy + +deploy + + + + + + +org.apache.maven.plugins +maven-gpg-plugin +1.5 + + +sign-artifacts +verify + +sign + + + + + + + + + + scm:git:g...@github.com:apache/cassandra-in-jvm-dtests.git + scm:git:g...@github.com:apache/cassandra-in-jvm-dtests.git +g...@github.com:apache/cassandra-in-jvm-dtests.git +HEAD + + + diff --git a/src/main/java/org/apache/cassandra/distributed/api/ConsistencyLevel.java b/src/main/java/org/apache/cassandra/distributed/api/ConsistencyLevel.java new file mode 100644 index 000..3c057f8 --- /dev/null +++ b/src/main/java/org/apache/cassandra/distributed/api/ConsistencyLevel.java @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license
[cassandra-in-jvm-dtest-api] 03/03: [maven-release-plugin] prepare release 0.0.1
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to annotated tag 0.0.1-1 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git commit 358bf0d4cec6428e46e1ba153cc085c049a2fcc5 Author: Alex Petrov AuthorDate: Fri Mar 20 16:45:17 2020 +0100 [maven-release-plugin] prepare release 0.0.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 1757a52..8668fa2 100644 --- a/pom.xml +++ b/pom.xml @@ -90,8 +90,8 @@ - scm:git:g...@github.com:apache/cassandra-in-jvm-dtests.git - scm:git:g...@github.com:apache/cassandra-in-jvm-dtests.git + scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git + scm:git:https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git g...@github.com:apache/cassandra-in-jvm-dtests.git HEAD - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] branch CASSANDRA-15539 created (now 6257417)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch CASSANDRA-15539 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. at 6257417 [maven-release-plugin] prepare for next development iteration This branch includes the following new commits: new 6257417 [maven-release-plugin] prepare for next development iteration The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-in-jvm-dtest-api] 02/03: Bring in CASSANDRA-15564 changes
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to annotated tag 0.0.1-1 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git commit 10ff11fd8e34e66992d4fb08aa476fd1198d6260 Author: Alex Petrov AuthorDate: Thu Mar 12 13:25:25 2020 +0100 Bring in CASSANDRA-15564 changes --- pom.xml| 13 +- .../apache/cassandra/distributed/api/ICluster.java | 69 - .../cassandra/distributed/api/ICoordinator.java| 6 +- .../cassandra/distributed/api/IInstance.java | 16 +- .../cassandra/distributed/api/IInstanceConfig.java | 3 +- .../apache/cassandra/distributed/api/IListen.java | 2 +- .../apache/cassandra/distributed/api/IMessage.java | 5 +- .../cassandra/distributed/api/IMessageFilters.java | 52 +++- .../api/{IMessage.java => LongTokenRange.java} | 28 +- .../cassandra/distributed/api/NodeToolResult.java | 182 + .../cassandra/distributed/api/QueryResult.java | 139 ++ .../org/apache/cassandra/distributed/api/Row.java | 110 .../cassandra/distributed/shared/AssertUtils.java | 130 + .../distributed/shared/DistributedTestBase.java| 156 +-- .../distributed/shared/MessageFilters.java | 73 -- .../distributed/shared/MessageFiltersTest.java | 113 .../distributed/shared/NetworkTopology.java| 67 + .../cassandra/distributed/shared/Versions.java | 7 +- .../cassandra/distributed/test/BootstrapTest.java | 10 +- .../test/DistributedReadWritePathTest.java | 290 - .../distributed/test/LargeColumnTest.java | 96 --- .../distributed/test/MessageFiltersTest.java | 132 ++ .../distributed/test/NativeProtocolTest.java | 2 + .../distributed/test/SimpleReadWriteTest.java | 68 + 24 files changed, 927 insertions(+), 842 deletions(-) diff --git a/pom.xml b/pom.xml index 4b92a62..1757a52 100644 --- a/pom.xml +++ b/pom.xml @@ -1,10 +1,9 @@ -http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> org.apache apache -10 +23 4.0.0 @@ -28,14 +27,20 @@ +org.slf4j +slf4j-api +1.7.25 + + junit junit 4.12 +test org.apache.cassandra in-jvm-dtest-cassandra-tryout -0.0.7-3.11-SNAPSHOT +0.0.1-2.2-1 test diff --git a/src/main/java/org/apache/cassandra/distributed/api/ICluster.java b/src/main/java/org/apache/cassandra/distributed/api/ICluster.java index 6d86e99..dffd980 100644 --- a/src/main/java/org/apache/cassandra/distributed/api/ICluster.java +++ b/src/main/java/org/apache/cassandra/distributed/api/ICluster.java @@ -18,24 +18,81 @@ package org.apache.cassandra.distributed.api; -import org.apache.cassandra.distributed.shared.NetworkTopology; - +import java.io.File; +import java.io.IOException; +import java.net.InetSocketAddress; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; import java.util.stream.Stream; -public interface ICluster extends AutoCloseable -{ +public interface ICluster extends AutoCloseable { void startup(); + I bootstrap(IInstanceConfig config); + I get(int i); -I get(NetworkTopology.AddressAndPort endpoint); + +I get(InetSocketAddress endpoint); + ICoordinator coordinator(int node); + void schemaChange(String query); + void schemaChange(String statement, int instance); int size(); Stream stream(); + Stream stream(String dcName); + Stream stream(String dcName, String rackName); + IMessageFilters filters(); -} + +static void setup() throws Throwable { +setupLogging(); +setSystemProperties(); +nativeLibraryWorkaround(); +processReaperWorkaround(); +} + +static void nativeLibraryWorkaround() { +// Disable the Netty tcnative library otherwise the io.netty.internal.tcnative.CertificateCallbackTask, +// CertificateVerifierTask, SSLPrivateKeyMethodDecryptTask, SSLPrivateKeyMethodSignTask, +// SSLPrivateKeyMethodTask, and SSLTask hold a gcroot against the InstanceClassLoader. +System.setProperty("cassandra.disable_tcactive_openssl", "true"); +System.setProperty("io.netty.transport.noNative", "true"); +} + +static void processReaperWorkaround() throws Throwable { +// Make sure the 'process
[cassandra-in-jvm-dtest-api] annotated tag 0.0.1-1 created (now da52406)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to annotated tag 0.0.1-1 in repository https://gitbox.apache.org/repos/asf/cassandra-in-jvm-dtest-api.git. at da52406 (tag) tagging 358bf0d4cec6428e46e1ba153cc085c049a2fcc5 (commit) by Alex Petrov on Fri Mar 20 16:49:20 2020 +0100 - Log - [maven-release-plugin] copy for tag 0.0.1-1 --- This annotated tag includes the following new commits: new 10a3729 Introduce the extracted in-JVM DTest API new 10ff11f Bring in CASSANDRA-15564 changes new 358bf0d [maven-release-plugin] prepare release 0.0.1 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14520) ClosedChannelException handled as FSError
[ https://issues.apache.org/jira/browse/CASSANDRA-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063456#comment-17063456 ] Kevin Gallardo commented on CASSANDRA-14520: This exception is caused when a read of a local SSTable gets interrupted by another thread, or just interrupted. When this interruption happens, the error is caught by the {{ChannelProxy}}, and thrown as a {{FsReadError}}. My understanding then is that the {{FsReadError}} is not caught, but handled at a higher level in the Cassandra daemon by the {{DefaultFsErrorHandler}}. The {{DefaultFsErrorHandler}} has multiple ways to treating a FsError, decided by how the {{disk_failure_policy}} is configured, if configured to {{stop}}, it will indeed stop the daemon/node. It seems that by default the {{disk_failure_policy}} is {{ignore}} though, which would mean it doesn't stop the node. I am not 100% sure that since the CASSANDRA-15066 changes, long reads cannot be interrupted by another thread, i.e. it seems this exception could still be thrown at any time. In any case, it seem the case of a long read of a local SSTable being interrupted shouldn't trigger the node to shutdown, ever? In which case I would suggest to catch the {{ClosedByInterruptException}} in {{ChannelProxy}} and rethrow it as a runtime exception, which should be caught in the {{NettyStreamingMessageSender.FileStreamTask#run}} and have a more graceful exception handling. Does that make sense? [~bdeggleston] [~benedict] > ClosedChannelException handled as FSError > - > > Key: CASSANDRA-14520 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14520 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Streaming and Messaging >Reporter: Blake Eggleston >Assignee: Kevin Gallardo >Priority: Urgent > Fix For: 4.0 > > > After the messaging service netty refactor, I’ve seen a few instances where a > closed socket causes a ClosedChannelException (an IOException subclass) to be > thrown. The exception is caught by ChannelProxy, interpreted as a disk error, > and is then re-thrown as an FSError, causing the node to be shutdown. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15586) 4.0 quality testing: Cluster Setup and Maintenance
[ https://issues.apache.org/jira/browse/CASSANDRA-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063447#comment-17063447 ] Ekaterina Dimitrova commented on CASSANDRA-15586: - [~mshuler] do you test on the multiple platforms? Do you use Apache infrastructure? You mentioned that Windows machines are not available already. What else could be utilized? Any input would be appreciated > 4.0 quality testing: Cluster Setup and Maintenance > -- > > Key: CASSANDRA-15586 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15586 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Ekaterina Dimitrova >Priority: Normal > Labels: 4.0-QA > Fix For: 4.0-rc > > > We want 4.0 to be easy for users to setup out of the box and just work. This > means having low friction when users download the Cassandra package and start > running it. For example, users should be able to easily configure and start > new 4.0 clusters and have tokens distributed evenly. Another example is > packaging, it should be easy to install Cassandra on all supported platforms > (e.g. packaging) and have Cassandra use standard platform integrations. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15586) 4.0 quality testing: Cluster Setup and Maintenance
[ https://issues.apache.org/jira/browse/CASSANDRA-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063447#comment-17063447 ] Ekaterina Dimitrova edited comment on CASSANDRA-15586 at 3/20/20, 3:13 PM: --- [~mshuler] do you test on the multiple platforms? Do you use Apache infrastructure? You mentioned that Windows machines are not available already. What else could be utilized? Any input would be appreciated. Thanks! was (Author: e.dimitrova): [~mshuler] do you test on the multiple platforms? Do you use Apache infrastructure? You mentioned that Windows machines are not available already. What else could be utilized? Any input would be appreciated > 4.0 quality testing: Cluster Setup and Maintenance > -- > > Key: CASSANDRA-15586 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15586 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Josh McKenzie >Assignee: Ekaterina Dimitrova >Priority: Normal > Labels: 4.0-QA > Fix For: 4.0-rc > > > We want 4.0 to be easy for users to setup out of the box and just work. This > means having low friction when users download the Cassandra package and start > running it. For example, users should be able to easily configure and start > new 4.0 clusters and have tokens distributed evenly. Another example is > packaging, it should be easy to install Cassandra on all supported platforms > (e.g. packaging) and have Cassandra use standard platform integrations. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063340#comment-17063340 ] Benedict Elliott Smith commented on CASSANDRA-15647: According to the commit "Disable native library loading until it can be reinstated (tracked in CASSANDRA-15170)." This work was done by [~jmeredithco], and while I don't believe this was intentional it might have been. > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063338#comment-17063338 ] Ryan Svihla commented on CASSANDRA-15647: - [~benedict] I think the build.xml file got force pushed over in this commit [https://github.com/apache/cassandra/commit/7dc5b700b760382c15045e3301c7061f412da993|https://github.com/apache/cassandra/blob/7dc5b700b760382c15045e3301c7061f412da993/build.xml] removing the exclusion. Can you confirm dropping the JNA exclusion wasn't intentional? > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: ninja fix: Fix temporal operation validation check
This is an automated email from the ASF dual-hosted git repository. blerer pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 7e739a4 ninja fix: Fix temporal operation validation check 7e739a4 is described below commit 7e739a4fa3f49a64abb1ad2c96d0c0a6780b31e8 Author: Benjamin Lerer AuthorDate: Fri Mar 20 13:17:32 2020 +0100 ninja fix: Fix temporal operation validation check The code was obviously written by a drunk baboon. Not sure what crossed my mind that day but I feel pretty ashamed right now. --- src/java/org/apache/cassandra/cql3/Duration.java | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/java/org/apache/cassandra/cql3/Duration.java b/src/java/org/apache/cassandra/cql3/Duration.java index 7452316..520d195 100644 --- a/src/java/org/apache/cassandra/cql3/Duration.java +++ b/src/java/org/apache/cassandra/cql3/Duration.java @@ -374,10 +374,7 @@ public final class Duration */ public boolean hasMillisecondPrecision() { -// Checks that the duration has no data bellow milliseconds. We can do that by checking that the last -// 6 bits of the number of nanoseconds are all zeros. The compiler will replace the call to -// numberOfTrailingZeros by a TZCNT instruction. -return Long.numberOfTrailingZeros(getNanoseconds()) >= 6; +return getNanoseconds() % NANOS_PER_MILLI == 0; } /** - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[ https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063235#comment-17063235 ] ZhaoYang commented on CASSANDRA-15557: -- [~blerer] "ant realclean && ant jar" solves it.. thanks > Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest > testDropListAndAddListWithSameName > --- > > Key: CASSANDRA-15557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15557 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Ryan Svihla >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 20m > Remaining Estimate: 0h > > https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests > {code} > junit.framework.AssertionFailedError: Invalid value for row 0 column 2 > (mycollection of type list), expected but got <[first element]> > at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070) > at > org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[ https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063226#comment-17063226 ] Benjamin Lerer commented on CASSANDRA-15557: [~jasonstack] {{java.lang.IncompatibleClassChangeError}} is normally thrown when some client of a jar has not been recompiled while the jar has changed. Could you make sure that everything has been recompiled? > Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest > testDropListAndAddListWithSameName > --- > > Key: CASSANDRA-15557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15557 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Ryan Svihla >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 20m > Remaining Estimate: 0h > > https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests > {code} > junit.framework.AssertionFailedError: Invalid value for row 0 column 2 > (mycollection of type list), expected but got <[first element]> > at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070) > at > org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[ https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063152#comment-17063152 ] ZhaoYang commented on CASSANDRA-15557: -- Should we change {{QueryState#getTimestamp()}} to use class {{ClientState}} instead of object {{clientState}}? I got some exception when running dtest locally... {code} ERROR [main] 2020-03-20 15:43:21,360 CassandraDaemon.java:789 - Exception encountered during startup java.lang.IncompatibleClassChangeError: Expecting non-static method org.apache.cassandra.service.ClientState.getTimestamp()J at org.apache.cassandra.service.QueryState.getTimestamp(QueryState.java:71) at org.apache.cassandra.cql3.QueryOptions.getTimestamp(QueryOptions.java:199) at org.apache.cassandra.cql3.statements.ModificationStatement.executeInternalWithoutCondition(ModificationStatement.java:630) at org.apache.cassandra.cql3.statements.ModificationStatement.executeLocally(ModificationStatement.java:624) at org.apache.cassandra.cql3.QueryProcessor.executeOnceInternal(QueryProcessor.java:358) at org.apache.cassandra.db.SystemKeyspace.persistLocalMetadata(SystemKeyspace.java:457) at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:228) at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:650) at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:767) {code} > Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest > testDropListAndAddListWithSameName > --- > > Key: CASSANDRA-15557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15557 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Ryan Svihla >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 20m > Remaining Estimate: 0h > > https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests > {code} > junit.framework.AssertionFailedError: Invalid value for row 0 column 2 > (mycollection of type list), expected but got <[first element]> > at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070) > at > org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15605) Broken dtest replication_test.py::TestSnitchConfigurationUpdate
[ https://issues.apache.org/jira/browse/CASSANDRA-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15605: --- Labels: pull-request-available (was: ) > Broken dtest replication_test.py::TestSnitchConfigurationUpdate > --- > > Key: CASSANDRA-15605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15605 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Sam Tunnicliffe >Assignee: Ryan Svihla >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > > Noticed this failing on a couple of CI runs and repros when running trunk > locally and on CircleCI > 2 or 3 tests are consistently failing: > * {{test_rf_expand_gossiping_property_file_snitch}} > * {{test_rf_expand_property_file_snitch}} > * {{test_move_forwards_between_and_cleanup}} > [https://circleci.com/workflow-run/f23f13a9-bbdc-4764-8336-109517e137f1] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org