[jira] [Updated] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-16994: --- Labels: pull-request-available (was: ) > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-16994: -- Status: Patch Available (was: In Progress) > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: 4.0.x > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-16994: -- Status: Review In Progress (was: Patch Available) > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: 4.0.x > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-16994: -- Authors: Diogenese Topper (was: Erick Ramirez) > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: 4.0.x > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16446) Parent repair sessions leak may lead to node long pauses
[
https://issues.apache.org/jira/browse/CASSANDRA-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451511#comment-17451511
]
Berenguer Blasi commented on CASSANDRA-16446:
-
[~dcapwell] I don't remember any specific reasons. Also reading the code
diagonally I don't see a reason why we couldn't cleanup also on failures. But
this is not a part of the code I know by heart so I guess the best is to give
it a go and see what happens?
> Parent repair sessions leak may lead to node long pauses
>
>
> Key: CASSANDRA-16446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16446
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc1, 4.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {{ActiveRepairService}} keeps a map `parentRepairSessions`. If these
> sessions leak, that map can grow to a size when a node restarts
> {{ActiveRepairService.onRestart()}} triggers a cleanup of sessions that can
> pause nodes in a cluster for a long time.
> The proposed solution is for repairs to cleanup these sessions on all nodes
> on completion by sending a CLEANUP message to involved nodes. Tests rely on a
> new {{parentRepairSessionsCount()}} method on the parent repair sessions
> MBean to keep track of these.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17080) Fix test: dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
[
https://issues.apache.org/jira/browse/CASSANDRA-17080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451510#comment-17451510
]
Berenguer Blasi commented on CASSANDRA-17080:
-
PR lgtm but we still need a CI runs?
> Fix test:
> dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
> --
>
> Key: CASSANDRA-17080
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17080
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Josh McKenzie
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> !https://ci-cassandra.apache.org/static/a177fe56/images/32x32/health-80plus.png!
> Failed 28 times in the last 28 runs. Flakiness: 0%, Stability: 0%
>
> Example of failure:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/801/testReport/junit/dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test/TestDropCompactStorage/test_drop_compact_storage_mixed_cluster/]
>
> {code:java}
> upgrade_tests/drop_compact_storage_upgrade_test.py:149:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7fa0e7f1ceb0>
> session =
> assert_msg = 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.'
> def drop_compact_storage(self, session, assert_msg):
> try:
> session.execute("ALTER TABLE drop_compact_storage_test.test DROP
> COMPACT STORAGE")
> pytest.fail("No exception has been thrown")
> except InvalidRequest as e:
> > assert assert_msg in str(e)
> E assert 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.' in 'Error from
> server: code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as
> some nodes in the cluster ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+
> yet. Please upgrade those nodes and run `upgradesstables` before retrying."'
> E+ where 'Error from server: code=2200 [Invalid query]
> message="Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those
> nodes and run `upgradesstables` before retrying."' =
> str(InvalidRequest('Error from server: code=2200 [Invalid query]
> message="Cannot DROP COMPACT STORAGE as some nodes in the...1:7000,
> /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those nodes and run
> `upgradesstables` before retrying."'))
> upgrade_tests/drop_compact_storage_upgrade_test.py:45: AssertionError
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17031) Add support for PEM based key material for SSL
[
https://issues.apache.org/jira/browse/CASSANDRA-17031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451453#comment-17451453
]
Maulin Vasavada commented on CASSANDRA-17031:
-
[~jonmeredith] and [~stefan.miklosovic] Can you please take a look at the PR
with updated comments and my question in the prior post seeking your opinion?
Thanks.
> Add support for PEM based key material for SSL
> --
>
> Key: CASSANDRA-17031
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17031
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Maulin Vasavada
>Assignee: Maulin Vasavada
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> h1. Scope
> Currently Cassandra supports standard keystore types for SSL
> keys/certificates. The scope of this enhancement is to add support for PEM
> based key material (keys/certificate) given that PEM is widely used common
> format for the same. We intend to add support for Unencrypted and Password
> Based Encrypted (PBE) PKCS#8 formatted Private Keys in PEM format with
> standard algorithms (RSA, DSA and EC) along with the certificate chain for
> the private key and PEM based X509 certificates. The work here is going to be
> built on top of [CEP-9: Make SSLContext creation
> pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable]
> for which the code is merged for Apache Cassandra 4.1 release.
> We intend to support the key material be configured as direct PEM values
> input OR via the file (configured with keystore and truststore configurations
> today). We are not going to model PEM as a valid 'store_type' given that
> 'store_type' has a [specific
> definition|https://docs.oracle.com/en/java/javase/11/security/java-cryptography-architecture-jca-reference-guide.html#GUID-AB51DEFD-5238-4F96-967F-082F6D34FBEA].
>
> h1. Approach
> Create an implementation for
> [ISslContextFactory|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/ISslContextFactory.java]
> extending
> [FileBasedSslContextFactory|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java]
> implementation to add PEM formatted key/certificates.
> h1. Motivation
> PEM is a widely used format for encoding Private Keys and X.509 Certificates
> and Apache Cassandra's current implementation lacks the support for
> specifying the PEM formatted key material for SSL configurations. This means
> operators have to re-create the key material to comply to the supported
> formats (using key/trust store types - jks, pkcs12 etc) and deal with an
> operational task for managing it. This is an operational overhead we can
> avoid by supporting the PEM format making Apache Cassandra even more customer
> friendly and drive more adoption.
> h1. Proposed Changes
> # A new implementation for ISslContextFactory - PEMBasedSslContextFactory
> with the following supported configuration
> {panel:title=New configurations}
> {panel}
> |{{encryption_options: }}
> {{}}{{ssl_context_factory:}}
> {{}}{{class_name:
> org.apache.cassandra.security.PEMBasedSslContextFactory}}
> {{}}{{parameters:}}
> {{ }}{{private_key: certificate chain>}}
> {{ }}{{private_key_password: }}{{private}} {{key }}{{if}} {{it is encrypted>}}
> {{ }}{{trusted_certificates: }}|
> *NOTE:* We could reuse 'keystore_password' instead of the
> 'private_key_password'. However PEM encoded private key is not a 'keystore'
> in itself hence it would be inappropriate to piggyback on that other than
> avoid duplicating similar fields.
> # The PEMBasedSslContextFactory will also support file based key material
> (and the corresponding HOT Reloading based on file timestamp updates) for the
> PEM format via existing 'keystore' and 'truststore' encryption options.
> However in that case the 'truststore_password' configuration won't be used
> since generally PEM formatted certificates for truststore don't get encrypted
> with a password.
> # The PEMBasedSslContextFactory will internally create PKCS12 keystore for
> private key and the trusted certificates. However, this doesn't impact the
> user of the implementation in anyway and it is mentioned for clarity only.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17166) Enhance SnakeYAML properties to be reusable outside of YAML parsing, support camel case conversion to snake case, and add support to ignore properties
[ https://issues.apache.org/jira/browse/CASSANDRA-17166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17166: -- Summary: Enhance SnakeYAML properties to be reusable outside of YAML parsing, support camel case conversion to snake case, and add support to ignore properties (was: Switch to Jackson for config property definition to allow private fields and getter/setter support) > Enhance SnakeYAML properties to be reusable outside of YAML parsing, support > camel case conversion to snake case, and add support to ignore properties > -- > > Key: CASSANDRA-17166 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17166 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: David Capwell >Priority: Normal > Fix For: 4.x > > > SnakeYaml is rather limited in the “object mapping” layer, which forces our > internal code to match specific patterns (all fields public and camel case); > we can remove this restriction by leveraging Jackson for property lookup, and > leaving the YAML handling to SnakeYAML -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17147) Guardrails prototype
[
https://issues.apache.org/jira/browse/CASSANDRA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451450#comment-17451450
]
David Capwell commented on CASSANDRA-17147:
---
{code}
# Guardrail to warn or fail when creating more user tables than threshold.
Defaults to -1 to disable.
tables:
warn_threshold: -1
fail_threshold: -1
# Guardrail to warn or fail when creating more columns per table than
threshold. Defaults to -1 to disable.
columns_per_table:
warn_threshold: -1
fail_threshold: -1
# Guardrail to warn or fail when creating more secondary indexes per table
than threshold. Defaults to -1 to disable.
secondary_indexes_per_table:
warn_threshold: -1
fail_threshold: -1
# Guardrail to warn or fail when creating more materialized views per
table than threshold. Defaults to -1 to disable.
materialized_views_per_table:
warn_threshold: -1
fail_threshold: -1
# Guardrail to ignore or reject properties when creating tables. By
default all properties are allowed.
table_properties:
ignored_values: []
disallowed_values: []
{code}
LGTM; though would drop "_values" in table_properties
{code}
validate("guardrails.materialized_views_per_table")
{code}
we did the same for TrackWarnings; LGTM.
If we assume the nested convo doesn't get flat out rejected (mostly people are
positive to it) then CASSANDRA-17166 can fix your concerns for getter/setters;
I know that the yaml will be interesting with your patch, but prefer
CASSANDRA-17166 fixes those issues rather than you dealing with it in this
patch (your getter/setters are currently exposed as camel case in yaml; found
the same bug in TrackWarnings).
Once you merge into the PR can view whole patch together; think we are close!
> Guardrails prototype
>
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451448#comment-17451448
]
David Capwell commented on CASSANDRA-15234:
---
bq. DTests were not updated to the new names and format as this will take
forever. Suggestion - leave the old ones and add new tests with new ones. We
can also open a follow up ticket but now this exercises the backward
compatibility which is good as this is also how I figured out one more change
needed for CCM.
works for me; more testing we didn't break things ^_^
bq. I suggest not to overwhelm the patch with the reorganization of
cassandra.yaml I suggested earlier on this ticket. I will pull it in a separate
one and I can trigger a new discuss thread on the mailing list to confirm that.
Works for me
bq. Converter was not changed to an enum because we need generics support for
that and JEP301 was withdrawn.
Works for me
bq. Intentionally left the commits after the old patch not squashed to provide
some input and hopefully make the review a bit more easy. Benjamin Lerer and
David Capwell , please, let me know if you want them in a different way for the
review.
Personally prefer PRs, easier to leave comments than commits
bq. Any new parameters added post 4.0 in trunk were/will be directly changed to
support the new format as they are still not in any release.
Saw the TrackWarning changes <3
bq. I can think of adding some additional test for the virtual table.
I am 100% cool leaving the vtable problem to another ticket =). Right now it
will show the new names, if we want different behavior we can solve it outside
of this JIRA. We are having side conversations on how can we unify (at least I
am pushing this) properties access.
bq. I also suggest we add a warning to the users when they start Cassandra that
if they add more than once a property (even if it is the old name), the latest
occurrence from the yaml file will be the one assigned to the parameter. I
would say we add also info to the docs and we don't complicate to add checks
whether we have or not more occurrences during startup and emitting warnings on
occurrence as it seems a bit too much overhead on startup. WDYT?
Ideally I like this, but also 100% cool not doing in this patch.
{code}
a: b
a: c
{code}
that has worked for years without anyone noticing... if adding a warning is
low-hanging-fruit then I am cool, but I wouldn't hold up this ticket (I like
splitting tickets if you have not noticed).
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451447#comment-17451447
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 11/30/21, 11:52 PM:
-
Sure, [PR|https://github.com/apache/cassandra/pull/1350] created
{quote}patch is massive; no way I can finish before I go on break Friday =(
{quote}
This waited whole year, it can wait while you take well deserved break. I will
be off on Friday and then in two weeks again. Hopefully the next rebase won't
be too painful :) Hopefully the community won't work too much around the
holidays :D
was (Author: e.dimitrova):
Sure, [PR|https://github.com/apache/cassandra/pull/1350] created
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451447#comment-17451447
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-
Sure, [PR|https://github.com/apache/cassandra/pull/1350] created
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15281) help for clearsnapshot needs to be updated to indicate requirement for --all
[
https://issues.apache.org/jira/browse/CASSANDRA-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15281:
Resolution: Duplicate
Status: Resolved (was: Open)
> help for clearsnapshot needs to be updated to indicate requirement for --all
>
>
> Key: CASSANDRA-15281
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15281
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Priority: Normal
> Fix For: 4.x
>
> Attachments: 15281.trunk
>
>
> According to _CASSANDRA-13391_
> _nodetool clearsnapshot should require --all to clear all snapshots_
> But the help for clearsnapshot does not indicate the same.
> {code:java}
> [ec2-user@ip-10-0-2-238 ~]$ nodetool help clearsnapshot
> NAME nodetool clearsnapshot - Remove the snapshot with the given name from
> the given keyspaces. If no snapshotName is specified we will remove all
> snapshots{code}
> The help for clearsnapshot needs to be updated to indicate requirement for
> --all to remove all snapshots.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15281) help for clearsnapshot needs to be updated to indicate requirement for --all
[
https://issues.apache.org/jira/browse/CASSANDRA-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451445#comment-17451445
]
Ekaterina Dimitrova commented on CASSANDRA-15281:
-
Thank you for following up [~subkanthi], I agree with you. Closing the ticket.
> help for clearsnapshot needs to be updated to indicate requirement for --all
>
>
> Key: CASSANDRA-15281
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15281
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Priority: Normal
> Fix For: 4.x
>
> Attachments: 15281.trunk
>
>
> According to _CASSANDRA-13391_
> _nodetool clearsnapshot should require --all to clear all snapshots_
> But the help for clearsnapshot does not indicate the same.
> {code:java}
> [ec2-user@ip-10-0-2-238 ~]$ nodetool help clearsnapshot
> NAME nodetool clearsnapshot - Remove the snapshot with the given name from
> the given keyspaces. If no snapshotName is specified we will remove all
> snapshots{code}
> The help for clearsnapshot needs to be updated to indicate requirement for
> --all to remove all snapshots.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15234) Standardise config and JVM parameters
[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451443#comment-17451443
]
David Capwell commented on CASSANDRA-15234:
---
patch is massive; no way I can finish before I go on break Friday =(
Can you actually send a PR? easier to leave comments
> Standardise config and JVM parameters
> -
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Benedict Elliott Smith
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17168) Don't block gossip when clearing snapshots for failing repairs
[ https://issues.apache.org/jira/browse/CASSANDRA-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451441#comment-17451441 ] David Capwell commented on CASSANDRA-17168: --- Overall +1 (assuming repair tests are passing). I am not a fan of breaking change in the protocol, though I do know we say repair isn't supported in mixed-mode... > Don't block gossip when clearing snapshots for failing repairs > -- > > Key: CASSANDRA-17168 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17168 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0.x, 4.x > > > We clear snapshots in the GossipTasks thread when a repair session fails due > to a replica shutting down. If there are many tables/repair sessions ongoing > this can take a long time. With enough tables being repaired at the same time > even checking if the snapshots exists can take long enough to mark nodes down. > We should clear snapshots in a separate thread and add a flag to tell us > whether this repair session can have snapshots to avoid checking if the > directory exists. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17168) Don't block gossip when clearing snapshots for failing repairs
[ https://issues.apache.org/jira/browse/CASSANDRA-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17168: -- Test and Documentation Plan: tests Status: Patch Available (was: Open) > Don't block gossip when clearing snapshots for failing repairs > -- > > Key: CASSANDRA-17168 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17168 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0.x, 4.x > > > We clear snapshots in the GossipTasks thread when a repair session fails due > to a replica shutting down. If there are many tables/repair sessions ongoing > this can take a long time. With enough tables being repaired at the same time > even checking if the snapshots exists can take long enough to mark nodes down. > We should clear snapshots in a separate thread and add a flag to tell us > whether this repair session can have snapshots to avoid checking if the > directory exists. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17168) Don't block gossip when clearing snapshots for failing repairs
[ https://issues.apache.org/jira/browse/CASSANDRA-17168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17168: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell (was: David Capwell) Status: Review In Progress (was: Patch Available) > Don't block gossip when clearing snapshots for failing repairs > -- > > Key: CASSANDRA-17168 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17168 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0.x, 4.x > > > We clear snapshots in the GossipTasks thread when a repair session fails due > to a replica shutting down. If there are many tables/repair sessions ongoing > this can take a long time. With enough tables being repaired at the same time > even checking if the snapshots exists can take long enough to mark nodes down. > We should clear snapshots in a separate thread and add a flag to tell us > whether this repair session can have snapshots to avoid checking if the > directory exists. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[
https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451438#comment-17451438
]
David Capwell commented on CASSANDRA-15254:
---
bq. deprecated as they were found through reflection
Cool, so different than Ekaterina's version =D. @Replaces was merged to
trunk/cassandra-4.0 which allows renaming and marking the old name deprecated,
but don't actually remember if @Deprecated was supported (since and forRemoval
exists, so can leverage to provide useful warnings).
bq. Question: Shouldn't we expose deprecated properties until they are fully
removed?
IMO yes, though settings vtable should prob return a ClientWarn if setting a
deprecated name?
bq. An annoying job though.
With my POC it makes it rather low-hanging-fruit. Let's say system properties
start with the "cassandra." prefix, then we just walk and check if we have a
flatten version found; else ignore
-Dcassandra.track_warnings.local_read_size.abort_threshold=1kb
we just strip off the "cassandra." bit, then check if
"track_warnings.local_read_size.abort_threshold" property exists in the flatten
version; if so we have a Property, which offers the ability to mutate objects
{code}
Map properties = Properties.getProperties(Config.java);
properties = Properties.flatten(properties);
Config conf = DatabaseDescriptor.getConf();
Properties sys = System.getProperties();
for (String field : sys.stringPropertyNames())
{
if (!field.startsWith("cassandra."))
continue;
String value = sys.getProperty(field);
field = field.replace("cassandra.", "");
if (properties.contains(field))
properties.get(field).set(conf, value);
}
{code}
The only real annoying bit are the stuff which are only system properties; we
could move them to Config; which would also be so much nicer for jvm-dtests as
system property isolation is a pain right now, though this could have issues as
I think we don't always use snake casing...
> Allow UPDATE on settings virtual table to change running configurations
> ---
>
> Key: CASSANDRA-15254
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15254
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Virtual Tables
>Reporter: Chris Lohfink
>Assignee: Benjamin Lerer
>Priority: Normal
>
> Allow using UPDATE on the system_views.settings virtual table to update
> configs at runtime for the equivalent of the dispersed JMX
> attributes/operations.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451433#comment-17451433 ] Ekaterina Dimitrova commented on CASSANDRA-15254: - Question: Shouldn't we expose deprecated properties until they are fully removed? > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Benjamin Lerer >Priority: Normal > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17147) Guardrails prototype
[
https://issues.apache.org/jira/browse/CASSANDRA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451396#comment-17451396
]
Andres de la Peña commented on CASSANDRA-17147:
---
[Here|https://github.com/adelapena/cassandra/commit/e2cadadd628ff70970cda6b8ecb9e2f3f45a6123]
is a first, minimal version of nested config. Nesting is limited to
{{GuardrailOptions}} and {{cassandra.yaml}} and the rest is as flat as before.
[This other
commit|https://github.com/adelapena/cassandra/commit/bb24a63cce0f2c6576875b48d8f7854edcc8af49]
extends this a bit so the guardrail classes accept the nested objects,
although JMX is still flat for convenience. If it looks good I'll add it to the
PR.
> Guardrails prototype
>
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16310) Track top partitions (by size and tombstone count) and display in nodetool tablestats
[
https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451381#comment-17451381
]
Yifan Cai commented on CASSANDRA-16310:
---
The new commits update the schema for the TopPartitions table and exclude the
partitions no longer owned on merging.
I left a few nits and a general question about switching from {{blob}} to
{{text}} to represent the partition keys in the schema.
> Track top partitions (by size and tombstone count) and display in nodetool
> tablestats
> -
>
> Key: CASSANDRA-16310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16310
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.x
>
>
> We should track the top partitions by size and tombstone count and display in
> {{nodetool tablestats}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17080) Fix test: dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
[
https://issues.apache.org/jira/browse/CASSANDRA-17080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-17080:
Status: Review In Progress (was: Changes Suggested)
> Fix test:
> dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
> --
>
> Key: CASSANDRA-17080
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17080
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Josh McKenzie
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> !https://ci-cassandra.apache.org/static/a177fe56/images/32x32/health-80plus.png!
> Failed 28 times in the last 28 runs. Flakiness: 0%, Stability: 0%
>
> Example of failure:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/801/testReport/junit/dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test/TestDropCompactStorage/test_drop_compact_storage_mixed_cluster/]
>
> {code:java}
> upgrade_tests/drop_compact_storage_upgrade_test.py:149:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7fa0e7f1ceb0>
> session =
> assert_msg = 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.'
> def drop_compact_storage(self, session, assert_msg):
> try:
> session.execute("ALTER TABLE drop_compact_storage_test.test DROP
> COMPACT STORAGE")
> pytest.fail("No exception has been thrown")
> except InvalidRequest as e:
> > assert assert_msg in str(e)
> E assert 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.' in 'Error from
> server: code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as
> some nodes in the cluster ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+
> yet. Please upgrade those nodes and run `upgradesstables` before retrying."'
> E+ where 'Error from server: code=2200 [Invalid query]
> message="Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those
> nodes and run `upgradesstables` before retrying."' =
> str(InvalidRequest('Error from server: code=2200 [Invalid query]
> message="Cannot DROP COMPACT STORAGE as some nodes in the...1:7000,
> /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those nodes and run
> `upgradesstables` before retrying."'))
> upgrade_tests/drop_compact_storage_upgrade_test.py:45: AssertionError
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17080) Fix test: dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
[
https://issues.apache.org/jira/browse/CASSANDRA-17080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447644#comment-17447644
]
Ekaterina Dimitrova edited comment on CASSANDRA-17080 at 11/30/21, 10:10 PM:
-
It seems locally and in Jenkins - the error message appears to have ordered the
IPs in one order, now I ran it 100 times in Circle and it was always different
order.
I made the test checking just that all the IPs we want appear in the exception
and order won't matter.
[Python DTest
patch|https://github.com/apache/cassandra-dtest/compare/trunk...ekaterinadimitrova2:C17080?expand=1]
was (Author: e.dimitrova):
It seems locally and in Jenkins - the error message appears to have ordered the
IPs in one order, now I ran it 100 times in Circle and it was always different
order.
I made the test checking just that all the IPs we want appear in the exception
and order won't matter.
[Python DTest
patch|https://github.com/apache/cassandra-dtest/compare/trunk...ekaterinadimitrova2:C17080?expand=1]
> Fix test:
> dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
> --
>
> Key: CASSANDRA-17080
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17080
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Josh McKenzie
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> !https://ci-cassandra.apache.org/static/a177fe56/images/32x32/health-80plus.png!
> Failed 28 times in the last 28 runs. Flakiness: 0%, Stability: 0%
>
> Example of failure:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/801/testReport/junit/dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test/TestDropCompactStorage/test_drop_compact_storage_mixed_cluster/]
>
> {code:java}
> upgrade_tests/drop_compact_storage_upgrade_test.py:149:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7fa0e7f1ceb0>
> session =
> assert_msg = 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.'
> def drop_compact_storage(self, session, assert_msg):
> try:
> session.execute("ALTER TABLE drop_compact_storage_test.test DROP
> COMPACT STORAGE")
> pytest.fail("No exception has been thrown")
> except InvalidRequest as e:
> > assert assert_msg in str(e)
> E assert 'Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/127.0.0.2:7000, /127.0.0.1:7000]) are not on 4.0+ yet. Please upgrade
> those nodes and run `upgradesstables` before retrying.' in 'Error from
> server: code=2200 [Invalid query] message="Cannot DROP COMPACT STORAGE as
> some nodes in the cluster ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+
> yet. Please upgrade those nodes and run `upgradesstables` before retrying."'
> E+ where 'Error from server: code=2200 [Invalid query]
> message="Cannot DROP COMPACT STORAGE as some nodes in the cluster
> ([/1271:7000, /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those
> nodes and run `upgradesstables` before retrying."' =
> str(InvalidRequest('Error from server: code=2200 [Invalid query]
> message="Cannot DROP COMPACT STORAGE as some nodes in the...1:7000,
> /127.0.0.2:7000]) are not on 4.0+ yet. Please upgrade those nodes and run
> `upgradesstables` before retrying."'))
> upgrade_tests/drop_compact_storage_upgrade_test.py:45: AssertionError
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17082) Make nodes more resilient to stale JSON files during startup
[
https://issues.apache.org/jira/browse/CASSANDRA-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451378#comment-17451378
]
Caleb Rackliffe commented on CASSANDRA-17082:
-
+1 w/ one nit...
{noformat}
logger.info("Couldn't parse filename {}, ignoring", p.toString());
{noformat}
...can be...
{noformat}
logger.info("Couldn't parse filename {}, ignoring", p);
{noformat}
> Make nodes more resilient to stale JSON files during startup
>
>
> Key: CASSANDRA-17082
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17082
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Startup and Shutdown
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.x
>
>
> There's a few things we can protect against being in the data dir on startup
> that might be around from older activity, tool usage, exports, etc on a 3.x
> -> 4.x update:
> a) file ending with *-old.json
> b) file ending with *.json or *idx.json
> A trivial update to the filter on SSTableHeaderFix.java should protect
> against hitting these types of files on startup and throwing.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17174) Harden resource management on SSTable components to prevent further leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451350#comment-17451350
]
Caleb Rackliffe commented on CASSANDRA-17174:
-
+1
The only minor question I have is whether we want to catch {{Throwable}}
[here|https://github.com/apache/cassandra/commit/532ee78a11668f6e8206b3060b8626fcc0b524e2#diff-b2d3079f6ed6b50a76ee1ebc12f03cbe59750fc7f6887b08f4175842d0e25b5aR377]
to account for {{Error}} possibly being thrown out of the {{try}} block.
> Harden resource management on SSTable components to prevent further leaks
> -
>
> Key: CASSANDRA-17174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17174
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.x
>
>
> We've seen resource leaks pop up w/histogram overflows repeatedly; the code
> in {{BigTableWriter.openEarly()}} and {{BigTableWriter.openFinal()}} doesn't
> appropriately catch and handle any exceptions during creation before things
> are registered with a {{LifecycleTransaction}} so any errors there will leak.
> We should clean that up.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-site updated (58b29b0 -> 6332455)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cassandra-website.git. from 58b29b0 generated for e35418ad9542cc50f61e9bcb3610a5a457657bd3 add 6332455 generated for ea789239e No new revisions were added by this update. Summary of changes: .../blog/cassandra-on-kubernetes-beginner.png | Bin 0 -> 110165 bytes content/_/index.html | 604 ++- content/assets/css/site.css| 2 +- content/assets/img/big-quotes.png | Bin 0 -> 1898 bytes .../doc/4.0.0/cassandra/architecture/dynamo.html | 2 +- .../4.0.0/cassandra/architecture/guarantees.html | 2 +- .../doc/4.0.0/cassandra/architecture/index.html| 2 +- .../doc/4.0.0/cassandra/architecture/overview.html | 2 +- .../doc/4.0.0/cassandra/architecture/snitch.html | 2 +- .../cassandra/architecture/storage_engine.html | 2 +- .../configuration/cass_cl_archive_file.html| 2 +- .../cassandra/configuration/cass_env_sh_file.html | 2 +- .../configuration/cass_jvm_options_file.html | 2 +- .../configuration/cass_logback_xml_file.html | 2 +- .../cassandra/configuration/cass_rackdc_file.html | 2 +- .../cassandra/configuration/cass_topo_file.html| 2 +- .../cassandra/configuration/cass_yaml_file.html| 2 +- .../doc/4.0.0/cassandra/configuration/index.html | 2 +- content/doc/4.0.0/cassandra/cql/SASI.html | 2 +- content/doc/4.0.0/cassandra/cql/appendices.html| 2 +- content/doc/4.0.0/cassandra/cql/changes.html | 2 +- .../doc/4.0.0/cassandra/cql/cql_singlefile.html| 2 +- content/doc/4.0.0/cassandra/cql/ddl.html | 2 +- content/doc/4.0.0/cassandra/cql/definitions.html | 2 +- content/doc/4.0.0/cassandra/cql/dml.html | 2 +- content/doc/4.0.0/cassandra/cql/functions.html | 2 +- content/doc/4.0.0/cassandra/cql/index.html | 2 +- content/doc/4.0.0/cassandra/cql/indexes.html | 2 +- content/doc/4.0.0/cassandra/cql/json.html | 2 +- content/doc/4.0.0/cassandra/cql/mvs.html | 2 +- content/doc/4.0.0/cassandra/cql/operators.html | 2 +- content/doc/4.0.0/cassandra/cql/security.html | 2 +- content/doc/4.0.0/cassandra/cql/triggers.html | 2 +- content/doc/4.0.0/cassandra/cql/types.html | 2 +- .../data_modeling/data_modeling_conceptual.html| 2 +- .../data_modeling/data_modeling_logical.html | 2 +- .../data_modeling/data_modeling_physical.html | 2 +- .../data_modeling/data_modeling_queries.html | 2 +- .../data_modeling/data_modeling_rdbms.html | 2 +- .../data_modeling/data_modeling_refining.html | 2 +- .../data_modeling/data_modeling_schema.html| 2 +- .../data_modeling/data_modeling_tools.html | 2 +- .../doc/4.0.0/cassandra/data_modeling/index.html | 2 +- .../doc/4.0.0/cassandra/data_modeling/intro.html | 2 +- content/doc/4.0.0/cassandra/faq/index.html | 2 +- .../cassandra/getting_started/configuring.html | 2 +- .../4.0.0/cassandra/getting_started/drivers.html | 2 +- .../doc/4.0.0/cassandra/getting_started/index.html | 2 +- .../cassandra/getting_started/installing.html | 2 +- .../cassandra/getting_started/production.html | 2 +- .../4.0.0/cassandra/getting_started/querying.html | 2 +- .../cassandra/getting_started/quickstart.html | 2 +- content/doc/4.0.0/cassandra/new/auditlogging.html | 2 +- content/doc/4.0.0/cassandra/new/fqllogging.html| 2 +- content/doc/4.0.0/cassandra/new/index.html | 2 +- content/doc/4.0.0/cassandra/new/java11.html| 2 +- content/doc/4.0.0/cassandra/new/messaging.html | 2 +- content/doc/4.0.0/cassandra/new/streaming.html | 2 +- .../4.0.0/cassandra/new/transientreplication.html | 2 +- content/doc/4.0.0/cassandra/new/virtualtables.html | 2 +- .../4.0.0/cassandra/operating/audit_logging.html | 2 +- content/doc/4.0.0/cassandra/operating/backups.html | 2 +- .../4.0.0/cassandra/operating/bloom_filters.html | 2 +- .../4.0.0/cassandra/operating/bulk_loading.html| 2 +- content/doc/4.0.0/cassandra/operating/cdc.html | 2 +- .../cassandra/operating/compaction/index.html | 2 +- .../4.0.0/cassandra/operating/compaction/lcs.html | 2 +- .../4.0.0/cassandra/operating/compaction/stcs.html | 2 +- .../4.0.0/cassandra/operating/compaction/twcs.html | 2 +- .../doc/4.0.0/cassandra/operating/compression.html | 2 +- .../doc/4.0.0/cassandra/operating/hardware.html| 2 +- content/doc/4.0.0/cassandra/operating/hints.html | 2 +- content/doc/4.0.0/cassandra/operating/index.html | 2 +- content/doc/4.0.0/cassandra/operating/metrics.html | 2 +- .../doc/4.0.0/cassandra/operating/read_repair.html | 2 +-
[jira] [Commented] (CASSANDRA-16890) WEBSITE - Remove section with company logos from homepage
[ https://issues.apache.org/jira/browse/CASSANDRA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451341#comment-17451341 ] Michael Semb Wever commented on CASSANDRA-16890: thanks. pushed live. > WEBSITE - Remove section with company logos from homepage > - > > Key: CASSANDRA-16890 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16890 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > Attachments: Apache-Cassandra-Apache-Cassandra-Documentation.png > > > [~mck] advised that the company logos on the homepage are a breach of ASF > policy so will need to be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16890) WEBSITE - Remove section with company logos from homepage
[ https://issues.apache.org/jira/browse/CASSANDRA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451325#comment-17451325 ] Erick Ramirez commented on CASSANDRA-16890: --- Looks good in staging. Should be good to publish to production. > WEBSITE - Remove section with company logos from homepage > - > > Key: CASSANDRA-16890 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16890 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > Attachments: Apache-Cassandra-Apache-Cassandra-Documentation.png > > > [~mck] advised that the company logos on the homepage are a breach of ASF > policy so will need to be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17174) Harden resource management on SSTable components to prevent further leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-17174:
Status: Review In Progress (was: Patch Available)
> Harden resource management on SSTable components to prevent further leaks
> -
>
> Key: CASSANDRA-17174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17174
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.x
>
>
> We've seen resource leaks pop up w/histogram overflows repeatedly; the code
> in {{BigTableWriter.openEarly()}} and {{BigTableWriter.openFinal()}} doesn't
> appropriately catch and handle any exceptions during creation before things
> are registered with a {{LifecycleTransaction}} so any errors there will leak.
> We should clean that up.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17179) Cassandra new node is taking Too long to join in cluster
[ https://issues.apache.org/jira/browse/CASSANDRA-17179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17179: - Resolution: Invalid Status: Resolved (was: Triage Needed) This jira is for the development of Apache Cassandra. For assistance with your issue, you will be better served by contacting the community via slack or the ML: https://cassandra.apache.org/_/community.html > Cassandra new node is taking Too long to join in cluster > -- > > Key: CASSANDRA-17179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17179 > Project: Cassandra > Issue Type: Task >Reporter: Syed Abdullah >Priority: Normal > > We are trying to add new new node in Cassandra cluster bootstraping is taking > too much time Since two weeks it is showing still in joining state, Can > someone please help to fix the issue -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17179) Cassandra new node is taking Too long to join in cluster
Syed Abdullah created CASSANDRA-17179: - Summary: Cassandra new node is taking Too long to join in cluster Key: CASSANDRA-17179 URL: https://issues.apache.org/jira/browse/CASSANDRA-17179 Project: Cassandra Issue Type: Task Reporter: Syed Abdullah We are trying to add new new node in Cassandra cluster bootstraping is taking too much time Since two weeks it is showing still in joining state, Can someone please help to fix the issue -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16446) Parent repair sessions leak may lead to node long pauses
[
https://issues.apache.org/jira/browse/CASSANDRA-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451288#comment-17451288
]
David Capwell commented on CASSANDRA-16446:
---
I don't see conversation in JIRA or GH, was wondering why cleanup is success
only and does not include failure? Best I see is
https://github.com/apache/cassandra/pull/896#discussion_r577334272
bq. Parent session is removed as part of the success() call path.
If a session is failed, we can't recover or really act on it... Was the
concern IR?
> Parent repair sessions leak may lead to node long pauses
>
>
> Key: CASSANDRA-16446
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16446
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc1, 4.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {{ActiveRepairService}} keeps a map `parentRepairSessions`. If these
> sessions leak, that map can grow to a size when a node restarts
> {{ActiveRepairService.onRestart()}} triggers a cleanup of sessions that can
> pause nodes in a cluster for a long time.
> The proposed solution is for repairs to cleanup these sessions on all nodes
> on completion by sending a CLEANUP message to involved nodes. Tests rely on a
> new {{parentRepairSessionsCount()}} method on the parent repair sessions
> MBean to keep track of these.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17147) Guardrails prototype
[
https://issues.apache.org/jira/browse/CASSANDRA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451278#comment-17451278
]
David Capwell commented on CASSANDRA-17147:
---
bq. We don't have a clear outcome for the discussion about that in the mail
list, although it seems that probably we are going in that direction
Thats my reading as well; there are some small concerns with nesting but most
are leaning towards nesting; the main talking point now is how deep and what
groupings. I am also planning to flesh out CASSANDRA-17166 once Ekaterina's
work gets merged, so would allow getter/setters, using camel case and have yaml
convert to snake, and support "." notation for nested configs.
bq. I think our main concern at this point is the nested yaml config
As long as we are not releasing 4.1 soon, we can also prob go with "every
commit can break the yaml" until the epic is fully closed; so can prob move
forward even though the email thread isn't fully complete.
bq. I'll try to get ready a version of the patch with nested config, even if we
miss some of the ongoing config improvements.
works for me.
> Guardrails prototype
>
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17177) List Appends Are Not Linearizable
[ https://issues.apache.org/jira/browse/CASSANDRA-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-17177: --- Parent: (was: CASSANDRA-17164) Workflow: Copy of Cassandra Bug Workflow (was: Copy of Cassandra Default Workflow) Issue Type: Bug (was: Sub-task) > List Appends Are Not Linearizable > - > > Key: CASSANDRA-17177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17177 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Coordination >Reporter: Benedict Elliott Smith >Priority: Normal > > List TimeUUID are issued using the wall clock of the coordinator, so that two > coordinators with divergent clocks may invert their append order -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17177) List Appends Are Not Linearizable
[ https://issues.apache.org/jira/browse/CASSANDRA-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-17177: --- Bug Category: Parent values: Correctness(12982)Level 1 values: Consistency(12989) Complexity: Normal Discovered By: Fuzz Test Severity: Normal Assignee: Benedict Elliott Smith Status: Open (was: Triage Needed) > List Appends Are Not Linearizable > - > > Key: CASSANDRA-17177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17177 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Coordination >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > > List TimeUUID are issued using the wall clock of the coordinator, so that two > coordinators with divergent clocks may invert their append order -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17176) Introduce TimeUUID
[ https://issues.apache.org/jira/browse/CASSANDRA-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-17176: --- Test and Documentation Plan: UUID behaviour is already tested throughout the codebase, and with some minor dedicated tests. This functionality is also extensively covered by the Simulator. We may introduce some new additional tests. (was: UUID behaviour is already tested throughout the codebase, and with some minor dedicated tests. We may introduce some new additional tests.) > Introduce TimeUUID > -- > > Key: CASSANDRA-17176 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17176 > Project: Cassandra > Issue Type: Sub-task > Components: Local/Other >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > > Introduce a dedicated class to represent UUID version 2, to ensure correct > usage within Cassandra -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17176) Introduce TimeUUID
[ https://issues.apache.org/jira/browse/CASSANDRA-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-17176: --- Test and Documentation Plan: UUID behaviour is already tested throughout the codebase, and with some minor dedicated tests. We may introduce some new additional tests. Status: Patch Available (was: Open) [trunk|http://github.com/belliottsmith/cassandra/tree/17176-trunk] > Introduce TimeUUID > -- > > Key: CASSANDRA-17176 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17176 > Project: Cassandra > Issue Type: Sub-task > Components: Local/Other >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > > Introduce a dedicated class to represent UUID version 2, to ensure correct > usage within Cassandra -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17176) Introduce TimeUUID
[ https://issues.apache.org/jira/browse/CASSANDRA-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-17176: --- Change Category: Code Clarity Complexity: Normal Assignee: Benedict Elliott Smith Status: Open (was: Triage Needed) > Introduce TimeUUID > -- > > Key: CASSANDRA-17176 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17176 > Project: Cassandra > Issue Type: Sub-task > Components: Local/Other >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > > Introduce a dedicated class to represent UUID version 2, to ensure correct > usage within Cassandra -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17082) Make nodes more resilient to stale JSON files during startup
[ https://issues.apache.org/jira/browse/CASSANDRA-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-17082: Reviewers: Caleb Rackliffe > Make nodes more resilient to stale JSON files during startup > > > Key: CASSANDRA-17082 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17082 > Project: Cassandra > Issue Type: Improvement > Components: Local/Startup and Shutdown >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.x > > > There's a few things we can protect against being in the data dir on startup > that might be around from older activity, tool usage, exports, etc on a 3.x > -> 4.x update: > a) file ending with *-old.json > b) file ending with *.json or *idx.json > A trivial update to the filter on SSTableHeaderFix.java should protect > against hitting these types of files on startup and throwing. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17178) CEP-10: Simulator Java11 Support
Benedict Elliott Smith created CASSANDRA-17178: -- Summary: CEP-10: Simulator Java11 Support Key: CASSANDRA-17178 URL: https://issues.apache.org/jira/browse/CASSANDRA-17178 Project: Cassandra Issue Type: Task Components: Test/fuzz Reporter: Benedict Elliott Smith Java11 introduces new protection domains for package private methods, so that classes loaded with different class loaders may not access each others’ package private methods, regardless of the package they are declared within. There are differences within the JDK also, and there may be byte weaving targets that need updating (ThreadLocalRandom was one that has been handled) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17177) List Appends Are Not Linearizable
Benedict Elliott Smith created CASSANDRA-17177: -- Summary: List Appends Are Not Linearizable Key: CASSANDRA-17177 URL: https://issues.apache.org/jira/browse/CASSANDRA-17177 Project: Cassandra Issue Type: Sub-task Components: Consistency/Coordination Reporter: Benedict Elliott Smith List TimeUUID are issued using the wall clock of the coordinator, so that two coordinators with divergent clocks may invert their append order -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17176) Introduce TimeUUID
Benedict Elliott Smith created CASSANDRA-17176: -- Summary: Introduce TimeUUID Key: CASSANDRA-17176 URL: https://issues.apache.org/jira/browse/CASSANDRA-17176 Project: Cassandra Issue Type: Sub-task Components: Local/Other Reporter: Benedict Elliott Smith Introduce a dedicated class to represent UUID version 2, to ensure correct usage within Cassandra -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17008) CEP-10: Simulator
[ https://issues.apache.org/jira/browse/CASSANDRA-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-17008: --- Fix Version/s: 4.1 (was: 4.x) Source Control Link: [209c35aa62855e2834e629e8ecb38ebb329aa6ce|https://github.com/apache/cassandra/commit/209c35aa62855e2834e629e8ecb38ebb329aa6ce] Resolution: Fixed Status: Resolved (was: Ready to Commit) [CI|https://app.circleci.com/pipelines/github/belliottsmith/cassandra/209/workflows/d176664c-8e32-498d-b19d-cb6d1e202d7a] (one of many runs) > CEP-10: Simulator > - > > Key: CASSANDRA-17008 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17008 > Project: Cassandra > Issue Type: Improvement > Components: Test/burn, Test/dtest/java >Reporter: Benedict Elliott Smith >Assignee: Benedict Elliott Smith >Priority: Normal > Fix For: 4.1 > > > This ticket introduces the Simulator facility proposed by CEP-10, including > mock implementations of: time, blocking concurrency primitives, executors, > messaging, object monitors, identity hashcode, and byte weaving class loaders > to ensure these mock implementations are utilised in place of their originals. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/03: [CEP-10] Cluster and Code Simulations: Minor improvements
This is an automated email from the ASF dual-hosted git repository.
benedict pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit eae581a5f07c340594f6af47bb558693ef363611
Author: Benedict Elliott Smith
AuthorDate: Wed Nov 17 14:34:23 2021 +
[CEP-10] Cluster and Code Simulations: Minor improvements
- Simplify Semaphore
- Future improvements
- ScheduledExecutorPlus improvements for simulator compatibility
- Debug leaks in Ref or BufferPool
- Support use of TokenMetadata without initialising Cassandra
- Additional system properties and simulator flags
- Permit Clock initialisation within separate ClassLoader
- Introduce BallotGenerator
patch by Benedict; reviewed by Sam Tunnicliffe for CASSANDRA-17008
---
.../cassandra/auth/CassandraRoleManager.java | 2 +-
.../concurrent/ScheduledExecutorPlus.java | 24 +++
.../ScheduledThreadPoolExecutorPlus.java | 27 +++
.../cassandra/concurrent/SyncFutureTask.java | 5 +-
.../config/CassandraRelevantProperties.java| 1 +
.../cassandra/config/DatabaseDescriptor.java | 4 +
.../cql3/statements/BatchUpdatesCollector.java | 2 +-
src/java/org/apache/cassandra/db/Keyspace.java | 2 +-
src/java/org/apache/cassandra/db/Mutation.java | 2 +-
src/java/org/apache/cassandra/db/ReadCommand.java | 2 +-
.../cassandra/db/ReadExecutionController.java | 2 +-
.../db/commitlog/AbstractCommitLogService.java | 3 +-
.../cassandra/db/monitoring/MonitorableImpl.java | 2 +-
.../cassandra/db/monitoring/MonitoringTask.java| 2 +-
.../org/apache/cassandra/gms/FailureDetector.java | 4 +-
.../apache/cassandra/hints/HintsDispatcher.java| 2 +-
.../apache/cassandra/locator/TokenMetadata.java| 76
src/java/org/apache/cassandra/metrics/Sampler.java | 2 +-
.../cassandra/net/AbstractMessageHandler.java | 2 +-
.../cassandra/net/InboundMessageHandler.java | 2 +-
.../cassandra/net/InboundMessageHandlers.java | 2 +-
src/java/org/apache/cassandra/net/Message.java | 2 +-
.../apache/cassandra/net/OutboundConnection.java | 2 +-
.../org/apache/cassandra/net/RequestCallbacks.java | 2 +-
.../apache/cassandra/net/ResponseVerbHandler.java | 2 +-
.../apache/cassandra/schema/MigrationManager.java | 4 +
.../apache/cassandra/schema/SchemaKeyspace.java| 3 +
.../cassandra/service/ActiveRepairService.java | 3 +
.../org/apache/cassandra/service/StorageProxy.java | 28 ++-
.../cassandra/service/paxos/BallotGenerator.java | 75
.../cassandra/service/paxos/ProposeCallback.java | 3 +-
.../cassandra/transport/CQLMessageHandler.java | 2 +-
src/java/org/apache/cassandra/utils/Clock.java | 31 +++-
.../org/apache/cassandra/utils/MonotonicClock.java | 19 +-
.../Nemesis.java} | 27 ++-
src/java/org/apache/cassandra/utils/Simulate.java | 56 ++
.../cassandra/utils/concurrent/AbstractFuture.java | 26 ++-
.../cassandra/utils/concurrent/AsyncFuture.java| 2 +-
.../cassandra/utils/concurrent/Awaitable.java | 135 +++---
.../apache/cassandra/utils/concurrent/Future.java | 11 ++
.../cassandra/utils/concurrent/ListenerList.java | 18 +-
.../org/apache/cassandra/utils/concurrent/Ref.java | 29 ++-
.../cassandra/utils/concurrent/Semaphore.java | 200 ++---
.../cassandra/utils/concurrent/SyncFuture.java | 4 +-
.../apache/cassandra/utils/memory/BufferPool.java | 19 +-
.../apache/cassandra/utils/memory/HeapPool.java| 4 +
.../cassandra/utils/memory/LongBufferPoolTest.java | 4 +-
.../concurrent/AbstractExecutorPlusTest.java | 8 +-
.../cassandra/utils/concurrent/SemaphoreTest.java | 8 +-
49 files changed, 515 insertions(+), 382 deletions(-)
diff --git a/src/java/org/apache/cassandra/auth/CassandraRoleManager.java
b/src/java/org/apache/cassandra/auth/CassandraRoleManager.java
index 0e49056..b813b55 100644
--- a/src/java/org/apache/cassandra/auth/CassandraRoleManager.java
+++ b/src/java/org/apache/cassandra/auth/CassandraRoleManager.java
@@ -385,7 +385,7 @@ public class CassandraRoleManager implements IRoleManager
protected void scheduleSetupTask(final Callable setupTask)
{
// The delay is to give the node a chance to see its peers before
attempting the operation
-ScheduledExecutors.optionalTasks.schedule(() -> {
+ScheduledExecutors.optionalTasks.scheduleSelfRecurring(() -> {
isClusterReady = true;
try
{
diff --git
a/src/java/org/apache/cassandra/concurrent/ScheduledExecutorPlus.java
b/src/java/org/apache/cassandra/concurrent/ScheduledExecutorPlus.java
index ecf073d..a2b033a 100644
--- a/src/java/org/apache/cassandra/concurrent/ScheduledExecutorPlus.java
+++ b/src/java/org/apache/cassandra/concurrent/ScheduledExecutorPlus.java
@@
[cassandra] 01/03: [CEP-10] Cluster and Code Simulations: Minor fixes
This is an automated email from the ASF dual-hosted git repository. benedict pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 31bea0b0d41e4e81095f0d088094f03db14af490 Author: Benedict Elliott Smith AuthorDate: Wed Nov 17 14:50:09 2021 + [CEP-10] Cluster and Code Simulations: Minor fixes - fix repair timeout - fix secondary index flushing - fix race condition with Ref - fix resource leaks - fix incorrect exists() - fix repair error reporting when null exception message - fix dtest use of System.nanoTime patch by Benedict; reviewed by Sam Tunnicliffe for CASSANDRA-17008 --- .../apache/cassandra/cache/AutoSavingCache.java| 1 - .../cassandra/concurrent/NamedThreadFactory.java | 2 +- .../org/apache/cassandra/db/ColumnFamilyStore.java | 2 +- src/java/org/apache/cassandra/db/Directories.java | 1 - src/java/org/apache/cassandra/db/ReadResponse.java | 1 - .../org/apache/cassandra/db/SystemKeyspace.java| 1 - .../cassandra/db/WindowsFailedSnapshotTracker.java | 2 -- .../commitlog/CommitLogSegmentManagerStandard.java | 1 - .../apache/cassandra/db/compaction/Scrubber.java | 1 - .../apache/cassandra/db/compaction/Verifier.java | 11 ++- .../compaction/writers/CompactionAwareWriter.java | 1 - .../apache/cassandra/db/lifecycle/LogRecord.java | 1 - .../org/apache/cassandra/gms/EndpointState.java| 1 - .../org/apache/cassandra/gms/GossipDigest.java | 1 - .../org/apache/cassandra/gms/GossipDigestAck2.java | 1 - .../org/apache/cassandra/gms/GossipDigestSyn.java | 1 - .../org/apache/cassandra/gms/HeartBeatState.java | 1 - .../org/apache/cassandra/gms/TokenSerializer.java | 3 -- .../org/apache/cassandra/gms/VersionedValue.java | 1 - .../cassandra/hints/ChecksummedDataInput.java | 1 - .../apache/cassandra/index/sasi/TermIterator.java | 4 --- .../index/sasi/disk/OnDiskIndexBuilder.java| 1 - .../io/compress/CompressedSequentialWriter.java| 1 - .../cassandra/io/compress/CompressionMetadata.java | 3 -- .../apache/cassandra/io/sstable/Descriptor.java| 2 -- .../io/sstable/SSTableIdentityIterator.java| 1 - .../cassandra/io/sstable/format/SSTableReader.java | 30 ++--- .../io/sstable/format/SSTableReaderBuilder.java| 2 -- .../io/sstable/format/big/BigTableWriter.java | 2 +- .../io/sstable/metadata/MetadataSerializer.java| 1 - .../io/util/BufferedDataOutputStreamPlus.java | 3 ++ .../org/apache/cassandra/io/util/FileHandle.java | 12 +-- .../org/apache/cassandra/io/util/PathUtils.java| 2 -- src/java/org/apache/cassandra/net/Verb.java| 2 +- .../repair/consistent/SyncStatSummary.java | 1 - .../schema/SystemDistributedKeyspace.java | 5 ++- .../apache/cassandra/service/StartupChecks.java| 2 -- .../apache/cassandra/service/StorageService.java | 1 - .../org/apache/cassandra/service/paxos/Commit.java | 34 +++ .../apache/cassandra/service/paxos/PaxosState.java | 6 ++-- .../service/snapshot/SnapshotManifest.java | 14 ++-- .../cassandra/streaming/StreamResultFuture.java| 5 ++- .../apache/cassandra/streaming/StreamSession.java | 9 + .../cassandra/streaming/StreamTransferTask.java| 38 +- .../async/StreamingMultiplexedChannel.java | 1 + .../cassandra/tools/BulkLoadConnectionFactory.java | 1 - .../cassandra/utils/BloomFilterSerializer.java | 2 -- .../org/apache/cassandra/utils/FBUtilities.java| 2 +- .../cassandra/utils/binlog/ExternalArchiver.java | 1 - .../apache/cassandra/utils/concurrent/Threads.java | 5 +++ .../apache/cassandra/utils/obs/OffHeapBitSet.java | 1 - .../cassandra/distributed/impl/Coordinator.java| 2 +- .../apache/cassandra/distributed/impl/Query.java | 4 ++- .../streaming/StreamTransferTaskTest.java | 1 + 54 files changed, 140 insertions(+), 96 deletions(-) diff --git a/src/java/org/apache/cassandra/cache/AutoSavingCache.java b/src/java/org/apache/cassandra/cache/AutoSavingCache.java index 03cbde2..0e022d4 100644 --- a/src/java/org/apache/cassandra/cache/AutoSavingCache.java +++ b/src/java/org/apache/cassandra/cache/AutoSavingCache.java @@ -27,7 +27,6 @@ import java.util.*; import java.util.concurrent.ScheduledFuture; import java.util.concurrent.TimeUnit; -import org.apache.cassandra.io.util.File; import org.cliffc.high_scale_lib.NonBlockingHashSet; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/src/java/org/apache/cassandra/concurrent/NamedThreadFactory.java b/src/java/org/apache/cassandra/concurrent/NamedThreadFactory.java index 88e0d10..9816649 100644 --- a/src/java/org/apache/cassandra/concurrent/NamedThreadFactory.java +++ b/src/java/org/apache/cassandra/concurrent/NamedThreadFactory.java @@ -177,7 +177,7 @@ public class NamedThreadFactory implements ThreadFactory
[cassandra] branch trunk updated (f47e4b2 -> 209c35a)
This is an automated email from the ASF dual-hosted git repository. benedict pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from f47e4b2 Flaky GrantAndRevokeTest new 31bea0b [CEP-10] Cluster and Code Simulations: Minor fixes new eae581a [CEP-10] Cluster and Code Simulations: Minor improvements new 209c35a [CEP-10] Phase 4: Cluster and Code Simulation The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 167 +++- ide/idea-iml-file.xml | 3 + .../cassandra/auth/CassandraRoleManager.java | 2 +- .../apache/cassandra/cache/AutoSavingCache.java| 1 - .../cassandra/concurrent/ImmediateExecutor.java| 4 + .../cassandra/concurrent/InfiniteLoopExecutor.java | 17 + .../cassandra/concurrent/NamedThreadFactory.java | 2 +- .../concurrent/ScheduledExecutorPlus.java | 24 + .../ScheduledThreadPoolExecutorPlus.java | 27 + .../cassandra/concurrent/SyncFutureTask.java | 5 +- .../config/CassandraRelevantProperties.java| 2 + .../cassandra/config/DatabaseDescriptor.java | 4 + .../cql3/statements/BatchUpdatesCollector.java | 2 +- .../org/apache/cassandra/db/ColumnFamilyStore.java | 2 +- src/java/org/apache/cassandra/db/Directories.java | 1 - src/java/org/apache/cassandra/db/Keyspace.java | 2 +- src/java/org/apache/cassandra/db/Mutation.java | 2 +- src/java/org/apache/cassandra/db/ReadCommand.java | 2 +- .../cassandra/db/ReadExecutionController.java | 2 +- src/java/org/apache/cassandra/db/ReadResponse.java | 1 - .../org/apache/cassandra/db/SystemKeyspace.java| 1 - .../cassandra/db/WindowsFailedSnapshotTracker.java | 2 - .../db/commitlog/AbstractCommitLogService.java | 3 +- .../commitlog/CommitLogSegmentManagerStandard.java | 1 - .../apache/cassandra/db/compaction/Scrubber.java | 1 - .../apache/cassandra/db/compaction/Verifier.java | 11 +- .../compaction/writers/CompactionAwareWriter.java | 1 - .../apache/cassandra/db/lifecycle/LogRecord.java | 1 - .../cassandra/db/monitoring/MonitorableImpl.java | 2 +- .../cassandra/db/monitoring/MonitoringTask.java| 2 +- .../org/apache/cassandra/gms/EndpointState.java| 1 - .../org/apache/cassandra/gms/FailureDetector.java | 4 +- .../org/apache/cassandra/gms/GossipDigest.java | 1 - .../org/apache/cassandra/gms/GossipDigestAck2.java | 1 - .../org/apache/cassandra/gms/GossipDigestSyn.java | 1 - .../org/apache/cassandra/gms/HeartBeatState.java | 1 - .../org/apache/cassandra/gms/TokenSerializer.java | 3 - .../org/apache/cassandra/gms/VersionedValue.java | 1 - .../cassandra/hints/ChecksummedDataInput.java | 1 - .../apache/cassandra/hints/HintsDispatcher.java| 2 +- .../apache/cassandra/index/sasi/TermIterator.java | 4 - .../index/sasi/disk/OnDiskIndexBuilder.java| 1 - .../io/compress/CompressedSequentialWriter.java| 1 - .../cassandra/io/compress/CompressionMetadata.java | 3 - .../apache/cassandra/io/sstable/Descriptor.java| 2 - .../io/sstable/SSTableIdentityIterator.java| 1 - .../cassandra/io/sstable/format/SSTableReader.java | 30 +- .../io/sstable/format/SSTableReaderBuilder.java| 2 - .../io/sstable/format/big/BigTableWriter.java | 2 +- .../io/sstable/metadata/MetadataSerializer.java| 1 - .../io/util/BufferedDataOutputStreamPlus.java | 3 + .../org/apache/cassandra/io/util/FileHandle.java | 12 +- .../org/apache/cassandra/io/util/PathUtils.java| 2 - .../apache/cassandra/locator/TokenMetadata.java| 76 +- src/java/org/apache/cassandra/metrics/Sampler.java | 2 +- .../cassandra/net/AbstractMessageHandler.java | 2 +- .../cassandra/net/InboundMessageHandler.java | 2 +- .../cassandra/net/InboundMessageHandlers.java | 2 +- src/java/org/apache/cassandra/net/Message.java | 2 +- .../apache/cassandra/net/OutboundConnection.java | 2 +- .../org/apache/cassandra/net/RequestCallbacks.java | 2 +- .../apache/cassandra/net/ResponseVerbHandler.java | 2 +- src/java/org/apache/cassandra/net/Verb.java| 2 +- .../repair/consistent/SyncStatSummary.java | 1 - .../apache/cassandra/schema/MigrationManager.java | 4 + .../apache/cassandra/schema/SchemaKeyspace.java| 3 + .../schema/SystemDistributedKeyspace.java | 5 +- .../cassandra/service/ActiveRepairService.java | 3 + .../apache/cassandra/service/StartupChecks.java| 2 - .../org/apache/cassandra/service/StorageProxy.java | 28 +- .../apache/cassandra/service/StorageService.java | 1 -
[jira] [Commented] (CASSANDRA-16894) Java 11 support - remove the experimental flag
[ https://issues.apache.org/jira/browse/CASSANDRA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451191#comment-17451191 ] Ekaterina Dimitrova commented on CASSANDRA-16894: - I agree, the patch was created before 4.0.1 but I thought we are waiting on the ASCII patch to deal with these tickets? I am going to follow up with Lorina this week. > Java 11 support - remove the experimental flag > -- > > Key: CASSANDRA-16894 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16894 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > As per this [thread. > |https://lists.apache.org/thread.html/r06a4768bae215dc19469491a1faec64dd90e1c3d4d10ed34b85ba248%40%3Cdev.cassandra.apache.org%3E]the > goal of this ticket is to remove the experimental flag for Java 11 support. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17147) Guardrails prototype
[
https://issues.apache.org/jira/browse/CASSANDRA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451187#comment-17451187
]
Andres de la Peña edited comment on CASSANDRA-17147 at 11/30/21, 3:23 PM:
--
bq. I am off for the year after this week (Friday is my last day). Ill try to
prioritize review to make sure I don't drop it, but if still pending by then
can pick back up January 3rd
Thanks for the update, I'll also try to prioritize this during this week. It
would be great if we manage to get this ready by the end of the week so we can
start working on the rest of the tickets in the guardrails epic.
I think our main concern at this point is the nested yaml config. We don't have
a clear outcome for the discussion about that in the mail list, although it
seems that probably we are going in that direction. I'll try to get ready a
version of the patch with nested config, even if we miss some of the ongoing
config improvements.
was (Author: adelapena):
{quote}
I am off for the year after this week (Friday is my last day). Ill try to
prioritize review to make sure I don't drop it, but if still pending by then
can pick back up January 3rd
{quote}
Thanks for the update, I'll also try to prioritize this during this week. It
would be great if we manage to get this ready by the end of the week so we can
start working on the rest of the tickets in the guardrails epic.
I think our main concern at this point is the nested yaml config. We don't have
a clear outcome for the discussion about that in the mail list, although it
seems that probably we are going in that direction. I'll try to get ready a
version of the patch with nested config, even if we miss some of the ongoing
config improvements.
> Guardrails prototype
>
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17147) Guardrails prototype
[
https://issues.apache.org/jira/browse/CASSANDRA-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451187#comment-17451187
]
Andres de la Peña commented on CASSANDRA-17147:
---
{quote}
I am off for the year after this week (Friday is my last day). Ill try to
prioritize review to make sure I don't drop it, but if still pending by then
can pick back up January 3rd
{quote}
Thanks for the update, I'll also try to prioritize this during this week. It
would be great if we manage to get this ready by the end of the week so we can
start working on the rest of the tickets in the guardrails epic.
I think our main concern at this point is the nested yaml config. We don't have
a clear outcome for the discussion about that in the mail list, although it
seems that probably we are going in that direction. I'll try to get ready a
version of the patch with nested config, even if we miss some of the ongoing
config improvements.
> Guardrails prototype
>
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17048) Replace sequential sstable generation identifier with UUID v1
[ https://issues.apache.org/jira/browse/CASSANDRA-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451169#comment-17451169 ] Benjamin Lerer commented on CASSANDRA-17048: On problem, I see is with the current patch is that the existing tests will not check the use of the new identifier but the use of the old one. We also probably need to also check the transistion from the sequential one to the UUID one. > Replace sequential sstable generation identifier with UUID v1 > - > > Key: CASSANDRA-17048 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17048 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.1 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Replace the current sequential sstable generation identifier with ULID based. > ULID is better because we do not need to scan the existing files to pick the > starting number as well as we can generate globally unique identifiers. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16890) WEBSITE - Remove section with company logos from homepage
[ https://issues.apache.org/jira/browse/CASSANDRA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16890: --- Fix Version/s: 4.0.2 4.1 (was: 4.0.x) Source Control Link: https://github.com/apache/cassandra-website/commit/ea789239ef6d08fd91bf055ef363769c1751a223 Resolution: Fixed Status: Resolved (was: Ready to Commit) > WEBSITE - Remove section with company logos from homepage > - > > Key: CASSANDRA-16890 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16890 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.2, 4.1 > > Attachments: Apache-Cassandra-Apache-Cassandra-Documentation.png > > > [~mck] advised that the company logos on the homepage are a breach of ASF > policy so will need to be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16890) WEBSITE - Remove section with company logos from homepage
[ https://issues.apache.org/jira/browse/CASSANDRA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16890: --- Status: Ready to Commit (was: Review In Progress) > WEBSITE - Remove section with company logos from homepage > - > > Key: CASSANDRA-16890 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16890 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Attachments: Apache-Cassandra-Apache-Cassandra-Documentation.png > > > [~mck] advised that the company logos on the homepage are a breach of ASF > policy so will need to be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16890) WEBSITE - Remove section with company logos from homepage
[ https://issues.apache.org/jira/browse/CASSANDRA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451088#comment-17451088 ] Michael Semb Wever commented on CASSANDRA-16890: Committed as [ea789239e|https://github.com/apache/cassandra-website/commit/ea789239ef6d08fd91bf055ef363769c1751a223]. It is on [staging|https://cassandra.staged.apache.org/_/index.html] now. > WEBSITE - Remove section with company logos from homepage > - > > Key: CASSANDRA-16890 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16890 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Attachments: Apache-Cassandra-Apache-Cassandra-Documentation.png > > > [~mck] advised that the company logos on the homepage are a breach of ASF > policy so will need to be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch trunk updated: Removing logos from home page
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-website.git The following commit(s) were added to refs/heads/trunk by this push: new ea78923 Removing logos from home page ea78923 is described below commit ea789239ef6d08fd91bf055ef363769c1751a223 Author: Paul Thomas Au AuthorDate: Wed Sep 22 15:11:01 2021 -0700 Removing logos from home page patch by Paul Thomas Au; reviewed by Mick Semb Wever, Erick Ramirex for CASSANDRA-16890 --- .../blog/cassandra-on-kubernetes-beginner.png | Bin 0 -> 110165 bytes site-content/source/modules/ROOT/pages/index.adoc | 297 +++-- site-ui/src/css/tt_styles.css | 37 +++ site-ui/src/img/big-quotes.png | Bin 0 -> 3447 bytes site-ui/src/layouts/home.hbs | 11 +- 5 files changed, 85 insertions(+), 260 deletions(-) diff --git a/site-content/source/modules/ROOT/images/blog/cassandra-on-kubernetes-beginner.png b/site-content/source/modules/ROOT/images/blog/cassandra-on-kubernetes-beginner.png new file mode 100644 index 000..2f65e16 Binary files /dev/null and b/site-content/source/modules/ROOT/images/blog/cassandra-on-kubernetes-beginner.png differ diff --git a/site-content/source/modules/ROOT/pages/index.adoc b/site-content/source/modules/ROOT/pages/index.adoc index d184912..b630384 100644 --- a/site-content/source/modules/ROOT/pages/index.adoc +++ b/site-content/source/modules/ROOT/pages/index.adoc @@ -137,263 +137,45 @@ Cassandra streams data between nodes during scaling operations such as adding a [discrete] == Cassandra Users Cassandra is used by thousands of companies with large active data sets. -[openblock,all-users] + +[openblock,cf home-quotes py-large] -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/ably_full_logo.png[ably logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/activision_black_text.png[activision logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/adstage_full_white_text.jpg[adstage logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/bazaar_full.png[bazaar logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/best_buy.png[best buy logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/bigmate.png[bigmate logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/blackberry_black_text.jpg[blackberry logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/blackrock_logo.png[blacktread logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/bloomberg.png[bloomberg logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/campaign-monitor_black_text.png[campaign monitor logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/cern_blue_text.png[CERN logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/clearcapital_full.png[Clear Capital logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/cloudkick.png[cloudkick logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/cloudtrax_logo.png[cloudtrax logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/constant_contact_white_text.png[constant contact logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/coursera_blue_text.png[coursera blue logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/datacloud.png[datacloud logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/discord_full.png[discord logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/ebay_logo.png[ebay logo logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/equinix.png[equinix logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/flant.png[flant logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/grubhub_red_text.jpg[grubhub logo] --- -[openblock,grayscale company-logo inline25 inline-middle] --- -image::companies/home_depot.jpg[home depot logo] ---
[jira] [Commented] (CASSANDRA-16890) WEBSITE - Remove section with company logos from homepage
[ https://issues.apache.org/jira/browse/CASSANDRA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451083#comment-17451083 ] Erick Ramirez commented on CASSANDRA-16890: --- [~mck] the screenshot looks good to me although I noted that the [homepage in staging|https://cassandra.staged.apache.org/] is still showing the logos so I'm assuming you haven't pushed it there yet. > WEBSITE - Remove section with company logos from homepage > - > > Key: CASSANDRA-16890 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16890 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Erick Ramirez >Assignee: Paul Au >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Attachments: Apache-Cassandra-Apache-Cassandra-Documentation.png > > > [~mck] advised that the company logos on the homepage are a breach of ASF > policy so will need to be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451079#comment-17451079 ] Erick Ramirez commented on CASSANDRA-16994: --- Sorry, I somehow missed this. Didn't realise this was on my list. Will work on it in the next 24 hours. > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: NA > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Ramirez updated CASSANDRA-16994: -- Change Category: Semantic (was: Operability) Complexity: Normal (was: Low Hanging Fruit) Fix Version/s: 4.0.x (was: NA) Status: Open (was: Triage Needed) > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: 4.0.x > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[
https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451067#comment-17451067
]
Benedict Elliott Smith commented on CASSANDRA-15254:
bq. all configs exposed via system properties
If we're looking at exposing things through system properties, it would be much
nicer IMO to properly unify them so that all system properties are also
settable as {{Config}} parameters, so we can eventually have a properly unified
approach (system properties, config file, virtual table). An annoying job
though.
> Allow UPDATE on settings virtual table to change running configurations
> ---
>
> Key: CASSANDRA-15254
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15254
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Virtual Tables
>Reporter: Chris Lohfink
>Assignee: Benjamin Lerer
>Priority: Normal
>
> Allow using UPDATE on the system_views.settings virtual table to update
> configs at runtime for the equivalent of the dispersed JMX
> attributes/operations.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15215) VIntCoding should read and write more efficiently
[ https://issues.apache.org/jira/browse/CASSANDRA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451029#comment-17451029 ] Benedict Elliott Smith commented on CASSANDRA-15215: I suspect we just need a better unit test for the encode and decode methods, that test serialising and deserialising a sequence of random integers and verifies the sequence is intact, for each variant have implemented. > VIntCoding should read and write more efficiently > - > > Key: CASSANDRA-15215 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15215 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction, Local/SSTable >Reporter: Benedict Elliott Smith >Assignee: Aleksandr Sorokoumov >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.x > > Attachments: testWriteRandomLongDOP_final.png, > writeUnsignedVInt_megamorphic_BB.png, writeUnsignedVInt_megamorphic_DOP.png > > Time Spent: 40m > Remaining Estimate: 0h > > Most vints occupy significantly fewer than 8 bytes, and most buffers have >= > 8 bytes spare, in which case we can construct the relevant bytes in a > register and memcpy them to the correct position. Since we read and write a > lot of vints, this waste is probably measurable, particularly during > compaction and flush, and can probably be considered a performance bug. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15215) VIntCoding should read and write more efficiently
[ https://issues.apache.org/jira/browse/CASSANDRA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451023#comment-17451023 ] Aleksandr Sorokoumov commented on CASSANDRA-15215: -- I'll fix test failures closer to the end of the week, probably on the weekend. > VIntCoding should read and write more efficiently > - > > Key: CASSANDRA-15215 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15215 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction, Local/SSTable >Reporter: Benedict Elliott Smith >Assignee: Aleksandr Sorokoumov >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.x > > Attachments: testWriteRandomLongDOP_final.png, > writeUnsignedVInt_megamorphic_BB.png, writeUnsignedVInt_megamorphic_DOP.png > > Time Spent: 40m > Remaining Estimate: 0h > > Most vints occupy significantly fewer than 8 bytes, and most buffers have >= > 8 bytes spare, in which case we can construct the relevant bytes in a > register and memcpy them to the correct position. Since we read and write a > lot of vints, this waste is probably measurable, particularly during > compaction and flush, and can probably be considered a performance bug. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450959#comment-17450959 ] Benjamin Lerer commented on CASSANDRA-15254: The current approach was exposing all Config fields in the virtual table even if those where deprecated as they were found through reflection. The idea was to not expose them in the virtual table. I kind of forget how [~e.dimitrova] patch is working. I would need to have a look at it. > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Benjamin Lerer >Priority: Normal > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16994) WEBSITE - September 2021 website edits
[ https://issues.apache.org/jira/browse/CASSANDRA-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450951#comment-17450951 ] Diogenese Topper commented on CASSANDRA-16994: -- [~mck] [~flightc] - ticket is still valid. Typos and incorrect links are still live. Index is a little dated at this point. > WEBSITE - September 2021 website edits > -- > > Key: CASSANDRA-16994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16994 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Assignee: Erick Ramirez >Priority: Normal > Fix For: NA > > > Edits and fixes for formatting and typos across the website. > Can be closed upon merged changes. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
