[jira] [Assigned] (CASSANDRA-18027) Use G1GC as default
[ https://issues.apache.org/jira/browse/CASSANDRA-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever reassigned CASSANDRA-18027: -- Assignee: Michael Semb Wever > Use G1GC as default > --- > > Key: CASSANDRA-18027 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18027 > Project: Cassandra > Issue Type: Task > Components: Local/Config >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > G1GC is well battle tested now, and the recommended configuration for most > users. CMS can work well on smaller heaps but requires more tuning, initially > and over time. G1GC just works. CMS was deprecated in JDK 9. > Patch at > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/7486/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18027) Use G1GC as default
[ https://issues.apache.org/jira/browse/CASSANDRA-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18027: --- Test and Documentation Plan: CI Status: Patch Available (was: Open) > Use G1GC as default > --- > > Key: CASSANDRA-18027 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18027 > Project: Cassandra > Issue Type: Task > Components: Local/Config >Reporter: Michael Semb Wever >Priority: Normal > > G1GC is well battle tested now, and the recommended configuration for most > users. CMS can work well on smaller heaps but requires more tuning, initially > and over time. G1GC just works. CMS was deprecated in JDK 9. > Patch at > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/7486/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (68a6720b -> 4b195b33)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 68a6720b generate docs for a67d0561 new 4b195b33 generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (68a6720b) \ N -- N -- N refs/heads/asf-staging (4b195b33) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970139 -> 4970139 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17964) Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
[ https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631476#comment-17631476 ] Berenguer Blasi commented on CASSANDRA-17964: - Would it make sense to hold this one until 4.1 is out? We probably don't want to add noise on that side of the fence? > Some tests are never executed due to naming violation - fix it and add > checkstyle where applicable > -- > > Key: CASSANDRA-17964 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17964 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Ruslan Fomkin >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > Time Spent: 2h 40m > Remaining Estimate: 0h > > [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java] > doesn't follow naming convention to be run as unit tests and, thus, is never > run. > The rule in build expects names as `*Test`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (d15b3019 -> 68a6720b)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d15b3019 generate docs for a67d0561 new 68a6720b generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d15b3019) \ N -- N -- N refs/heads/asf-staging (68a6720b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970139 -> 4970139 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631449#comment-17631449 ] Ekaterina Dimitrova edited comment on CASSANDRA-18001 at 11/10/22 4:34 AM: --- Rebased the 3.0 patch on top of CASSANDRA-17950 [here|https://github.com/ekaterinadimitrova2/cassandra/commit/7aaa1486bc455f1a3543d3371b7d237a26fcb39a] This is how UI looks like - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18001-3.0] I suggest if there is nothing more to be done to cqlshlib in 4.0+ where those are added (I am trying to address one question offline with the community), we finish those I am adding here to ublock the 4.1 release and back port the cqlshlib tests to older patches in a separate ticket. was (Author: e.dimitrova): Rebased the 3.0 patch on top of CASSANDRA-17950 [here|https://github.com/ekaterinadimitrova2/cassandra/commit/7aaa1486bc455f1a3543d3371b7d237a26fcb39a] > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631449#comment-17631449 ] Ekaterina Dimitrova commented on CASSANDRA-18001: - Rebased the 3.0 patch on top of CASSANDRA-17950 [here|https://github.com/ekaterinadimitrova2/cassandra/commit/7aaa1486bc455f1a3543d3371b7d237a26fcb39a] > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17178) CEP-10: Simulator Java11 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-17178: -- Test and Documentation Plan: existing tests Status: Patch Available (was: In Progress) > CEP-10: Simulator Java11 Support > > > Key: CASSANDRA-17178 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17178 > Project: Cassandra > Issue Type: Task > Components: Test/fuzz >Reporter: Benedict Elliott Smith >Assignee: David Capwell >Priority: Normal > Fix For: NA > > > Java11 introduces new protection domains for package private methods, so that > classes loaded with different class loaders may not access each others’ > package private methods, regardless of the package they are declared within. > There are differences within the JDK also, and there may be byte weaving > targets that need updating (ThreadLocalRandom was one that has been handled) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17178) CEP-10: Simulator Java11 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631393#comment-17631393 ] David Capwell commented on CASSANDRA-17178: --- patch makes idk 11/17 work for simulator. For JDK 17 we can not "build" but if you build with 8 you can run with JDK 17 just fine now with this patch [~e.dimitrova] [~benedict] mind taking a look? > CEP-10: Simulator Java11 Support > > > Key: CASSANDRA-17178 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17178 > Project: Cassandra > Issue Type: Task > Components: Test/fuzz >Reporter: Benedict Elliott Smith >Assignee: David Capwell >Priority: Normal > Fix For: NA > > > Java11 introduces new protection domains for package private methods, so that > classes loaded with different class loaders may not access each others’ > package private methods, regardless of the package they are declared within. > There are differences within the JDK also, and there may be byte weaving > targets that need updating (ThreadLocalRandom was one that has been handled) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18023) Add option to print level with getsstables output
[ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631385#comment-17631385 ] Jordan West edited comment on CASSANDRA-18023 at 11/10/22 1:54 AM: --- Its mad about the use of the guava MultiMap. From the comment it looks like I need to find an alternative in java/javax. I saw a lot more red than expected so planning to look at that before moving further. was (Author: jrwest): Its mad about the use of the guava MultiMap. From the comment it looks like I need to find an alternative in java/javax. > Add option to print level with getsstables output > - > > Key: CASSANDRA-18023 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18023 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > A common operation is to pipe getsstables output to sstablemetadata to > determine the level. This adds friction to operations. Add an optional flag > to getsstables to print the level with data file path. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18023) Add option to print level with getsstables output
[ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631385#comment-17631385 ] Jordan West commented on CASSANDRA-18023: - Its mad about the use of the guava MultiMap. From the comment it looks like I need to find an alternative in java/javax. > Add option to print level with getsstables output > - > > Key: CASSANDRA-18023 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18023 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > A common operation is to pipe getsstables output to sstablemetadata to > determine the level. This adds friction to operations. Add an optional flag > to getsstables to print the level with data file path. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18023) Add option to print level with getsstables output
[ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631383#comment-17631383 ] Brandon Williams commented on CASSANDRA-18023: -- In both runs JMXStandardsTest was broken. > Add option to print level with getsstables output > - > > Key: CASSANDRA-18023 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18023 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > A common operation is to pipe getsstables output to sstablemetadata to > determine the level. This adds friction to operations. Add an optional flag > to getsstables to print the level with data file path. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18023) Add option to print level with getsstables output
[ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan West updated CASSANDRA-18023: Reviewers: Cheng Wang Status: Review In Progress (was: Patch Available) > Add option to print level with getsstables output > - > > Key: CASSANDRA-18023 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18023 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > A common operation is to pipe getsstables output to sstablemetadata to > determine the level. This adds friction to operations. Add an optional flag > to getsstables to print the level with data file path. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18023) Add option to print level with getsstables output
[
https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631380#comment-17631380
]
Jordan West commented on CASSANDRA-18023:
-
Good catch. Updated my branch w/ the recommended change. the {{synchronized}}
was a holdover from my original 3.0 implementation.
> Add option to print level with getsstables output
> -
>
> Key: CASSANDRA-18023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18023
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
>
> A common operation is to pipe getsstables output to sstablemetadata to
> determine the level. This adds friction to operations. Add an optional flag
> to getsstables to print the level with data file path.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17848) LIST PERMISSION can display incorrect resource name
[
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRA-17848:
--
Test and Documentation Plan: unit test; ci
Status: Patch Available (was: Open)
The patch could be like this [https://github.com/apache/cassandra/pull/1992]
> LIST PERMISSION can display incorrect resource name
> ---
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
>
> When producing the resource name, it seems to assume that the content in the
> `[]` is the function's input type, where it could also be part of the
> function name, as long as it is quoted. Here is an example to reproduce. In
> cqlsh,
> {code:java}
> > CREATE FUNCTION
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
> role | username | resource| permission
> ---+--+-+
> user |user | |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long".
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION
> request always fails for the user with "ConfigurationException: Unable to
> find abstract-type class".
> The bug is discovered by Piotr Sarna.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17854) Add JDK17 to our test docker images
[
https://issues.apache.org/jira/browse/CASSANDRA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631363#comment-17631363
]
Ekaterina Dimitrova edited comment on CASSANDRA-17854 at 11/10/22 12:53 AM:
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk
installed. Otherwise we will block this one on the other one and test twice
images also...
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward with this one and be reasonable...?
was (Author: e.dimitrova):
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk
installed.
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward with this one and be reasonable...?
> Add JDK17 to our test docker images
> ---
>
> Key: CASSANDRA-17854
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17854
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
>
> In preparation to support JDK 17 I want to add JDK 17 to our test images to
> enable our CIs for testing with JDK 17
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17854) Add JDK17 to our test docker images
[
https://issues.apache.org/jira/browse/CASSANDRA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631363#comment-17631363
]
Ekaterina Dimitrova edited comment on CASSANDRA-17854 at 11/10/22 12:53 AM:
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk
installed.
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward with this one and be reasonable...?
was (Author: e.dimitrova):
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk
installed.
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward and be reasonable...?
> Add JDK17 to our test docker images
> ---
>
> Key: CASSANDRA-17854
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17854
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
>
> In preparation to support JDK 17 I want to add JDK 17 to our test images to
> enable our CIs for testing with JDK 17
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17854) Add JDK17 to our test docker images
[
https://issues.apache.org/jira/browse/CASSANDRA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631363#comment-17631363
]
Ekaterina Dimitrova commented on CASSANDRA-17854:
-
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk.
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward and be reasonable...?
> Add JDK17 to our test docker images
> ---
>
> Key: CASSANDRA-17854
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17854
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
>
> In preparation to support JDK 17 I want to add JDK 17 to our test images to
> enable our CIs for testing with JDK 17
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17854) Add JDK17 to our test docker images
[
https://issues.apache.org/jira/browse/CASSANDRA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631363#comment-17631363
]
Ekaterina Dimitrova edited comment on CASSANDRA-17854 at 11/10/22 12:53 AM:
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk
installed.
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward and be reasonable...?
was (Author: e.dimitrova):
{quote}I think that should be doable, but probably in a different ticket.
{quote}
Well, different ticket to install also that version and do new image and test
it... I think better for me to do it then here and have both jdk17 and _312 jdk.
Not that I volunteer (just I do not have time really) but it seems to me I have
no choice if I want to move forward and be reasonable...?
> Add JDK17 to our test docker images
> ---
>
> Key: CASSANDRA-17854
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17854
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
>
> In preparation to support JDK 17 I want to add JDK 17 to our test images to
> enable our CIs for testing with JDK 17
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631350#comment-17631350 ] Derek Chen-Becker commented on CASSANDRA-17950: --- Trunk patch LGTM > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (a2e478f9 -> d15b3019)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard a2e478f9 generate docs for a67d0561 new d15b3019 generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a2e478f9) \ N -- N -- N refs/heads/asf-staging (d15b3019) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4970139 -> 4970139 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7486) Migrate to G1GC by default
[ https://issues.apache.org/jira/browse/CASSANDRA-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631325#comment-17631325 ] Michael Semb Wever commented on CASSANDRA-7486: --- Created CASSANDRA-18027 instead of re-opening this. > Migrate to G1GC by default > -- > > Key: CASSANDRA-7486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7486 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config >Reporter: Jonathan Ellis >Priority: Normal > Fix For: 3.0 alpha 1 > > > See > http://www.slideshare.net/MonicaBeckwith/garbage-first-garbage-collector-g1-7486gc-migration-to-expectations-and-advanced-tuning > and https://twitter.com/rbranson/status/482113561431265281 > May want to default 2.1 to G1. > 2.1 is a different animal from 2.0 after moving most of memtables off heap. > Suspect this will help G1 even more than CMS. (NB this is off by default but > needs to be part of the test.) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18027) Use G1GC as default
[ https://issues.apache.org/jira/browse/CASSANDRA-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18027: --- Change Category: Operability Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Use G1GC as default > --- > > Key: CASSANDRA-18027 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18027 > Project: Cassandra > Issue Type: Task > Components: Local/Config >Reporter: Michael Semb Wever >Priority: Normal > > G1GC is well battle tested now, and the recommended configuration for most > users. CMS can work well on smaller heaps but requires more tuning, initially > and over time. G1GC just works. CMS was deprecated in JDK 9. > Patch at > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/7486/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18027) Use G1GC as default
Michael Semb Wever created CASSANDRA-18027: -- Summary: Use G1GC as default Key: CASSANDRA-18027 URL: https://issues.apache.org/jira/browse/CASSANDRA-18027 Project: Cassandra Issue Type: Task Components: Local/Config Reporter: Michael Semb Wever G1GC is well battle tested now, and the recommended configuration for most users. CMS can work well on smaller heaps but requires more tuning, initially and over time. G1GC just works. CMS was deprecated in JDK 9. Patch at https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/7486/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] (CASSANDRA-7486) Migrate to G1GC by default
[ https://issues.apache.org/jira/browse/CASSANDRA-7486 ] Michael Semb Wever deleted comment on CASSANDRA-7486: --- was (Author: michaelsembwever): Patch at https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/7486/trunk > Migrate to G1GC by default > -- > > Key: CASSANDRA-7486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7486 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config >Reporter: Jonathan Ellis >Priority: Normal > Fix For: 3.0 alpha 1 > > > See > http://www.slideshare.net/MonicaBeckwith/garbage-first-garbage-collector-g1-7486gc-migration-to-expectations-and-advanced-tuning > and https://twitter.com/rbranson/status/482113561431265281 > May want to default 2.1 to G1. > 2.1 is a different animal from 2.0 after moving most of memtables off heap. > Suspect this will help G1 even more than CMS. (NB this is off by default but > needs to be part of the test.) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7486) Migrate to G1GC by default
[ https://issues.apache.org/jira/browse/CASSANDRA-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631321#comment-17631321 ] Michael Semb Wever commented on CASSANDRA-7486: --- Patch at https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/7486/trunk > Migrate to G1GC by default > -- > > Key: CASSANDRA-7486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7486 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config >Reporter: Jonathan Ellis >Priority: Normal > Fix For: 3.0 alpha 1 > > > See > http://www.slideshare.net/MonicaBeckwith/garbage-first-garbage-collector-g1-7486gc-migration-to-expectations-and-advanced-tuning > and https://twitter.com/rbranson/status/482113561431265281 > May want to default 2.1 to G1. > 2.1 is a different animal from 2.0 after moving most of memtables off heap. > Suspect this will help G1 even more than CMS. (NB this is off by default but > needs to be part of the test.) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17254) nodetool toppartitions can fail because ByteBuffer.array() returns more bytes than would be considered valid by UTF8Serializer.validate
[
https://issues.apache.org/jira/browse/CASSANDRA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631318#comment-17631318
]
Brandon Williams commented on CASSANDRA-17254:
--
+1
> nodetool toppartitions can fail because ByteBuffer.array() returns more bytes
> than would be considered valid by UTF8Serializer.validate
> ---
>
> Key: CASSANDRA-17254
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17254
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
> Fix For: 3.0.x
>
>
> The error below is caused by the use of
> [{{ByteBuffer.array()}}|https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L1628].
> Doing so not only makes the hex key potentially incorrect but causes invalid
> data to be passed to {{AbstractType.getString}} and ultimately
> {{UTF8Validator.validate}}.
> {code}
> error: String didn't validate.
> -- StackTrace --
> org.apache.cassandra.serializers.MarshalException: String didn't validate.
> at
> org.apache.cassandra.serializers.UTF8Serializer.validate(UTF8Serializer.java:35)
> at
> org.apache.cassandra.db.marshal.AbstractType.getString(AbstractType.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.finishLocalSampling(ColumnFamilyStore.java:1633)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631316#comment-17631316 ] Ekaterina Dimitrova commented on CASSANDRA-17950: - LGTM, I will still leave it for the others to double-check it until tomorrow. In the meantime the other branches were confirmed so I will cherry-pick them and rebase the other ticket on top. So this is "almost" not a blocker to finish these works. > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18023) Add option to print level with getsstables output
[ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631315#comment-17631315 ] Cheng Wang edited comment on CASSANDRA-18023 at 11/9/22 10:15 PM: -- +1. LGTM. The only comment is in src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java public synchronized boolean isLeveledCompaction() It might be better to use the readLock instead of the synchronized method to be consistent with rest of the file, and to have better performance because you can have multiple concurrent threads holding the read lock? was (Author: JIRAUSER291462): +1. LGTM. The only comment is in src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java public synchronized boolean isLeveledCompaction() I might be better to use the readLock instead of the synchronized method to be consistent with rest of the file, and to have better performance because you can have multiple concurrent threads holding the read lock? > Add option to print level with getsstables output > - > > Key: CASSANDRA-18023 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18023 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > A common operation is to pipe getsstables output to sstablemetadata to > determine the level. This adds friction to operations. Add an optional flag > to getsstables to print the level with data file path. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18023) Add option to print level with getsstables output
[ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631315#comment-17631315 ] Cheng Wang commented on CASSANDRA-18023: +1. LGTM. The only comment is in src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java public synchronized boolean isLeveledCompaction() I might be better to use the readLock instead of the synchronized method to be consistent with rest of the file, and to have better performance because you can have multiple concurrent threads holding the read lock? > Add option to print level with getsstables output > - > > Key: CASSANDRA-18023 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18023 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > A common operation is to pipe getsstables output to sstablemetadata to > determine the level. This adds friction to operations. Add an optional flag > to getsstables to print the level with data file path. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (5601abce -> a2e478f9)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 5601abce generate docs for a67d0561 new a2e478f9 generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5601abce) \ N -- N -- N refs/heads/asf-staging (a2e478f9) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4970139 -> 4970139 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17878) Harden parsing of boolean values in CQL in PropertyDefinitions
[
https://issues.apache.org/jira/browse/CASSANDRA-17878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-17878:
--
Status: Ready to Commit (was: Changes Suggested)
> Harden parsing of boolean values in CQL in PropertyDefinitions
> --
>
> Key: CASSANDRA-17878
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17878
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter, CQL/Semantics
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is currently this in PropertyDefinitions class as a pattern we use for
> testing a boolean value in cqlsh
> {code}
> private static final Pattern PATTERN_POSITIVE =
> Pattern.compile("(1|true|yes)");
> {code}
> This might be source of mistakes and typos. For example, if a user does, for
> example:
> {code}
> ALTER TABLE ks.tb WITH cdc = tru;
> {code}
> If he does not notice it, he thinks that cdc is true, but it is not.
> More to it, currently, everything which is not "1", "true", or "yes" is
> evaluated as false. We should harden this in such a way that both logical
> true and false would be parsed only on well defined values and every other
> value would be rejected and a query would fail.
> EDIT: I have checked how it behaves in cqlsh and there seems to be validation
> of this already like this:
> {code}
> cqlsh> ALTER TABLE abc.def WITH cdc = tru;
> SyntaxException: line 1:31 no viable alternative at input 'tru' (ALTER TABLE
> abc.def WITH [cdc] =...)
> {code}
> It seems that cqlsh already knows this should be a boolean and rejects such
> query.
> Nevertheless, it is still reasonable to harden this on the code level when a
> query is executed in Java, programmatically (e.g. as part of tests or
> similar). The patch also includes optimizations to not return Boolean but
> boolean on related methods (other primitives are covered as well).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17878) Harden parsing of boolean values in CQL in PropertyDefinitions
[
https://issues.apache.org/jira/browse/CASSANDRA-17878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-17878:
--
Fix Version/s: 4.x
> Harden parsing of boolean values in CQL in PropertyDefinitions
> --
>
> Key: CASSANDRA-17878
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17878
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter, CQL/Semantics
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is currently this in PropertyDefinitions class as a pattern we use for
> testing a boolean value in cqlsh
> {code}
> private static final Pattern PATTERN_POSITIVE =
> Pattern.compile("(1|true|yes)");
> {code}
> This might be source of mistakes and typos. For example, if a user does, for
> example:
> {code}
> ALTER TABLE ks.tb WITH cdc = tru;
> {code}
> If he does not notice it, he thinks that cdc is true, but it is not.
> More to it, currently, everything which is not "1", "true", or "yes" is
> evaluated as false. We should harden this in such a way that both logical
> true and false would be parsed only on well defined values and every other
> value would be rejected and a query would fail.
> EDIT: I have checked how it behaves in cqlsh and there seems to be validation
> of this already like this:
> {code}
> cqlsh> ALTER TABLE abc.def WITH cdc = tru;
> SyntaxException: line 1:31 no viable alternative at input 'tru' (ALTER TABLE
> abc.def WITH [cdc] =...)
> {code}
> It seems that cqlsh already knows this should be a boolean and rejects such
> query.
> Nevertheless, it is still reasonable to harden this on the code level when a
> query is executed in Java, programmatically (e.g. as part of tests or
> similar). The patch also includes optimizations to not return Boolean but
> boolean on related methods (other primitives are covered as well).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17878) Harden parsing of boolean values in CQL in PropertyDefinitions
[
https://issues.apache.org/jira/browse/CASSANDRA-17878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631307#comment-17631307
]
Stefan Miklosovic commented on CASSANDRA-17878:
---
trunk j11 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1553/workflows/a5f6828c-136a-4249-8679-3e6a7d95ef16]
trunk j8 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1553/workflows/714ad996-90b0-45d1-99d0-d2d539ca5b1d]
4.1 j11 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1552/workflows/327ea0f3-125a-46f3-999e-cd27b7e8941b]
4.1 j8 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1552/workflows/9a8d025c-781a-43cf-985e-e42f6d7ed38c]
4.0 j11 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1545/workflows/d02995d5-8acb-4c45-ab2b-9abd8b5a3134]
4.0 j8 pre-commit
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1545/workflows/1a773e1e-c797-4c1d-b015-2bab09539fa0]
> Harden parsing of boolean values in CQL in PropertyDefinitions
> --
>
> Key: CASSANDRA-17878
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17878
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter, CQL/Semantics
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is currently this in PropertyDefinitions class as a pattern we use for
> testing a boolean value in cqlsh
> {code}
> private static final Pattern PATTERN_POSITIVE =
> Pattern.compile("(1|true|yes)");
> {code}
> This might be source of mistakes and typos. For example, if a user does, for
> example:
> {code}
> ALTER TABLE ks.tb WITH cdc = tru;
> {code}
> If he does not notice it, he thinks that cdc is true, but it is not.
> More to it, currently, everything which is not "1", "true", or "yes" is
> evaluated as false. We should harden this in such a way that both logical
> true and false would be parsed only on well defined values and every other
> value would be rejected and a query would fail.
> EDIT: I have checked how it behaves in cqlsh and there seems to be validation
> of this already like this:
> {code}
> cqlsh> ALTER TABLE abc.def WITH cdc = tru;
> SyntaxException: line 1:31 no viable alternative at input 'tru' (ALTER TABLE
> abc.def WITH [cdc] =...)
> {code}
> It seems that cqlsh already knows this should be a boolean and rejects such
> query.
> Nevertheless, it is still reasonable to harden this on the code level when a
> query is executed in Java, programmatically (e.g. as part of tests or
> similar). The patch also includes optimizations to not return Boolean but
> boolean on related methods (other primitives are covered as well).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18026) Operability improvements around internode_max_message_size[_in_bytes] in 4.0+
[
https://issues.apache.org/jira/browse/CASSANDRA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18026:
Change Category: Operability
Complexity: Normal
Component/s: Documentation/NEWS.txt
Local/Config
Messaging/Internode
Fix Version/s: 4.0.x
4.1.x
4.x
Status: Open (was: Triage Needed)
> Operability improvements around internode_max_message_size[_in_bytes] in 4.0+
> -
>
> Key: CASSANDRA-18026
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18026
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/NEWS.txt, Local/Config, Messaging/Internode
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
>
> There are a few things we could do to make {{internode_max_message_size}}
> (formerly {{internode_max_message_size_in_bytes}}) a bit more friendly:
> 1.) If a read fails because of an {{OversizedMessageException}}, it would be
> nice to emit a client warning. Currently the client gets a
> {{ReadFailureException}}, surfaced as something like this:
> {noformat}
> msg="Cassandra failure during read query at consistency QUORUM (3 responses
> were required but only 0 replica responded, 2 failed)"
> query="SELECT key, column1, value FROM ks.tbl WHERE key=? AND column1>? AND
> column1<=? LIMIT 256;"
> stackTrace="com.datastax.driver.core.exceptions.ReadFailureException:
> Cassandra failure during read query at consistency QUORUM (3 responses were
> required but only 0 replica responded, 2 failed)
> {noformat}
> 2.) We should add an entry in {{NEWS.txt}} to indicate the possible impact of
> {{internode_max_message_size_in_bytes}} when upgrading to 4.0+.
> 3.) {{internode_max_message_size_in_bytes}} / {{internode_max_message_size}}
> should be settable at runtime via JMX/vtable/etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18026) Operability improvements around internode_max_message_size[_in_bytes] in 4.0+
Caleb Rackliffe created CASSANDRA-18026:
---
Summary: Operability improvements around
internode_max_message_size[_in_bytes] in 4.0+
Key: CASSANDRA-18026
URL: https://issues.apache.org/jira/browse/CASSANDRA-18026
Project: Cassandra
Issue Type: Improvement
Reporter: Caleb Rackliffe
There are a few things we could do to make {{internode_max_message_size}}
(formerly {{internode_max_message_size_in_bytes}}) a bit more friendly:
1.) If a read fails because of an {{OversizedMessageException}}, it would be
nice to emit a client warning. Currently the client gets a
{{ReadFailureException}}, surfaced as something like this:
{noformat}
msg="Cassandra failure during read query at consistency QUORUM (3 responses
were required but only 0 replica responded, 2 failed)"
query="SELECT key, column1, value FROM ks.tbl WHERE key=? AND column1>? AND
column1<=? LIMIT 256;"
stackTrace="com.datastax.driver.core.exceptions.ReadFailureException: Cassandra
failure during read query at consistency QUORUM (3 responses were required but
only 0 replica responded, 2 failed)
{noformat}
2.) We should add an entry in {{NEWS.txt}} to indicate the possible impact of
{{internode_max_message_size_in_bytes}} when upgrading to 4.0+.
3.) {{internode_max_message_size_in_bytes}} / {{internode_max_message_size}}
should be settable at runtime via JMX/vtable/etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17254) nodetool toppartitions can fail because ByteBuffer.array() returns more bytes than would be considered valid by UTF8Serializer.validate
[
https://issues.apache.org/jira/browse/CASSANDRA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-17254:
Fix Version/s: (was: 3.11.x)
> nodetool toppartitions can fail because ByteBuffer.array() returns more bytes
> than would be considered valid by UTF8Serializer.validate
> ---
>
> Key: CASSANDRA-17254
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17254
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
> Fix For: 3.0.x
>
>
> The error below is caused by the use of
> [{{ByteBuffer.array()}}|https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L1628].
> Doing so not only makes the hex key potentially incorrect but causes invalid
> data to be passed to {{AbstractType.getString}} and ultimately
> {{UTF8Validator.validate}}.
> {code}
> error: String didn't validate.
> -- StackTrace --
> org.apache.cassandra.serializers.MarshalException: String didn't validate.
> at
> org.apache.cassandra.serializers.UTF8Serializer.validate(UTF8Serializer.java:35)
> at
> org.apache.cassandra.db.marshal.AbstractType.getString(AbstractType.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.finishLocalSampling(ColumnFamilyStore.java:1633)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17254) nodetool toppartitions can fail because ByteBuffer.array() returns more bytes than would be considered valid by UTF8Serializer.validate
[
https://issues.apache.org/jira/browse/CASSANDRA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631300#comment-17631300
]
Jordan West commented on CASSANDRA-17254:
-
Updated the branch linked above with the 3.11 code and kicked off tests
[here|https://app.circleci.com/pipelines/github/jrwest/cassandra/112/workflows/4c88ab60-cd11-4579-b4ee-d8f3c241d6fc]
> nodetool toppartitions can fail because ByteBuffer.array() returns more bytes
> than would be considered valid by UTF8Serializer.validate
> ---
>
> Key: CASSANDRA-17254
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17254
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> The error below is caused by the use of
> [{{ByteBuffer.array()}}|https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L1628].
> Doing so not only makes the hex key potentially incorrect but causes invalid
> data to be passed to {{AbstractType.getString}} and ultimately
> {{UTF8Validator.validate}}.
> {code}
> error: String didn't validate.
> -- StackTrace --
> org.apache.cassandra.serializers.MarshalException: String didn't validate.
> at
> org.apache.cassandra.serializers.UTF8Serializer.validate(UTF8Serializer.java:35)
> at
> org.apache.cassandra.db.marshal.AbstractType.getString(AbstractType.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.finishLocalSampling(ColumnFamilyStore.java:1633)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18023) Add option to print level with getsstables output
[
https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-18023:
Test and Documentation Plan: Existing test suite plus sample output
Status: Patch Available (was: Open)
Code: [https://github.com/apache/cassandra/compare/trunk...jrwest:jwest/18023]
Test Runs:
[j8|https://app.circleci.com/pipelines/github/jrwest/cassandra/110/workflows/b1b3c268-ebd7-468a-bd74-876ce176c7be]
[j11|https://app.circleci.com/pipelines/github/jrwest/cassandra/110/workflows/e19e4309-a831-4674-be28-f001b39d50de]
Example output:
{code:java}
$ bin/nodetool getsstables foo bar 4
/home/jordanw/sbx/cass/oss/cassandra/data/data/foo/bar-a58b5910607011ed910347124b0dc061/nb-1-big-Data.db
/home/jordanw/sbx/cass/oss/cassandra/data/data/foo/bar-a58b5910607011ed910347124b0dc061/nb-2-big-Data.db
$ bin/nodetool getsstables foo bar 4 -l
0:
/home/jordanw/sbx/cass/oss/cassandra/data/data/foo/bar-a58b5910607011ed910347124b0dc061/nb-1-big-Data.db
0:
/home/jordanw/sbx/cass/oss/cassandra/data/data/foo/bar-a58b5910607011ed910347124b0dc061/nb-2-big-Data.db
$ bin/nodetool compact foo bar
$ bin/nodetool getsstables foo bar 4 -l
1:
/home/jordanw/sbx/cass/oss/cassandra/data/data/foo/bar-a58b5910607011ed910347124b0dc061/nb-3-big-Data.db
{code}
> Add option to print level with getsstables output
> -
>
> Key: CASSANDRA-18023
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18023
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
>
> A common operation is to pipe getsstables output to sstablemetadata to
> determine the level. This adds friction to operations. Add an optional flag
> to getsstables to print the level with data file path.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-12029) Use off-heap memtables by default
[
https://issues.apache.org/jira/browse/CASSANDRA-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever reassigned CASSANDRA-12029:
--
Assignee: Michael Semb Wever
> Use off-heap memtables by default
> -
>
> Key: CASSANDRA-12029
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12029
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Robert Stupp
>Assignee: Michael Semb Wever
>Priority: Low
>
> A memtable configuration for 0mb on-heap and >0 mb off-heap is currently
> rejected.
> I'm not fully sure whether this is intentional, but making the memtable
> completely off-heap could reduce heap usage and GC pressure using a
> configuration like this:
> {code}
> memtable_heap_space_in_mb: 0
> memtable_offheap_space_in_mb: 1024
> memtable_allocation_type: offheap_objects
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12029) Use off-heap memtables by default
[
https://issues.apache.org/jira/browse/CASSANDRA-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-12029:
---
Authors: Michael Semb Wever
Test and Documentation Plan: CI
Status: Patch Available (was: Open)
> Use off-heap memtables by default
> -
>
> Key: CASSANDRA-12029
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12029
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Robert Stupp
>Priority: Low
>
> A memtable configuration for 0mb on-heap and >0 mb off-heap is currently
> rejected.
> I'm not fully sure whether this is intentional, but making the memtable
> completely off-heap could reduce heap usage and GC pressure using a
> configuration like this:
> {code}
> memtable_heap_space_in_mb: 0
> memtable_offheap_space_in_mb: 1024
> memtable_allocation_type: offheap_objects
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12029) Use off-heap memtables by default
[
https://issues.apache.org/jira/browse/CASSANDRA-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631288#comment-17631288
]
Michael Semb Wever commented on CASSANDRA-12029:
patch at
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/12029/trunk
> Use off-heap memtables by default
> -
>
> Key: CASSANDRA-12029
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12029
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Robert Stupp
>Priority: Low
>
> A memtable configuration for 0mb on-heap and >0 mb off-heap is currently
> rejected.
> I'm not fully sure whether this is intentional, but making the memtable
> completely off-heap could reduce heap usage and GC pressure using a
> configuration like this:
> {code}
> memtable_heap_space_in_mb: 0
> memtable_offheap_space_in_mb: 1024
> memtable_allocation_type: offheap_objects
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631264#comment-17631264 ] Ekaterina Dimitrova commented on CASSANDRA-17950: - Figured it out, trunk was rebased one patch earlier than it should have been last night... The repeat_jobs were still there with the previous patch. Pushing CI here for trunk: ||Patch||LOWRES||MIDRES||HIGHRES|| |[trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:17950-trunk2]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-trunk2]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-trunk2-mid]|[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-trunk2-high]| > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631263#comment-17631263
]
Natnael Adere commented on CASSANDRA-17915:
---
[~brandon.williams] The pull requests have been updated to reflect those
changes.
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (0311ffc6 -> 5601abce)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 0311ffc6 generate docs for a67d0561 new 5601abce generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0311ffc6) \ N -- N -- N refs/heads/asf-staging (5601abce) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4970139 -> 4970139 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631223#comment-17631223 ] Ekaterina Dimitrova commented on CASSANDRA-17950: - There is something wrong with trunk while preparing the whole merge fun...looking now into it > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12029) Use off-heap memtables by default
[
https://issues.apache.org/jira/browse/CASSANDRA-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631219#comment-17631219
]
Michael Semb Wever commented on CASSANDRA-12029:
`memtable_heap_space_in_mb` still needs to be defined, as space is still
required on heap (not everything is offheap).
Is the recommendation is to set it to the same value as
`memtable_offheap_space_in_mb` ?
Switching to offheap_objects as the default is absolutely warranted.
> Use off-heap memtables by default
> -
>
> Key: CASSANDRA-12029
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12029
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Robert Stupp
>Priority: Low
>
> A memtable configuration for 0mb on-heap and >0 mb off-heap is currently
> rejected.
> I'm not fully sure whether this is intentional, but making the memtable
> completely off-heap could reduce heap usage and GC pressure using a
> configuration like this:
> {code}
> memtable_heap_space_in_mb: 0
> memtable_offheap_space_in_mb: 1024
> memtable_allocation_type: offheap_objects
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17848) LIST PERMISSION can display incorrect resource name
[
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631210#comment-17631210
]
Yifan Cai commented on CASSANDRA-17848:
---
The issue is on listing the permissions only. It either parses the stored
function name incorrectly or fails to parse. Invoking/using those functions are
allowed.
For example, the below SELECT statement runs just fine (and returns 42 as
defined in the function body).
{code:java}
SELECT a, b,
cql_test_keyspace."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(a,
b) FROM cql_test_keyspace.tbl WHERE a = 1;
{code}
If Cassandra no longer permits creating function with the disallowed
characters, the existing function should not be affected. They can still be
used like the above example. However, it does not fix the broken output form
listing permissions.
So, as Sam said, we need to do both #1 and #2.
bq. perhaps we can localise a custom parsing implementation to
`ListPermissionsStatement`, leave `FunctionResource#fromName` as it is and
tighten up the naming rules going forward?
I think `FunctionResource#fromName` is the right place to have the parsing
logic. Maybe I am missing something?
> LIST PERMISSION can display incorrect resource name
> ---
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
>
> When producing the resource name, it seems to assume that the content in the
> `[]` is the function's input type, where it could also be part of the
> function name, as long as it is quoted. Here is an example to reproduce. In
> cqlsh,
> {code:java}
> > CREATE FUNCTION
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
> role | username | resource| permission
> ---+--+-+
> user |user | |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long".
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION
> request always fails for the user with "ConfigurationException: Unable to
> find abstract-type class".
> The bug is discovered by Piotr Sarna.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (d5f724af -> 0311ffc6)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d5f724af generate docs for a67d0561 new 0311ffc6 generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d5f724af) \ N -- N -- N refs/heads/asf-staging (0311ffc6) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970139 -> 4970139 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17928:
-
Since Version: 4.0-alpha3 (was: 4.0)
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.8, 4.1-rc, 4.2
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17928:
-
Fix Version/s: 4.0.8
4.2
Since Version: 4.0
Source Control Link:
https://github.com/apache/cassandra/commit/70478a1578fe4facb0f59fcb40529e0a4040ac81
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.8, 4.1-rc, 4.2
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17928:
-
Status: Ready to Commit (was: Review In Progress)
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631192#comment-17631192
]
Brandon Williams commented on CASSANDRA-17928:
--
bq. 30K iterations per config and branch is a lot of iterations
bq. I suspect that most tests using spinAssertEquals with a shorter timeout
would also fail if we run them with such a high number of iterations.
I suspect so too, but that may just be the point where you are statistically
bound to get bitten by an environmental problem.
Committed with the timeout changed to 120s.
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 8f47d232faeacb44087712dd5524db96d92aae46
Merge: e12dc48c87 70478a1578
Author: Brandon Williams
AuthorDate: Wed Nov 9 11:59:49 2022 -0600
Merge branch 'cassandra-4.0' into cassandra-4.1
.../commitlog/CommitLogInitWithExceptionTest.java | 32 +-
1 file changed, 7 insertions(+), 25 deletions(-)
diff --cc
test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
index fbad0b4857,21d207bea2..b3cff94c66
---
a/test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
+++
b/test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
@@@ -19,6 -19,6 +19,8 @@@
package org.apache.cassandra.db.commitlog;
++import org.apache.cassandra.Util;
++import org.apache.cassandra.utils.concurrent.Condition;
import org.junit.Assert;
import org.junit.BeforeClass;
import org.junit.Test;
@@@ -27,12 -27,14 +29,13 @@@ import org.apache.cassandra.CassandraIs
import org.apache.cassandra.config.Config;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.utils.JVMStabilityInspector;
-import org.apache.cassandra.utils.concurrent.SimpleCondition;
+
+
@RunWith(CassandraIsolatedJunit4ClassRunner.class)
public class CommitLogInitWithExceptionTest
{
-private final static SimpleCondition killed = new SimpleCondition();
-
+private static Thread initThread;
-
++private final static Condition killed = Condition.newOneTimeCondition();
@BeforeClass
public static void setUp()
{
@@@ -56,41 -58,20 +59,20 @@@
}
finally
{
- Assert.assertNotNull(initThread);
- // We have to manually stop init thread because the JVM does
not exit actually.
- initThread.stop();
-killed.signalAll();
++killed.signal();
}
};
}
- @Test(timeout = 3)
+ @Test
public void testCommitLogInitWithException() {
// This line will trigger initialization process because it's the
first time to access CommitLog class.
-Thread initThread = new Thread(CommitLog.instance::start);
+initThread = new Thread(CommitLog.instance::start);
initThread.setName("initThread");
initThread.start();
- try
- {
- initThread.join(); // Should not block here
- }
- catch (InterruptedException expected)
- {
- }
-
- Assert.assertFalse(initThread.isAlive());
-
- try
- {
- Thread.sleep(1000); // Wait for COMMIT-LOG-ALLOCATOR exit
- }
- catch (InterruptedException e)
- {
- Assert.fail();
- }
-
-
Assert.assertTrue(CommitLog.instance.segmentManager.executor.isTerminated());
// exit successfully
-Util.spinAssertEquals(true, killed::isSignaled, 120);
++Util.spinAssertEquals(true, killed::isSignalled, 10);
}
private static class MockCommitLogSegmentMgr extends
CommitLogSegmentManagerStandard {
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d0e0e20f80f7d5a4b37d542b65f2a781ce1d3015 Merge: d8e0991775 8f47d232fa Author: Brandon Williams AuthorDate: Wed Nov 9 12:00:31 2022 -0600 Merge branch 'cassandra-4.1' into trunk .../commitlog/CommitLogInitWithExceptionTest.java | 32 +- 1 file changed, 7 insertions(+), 25 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (e12dc48c87 -> 8f47d232fa)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from e12dc48c87 Merge branch 'cassandra-4.0' into cassandra-4.1 new 70478a1578 Fix testCommitLogInitWithException: signal condition instead of killing thread new 8f47d232fa Merge branch 'cassandra-4.0' into cassandra-4.1 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../commitlog/CommitLogInitWithExceptionTest.java | 32 +- 1 file changed, 7 insertions(+), 25 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (d8e0991775 -> d0e0e20f80)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from d8e0991775 Merge branch 'cassandra-4.1' into trunk new 70478a1578 Fix testCommitLogInitWithException: signal condition instead of killing thread new 8f47d232fa Merge branch 'cassandra-4.0' into cassandra-4.1 new d0e0e20f80 Merge branch 'cassandra-4.1' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../commitlog/CommitLogInitWithExceptionTest.java | 32 +- 1 file changed, 7 insertions(+), 25 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Fix testCommitLogInitWithException: signal condition instead of killing thread
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 70478a1578 Fix testCommitLogInitWithException: signal condition
instead of killing thread
70478a1578 is described below
commit 70478a1578fe4facb0f59fcb40529e0a4040ac81
Author: Brandon Williams
AuthorDate: Mon Oct 31 11:51:41 2022 -0500
Fix testCommitLogInitWithException: signal condition instead of killing
thread
Patch by brandonwilliams; reviewed by adelapena and bereng for
CASSANDRa-17928
---
.../commitlog/CommitLogInitWithExceptionTest.java | 33 +-
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git
a/test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
b/test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
index 690d9babfc..21d207bea2 100644
---
a/test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
+++
b/test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java
@@ -24,14 +24,16 @@ import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.apache.cassandra.CassandraIsolatedJunit4ClassRunner;
+import org.apache.cassandra.Util;
import org.apache.cassandra.config.Config;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.utils.JVMStabilityInspector;
+import org.apache.cassandra.utils.concurrent.SimpleCondition;
@RunWith(CassandraIsolatedJunit4ClassRunner.class)
public class CommitLogInitWithExceptionTest
{
-private static Thread initThread;
+private final static SimpleCondition killed = new SimpleCondition();
@BeforeClass
public static void setUp()
@@ -56,41 +58,20 @@ public class CommitLogInitWithExceptionTest
}
finally
{
-Assert.assertNotNull(initThread);
-// We have to manually stop init thread because the JVM does
not exit actually.
-initThread.stop();
+killed.signalAll();
}
};
}
-@Test(timeout = 3)
+@Test
public void testCommitLogInitWithException() {
// This line will trigger initialization process because it's the
first time to access CommitLog class.
-initThread = new Thread(CommitLog.instance::start);
+Thread initThread = new Thread(CommitLog.instance::start);
initThread.setName("initThread");
initThread.start();
-try
-{
-initThread.join(); // Should not block here
-}
-catch (InterruptedException expected)
-{
-}
-
-Assert.assertFalse(initThread.isAlive());
-
-try
-{
-Thread.sleep(1000); // Wait for COMMIT-LOG-ALLOCATOR exit
-}
-catch (InterruptedException e)
-{
-Assert.fail();
-}
-
-Assert.assertEquals(Thread.State.TERMINATED,
CommitLog.instance.segmentManager.managerThread.getState()); // exit
successfully
+Util.spinAssertEquals(true, killed::isSignaled, 120);
}
private static class MockCommitLogSegmentMgr extends
CommitLogSegmentManagerStandard {
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17997) Improve git branch handling for CircleCI generate.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-17997: -- Fix Version/s: 3.0.x 4.0.x 4.1.x 4.x > Improve git branch handling for CircleCI generate.sh > > > Key: CASSANDRA-17997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17997 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.0.x, 4.0.x, 4.1.x, 4.x > > > The generate.sh script assumes a base git branch that is local and named > after the official repo branch (e.g. `cassandra-3.11`). This may not be a > local branch if the developer has recently cloned the repo and is creating a > work branch, and will lead to the git commands in generate.sh failing: > > ``` > fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path > not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > ``` > We should be able to make some sanity checks to better guide or warn the > developer if things aren't set up properly to check against git. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17997) Improve git branch handling for CircleCI generate.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631188#comment-17631188 ] Andres de la Peña edited comment on CASSANDRA-17997 at 11/9/22 5:56 PM: Changes look good to me, I have left only a remaining nit on the PR. I have tested the script manually and verified that the specified branch is picked, the default branch is correct, and it complains if the branch is not found. I'm not actually running CI because all this does is generating the config file according to the base branch. One can just see the changed files locally and I can't imagine what pushing the config to Circle would probe. I think now we'll need the approval of a second committer and patches for 3.0, 4.0, 4.1 and trunk. was (Author: adelapena): Changes look good to me, I have left only a remaining nit on the PR. I have tested the script manually and verified that the specified branch is picked, the default is correct and it complains if the branch is not found. I'm not actually running CI because all this does is generating the config file according to the base branch. One can just see the changed files locally and I can't imagine what pushing the config to Circle would probe. I think now we'll need the approval of a second committer and patches for 3.0, 4.0, 4.1 and trunk. > Improve git branch handling for CircleCI generate.sh > > > Key: CASSANDRA-17997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17997 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > > The generate.sh script assumes a base git branch that is local and named > after the official repo branch (e.g. `cassandra-3.11`). This may not be a > local branch if the developer has recently cloned the repo and is creating a > work branch, and will lead to the git commands in generate.sh failing: > > ``` > fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path > not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > ``` > We should be able to make some sanity checks to better guide or warn the > developer if things aren't set up properly to check against git. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17997) Improve git branch handling for CircleCI generate.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-17997: -- Status: Needs Committer (was: Patch Available) > Improve git branch handling for CircleCI generate.sh > > > Key: CASSANDRA-17997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17997 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > > The generate.sh script assumes a base git branch that is local and named > after the official repo branch (e.g. `cassandra-3.11`). This may not be a > local branch if the developer has recently cloned the repo and is creating a > work branch, and will lead to the git commands in generate.sh failing: > > ``` > fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path > not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > ``` > We should be able to make some sanity checks to better guide or warn the > developer if things aren't set up properly to check against git. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17997) Improve git branch handling for CircleCI generate.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-17997: -- Test and Documentation Plan: The script should be manually tested with different base branches, existing and not-existing, using the default branch and a manually specified one. Status: Patch Available (was: Open) > Improve git branch handling for CircleCI generate.sh > > > Key: CASSANDRA-17997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17997 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > > The generate.sh script assumes a base git branch that is local and named > after the official repo branch (e.g. `cassandra-3.11`). This may not be a > local branch if the developer has recently cloned the repo and is creating a > work branch, and will lead to the git commands in generate.sh failing: > > ``` > fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path > not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > ``` > We should be able to make some sanity checks to better guide or warn the > developer if things aren't set up properly to check against git. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17997) Improve git branch handling for CircleCI generate.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631188#comment-17631188 ] Andres de la Peña commented on CASSANDRA-17997: --- Changes look good to me, I have left only a remaining nit on the PR. I have tested the script manually and verified that the specified branch is picked, the default is correct and it complains if the branch is not found. I'm not actually running CI because all this does is generating the config file according to the base branch. One can just see the changed files locally and I can't imagine what pushing the config to Circle would probe. I think now we'll need the approval of a second committer and patches for 3.0, 4.0, 4.1 and trunk. > Improve git branch handling for CircleCI generate.sh > > > Key: CASSANDRA-17997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17997 > Project: Cassandra > Issue Type: Improvement > Components: CI >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > > The generate.sh script assumes a base git branch that is local and named > after the official repo branch (e.g. `cassandra-3.11`). This may not be a > local branch if the developer has recently cloned the repo and is creating a > work branch, and will lead to the git commands in generate.sh failing: > > ``` > fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path > not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > ``` > We should be able to make some sanity checks to better guide or warn the > developer if things aren't set up properly to check against git. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631184#comment-17631184 ] Ekaterina Dimitrova commented on CASSANDRA-17950: - Thanks, preparing branches, starting commit soon > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17950: Status: Ready to Commit (was: Review In Progress) > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (671b16b0 -> d5f724af)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 671b16b0 generate docs for a67d0561 new d5f724af generate docs for a67d0561 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (671b16b0) \ N -- N -- N refs/heads/asf-staging (d5f724af) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../cassandra/configuration/cass_yaml_file.html| 14 -- .../cassandra/configuration/cass_yaml_file.html| 14 -- .../cassandra/configuration/cass_yaml_file.html| 14 -- .../cassandra/configuration/cass_yaml_file.html| 14 -- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4970139 -> 4970139 bytes 6 files changed, 33 insertions(+), 25 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631176#comment-17631176
]
Andres de la Peña commented on CASSANDRA-17928:
---
Yes, I think we can go ahead with the 2min timeout.
I've also run j11 and trunk with the increased timeout and all of them pass:
||Branch||CI||
|[4.1
|https://github.com/adelapena/cassandra/tree/17928-4.1-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2484/workflows/7db9a37e-9866-4d6b-9445-3c5e1e751047]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2484/workflows/4cc51390-8680-4638-a27c-81feb36b73e7]|
|[trunk|https://github.com/adelapena/cassandra/tree/17928-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2486/workflows/3796fc67-ecfd-4e06-90cc-0751768cec25]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2486/workflows/77e044a2-dde3-47ef-ac69-a36c4aca2153]|
30K iterations per config and branch is a lot of iterations. That increases our
chances of hitting both timeouts and races. I guess that seeing that the test
doesn't fail anymore when we increase the max wait time discards the
possibility of an unknown race. I suspect that most tests using
{{spinAssertEquals}} with a shorter timeout would also fail if we run them with
such a high number of iterations.
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631172#comment-17631172 ] Derek Chen-Becker commented on CASSANDRA-17950: --- +1 > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631167#comment-17631167
]
Brandon Williams commented on CASSANDRA-17928:
--
That passed, should we go ahead with that timeout?
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630160#comment-17630160
]
Ekaterina Dimitrova edited comment on CASSANDRA-17950 at 11/9/22 4:44 PM:
--
Thank you both!
{quote}The patch for 3.11 looks good to me, I have left a couple of minor
suggestions on the PR.
{quote}
Feedback incorporated
[4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/4e240587be247fb21808de890270e89b8848d27a],
[CI
#2042|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.0]-
I will rework the patches (which do not apply clean) now when we agree on the
rest. I saw some inconsistencies in the names having both "_" and "-" in the
names and I decided to fix this In a different commit or even maybe in a follow
up ticket as otherwise things become extra noisy and super hard for review.
Seems like in Jenkins we run CQLSH tests only Python3? But as we still do have
best effort Python2 not removed in 4.0, I kept the trend to have the Python2
jobs too.
[4.1|https://github.com/ekaterinadimitrova2/cassandra/commit/5e3b045f2afba3424efd4c86c28664b24905c06c],
[CI
#2045|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.1]
- we removed python 2 in 4.1. Otherwise it is the same as 4.0
Trunk will be the same as 4.1.
If those look ok I can work on midres and highres patches tomorrow.
was (Author: e.dimitrova):
Thank you both!
{quote}The patch for 3.11 looks good to me, I have left a couple of minor
suggestions on the PR.
{quote}
Feedback incorporated
[4.0|https://github.com/ekaterinadimitrova2/cassandra/commit/4e240587be247fb21808de890270e89b8848d27a],
[CI
#2042|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.0]-
I will rework the patches which do not apply clean now when we agree on the
rest. I saw some inconsistencies in the names having both "{-}" and "{-}" in
the names and I decided to fix this In a different commit or even maybe in a
follow up ticket as otherwise things become extra noisy and super hard for
review.
Seems like in Jenkins we run CQLSH tests only Python3? But as we still do have
best effort Python2 not removed in 4.0, I kept the trend to have the Python2
jobs too.
[4.1|https://github.com/ekaterinadimitrova2/cassandra/commit/5e3b045f2afba3424efd4c86c28664b24905c06c],
[CI
#2045|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17950-4.1]
- we removed python 2 in 4.1. Otherwise it is the same as 4.0
Trunk will be the same as 4.1.
If those look ok I can work on midres and highres patches tomorrow.
> Enable dtest-offheap in CircleCI
>
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Urgent
> Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17950: Priority: Urgent (was: Normal) > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Urgent > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18013) Splitter sometimes creates different number of splits than requested
[
https://issues.apache.org/jira/browse/CASSANDRA-18013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18013:
--
Since Version: 3.2
Source Control Link:
https://github.com/apache/cassandra/commit/9213335f59293926b2d643fa8a156a882495dd42
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Splitter sometimes creates different number of splits than requested
>
>
> Key: CASSANDRA-18013
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18013
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 3.11.15, 4.0.8, 4.1, 4.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{Splitter}} in some cases may produce one split more than requested. When it
> happens, it fails with assertion error when assertions are enabled.
> Test to reproduce the issue:
> {code:java}
> Splitter splitter = getSplitter(Murmur3Partitioner.instance);
> long lt = 0;
> long rt = 31;
> Range range = new
> Range<>(getWrappedToken(Murmur3Partitioner.instance, BigInteger.valueOf(lt)),
>
> getWrappedToken(Murmur3Partitioner.instance, BigInteger.valueOf(rt)));
> for (int i = 1; i <= (rt - lt); i++)
> {
> List splits = splitter.splitOwnedRanges(i,
> Arrays.asList(new Splitter.WeightedRange(1.0d, range)), false);
> logger.info("{} splits of {} are: {}", i, range, splits);
> Assertions.assertThat(splits).hasSize(i);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (7b7762826e -> 9213335f59)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 7b7762826e Merge branch 'cassandra-3.0' into cassandra-3.11 add 9213335f59 Fix Splitter sometimes creating more splits than requested No new revisions were added by this update. Summary of changes: CHANGES.txt| 2 ++ src/java/org/apache/cassandra/dht/Splitter.java| 7 +++ .../org/apache/cassandra/dht/SplitterTest.java | 24 ++ 3 files changed, 33 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (0778ae362c -> d8e0991775)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 0778ae362c Merge branch 'cassandra-4.1' into trunk add 9213335f59 Fix Splitter sometimes creating more splits than requested add 67c530171c Merge branch 'cassandra-3.11' into cassandra-4.0 add e12dc48c87 Merge branch 'cassandra-4.0' into cassandra-4.1 new d8e0991775 Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/dht/Splitter.java| 7 +++ .../org/apache/cassandra/dht/SplitterTest.java | 22 ++ 3 files changed, 30 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d8e0991775f8063c72c8ddc69282bf22a4789bcd Merge: 0778ae362c e12dc48c87 Author: Jacek Lewandowski AuthorDate: Wed Nov 9 17:22:35 2022 +0100 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 1 + src/java/org/apache/cassandra/dht/Splitter.java| 7 +++ .../org/apache/cassandra/dht/SplitterTest.java | 22 ++ 3 files changed, 30 insertions(+) diff --cc CHANGES.txt index 5683e3be5e,a9a1091c9d..de216c8688 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -134,8 -71,6 +134,9 @@@ Merged from 4.0 * Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted (CASSANDRA-17663) * silence benign SslClosedEngineException (CASSANDRA-17565) Merged from 3.11: ++ * Fix Splitter sometimes creating more splits than requested (CASSANDRA-18013) + * Suppress CVE-2022-42003 and CVE-2022-42004 (CASSANDRA-17966) + * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) * Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters (CASSANDRA-17840) * Document usage of closed token intervals in manual compaction (CASSANDRA-17575) * Creating of a keyspace on insufficient number of replicas should filter out gosspping-only members (CASSANDRA-17759) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (cea850d67d -> 67c530171c)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from cea850d67d Merge branch 'cassandra-3.11' into cassandra-4.0 add 9213335f59 Fix Splitter sometimes creating more splits than requested add 67c530171c Merge branch 'cassandra-3.11' into cassandra-4.0 No new revisions were added by this update. Summary of changes: CHANGES.txt| 2 +- src/java/org/apache/cassandra/dht/Splitter.java| 7 +++ .../org/apache/cassandra/dht/SplitterTest.java | 22 ++ 3 files changed, 30 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (c100d34a1a -> e12dc48c87)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from c100d34a1a Restore streaming_keep_alive_period functionality on the netty control streaming channel add 9213335f59 Fix Splitter sometimes creating more splits than requested add 67c530171c Merge branch 'cassandra-3.11' into cassandra-4.0 add e12dc48c87 Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/dht/Splitter.java| 7 +++ .../org/apache/cassandra/dht/SplitterTest.java | 22 ++ 3 files changed, 30 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: Revert "ninja-fix disabled until arm64 agents network is stable again"
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
The following commit(s) were added to refs/heads/trunk by this push:
new 7dcff63 Revert "ninja-fix disabled until arm64 agents network is
stable again"
7dcff63 is described below
commit 7dcff63f419d11d4da1b08e91837bae44264e76f
Author: Mick Semb Wever
AuthorDate: Wed Nov 9 17:25:10 2022 +0100
Revert "ninja-fix disabled until arm64 agents network is stable again"
This reverts commit 016d7f0b419d310ef009fd65ad18b9a8aa8de9bc.
---
jenkins-dsl/cassandra_job_dsl_seed.groovy | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index be27d2b..079f438 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -24,7 +24,7 @@ if(binding.hasVariable("CASSANDRA_JDK_LABEL")) {
// architectures. blank is amd64
def archs = ['', '-arm64']
-arm64_enabled = false // disabled while bullseye downloading is stable again
+arm64_enabled = true
arm64_test_label_enabled = false
def use_arm64_test_label() { return arm64_enabled && arm64_test_label_enabled }
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631153#comment-17631153 ] Michael Semb Wever commented on CASSANDRA-17950: +1 > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631133#comment-17631133
]
Ekaterina Dimitrova edited comment on CASSANDRA-17950 at 11/9/22 3:32 PM:
--
4.0 finished fully green, I also verified the amount of offheap tests being run
to be the one we also see in Jenkins :)
{quote}Yes, yes, I'm happy with not making them mandatory on the pre-commit
workflow.
{quote}
I was actually talking about both separate and pre-commit workflows :D Anyway,
let's juggle those when we have 4.1 out, agreed. And thanks :)
was (Author: e.dimitrova):
40 finished fully green, I also verified the amount of offheap tests being run
to be the one we also see in Jenkins :)
{quote}Yes, yes, I'm happy with not making them mandatory on the pre-commit
workflow.
{quote}
I was actually talking about both separate and pre-commit workflows :D Anyway,
let's juggle those when we have 4.1 out, agreed. And thanks :)
> Enable dtest-offheap in CircleCI
>
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631133#comment-17631133
]
Ekaterina Dimitrova commented on CASSANDRA-17950:
-
40 finished fully green, I also verified the amount of offheap tests being run
to be the one we also see in Jenkins :)
{quote}Yes, yes, I'm happy with not making them mandatory on the pre-commit
workflow.
{quote}
I was actually talking about both separate and pre-commit workflows :D Anyway,
let's juggle those when we have 4.1 out, agreed. And thanks :)
> Enable dtest-offheap in CircleCI
>
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627372#comment-17627372 ] Ekaterina Dimitrova edited comment on CASSANDRA-18001 at 11/9/22 3:29 PM: -- Website quick fix submitted in CASSANDRA-18005 was (Author: e.dimitrova): Website quick fix submitted in CASSANDRA-18005 *EDIT:* Finished fully green, I also verified the amount of offheap tests being run to be the one we also see in Jenkins :) > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627372#comment-17627372 ] Ekaterina Dimitrova edited comment on CASSANDRA-18001 at 11/9/22 3:29 PM: -- Website quick fix submitted in CASSANDRA-18005 *EDIT:* Finished fully green, I also verified the amount of offheap tests being run to be the one we also see in Jenkins :) was (Author: e.dimitrova): Website quick fix submitted in CASSANDRA-18005 > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631124#comment-17631124 ] Andres de la Peña commented on CASSANDRA-17950: --- bq. I did it intentionally that way. My reasoning - we do not change the current setup but we also do not want the new ones to be mandatory as we haven't really seen them failing without the others failing. But I agree that we need a broader agreement on what will be mandatory and what not after we have all jobs presented, annual re-evaluation if you will Yes, yes, I'm happy with not making them mandatory on the pre-commit workflow. It's the buttons on the separate workflows what I think we could rearrange, having either a single approval step for all types of cqlsh dtests, or three separate approval steps for regular, vnodes and offheap cqlsh dtests. That's just a small improvement and we can do it separately, maybe in that followup ticket for homogenizing names. But we have a lot of more pressing things to do before. bq. So do I hear I have +1 to commit this one and move to the last ticket on the line? Derek Chen-Becker ? Michael Semb Wever ? +1 from me. > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18001) Add missing tests suites to CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18001: Fix Version/s: 4.1-rc > Add missing tests suites to CircleCI > > > Key: CASSANDRA-18001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18001 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Urgent > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > > Burn tests to all branches, large Python DTests (with/without vnodes), > cqlshlib not tested in all branches and with all jdks; Java distributed tests > not running with J8/J11 4.0+ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17950: Fix Version/s: 4.1-rc > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631113#comment-17631113 ] Ekaterina Dimitrova commented on CASSANDRA-17950: - Started [this 4.0 pre-commit |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2057/workflows/6cca6ba0-8e84-4f99-a989-4285089994b4] for a sanity check while waiting for go/no go :-) > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1763#comment-1763
]
Ekaterina Dimitrova commented on CASSANDRA-17950:
-
{quote}I have tested the patches locally to see that the patches apply cleanly,
the repeated jobs are removed on the absence on tests to be repeated, etc. All
looks good to me to the extent that, as we know, it's a quite manual process. I
hope not to have missed anything.
{quote}
Thank you so much for doing that and for the quick review :)
{quote}I see that on pre-commit offheap cqlsh dtests are optional, whereas
regular and vnodes cqlsh dtests are mandatory, which is ok to me. However, it's
a bit odd that on the separate workflows there is a separate approval step for
offheap cqlsh dtests, whereas regular and vnodes cqlsh dtests are grouped
together under a single approval step. I think we should probably have either a
single approval step for all types of cqlsh dtests, or three separate approval
steps for regular, vnodes and offheap cqlsh dtests. Since that would be just a
very minor improvement we can do it in a separate ticket, and keep going with
this as it is so we get to CI parity as soon as possible.
{quote}
I did it intentionally that way. My reasoning - we do not change the current
setup but we also do not want the new ones to be mandatory as we haven't really
seen them failing without the others failing. But I agree that we need a
broader agreement on what will be mandatory and what not after we have all jobs
presented, annual re-evaluation if you will :D
So do I hear I have +1 to commit this one and move to the last ticket on the
line? [~dchenbecker] ? [~mck] ?
> Enable dtest-offheap in CircleCI
>
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Derek Chen-Becker
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: For slow internets, retry mk-build-deps when debian package building, as it can time out too
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git The following commit(s) were added to refs/heads/trunk by this push: new ab06938 For slow internets, retry mk-build-deps when debian package building, as it can time out too ab06938 is described below commit ab06938814f39a850ba7fcc03d0dc3a24cac716b Author: Mick Semb Wever AuthorDate: Wed Nov 9 12:37:33 2022 +0100 For slow internets, retry mk-build-deps when debian package building, as it can time out too --- docker/build-debs.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docker/build-debs.sh b/docker/build-debs.sh index f9e5366..3bbe892 100755 --- a/docker/build-debs.sh +++ b/docker/build-debs.sh @@ -126,8 +126,10 @@ for x in $(seq 1 3); do done set -e -# Install build dependencies and build package -echo "y" | sudo mk-build-deps --install +# Install build dependencies (retry if failed) +until ( echo "y" | sudo mk-build-deps --install ) ; do echo "mk-build-deps failed… trying again after 10s… " ; sleep 10 ; done + +# build package dpkg-buildpackage -rfakeroot -uc -us # Copy created artifacts to dist dir mapped to docker host directory (must have proper permissions) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631107#comment-17631107
]
Andres de la Peña commented on CASSANDRA-17928:
---
Trying with a higher timeout
[here|https://app.circleci.com/pipelines/github/adelapena/cassandra/2484/workflows/7db9a37e-9866-4d6b-9445-3c5e1e751047].
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-8110) Make streaming forward & backwards compatible
[ https://issues.apache.org/jira/browse/CASSANDRA-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-8110: -- Summary: Make streaming forward & backwards compatible (was: Make streaming backwards compatible) > Make streaming forward & backwards compatible > - > > Key: CASSANDRA-8110 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8110 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Streaming and Messaging >Reporter: Marcus Eriksson >Priority: Normal > Labels: gsoc2016, mentor > > To be able to seamlessly upgrade clusters we need to make it possible to > stream files between nodes with different StreamMessage.CURRENT_VERSION -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-8110) Make streaming backwards compatible
[ https://issues.apache.org/jira/browse/CASSANDRA-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-8110: -- Issue Type: New Feature (was: Improvement) > Make streaming backwards compatible > --- > > Key: CASSANDRA-8110 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8110 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Streaming and Messaging >Reporter: Marcus Eriksson >Priority: Normal > Labels: gsoc2016, mentor > > To be able to seamlessly upgrade clusters we need to make it possible to > stream files between nodes with different StreamMessage.CURRENT_VERSION -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-8110) Make streaming backwards compatible
[ https://issues.apache.org/jira/browse/CASSANDRA-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-8110: -- Fix Version/s: (was: 4.x) > Make streaming backwards compatible > --- > > Key: CASSANDRA-8110 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8110 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Streaming and Messaging >Reporter: Marcus Eriksson >Priority: Normal > Labels: gsoc2016, mentor > > To be able to seamlessly upgrade clusters we need to make it possible to > stream files between nodes with different StreamMessage.CURRENT_VERSION -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17928) Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
[
https://issues.apache.org/jira/browse/CASSANDRA-17928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631076#comment-17631076
]
Berenguer Blasi commented on CASSANDRA-17928:
-
Looks like we hit that unusual long execution even at 30s
> Test Failure:
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
> -
>
> Key: CASSANDRA-17928
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17928
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1-rc
>
>
> [Link|https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/org.apache.cassandra.db.commitlog/CommitLogInitWithExceptionTest/testCommitLogInitWithException_compression/]
> Failed 1 times in the last 14 runs. Flakiness: 7%, Stability: 92%
> Stacktrace
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException(CommitLogInitWithExceptionTest.java:93)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code:java}
> Standard Output
> INFO [main] 2022-09-25 11:43:16,512 Reflections.java:219 - Reflections took
> 1221 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,480 Reflections.java:219 - Reflections took
> 907 ms to scan 8 urls, producing 1756 keys and 6922 values
> INFO [main] 2022-09-25 11:43:17,573 YamlConfigurationLoader.java:104 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2022-09-25 11:43:17,574 YamlConfigurationLoader
> ...[truncated 35568 chars]...
> .apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest$MockCommitLogSegmentMgr.createSegment(CommitLogInitWithExceptionTest.java:106)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager$AllocatorRunnable.run(AbstractCommitLogSegmentManager.java:155)
> at
> org.apache.cassandra.concurrent.InfiniteLoopExecutor.loop(InfiniteLoopExecutor.java:121)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17950) Enable dtest-offheap in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631036#comment-17631036 ] Andres de la Peña commented on CASSANDRA-17950: --- That's looking good :) I have tested the patches locally to see that the patches apply cleanly, the repeated jobs are removed on the absence on tests to be repeated, etc. All looks good to me to the extent that, as we know, it's a quite manual process. I hope not to have missed anything. I see that on pre-commit offheap cqlsh dtests are optional, whereas regular and vnodes cqlsh dtests are mandatory, which is ok to me. However, it's a bit odd that on the separate workflows there is a separate approval step for offheap cqlsh dtests, whereas regular and vnodes cqlsh dtests are grouped together under a single approval step. I think we should probably have either a single approval step for all types of cqlsh dtests, or three separate approval steps for regular, vnodes and offheap cqlsh dtests. Since that would be just a very minor improvement we can do it in a separate ticket, and keep going with this as it is so we get to CI parity as soon as possible. > Enable dtest-offheap in CircleCI > > > Key: CASSANDRA-17950 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17950 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Derek Chen-Becker >Assignee: Derek Chen-Becker >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17768) Restore streaming_keep_alive_period functionality on the netty control streaming channel
[ https://issues.apache.org/jira/browse/CASSANDRA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-17768: --- Fix Version/s: 4.1-beta2 4.1 4.2 (was: 4.1-rc) Since Version: 4.1-alpha1 Source Control Link: https://github.com/apache/cassandra/commit/c100d34a1a1d497eee85ca10c5cc1e43eb4871c4 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [c100d34a1a1d497eee85ca10c5cc1e43eb4871c4|https://github.com/apache/cassandra/commit/c100d34a1a1d497eee85ca10c5cc1e43eb4871c4]. > Restore streaming_keep_alive_period functionality on the netty control > streaming channel > > > Key: CASSANDRA-17768 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17768 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Streaming and Messaging >Reporter: Ekaterina Dimitrova >Assignee: Aleksey Yeschenko >Priority: Normal > Fix For: 4.1-beta2, 4.1, 4.2 > > > While working on another ticket I noticed that after [CASSANDRA-16927] CEP-10 > Phase 1: Refactor Streaming > streaming_keep_alive_period is not used anymore, except to print it in error > message > [here|https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/streaming/StreamSession.java#L689] > If the property should not be used anymore, we need to deprecate it and fix > the error message as it is misleading. > [~benedict] , [~samt] , [~aleksey] , can you, please, check and take care of > this one as authors of that patch? > Thank you in advance! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated: Restore streaming_keep_alive_period functionality on the netty control streaming channel
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.1 by this push:
new c100d34a1a Restore streaming_keep_alive_period functionality on the
netty control streaming channel
c100d34a1a is described below
commit c100d34a1a1d497eee85ca10c5cc1e43eb4871c4
Author: Aleksey Yeschenko
AuthorDate: Wed Nov 2 17:30:57 2022 +
Restore streaming_keep_alive_period functionality on the netty control
streaming channel
patch by Aleksey Yeschenko, Mick Semb Wever; reviewed by Mick Semb Wever,
Berenguer Blasi for CASSANDRA-17768
Co-authored-by: Aleksey Yeschenko
---
CHANGES.txt| 1 +
conf/cassandra.yaml| 14 ++--
.../cassandra/net/InboundConnectionInitiator.java | 7 +-
.../apache/cassandra/streaming/StreamSession.java | 6 +-
.../async/StreamingMultiplexedChannel.java | 74 +-
.../streaming/messages/KeepAliveMessage.java | 30 -
.../streaming/messages/KeepAliveMessageTest.java | 33 +++---
7 files changed, 114 insertions(+), 51 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 10b4ac7016..ffa03b7322 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.1-beta2
+ * Restore streaming_keep_alive_period on the netty control streaming channel
(CASSANDRA-17768)
* Move Schema.FORCE_LOAD_KEYSPACES and Schema.FORCE_LOAD_KEYSPACES_PROP to
CassandraRelevantProps (CASSANDRA-17783)
* Add --resolve-ip option to nodetool gossipinfo (CASSANDRA-17934)
* Allow pre-V5 global limit on bytes in flight to revert to zero
asynchronously in RateLimitingTest (CASSANDRA-17927)
diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml
index 92addc5ae3..ef7cc72605 100644
--- a/conf/cassandra.yaml
+++ b/conf/cassandra.yaml
@@ -1145,12 +1145,14 @@ slow_query_log_timeout: 500ms
# since this is a requirement for general correctness of last write wins.
# internode_timeout: true
-# Set keep-alive period for streaming
-# This node will send a keep-alive message periodically with this period.
-# If the node does not receive a keep-alive message from the peer for
-# 2 keep-alive cycles the stream session times out and fail
-# Default value is 300s (5 minutes), which means stalled stream
-# times out in 10 minutes by default
+# Set period for idle state control messages for earlier detection of failed
streams
+# This node will send a keep-alive message periodically on the streaming's
control channel.
+# This ensures that any eventual SocketTimeoutException will occur within 2
keep-alive cycles
+# If the node cannot send, or timeouts sending, the keep-alive message on the
netty control channel
+# the stream session is closed.
+# Default value is 300s (5 minutes), which means stalled streams
+# are detected within 10 minutes
+# Specify 0 to disable.
# Min unit: s
# streaming_keep_alive_period: 300s
diff --git a/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
b/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
index 7ac479fd9f..807d0262d8 100644
--- a/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
+++ b/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
@@ -452,7 +452,12 @@ public class InboundConnectionInitiator
}
BufferPools.forNetworking().setRecycleWhenFreeForCurrentThread(false);
-NettyStreamingChannel streamingChannel = new
NettyStreamingChannel(current_version, channel, StreamingChannel.Kind.CONTROL);
+
+// we can't infer the type of streaming connection at this point,
+// so we use CONTROL unconditionally; it's ugly but does what we
want
+// (establishes an AsyncStreamingInputPlus)
+NettyStreamingChannel streamingChannel =
+new NettyStreamingChannel(current_version, channel,
StreamingChannel.Kind.CONTROL);
pipeline.replace(this, "streamInbound", streamingChannel);
executorFactory().startThread(String.format("Stream-Deserializer-%s-%s", from,
channel.id()),
new StreamDeserializingTask(null,
streamingChannel, current_version));
diff --git a/src/java/org/apache/cassandra/streaming/StreamSession.java
b/src/java/org/apache/cassandra/streaming/StreamSession.java
index 2da7021968..a540a1b6d0 100644
--- a/src/java/org/apache/cassandra/streaming/StreamSession.java
+++ b/src/java/org/apache/cassandra/streaming/StreamSession.java
@@ -682,11 +682,11 @@ public class StreamSession implements
IEndpointStateChangeSubscriber
{
if (e instanceof SocketTimeoutException)
{
-logger.error("[Stream #{}] Did not receive response from peer {}{}
for {} secs. Is peer down? " +
- "If not, maybe try incr
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0778ae362c56354959b5313be20017b9ea5d2763 Merge: af3eea7558 c100d34a1a Author: Mick Semb Wever AuthorDate: Wed Nov 9 11:41:37 2022 +0100 Merge branch 'cassandra-4.1' into trunk * cassandra-4.1: Restore streaming_keep_alive_period functionality on the netty control streaming channel CHANGES.txt| 1 + conf/cassandra.yaml| 14 ++-- .../cassandra/net/InboundConnectionInitiator.java | 7 +- .../apache/cassandra/streaming/StreamSession.java | 6 +- .../async/StreamingMultiplexedChannel.java | 74 +- .../streaming/messages/KeepAliveMessage.java | 30 - .../streaming/messages/KeepAliveMessageTest.java | 33 +++--- 7 files changed, 114 insertions(+), 51 deletions(-) diff --cc CHANGES.txt index d8e8cb2e8d,ffa03b7322..5683e3be5e --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,79 -1,5 +1,80 @@@ -4.1-beta2 +4.2 + * Add nodetool forcecompact to remove tombstoned or ttl'd data ignoring GC grace for given table and partition keys (CASSANDRA-17711) + * Offer IF (NOT) EXISTS in cqlsh completion for CREATE TYPE, DROP TYPE, CREATE ROLE and DROP ROLE (CASSANDRA-16640) + * Nodetool bootstrap resume will now return an error if the operation fails (CASSANDRA-16491) + * Disable resumable bootstrap by default (CASSANDRA-17679) + * Include Git SHA in --verbose flag for nodetool version (CASSANDRA-17753) + * Update Byteman to 4.0.20 and Jacoco to 0.8.8 (CASSANDRA-16413) + * Add memtable option among possible tab completions for a table (CASSANDRA-17982) + * Adds a trie-based memtable implementation (CASSANDRA-17240) + * Further improves precision of memtable heap tracking (CASSANDRA-17240) + * Fix formatting of metrics documentation (CASSANDRA-17961) + * Keep sstable level when streaming for decommission and move (CASSANDRA-17969) + * Add Unavailables metric for CASWrite in the docs (CASSANDRA-16357) + * Make Cassandra logs able to be viewed in the virtual table system_views.system_logs (CASSANDRA-17946) + * IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied (CASSANDRA-17908) + * Include estimated active compaction remaining write size when starting a new compaction (CASSANDRA-17931) + * Mixed mode support for internode authentication during TLS upgrades (CASSANDRA-17923) + * Revert Mockito downgrade from CASSANDRA-17750 (CASSANDRA-17496) + * Add --older-than and --older-than-timestamp options for nodetool clearsnapshots (CASSANDRA-16860) + * Fix "open RT bound as its last item" exception (CASSANDRA-17810) + * Fix leak of non-standard Java types in JMX MBeans `org.apache.cassandra.db:type=StorageService` + and `org.apache.cassandra.db:type=RepairService` as clients using JMX cannot handle them. More details in NEWS.txt (CASSANDRA-17668) + * Deprecate Throwables.propagate usage (CASSANDRA-14218) + * Allow disabling hotness persistence for high sstable counts (CASSANDRA-17868) + * Prevent NullPointerException when changing neverPurgeTombstones from true to false (CASSANDRA-17897) + * Add metrics around storage usage and compression (CASSANDRA-17898) + * Remove usage of deprecated javax certificate classes (CASSANDRA-17867) + * Make sure preview repairs don't optimise streams unless configured to (CASSANDRA-17865) + * Optionally avoid hint transfer during decommission (CASSANDRA-17808) + * Make disabling auto snapshot on selected tables possible (CASSANDRA-10383) + * Introduce compaction priorities to prevent upgrade compaction inability to finish (CASSANDRA-17851) + * Prevent a user from manually removing ephemeral snapshots (CASSANDRA-17757) + * Remove dependency on Maven Ant Tasks (CASSANDRA-17750) + * Update ASM(9.1 to 9.3), Mockito(1.10.10 to 1.12.13) and ByteBuddy(3.2.4 to 4.7.0) (CASSANDRA-17835) + * Add the ability for operators to loosen the definition of "empty" for edge cases (CASSANDRA-17842) + * Fix potential out of range exception on column index downsampling (CASSANDRA-17839) + * Introduce target directory to vtable output for sstable_tasks and for compactionstats (CASSANDRA-13010) + * Read/Write/Truncate throw RequestFailure in a race condition with callback timeouts, should return Timeout instead (CASSANDRA-17828) + * Add ability to log load profiles at fixed intervals (CASSANDRA-17821) + * Protect against Gossip backing up due to a quarantined endpoint without version information (CASSANDRA-17830) + * NPE in org.apache.cassandra.cql3.Attributes.getTimeToLive (CASSANDRA-17822) + * Add guardrail for column size (CASSANDRA-17151) + * When doing a host replacement, we need to check that the node is a live node before failing with "Cannot replace a live node..." (CASSANDRA-17805) + * Add support
[cassandra] branch trunk updated (af3eea7558 -> 0778ae362c)
This is an automated email from the ASF dual-hosted git repository.
mck pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from af3eea7558 Merge branch 'cassandra-4.1' into trunk
new c100d34a1a Restore streaming_keep_alive_period functionality on the
netty control streaming channel
new 0778ae362c Merge branch 'cassandra-4.1' into trunk
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt| 1 +
conf/cassandra.yaml| 14 ++--
.../cassandra/net/InboundConnectionInitiator.java | 7 +-
.../apache/cassandra/streaming/StreamSession.java | 6 +-
.../async/StreamingMultiplexedChannel.java | 74 +-
.../streaming/messages/KeepAliveMessage.java | 30 -
.../messages/KeepAliveMessageTest.java}| 16 +++--
7 files changed, 116 insertions(+), 32 deletions(-)
copy test/unit/org/apache/cassandra/{net/VerbTest.java =>
streaming/messages/KeepAliveMessageTest.java} (70%)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10619) disallow streaming operations while upgrading
[ https://issues.apache.org/jira/browse/CASSANDRA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-10619: --- Fix Version/s: 4.0 4.0-alpha1 > disallow streaming operations while upgrading > - > > Key: CASSANDRA-10619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10619 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Streaming and Messaging, Local/Startup and > Shutdown >Reporter: Jon Haddad >Priority: Normal > Fix For: 4.0-alpha1, 4.0 > > > Cassandra should prevent users from doing streaming operations in the middle > of a cluster upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
