[jira] [Commented] (CASSANDRA-18116) Denylist can load perpetually and too frequently if it fails persistently
[ https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655172#comment-17655172 ] Jordan West commented on CASSANDRA-18116: - Changed javadoc to "@return empty denylist if we do not or cannot find the data, preserving the old value, otherwise the new value". Second run of tests here: [j11|https://app.circleci.com/pipelines/github/jrwest/cassandra/129/workflows/d8db359f-3d98-4ba5-84ab-14083e387a6e] [j8|https://app.circleci.com/pipelines/github/jrwest/cassandra/129/workflows/94cf9c40-bd35-4983-a787-15b466fbd6df] > Denylist can load perpetually and too frequently if it fails persistently > -- > > Key: CASSANDRA-18116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18116 > Project: Cassandra > Issue Type: Bug > Components: Feature/Rate Limiting >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0.x, 4.1.x > > > When the denylist fails its initial load it can [return a value of > null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453] > for a key in the cache. The [BoundedLoadingCache > implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615] > that is used treats null as missing and will end up trying to load the key > on reads. Besides the performance impact this can also lead to significant > log spam leading to disk or CPU usage issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655160#comment-17655160
]
Paulo Motta commented on CASSANDRA-11537:
-
the patch is ready for a second round of review. Would you have cycles to take
a look [~brandon.williams] ?
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655159#comment-17655159
]
Paulo Motta commented on CASSANDRA-11537:
-
I tested the patch locally and it makes nodetool commands fail gracefully when
the node is not initialized:
BEFORE:
{noformat}
$ nodetool ring
error: null
-- StackTrace --
java.util.NoSuchElementException
at
com.google.common.collect.LinkedHashMultimap$1.next(LinkedHashMultimap.java:532)
at
com.google.common.collect.LinkedHashMultimap$1.next(LinkedHashMultimap.java:520)
at
com.google.common.collect.TransformedIterator.next(TransformedIterator.java:47)
at java.base/java.util.Collections.max(Unknown Source)
at org.apache.cassandra.tools.nodetool.Ring.execute(Ring.java:78)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.runInternal(NodeTool.java:372)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:357)
at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:260)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:83)
{noformat}
AFTER
{noformat}
nodetool: Node is not initialized yet.
See 'nodetool help' or 'nodetool help '.
{noformat}
I'd just slightly update the message to something like: {{Server is not
initialized yet, cannot run nodetool.}}
I submitted a CI run but failures look unrelated:
* https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2153/
One concern mentioned earlier was if commands like {{nodetool join}} where the
server does not join the ring will be affected by this, but it doesn't seem to
be the case as we have a test for that that passed:
*
[test_bootstrap_on_write_survey|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2153/testReport/dtest-novnode.bootstrap_test/TestBootstrap/test_bootstrap_on_write_survey/]
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-11537:
Status: Needs Committer (was: Patch Available)
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15458) CQL: Unable to escape single quote in a map attribute
[
https://issues.apache.org/jira/browse/CASSANDRA-15458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655151#comment-17655151
]
Paulo Motta commented on CASSANDRA-15458:
-
Submitted CI run for
[branch|https://github.com/yziadeh/cassandra/tree/CASSANDRA-18035] with tests:
* https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2159/
> CQL: Unable to escape single quote in a map attribute
> ---
>
> Key: CASSANDRA-15458
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15458
> Project: Cassandra
> Issue Type: Bug
> Components: CQL/Interpreter, CQL/Semantics
>Reporter: Abhijeet Singh
>Assignee: Yaman Ziadeh
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Attachments: cass-screen.png
>
>
> h3. Overview
> For {{text}} attributes, CQL allows escaping single quote [using additional
> single
> quote|http://mail-archives.apache.org/mod_mbox/cassandra-user/201108.mbox/%3c20110803152250.294...@gmx.net%3E].
> But applying the same syntax for a {{map}} attribute does not
> work. Inconsistent behavior was observed between {{text}} datatype and
> {{map}} datatype.
> h3. CQL semantic proposal
> Cassandra (CQL) should apply same escaping semantics on {{text}} and
> text-within-map {{map}} datatypes.
> h3. Reproducing the bug:
> CREATE query:
> {code:java}
> CREATE TABLE university.test (id int, data map, PRIMARY KEY
> (id));{code}
> INSERT query:
> {code:java}
> insert into university.test (id, data) values(1, {1:'I''m newb'});{code}
> On running the aforementioned INSERT query, Cassandra inserts and returns
> {{\{1: 'I''m newb'}}} while the expected result is {{\{1: 'I'm newb'}}}
> h3. Technical details
> OS: CentOS 7
> Kernel: Linux 3.10.0-1062.9.1.el7.x86_64
> Cassandra version: 3.11.5
> Screenshot: [Output after SELECT query|https://i.stack.imgur.com/PLAan.png]
>
> +Additional information for newcomers:+
> The issue seems to come from the ANTLR Lexer logic for {{STRING_LITERAL}}. A
> unit test should also be added in {{SelectTest}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18136) Upgrade maven-shade-plugin to fix shaded dtest JAR build
[
https://issues.apache.org/jira/browse/CASSANDRA-18136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abe Ratnofsky updated CASSANDRA-18136:
--
Authors: Abe Ratnofsky
Test and Documentation Plan: This passes test if shaded dtest JARs build
successfully and can be used by dependencies such as Harry.
Status: Patch Available (was: Open)
> Upgrade maven-shade-plugin to fix shaded dtest JAR build
>
>
> Key: CASSANDRA-18136
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18136
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Packaging
>Reporter: Abe Ratnofsky
>Priority: Normal
>
> Could not build shaded dtest JAR with ./build-shaded-dtest-jar.sh due to:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project
> cassandra-dtest-shaded: Error creating shaded jar: Problem shading JAR
> ~/Repos/apache/cassandra/target/cassandra-dtest-shaded-4.0.1-SNAPSHOT.jar
> entry net/openhft/chronicle/wire/YamlWire$TextValueIn.class:
> org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class
> net/openhft/chronicle/wire/YamlWire$TextValueIn.class: 65536 -> [Help 1]
> {code}
>
> Tried on both Java 8 and Java 11, included ant clean / realclean / unlinking
> the entire ~/.m2/repository.
>
> Fixed by upgrading maven-shade-plugin in relocate-dependencies.pom:
> {code:java}
> org.apache.maven.plugins
> maven-shade-plugin
> - 3.2.1
> + 3.4.1{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18136) Upgrade maven-shade-plugin to fix shaded dtest JAR build
[
https://issues.apache.org/jira/browse/CASSANDRA-18136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abe Ratnofsky updated CASSANDRA-18136:
--
Bug Category: Parent values: Packaging(13660)
Complexity: Low Hanging Fruit
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Upgrade maven-shade-plugin to fix shaded dtest JAR build
>
>
> Key: CASSANDRA-18136
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18136
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Packaging
>Reporter: Abe Ratnofsky
>Priority: Normal
>
> Could not build shaded dtest JAR with ./build-shaded-dtest-jar.sh due to:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project
> cassandra-dtest-shaded: Error creating shaded jar: Problem shading JAR
> ~/Repos/apache/cassandra/target/cassandra-dtest-shaded-4.0.1-SNAPSHOT.jar
> entry net/openhft/chronicle/wire/YamlWire$TextValueIn.class:
> org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class
> net/openhft/chronicle/wire/YamlWire$TextValueIn.class: 65536 -> [Help 1]
> {code}
>
> Tried on both Java 8 and Java 11, included ant clean / realclean / unlinking
> the entire ~/.m2/repository.
>
> Fixed by upgrading maven-shade-plugin in relocate-dependencies.pom:
> {code:java}
> org.apache.maven.plugins
> maven-shade-plugin
> - 3.2.1
> + 3.4.1{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18136) Upgrade maven-shade-plugin to fix shaded dtest JAR build
Abe Ratnofsky created CASSANDRA-18136:
-
Summary: Upgrade maven-shade-plugin to fix shaded dtest JAR build
Key: CASSANDRA-18136
URL: https://issues.apache.org/jira/browse/CASSANDRA-18136
Project: Cassandra
Issue Type: Bug
Components: Build, Packaging
Reporter: Abe Ratnofsky
Could not build shaded dtest JAR with ./build-shaded-dtest-jar.sh due to:
{code:java}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project
cassandra-dtest-shaded: Error creating shaded jar: Problem shading JAR
~/Repos/apache/cassandra/target/cassandra-dtest-shaded-4.0.1-SNAPSHOT.jar entry
net/openhft/chronicle/wire/YamlWire$TextValueIn.class:
org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class
net/openhft/chronicle/wire/YamlWire$TextValueIn.class: 65536 -> [Help 1] {code}
Tried on both Java 8 and Java 11, included ant clean / realclean / unlinking
the entire ~/.m2/repository.
Fixed by upgrading maven-shade-plugin in relocate-dependencies.pom:
{code:java}
org.apache.maven.plugins
maven-shade-plugin
- 3.2.1
+ 3.4.1{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18116) Denylist can load perpetually and too frequently if it fails persistently
[
https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655097#comment-17655097
]
Josh McKenzie commented on CASSANDRA-18116:
---
We originally intentionally returned null on the
{{PartitionDenylist.buildEmptyCache}} load() path on the Caffeine cache so as
to preserve the old value in the cache. Which, as I type that out, seems
fundamentally flawed to begin with; if you can't find an entry from CQL on the
table you probably shouldn't have the old value persist in the cache since that
makes removing entries... challenging.
Let's update the javadoc
[here|https://github.com/jrwest/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L395]
to reflect our return pattern (empty entry) on not found and the implications
to the cache.
Otherwise +1; a couple circle flakes on some dtests.
> Denylist can load perpetually and too frequently if it fails persistently
> --
>
> Key: CASSANDRA-18116
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18116
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Rate Limiting
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> When the denylist fails its initial load it can [return a value of
> null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453]
> for a key in the cache. The [BoundedLoadingCache
> implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615]
> that is used treats null as missing and will end up trying to load the key
> on reads. Besides the performance impact this can also lead to significant
> log spam leading to disk or CPU usage issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18116) Denylist can load perpetually and too frequently if it fails persistently
[ https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-18116: -- Status: Ready to Commit (was: Review In Progress) > Denylist can load perpetually and too frequently if it fails persistently > -- > > Key: CASSANDRA-18116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18116 > Project: Cassandra > Issue Type: Bug > Components: Feature/Rate Limiting >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0.x, 4.1.x > > > When the denylist fails its initial load it can [return a value of > null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453] > for a key in the cache. The [BoundedLoadingCache > implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615] > that is used treats null as missing and will end up trying to load the key > on reads. Besides the performance impact this can also lead to significant > log spam leading to disk or CPU usage issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18116) Denylist can load perpetually and too frequently if it fails persistently
[ https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-18116: -- Reviewers: Josh McKenzie, Josh McKenzie (was: Josh McKenzie) Josh McKenzie, Josh McKenzie (was: Josh McKenzie) Status: Review In Progress (was: Patch Available) > Denylist can load perpetually and too frequently if it fails persistently > -- > > Key: CASSANDRA-18116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18116 > Project: Cassandra > Issue Type: Bug > Components: Feature/Rate Limiting >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0.x, 4.1.x > > > When the denylist fails its initial load it can [return a value of > null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453] > for a key in the cache. The [BoundedLoadingCache > implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615] > that is used treats null as missing and will end up trying to load the key > on reads. Besides the performance impact this can also lead to significant > log spam leading to disk or CPU usage issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18116) Denylist can load perpetually and too frequently if it fails persistently
[ https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-18116: -- Reviewers: Josh McKenzie > Denylist can load perpetually and too frequently if it fails persistently > -- > > Key: CASSANDRA-18116 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18116 > Project: Cassandra > Issue Type: Bug > Components: Feature/Rate Limiting >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0.x, 4.1.x > > > When the denylist fails its initial load it can [return a value of > null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453] > for a key in the cache. The [BoundedLoadingCache > implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615] > that is used treats null as missing and will end up trying to load the key > on reads. Besides the performance impact this can also lead to significant > log spam leading to disk or CPU usage issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (60148606 -> 7c0d7fb5)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 60148606 generate docs for b072ce0a new 7c0d7fb5 generate docs for b072ce0a This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (60148606) \ N -- N -- N refs/heads/asf-staging (7c0d7fb5) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4970898 -> 4970898 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-15254: --- Assignee: Maxim Muzafarov (was: Benjamin Lerer) > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Maxim Muzafarov >Priority: Normal > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18132) Add support for Paxos repair to PaxosV1
[ https://issues.apache.org/jira/browse/CASSANDRA-18132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655055#comment-17655055 ] Ariel Weisberg commented on CASSANDRA-18132: We had some discussion about whether PaxosV2 should be a pre-requisite for moving to Accord. Paxos repair for PaxosV1 isn't valuable since it is already in PaxosV2 and V2 is significantly better. There are several opportunities to make upgrade to PaxosV2 easier so maybe that is a better investment. For now I am going to defer deciding and only add support for migration from PaxosV2 and when that is complete I will take a harder look at how to make switching to PaxosV2 easier so it is an acceptable pre-requisite. > Add support for Paxos repair to PaxosV1 > --- > > Key: CASSANDRA-18132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18132 > Project: Cassandra > Issue Type: Sub-task >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg >Priority: Normal > > PaxosV2 supports repair of Paxos state by maintaining a 2i that leverages > PaxosUncommittedTracker to track uncommitted transactions in the system paxos > table. This could be enabled for PaxosV1 to aid with migration. > Alternatively this could be a scan of the system paxos table and then repair > of uncommitted transactions that are found. > Need to find the right way from A to B here. [~benedict] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11537) Give clear error when certain nodetool commands are issued before server is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655020#comment-17655020
]
William Nguyen commented on CASSANDRA-11537:
I created a PR here: [https://github.com/apache/cassandra/pull/2060.] I took
Paulo's suggestion to throw an error at the end of{{{} NodeProbe.connect(){}}},
but doing so I needed to initially not start the test with {{requireNetwork()}}
because it sets the initialized flag for {{{}StorageServiceMBean{}}}. Though
for this to work, I needed to call
{{Class.forName("org.apache.cassandra.service.StorageProxy")}} in the setup to
the test.
The test itself runs nodetool ring without the initialization set.
I also needed to update a series of nodetool tests to include
{{requireNetwork(),}} now that {{NodeProbe}} checks if it is initialized.
> Give clear error when certain nodetool commands are issued before server is
> ready
> -
>
> Key: CASSANDRA-11537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Observability, Local/Startup and Shutdown
>Reporter: Edward Capriolo
>Assignee: William Nguyen
>Priority: Low
> Labels: lhf
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As an ops person upgrading and servicing Cassandra servers, I require a more
> clear message when I issue a nodetool command that the server is not ready
> for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool
> scrub/compact/updatess etc you get unfriendly assertion. An exception would
> be easier to understand. Also if a user has turned assertions off it is
> unclear what might happen.
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process.
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
> at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
> at
> org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
> at
> org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
> at
> org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1:
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18134) Improve handling of min/max clustering in sstable
[ https://issues.apache.org/jira/browse/CASSANDRA-18134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18134: -- Test and Documentation Plan: run regression + new tests run performance tests and compare Status: Patch Available (was: In Progress) https://github.com/apache/cassandra/pull/2065 > Improve handling of min/max clustering in sstable > - > > Key: CASSANDRA-18134 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18134 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.2 > > > (details will come later) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18134) Improve handling of min/max clustering in sstable
[ https://issues.apache.org/jira/browse/CASSANDRA-18134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18134: -- Change Category: Performance Complexity: Normal Fix Version/s: 4.2 Status: Open (was: Triage Needed) > Improve handling of min/max clustering in sstable > - > > Key: CASSANDRA-18134 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18134 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 4.2 > > > (details will come later) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18025) cassandra-stress: not all contact point are passed down to driver
[ https://issues.apache.org/jira/browse/CASSANDRA-18025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic reassigned CASSANDRA-18025: - Assignee: Stefan Miklosovic > cassandra-stress: not all contact point are passed down to driver > - > > Key: CASSANDRA-18025 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18025 > Project: Cassandra > Issue Type: Bug > Components: Tool/stress >Reporter: Israel Fruchter >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.2 > > Time Spent: 10m > Remaining Estimate: 0h > > Seem like c-s is randomly selecting a node from the nodes passed down to it > in the command line, and use that node as contact point to the driver. > > When using c-s together with other management operations (for example > expending/shrinking the cluster), we can get into situation some of the nodes > mentioned in the command line aren't reachable/available, and c-s instead of > applying the best practice of having multiple contact points, pass down only > one that can be unavailable and fail completely without trying any of the > other nodes mentioned in the command line > we just fixed that in our fork of cassandra-stress: > [https://github.com/scylladb/scylla-tools-java/pull/314] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17547) Documentation from Partition Denylist Lost in Document Migration + Minor Fixes
[ https://issues.apache.org/jira/browse/CASSANDRA-17547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17547: -- Reviewers: Josh McKenzie, Stefan Miklosovic (was: Josh McKenzie) > Documentation from Partition Denylist Lost in Document Migration + Minor Fixes > -- > > Key: CASSANDRA-17547 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17547 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Jordan West >Assignee: Sharan Foga >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > The documentation added in > https://issues.apache.org/jira/browse/CASSANDRA-12106 went missing when the > documents were migrated to the new format. We just need to bring the doc > back. Along with this fix there are a couple minor edits to make to the > document itself to correct the examples. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17547) Documentation from Partition Denylist Lost in Document Migration + Minor Fixes
[ https://issues.apache.org/jira/browse/CASSANDRA-17547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17547: -- Reviewers: Josh McKenzie, Stefan Miklosovic, Stefan Miklosovic (was: Josh McKenzie, Stefan Miklosovic) Josh McKenzie, Stefan Miklosovic, Stefan Miklosovic (was: Josh McKenzie, Stefan Miklosovic) Status: Review In Progress (was: Patch Available) > Documentation from Partition Denylist Lost in Document Migration + Minor Fixes > -- > > Key: CASSANDRA-17547 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17547 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Jordan West >Assignee: Sharan Foga >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > The documentation added in > https://issues.apache.org/jira/browse/CASSANDRA-12106 went missing when the > documents were migrated to the new format. We just need to bring the doc > back. Along with this fix there are a couple minor edits to make to the > document itself to correct the examples. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18126:
--
Reviewers: Aleksey Yeschenko, David Capwell, Stefan Miklosovic (was:
Aleksey Yeschenko, David Capwell)
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654976#comment-17654976
]
Stefan Miklosovic commented on CASSANDRA-18126:
---
Is anybody against merging this into 3.0 and up? [~dcapwell] [~aleksey] I see
the fix version is 4.x but I dont see any reason why it could not go into 3.0
and 3.11 as well.
I ll take care of merging, just please confirm you are ok with this in older
branches too.
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654970#comment-17654970 ] Benjamin Lerer commented on CASSANDRA-15254: [~mmuzaf] Happy new year to you too. I have to focus on other stuff before I can come back to this ticket and I would probably not be able to touch it before several months. If you want to have a try at it, feel free to assign the ticket to you :-) > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Benjamin Lerer >Priority: Normal > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
