[cassandra-website] branch asf-staging updated (d9b66a29 -> 21cab9fd)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d9b66a29 generate docs for 8612e581 new 21cab9fd generate docs for 8612e581 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d9b66a29) \ N -- N -- N refs/heads/asf-staging (21cab9fd) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (1ff53b41 -> d9b66a29)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1ff53b41 generate docs for 8612e581 new d9b66a29 generate docs for 8612e581 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1ff53b41) \ N -- N -- N refs/heads/asf-staging (d9b66a29) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18390) Run Sonar analyzer over the Cassandra project
[
https://issues.apache.org/jira/browse/CASSANDRA-18390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707439#comment-17707439
]
Maxim Muzafarov commented on CASSANDRA-18390:
-
Ok, I seem to have configured the SonarLint plugin as follows (we can probably
update the documentation pages once we decide to move on):
- installed the SonarLint plugin;
- logged in with my ASF credentials through GitHub to https://sonarcloud.io/ ;
- generated a new token for myself on My Account -> Security tag (any ASF
member could also provide this token for a member who doesn't have the ASF
membership);
- configured a new cloud connection (supported for IntelliJ IDEA, Eclipse only)
for the Sonarlint plugin using the given token Settings -> Tools -> SonarLint;
- bind the project to the connection: Settings -> Tools -> SonarLint -> Bind to
Sonarcloud , and use the "apache_cassandra" as projectKey pulled from the
Sonarcloud;
I think the main concern here is "where can I get a sonar auth token", so it
shouldn't be a problem for an ASF member. For the others, a user can ask
someone on the @dev slack channel for it, I guess, as according to this note it
is quite legal to share tokens:
{code}
If you want to enforce security by not providing credentials of a real
SonarCloud user to run your code scan or to invoke web services, you can
provide a User Token as a replacement of the user login. This will increase the
security of your installation by not letting your analysis user's password
going through your network.
{code}
> Run Sonar analyzer over the Cassandra project
> -
>
> Key: CASSANDRA-18390
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18390
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As we already have Cassandra's project configured for the sonarcloud.io
> INFRA-24196, I wonder if we will be able to release branches, trunk, and pull
> requests to get analyzed by the SonarAnalyzer tool.
> Sonar is a code quality and security tool that is free to open-source
> projects and recommended by the INFRA team:
> https://cwiki.apache.org/confluence/display/INFRA/SonarCloud+for+ASF+projects
> It can have the following benefits without introducing any drawbacks (except
> for a few lines of source code)
> - visualise the LFH problems to work on;
> - see the trends in the source code;
> - add an extra layer of static code analysis;
> Changes below I have tested it locally with my SonarQube deployed on
> http://localhost:9000 and run the `act` for the GA part of the PR. It seems
> to work and parse classes correctly, but there are a few steps that need to
> be done by Cassandra's Committer or PMC (I do not have sufficient privileges):
> - Get the {{sonar.projectKey}} from the INFRA team;
> - make sure that the {{SONARCLOUD_TOKEN}} is available for GA and enabled for
> the project;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18375) CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
[
https://issues.apache.org/jira/browse/CASSANDRA-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18375:
--
Fix Version/s: 5.0
(was: 5.x)
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/9b90c90de30ad1317e59bc38ed9372cbdd9abfec
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP
> but got ACCORD_SIMPLE_RSP
> -
>
> Key: CASSANDRA-18375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18375
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> java.lang.IllegalArgumentException: Expected reply message with verb
> ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:440)
> at
> org.apache.cassandra.service.accord.AccordMessageSink.reply(AccordMessageSink.java:125)
> at accord.local.Node.reply(Node.java:361)
> at
> accord.messages.AbstractEpochRequest.accept(AbstractEpochRequest.java:63)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:66)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:31)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:165)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:176)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.runInternal(AsyncOperation.java:247)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:268)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.callback(AsyncOperation.java:157)
> at
> accord.utils.async.AsyncCallbacks.lambda$null$0(AsyncCallbacks.java:31)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18375) CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
[
https://issues.apache.org/jira/browse/CASSANDRA-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18375:
--
Status: Ready to Commit (was: Review In Progress)
+1 from Caleb in GH
> CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP
> but got ACCORD_SIMPLE_RSP
> -
>
> Key: CASSANDRA-18375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18375
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> java.lang.IllegalArgumentException: Expected reply message with verb
> ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:440)
> at
> org.apache.cassandra.service.accord.AccordMessageSink.reply(AccordMessageSink.java:125)
> at accord.local.Node.reply(Node.java:361)
> at
> accord.messages.AbstractEpochRequest.accept(AbstractEpochRequest.java:63)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:66)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:31)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:165)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:176)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.runInternal(AsyncOperation.java:247)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:268)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.callback(AsyncOperation.java:157)
> at
> accord.utils.async.AsyncCallbacks.lambda$null$0(AsyncCallbacks.java:31)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated: CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cep-15-accord by this push:
new 9b90c90de3 CEP-15 (Accord) Expected reply message with verb
ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
9b90c90de3 is described below
commit 9b90c90de30ad1317e59bc38ed9372cbdd9abfec
Author: David Capwell
AuthorDate: Fri Mar 31 15:04:51 2023 -0700
CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP
but got ACCORD_SIMPLE_RSP
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18375
---
src/java/org/apache/cassandra/net/Messaging.java | 27 ++
.../org/apache/cassandra/net/MessagingService.java | 4 +-
src/java/org/apache/cassandra/net/Verb.java| 99 ++
.../service/accord/AccordMessageSink.java | 19 -
.../service/accord/async/AsyncOperation.java | 17 +++-
.../service/accord/AccordMessageSinkTest.java | 56
6 files changed, 180 insertions(+), 42 deletions(-)
diff --git a/src/java/org/apache/cassandra/net/Messaging.java
b/src/java/org/apache/cassandra/net/Messaging.java
new file mode 100644
index 00..cdc6f7f1ee
--- /dev/null
+++ b/src/java/org/apache/cassandra/net/Messaging.java
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.net;
+
+import org.apache.cassandra.locator.InetAddressAndPort;
+
+public interface Messaging
+{
+void send(Message message, InetAddressAndPort to);
+void sendWithCallback(Message message, InetAddressAndPort to,
RequestCallback cb);
+}
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java
b/src/java/org/apache/cassandra/net/MessagingService.java
index 268a3c3ee8..092e45cfd7 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -203,7 +203,7 @@ import static
org.apache.cassandra.utils.Throwables.maybeFail;
* implemented in {@link
org.apache.cassandra.db.virtual.InternodeInboundTable} and
* {@link org.apache.cassandra.db.virtual.InternodeOutboundTable} respectively.
*/
-public class MessagingService extends MessagingServiceMBeanImpl
+public class MessagingService extends MessagingServiceMBeanImpl implements
Messaging
{
private static final Logger logger =
LoggerFactory.getLogger(MessagingService.class);
@@ -352,6 +352,7 @@ public class MessagingService extends
MessagingServiceMBeanImpl
* @param cb callback interface which is used to pass the responses or
*suggest that a timeout occurred to the invoker of the
send().
*/
+@Override
public void sendWithCallback(Message message, InetAddressAndPort to,
RequestCallback cb)
{
sendWithCallback(message, to, cb, null);
@@ -390,6 +391,7 @@ public class MessagingService extends
MessagingServiceMBeanImpl
* @param message messages to be sent.
* @param to endpoint to which the message needs to be sent
*/
+@Override
public void send(Message message, InetAddressAndPort to)
{
send(message, to, null);
diff --git a/src/java/org/apache/cassandra/net/Verb.java
b/src/java/org/apache/cassandra/net/Verb.java
index cbde8e8eee..15584b7e8f 100644
--- a/src/java/org/apache/cassandra/net/Verb.java
+++ b/src/java/org/apache/cassandra/net/Verb.java
@@ -19,15 +19,21 @@ package org.apache.cassandra.net;
import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
import java.util.List;
import java.util.concurrent.TimeUnit;
import java.util.function.Predicate;
import java.util.function.Supplier;
import java.util.function.ToLongFunction;
+import java.util.stream.IntStream;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
+import org.agrona.collections.IntHashSet;
import org.apache.cassandra.batchlog.Batch;
import
[jira] [Updated] (CASSANDRA-18375) CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
[
https://issues.apache.org/jira/browse/CASSANDRA-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18375:
Reviewers: Caleb Rackliffe, Caleb Rackliffe
Caleb Rackliffe, Caleb Rackliffe (was: Caleb Rackliffe)
Status: Review In Progress (was: Patch Available)
> CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP
> but got ACCORD_SIMPLE_RSP
> -
>
> Key: CASSANDRA-18375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18375
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> java.lang.IllegalArgumentException: Expected reply message with verb
> ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:440)
> at
> org.apache.cassandra.service.accord.AccordMessageSink.reply(AccordMessageSink.java:125)
> at accord.local.Node.reply(Node.java:361)
> at
> accord.messages.AbstractEpochRequest.accept(AbstractEpochRequest.java:63)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:66)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:31)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:165)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:176)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.runInternal(AsyncOperation.java:247)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:268)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.callback(AsyncOperation.java:157)
> at
> accord.utils.async.AsyncCallbacks.lambda$null$0(AsyncCallbacks.java:31)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18377) CEP-15 (Accord) AsyncOperation can not fail as it has already reached FINISHED
[
https://issues.apache.org/jira/browse/CASSANDRA-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707425#comment-17707425
]
David Capwell commented on CASSANDRA-18377:
---
Caleb saw this in the simulator as well... running that in a loop while I get
lunch
> CEP-15 (Accord) AsyncOperation can not fail as it has already reached FINISHED
> --
>
> Key: CASSANDRA-18377
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18377
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> java.lang.IllegalArgumentException: Unexpected state FINISHED
> at accord.utils.Invariants.illegalArgument(Invariants.java:54)
> at accord.utils.Invariants.checkArgument(Invariants.java:202)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.fail(AsyncOperation.java:182)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:273)
> {code}
> And
> {code}
> java.lang.IllegalArgumentException: Unexpected state FINISHED
> at accord.utils.Invariants.illegalArgument(Invariants.java:54)
> at accord.utils.Invariants.checkArgument(Invariants.java:202)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.fail(AsyncOperation.java:182)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:273)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.callback(AsyncOperation.java:157)
> at
> accord.utils.async.AsyncCallbacks.lambda$null$0(AsyncCallbacks.java:31)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18375) CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
[
https://issues.apache.org/jira/browse/CASSANDRA-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18375:
--
Test and Documentation Plan: new tests
Status: Patch Available (was: Open)
> CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP
> but got ACCORD_SIMPLE_RSP
> -
>
> Key: CASSANDRA-18375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18375
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> java.lang.IllegalArgumentException: Expected reply message with verb
> ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:440)
> at
> org.apache.cassandra.service.accord.AccordMessageSink.reply(AccordMessageSink.java:125)
> at accord.local.Node.reply(Node.java:361)
> at
> accord.messages.AbstractEpochRequest.accept(AbstractEpochRequest.java:63)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:66)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:31)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:165)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:176)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.runInternal(AsyncOperation.java:247)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:268)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.callback(AsyncOperation.java:157)
> at
> accord.utils.async.AsyncCallbacks.lambda$null$0(AsyncCallbacks.java:31)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18375) CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
[
https://issues.apache.org/jira/browse/CASSANDRA-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell reassigned CASSANDRA-18375:
-
Assignee: David Capwell
> CEP-15 (Accord) Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP
> but got ACCORD_SIMPLE_RSP
> -
>
> Key: CASSANDRA-18375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18375
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> java.lang.IllegalArgumentException: Expected reply message with verb
> ACCORD_INFORM_OF_TXNID_RSP but got ACCORD_SIMPLE_RSP
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:440)
> at
> org.apache.cassandra.service.accord.AccordMessageSink.reply(AccordMessageSink.java:125)
> at accord.local.Node.reply(Node.java:361)
> at
> accord.messages.AbstractEpochRequest.accept(AbstractEpochRequest.java:63)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:66)
> at accord.messages.InformOfTxnId.accept(InformOfTxnId.java:31)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:165)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.finish(AsyncOperation.java:176)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.runInternal(AsyncOperation.java:247)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:268)
> at
> org.apache.cassandra.service.accord.async.AsyncOperation.callback(AsyncOperation.java:157)
> at
> accord.utils.async.AsyncCallbacks.lambda$null$0(AsyncCallbacks.java:31)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707335#comment-17707335 ] Stefan Miklosovic edited comment on CASSANDRA-18124 at 3/31/23 7:18 PM: j8 precommit looks good https://app.circleci.com/pipelines/github/instaclustr/cassandra/2043/workflows/058d0781-13f9-45f0-9343-b6b84d6f4485 j11 precommit too https://app.circleci.com/pipelines/github/instaclustr/cassandra/2043/workflows/dcd865fa-7332-47cc-ba60-cb2ee1f18024 I have also tested example and tests pass. [~rtib] is that still all good for you? I then have to look for another committer. was (Author: smiklosovic): j8 precommit looks good https://app.circleci.com/pipelines/github/instaclustr/cassandra/2043/workflows/058d0781-13f9-45f0-9343-b6b84d6f4485 > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18352) Add Option to Timebox write timestamps
[ https://issues.apache.org/jira/browse/CASSANDRA-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707398#comment-17707398 ] Jordan West commented on CASSANDRA-18352: - I will change to that naming > Add Option to Timebox write timestamps > -- > > Key: CASSANDRA-18352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18352 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > In several cases it is desirable to have client provided timestamps generated > at the application-level. This can be error prone, however. In particular, > applications can choose timestamps that may be nonsensical for a given > application. One dangerous manifestation of this is the "doomstone" (a > tombstone far in the future of any realistic write). This feature would allow > either operators or users to specify a minimum and maximum timebound of > "reasonable" timestamps. The default would be negative infinity, positive > infinity to maintain backwards compatibility. Writes that are USING TIMESTAMP > with a timestamp outside of the timebox will see an exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18352) Add Option to Timebox write timestamps
[ https://issues.apache.org/jira/browse/CASSANDRA-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707398#comment-17707398 ] Jordan West edited comment on CASSANDRA-18352 at 3/31/23 7:08 PM: -- I will change to that naming (and will share another test run) was (Author: jrwest): I will change to that naming > Add Option to Timebox write timestamps > -- > > Key: CASSANDRA-18352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18352 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > In several cases it is desirable to have client provided timestamps generated > at the application-level. This can be error prone, however. In particular, > applications can choose timestamps that may be nonsensical for a given > application. One dangerous manifestation of this is the "doomstone" (a > tombstone far in the future of any realistic write). This feature would allow > either operators or users to specify a minimum and maximum timebound of > "reasonable" timestamps. The default would be negative infinity, positive > infinity to maintain backwards compatibility. Writes that are USING TIMESTAMP > with a timestamp outside of the timebox will see an exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18352) Add Option to Timebox write timestamps
[
https://issues.apache.org/jira/browse/CASSANDRA-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707394#comment-17707394
]
Andres de la Peña commented on CASSANDRA-18352:
---
I'm not sure the names of the properties match the style of other
{{cassandra.yaml}} properties. Usually the names of threshold guardrails
include the "_threshold" suffix.
For the case of min/max thresholds, we have the precedent of [the guardrail for
min/max replication
factor|https://github.com/apache/cassandra/blob/9f078090e9e07d0917716e395e770b766a327fc7/conf/cassandra.yaml#L1871-L1880],
which looks like:
{code:java}
minimum_replication_factor_warn_threshold
minimum_replication_factor_fail_threshold
maximum_replication_factor_warn_threshold
maximum_replication_factor_fail_threshold
{code}
If we follow the same naming style for consistency, the new yaml properties
would look like:
{code:java}
minimum_timestamp_warn_threshold
minimum_timestamp_fail_threshold
maximum_timestamp_warn_threshold
maximum_timestamp_fail_threshold
{code}
Instead of the current:
{code:java}
timestamp_warn_upper_bound
timestamp_fail_upper_bound
timestamp_warn_lower_bound
timestamp_fail_lower_bound
{code}
I don't see that we have any other properties whose names use lower/upper bound.
> Add Option to Timebox write timestamps
> --
>
> Key: CASSANDRA-18352
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18352
> Project: Cassandra
> Issue Type: New Feature
> Components: CQL/Semantics
>Reporter: Jordan West
>Assignee: Jordan West
>Priority: Normal
>
> In several cases it is desirable to have client provided timestamps generated
> at the application-level. This can be error prone, however. In particular,
> applications can choose timestamps that may be nonsensical for a given
> application. One dangerous manifestation of this is the "doomstone" (a
> tombstone far in the future of any realistic write). This feature would allow
> either operators or users to specify a minimum and maximum timebound of
> "reasonable" timestamps. The default would be negative infinity, positive
> infinity to maintain backwards compatibility. Writes that are USING TIMESTAMP
> with a timestamp outside of the timebox will see an exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18352) Add Option to Timebox write timestamps
[ https://issues.apache.org/jira/browse/CASSANDRA-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707392#comment-17707392 ] Jordan West commented on CASSANDRA-18352: - Planning to add that before commit, yes. Had only rebased and kicked off a new test run when I had a moment. > Add Option to Timebox write timestamps > -- > > Key: CASSANDRA-18352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18352 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > In several cases it is desirable to have client provided timestamps generated > at the application-level. This can be error prone, however. In particular, > applications can choose timestamps that may be nonsensical for a given > application. One dangerous manifestation of this is the "doomstone" (a > tombstone far in the future of any realistic write). This feature would allow > either operators or users to specify a minimum and maximum timebound of > "reasonable" timestamps. The default would be negative infinity, positive > infinity to maintain backwards compatibility. Writes that are USING TIMESTAMP > with a timestamp outside of the timebox will see an exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18125) Improve memtable allocator accounting when updating AtomicBTreePartition
[
https://issues.apache.org/jira/browse/CASSANDRA-18125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707383#comment-17707383
]
Andres de la Peña commented on CASSANDRA-18125:
---
This seems to have made
{{o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
flaky, as reported in CASSANDRA-18360.
[This
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2758/workflows/f9c1b471-3804-4b9b-acf8-2a1201591088]
for the commit immediately before CASSANDRA-18125 succeeds.
[This other
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2757/workflows/ebbe5032-fc89-41c1-9603-f4336f20cdc3]
for the 4.1-trunk merge commit of CASSANDRA-18125 fails reproducing the
current issue.
[This
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2745/workflows/6eb7b890-40de-4ffe-b1f7-16b26ed19b42]
for the current 4.1 branch successes, suggesting that probably the failure
only affects trunk. I haven't tested 4.0 yet.
> Improve memtable allocator accounting when updating AtomicBTreePartition
>
>
> Key: CASSANDRA-18125
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18125
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Memtable
>Reporter: Nicolas Henneaux
>Assignee: Benedict Elliott Smith
>Priority: Normal
> Fix For: 4.0.9, 4.1.1, 5.0
>
>
> On two nodes (on a 5 nodes cluster) on the cluster I'm running, I got the
> following exception. It occurred at 3,5 minutes interval.
> {code}
> MemtableReclaimMemory:2625 org.apache.cassandra.service.CassandraDaemon
> uncaughtException - Exception in thread
> Thread[MemtableReclaimMemory:2625,5,main]java.lang.AssertionError: null
> at
> org.apache.cassandra.utils.memory.MemtablePool$SubPool.released(MemtablePool.java:193)
> at
> org.apache.cassandra.utils.memory.MemtableAllocator$SubAllocator.releaseAll(MemtableAllocator.java:151)
> at
> org.apache.cassandra.utils.memory.MemtableAllocator$SubAllocator.setDiscarded(MemtableAllocator.java:142)
> at
> org.apache.cassandra.utils.memory.MemtableAllocator.setDiscarded(MemtableAllocator.java:93)
> at
> org.apache.cassandra.utils.memory.SlabAllocator.setDiscarded(SlabAllocator.java:120)
> at org.apache.cassandra.db.Memtable.setDiscarded(Memtable.java:201)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush$1.runMayThrow(ColumnFamilyStore.java:1216)
> at
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {code}
> {code}
> $ nodetool info
> ID :
> Gossip active : true
> Native Transport active: true
> Load : 204.67 GiB
> Generation No : 1670343179
> Uptime (seconds) : 1110514
> Heap Memory (MB) : 7218.07 / 24576.00
> Off Heap Memory (MB) : 784.06
> Data Center: par
> Rack : e1
> Exceptions : 1
> Key Cache : entries 802712, size 100 MiB, capacity 100 MiB,
> 774541004 hits, 914207516 requests, 0.847 recent hit rate, 14400 save period
> in seconds
> Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0
> requests, NaN recent hit rate, 0 save period in seconds
> Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0
> requests, NaN recent hit rate, 7200 save period in seconds
> Percent Repaired : 2.3272298419424144E-5%
> Token : (invoke with -T/--tokens to see all 8 tokens)
> $ java -version
> openjdk version "11.0.16" 2022-07-19 LTS
> OpenJDK Runtime Environment (Red_Hat-11.0.16.0.8-1.el7_9) (build
> 11.0.16+8-LTS)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.16.0.8-1.el7_9) (build 11.0.16+8-LTS,
> mixed mode, sharing)
> $ nodetool version
> ReleaseVersion: 4.0.6
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18400) Nodetool info should report on the new networking cache
[
https://issues.apache.org/jira/browse/CASSANDRA-18400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18400:
---
Summary: Nodetool info should report on the new networking cache (was:
Nodetool info should report on new networking_cache)
> Nodetool info should report on the new networking cache
> ---
>
> Key: CASSANDRA-18400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18400
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> CASSANDRA-15229 separated the chunk and network cache, creating a new
> network_cache_size parameter.
> However, *nodetool info* does not report the in-use size of this cache or a
> hit ratio as it does for key, row, counter and chunk cache.
> {quote}Exceptions : 4
> Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
> 2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
> Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests,
> NaN recent hit rate, 0 save period in seconds
> Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
> NaN recent hit rate, 7200 save period in seconds
> Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
> 7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
> Percent Repaired : 0.0%
> {quote}
> However, when its full, it will be logged:
> {quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
> NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
> allocate chunk of 8.000MiB
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18400) Nodetool info should report on new networking_cache
[
https://issues.apache.org/jira/browse/CASSANDRA-18400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18400:
---
Change Category: Operability
Complexity: Low Hanging Fruit
Status: Open (was: Triage Needed)
> Nodetool info should report on new networking_cache
> ---
>
> Key: CASSANDRA-18400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18400
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> CASSANDRA-15229 separated the chunk and network cache, creating a new
> network_cache_size parameter.
> However, *nodetool info* does not report the in-use size of this cache or a
> hit ratio as it does for key, row, counter and chunk cache.
> {quote}Exceptions : 4
> Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
> 2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
> Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests,
> NaN recent hit rate, 0 save period in seconds
> Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
> NaN recent hit rate, 7200 save period in seconds
> Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
> 7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
> Percent Repaired : 0.0%
> {quote}
> However, when its full, it will be logged:
> {quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
> NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
> allocate chunk of 8.000MiB
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18360) Test Failure: o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707381#comment-17707381
]
Andres de la Peña commented on CASSANDRA-18360:
---
The test failure can be reproduced by running the test method separately,
without running the entire test class:
{code}
.circleci/generate.sh -p \
-e REPEATED_UTESTS_COUNT=500 \
-e
REPEATED_UTESTS=org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
{code}
[Bisection|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18360-trunk-bisect]
shows that the commit where the test started to fail for the first time is
[0bed1967fdd1caeb2bbc38645c2a0cb7e728725c|https://github.com/apache/cassandra/commit/0bed1967fdd1caeb2bbc38645c2a0cb7e728725c].
That commit belongs to CASSANDRA-18125, which seems the ticket where the test
failure was introduced.
[This
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2758/workflows/f9c1b471-3804-4b9b-acf8-2a1201591088]
for the commit immediately before CASSANDRA-18125 succeeds.
[This other
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2757/workflows/ebbe5032-fc89-41c1-9603-f4336f20cdc3]
for the 4.1-trunk merge commit of CASSANDRA-18125 fails reproducing the
current issue.
[This
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2745/workflows/6eb7b890-40de-4ffe-b1f7-16b26ed19b42]
for the current 4.1 branch successes, suggesting that the failure only affects
trunk. I haven't tested 4.0 yet.
> Test Failure:
> o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-18360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18360
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test
> {{org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
> is flaky at least on trunk. Flakiness seems lesser than 1%.
> While I haven't seen it on Jenkins yet, it can easily be reproduced on
> CircleCI with the multiplexer:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32235
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32234
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/739a95d3-8e42-4447-93dd-122fc16fdd7d/jobs/32233/tests
> Those runs show two types of errors:
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 1
> (content of type text), expected but got
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1506)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> {code}
> and:
> {code}
> org.apache.cassandra.serializers.MarshalException: Invalid UTF-8 bytes
> 00e0279515437f00
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:46)
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:29)
> at
> org.apache.cassandra.serializers.TypeSerializer.deserialize(TypeSerializer.java:37)
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1494)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_UTESTS_COUNT=500 \
> -e REPEATED_UTESTS=org.apache.cassandra.cql3.validation.operations.AlterTest
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18400) Nodetool info should report on new networking_cache
[
https://issues.apache.org/jira/browse/CASSANDRA-18400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18400:
---
Fix Version/s: 4.0.x
4.1.x
5.x
> Nodetool info should report on new networking_cache
> ---
>
> Key: CASSANDRA-18400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18400
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> CASSANDRA-15229 separated the chunk and network cache, creating a new
> network_cache_size parameter.
> However, *nodetool info* does not report the in-use size of this cache or a
> hit ratio as it does for key, row, counter and chunk cache.
> {quote}Exceptions : 4
> Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
> 2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
> Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests,
> NaN recent hit rate, 0 save period in seconds
> Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
> NaN recent hit rate, 7200 save period in seconds
> Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
> 7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
> Percent Repaired : 0.0%
> {quote}
> However, when its full, it will be logged:
> {quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
> NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
> allocate chunk of 8.000MiB
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18400) Nodetool info should report on new networking_cache
[
https://issues.apache.org/jira/browse/CASSANDRA-18400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18400:
---
Description:
CASSANDRA-15229 separated the chunk and network cache, creating a new
network_cache_size parameter.
However, *nodetool info* does not report the in-use size of this cache or a hit
ratio as it does for key, row, counter and chunk cache.
{quote}Exceptions : 4
Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests, NaN
recent hit rate, 0 save period in seconds
Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
NaN recent hit rate, 7200 save period in seconds
Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
Percent Repaired : 0.0%
{quote}
However, when its full, it will be logged:
{quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
allocate chunk of 8.000MiB
{quote}
was:
CASSANDRA-15229 separated the chunk and network cache, creating a new
network_cache_size parameter.
However, *nodetool info* does not report the in-use size of this cache or a hit
ratio as it does for key, row, counter and chunk cache.
{quote}Exceptions : 4
Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests, NaN
recent hit rate, 0 save period in seconds
Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
NaN recent hit rate, 7200 save period in seconds
Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
Percent Repaired : 0.0%
{quote}
However, when its full, it will be logged:
{quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
allocate chunk of 8.000MiB
{quote}
> Nodetool info should report on new networking_cache
> ---
>
> Key: CASSANDRA-18400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18400
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Brad Schoening
>Priority: Normal
>
> CASSANDRA-15229 separated the chunk and network cache, creating a new
> network_cache_size parameter.
> However, *nodetool info* does not report the in-use size of this cache or a
> hit ratio as it does for key, row, counter and chunk cache.
> {quote}Exceptions : 4
> Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
> 2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
> Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests,
> NaN recent hit rate, 0 save period in seconds
> Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
> NaN recent hit rate, 7200 save period in seconds
> Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
> 7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
> Percent Repaired : 0.0%
> {quote}
> However, when its full, it will be logged:
> {quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
> NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
> allocate chunk of 8.000MiB
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18400) Nodetool info should report on new networking_cache
[
https://issues.apache.org/jira/browse/CASSANDRA-18400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18400:
---
Component/s: Tool/nodetool
> Nodetool info should report on new networking_cache
> ---
>
> Key: CASSANDRA-18400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18400
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
>
> CASSANDRA-15229 separated the chunk and network cache, creating a new
> network_cache_size parameter.
> However, *nodetool info* does not report the in-use size of this cache or a
> hit ratio as it does for key, row, counter and chunk cache.
> {quote}Exceptions : 4
> Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
> 2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
> Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests,
> NaN recent hit rate, 0 save period in seconds
> Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
> NaN recent hit rate, 7200 save period in seconds
> Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
> 7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
> Percent Repaired : 0.0%
> {quote}
> However, when its full, it will be logged:
> {quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
> NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
> allocate chunk of 8.000MiB
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18400) Nodetool info should report on new networking_cache
Brad Schoening created CASSANDRA-18400:
--
Summary: Nodetool info should report on new networking_cache
Key: CASSANDRA-18400
URL: https://issues.apache.org/jira/browse/CASSANDRA-18400
Project: Cassandra
Issue Type: Improvement
Reporter: Brad Schoening
CASSANDRA-15229 separated the chunk and network cache, creating a new
network_cache_size parameter.
However, *nodetool info* does not report the in-use size of this cache or a hit
ratio as it does for key, row, counter and chunk cache.
{quote}Exceptions : 4
Key Cache : entries 2852, size 297.59 KiB, capacity 100 MiB, 2406561 hits,
2409424 requests, 0.999 recent hit rate, 14400 save period in seconds
Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests, NaN
recent hit rate, 0 save period in seconds
Counter Cache : entries 0, size 0 bytes, capacity 50 MiB, 0 hits, 0 requests,
NaN recent hit rate, 7200 save period in seconds
Chunk Cache : entries 1118, size 55.02 MiB, capacity 992 MiB, 4695794 misses,
7179421 requests, 0.346 recent hit rate, 24.145 microseconds miss latency
Percent Repaired : 0.0%
{quote}
However, when its full, it will be logged:
{quote}[INFO ] [epollEventLoopGroup-5-12] cluster_id=1 ip_address=127.1.1.1
NoSpamLogger.java:92 - Maximum memory usage reached (128.000MiB), cannot
allocate chunk of 8.000MiB
{quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707379#comment-17707379 ] Stefan Miklosovic edited comment on CASSANDRA-18332 at 3/31/23 6:00 PM: If I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? was (Author: smiklosovic): As I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18332) Backport CASSANDRA-17205 to 4.0 branch (strong ref leak)
[ https://issues.apache.org/jira/browse/CASSANDRA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707379#comment-17707379 ] Stefan Miklosovic commented on CASSANDRA-18332: --- As I understand it correctly, this has to go to 4.0 and then the changes in constructor on that parentRef order as well as logging from warn to error level should be applied to 4.1 and trunk, right? > Backport CASSANDRA-17205 to 4.0 branch (strong ref leak) > > > Key: CASSANDRA-18332 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18332 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.0.x > > > See description in CASSANDRA-17205; this should have been applied on 4.0 and > merged up but was overlooked. > > Also double-check that strong leaks are logged at ERROR instead of WARN on > both 4.0, 4.1, and trunk (see > [comment|https://issues.apache.org/jira/browse/CASSANDRA-18176?focusedCommentId=17687184=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687184]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18370) BulkLoader tool initializes schema unnecessarily via streaming - 4.0
[
https://issues.apache.org/jira/browse/CASSANDRA-18370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18370:
Fix Version/s: 4.0.9
(was: 4.0.x)
Since Version: 4.0
Source Control Link:
https://github.com/apache/cassandra/commit/853ae8c84049be875921a40c9d5924724cc72792
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed to 4.0:
https://github.com/apache/cassandra/commit/853ae8c84049be875921a40c9d5924724cc72792
(no-op merge to 4.1 and trunk)
> BulkLoader tool initializes schema unnecessarily via streaming - 4.0
>
>
> Key: CASSANDRA-18370
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18370
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Yijun Mao
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.9
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Similar to CASSANDRA-17740, {{BulkLoader}} initializes the schema/system
> keyspace, which caused the issue in bulk loader tool. See more details in
> CASSANDRA-17740. Please help fix the issue in 4.0 branch as well. Thanks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 03806f95e427384107b3e943a73f1b2273b7f749 Merge: 14936d0bd3 853ae8c840 Author: Caleb Rackliffe AuthorDate: Fri Mar 31 11:58:59 2023 -0500 Merge branch 'cassandra-4.0' into cassandra-4.1 * cassandra-4.0: Avoid loading the preferred IP for BulkLoader streaming - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (e07b8dfe8d -> 9f078090e9)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from e07b8dfe8d Merge branch 'cassandra-4.1' into trunk add 14936d0bd3 Merge branch 'cassandra-4.0' into cassandra-4.1 new 853ae8c840 Avoid loading the preferred IP for BulkLoader streaming new 03806f95e4 Merge branch 'cassandra-4.0' into cassandra-4.1 new 9f078090e9 Merge branch 'cassandra-4.1' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (14936d0bd3 -> 03806f95e4)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 14936d0bd3 Merge branch 'cassandra-4.0' into cassandra-4.1 new 853ae8c840 Avoid loading the preferred IP for BulkLoader streaming new 03806f95e4 Merge branch 'cassandra-4.0' into cassandra-4.1 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 9f078090e9e07d0917716e395e770b766a327fc7 Merge: e07b8dfe8d 03806f95e4 Author: Caleb Rackliffe AuthorDate: Fri Mar 31 11:59:19 2023 -0500 Merge branch 'cassandra-4.1' into trunk * cassandra-4.1: Avoid loading the preferred IP for BulkLoader streaming - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Avoid loading the preferred IP for BulkLoader streaming
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new 853ae8c840 Avoid loading the preferred IP for BulkLoader streaming
853ae8c840 is described below
commit 853ae8c84049be875921a40c9d5924724cc72792
Author: Caleb Rackliffe
AuthorDate: Thu Mar 30 13:07:16 2023 -0500
Avoid loading the preferred IP for BulkLoader streaming
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-18370
Co-authored-by: Caleb Rackliffe
Co-authored-by: Jon Meredith
---
CHANGES.txt| 1 +
src/java/org/apache/cassandra/db/SystemKeyspace.java | 3 +++
.../cassandra/streaming/StreamConnectionFactory.java | 14 ++
.../streaming/async/NettyStreamingMessageSender.java | 2 +-
.../apache/cassandra/tools/BulkLoadConnectionFactory.java | 6 ++
5 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 675d423080..924f7d82ff 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0.9
+ * Avoid loading the preferred IP for BulkLoader streaming (CASSANDRA-18370)
* Fix BufferPool incorrect memoryInUse when putUnusedPortion is used
(CASSANDRA-18311)
* Improve memtable allocator accounting when updating AtomicBTreePartition
(CASSANDRA-18125)
* Update zstd-jni to version 1.5.4-1 (CASSANDRA-18259)
diff --git a/src/java/org/apache/cassandra/db/SystemKeyspace.java
b/src/java/org/apache/cassandra/db/SystemKeyspace.java
index d63ee77736..e3f7fba010 100644
--- a/src/java/org/apache/cassandra/db/SystemKeyspace.java
+++ b/src/java/org/apache/cassandra/db/SystemKeyspace.java
@@ -41,6 +41,7 @@ import javax.management.openmbean.OpenDataException;
import javax.management.openmbean.TabularData;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
import com.google.common.collect.HashMultimap;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
@@ -934,6 +935,8 @@ public final class SystemKeyspace
*/
public static InetAddressAndPort getPreferredIP(InetAddressAndPort ep)
{
+Preconditions.checkState(DatabaseDescriptor.isDaemonInitialized()); //
Make sure being used as a daemon, not a tool
+
String req = "SELECT preferred_ip, preferred_port FROM system.%s WHERE
peer=? AND peer_port = ?";
UntypedResultSet result = executeInternal(String.format(req,
PEERS_V2), ep.address, ep.port);
if (!result.isEmpty() && result.one().has("preferred_ip"))
diff --git
a/src/java/org/apache/cassandra/streaming/StreamConnectionFactory.java
b/src/java/org/apache/cassandra/streaming/StreamConnectionFactory.java
index 95208e400b..97bb452272 100644
--- a/src/java/org/apache/cassandra/streaming/StreamConnectionFactory.java
+++ b/src/java/org/apache/cassandra/streaming/StreamConnectionFactory.java
@@ -26,4 +26,18 @@ import org.apache.cassandra.net.OutboundConnectionSettings;
public interface StreamConnectionFactory
{
Channel createConnection(OutboundConnectionSettings template, int
messagingVersion) throws IOException;
+
+/** Provide way to disable getPreferredIP() for tools without access to
the system keyspace
+ *
+ * CASSANDRA-17663 moves calls to SystemKeyspace.getPreferredIP() outside
of any threads
+ * that are regularly interrupted. However the streaming subsystem is
also used
+ * by the bulk loader tool, which does not have direct access to the local
tables
+ * and uses the client metadata/queries to retrieve it.
+ *
+ * @return true if SystemKeyspace.getPreferredIP() should be used when
connecting
+ */
+default boolean supportsPreferredIp()
+{
+return true;
+}
}
diff --git
a/src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java
b/src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java
index 2b9111627a..9f8f47608d 100644
---
a/src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java
+++
b/src/java/org/apache/cassandra/streaming/async/NettyStreamingMessageSender.java
@@ -238,7 +238,7 @@ public class NettyStreamingMessageSender implements
StreamingMessageSender
logger.debug("{} Sending {}", createLogTag(session, null),
message);
// Supply a preferred IP up-front to avoid trying to get it in the
executor thread, which can be interrupted.
-OutboundConnectionSettings templateWithConnectTo =
template.withConnectTo(template.connectTo());
+OutboundConnectionSettings templateWithConnectTo =
factory.supportsPreferredIp() ? template.withConnectTo(template.connectTo()) :
template;
fileTransferExecutor.submit(new
[jira] [Commented] (CASSANDRA-18364) CEP-15: (C*) Accord message processing should avoid being passed on to a Stage and run directly in the messageing handler
[
https://issues.apache.org/jira/browse/CASSANDRA-18364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707344#comment-17707344
]
David Capwell commented on CASSANDRA-18364:
---
Ran the cluster benchmarks with this patch and with the following Splunk filter
we have a clean result
{code}
exception!="*Inconsistent execution timestamp detected for txnId*"
exception!="*Unexpected state
FINISHED*AsyncOperation.fail(AsyncOperation.java:182)*"
exception!="*Expected reply message with verb ACCORD_INFORM_OF_TXNID_RSP but
got ACCORD_SIMPLE_RSP*"
exception!="java.lang.NullPointerException*accord.topology.TopologyManager.localForEpoch(TopologyManager.java:402)*"
exception!="java.lang.NullPointerException*TxnData.java:45*"
exception!="*org.apache.cassandra.service.ActiveRepairService*"
{code}
I pushed a fix for
"exception!="java.lang.NullPointerException*TxnData.java:45*"" as it was us not
handling the null case.
> CEP-15: (C*) Accord message processing should avoid being passed on to a
> Stage and run directly in the messageing handler
> -
>
> Key: CASSANDRA-18364
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18364
> Project: Cassandra
> Issue Type: Improvement
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Accord message processing should avoid being passed on to a Stage and run
> directly in the messageing handler. This logic should validate that all
> messages are non-blocking and async handle replies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18344) Store PreAccept, Accept, Commit, and Apply in a durable log before processing by CommandStores
[ https://issues.apache.org/jira/browse/CASSANDRA-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707343#comment-17707343 ] Aleksey Yeschenko commented on CASSANDRA-18344: --- [https://github.com/apache/cassandra/pull/2256] Pre-requisite patch-set for several upcoming Accord changes. Introduces an append-only journal for Accord messages. The journal supports invalidating individual entries by id and sets of owners, and looking up records by id, among other things. Several complete/near-complete parts of the generic journal implementation have been temporarily taken out until we need them (soon, once bootstrap/state reclamation are implemented). These include: * invalidation support (in memory and on-disk implementations), and * segment compaction (not needed without invalidations) PreAccept, Accept, Commit, and Apply are now written to a journal but aren't yet being read/used. Test coverage needs and comments around certain areas need work before commit. Coming soon. > Store PreAccept, Accept, Commit, and Apply in a durable log before processing > by CommandStores > -- > > Key: CASSANDRA-18344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18344 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Write PreAccept, Accept, Commit, and Apply messages durably to a journal. > CommandStore will then processes the messages in write order. > > This is a prerequisite JIRA for several incoming improvements, such as > reducing the data we store in system tables, making command stores and > progress log persistent, simplifying caching. > The journal supports invalidating individual entries by id and sets of > owners, and looking up records by id, both needed for near-future Accord work. > > Several complete/near-complete parts of the generic journal implementation > have been temporarily taken out until we need them (soon, once > bootstrap/state reclamation are implemented). > These include invalidation support (in memory and on-disk implementations), > and segment compaction (not needed without invalidations). > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18344) Store PreAccept, Accept, Commit, and Apply in a durable log before processing by CommandStores
[ https://issues.apache.org/jira/browse/CASSANDRA-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-18344: -- Change Category: Performance Complexity: Normal Status: Open (was: Triage Needed) > Store PreAccept, Accept, Commit, and Apply in a durable log before processing > by CommandStores > -- > > Key: CASSANDRA-18344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18344 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > > Write PreAccept, Accept, Commit, and Apply messages durably to a journal. > CommandStore will then processes the messages in write order. > > This is a prerequisite JIRA for several incoming improvements, such as > reducing the data we store in system tables, making command stores and > progress log persistent, simplifying caching. > The journal supports invalidating individual entries by id and sets of > owners, and looking up records by id, both needed for near-future Accord work. > > Several complete/near-complete parts of the generic journal implementation > have been temporarily taken out until we need them (soon, once > bootstrap/state reclamation are implemented). > These include invalidation support (in memory and on-disk implementations), > and segment compaction (not needed without invalidations). > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18344) Store PreAccept, Accept, Commit, and Apply in a durable log before processing by CommandStores
[ https://issues.apache.org/jira/browse/CASSANDRA-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-18344: -- Component/s: Accord > Store PreAccept, Accept, Commit, and Apply in a durable log before processing > by CommandStores > -- > > Key: CASSANDRA-18344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18344 > Project: Cassandra > Issue Type: New Feature > Components: Accord >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > > Write PreAccept, Accept, Commit, and Apply messages durably to a journal. > CommandStore will then processes the messages in write order. > > This is a prerequisite JIRA for several incoming improvements, such as > reducing the data we store in system tables, making command stores and > progress log persistent, simplifying caching. > The journal supports invalidating individual entries by id and sets of > owners, and looking up records by id, both needed for near-future Accord work. > > Several complete/near-complete parts of the generic journal implementation > have been temporarily taken out until we need them (soon, once > bootstrap/state reclamation are implemented). > These include invalidation support (in memory and on-disk implementations), > and segment compaction (not needed without invalidations). > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707335#comment-17707335 ] Stefan Miklosovic commented on CASSANDRA-18124: --- j8 precommit looks good https://app.circleci.com/pipelines/github/instaclustr/cassandra/2043/workflows/058d0781-13f9-45f0-9343-b6b84d6f4485 > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18344) Store PreAccept, Accept, Commit, and Apply in a durable log before processing by CommandStores
[ https://issues.apache.org/jira/browse/CASSANDRA-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-18344: -- Description: Write PreAccept, Accept, Commit, and Apply messages durably to a journal. CommandStore will then processes the messages in write order. This is a prerequisite JIRA for several incoming improvements, such as reducing the data we store in system tables, making command stores and progress log persistent, simplifying caching. The journal supports invalidating individual entries by id and sets of owners, and looking up records by id, both needed for near-future Accord work. Several complete/near-complete parts of the generic journal implementation have been temporarily taken out until we need them (soon, once bootstrap/state reclamation are implemented). These include invalidation support (in memory and on-disk implementations), and segment compaction (not needed without invalidations). was:TBD Summary: Store PreAccept, Accept, Commit, and Apply in a durable log before processing by CommandStores (was: TBD) > Store PreAccept, Accept, Commit, and Apply in a durable log before processing > by CommandStores > -- > > Key: CASSANDRA-18344 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18344 > Project: Cassandra > Issue Type: New Feature >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > > Write PreAccept, Accept, Commit, and Apply messages durably to a journal. > CommandStore will then processes the messages in write order. > > This is a prerequisite JIRA for several incoming improvements, such as > reducing the data we store in system tables, making command stores and > progress log persistent, simplifying caching. > The journal supports invalidating individual entries by id and sets of > owners, and looking up records by id, both needed for near-future Accord work. > > Several complete/near-complete parts of the generic journal implementation > have been temporarily taken out until we need them (soon, once > bootstrap/state reclamation are implemented). > These include invalidation support (in memory and on-disk implementations), > and segment compaction (not needed without invalidations). > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18399:
---
Reviewers: Michael Semb Wever
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit cassandra-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit cassandra-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-4.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-4.1 -> cassandra-4.1
> #
>
> git switch cassandra-4.1
> git reset --hard origin/cassandra-4.1
> git merge -s ours --log --no-edit cassandra-4.0
> git cherry-pick -n 3584d17b36 && git commit -a --amend --no-edit # 3584d17b36
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n e7b2ca37e6 &&
[jira] [Commented] (CASSANDRA-18352) Add Option to Timebox write timestamps
[ https://issues.apache.org/jira/browse/CASSANDRA-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707329#comment-17707329 ] Brandon Williams commented on CASSANDRA-18352: -- I don't see the commented out entries to the cassandra.yaml documenting this new guardrail and its use that Jeremiah mentioned, but this looks good and I trust you can handle that on commit. +1 > Add Option to Timebox write timestamps > -- > > Key: CASSANDRA-18352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18352 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > In several cases it is desirable to have client provided timestamps generated > at the application-level. This can be error prone, however. In particular, > applications can choose timestamps that may be nonsensical for a given > application. One dangerous manifestation of this is the "doomstone" (a > tombstone far in the future of any realistic write). This feature would allow > either operators or users to specify a minimum and maximum timebound of > "reasonable" timestamps. The default would be negative infinity, positive > infinity to maintain backwards compatibility. Writes that are USING TIMESTAMP > with a timestamp outside of the timebox will see an exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18352) Add Option to Timebox write timestamps
[ https://issues.apache.org/jira/browse/CASSANDRA-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707325#comment-17707325 ] Jordan West commented on CASSANDRA-18352: - The newest run is much more green: [j8|https://app.circleci.com/pipelines/github/jrwest/cassandra/158/workflows/c10f7c56-3821-4f27-98e1-0664b1e9c73f] [j11 |https://app.circleci.com/pipelines/github/jrwest/cassandra/158/workflows/cf28afe3-b9f7-4f63-8f07-3c35af8398e2] > Add Option to Timebox write timestamps > -- > > Key: CASSANDRA-18352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18352 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > > In several cases it is desirable to have client provided timestamps generated > at the application-level. This can be error prone, however. In particular, > applications can choose timestamps that may be nonsensical for a given > application. One dangerous manifestation of this is the "doomstone" (a > tombstone far in the future of any realistic write). This feature would allow > either operators or users to specify a minimum and maximum timebound of > "reasonable" timestamps. The default would be negative infinity, positive > infinity to maintain backwards compatibility. Writes that are USING TIMESTAMP > with a timestamp outside of the timebox will see an exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18393) Flaky test: org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1: clusterMinVersion=3.11]-compression.jdk1.8 on
[
https://issues.apache.org/jira/browse/CASSANDRA-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707318#comment-17707318
]
Brandon Williams edited comment on CASSANDRA-18393 at 3/31/23 3:50 PM:
---
I manually verified this test was flaky (did not repro in 500 runs), for some
reason I could not get it to multiplex in circle with [the usual
method|https://app.circleci.com/pipelines/github/driftx/cassandra/949/workflows/80597aa3-9d84-4689-837f-b2f86cbf670c/jobs/18482/tests]
or the [other
one|https://app.circleci.com/pipelines/github/driftx/cassandra/950/workflows/6a8b76ea-ead6-49c9-b629-2efc3a6bbe0f/jobs/18578]:
{noformat}
java.lang.Exception: No tests found matching Method
testConditionalUpdate(org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest)
from org.junit.internal.requests.ClassRequest@5851bd4f
{noformat}
Maybe I was doing something wrong though.
was (Author: brandon.williams):
I manually verified this test was flaky, for some reason I could not get it to
multiplex in circle with [the usual
method|https://app.circleci.com/pipelines/github/driftx/cassandra/949/workflows/80597aa3-9d84-4689-837f-b2f86cbf670c/jobs/18482/tests]
or the [other
one|https://app.circleci.com/pipelines/github/driftx/cassandra/950/workflows/6a8b76ea-ead6-49c9-b629-2efc3a6bbe0f/jobs/18578]:
{noformat}
java.lang.Exception: No tests found matching Method
testConditionalUpdate(org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest)
from org.junit.internal.requests.ClassRequest@5851bd4f
{noformat}
Maybe I was doing something wrong though.
> Flaky test:
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1:
> clusterMinVersion=3.11]-compression.jdk1.8 on trunk
>
>
> Key: CASSANDRA-18393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18393
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Priority: Normal
>
> Failed 1 times in the last 1 runs. Flakiness: 0%, Stability: 0%
> {code}
> Error Message
> 5.0.0-SNAPSHOT boolean:false
> Stacktrace
> junit.framework.AssertionFailedError: 5.0.0-SNAPSHOT boolean:false
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.lambda$data$1(InsertUpdateIfConditionTest.java:70)
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.beforeSetup(InsertUpdateIfConditionTest.java:95)
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.before(InsertUpdateIfConditionTest.java:89)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18393) Flaky test: org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1: clusterMinVersion=3.11]-compression.jdk1.8 on trun
[
https://issues.apache.org/jira/browse/CASSANDRA-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707318#comment-17707318
]
Brandon Williams commented on CASSANDRA-18393:
--
I manually verified this test was flaky, for some reason I could not get it to
multiplex in circle with [the usual
method|https://app.circleci.com/pipelines/github/driftx/cassandra/949/workflows/80597aa3-9d84-4689-837f-b2f86cbf670c/jobs/18482/tests]
or the [other
one|https://app.circleci.com/pipelines/github/driftx/cassandra/950/workflows/6a8b76ea-ead6-49c9-b629-2efc3a6bbe0f/jobs/18578]:
{noformat}
java.lang.Exception: No tests found matching Method
testConditionalUpdate(org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest)
from org.junit.internal.requests.ClassRequest@5851bd4f
{noformat}
Maybe I was doing something wrong though.
> Flaky test:
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1:
> clusterMinVersion=3.11]-compression.jdk1.8 on trunk
>
>
> Key: CASSANDRA-18393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18393
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Priority: Normal
>
> Failed 1 times in the last 1 runs. Flakiness: 0%, Stability: 0%
> {code}
> Error Message
> 5.0.0-SNAPSHOT boolean:false
> Stacktrace
> junit.framework.AssertionFailedError: 5.0.0-SNAPSHOT boolean:false
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.lambda$data$1(InsertUpdateIfConditionTest.java:70)
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.beforeSetup(InsertUpdateIfConditionTest.java:95)
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.before(InsertUpdateIfConditionTest.java:89)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18393) Flaky test: org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1: clusterMinVersion=3.11]-compression.jdk1.8 on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18393:
-
Summary: Flaky test:
org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1:
clusterMinVersion=3.11]-compression.jdk1.8 on trunk (was: Test failure:
org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1:
clusterMinVersion=3.11]-compression.jdk1.8 on trunk)
> Flaky test:
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate[1:
> clusterMinVersion=3.11]-compression.jdk1.8 on trunk
>
>
> Key: CASSANDRA-18393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18393
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Priority: Normal
>
> Failed 1 times in the last 1 runs. Flakiness: 0%, Stability: 0%
> {code}
> Error Message
> 5.0.0-SNAPSHOT boolean:false
> Stacktrace
> junit.framework.AssertionFailedError: 5.0.0-SNAPSHOT boolean:false
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.lambda$data$1(InsertUpdateIfConditionTest.java:70)
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.beforeSetup(InsertUpdateIfConditionTest.java:95)
> at
> org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.before(InsertUpdateIfConditionTest.java:89)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18391: - Fix Version/s: 3.0.29 3.11.15 4.0.9 5.0 (was: 5.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra-dtest/commit/c49bcf307686886fb34eea646eb3e7ff5855eb03 Resolution: Fixed Status: Resolved (was: Ready to Commit) bq. ported_to_in_jvm isn't used on upgrade dtests Indeed that's why I didn't run them. Thanks for the review, committed. > consistent timeout: > dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones > on trunk > -- > > Key: CASSANDRA-18391 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18391 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Josh McKenzie >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.29, 3.11.15, 4.0.9, 5.0 > > > Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0% > link: > https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/ > Error message: failed on setup with "Failed: Timeout >900.0s" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18153:
--
Fix Version/s: 3.0.29
3.11.15
4.0.9
5.0
4.1.2
Since Version: 3.0.25
Source Control Link:
https://github.com/apache/cassandra/commit/f96659c5306e62666e21c371c2ded646dd51672b
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.9, 5.0, 4.1.2
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18391: - Status: Ready to Commit (was: Review In Progress) > consistent timeout: > dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones > on trunk > -- > > Key: CASSANDRA-18391 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18391 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Josh McKenzie >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0% > link: > https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/ > Error message: failed on setup with "Failed: Timeout >900.0s" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Skip upgrades in the 'since' fixture faster
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git The following commit(s) were added to refs/heads/trunk by this push: new c49bcf30 Skip upgrades in the 'since' fixture faster c49bcf30 is described below commit c49bcf307686886fb34eea646eb3e7ff5855eb03 Author: Brandon Williams AuthorDate: Thu Mar 30 17:21:32 2023 -0500 Skip upgrades in the 'since' fixture faster Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-18391 --- conftest.py | 8 1 file changed, 8 insertions(+) diff --git a/conftest.py b/conftest.py index 5ba3de80..e07aeac6 100644 --- a/conftest.py +++ b/conftest.py @@ -439,6 +439,10 @@ def fixture_since(request, fixture_dtest_setup): # are excluded by the annotation if hasattr(request.cls, "UPGRADE_PATH"): upgrade_path = request.cls.UPGRADE_PATH +if hasattr(upgrade_path, 'upgrade_meta'): +skip_msg = _skip_msg(LooseVersion(upgrade_path.upgrade_meta.family), since, max_version) +if skip_msg: +pytest.skip(skip_msg) ccm_repo_cache_dir, _ = ccmlib.repository.setup(upgrade_path.starting_meta.version) starting_version = get_version_from_build(ccm_repo_cache_dir) skip_msg = _skip_msg(starting_version, since, max_version) @@ -486,6 +490,10 @@ def fixture_ported_to_in_jvm(request, fixture_dtest_setup): # are excluded by the annotation if hasattr(request.cls, "UPGRADE_PATH"): upgrade_path = request.cls.UPGRADE_PATH +if hasattr(upgrade_path, 'upgrade_meta'): +skip_msg = _skip_msg(LooseVersion(upgrade_path.upgrade_meta.family), since, max_version) +if skip_msg: +pytest.skip(skip_msg) ccm_repo_cache_dir, _ = ccmlib.repository.setup(upgrade_path.starting_meta.version) starting_version = get_version_from_build(ccm_repo_cache_dir) skip_msg = _skip_ported_msg(starting_version, ported_from_version) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18153:
--
Status: Ready to Commit (was: Review In Progress)
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 2h
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
jlewandowski pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 14936d0bd3716ed251e799a264f5ab16d51b893b
Merge: 780f8b94ff 4b9c18235a
Author: Jacek Lewandowski
AuthorDate: Fri Mar 31 17:30:20 2023 +0200
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
Save host id to system.local and flush immediately after startup
CHANGES.txt| 5 +-
.../org/apache/cassandra/db/SystemKeyspace.java| 23 ++-
.../apache/cassandra/db/commitlog/CommitLog.java | 47 --
.../cassandra/db/compaction/CompactionManager.java | 76 +++--
.../apache/cassandra/service/StorageService.java | 173 -
.../cassandra/tools/SSTableMetadataViewer.java | 31 ++--
.../cassandra/distributed/impl/Instance.java | 12 +-
.../cassandra/distributed/impl/InstanceConfig.java | 4 +-
.../distributed/test/IPMembershipTest.java | 4 +
.../distributed/test/SSTableIdGenerationTest.java | 24 +--
.../unit/org/apache/cassandra/db/KeyCacheTest.java | 2 -
.../cassandra/db/compaction/NeverPurgeTest.java| 8 +-
12 files changed, 302 insertions(+), 107 deletions(-)
diff --cc CHANGES.txt
index dec7f680f2,675d423080..c12983568e
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,21 -1,4 +1,24 @@@
-4.0.9
+4.1.2
+ * Return snapshots with dots in their name in nodetool listsnapshots
(CASSANDRA-18371)
+ * Fix NPE when loading snapshots and data directory is one directory from
root (CASSANDRA-18359)
+ * Do not submit hints when hinted_handoff_enabled=false (CASSANDRA-18304)
+ * Fix COPY ... TO STDOUT behavior in cqlsh (CASSANDRA-18353)
+ * Remove six and Py2SaferScanner merge cruft (CASSANDRA-18354)
-
++Merged from 4.0:
++Merged from 3.11:
++Merged from 3.0:
++ * Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)
+
+4.1.1
+ * Deprecate org.apache.cassandra.hadoop code (CASSANDRA-16984)
+ * Fix too early schema version change in sysem local table (CASSANDRA-18291)
+ * Fix copying of JAR of a trigger to temporary file (CASSANDRA-18264)
+ * Fix possible NoSuchFileException when removing a snapshot (CASSANDRA-18211)
+ * PaxosPrepare may add instances to the Electorate that are not in gossip
(CASSANDRA-18194)
+ * Fix PAXOS2_COMMIT_AND_PREPARE_RSP serialisation AssertionError
(CASSANDRA-18164)
+ * Streaming progress virtual table lock contention can trigger
TCP_USER_TIMEOUT and fail streaming (CASSANDRA-18110)
+ * Fix perpetual load of denylist on read in cases where denylist can never
be loaded (CASSANDRA-18116)
+Merged from 4.0:
* Fix BufferPool incorrect memoryInUse when putUnusedPortion is used
(CASSANDRA-18311)
* Improve memtable allocator accounting when updating AtomicBTreePartition
(CASSANDRA-18125)
* Update zstd-jni to version 1.5.4-1 (CASSANDRA-18259)
diff --cc src/java/org/apache/cassandra/db/SystemKeyspace.java
index 1523720d53,d63ee77736..fd2145b30c
--- a/src/java/org/apache/cassandra/db/SystemKeyspace.java
+++ b/src/java/org/apache/cassandra/db/SystemKeyspace.java
@@@ -559,7 -498,18 +561,13 @@@ public final class SystemKeyspac
DECOMMISSIONED
}
-public static void finishStartup()
-{
-Schema.instance.saveSystemKeyspace();
-}
-
public static void persistLocalMetadata()
+ {
+ persistLocalMetadata(UUID::randomUUID);
+ }
+
+ @VisibleForTesting
+ public static void persistLocalMetadata(Supplier nodeIdSupplier)
{
String req = "INSERT INTO system.%s (" +
"key," +
diff --cc src/java/org/apache/cassandra/db/commitlog/CommitLog.java
index a832b5ea42,49eb67b1df..6195b1b4ca
--- a/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
+++ b/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
@@@ -17,19 -17,23 +17,25 @@@
*/
package org.apache.cassandra.db.commitlog;
-
-import java.io.File;
-import java.io.FilenameFilter;
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.nio.file.FileStore;
- import java.util.*;
+ import java.util.ArrayList;
+ import java.util.Arrays;
+ import java.util.Collection;
+ import java.util.Collections;
+ import java.util.Iterator;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.TreeMap;
+ import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+import java.util.function.BiPredicate;
import java.util.function.Function;
import java.util.zip.CRC32;
import com.google.common.annotations.VisibleForTesting;
- import org.apache.cassandra.io.util.File;
+import com.google.common.base.Preconditions;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@@ -43,7 -47,7 +49,8 @@@ import org.apache.cassandra.io.compress
import
[cassandra] branch cassandra-4.1 updated (780f8b94ff -> 14936d0bd3)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 780f8b94ff Merge branch 'cassandra-4.0' into cassandra-4.1 add f96659c530 Save host id to system.local and flush immediately after startup add ee586b53c2 Merge branch 'cassandra-3.0' into cassandra-3.11 add 4b9c18235a Merge branch 'cassandra-3.11' into cassandra-4.0 new 14936d0bd3 Merge branch 'cassandra-4.0' into cassandra-4.1 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 5 +- .../org/apache/cassandra/db/SystemKeyspace.java| 23 ++- .../apache/cassandra/db/commitlog/CommitLog.java | 47 -- .../cassandra/db/compaction/CompactionManager.java | 76 +++-- .../apache/cassandra/service/StorageService.java | 173 - .../cassandra/tools/SSTableMetadataViewer.java | 31 ++-- .../cassandra/distributed/impl/Instance.java | 12 +- .../cassandra/distributed/impl/InstanceConfig.java | 4 +- .../distributed/test/IPMembershipTest.java | 4 + .../distributed/test/SSTableIdGenerationTest.java | 24 +-- .../unit/org/apache/cassandra/db/KeyCacheTest.java | 2 - .../cassandra/db/compaction/NeverPurgeTest.java| 8 +- 12 files changed, 302 insertions(+), 107 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (5f61645778 -> 4b9c18235a)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 5f61645778 Merge branch 'cassandra-3.11' into cassandra-4.0 add f96659c530 Save host id to system.local and flush immediately after startup add ee586b53c2 Merge branch 'cassandra-3.0' into cassandra-3.11 add 4b9c18235a Merge branch 'cassandra-3.11' into cassandra-4.0 No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/db/SystemKeyspace.java| 75 -- .../apache/cassandra/db/commitlog/CommitLog.java | 44 -- .../cassandra/db/compaction/CompactionManager.java | 83 +-- .../apache/cassandra/service/StorageService.java | 152 + .../cassandra/tools/SSTableMetadataViewer.java | 29 ++-- .../cassandra/distributed/impl/Instance.java | 11 +- .../cassandra/distributed/impl/InstanceConfig.java | 5 +- .../distributed/test/IPMembershipTest.java | 5 +- .../unit/org/apache/cassandra/db/KeyCacheTest.java | 8 +- .../cassandra/db/compaction/NeverPurgeTest.java| 8 +- 11 files changed, 336 insertions(+), 85 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (e98258a132 -> e07b8dfe8d)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from e98258a132 Upgrade checkstyle to 10.8.1 for j11 and 8.45.1 for j8 add f96659c530 Save host id to system.local and flush immediately after startup add ee586b53c2 Merge branch 'cassandra-3.0' into cassandra-3.11 add 4b9c18235a Merge branch 'cassandra-3.11' into cassandra-4.0 new f8dd1931ee Merge branch 'cassandra-4.0' into cassandra-4.1 new e07b8dfe8d Merge branch 'cassandra-4.1' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 5 +++ .../org/apache/cassandra/db/SystemKeyspace.java| 25 +++- .../apache/cassandra/db/commitlog/CommitLog.java | 47 -- .../cassandra/db/compaction/CompactionManager.java | 23 +++ .../apache/cassandra/service/StorageService.java | 13 +- .../cassandra/tools/SSTableMetadataViewer.java | 1 + .../cassandra/distributed/impl/Instance.java | 9 - .../cassandra/distributed/impl/InstanceConfig.java | 4 +- .../distributed/test/IPMembershipTest.java | 5 +++ .../distributed/test/SSTableIdGenerationTest.java | 24 +-- .../cassandra/db/compaction/NeverPurgeTest.java| 8 ++-- .../io/sstable/keycache/KeyCacheTest.java | 2 - 12 files changed, 130 insertions(+), 36 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (955cf156c8 -> ee586b53c2)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 955cf156c8 Merge branch 'cassandra-3.0' into cassandra-3.11 add f352f2b637 Notify the corresponding JIRA issue as soon as the PR is raised add 2f8d11335e Remove asf.yaml from non-trunk branches add f96659c530 Save host id to system.local and flush immediately after startup add ee586b53c2 Merge branch 'cassandra-3.0' into cassandra-3.11 No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/db/SystemKeyspace.java| 79 ++-- .../apache/cassandra/db/commitlog/CommitLog.java | 40 -- .../apache/cassandra/service/StorageService.java | 141 ++--- .../cassandra/tools/SSTableMetadataViewer.java | 28 ++-- .../cassandra/distributed/impl/Instance.java | 12 +- 6 files changed, 245 insertions(+), 56 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (2f8d11335e -> f96659c530)
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 2f8d11335e Remove asf.yaml from non-trunk branches add f96659c530 Save host id to system.local and flush immediately after startup No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/db/SystemKeyspace.java| 75 +-- .../apache/cassandra/db/commitlog/CommitLog.java | 60 + .../apache/cassandra/service/StorageService.java | 139 ++--- .../cassandra/tools/SSTableMetadataViewer.java | 8 +- .../cassandra/distributed/impl/Instance.java | 12 +- 6 files changed, 237 insertions(+), 58 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. jlewandowski pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit e07b8dfe8dc142356223e71e438c77ffe97140c1 Merge: e98258a132 f8dd1931ee Author: Jacek Lewandowski AuthorDate: Fri Mar 31 17:30:21 2023 +0200 Merge branch 'cassandra-4.1' into trunk * cassandra-4.1: Save host id to system.local and flush immediately after startup CHANGES.txt| 5 +++ .../org/apache/cassandra/db/SystemKeyspace.java| 25 +++- .../apache/cassandra/db/commitlog/CommitLog.java | 47 -- .../cassandra/db/compaction/CompactionManager.java | 23 +++ .../apache/cassandra/service/StorageService.java | 13 +- .../cassandra/tools/SSTableMetadataViewer.java | 1 + .../cassandra/distributed/impl/Instance.java | 9 - .../cassandra/distributed/impl/InstanceConfig.java | 4 +- .../distributed/test/IPMembershipTest.java | 5 +++ .../distributed/test/SSTableIdGenerationTest.java | 24 +-- .../cassandra/db/compaction/NeverPurgeTest.java| 8 ++-- .../io/sstable/keycache/KeyCacheTest.java | 2 - 12 files changed, 130 insertions(+), 36 deletions(-) diff --cc CHANGES.txt index e541b5c7b1,31840b79bc..374ecc709a --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,130 -1,3 +1,135 @@@ +5.0 + * Use jdk-dependent checkstyle version to check the source code (CASSANDRA-18262) + * Provide summary of failed SessionInfo's in StreamResultFuture (CASSANDRA-17199) + * CEP-20: Dynamic Data Masking (CASSANDRA-17940) + * Add system_views.snapshots virtual table (CASSANDRA-18102) + * Update OpenHFT dependencies (chronicle-queue, chronicle-core, chronicle-bytes, chronicle-wire, chronicle-threads) (CASSANDRA-18049) + * Remove org.apache.cassandra.hadoop code (CASSANDRA-18323) + * Remove deprecated CQL functions dateOf and unixTimestampOf (CASSANDRA-18328) + * Remove DateTieredCompactionStrategy (CASSANDRA-18043) + * Add system_views.max_sstable_size and system_views.max_sstable_duration tables (CASSANDRA-18333) + * Extend implicit allow-filtering for virtual tables to clustering columns (CASSANDRA-18331) + * Upgrade maven-shade-plugin to 3.4.1 to fix shaded dtest JAR build (CASSANDRA-18136) + * Upgrade to Opcodes.ASM9 (CASSANDRA-17971) + * Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them together with local read/write ratio to tablestats (CASSANDRA-18283) + * Add more logging around CompactionManager operations (CASSANDRA-18268) + * Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue (CASSANDRA-18212) + * CEP-17: SSTable API (CASSANDRA-17056) + * Gossip stateMapOrdering does not have correct ordering when both EndpointState are in the bootstrapping set (CASSANDRA-18292) + * Snapshot only sstables containing mismatching ranges on preview repair mismatch (CASSANDRA-17561) + * More accurate skipping of sstables in read path (CASSANDRA-18134) + * Prepare for JDK17 experimental support (CASSANDRA-18179, CASSANDRA-18258) + * Remove Scripted UDFs internals; hooks to be added later in CASSANDRA-17281 (CASSANDRA-18252) + * Update JNA to 5.13.0 (CASSANDRA-18050) + * Make virtual tables decide if they implicitly enable ALLOW FILTERING (CASSANDRA-18238) + * Add row, tombstone, and sstable count to nodetool profileload (CASSANDRA-18022) + * Coordinator level metrics for read response and mutation row and column counts (CASSANDRA-18155) + * Add CQL functions for dynamic data masking (CASSANDRA-17941) + * Print friendly error when nodetool attempts to connect to uninitialized server (CASSANDRA-11537) + * Use G1GC by default, and update default G1GC settings (CASSANDRA-18027) + * SimpleSeedProvider can resolve multiple IP addresses per DNS record (CASSANDRA-14361) + * Remove mocking in InternalNodeProbe spying on StorageServiceMBean (CASSANDRA-18152) + * Add compaction_properties column to system.compaction_history table and nodetool compactionhistory command (CASSANDRA-18061) + * Remove ProtocolVersion entirely from the CollectionSerializer ecosystem (CASSANDRA-18114) + * Fix serialization error in new getsstables --show-levels option (CASSANDRA-18140) + * Use checked casts when reading vints as ints (CASSANDRA-18099) + * Add Mutation Serialization Caching (CASSANDRA-17998) + * Only reload compaction strategies if disk boundaries change (CASSANDRA-17874) + * CEP-10: Simulator Java11 Support (CASSANDRA-17178) + * Set the major compaction type correctly for compactionstats (CASSANDRA-18055) + * Print exception message without stacktrace when nodetool commands fail on probe.getOwnershipWithPort() (CASSANDRA-18079) + * Add option to print level in nodetool getsstables output (CASSANDRA-18023) + * Implement a guardrail for not having zero default_time_to_live on tables with
[cassandra] 01/02: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
jlewandowski pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f8dd1931eeacb290af9e246376468f3704891cc4
Merge: 780f8b94ff 4b9c18235a
Author: Jacek Lewandowski
AuthorDate: Fri Mar 31 17:30:20 2023 +0200
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
Save host id to system.local and flush immediately after startup
CHANGES.txt| 1 +
.../org/apache/cassandra/db/SystemKeyspace.java| 23 ++-
.../apache/cassandra/db/commitlog/CommitLog.java | 47 --
.../cassandra/db/compaction/CompactionManager.java | 76 +++--
.../apache/cassandra/service/StorageService.java | 173 -
.../cassandra/tools/SSTableMetadataViewer.java | 31 ++--
.../cassandra/distributed/impl/Instance.java | 12 +-
.../cassandra/distributed/impl/InstanceConfig.java | 4 +-
.../distributed/test/IPMembershipTest.java | 4 +
.../distributed/test/SSTableIdGenerationTest.java | 24 +--
.../unit/org/apache/cassandra/db/KeyCacheTest.java | 2 -
.../cassandra/db/compaction/NeverPurgeTest.java| 8 +-
12 files changed, 299 insertions(+), 106 deletions(-)
diff --cc CHANGES.txt
index dec7f680f2,675d423080..31840b79bc
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -33,10 -23,13 +33,11 @@@ Merged from 4.0
* Fix sstable loading of keyspaces named snapshots or backups
(CASSANDRA-14013)
* Avoid ConcurrentModificationException in STCS/DTCS/TWCS.getSSTables
(CASSANDRA-17977)
* Restore internode custom tracing on 4.0's new messaging system
(CASSANDRA-17981)
- * Harden parsing of boolean values in CQL in PropertyDefinitions
(CASSANDRA-17878)
- * Fix error message about type hints (CASSANDRA-17915)
- * Fix possible race condition on repair snapshots (CASSANDRA-17955)
- * Fix ASM bytecode version inconsistency (CASSANDRA-17873)
Merged from 3.11:
- * Fix Splitter sometimes creating more splits than requested
(CASSANDRA-18013)
Merged from 3.0:
++ * Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)
+ * Fix the ordering of sstables when running sstableupgrade tool
(CASSANDRA-18143)
+ * Fix default file system error handler for disk_failure_policy die
(CASSANDRA-18294)
* Introduce check for names of test classes (CASSANDRA-17964)
* Suppress CVE-2022-41915 (CASSANDRA-18147)
* Suppress CVE-2021-1471, CVE-2021-3064, CVE-2021-4235 (CASSANDRA-18149)
diff --cc src/java/org/apache/cassandra/db/SystemKeyspace.java
index 1523720d53,d63ee77736..fd2145b30c
--- a/src/java/org/apache/cassandra/db/SystemKeyspace.java
+++ b/src/java/org/apache/cassandra/db/SystemKeyspace.java
@@@ -559,7 -498,18 +561,13 @@@ public final class SystemKeyspac
DECOMMISSIONED
}
-public static void finishStartup()
-{
-Schema.instance.saveSystemKeyspace();
-}
-
public static void persistLocalMetadata()
+ {
+ persistLocalMetadata(UUID::randomUUID);
+ }
+
+ @VisibleForTesting
+ public static void persistLocalMetadata(Supplier nodeIdSupplier)
{
String req = "INSERT INTO system.%s (" +
"key," +
diff --cc src/java/org/apache/cassandra/db/commitlog/CommitLog.java
index a832b5ea42,49eb67b1df..6195b1b4ca
--- a/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
+++ b/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
@@@ -17,19 -17,23 +17,25 @@@
*/
package org.apache.cassandra.db.commitlog;
-
-import java.io.File;
-import java.io.FilenameFilter;
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.nio.file.FileStore;
- import java.util.*;
+ import java.util.ArrayList;
+ import java.util.Arrays;
+ import java.util.Collection;
+ import java.util.Collections;
+ import java.util.Iterator;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.TreeMap;
+ import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+import java.util.function.BiPredicate;
import java.util.function.Function;
import java.util.zip.CRC32;
import com.google.common.annotations.VisibleForTesting;
- import org.apache.cassandra.io.util.File;
+import com.google.common.base.Preconditions;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@@ -43,7 -47,7 +49,8 @@@ import org.apache.cassandra.io.compress
import org.apache.cassandra.io.util.BufferedDataOutputStreamPlus;
import org.apache.cassandra.io.util.DataOutputBuffer;
import org.apache.cassandra.io.util.DataOutputBufferFixed;
-import org.apache.cassandra.io.util.FileUtils;
++import org.apache.cassandra.io.util.File;
+import org.apache.cassandra.io.util.PathUtils;
import org.apache.cassandra.metrics.CommitLogMetrics;
import org.apache.cassandra.net.MessagingService;
import org.apache.cassandra.schema.CompressionParams;
[jira] [Updated] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18399:
--
Description:
This is just a simple additional script which committers can use to help them
merge commits, especially if the change applies to multiple Cassandra versions.
For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates the
following commands, which then can be run manually:
{noformat}
git fetch origin
git fetch jacek-lewandowski
# jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
#
git switch cassandra-3.0
git reset --hard origin/cassandra-3.0
git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and flush
immediately after startup
git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
fixes
git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
DO NOT MERGE - CircleCI config
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
files
# jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
#
git switch cassandra-3.11
git reset --hard origin/cassandra-3.11
git merge -s ours --log --no-edit cassandra-3.0
git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
Save host id to system.local and flush immediately after startup
git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
fixes
git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
DO NOT MERGE - CircleCI config
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-3.11..HEAD # print a list of all changes
files
# jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
#
git switch cassandra-4.0
git reset --hard origin/cassandra-4.0
git merge -s ours --log --no-edit cassandra-3.11
git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
Save host id to system.local and flush immediately after startup
git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
DO NOT MERGE - CircleCI config
git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
fixes
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-4.0..HEAD # print a list of all changes
files
# jacek-lewandowski/CASSANDRA-18153-4.1 -> cassandra-4.1
#
git switch cassandra-4.1
git reset --hard origin/cassandra-4.1
git merge -s ours --log --no-edit cassandra-4.0
git cherry-pick -n 3584d17b36 && git commit -a --amend --no-edit # 3584d17b36
Save host id to system.local and flush immediately after startup
git cherry-pick -n e7b2ca37e6 && git commit -a --amend --no-edit # e7b2ca37e6
DO NOT MERGE - CircleCI config
git cherry-pick -n 85f3049e90 && git commit -a --amend --no-edit # 85f3049e90
fixes
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-4.1..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-4.1..HEAD
[jira] [Updated] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18399:
--
Test and Documentation Plan: user tests
Status: Patch Available (was: In Progress)
https://github.com/apache/cassandra-builds/pull/89
> Add simple helper script for commiting a change to multiple branches
>
>
> Key: CASSANDRA-18399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18399
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Low
>
> This is just a simple additional script which committers can use to help them
> merge commits, especially if the change applies to multiple Cassandra
> versions.
> For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates
> the following commands, which then can be run manually:
> {noformat}
> git fetch origin
> git fetch jacek-lewandowski
> # jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
> #
>
> git switch cassandra-3.0
> git reset --hard origin/cassandra-3.0
> git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and
> flush immediately after startup
> git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
> fixes
> git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
> #
>
> git switch cassandra-3.11
> git reset --hard origin/cassandra-3.11
> git merge -s ours --log --no-edit CASSANDRA-18153-3.0
> git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
> fixes
> git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
> DO NOT MERGE - CircleCI config
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index)
> && git commit -a --amend --no-edit # Remove all changes in .circleci
> directory if you need to
> git diff --name-only origin/cassandra-3.11..HEAD # print a list of all
> changes files
> # jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
> #
>
> git switch cassandra-4.0
> git reset --hard origin/cassandra-4.0
> git merge -s ours --log --no-edit CASSANDRA-18153-3.11
> git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
> Save host id to system.local and flush immediately after startup
> git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
> DO NOT MERGE - CircleCI config
> git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
> fixes
> grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\
> * Save host id to system.local and flush immediately after startup
> (CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
> git diff CHANGES.txt
> git add CHANGES.txt
> git commit --amend --no-edit
> (git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
> git commit -a --amend --no-edit # Remove all changes in .circleci directory
> if you need to
> git diff --name-only origin/cassandra-4.0..HEAD # print a list of all changes
> files
> # jacek-lewandowski/CASSANDRA-18153-4.1 -> cassandra-4.1
> #
>
> git switch cassandra-4.1
> git reset --hard origin/cassandra-4.1
> git merge -s ours --log --no-edit CASSANDRA-18153-4.0
> git cherry-pick -n 3584d17b36 &&
[jira] [Updated] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[
https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18399:
--
Description:
This is just a simple additional script which committers can use to help them
merge commits, especially if the change applies to multiple Cassandra versions.
For example, for CASSANDRA-18153, which applies to 3.0..trunk, it generates the
following commands, which then can be run manually:
{noformat}
git fetch origin
git fetch jacek-lewandowski
# jacek-lewandowski/CASSANDRA-18153-3.0 -> cassandra-3.0
#
git switch cassandra-3.0
git reset --hard origin/cassandra-3.0
git cherry-pick e7e9b42559 # e7e9b42559 Save host id to system.local and flush
immediately after startup
git cherry-pick -n 99e96a4f95 && git commit -a --amend --no-edit # 99e96a4f95
fixes
git cherry-pick -n c63e3f29f1 && git commit -a --amend --no-edit # c63e3f29f1
DO NOT MERGE - CircleCI config
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^[0-9]+\.[0-9]+/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-3.0..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-3.0..HEAD # print a list of all changes
files
# jacek-lewandowski/CASSANDRA-18153-3.11 -> cassandra-3.11
#
git switch cassandra-3.11
git reset --hard origin/cassandra-3.11
git merge -s ours --log --no-edit CASSANDRA-18153-3.0
git cherry-pick -n 79e7b90c8f && git commit -a --amend --no-edit # 79e7b90c8f
Save host id to system.local and flush immediately after startup
git cherry-pick -n bdca4c384b && git commit -a --amend --no-edit # bdca4c384b
fixes
git cherry-pick -n 45078e6793 && git commit -a --amend --no-edit # 45078e6793
DO NOT MERGE - CircleCI config
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-3.11..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-3.11..HEAD # print a list of all changes
files
# jacek-lewandowski/CASSANDRA-18153-4.0 -> cassandra-4.0
#
git switch cassandra-4.0
git reset --hard origin/cassandra-4.0
git merge -s ours --log --no-edit CASSANDRA-18153-3.11
git cherry-pick -n 2227c5c7af && git commit -a --amend --no-edit # 2227c5c7af
Save host id to system.local and flush immediately after startup
git cherry-pick -n a71d4e3408 && git commit -a --amend --no-edit # a71d4e3408
DO NOT MERGE - CircleCI config
git cherry-pick -n 6dc53f4e97 && git commit -a --amend --no-edit # 6dc53f4e97
fixes
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-4.0..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only origin/cassandra-4.0..HEAD # print a list of all changes
files
# jacek-lewandowski/CASSANDRA-18153-4.1 -> cassandra-4.1
#
git switch cassandra-4.1
git reset --hard origin/cassandra-4.1
git merge -s ours --log --no-edit CASSANDRA-18153-4.0
git cherry-pick -n 3584d17b36 && git commit -a --amend --no-edit # 3584d17b36
Save host id to system.local and flush immediately after startup
git cherry-pick -n e7b2ca37e6 && git commit -a --amend --no-edit # e7b2ca37e6
DO NOT MERGE - CircleCI config
git cherry-pick -n 85f3049e90 && git commit -a --amend --no-edit # 85f3049e90
fixes
grep 'CASSANDRA-18153' CHANGES.txt || sed -E -i '/^Merged from 3.0/{s/.*/&\n\ *
Save host id to system.local and flush immediately after startup
(CASSANDRA-18153)/;:a;n;ba}' CHANGES.txt
git diff CHANGES.txt
git add CHANGES.txt
git commit --amend --no-edit
(git diff origin/cassandra-4.1..HEAD -- .circleci/ | git apply -R --index) &&
git commit -a --amend --no-edit # Remove all changes in .circleci directory if
you need to
git diff --name-only
[jira] [Assigned] (CASSANDRA-18360) Test Failure: o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña reassigned CASSANDRA-18360:
-
Assignee: Andres de la Peña
> Test Failure:
> o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-18360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18360
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test
> {{org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
> is flaky at least on trunk. Flakiness seems lesser than 1%.
> While I haven't seen it on Jenkins yet, it can easily be reproduced on
> CircleCI with the multiplexer:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32235
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32234
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/739a95d3-8e42-4447-93dd-122fc16fdd7d/jobs/32233/tests
> Those runs show two types of errors:
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 1
> (content of type text), expected but got
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1506)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> {code}
> and:
> {code}
> org.apache.cassandra.serializers.MarshalException: Invalid UTF-8 bytes
> 00e0279515437f00
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:46)
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:29)
> at
> org.apache.cassandra.serializers.TypeSerializer.deserialize(TypeSerializer.java:37)
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1494)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_UTESTS_COUNT=500 \
> -e REPEATED_UTESTS=org.apache.cassandra.cql3.validation.operations.AlterTest
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707294#comment-17707294
]
Andres de la Peña commented on CASSANDRA-18391:
---
Looks great. It seems the last CI run doesn't include upgrade dtests, but I
guess we can do with the previous run, since {{ported_to_in_jvm}} isn't used on
upgrade dtests.
> consistent timeout:
> dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones
> on trunk
> --
>
> Key: CASSANDRA-18391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18391
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
>
> Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0%
> link:
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/
> Error message: failed on setup with "Failed: Timeout >900.0s"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
[ https://issues.apache.org/jira/browse/CASSANDRA-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18399: -- Change Category: Code Clarity Complexity: Low Hanging Fruit Priority: Low (was: Normal) Status: Open (was: Triage Needed) > Add simple helper script for commiting a change to multiple branches > > > Key: CASSANDRA-18399 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18399 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Low > > This is just a simple additional script which committers can use to help them > merge commits, especially if the change applies to multiple Cassandra > versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18399) Add simple helper script for commiting a change to multiple branches
Jacek Lewandowski created CASSANDRA-18399: - Summary: Add simple helper script for commiting a change to multiple branches Key: CASSANDRA-18399 URL: https://issues.apache.org/jira/browse/CASSANDRA-18399 Project: Cassandra Issue Type: Task Components: Build Reporter: Jacek Lewandowski Assignee: Jacek Lewandowski This is just a simple additional script which committers can use to help them merge commits, especially if the change applies to multiple Cassandra versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18398) CEP-25: Trie-indexed SSTable format
[ https://issues.apache.org/jira/browse/CASSANDRA-18398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-18398: Authors: Branimir Lambov, Jacek Lewandowski (was: Branimir Lambov) Component/s: Local/SSTable > CEP-25: Trie-indexed SSTable format > --- > > Key: CASSANDRA-18398 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18398 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Branimir Lambov >Assignee: Branimir Lambov >Priority: Normal > > Implementation of Big Trie-Indexed (BTI) SSTable format, per > [CEP-25|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-25%3A+Trie-indexed+SSTable+format]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18398) CEP-25: Trie-indexed SSTable format
Branimir Lambov created CASSANDRA-18398: --- Summary: CEP-25: Trie-indexed SSTable format Key: CASSANDRA-18398 URL: https://issues.apache.org/jira/browse/CASSANDRA-18398 Project: Cassandra Issue Type: Improvement Reporter: Branimir Lambov Assignee: Branimir Lambov Implementation of Big Trie-Indexed (BTI) SSTable format, per [CEP-25|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-25%3A+Trie-indexed+SSTable+format]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18360) Test Failure: o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18360:
--
Summary: Test Failure:
o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
(was: Test Failure:
a.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName)
> Test Failure:
> o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-18360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18360
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test
> {{org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
> is flaky at least on trunk. Flakiness seems lesser than 1%.
> While I haven't seen it on Jenkins yet, it can easily be reproduced on
> CircleCI with the multiplexer:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32235
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32234
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/739a95d3-8e42-4447-93dd-122fc16fdd7d/jobs/32233/tests
> Those runs show two types of errors:
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 1
> (content of type text), expected but got
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1506)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> {code}
> and:
> {code}
> org.apache.cassandra.serializers.MarshalException: Invalid UTF-8 bytes
> 00e0279515437f00
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:46)
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:29)
> at
> org.apache.cassandra.serializers.TypeSerializer.deserialize(TypeSerializer.java:37)
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1494)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_UTESTS_COUNT=500 \
> -e REPEATED_UTESTS=org.apache.cassandra.cql3.validation.operations.AlterTest
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18397) CEP-26: Unified Compaction Strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov reassigned CASSANDRA-18397: --- Authors: Alex Sorokoumov, Branimir Lambov, Dimitar Dimitrov, Stefania Alborghetti Source Control Link: https://github.com/blambov/cassandra/CASSANDRA-18397 Assignee: Branimir Lambov > CEP-26: Unified Compaction Strategy > --- > > Key: CASSANDRA-18397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18397 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Branimir Lambov >Assignee: Branimir Lambov >Priority: Normal > > Implementation of Unified Compaction Strategy per > [CEP-26|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy]. > Further documentation of the most current state of the solution can be found > in [the included markdown > documentation|https://github.com/blambov/cassandra/blob/CASSANDRA-18397/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18397) CEP-26: Unified Compaction Strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-18397: Description: Implementation of Unified Compaction Strategy per [CEP-26|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy]. Further documentation of the most current state of the solution can be found in [the included markdown documentation|https://github.com/blambov/cassandra/blob/CASSANDRA-18397/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md]. was: Implementation of Unified Compaction Strategy per [CEP-26|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy]. Documentation of the approach can also be found in [the included markdown documentation|https://github.com/blambov/cassandra/blob/CASSANDRA-18397/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md]. > CEP-26: Unified Compaction Strategy > --- > > Key: CASSANDRA-18397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18397 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Branimir Lambov >Priority: Normal > > Implementation of Unified Compaction Strategy per > [CEP-26|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy]. > Further documentation of the most current state of the solution can be found > in [the included markdown > documentation|https://github.com/blambov/cassandra/blob/CASSANDRA-18397/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18397) CEP-26: Unified Compaction Strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-18397: Description: Implementation of Unified Compaction Strategy per [CEP-26|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy]. Documentation of the approach can also be found in [the included markdown documentation|https://github.com/blambov/cassandra/blob/CASSANDRA-18397/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md]. was:Implementation of Unified Compaction Strategy per [CEP-26|[https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy].] > CEP-26: Unified Compaction Strategy > --- > > Key: CASSANDRA-18397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18397 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Branimir Lambov >Priority: Normal > > Implementation of Unified Compaction Strategy per > [CEP-26|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy]. > Documentation of the approach can also be found in [the included markdown > documentation|https://github.com/blambov/cassandra/blob/CASSANDRA-18397/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18397) CEP-26: Unified Compaction Strategy
Branimir Lambov created CASSANDRA-18397: --- Summary: CEP-26: Unified Compaction Strategy Key: CASSANDRA-18397 URL: https://issues.apache.org/jira/browse/CASSANDRA-18397 Project: Cassandra Issue Type: Improvement Components: Local/Compaction Reporter: Branimir Lambov Implementation of Unified Compaction Strategy per [CEP-26|[https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-26%3A+Unified+Compaction+Strategy].] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707263#comment-17707263 ] Brandon Williams commented on CASSANDRA-18391: -- Good call, updated [my branch|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-18391] and a [circle precommit|https://app.circleci.com/pipelines/github/driftx/cassandra/951/workflows/40fc731d-0d44-4dd9-838c-fe6d2919c72f]. [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2406/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2406/pipeline] > consistent timeout: > dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones > on trunk > -- > > Key: CASSANDRA-18391 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18391 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Josh McKenzie >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0% > link: > https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/ > Error message: failed on setup with "Failed: Timeout >900.0s" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18396) Dtests marked with @ported_to_in_jvm can be skipped since 4.1
Andres de la Peña created CASSANDRA-18396:
-
Summary: Dtests marked with @ported_to_in_jvm can be skipped since
4.1
Key: CASSANDRA-18396
URL: https://issues.apache.org/jira/browse/CASSANDRA-18396
Project: Cassandra
Issue Type: Improvement
Components: Test/dtest/python
Reporter: Andres de la Peña
Assignee: Andres de la Peña
During the CASSANDRA-15536 epic we ported multiple Python dtests to in-JVM
dtests.
The ported Python dtests are still present but marked with a new
{{@ported_to_in_jvm}} annotation. JVM dtests didn't support vnodes at that
time, so when a Python dtest is marked with that annotation it's only run for
vnodes config, whereas it's skipped if vnodes are off.
However, we have had support for vnodes on JVM dtests since 4.1. Thus, I think
we should modify the {{@ported_to_in_jvm}} annotation to also skip configs with
vnodes if all the nodes are in 4.1 or later.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707245#comment-17707245
]
Andres de la Peña commented on CASSANDRA-18391:
---
Looks good to me. I have verified that the test is still run in
[3.0|https://app.circleci.com/pipelines/github/adelapena/cassandra/2741/workflows/40dcb79f-5178-4736-ba16-bd62ac486870/jobs/32976/artifacts]
and
[3.11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2740/workflows/a7fa29c9-6b4f-4628-8e89-ebde92b930ac/jobs/32977/artifacts].
Hopefully skipping the ccm setup will help with other timeouts.
Probably we should add a similar skipping of the ccm setup on
{{ported_to_in_jvm}}, a few lines below,
[here|https://github.com/driftx/cassandra-dtest/blob/4481f86e80f9625bcb1cfc36e1a97028d235b1d0/conftest.py#L493].
> consistent timeout:
> dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones
> on trunk
> --
>
> Key: CASSANDRA-18391
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18391
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Josh McKenzie
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
>
> Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0%
> link:
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/
> Error message: failed on setup with "Failed: Timeout >900.0s"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18260) Add details to Error message: Not enough space for compaction
[
https://issues.apache.org/jira/browse/CASSANDRA-18260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707238#comment-17707238
]
Michael Semb Wever commented on CASSANDRA-18260:
bq. FileStore org.apache.cassandra.db.DirectoriesTest$FakeFileStore@6ddee60f
Could this be more user friendly?
e.g. if i've got a jbod setup, which data_dir is this?
> Add details to Error message: Not enough space for compaction
> --
>
> Key: CASSANDRA-18260
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18260
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction, Observability/Logging
>Reporter: Brad Schoening
>Assignee: Henrik Ingo
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When compaction fails, the log message should list a) the free space
> available on disk at that point in time and b) perhaps the number and/or size
> of the source sstables being compacted.
> Free space can change from one moment to the next, so when the below
> compaction failed because it needed 161GB, upon checking the server a few
> minutes later, it had 184GB free. Similarly, the error message mentions it
> was writing out one SSTable on this STCS table, but its not clear if it was
> combining X -> 1 tables, or something else.
> {noformat}
> [INFO ] [CompactionExecutor:77758] cluster_id=87 ip_address=127.1.1.1
> CompactionTask.java:241 - Compacted (8a1cffe0-abb5-11ed-b3fc-8d2ac2c52f0d) 1
> sstables to [...] to level=0. 86.997GiB to 86.997GiB (~99% of original) in
> 1,508,155ms. Read Throughput = 59.069MiB/s, Write Throughput = 59.069MiB/s,
> Row Throughput = ~20,283/s. 21,375 total partitions merged to 21,375.
> Partition merge counts were \{1:21375, }
> [ERROR] [CompactionExecutor:4] cluster_id=87 ip_address=127.1.1.1
> CassandraDaemon.java:581 - Exception in thread
> Thread[CompactionExecutor:4,1,main]
> java.lang.RuntimeException: Not enough space for compaction, estimated
> sstables = 1, expected write size = 161228934093
> at
> org.apache.cassandra.db.compaction.CompactionTask.buildCompactionCandidatesForAvailableDiskSpace(CompactionTask.java:386)
> at
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:126)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:77)
> at
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:100)
> at
> org.apache.cassandra.db.compaction.CompactionManager$7.execute(CompactionManager.java:613)
> at
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:377)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18260) Add details to Error message: Not enough space for compaction
[
https://issues.apache.org/jira/browse/CASSANDRA-18260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18260:
---
Component/s: Local/Compaction
> Add details to Error message: Not enough space for compaction
> --
>
> Key: CASSANDRA-18260
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18260
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction, Observability/Logging
>Reporter: Brad Schoening
>Assignee: Henrik Ingo
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When compaction fails, the log message should list a) the free space
> available on disk at that point in time and b) perhaps the number and/or size
> of the source sstables being compacted.
> Free space can change from one moment to the next, so when the below
> compaction failed because it needed 161GB, upon checking the server a few
> minutes later, it had 184GB free. Similarly, the error message mentions it
> was writing out one SSTable on this STCS table, but its not clear if it was
> combining X -> 1 tables, or something else.
> [INFO ] [CompactionExecutor:77758] cluster_id=87 ip_address=127.1.1.1
> CompactionTask.java:241 - Compacted (8a1cffe0-abb5-11ed-b3fc-8d2ac2c52f0d) 1
> sstables to [...] to level=0. 86.997GiB to 86.997GiB (~99% of original) in
> 1,508,155ms. Read Throughput = 59.069MiB/s, Write Throughput = 59.069MiB/s,
> Row Throughput = ~20,283/s. 21,375 total partitions merged to 21,375.
> Partition merge counts were \{1:21375, }
> [ERROR] [CompactionExecutor:4] cluster_id=87 ip_address=127.1.1.1
> CassandraDaemon.java:581 - Exception in thread
> Thread[CompactionExecutor:4,1,main]
> java.lang.RuntimeException: Not enough space for compaction, estimated
> sstables = 1, expected write size = 161228934093
> at
> org.apache.cassandra.db.compaction.CompactionTask.buildCompactionCandidatesForAvailableDiskSpace(CompactionTask.java:386)
> at
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:126)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:77)
> at
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:100)
> at
> org.apache.cassandra.db.compaction.CompactionManager$7.execute(CompactionManager.java:613)
> at
> org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:377)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:834)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18260) Add details to Error message: Not enough space for compaction
[
https://issues.apache.org/jira/browse/CASSANDRA-18260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18260:
---
Description:
When compaction fails, the log message should list a) the free space available
on disk at that point in time and b) perhaps the number and/or size of the
source sstables being compacted.
Free space can change from one moment to the next, so when the below compaction
failed because it needed 161GB, upon checking the server a few minutes later,
it had 184GB free. Similarly, the error message mentions it was writing out
one SSTable on this STCS table, but its not clear if it was combining X -> 1
tables, or something else.
{noformat}
[INFO ] [CompactionExecutor:77758] cluster_id=87 ip_address=127.1.1.1
CompactionTask.java:241 - Compacted (8a1cffe0-abb5-11ed-b3fc-8d2ac2c52f0d) 1
sstables to [...] to level=0. 86.997GiB to 86.997GiB (~99% of original) in
1,508,155ms. Read Throughput = 59.069MiB/s, Write Throughput = 59.069MiB/s,
Row Throughput = ~20,283/s. 21,375 total partitions merged to 21,375.
Partition merge counts were \{1:21375, }
[ERROR] [CompactionExecutor:4] cluster_id=87 ip_address=127.1.1.1
CassandraDaemon.java:581 - Exception in thread
Thread[CompactionExecutor:4,1,main]
java.lang.RuntimeException: Not enough space for compaction, estimated sstables
= 1, expected write size = 161228934093
at
org.apache.cassandra.db.compaction.CompactionTask.buildCompactionCandidatesForAvailableDiskSpace(CompactionTask.java:386)
at
org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:126)
at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
at
org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:77)
at
org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:100)
at
org.apache.cassandra.db.compaction.CompactionManager$7.execute(CompactionManager.java:613)
at
org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:377)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:834)
{noformat}
was:
When compaction fails, the log message should list a) the free space available
on disk at that point in time and b) perhaps the number and/or size of the
source sstables being compacted.
Free space can change from one moment to the next, so when the below compaction
failed because it needed 161GB, upon checking the server a few minutes later,
it had 184GB free. Similarly, the error message mentions it was writing out
one SSTable on this STCS table, but its not clear if it was combining X -> 1
tables, or something else.
[INFO ] [CompactionExecutor:77758] cluster_id=87 ip_address=127.1.1.1
CompactionTask.java:241 - Compacted (8a1cffe0-abb5-11ed-b3fc-8d2ac2c52f0d) 1
sstables to [...] to level=0. 86.997GiB to 86.997GiB (~99% of original) in
1,508,155ms. Read Throughput = 59.069MiB/s, Write Throughput = 59.069MiB/s,
Row Throughput = ~20,283/s. 21,375 total partitions merged to 21,375.
Partition merge counts were \{1:21375, }
[ERROR] [CompactionExecutor:4] cluster_id=87 ip_address=127.1.1.1
CassandraDaemon.java:581 - Exception in thread
Thread[CompactionExecutor:4,1,main]
java.lang.RuntimeException: Not enough space for compaction, estimated sstables
= 1, expected write size = 161228934093
at
org.apache.cassandra.db.compaction.CompactionTask.buildCompactionCandidatesForAvailableDiskSpace(CompactionTask.java:386)
at
org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:126)
at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
at
org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:77)
at
org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:100)
at
org.apache.cassandra.db.compaction.CompactionManager$7.execute(CompactionManager.java:613)
at
org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:377)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:834)
> Add
[jira] [Updated] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18391: -- Reviewers: Andres de la Peña, Andres de la Peña (was: Andres de la Peña) Andres de la Peña, Andres de la Peña (was: Andres de la Peña) Status: Review In Progress (was: Patch Available) > consistent timeout: > dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones > on trunk > -- > > Key: CASSANDRA-18391 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18391 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Josh McKenzie >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0% > link: > https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/ > Error message: failed on setup with "Failed: Timeout >900.0s" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18391) consistent timeout: dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones on trunk
[ https://issues.apache.org/jira/browse/CASSANDRA-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18391: -- Reviewers: Andres de la Peña > consistent timeout: > dtest-upgrade.upgrade_tests.cql_tests.cls.test_cql3_non_compound_range_tombstones > on trunk > -- > > Key: CASSANDRA-18391 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18391 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Josh McKenzie >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > > Failed 30 times in the last 30 runs. Flakiness: 0%, Stability: 0% > link: > https://ci-cassandra.apache.org/job/Cassandra-trunk/1511/testReport/dtest-upgrade.upgrade_tests.cql_tests/cls/test_cql3_non_compound_range_tombstones/ > Error message: failed on setup with "Failed: Timeout >900.0s" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18394) Add nodetool to show top n read/write table
[ https://issues.apache.org/jira/browse/CASSANDRA-18394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707229#comment-17707229 ] Brandon Williams commented on CASSANDRA-18394: -- How would this differ from toppartitions? > Add nodetool to show top n read/write table > > > Key: CASSANDRA-18394 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18394 > Project: Cassandra > Issue Type: Improvement >Reporter: maxwellguo >Assignee: maxwellguo >Priority: Normal > > add nodetool to show the read/write top n table name -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18328) Remove deprecated CQL functions dateof and unixtimestampof
[
https://issues.apache.org/jira/browse/CASSANDRA-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707227#comment-17707227
]
Michael Semb Wever commented on CASSANDRA-18328:
+1
> Remove deprecated CQL functions dateof and unixtimestampof
> --
>
> Key: CASSANDRA-18328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18328
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Syntax
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The CQL functions {{dateof}} and {{unixtimestampof}} were [deprecated on
> Cassandra
> 2.2.0|https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa],
> almost eight years ago. They were deprecated in favour of the then new
> {{totimestamp}} and {{tounixtimestamp}} functions.
> A note about their deprecation was added to
> [{{NEWS.txt}}|https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423],
> and they were marked as deprecated on
> [{{CQL.textile}}|https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions].
> They are also listed as deprecated on [the new
> doc|https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions].
> We can finally remove those functions in 5.0, since they have been deprecated
> for so long.
> Discussion thread
> [here|https://lists.apache.org/thread/0gs824fpsngn5dr0yq2x1h8qsflj5sr0].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18328) Remove deprecated CQL functions dateof and unixtimestampof
[
https://issues.apache.org/jira/browse/CASSANDRA-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707225#comment-17707225
]
Andres de la Peña commented on CASSANDRA-18328:
---
[~bereng] / [~smiklosovic] can any of you please take a look at the fix for the
dtests when you have time?
> Remove deprecated CQL functions dateof and unixtimestampof
> --
>
> Key: CASSANDRA-18328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18328
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Syntax
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The CQL functions {{dateof}} and {{unixtimestampof}} were [deprecated on
> Cassandra
> 2.2.0|https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa],
> almost eight years ago. They were deprecated in favour of the then new
> {{totimestamp}} and {{tounixtimestamp}} functions.
> A note about their deprecation was added to
> [{{NEWS.txt}}|https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423],
> and they were marked as deprecated on
> [{{CQL.textile}}|https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions].
> They are also listed as deprecated on [the new
> doc|https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions].
> We can finally remove those functions in 5.0, since they have been deprecated
> for so long.
> Discussion thread
> [here|https://lists.apache.org/thread/0gs824fpsngn5dr0yq2x1h8qsflj5sr0].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18395) Rename internal state() method in AbstractFuture to not conflict with Java 19 changes
[
https://issues.apache.org/jira/browse/CASSANDRA-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned CASSANDRA-18395:
Assignee: Sylwester Lachiewicz
> Rename internal state() method in AbstractFuture to not conflict with Java 19
> changes
> -
>
> Key: CASSANDRA-18395
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18395
> Project: Cassandra
> Issue Type: Bug
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Normal
>
> From Java 19 we have new method Future.state and it conflicts with our
> private method. Fix bellow.
> [https://download.java.net/java/early_access/jdk20/docs/api/java.base/java/util/concurrent/Future.html#state()]
>
> {code:java}
> +++ b/src/java/org/apache/cassandra/utils/concurrent/AbstractFuture.java
> @@ -494,11 +494,11 @@ public abstract class AbstractFuture implements
> Future
> public String toString()
> {
> String description = description();
> - String state = state();
> + String state = stateInfo();
> return description == null ? state : (state + ' ' + description);
> }
>
> - private String state()
> + private String stateInfo()
> {
> Object result = this.result;
> if (isSuccess(result)){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18395) Rename internal state() method in AbstractFuture to not conflict with Java 19 changes
[
https://issues.apache.org/jira/browse/CASSANDRA-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated CASSANDRA-18395:
-
Description:
>From Java 19 we have new method Future.state and it conflicts with our private
>method. Fix bellow.
[https://download.java.net/java/early_access/jdk20/docs/api/java.base/java/util/concurrent/Future.html#state()]
{code:java}
+++ b/src/java/org/apache/cassandra/utils/concurrent/AbstractFuture.java
@@ -494,11 +494,11 @@ public abstract class AbstractFuture implements
Future
public String toString()
{
String description = description();
- String state = state();
+ String state = stateInfo();
return description == null ? state : (state + ' ' + description);
}
- private String state()
+ private String stateInfo()
{
Object result = this.result;
if (isSuccess(result)){code}
> Rename internal state() method in AbstractFuture to not conflict with Java 19
> changes
> -
>
> Key: CASSANDRA-18395
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18395
> Project: Cassandra
> Issue Type: Bug
>Reporter: Sylwester Lachiewicz
>Priority: Normal
>
> From Java 19 we have new method Future.state and it conflicts with our
> private method. Fix bellow.
> [https://download.java.net/java/early_access/jdk20/docs/api/java.base/java/util/concurrent/Future.html#state()]
>
> {code:java}
> +++ b/src/java/org/apache/cassandra/utils/concurrent/AbstractFuture.java
> @@ -494,11 +494,11 @@ public abstract class AbstractFuture implements
> Future
> public String toString()
> {
> String description = description();
> - String state = state();
> + String state = stateInfo();
> return description == null ? state : (state + ' ' + description);
> }
>
> - private String state()
> + private String stateInfo()
> {
> Object result = this.result;
> if (isSuccess(result)){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18395) Rename internal state() method in AbstractFuture to not conflict with Java 19 changes
Sylwester Lachiewicz created CASSANDRA-18395: Summary: Rename internal state() method in AbstractFuture to not conflict with Java 19 changes Key: CASSANDRA-18395 URL: https://issues.apache.org/jira/browse/CASSANDRA-18395 Project: Cassandra Issue Type: Bug Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16895) Build with Java 17
[ https://issues.apache.org/jira/browse/CASSANDRA-16895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707216#comment-17707216 ] Sylwester Lachiewicz commented on CASSANDRA-16895: -- yes Michael - that what I was actually trying to archive. Otherwise everyone who would like to experiment and find this compiling issues must apply own adjustments. As we stated in build.xml - we support Java 11, and anything else is "experimental" but I expect more and more project will try to experiment with Java 21 soon. Would be good to not block people while have stable 11/17 version > Build with Java 17 > -- > > Key: CASSANDRA-16895 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16895 > Project: Cassandra > Issue Type: Epic > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > This ticket is intended to group all issues found to support Java 17 in the > future. > Upgrade steps: > * [Dependencies > |https://mvnrepository.com/artifact/org.apache.cassandra/cassandra-all/4.0.1]to > be updated (not all but at least those that require an update in order to > work with Java 17) > * More encapsulated JDK internal APIs. Some of the issues might be solved > with the dependencies updates > * Currently trunk compiles if we remove the Nashorn dependency (ant script > tag, used for the test environment; UDFs) . The oracle recommendation to use > Nashorn-core won't work for the project as it is under GPL 2.0. Most probably > we will opt in for graal-sdk licensed under UPL > * All tests to be cleaned > * CI environment to be setup > *NOTE:* GC tuning, performance testing were never agreed to be part of this > ticket. > Below is a snapshot of current CI failures with JDK17, it will be updated on > a regular basis with a date of update > *March 19th 2023* > || ||Failing Test Classes||Ticket Numbers|| > | |_Python DTests_| | > |1|test_sjk|CASSANDRA-18343| > | |_Java Ditributed Tests_| | > |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all > tests, > org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, > org.apache.cassandra.distributed.test.IPMembershipTest - both tests, > org.apache.cassandra.distributed.test.MixedModeFuzzTest, > org.apache.cassandra.distributed.test.ReprepareFuzzTest, > org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| > |7,8|org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest > - all tests > org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all > tests|Could be related to CASSANDRA-18180, to be checked | > |9|org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - > 2 tests|CASSANDRA-18180| > | |_Unit Tests_| | > |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| > |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| > |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, > org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| > |5,6|org.apache.cassandra.cql3.validation.entities.UFJavaTest, > org.apache.cassandra.cql3.validation.entities.UFSecurityTest|CASSANDRA-18190| > | | | | > | | | | > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16895) Build with Java 17
[
https://issues.apache.org/jira/browse/CASSANDRA-16895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707210#comment-17707210
]
Benjamin Lerer commented on CASSANDRA-16895:
{quote}so long as relatively costless{quote}
Let's be fully honest here. It is costly. I have been working on Jamm for the
last 4 months to get a correct support up to Java 17 and it is only a tiny bit
of the puzzle. Once we reach full support for 17, we can decide how we want to
progress on other versions but it is not a tiny work to officially support
another release and build + green CI is probably not enough in my opinion. Jamm
will simply return you the wrong results and other projects might do the same.
I agree that we must do it but if we do it, it should be done properly and not
how it was done for Java 11.
> Build with Java 17
> --
>
> Key: CASSANDRA-16895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16895
> Project: Cassandra
> Issue Type: Epic
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> This ticket is intended to group all issues found to support Java 17 in the
> future.
> Upgrade steps:
> * [Dependencies
> |https://mvnrepository.com/artifact/org.apache.cassandra/cassandra-all/4.0.1]to
> be updated (not all but at least those that require an update in order to
> work with Java 17)
> * More encapsulated JDK internal APIs. Some of the issues might be solved
> with the dependencies updates
> * Currently trunk compiles if we remove the Nashorn dependency (ant script
> tag, used for the test environment; UDFs) . The oracle recommendation to use
> Nashorn-core won't work for the project as it is under GPL 2.0. Most probably
> we will opt in for graal-sdk licensed under UPL
> * All tests to be cleaned
> * CI environment to be setup
> *NOTE:* GC tuning, performance testing were never agreed to be part of this
> ticket.
> Below is a snapshot of current CI failures with JDK17, it will be updated on
> a regular basis with a date of update
> *March 19th 2023*
> || ||Failing Test Classes||Ticket Numbers||
> | |_Python DTests_| |
> |1|test_sjk|CASSANDRA-18343|
> | |_Java Ditributed Tests_| |
> |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all
> tests,
> org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests,
> org.apache.cassandra.distributed.test.IPMembershipTest - both tests,
> org.apache.cassandra.distributed.test.MixedModeFuzzTest,
> org.apache.cassandra.distributed.test.ReprepareFuzzTest,
> org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304|
> |7,8|org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
> - all tests
> org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all
> tests|Could be related to CASSANDRA-18180, to be checked |
> |9|org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest -
> 2 tests|CASSANDRA-18180|
> | |_Unit Tests_| |
> |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884|
> |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992|
> |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest,
> org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329|
> |5,6|org.apache.cassandra.cql3.validation.entities.UFJavaTest,
> org.apache.cassandra.cql3.validation.entities.UFSecurityTest|CASSANDRA-18190|
> | | | |
> | | | |
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16895) Build with Java 17
[
https://issues.apache.org/jira/browse/CASSANDRA-16895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707183#comment-17707183
]
Michael Semb Wever commented on CASSANDRA-16895:
[~slachiewicz] and [~benedict], it will be possible for developers to
experiment with other JDKs using the {{java.supported}} ant property.
For example
{code}
ant -Djava.supported=20 jar
{code}
Throughout the test and CI system we are working on honouring this setting, but
for direct ant calls it should be working already.
> Build with Java 17
> --
>
> Key: CASSANDRA-16895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16895
> Project: Cassandra
> Issue Type: Epic
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> This ticket is intended to group all issues found to support Java 17 in the
> future.
> Upgrade steps:
> * [Dependencies
> |https://mvnrepository.com/artifact/org.apache.cassandra/cassandra-all/4.0.1]to
> be updated (not all but at least those that require an update in order to
> work with Java 17)
> * More encapsulated JDK internal APIs. Some of the issues might be solved
> with the dependencies updates
> * Currently trunk compiles if we remove the Nashorn dependency (ant script
> tag, used for the test environment; UDFs) . The oracle recommendation to use
> Nashorn-core won't work for the project as it is under GPL 2.0. Most probably
> we will opt in for graal-sdk licensed under UPL
> * All tests to be cleaned
> * CI environment to be setup
> *NOTE:* GC tuning, performance testing were never agreed to be part of this
> ticket.
> Below is a snapshot of current CI failures with JDK17, it will be updated on
> a regular basis with a date of update
> *March 19th 2023*
> || ||Failing Test Classes||Ticket Numbers||
> | |_Python DTests_| |
> |1|test_sjk|CASSANDRA-18343|
> | |_Java Ditributed Tests_| |
> |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all
> tests,
> org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests,
> org.apache.cassandra.distributed.test.IPMembershipTest - both tests,
> org.apache.cassandra.distributed.test.MixedModeFuzzTest,
> org.apache.cassandra.distributed.test.ReprepareFuzzTest,
> org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304|
> |7,8|org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
> - all tests
> org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all
> tests|Could be related to CASSANDRA-18180, to be checked |
> |9|org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest -
> 2 tests|CASSANDRA-18180|
> | |_Unit Tests_| |
> |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884|
> |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992|
> |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest,
> org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329|
> |5,6|org.apache.cassandra.cql3.validation.entities.UFJavaTest,
> org.apache.cassandra.cql3.validation.entities.UFSecurityTest|CASSANDRA-18190|
> | | | |
> | | | |
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
