[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737978#comment-17737978 ] Stefan Miklosovic commented on CASSANDRA-18632: --- Ahaaa we already have system_views.streaming, I forgot ... what is wrong with that table? Why do you prefer jmx instead cql? What do you mean about reporting previous streams there? Are not they already there? > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18617) Disable the deprecated keyspace/table thresholds and convert them to Guardrails
[ https://issues.apache.org/jira/browse/CASSANDRA-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737922#comment-17737922 ] dan jatnieks commented on CASSANDRA-18617: -- I think that's a good idea to check for the deprecated threshold value in {{{}GuardrailsOptions{}}}. My only worry would be if others might consider a bit confusing to still have {{table_count_warn_threshold}} in {{Config.java}}? I have a WIP branch here: https://github.com/djatnieks/cassandra/tree/CASSANDRA-18617 > Disable the deprecated keyspace/table thresholds and convert them to > Guardrails > --- > > Key: CASSANDRA-18617 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18617 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails >Reporter: dan jatnieks >Assignee: dan jatnieks >Priority: Normal > Fix For: 5.x > > > The non-guardrail thresholds 'keyspace_count_warn_threshold' and > 'table_count_warn_threshold' configuration settings were first added with > CASSANDRA-16309 in 4.0-beta4 and have subsequently been deprecated since > 4.1-alpha in CASSANDRA-17195 when they were replaced/migrated to guardrails > as part of CEP-3 (Guardrails). > These thresholds should now be removed from cassandra.yaml, while still > allowed in existing yaml files. > The old thresholds will be disabled by removing their default values from > Config.java, and any existing values for these thresholds will be converted > to the new guardrails using the '@Replaces' tag on the corresponding > guardrail values. > Since the old thresholds considered the number of system keyspace/tables in > their values, the '@Replaces' conversion will subtract the current number of > system tables from the old value and log a descriptive message. > See dev list discussion: > https://lists.apache.org/thread/0zjg08hrd6xv7lhvo96frz456b2rvr8b -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code and update it for new JDK versions
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Summary: Clean SyncUtil from dead code and update it for new JDK versions (was: Clean SyncUtil from dead code) > Clean SyncUtil from dead code and update it for new JDK versions > > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (1e9c4bc25 -> 1ffa74c33)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git omit 1e9c4bc25 generate docs for 898aa3ff new 1ffa74c33 generate docs for 898aa3ff This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1e9c4bc25) \ N -- N -- N refs/heads/asf-staging (1ffa74c33) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18634) Missed version note for nodetool setmaxhintwindow
Yury Vidineev created CASSANDRA-18634: - Summary: Missed version note for nodetool setmaxhintwindow Key: CASSANDRA-18634 URL: https://issues.apache.org/jira/browse/CASSANDRA-18634 Project: Cassandra Issue Type: Bug Components: Documentation/Website Reporter: Yury Vidineev In the [documentation about hints for Cassandra 4.1|https://cassandra.apache.org/doc/latest/cassandra/operating/hints.html], there is a note for nodetool getmaxhintwindow: "New in Cassandra 4.0." I think the same note should be for nodetool setmaxhintwindow. I can create a merge request myself, but don't know where -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18541) AUTH requests use too much resources
[ https://issues.apache.org/jira/browse/CASSANDRA-18541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737899#comment-17737899 ] Yury Vidineev commented on CASSANDRA-18541: --- Thanks for the answer, [~smiklosovic] . Yes, from the [CASSANDRA-17812|https://issues.apache.org/jira/browse/CASSANDRA-17812] description that's exactly the issue I faced. Since we already fixed it on the client side - it's hard to reproduce, but I'll try. For now, I think we can close this issue. Thanks! > AUTH requests use too much resources > > > Key: CASSANDRA-18541 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18541 > Project: Cassandra > Issue Type: Bug >Reporter: Yury Vidineev >Priority: Normal > Attachments: Screenshot_20230520_000633.png, > Screenshot_20230520_000654.png > > > Hello. I see unexpected CPU usage in a rare situation that may be worth > digging into. > We have C* 4.0.9 on Debian running on Java 11.0.18. > It's a small cluster of 3 nodes on commodity hardware (6 cores CPU, 32 Gb > RAM, 2 x 512 Gb SSD NVME). > This ring has about 35 clients using Datastax Java Driver for Apache > Cassandra. > In the driver connection settings, we use the following: > CONNECTION_POOL_LOCAL_SIZE = 400 > CONNECTION_POOL_REMOTE_SIZE = 100 > > And for some reason, from time to time, it causes hundreds of AUTH requests > per second that leads to an enormous CPU usage. > And yes, it's easy not to use these settings in the driver, leaving defaults > that don't produce such an amount of AUTHs. But isn't it weird that ~150 AUTH > rps consume ~1200% CPU? > Please see attached graphs. > I have the following in the settings: > authenticator: PasswordAuthenticator > authorizer: CassandraAuthorizer > roles_validity_in_ms: 60 > permissions_validity_in_ms: 60 > credentials_validity_in_ms: 60 > Please let me know if I can provide any other necessary information. > Thanks for your work. Cassandra is amazing :) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18541) AUTH requests use too much resources
[ https://issues.apache.org/jira/browse/CASSANDRA-18541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yury Vidineev updated CASSANDRA-18541: -- Resolution: Fixed Status: Resolved (was: Triage Needed) > AUTH requests use too much resources > > > Key: CASSANDRA-18541 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18541 > Project: Cassandra > Issue Type: Bug >Reporter: Yury Vidineev >Priority: Normal > Attachments: Screenshot_20230520_000633.png, > Screenshot_20230520_000654.png > > > Hello. I see unexpected CPU usage in a rare situation that may be worth > digging into. > We have C* 4.0.9 on Debian running on Java 11.0.18. > It's a small cluster of 3 nodes on commodity hardware (6 cores CPU, 32 Gb > RAM, 2 x 512 Gb SSD NVME). > This ring has about 35 clients using Datastax Java Driver for Apache > Cassandra. > In the driver connection settings, we use the following: > CONNECTION_POOL_LOCAL_SIZE = 400 > CONNECTION_POOL_REMOTE_SIZE = 100 > > And for some reason, from time to time, it causes hundreds of AUTH requests > per second that leads to an enormous CPU usage. > And yes, it's easy not to use these settings in the driver, leaving defaults > that don't produce such an amount of AUTHs. But isn't it weird that ~150 AUTH > rps consume ~1200% CPU? > Please see attached graphs. > I have the following in the settings: > authenticator: PasswordAuthenticator > authorizer: CassandraAuthorizer > roles_validity_in_ms: 60 > permissions_validity_in_ms: 60 > credentials_validity_in_ms: 60 > Please let me know if I can provide any other necessary information. > Thanks for your work. Cassandra is amazing :) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-62) Fix uncaught exception in sidecar client that causes request to freeze
[ https://issues.apache.org/jira/browse/CASSANDRASC-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737898#comment-17737898 ] Francisco Guerrero commented on CASSANDRASC-62: --- +1 (nb), thanks for fixing this issue! > Fix uncaught exception in sidecar client that causes request to freeze > -- > > Key: CASSANDRASC-62 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-62 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > When processing response, the sidecar client does not catch throwable rather > than IOException. The uncaught exception leads to the response future never > gets closes and the client that is waiting on the completion of it never make > progress. > The fix is to catch all throwable instead of only IOException. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-62) Fix uncaught exception in sidecar client that causes request to freeze
[ https://issues.apache.org/jira/browse/CASSANDRASC-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-62: - Authors: Yifan Cai Test and Documentation Plan: unit test Status: Patch Available (was: Open) > Fix uncaught exception in sidecar client that causes request to freeze > -- > > Key: CASSANDRASC-62 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-62 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > When processing response, the sidecar client does not catch throwable rather > than IOException. The uncaught exception leads to the response future never > gets closes and the client that is waiting on the completion of it never make > progress. > The fix is to catch all throwable instead of only IOException. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-62) Fix uncaught exception in sidecar client that causes request to freeze
[ https://issues.apache.org/jira/browse/CASSANDRASC-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-62: - Bug Category: Parent values: Availability(12983)Level 1 values: Response Crash(12991) Complexity: Low Hanging Fruit Discovered By: Code Inspection Fix Version/s: 1.0 Severity: Normal Status: Open (was: Triage Needed) PR: https://github.com/apache/cassandra-sidecar/pull/57 CI: https://app.circleci.com/pipelines/github/yifan-c/cassandra-sidecar?branch=CASSANDRASC-62%2Ftrunk > Fix uncaught exception in sidecar client that causes request to freeze > -- > > Key: CASSANDRASC-62 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-62 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > When processing response, the sidecar client does not catch throwable rather > than IOException. The uncaught exception leads to the response future never > gets closes and the client that is waiting on the completion of it never make > progress. > The fix is to catch all throwable instead of only IOException. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-62) Fix uncaught exception in sidecar client that causes request to freeze
[ https://issues.apache.org/jira/browse/CASSANDRASC-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRASC-62: -- Labels: pull-request-available (was: ) > Fix uncaught exception in sidecar client that causes request to freeze > -- > > Key: CASSANDRASC-62 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-62 > Project: Sidecar for Apache Cassandra > Issue Type: Bug > Components: Rest API >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > > When processing response, the sidecar client does not catch throwable rather > than IOException. The uncaught exception leads to the response future never > gets closes and the client that is waiting on the completion of it never make > progress. > The fix is to catch all throwable instead of only IOException. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-62) Fix uncaught exception in sidecar client that causes request to freeze
Yifan Cai created CASSANDRASC-62: Summary: Fix uncaught exception in sidecar client that causes request to freeze Key: CASSANDRASC-62 URL: https://issues.apache.org/jira/browse/CASSANDRASC-62 Project: Sidecar for Apache Cassandra Issue Type: Bug Components: Rest API Reporter: Yifan Cai Assignee: Yifan Cai When processing response, the sidecar client does not catch throwable rather than IOException. The uncaught exception leads to the response future never gets closes and the client that is waiting on the completion of it never make progress. The fix is to catch all throwable instead of only IOException. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18255) Drop JDK8 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18255: Description: * update Jenkins builds scripts (cassandra-builds) for trunk to build and run tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Revert this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] was: * update Jenkins builds scripts (cassandra-builds) for trunk to build and run tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] > Drop JDK8 Support > - > > Key: CASSANDRA-18255 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18255 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Priority: High > Fix For: 5.x > > > * update Jenkins builds scripts (cassandra-builds) for trunk to build and run > tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit > * the JDK11+17 config files and script in cassandra/.circleci should replace > the default J8+J11 test config files and script > * Cassandra trunk build.xml and conf files should be updated - JDK8 removed > everywhere > * Any tickets blocked on this one and ready to commit should be committed > * Revert this change in CCM - > [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18255) Drop JDK8 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18255: Description: * update Jenkins builds scripts (cassandra-builds) for trunk to build and run tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] was: * update Jenkins builds scripts for trunk to build and run tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] > Drop JDK8 Support > - > > Key: CASSANDRA-18255 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18255 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Priority: High > Fix For: 5.x > > > * update Jenkins builds scripts (cassandra-builds) for trunk to build and run > tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit > * the JDK11+17 config files and script in cassandra/.circleci should replace > the default J8+J11 test config files and script > * Cassandra trunk build.xml and conf files should be updated - JDK8 removed > everywhere > * Any tickets blocked on this one and ready to commit should be committed > * Reverse this change in CCM - > [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18255) Drop JDK8 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18255: Description: * update Jenkins builds scripts for trunk to build and run tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] was: * update Jenkins builds scripts * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] > Drop JDK8 Support > - > > Key: CASSANDRA-18255 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18255 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Priority: High > Fix For: 5.x > > > * update Jenkins builds scripts for trunk to build and run tests only with > JDK 11 and JDK 17 - both Jenkins-dev and post-commit > * the JDK11+17 config files and script in cassandra/.circleci should replace > the default J8+J11 test config files and script > * Cassandra trunk build.xml and conf files should be updated - JDK8 removed > everywhere > * Any tickets blocked on this one and ready to commit should be committed > * Reverse this change in CCM - > [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18255) Drop JDK8 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18255: Description: * update Jenkins builds scripts * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] > Drop JDK8 Support > - > > Key: CASSANDRA-18255 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18255 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Priority: High > Fix For: 5.x > > > * update Jenkins builds scripts > * the JDK11+17 config files and script in cassandra/.circleci should replace > the default J8+J11 test config files and script > * Cassandra trunk build.xml and conf files should be updated - JDK8 removed > * Any tickets blocked on this one and ready to commit should be committed > * Reverse this change in CCM - > [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18255) Drop JDK8 Support
[ https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18255: Description: * update Jenkins builds scripts * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed everywhere * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] was: * update Jenkins builds scripts * the JDK11+17 config files and script in cassandra/.circleci should replace the default J8+J11 test config files and script * Cassandra trunk build.xml and conf files should be updated - JDK8 removed * Any tickets blocked on this one and ready to commit should be committed * Reverse this change in CCM - [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] > Drop JDK8 Support > - > > Key: CASSANDRA-18255 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18255 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Michael Semb Wever >Priority: High > Fix For: 5.x > > > * update Jenkins builds scripts > * the JDK11+17 config files and script in cassandra/.circleci should replace > the default J8+J11 test config files and script > * Cassandra trunk build.xml and conf files should be updated - JDK8 removed > everywhere > * Any tickets blocked on this one and ready to commit should be committed > * Reverse this change in CCM - > [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18630) jackson-databind-2.13.2.2.jar vulnerability: CVE-2023-35116
[ https://issues.apache.org/jira/browse/CASSANDRA-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18630: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > jackson-databind-2.13.2.2.jar vulnerability: CVE-2023-35116 > --- > > Key: CASSANDRA-18630 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18630 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > https://nvd.nist.gov/vuln/detail/CVE-2023-35116 > {noformat} > An issue was discovered jackson-databind thru 2.15.2 allows attackers to > cause a denial of service or other unspecified impacts via crafted object > that uses cyclic dependencies. NOTE: the vendor's perspective is that the > product is not intended for use with untrusted input. > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch trunk updated: ninja fix: spotbugs complains about passing known null values
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git The following commit(s) were added to refs/heads/trunk by this push: new 6e8a628 ninja fix: spotbugs complains about passing known null values 6e8a628 is described below commit 6e8a62845acd211bb8fa460ef874b477245f395e Author: Yifan Cai AuthorDate: Tue Jun 27 15:21:29 2023 -0700 ninja fix: spotbugs complains about passing known null values --- .../org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java b/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java index 1eb3719..c06a629 100644 --- a/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java +++ b/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java @@ -152,11 +152,11 @@ public class BasicRetryPolicy extends RetryPolicy // checksum is encountered if (canRetryOnADifferentHost) { -retryImmediately(responseFuture, request, retryAction, attempts, throwable); +retryImmediately(responseFuture, request, retryAction, attempts); } else { -retry(responseFuture, request, retryAction, attempts, throwable); +retry(responseFuture, request, retryAction, attempts, null); } return; } - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] yifan-c commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
yifan-c commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1244426547 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -338,11 +339,23 @@ public String getVersionFromFeature() public String getVersionFromSidecar() { -LOGGER.info("Getting Cassandra versions from all nodes"); -List allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, - cassandraContext.getSidecarClient(), - cassandraContext.clusterConfig); -return getLowestVersion(allNodeSettings); +List currentAllNodeSettings = allNodeSettings; +if (currentAllNodeSettings != null) +{ +return getLowestVersion(currentAllNodeSettings); +} + +synchronized (this) +{ +if (allNodeSettings == null) +{ +LOGGER.info("Getting Cassandra versions from all nodes"); +allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, + cassandraContext.getSidecarClient(), + cassandraContext.clusterConfig); +} +return getLowestVersion(allNodeSettings); Review Comment: I think this line could be moved out of the critical section. And further more, it can combine with line#345 and making it the classic double checked locking pattern... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737890#comment-17737890 ] Raymond Huffman commented on CASSANDRA-18632: - It also looks like we already have a StreamingVirtualTable from [CASSANDRA-17390|https://issues.apache.org/jira/browse/CASSANDRA-17390], so I could potentially report previous streams there or in a separate table. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18616) Simulator Java 17 support
[ https://issues.apache.org/jira/browse/CASSANDRA-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737889#comment-17737889 ] Ekaterina Dimitrova commented on CASSANDRA-18616: - Spoke to Benedict Elliott Smith. There is no particular reason for tests not to work on JDK11 build with JDK17 runtime. Not a blocker if they don't but expected to work. He pointed to me {code:java} [junit-timeout] # Problematic frame: [junit-timeout] # V [libjvm.dylib+0x5086e5] java_lang_String::create_from_symbol(Symbol*, JavaThread*)+0x15{code} and related JDK bug: https://mail.openjdk.org/pipermail/hotspot-dev/2016-September/024480.html and https://bugs.openjdk.org/browse/JDK-8164561 It seems there’s some symbol in the classfile that is being turned into a string unsuccessfully. I ran a few more tests and realized that when I run the full suite of tests the first time, they pass, then if I do not run _ant realclean & ant jar_ before running them again, the _cassandra.testtag_ gets the default value {_}testtag_IS_UNDEFINED{_}: {code:java} Testcase: org.apache.cassandra.simulator.test.ShortPaxosSimulationTest:simulationTest-cassandra.testtag_IS_UNDEFINED{code} and the tests fail. This does not happen if we run a single test in a loop, and the issue is not presented in CI (we don't have jobs to run a full test suite in a loop). I will add the CI job for the JDK11 build + JDK17 tests for the simulator; it seems the issue is how we run tests. We very rarely run a full suite locally, moreover, more than once in a row. > Simulator Java 17 support > - > > Key: CASSANDRA-18616 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18616 > Project: Cassandra > Issue Type: Task > Components: Test/fuzz >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > Add Java 17 support for the simulator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] yifan-c closed pull request #3: CASSANDRA-18574: Fix sample job documentation after Sidecar changes
yifan-c closed pull request #3: CASSANDRA-18574: Fix sample job documentation after Sidecar changes URL: https://github.com/apache/cassandra-analytics/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737888#comment-17737888 ] Raymond Huffman commented on CASSANDRA-18632: - For my use case, I'd prefer to get this information from the StreamManagerMBean instead of via a virtual table. What do you think about just using a Cache with a maximum size? {code} Cache completedStreams = CacheBuilder.newBuilder().maximumSize(1000).build(); {code} > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18616) Simulator Java 17 support
[ https://issues.apache.org/jira/browse/CASSANDRA-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735516#comment-17735516 ] Ekaterina Dimitrova edited comment on CASSANDRA-18616 at 6/27/23 9:39 PM: -- Minimal patch similar to what we did in the past to enable the in-jvm tests with Java 17. JDK 17 simulator tests also adding and passing in CircleCI. I have only one thing. We never tested JDK8 build with JDK11 tests run but I tested locally that those pass. Now with the current patch JDK11 build with JDK17 runtime - all tests but one pass. This is the error that I got locally: {code:java} [junit-timeout] Testcase: selfReconcileTest(org.apache.cassandra.simulator.test.ShortPaxosSimulationTest)-.jdk17:SKIPPED: fails due to OOM DirectMemory - unclear why [junit-timeout] Testsuite: org.apache.cassandra.simulator.test.TrivialSimulationTest-.jdk17 [junit-timeout] # [junit-timeout] # A fatal error has been detected by the Java Runtime Environment: [junit-timeout] # [junit-timeout] # SIGSEGV (0xb) at pc=0x000101d2e6e5, pid=13776, tid=27907 [junit-timeout] # [junit-timeout] # JRE version: Java(TM) SE Runtime Environment (17.0.4.1+1) (build 17.0.4.1+1-LTS-2) [junit-timeout] # Java VM: Java HotSpot(TM) 64-Bit Server VM (17.0.4.1+1-LTS-2, mixed mode, sharing, compressed oops, compressed class ptrs, g1 gc, bsd-amd64) [junit-timeout] # Problematic frame: [junit-timeout] # V [libjvm.dylib+0x5086e5] java_lang_String::create_from_symbol(Symbol*, JavaThread*)+0x15 [junit-timeout] # [junit-timeout] # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again [junit-timeout] # [junit-timeout] # An error report file with more information is saved as: [junit-timeout] # /cassandra/hs_err_pid13776.log [junit-timeout] # [junit-timeout] # If you would like to submit a bug report, please visit: [junit-timeout] # https://bugreport.java.com/bugreport/crash.jsp [junit-timeout] # [junit-timeout] Testsuite: org.apache.cassandra.simulator.test.TrivialSimulationTest-cassandra.testtag_IS_UNDEFINED [junit-timeout] Testsuite: org.apache.cassandra.simulator.test.TrivialSimulationTest-cassandra.testtag_IS_UNDEFINED Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec [junit-timeout] [junit-timeout] Testcase: org.apache.cassandra.simulator.test.TrivialSimulationTest:trivialTest-cassandra.testtag_IS_UNDEFINED: Caused an ERROR [junit-timeout] Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. [junit-timeout] junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at java.base/java.util.Vector.forEach(Vector.java:1365) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at java.base/java.util.Vector.forEach(Vector.java:1365) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) {code} I found below in the mentioned log: {code:java} Internal exceptions (20 events): Event: 28.458 Thread 0x7f79c7113400 Exception (0x0007ca0ea7d0) thrown [open/src/hotspot/share/interpreter/linkResolver.cpp, line 759] Event: 28.474 Thread 0x7f79c7113400 Exception (0x0007ca102020) thrown [open/src/hotspot/share/interpreter/linkResolver.cpp, line 759] Event: 28.518 Thread 0x7f79c7113400 Exception (0x0007ca178b28) thrown [open/src/hotspot/share/interpreter/linkResolver.cpp, line 759] Event: 28.542 Thread 0x7f79c7113400 Exception (0x0007ca2c6440) thrown [open/src/hotspot/share/runtime/reflection.cpp, line 1121] Event: 28.949 Thread 0x7f79c7113400 Implicit null exception at 0x00010d1bbee0 to 0x00010d1bbf50 Event: 28.950 Thread 0x7f79c7113400 Exception (0x0007ca4a8020) thrown [open/src/hotspot/share/classfile/systemDiction
[jira] [Updated] (CASSANDRA-18616) Simulator Java 17 support
[ https://issues.apache.org/jira/browse/CASSANDRA-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18616: Test and Documentation Plan: Minimal patch similar to what we did in the past to enable the in-jvm tests with Java 17. JDK 17 simulator tests also adding and passing in CircleCI. I have only one concern. We never tested JDK8 build with JDK11 tests runtime but I tested locally that those pass. Now with the current patch JDK11 build with JDK17 runtime - all tests but one pass. This is the error that I got locally: {code:java} [junit-timeout] Testcase: selfReconcileTest(org.apache.cassandra.simulator.test.ShortPaxosSimulationTest)-.jdk17:SKIPPED: fails due to OOM DirectMemory - unclear why [junit-timeout] Testsuite: org.apache.cassandra.simulator.test.TrivialSimulationTest-.jdk17 [junit-timeout] # [junit-timeout] # A fatal error has been detected by the Java Runtime Environment: [junit-timeout] # [junit-timeout] # SIGSEGV (0xb) at pc=0x000101d2e6e5, pid=13776, tid=27907 [junit-timeout] # [junit-timeout] # JRE version: Java(TM) SE Runtime Environment (17.0.4.1+1) (build 17.0.4.1+1-LTS-2) [junit-timeout] # Java VM: Java HotSpot(TM) 64-Bit Server VM (17.0.4.1+1-LTS-2, mixed mode, sharing, compressed oops, compressed class ptrs, g1 gc, bsd-amd64) [junit-timeout] # Problematic frame: [junit-timeout] # V [libjvm.dylib+0x5086e5] java_lang_String::create_from_symbol(Symbol*, JavaThread*)+0x15 [junit-timeout] # [junit-timeout] # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again [junit-timeout] # [junit-timeout] # An error report file with more information is saved as: [junit-timeout] # /cassandra/hs_err_pid13776.log [junit-timeout] # [junit-timeout] # If you would like to submit a bug report, please visit: [junit-timeout] # https://bugreport.java.com/bugreport/crash.jsp [junit-timeout] # [junit-timeout] Testsuite: org.apache.cassandra.simulator.test.TrivialSimulationTest-cassandra.testtag_IS_UNDEFINED [junit-timeout] Testsuite: org.apache.cassandra.simulator.test.TrivialSimulationTest-cassandra.testtag_IS_UNDEFINED Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec [junit-timeout] [junit-timeout] Testcase: org.apache.cassandra.simulator.test.TrivialSimulationTest:trivialTest-cassandra.testtag_IS_UNDEFINED: Caused an ERROR [junit-timeout] Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. [junit-timeout] junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at java.base/java.util.Vector.forEach(Vector.java:1365) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at java.base/java.util.Vector.forEach(Vector.java:1365) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit-timeout] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) [junit-timeout] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) {code} I found below in the mentioned log: {code:java} Internal exceptions (20 events): Event: 28.458 Thread 0x7f79c7113400 Exception (0x0007ca0ea7d0) thrown [open/src/hotspot/share/interpreter/linkResolver.cpp, line 759] Event: 28.474 Thread 0x7f79c7113400 Exception (0x0007ca102020) thrown [open/src/hotspot/share/interpreter/linkResolver.cpp, line 759] Event: 28.518 Thread 0x7f79c7113400 Exception (0x0007ca178b28) thrown [open/src/hotspot/share/interpreter/linkResolver.cpp, line 759] Event: 28.542 Thread 0x7f79c7113400 Exception (0x0007ca2c6440) thrown [open/src/hotspot/share/runtime/reflection.cpp, line 1121] Event: 28.949 Thread 0x7f79c7113400 Implicit null exception at 0x00010d1bbee0 to 0x00010d1bbf50 Event: 28.950 Thread 0x7f79c7113400 Exception (0x0007ca4a8020) thrown [open/src/hotspot/share/classfile/systemDictionary.cpp, line 256] Event: 28.966 Thread 0x7f79c7113400 Exceptio
[jira] [Comment Edited] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737882#comment-17737882 ] Stefan Miklosovic edited comment on CASSANDRA-18632 at 6/27/23 9:10 PM: Ah this one, sorry, CASSANDRA-17948 [~rmhuffman] would you mind to try to model your patch like that? Let's see where we get with that. EDIT: great! was (Author: smiklosovic): Ah this one, sorry, CASSANDRA-17948 [~rmhuffman] would you mind to try to model your patch like that? Let's see where we get with that. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737882#comment-17737882 ] Stefan Miklosovic commented on CASSANDRA-18632: --- Ah this one, sorry, CASSANDRA-17948 [~rmhuffman] would you mind to try to model your patch like that? Let's see where we get with that. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737881#comment-17737881 ] Raymond Huffman commented on CASSANDRA-18632: - That makes sense to me, I can update the patch > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737879#comment-17737879 ] Brandon Williams commented on CASSANDRA-18632: -- That's not the right ticket linked, but I know what you're talking about and that approach sounds good to me. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737878#comment-17737878 ] Stefan Miklosovic commented on CASSANDRA-18632: --- We could probably use same technique as we did in CASSANDRA-17946. That is, there would be a virtual table which would be limited in its capacity (like ... 100k streams is enough?) and as new streams come in, the oldest ones would be removed. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
[ https://issues.apache.org/jira/browse/CASSANDRA-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuriy Semchyshyn updated CASSANDRA-18633: - Source Control Link: https://github.com/apache/cassandra-analytics/pull/9 > [Analytics] Add Caching of Node Settings to Improve Efficiency > -- > > Key: CASSANDRA-18633 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Priority: Normal > > Currently, `CassandraClusterInfo` does not reuse results of a call to > `allNodeSettingsBlocking` from `Sidecar`. > We should improve efficiency by caching these results in order to prevent > multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
Yuriy Semchyshyn created CASSANDRA-18633: Summary: [Analytics] Add Caching of Node Settings to Improve Efficiency Key: CASSANDRA-18633 URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 Project: Cassandra Issue Type: Improvement Components: Analytics Library Reporter: Yuriy Semchyshyn Currently, `CassandraClusterInfo` does not reuse results of a call to `allNodeSettingsBlocking` from `Sidecar`. We should improve efficiency by caching these results in order to prevent multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737875#comment-17737875 ] Brandon Williams commented on CASSANDRA-18632: -- The problem with doing this is the node may complete tens of thousands (or more) streams in its (running) lifetime from repairs, etc. Tracking all of them forever is probably not desirable. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18632: - Change Category: Operability Complexity: Normal Fix Version/s: 5.x Assignee: Raymond Huffman Status: Open (was: Triage Needed) > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Assignee: Raymond Huffman >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] 5 opened a new pull request, #9: Added Caching of Node Settings to Improve Efficiency
5 opened a new pull request, #9: URL: https://github.com/apache/cassandra-analytics/pull/9 Currently, `CassandraClusterInfo` does not reuse results of a call to `allNodeSettingsBlocking` from `Sidecar`. We should improve efficiency by caching these results in order to prevent multiple expensive cluster-wide calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18574) [Analytics] Fix example documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18574: -- Fix Version/s: NA Source Control Link: https://github.com/apache/cassandra-analytics/commit/ee1c83722bfb1155bef762cdfb2c86034857f2d0 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [ee1c8372|https://github.com/apache/cassandra-analytics/commit/ee1c83722bfb1155bef762cdfb2c86034857f2d0] > [Analytics] Fix example documentation > -- > > Key: CASSANDRA-18574 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18574 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Low > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > The documentation for the example job for Cassandra Analytics > [link|https://github.com/apache/cassandra-analytics/blob/trunk/cassandra-analytics-core-example/README.md] > configures Sidecar to use the local CCM cluster. This documentation is > however broken since some feedback during the review of the Sidecar PR > changed one of the yaml options from {{uploads_staging_dir}} to > {{staging_dir}}. > We need to update the documentation to reflect that change. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
[ https://issues.apache.org/jira/browse/CASSANDRA-18632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Huffman updated CASSANDRA-18632: Description: We monitor Bootstraps in progress by polling StreamManagerMBean.getCurrentStreams(). While this gives us good signal for how a bootstrap is progressing, we'd also like to check that all streams have completed successfully when a node has finished bootstrapping. This patch adds a separate map in StreamManager to track completed streams, and reports those stream summaries in StreamManagerMBean.getCompletedStreams() and .getAllStreams() It also adds an option to nodetool netstats to display completed streams alongside the current streams. https://github.com/apache/cassandra/pull/2453 was: We monitor Bootstraps in progress by polling StreamManagerMBean.getCurrentStreams(). While this gives us good signal for how a bootstrap is progressing, we'd also like to check that all streams have completed successfully when a node has finished bootstrapping. This patch adds a separate map in StreamManager to track completed streams, and reports those stream summaries in StreamManagerMBean.getCompletedStreams() and .getAllStreams() It also adds an option to nodetool netstats to display completed streams alongside the current streams. > Save state about completed streams and display in nodetool netstats > --- > > Key: CASSANDRA-18632 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 > Project: Cassandra > Issue Type: Improvement > Components: Observability/JMX >Reporter: Raymond Huffman >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > We monitor Bootstraps in progress by polling > StreamManagerMBean.getCurrentStreams(). While this gives us good signal for > how a bootstrap is progressing, we'd also like to check that all streams have > completed successfully when a node has finished bootstrapping. > This patch adds a separate map in StreamManager to track completed streams, > and reports those stream summaries in > StreamManagerMBean.getCompletedStreams() and .getAllStreams() > It also adds an option to nodetool netstats to display completed streams > alongside the current streams. > https://github.com/apache/cassandra/pull/2453 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-analytics] branch trunk updated: CASSANDRA-18574: Fix sample job documentation after Sidecar changes
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-analytics.git The following commit(s) were added to refs/heads/trunk by this push: new ee1c837 CASSANDRA-18574: Fix sample job documentation after Sidecar changes ee1c837 is described below commit ee1c83722bfb1155bef762cdfb2c86034857f2d0 Author: Francisco Guerrero AuthorDate: Wed Jun 7 12:40:50 2023 -0700 CASSANDRA-18574: Fix sample job documentation after Sidecar changes This commit fixes the README file with documentation to setup and run the Sample job provided in the repository. During Sidecar review, there was a suggestion to change the yaml property `uploads_staging_dir` to `staging_dir`. That change however was not reflected as part of the sample job README.md. patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRA-18574 --- cassandra-analytics-core-example/README.md | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/cassandra-analytics-core-example/README.md b/cassandra-analytics-core-example/README.md index 6204000..549dca8 100644 --- a/cassandra-analytics-core-example/README.md +++ b/cassandra-analytics-core-example/README.md @@ -49,13 +49,13 @@ In this step, we will clone and configure the Cassandra Sidecar project. Finally connecting to our local Cassandra 3-node cluster. ```shell -git clone https://github.com/frankgh/cassandra-sidecar/tree/CEP-28-bulk-apis +git clone https://github.com/apache/cassandra-sidecar cd cassandra-sidecar ``` -Configure the `main/dist/sidecar.yaml` file for your local environment. You will most likely only need to configure +Configure the `src/main/dist/sidecar.yaml` file for your local environment. You will most likely only need to configure the `cassandra_instances` section in your file pointing to your local Cassandra data directories. Here is what my -configuration looks like for this tutorial: +`cassandra_instances` configuration section looks like for this tutorial: ```yaml cassandra_instances: @@ -63,7 +63,7 @@ cassandra_instances: host: localhost port: 9042 data_dirs: /.ccm/test/node1/data0 -uploads_staging_dir: /.ccm/test/node1/sstable-staging +staging_dir: /.ccm/test/node1/sstable-staging jmx_host: 127.0.0.1 jmx_port: 7100 jmx_ssl_enabled: false @@ -71,7 +71,7 @@ cassandra_instances: host: localhost2 port: 9042 data_dirs: /.ccm/test/node2/data0 -uploads_staging_dir: /.ccm/test/node2/sstable-staging +staging_dir: /.ccm/test/node2/sstable-staging jmx_host: 127.0.0.1 jmx_port: 7200 jmx_ssl_enabled: false @@ -79,22 +79,20 @@ cassandra_instances: host: localhost3 port: 9042 data_dirs: /.ccm/test/node3/data0 -uploads_staging_dir: /.ccm/test/node3/sstable-staging +staging_dir: /.ccm/test/node3/sstable-staging jmx_host: 127.0.0.1 jmx_port: 7300 jmx_ssl_enabled: false ``` I have a 3 node setup, so I configure Sidecar for those 3 nodes. CCM creates the Cassandra cluster under -`${HOME}/.ccm/test`, so I update my `data_dirs` and `uploads_staging_dir` configuration to use my local path. +`${HOME}/.ccm/test`, so I update my `data_dirs` and `staging_dir` configuration to use my local path. -Next, create the `uploads_staging_dir` where Sidecar will stage SSTables coming from Cassandra Spark bulk writer. +Next, create the `staging_dir` where Sidecar will stage SSTables coming from Cassandra Spark bulk writer. In my case, I have decided to keep the `sstable-staging` directory inside each of the node's directories. ```shell -mkdir -p ${HOME}/.ccm/test/node1/sstable-staging -mkdir -p ${HOME}/.ccm/test/node2/sstable-staging -mkdir -p ${HOME}/.ccm/test/node3/sstable-staging +mkdir -p ${HOME}/.ccm/test/node{1..3}/sstable-staging ``` Finally, run Cassandra Sidecar, we skip running integration tests because we need docker for integration tests. You - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18632) Save state about completed streams and display in nodetool netstats
Raymond Huffman created CASSANDRA-18632: --- Summary: Save state about completed streams and display in nodetool netstats Key: CASSANDRA-18632 URL: https://issues.apache.org/jira/browse/CASSANDRA-18632 Project: Cassandra Issue Type: Improvement Components: Observability/JMX Reporter: Raymond Huffman We monitor Bootstraps in progress by polling StreamManagerMBean.getCurrentStreams(). While this gives us good signal for how a bootstrap is progressing, we'd also like to check that all streams have completed successfully when a node has finished bootstrapping. This patch adds a separate map in StreamManager to track completed streams, and reports those stream summaries in StreamManagerMBean.getCompletedStreams() and .getAllStreams() It also adds an option to nodetool netstats to display completed streams alongside the current streams. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18600) [Analytics] Add NOTICE.txt in Cassandra Analytics
[ https://issues.apache.org/jira/browse/CASSANDRA-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737872#comment-17737872 ] Yifan Cai commented on CASSANDRA-18600: --- Yeah. There is no release/fix version for the subproject at the moment. > [Analytics] Add NOTICE.txt in Cassandra Analytics > -- > > Key: CASSANDRA-18600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18600 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Fix For: NA > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Cassandra Analytics project is missing the {{NOTICE.txt}} file required > for compliance with the ASF guidance -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18574) [Analytics] Fix example documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18574: -- Status: Ready to Commit (was: Review In Progress) > [Analytics] Fix example documentation > -- > > Key: CASSANDRA-18574 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18574 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Low > Time Spent: 10m > Remaining Estimate: 0h > > The documentation for the example job for Cassandra Analytics > [link|https://github.com/apache/cassandra-analytics/blob/trunk/cassandra-analytics-core-example/README.md] > configures Sidecar to use the local CCM cluster. This documentation is > however broken since some feedback during the review of the Sidecar PR > changed one of the yaml options from {{uploads_staging_dir}} to > {{staging_dir}}. > We need to update the documentation to reflect that change. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18574) [Analytics] Fix example documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-18574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18574: -- Reviewers: Dinesh Joshi, Yifan Cai (was: Yifan Cai) > [Analytics] Fix example documentation > -- > > Key: CASSANDRA-18574 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18574 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Low > Time Spent: 10m > Remaining Estimate: 0h > > The documentation for the example job for Cassandra Analytics > [link|https://github.com/apache/cassandra-analytics/blob/trunk/cassandra-analytics-core-example/README.md] > configures Sidecar to use the local CCM cluster. This documentation is > however broken since some feedback during the review of the Sidecar PR > changed one of the yaml options from {{uploads_staging_dir}} to > {{staging_dir}}. > We need to update the documentation to reflect that change. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18600) [Analytics] Add NOTICE.txt in Cassandra Analytics
[ https://issues.apache.org/jira/browse/CASSANDRA-18600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18600: -- Fix Version/s: NA (was: 5.0) > [Analytics] Add NOTICE.txt in Cassandra Analytics > -- > > Key: CASSANDRA-18600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18600 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Fix For: NA > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Cassandra Analytics project is missing the {{NOTICE.txt}} file required > for compliance with the ASF guidance -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-58) Support retries in Sidecar Client when MD5 checksum is mismatched
[ https://issues.apache.org/jira/browse/CASSANDRASC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-58: - Fix Version/s: 1.0 Source Control Link: https://github.com/apache/cassandra-sidecar/commit/ab1884d2eedace79857489cb9dbe455ada9e4ad1 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Support retries in Sidecar Client when MD5 checksum is mismatched > - > > Key: CASSANDRASC-58 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-58 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > In rare occasions an SSTable upload will get corrupted during upload. Bit > flips are expected to occur occasionally while transmitting the SSTables from > the client to the server. The current behavior of the Sidecar Client in those > situations is to fail fast without any retries. > We want to support Sidecar Client retries when checksum mismatch occurs > during SSTable upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-58) Support retries in Sidecar Client when MD5 checksum is mismatched
[ https://issues.apache.org/jira/browse/CASSANDRASC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737871#comment-17737871 ] ASF subversion and git services commented on CASSANDRASC-58: Commit ab1884d2eedace79857489cb9dbe455ada9e4ad1 in cassandra-sidecar's branch refs/heads/trunk from Francisco Guerrero [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=ab1884d ] CASSANDRASC-58: Support retries in Sidecar Client on Invalid Checksum In rare occasions an SSTable upload will receive a corrupted SSTable. Bit flips are expected to occur occassionally while transmitting SSTables from client to server. This commit adds support for retries in Sidecar Client when a checksum mismatch is encountered during SSTable upload. Allowing for clients to retry patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-58 > Support retries in Sidecar Client when MD5 checksum is mismatched > - > > Key: CASSANDRASC-58 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-58 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > In rare occasions an SSTable upload will get corrupted during upload. Bit > flips are expected to occur occasionally while transmitting the SSTables from > the client to the server. The current behavior of the Sidecar Client in those > situations is to fail fast without any retries. > We want to support Sidecar Client retries when checksum mismatch occurs > during SSTable upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch trunk updated: CASSANDRASC-58: Support retries in Sidecar Client on Invalid Checksum
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git The following commit(s) were added to refs/heads/trunk by this push: new ab1884d CASSANDRASC-58: Support retries in Sidecar Client on Invalid Checksum ab1884d is described below commit ab1884d2eedace79857489cb9dbe455ada9e4ad1 Author: Francisco Guerrero AuthorDate: Thu Jun 22 10:52:10 2023 -0700 CASSANDRASC-58: Support retries in Sidecar Client on Invalid Checksum In rare occasions an SSTable upload will receive a corrupted SSTable. Bit flips are expected to occur occassionally while transmitting SSTables from client to server. This commit adds support for retries in Sidecar Client when a checksum mismatch is encountered during SSTable upload. Allowing for clients to retry patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-58 --- CHANGES.txt| 1 + build.gradle | 1 + .../sidecar/client/retry/BasicRetryPolicy.java | 16 .../sidecar/client/retry/BasicRetryPolicyTest.java | 13 +- common/build.gradle| 2 + .../common/http/SidecarHttpResponseStatus.java | 48 ++ .../common/http/SidecarHttpResponseStatusTest.java | 38 + docs/build.gradle | 12 +- .../sidecar/utils/MD5ChecksumVerifier.java | 5 ++- .../sstableuploads/SSTableUploadHandlerTest.java | 4 +- 10 files changed, 124 insertions(+), 16 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index b4f59b6..f7626e1 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,6 @@ 1.0.0 - + * Support retries in Sidecar Client on Invalid Checksum (CASSANDRASC-58) * Ignore unknown properties during Sidecar client deserialization (CASSANDRASC-53) * Create staging directory if it doesn't exists (CASSANDRASC-56) * Remove RESTEasy (CASSANDRASC-57) diff --git a/build.gradle b/build.gradle index 055cd28..dd07dfe 100644 --- a/build.gradle +++ b/build.gradle @@ -22,6 +22,7 @@ plugins { id "nebula.ospackage" version "8.3.0" id 'nebula.ospackage-application' version "8.3.0" id 'com.google.cloud.tools.jib' version '2.2.0' +id 'org.asciidoctor.jvm.convert' version '3.1.0' } ext.dtestJar = System.getenv("DTEST_JAR") ?: "dtest-5.0.jar" // trunk is currently 5.0.jar - update when trunk moves diff --git a/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java b/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java index 6b8d3dd..1eb3719 100644 --- a/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java +++ b/client/src/main/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicy.java @@ -27,6 +27,7 @@ import io.netty.handler.codec.http.HttpStatusClass; import org.apache.cassandra.sidecar.client.HttpResponse; import org.apache.cassandra.sidecar.client.exception.ResourceNotFoundException; import org.apache.cassandra.sidecar.client.request.Request; +import org.apache.cassandra.sidecar.common.http.SidecarHttpResponseStatus; /** * A basic {@link RetryPolicy} supporting standard status codes @@ -145,6 +146,21 @@ public class BasicRetryPolicy extends RetryPolicy return; } +if (response.statusCode() == SidecarHttpResponseStatus.CHECKSUM_MISMATCH.code()) +{ +// assume that the uploaded payload might have been corrupted, so allow for retries when an invalid +// checksum is encountered +if (canRetryOnADifferentHost) +{ +retryImmediately(responseFuture, request, retryAction, attempts, throwable); +} +else +{ +retry(responseFuture, request, retryAction, attempts, throwable); +} +return; +} + // 4xx Client Errors - 5xx Server Errors if (HttpStatusClass.CLIENT_ERROR.contains(response.statusCode()) || HttpStatusClass.SERVER_ERROR.contains(response.statusCode())) diff --git a/client/src/test/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicyTest.java b/client/src/test/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicyTest.java index 591e364..58b9c3b 100644 --- a/client/src/test/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicyTest.java +++ b/client/src/test/java/org/apache/cassandra/sidecar/client/retry/BasicRetryPolicyTest.java @@ -36,7 +36,6 @@ import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; import org.junit.jupiter.params.provider.ValueSource; -import io.netty.handler.codec.http.HttpResponseStatus; import org.apache.cassandra.sidecar.client.HttpRes
[jira] [Commented] (CASSANDRASC-58) Support retries in Sidecar Client when MD5 checksum is mismatched
[ https://issues.apache.org/jira/browse/CASSANDRASC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737868#comment-17737868 ] Yifan Cai commented on CASSANDRASC-58: -- I gave +1 on the GH page. Comment here as well. > Support retries in Sidecar Client when MD5 checksum is mismatched > - > > Key: CASSANDRASC-58 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-58 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > In rare occasions an SSTable upload will get corrupted during upload. Bit > flips are expected to occur occasionally while transmitting the SSTables from > the client to the server. The current behavior of the Sidecar Client in those > situations is to fail fast without any retries. > We want to support Sidecar Client retries when checksum mismatch occurs > during SSTable upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-58) Support retries in Sidecar Client when MD5 checksum is mismatched
[ https://issues.apache.org/jira/browse/CASSANDRASC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-58: - Reviewers: Dinesh Joshi, Yifan Cai Status: Review In Progress (was: Patch Available) > Support retries in Sidecar Client when MD5 checksum is mismatched > - > > Key: CASSANDRASC-58 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-58 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > In rare occasions an SSTable upload will get corrupted during upload. Bit > flips are expected to occur occasionally while transmitting the SSTables from > the client to the server. The current behavior of the Sidecar Client in those > situations is to fail fast without any retries. > We want to support Sidecar Client retries when checksum mismatch occurs > during SSTable upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-58) Support retries in Sidecar Client when MD5 checksum is mismatched
[ https://issues.apache.org/jira/browse/CASSANDRASC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-58: - Status: Ready to Commit (was: Review In Progress) > Support retries in Sidecar Client when MD5 checksum is mismatched > - > > Key: CASSANDRASC-58 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-58 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > In rare occasions an SSTable upload will get corrupted during upload. Bit > flips are expected to occur occasionally while transmitting the SSTables from > the client to the server. The current behavior of the Sidecar Client in those > situations is to fail fast without any retries. > We want to support Sidecar Client retries when checksum mismatch occurs > during SSTable upload. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-53) [Sidecar Client] Allow unknown fields in the response
[ https://issues.apache.org/jira/browse/CASSANDRASC-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-53: - Fix Version/s: 1.0 Source Control Link: https://github.com/apache/cassandra-sidecar/commit/3cbb3d19c6f043b3a20e4933e5ff7a0e3d58f0a9 Resolution: Fixed Status: Resolved (was: Ready to Commit) > [Sidecar Client] Allow unknown fields in the response > - > > Key: CASSANDRASC-53 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-53 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > While testing CASSANDRASC-52 on the server side, the Sidecar client based off > of {{trunk}} failed to deserialize the JSON payload with error > {code:java} > Caused by: > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: > Unrecognized field "sidecar" (class > org.apache.cassandra.sidecar.common.NodeSettings), not marked as ignorable (2 > known properties: "releaseVersion", "partitioner"]) > at [Source: > (byte[])"{"releaseVersion":"4.0.9-SNAPSHOT","partitioner":"org.apache.cassandra.dht.Murmur3Partitioner","sidecar":{"version":"1.0-SNAPSHOT"}}"; > line: 1, column: 107] (through reference chain: > org.apache.cassandra.sidecar.common.NodeSettings["sidecar"]) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1132) > {code} > As we are evolving the code, we expect the API on the server side to evolve. > The deployed clients need to tolerate these new fields in the response JSON > payload to continue working correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-53) [Sidecar Client] Allow unknown fields in the response
[ https://issues.apache.org/jira/browse/CASSANDRASC-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-53: - Status: Ready to Commit (was: Review In Progress) > [Sidecar Client] Allow unknown fields in the response > - > > Key: CASSANDRASC-53 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-53 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > While testing CASSANDRASC-52 on the server side, the Sidecar client based off > of {{trunk}} failed to deserialize the JSON payload with error > {code:java} > Caused by: > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: > Unrecognized field "sidecar" (class > org.apache.cassandra.sidecar.common.NodeSettings), not marked as ignorable (2 > known properties: "releaseVersion", "partitioner"]) > at [Source: > (byte[])"{"releaseVersion":"4.0.9-SNAPSHOT","partitioner":"org.apache.cassandra.dht.Murmur3Partitioner","sidecar":{"version":"1.0-SNAPSHOT"}}"; > line: 1, column: 107] (through reference chain: > org.apache.cassandra.sidecar.common.NodeSettings["sidecar"]) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1132) > {code} > As we are evolving the code, we expect the API on the server side to evolve. > The deployed clients need to tolerate these new fields in the response JSON > payload to continue working correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-53) [Sidecar Client] Allow unknown fields in the response
[ https://issues.apache.org/jira/browse/CASSANDRASC-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737867#comment-17737867 ] ASF subversion and git services commented on CASSANDRASC-53: Commit 3cbb3d19c6f043b3a20e4933e5ff7a0e3d58f0a9 in cassandra-sidecar's branch refs/heads/trunk from Francisco Guerrero [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=3cbb3d1 ] CASSANDRASC-53 Ignore unknown properties during Sidecar client deserialization This commit modifies the way the `DecodableRequest` handles unknown properties in the JSON payload. To support the evolution of the server API, we allow the Sidecar Client to be more flexible when it encounters unknown properties, and we make it ignore these new properties. patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-53 > [Sidecar Client] Allow unknown fields in the response > - > > Key: CASSANDRASC-53 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-53 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > While testing CASSANDRASC-52 on the server side, the Sidecar client based off > of {{trunk}} failed to deserialize the JSON payload with error > {code:java} > Caused by: > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: > Unrecognized field "sidecar" (class > org.apache.cassandra.sidecar.common.NodeSettings), not marked as ignorable (2 > known properties: "releaseVersion", "partitioner"]) > at [Source: > (byte[])"{"releaseVersion":"4.0.9-SNAPSHOT","partitioner":"org.apache.cassandra.dht.Murmur3Partitioner","sidecar":{"version":"1.0-SNAPSHOT"}}"; > line: 1, column: 107] (through reference chain: > org.apache.cassandra.sidecar.common.NodeSettings["sidecar"]) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1132) > {code} > As we are evolving the code, we expect the API on the server side to evolve. > The deployed clients need to tolerate these new fields in the response JSON > payload to continue working correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch trunk updated: CASSANDRASC-53 Ignore unknown properties during Sidecar client deserialization
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git The following commit(s) were added to refs/heads/trunk by this push: new 3cbb3d1 CASSANDRASC-53 Ignore unknown properties during Sidecar client deserialization 3cbb3d1 is described below commit 3cbb3d19c6f043b3a20e4933e5ff7a0e3d58f0a9 Author: Francisco Guerrero AuthorDate: Mon Jun 12 09:34:45 2023 -0700 CASSANDRASC-53 Ignore unknown properties during Sidecar client deserialization This commit modifies the way the `DecodableRequest` handles unknown properties in the JSON payload. To support the evolution of the server API, we allow the Sidecar Client to be more flexible when it encounters unknown properties, and we make it ignore these new properties. patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-53 --- CHANGES.txt| 1 + .../sidecar/client/request/DecodableRequest.java | 5 +- .../client/request/DecodableRequestTest.java | 81 ++ 3 files changed, 86 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 7131a8b..b4f59b6 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,6 @@ 1.0.0 - + * Ignore unknown properties during Sidecar client deserialization (CASSANDRASC-53) * Create staging directory if it doesn't exists (CASSANDRASC-56) * Remove RESTEasy (CASSANDRASC-57) * Use in-jvm dtest framework for integration tests (CASSANDRASC-51) diff --git a/client/src/main/java/org/apache/cassandra/sidecar/client/request/DecodableRequest.java b/client/src/main/java/org/apache/cassandra/sidecar/client/request/DecodableRequest.java index 90e93bd..f9fec27 100644 --- a/client/src/main/java/org/apache/cassandra/sidecar/client/request/DecodableRequest.java +++ b/client/src/main/java/org/apache/cassandra/sidecar/client/request/DecodableRequest.java @@ -24,6 +24,7 @@ import java.util.Collections; import java.util.HashMap; import java.util.Map; +import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.JavaType; import com.fasterxml.jackson.databind.ObjectMapper; @@ -34,7 +35,9 @@ import com.fasterxml.jackson.databind.ObjectMapper; */ public abstract class DecodableRequest extends Request { -static final ObjectMapper MAPPER = new ObjectMapper(); +static final ObjectMapper MAPPER = new ObjectMapper() + // ignore all the properties that are not declared + .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); private final JavaType javaType = MAPPER.constructType(((ParameterizedType) this.getClass().getGenericSuperclass()) .getActualTypeArguments()[0]); diff --git a/client/src/test/java/org/apache/cassandra/sidecar/client/request/DecodableRequestTest.java b/client/src/test/java/org/apache/cassandra/sidecar/client/request/DecodableRequestTest.java new file mode 100644 index 000..e37dc9a --- /dev/null +++ b/client/src/test/java/org/apache/cassandra/sidecar/client/request/DecodableRequestTest.java @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.client.request; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import io.netty.handler.codec.http.HttpMethod; +import org.apache.cassandra.sidecar.common.NodeSettings; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatExceptionOfType; + +/** + * Unit tests for the {@link DecodableRequest} class + */ +class DecodableRequestTest +{ +DecodableRequest instance; + +@BeforeEach +void setup() +{ +instance = new DecodableRequest("https://cassandra-sidecar.com/api/test";) +{ +@Override +public HttpMethod method() +{ +return HttpMeth
[jira] [Updated] (CASSANDRASC-53) [Sidecar Client] Allow unknown fields in the response
[ https://issues.apache.org/jira/browse/CASSANDRASC-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-53: - Reviewers: Dinesh Joshi, Yifan Cai Status: Review In Progress (was: Patch Available) > [Sidecar Client] Allow unknown fields in the response > - > > Key: CASSANDRASC-53 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-53 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > While testing CASSANDRASC-52 on the server side, the Sidecar client based off > of {{trunk}} failed to deserialize the JSON payload with error > {code:java} > Caused by: > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: > Unrecognized field "sidecar" (class > org.apache.cassandra.sidecar.common.NodeSettings), not marked as ignorable (2 > known properties: "releaseVersion", "partitioner"]) > at [Source: > (byte[])"{"releaseVersion":"4.0.9-SNAPSHOT","partitioner":"org.apache.cassandra.dht.Murmur3Partitioner","sidecar":{"version":"1.0-SNAPSHOT"}}"; > line: 1, column: 107] (through reference chain: > org.apache.cassandra.sidecar.common.NodeSettings["sidecar"]) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61) > at > o.a.c.sidecar.client.shaded.com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1132) > {code} > As we are evolving the code, we expect the API on the server side to evolve. > The deployed clients need to tolerate these new fields in the response JSON > payload to continue working correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-56) Create staging directory if it doesn't exists
[ https://issues.apache.org/jira/browse/CASSANDRASC-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-56: - Fix Version/s: 1.0 Source Control Link: https://github.com/apache/cassandra-sidecar/commit/9912a620a0e67d9aa723037aaf5237598a895eb7 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Create staging directory if it doesn't exists > - > > Key: CASSANDRASC-56 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-56 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > Fix For: 1.0 > > > During SSTable upload, the upload will fail if the configured staging > directory does not exist. When this occurs we must manually have to create > the directory, which increases the configuration toil. To improve the > experience, it is desired that Sidecar creates the staging directory if it > doesn't exist. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-56) Create staging directory if it doesn't exists
[ https://issues.apache.org/jira/browse/CASSANDRASC-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737866#comment-17737866 ] ASF subversion and git services commented on CASSANDRASC-56: Commit 9912a620a0e67d9aa723037aaf5237598a895eb7 in cassandra-sidecar's branch refs/heads/trunk from Francisco Guerrero [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=9912a62 ] CASSANDRASC-56: Create staging directory if it doesn't exists During SSTable upload, the upload will fail if the configured staging directory does not exist. When this occurs an operator must manually create the directory, which increases the configuration toil. In this commit, we automatically create the staging directory if it doesn't exists during SSTable upload. This improves the overall operational experience when running the Sidecar. patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-56 > Create staging directory if it doesn't exists > - > > Key: CASSANDRASC-56 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-56 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > During SSTable upload, the upload will fail if the configured staging > directory does not exist. When this occurs we must manually have to create > the directory, which increases the configuration toil. To improve the > experience, it is desired that Sidecar creates the staging directory if it > doesn't exist. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch trunk updated: CASSANDRASC-56: Create staging directory if it doesn't exists
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git The following commit(s) were added to refs/heads/trunk by this push: new 9912a62 CASSANDRASC-56: Create staging directory if it doesn't exists 9912a62 is described below commit 9912a620a0e67d9aa723037aaf5237598a895eb7 Author: Francisco Guerrero AuthorDate: Mon Jun 19 16:41:10 2023 -0700 CASSANDRASC-56: Create staging directory if it doesn't exists During SSTable upload, the upload will fail if the configured staging directory does not exist. When this occurs an operator must manually create the directory, which increases the configuration toil. In this commit, we automatically create the staging directory if it doesn't exists during SSTable upload. This improves the overall operational experience when running the Sidecar. patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRASC-56 --- CHANGES.txt| 1 + .../sstableuploads/SSTableCleanupHandler.java | 2 +- .../sstableuploads/SSTableImportHandler.java | 52 -- .../sstableuploads/SSTableUploadHandler.java | 18 .../cassandra/sidecar/utils/BaseFileSystem.java| 11 + .../cassandra/sidecar/utils/SSTableImporter.java | 2 +- .../sidecar/utils/SSTableUploadsPathBuilder.java | 23 +++--- .../sstableuploads/SSTableImportHandlerTest.java | 13 -- .../sstableuploads/SSTableUploadHandlerTest.java | 17 --- .../sidecar/utils/SSTableImporterTest.java | 2 +- 10 files changed, 77 insertions(+), 64 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 86f8bf0..7131a8b 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,6 @@ 1.0.0 - + * Create staging directory if it doesn't exists (CASSANDRASC-56) * Remove RESTEasy (CASSANDRASC-57) * Use in-jvm dtest framework for integration tests (CASSANDRASC-51) * Sidecar returns own version in node settings (CASSANDRASC-52) diff --git a/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableCleanupHandler.java b/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableCleanupHandler.java index 849fd3d..bffb9a5 100644 --- a/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableCleanupHandler.java +++ b/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableCleanupHandler.java @@ -66,7 +66,7 @@ public class SSTableCleanupHandler extends AbstractHandler SocketAddress remoteAddress, String uploadId) { -uploadPathBuilder.resolveStagingDirectory(host, uploadId) +uploadPathBuilder.resolveUploadIdDirectory(host, uploadId) .compose(uploadPathBuilder::isValidDirectory) .compose(stagingDirectory -> context.vertx() .fileSystem() diff --git a/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableImportHandler.java b/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableImportHandler.java index c5d5695..75f8049 100644 --- a/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableImportHandler.java +++ b/src/main/java/org/apache/cassandra/sidecar/routes/sstableuploads/SSTableImportHandler.java @@ -109,7 +109,7 @@ public class SSTableImportHandler extends AbstractHandler } else if (importResult.failed()) { - context.fail(importResult.cause()); + processFailure(importResult.cause(), context, host, remoteAddress, request); } else { @@ -121,29 +121,33 @@ public class SSTableImportHandler extends AbstractHandler request, remoteAddress, host); } }) - .onFailure(cause -> { - if (cause instanceof NoSuchFileException) - { - logger.error("Upload directory not found for request={}, remoteAddress={}, " + - "instance={}", request, remoteAddress, host, cause); - context.fail(wrapHttpException(HttpResponseStatus.NOT_FOUND, cause.getMessage())); - } - else if (cause instanceof IllegalArgumentException) - { - context.fail(wrapHttpException(HttpResponseStatus.BAD_REQUEST, cause.getMessage(), -
[jira] [Commented] (CASSANDRASC-56) Create staging directory if it doesn't exists
[ https://issues.apache.org/jira/browse/CASSANDRASC-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737864#comment-17737864 ] Yifan Cai commented on CASSANDRASC-56: -- +1 on the patch > Create staging directory if it doesn't exists > - > > Key: CASSANDRASC-56 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-56 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > During SSTable upload, the upload will fail if the configured staging > directory does not exist. When this occurs we must manually have to create > the directory, which increases the configuration toil. To improve the > experience, it is desired that Sidecar creates the staging directory if it > doesn't exist. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-56) Create staging directory if it doesn't exists
[ https://issues.apache.org/jira/browse/CASSANDRASC-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-56: - Status: Ready to Commit (was: Review In Progress) > Create staging directory if it doesn't exists > - > > Key: CASSANDRASC-56 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-56 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > During SSTable upload, the upload will fail if the configured staging > directory does not exist. When this occurs we must manually have to create > the directory, which increases the configuration toil. To improve the > experience, it is desired that Sidecar creates the staging directory if it > doesn't exist. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-56) Create staging directory if it doesn't exists
[ https://issues.apache.org/jira/browse/CASSANDRASC-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-56: - Reviewers: Dinesh Joshi, Yifan Cai Status: Review In Progress (was: Patch Available) > Create staging directory if it doesn't exists > - > > Key: CASSANDRASC-56 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-56 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > During SSTable upload, the upload will fail if the configured staging > directory does not exist. When this occurs we must manually have to create > the directory, which increases the configuration toil. To improve the > experience, it is desired that Sidecar creates the staging directory if it > doesn't exist. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[ https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17914: -- Reviewers: Stefan Miklosovic > Argparse migration as the Python Optparse library is deprecated > --- > > Key: CASSANDRA-17914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17914 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > > [Deprecated since version 2.7: The optparse module is deprecated and will not > be developed further; development will continue with the argparse > module.|https://docs.python.org/2/library/optparse.html] > Argparse is described in [PEP 389 – argparse - New Command Line Parsing > Module|https://peps.python.org/pep-0389/] > > A partial upgrade path from > [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse] > to > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]: > https://docs.python.org/3/library/argparse.html#upgrading-optparse-code > * Replace all > [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option] > calls with > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls. > * Replace {{(options, args) = parser.parse_args()}} with {{args = > parser.parse_args()}} and add additional > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls for the positional arguments. Keep in mind that what was previously > called {{{}options{}}}, now in the > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse] > context is called {{{}args{}}}. > * Replace > [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args] > by using > [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args] > instead of > [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args]. > * Replace callback actions and the {{callback_*}} keyword arguments with > {{type}} or {{action}} arguments. > * Replace string names for {{type}} keyword arguments with the corresponding > type objects (e.g. int, float, complex, etc). > * Replace {{optparse.Values}} with > [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace] > and {{optparse.OptionError}} and {{optparse.OptionValueError}} with > {{{}ArgumentError{}}}. > * Replace strings with implicit arguments such as {{%default}} or {{%prog}} > with the standard Python syntax to use dictionaries to format strings, that > is, {{%(default)s}} and {{{}%(prog)s{}}}. > * Replace the OptionParser constructor {{version}} argument with a call to > {{{}parser.add_argument('--version', action='version', version=' version>'){}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[ https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737862#comment-17737862 ] Stefan Miklosovic edited comment on CASSANDRA-17914 at 6/27/23 7:57 PM: ML link for reference https://lists.apache.org/thread/14wlyv2skmkn6jlg9ojh134c3p20ypg8 was (Author: smiklosovic): [~bschoeni] Can you link the ML thread please? https://lists.apache.org/list.html?d...@cassandra.apache.org > Argparse migration as the Python Optparse library is deprecated > --- > > Key: CASSANDRA-17914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17914 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > > [Deprecated since version 2.7: The optparse module is deprecated and will not > be developed further; development will continue with the argparse > module.|https://docs.python.org/2/library/optparse.html] > Argparse is described in [PEP 389 – argparse - New Command Line Parsing > Module|https://peps.python.org/pep-0389/] > > A partial upgrade path from > [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse] > to > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]: > https://docs.python.org/3/library/argparse.html#upgrading-optparse-code > * Replace all > [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option] > calls with > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls. > * Replace {{(options, args) = parser.parse_args()}} with {{args = > parser.parse_args()}} and add additional > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls for the positional arguments. Keep in mind that what was previously > called {{{}options{}}}, now in the > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse] > context is called {{{}args{}}}. > * Replace > [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args] > by using > [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args] > instead of > [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args]. > * Replace callback actions and the {{callback_*}} keyword arguments with > {{type}} or {{action}} arguments. > * Replace string names for {{type}} keyword arguments with the corresponding > type objects (e.g. int, float, complex, etc). > * Replace {{optparse.Values}} with > [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace] > and {{optparse.OptionError}} and {{optparse.OptionValueError}} with > {{{}ArgumentError{}}}. > * Replace strings with implicit arguments such as {{%default}} or {{%prog}} > with the standard Python syntax to use dictionaries to format strings, that > is, {{%(default)s}} and {{{}%(prog)s{}}}. > * Replace the OptionParser constructor {{version}} argument with a call to > {{{}parser.add_argument('--version', action='version', version=' version>'){}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[ https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737862#comment-17737862 ] Stefan Miklosovic commented on CASSANDRA-17914: --- [~bschoeni] Can you link the ML thread please? https://lists.apache.org/list.html?d...@cassandra.apache.org > Argparse migration as the Python Optparse library is deprecated > --- > > Key: CASSANDRA-17914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17914 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > > [Deprecated since version 2.7: The optparse module is deprecated and will not > be developed further; development will continue with the argparse > module.|https://docs.python.org/2/library/optparse.html] > Argparse is described in [PEP 389 – argparse - New Command Line Parsing > Module|https://peps.python.org/pep-0389/] > > A partial upgrade path from > [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse] > to > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]: > https://docs.python.org/3/library/argparse.html#upgrading-optparse-code > * Replace all > [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option] > calls with > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls. > * Replace {{(options, args) = parser.parse_args()}} with {{args = > parser.parse_args()}} and add additional > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls for the positional arguments. Keep in mind that what was previously > called {{{}options{}}}, now in the > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse] > context is called {{{}args{}}}. > * Replace > [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args] > by using > [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args] > instead of > [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args]. > * Replace callback actions and the {{callback_*}} keyword arguments with > {{type}} or {{action}} arguments. > * Replace string names for {{type}} keyword arguments with the corresponding > type objects (e.g. int, float, complex, etc). > * Replace {{optparse.Values}} with > [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace] > and {{optparse.OptionError}} and {{optparse.OptionValueError}} with > {{{}ArgumentError{}}}. > * Replace strings with implicit arguments such as {{%default}} or {{%prog}} > with the standard Python syntax to use dictionaries to format strings, that > is, {{%(default)s}} and {{{}%(prog)s{}}}. > * Replace the OptionParser constructor {{version}} argument with a call to > {{{}parser.add_argument('--version', action='version', version=' version>'){}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18630) jackson-databind-2.13.2.2.jar vulnerability: CVE-2023-35116
[ https://issues.apache.org/jira/browse/CASSANDRA-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737836#comment-17737836 ] Brandon Williams commented on CASSANDRA-18630: -- Reading through the issue [here|https://github.com/FasterXML/jackson-databind/issues/3972] I don't think we need to worry about this and this probably shouldn't have been a CVE. Patches to suppress: ||Branch||CI|| |[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18630-3.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1094/workflows/890d2bff-1c0c-4d92-9c2f-1db6dfcc28fa]| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-18630-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1096/workflows/8be147be-3cba-4912-8786-522c19feb623]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18630-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1092/workflows/361235e2-b54c-470f-bf00-4b5bcb631d7c], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1092/workflows/2eb95096-fede-4f7d-9c1b-adffe161ad74]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18630-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1093/workflows/bb1b1b46-9738-4b74-bcc7-c2fefeb7f737], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1093/workflows/6de7df6f-9b5f-4ec1-94ef-d3357d9604df]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18630-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1095/workflows/6114e2e3-8dcc-4bb0-b664-ae7d82c3349f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1095/workflows/d1b2651a-4428-4473-a120-ec655ecfd8c9]| > jackson-databind-2.13.2.2.jar vulnerability: CVE-2023-35116 > --- > > Key: CASSANDRA-18630 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18630 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > https://nvd.nist.gov/vuln/detail/CVE-2023-35116 > {noformat} > An issue was discovered jackson-databind thru 2.15.2 allows attackers to > cause a denial of service or other unspecified impacts via crafted object > that uses cyclic dependencies. NOTE: the vendor's perspective is that the > product is not intended for use with untrusted input. > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[ https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737828#comment-17737828 ] Brad Schoening edited comment on CASSANDRA-17914 at 6/27/23 6:38 PM: - [~stefan.miklosovic] would you be able to review this PR? Note: I did ask the mailing list back on Sept 29 2022 and there were no objections to changing from the deprecated library here to argparse. was (Author: bschoeni): [~stefan.miklosovic] would you be able to review this PR? > Argparse migration as the Python Optparse library is deprecated > --- > > Key: CASSANDRA-17914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17914 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > > [Deprecated since version 2.7: The optparse module is deprecated and will not > be developed further; development will continue with the argparse > module.|https://docs.python.org/2/library/optparse.html] > Argparse is described in [PEP 389 – argparse - New Command Line Parsing > Module|https://peps.python.org/pep-0389/] > > A partial upgrade path from > [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse] > to > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]: > https://docs.python.org/3/library/argparse.html#upgrading-optparse-code > * Replace all > [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option] > calls with > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls. > * Replace {{(options, args) = parser.parse_args()}} with {{args = > parser.parse_args()}} and add additional > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls for the positional arguments. Keep in mind that what was previously > called {{{}options{}}}, now in the > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse] > context is called {{{}args{}}}. > * Replace > [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args] > by using > [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args] > instead of > [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args]. > * Replace callback actions and the {{callback_*}} keyword arguments with > {{type}} or {{action}} arguments. > * Replace string names for {{type}} keyword arguments with the corresponding > type objects (e.g. int, float, complex, etc). > * Replace {{optparse.Values}} with > [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace] > and {{optparse.OptionError}} and {{optparse.OptionValueError}} with > {{{}ArgumentError{}}}. > * Replace strings with implicit arguments such as {{%default}} or {{%prog}} > with the standard Python syntax to use dictionaries to format strings, that > is, {{%(default)s}} and {{{}%(prog)s{}}}. > * Replace the OptionParser constructor {{version}} argument with a call to > {{{}parser.add_argument('--version', action='version', version=' version>'){}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[ https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737828#comment-17737828 ] Brad Schoening commented on CASSANDRA-17914: [~stefan.miklosovic] would you be able to review this PR? > Argparse migration as the Python Optparse library is deprecated > --- > > Key: CASSANDRA-17914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17914 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > > [Deprecated since version 2.7: The optparse module is deprecated and will not > be developed further; development will continue with the argparse > module.|https://docs.python.org/2/library/optparse.html] > Argparse is described in [PEP 389 – argparse - New Command Line Parsing > Module|https://peps.python.org/pep-0389/] > > A partial upgrade path from > [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse] > to > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]: > https://docs.python.org/3/library/argparse.html#upgrading-optparse-code > * Replace all > [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option] > calls with > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls. > * Replace {{(options, args) = parser.parse_args()}} with {{args = > parser.parse_args()}} and add additional > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls for the positional arguments. Keep in mind that what was previously > called {{{}options{}}}, now in the > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse] > context is called {{{}args{}}}. > * Replace > [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args] > by using > [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args] > instead of > [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args]. > * Replace callback actions and the {{callback_*}} keyword arguments with > {{type}} or {{action}} arguments. > * Replace string names for {{type}} keyword arguments with the corresponding > type objects (e.g. int, float, complex, etc). > * Replace {{optparse.Values}} with > [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace] > and {{optparse.OptionError}} and {{optparse.OptionValueError}} with > {{{}ArgumentError{}}}. > * Replace strings with implicit arguments such as {{%default}} or {{%prog}} > with the standard Python syntax to use dictionaries to format strings, that > is, {{%(default)s}} and {{{}%(prog)s{}}}. > * Replace the OptionParser constructor {{version}} argument with a call to > {{{}parser.add_argument('--version', action='version', version=' version>'){}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737825#comment-17737825 ] Dinesh Joshi commented on CASSANDRA-18631: -- +1, thanks. > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-18631: --- Test and Documentation Plan: No tests were added as part of this PR Status: Patch Available (was: In Progress) PR: https://github.com/apache/cassandra-analytics/pull/8 CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-analytics/14 > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18616) Simulator Java 17 support
[ https://issues.apache.org/jira/browse/CASSANDRA-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18616: Status: In Progress (was: Patch Available) > Simulator Java 17 support > - > > Key: CASSANDRA-18616 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18616 > Project: Cassandra > Issue Type: Task > Components: Test/fuzz >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > Add Java 17 support for the simulator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh opened a new pull request, #8: CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics
frankgh opened a new pull request, #8: URL: https://github.com/apache/cassandra-analytics/pull/8 This commit adds the Release Audit Tool (RAT) plugin to `build.gradle` which adds a new task `rat`. This new task makes sure that the license headers are valid and present in the source files during the `check` task. To run the RAT plugin, you can run: ``` ./gradlew rat ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-18631: --- Change Category: Semantic Complexity: Low Hanging Fruit Component/s: Analytics Library Status: Open (was: Triage Needed) > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
Francisco Guerrero created CASSANDRA-18631: -- Summary: [Cassandra Analytics] Add Release Audit Tool (RAT) plugin Key: CASSANDRA-18631 URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 Project: Cassandra Issue Type: Improvement Reporter: Francisco Guerrero Assignee: Francisco Guerrero Add the Release Audit Tool plugin to Cassandra Analytics to automate the {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18629) BLOG - Clarify wording on 3.x EOL post
[ https://issues.apache.org/jira/browse/CASSANDRA-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick McFadin updated CASSANDRA-18629: Source Control Link: https://github.com/apache/cassandra-website/commit/898aa3ff0d702a961f6a139eaf0562ea5ab2cce2 Resolution: Fixed Status: Resolved (was: Ready to Commit) > BLOG - Clarify wording on 3.x EOL post > -- > > Key: CASSANDRA-18629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18629 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Patrick McFadin >Assignee: Patrick McFadin >Priority: Normal > Fix For: NA > > Attachments: c18629-01-blog-index.png, c18629-02-blog-post.png > > > CASSANDRA-18531 generated some confusion so attempting to clean up the > wording. > https://cassandra.apache.org/_/blog/Apache-Cassandra-3.0.x-and-3.11.x-End-of-Life-Announcement.html -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15241) Virtual table to expose current running queries
[ https://issues.apache.org/jira/browse/CASSANDRA-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737808#comment-17737808 ] Maxim Muzafarov commented on CASSANDRA-15241: - [~maedhroz] leaving the commit 'as is' is the best state we've reached :-) So, I'm happy to proceed with this. > Virtual table to expose current running queries > --- > > Key: CASSANDRA-15241 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15241 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Expose current running queries and their duration. > {code}cqlsh> select * from system_views.queries; > thread_id| duration_micros | task > --+-+- > Native-Transport-Requests-17 |6325 | QUERY > select * from system_views.queries; [pageSize = 100] > Native-Transport-Requests-4 | 14681 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > Native-Transport-Requests-6 | 14678 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > ReadStage-10 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-13 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-14 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-19 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-20 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-22 |7279 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-23 |4716 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-5 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-7 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-8 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000{code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh closed pull request #6: CASSANDRA-18600 Add NOTICE.txt file
frankgh closed pull request #6: CASSANDRA-18600 Add NOTICE.txt file URL: https://github.com/apache/cassandra-analytics/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh commented on pull request #6: CASSANDRA-18600 Add NOTICE.txt file
frankgh commented on PR #6: URL: https://github.com/apache/cassandra-analytics/pull/6#issuecomment-1609908559 Closed by https://github.com/apache/cassandra-analytics/commit/cbae09ca71b9eb9a581b77c23844da21474b095a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18629) BLOG - Clarify wording on 3.x EOL post
[ https://issues.apache.org/jira/browse/CASSANDRA-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737788#comment-17737788 ] Patrick McFadin commented on CASSANDRA-18629: - Pushed to asf-site and successfully deployed https://cassandra.apache.org/_/blog/Apache-Cassandra-3.0.x-and-3.11.x-End-of-Life-Announcement.html > BLOG - Clarify wording on 3.x EOL post > -- > > Key: CASSANDRA-18629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18629 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Patrick McFadin >Assignee: Patrick McFadin >Priority: Normal > Fix For: NA > > Attachments: c18629-01-blog-index.png, c18629-02-blog-post.png > > > CASSANDRA-18531 generated some confusion so attempting to clean up the > wording. > https://cassandra.apache.org/_/blog/Apache-Cassandra-3.0.x-and-3.11.x-End-of-Life-Announcement.html -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18629) BLOG - Clarify wording on 3.x EOL post
[ https://issues.apache.org/jira/browse/CASSANDRA-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737786#comment-17737786 ] Patrick McFadin commented on CASSANDRA-18629: - Successfully staged [https://cassandra.staged.apache.org/_/blog/Apache-Cassandra-3.0.x-and-3.11.x-End-of-Life-Announcement.html] > BLOG - Clarify wording on 3.x EOL post > -- > > Key: CASSANDRA-18629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18629 > Project: Cassandra > Issue Type: Task > Components: Documentation/Blog >Reporter: Patrick McFadin >Assignee: Patrick McFadin >Priority: Normal > Fix For: NA > > Attachments: c18629-01-blog-index.png, c18629-02-blog-post.png > > > CASSANDRA-18531 generated some confusion so attempting to clean up the > wording. > https://cassandra.apache.org/_/blog/Apache-Cassandra-3.0.x-and-3.11.x-End-of-Life-Announcement.html -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-site updated (f74031fee -> 1e9c4bc25)
This is an automated email from the ASF dual-hosted git repository. patrick pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard f74031fee generate docs for 1b144e50 add 8efdf1270 github action to generate website add 898aa3ff0 Updated BLOG - C* 3.0, 3.11 EOL announcement add 1e9c4bc25 generate docs for 898aa3ff This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f74031fee) \ N -- N -- N refs/heads/asf-site (1e9c4bc25) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/site-content.yaml| 47 +++ content/_/blog.html| 2 +- ...-3.0.x-and-3.11.x-End-of-Life-Announcement.html | 7 +- .../doc/4.2/cassandra/developing/cql/changes.html | 3 + .../cassandra/developing/cql/cql_singlefile.html | 81 ++- .../4.2/cassandra/developing/cql/definitions.html | 4 +- .../doc/4.2/cassandra/developing/cql/types.html| 29 +++ .../cassandra/managing/tools/cassandra_stress.html | 4 + .../doc/4.2/cassandra/managing/tools/cqlsh.html| 11 +-- .../4.2/cassandra/tools/nodetool/bootstrap.html| 9 +-- .../doc/4.2/cassandra/tools/nodetool/import.html | 6 +- .../doc/4.2/cassandra/tools/nodetool/nodetool.html | 8 +- .../4.2/cassandra/tools/nodetool/repair_admin.html | 86 ++--- .../trunk/cassandra/developing/cql/changes.html| 3 + .../cassandra/developing/cql/cql_singlefile.html | 81 ++- .../cassandra/developing/cql/definitions.html | 4 +- .../doc/trunk/cassandra/developing/cql/types.html | 29 +++ .../cassandra/managing/tools/cassandra_stress.html | 4 + .../doc/trunk/cassandra/managing/tools/cqlsh.html | 11 +-- .../trunk/cassandra/tools/nodetool/bootstrap.html | 9 +-- .../doc/trunk/cassandra/tools/nodetool/import.html | 6 +- .../trunk/cassandra/tools/nodetool/nodetool.html | 8 +- .../cassandra/tools/nodetool/repair_admin.html | 86 ++--- content/search-index.js| 2 +- site-content/source/modules/ROOT/pages/blog.adoc | 2 +- ...-3.0.x-and-3.11.x-End-of-Life-Announcement.adoc | 6 +- site-ui/Dockerfile | 2 + site-ui/build/ui-bundle.zip| Bin 4796900 -> 4796900 bytes 28 files changed, 413 insertions(+), 137 deletions(-) create mode 100644 .github/workflows/site-content.yaml - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-61) Add Release Audit Tool (RAT) plugin to Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737779#comment-17737779 ] Dinesh Joshi commented on CASSANDRASC-61: - +1, thanks. > Add Release Audit Tool (RAT) plugin to Sidecar > -- > > Key: CASSANDRASC-61 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-61 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Add the Release Audit Tool plugin to Cassandra Sidecar to automate the > {{check}} process and make it part of the regular Sidecar build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15241) Virtual table to expose current running queries
[ https://issues.apache.org/jira/browse/CASSANDRA-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737778#comment-17737778 ] Caleb Rackliffe commented on CASSANDRA-15241: - [~mmuzaf] Let me know if there's anything else you want to do/fix before I commit... > Virtual table to expose current running queries > --- > > Key: CASSANDRA-15241 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15241 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Expose current running queries and their duration. > {code}cqlsh> select * from system_views.queries; > thread_id| duration_micros | task > --+-+- > Native-Transport-Requests-17 |6325 | QUERY > select * from system_views.queries; [pageSize = 100] > Native-Transport-Requests-4 | 14681 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > Native-Transport-Requests-6 | 14678 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > ReadStage-10 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-13 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-14 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-19 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-20 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-22 |7279 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-23 |4716 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-5 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-7 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-8 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000{code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (df43feb57 -> 1e9c4bc25)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard df43feb57 generate docs for 898aa3ff new 1e9c4bc25 generate docs for 898aa3ff This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (df43feb57) \ N -- N -- N refs/heads/asf-staging (1e9c4bc25) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15241) Virtual table to expose current running queries
[ https://issues.apache.org/jira/browse/CASSANDRA-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737762#comment-17737762 ] Francisco Guerrero commented on CASSANDRA-15241: [~maedhroz] I took a look at it. It looks like a clean cherry-pick. +1 from me > Virtual table to expose current running queries > --- > > Key: CASSANDRA-15241 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15241 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Expose current running queries and their duration. > {code}cqlsh> select * from system_views.queries; > thread_id| duration_micros | task > --+-+- > Native-Transport-Requests-17 |6325 | QUERY > select * from system_views.queries; [pageSize = 100] > Native-Transport-Requests-4 | 14681 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > Native-Transport-Requests-6 | 14678 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > ReadStage-10 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-13 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-14 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-19 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-20 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-22 |7279 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-23 |4716 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-5 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-7 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-8 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000{code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737761#comment-17737761 ] Jacek Lewandowski commented on CASSANDRA-17992: --- Let's see how it goes https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/754/workflows/e33f03ad-29fa-4f50-a61a-276364fbb7c4 > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737757#comment-17737757 ] Jacek Lewandowski commented on CASSANDRA-17992: --- I've pulled those bouncy castle and boringssl fixes from Brandon's branch, it is ok. The TTL problem seem to be related to the fact that netty-all is almost empty and it is used to fetch all fine grained netty jars. However, unlike 4.158, it does not include the native libraries. When I added netty-transport-native-epoll for linux x86_64 it started working locally. > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-61) Add Release Audit Tool (RAT) plugin to Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-61: -- Test and Documentation Plan: No tests are added to this commit Status: Patch Available (was: In Progress) PR: https://github.com/apache/cassandra-sidecar/pull/56 CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/164 > Add Release Audit Tool (RAT) plugin to Sidecar > -- > > Key: CASSANDRASC-61 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-61 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Add the Release Audit Tool plugin to Cassandra Sidecar to automate the > {{check}} process and make it part of the regular Sidecar build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-61) Add Release Audit Tool (RAT) plugin to Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-61: -- Change Category: Semantic Complexity: Low Hanging Fruit Component/s: Configuration Status: Open (was: Triage Needed) > Add Release Audit Tool (RAT) plugin to Sidecar > -- > > Key: CASSANDRASC-61 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-61 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Add the Release Audit Tool plugin to Cassandra Sidecar to automate the > {{check}} process and make it part of the regular Sidecar build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-61) Add Release Audit Tool (RAT) plugin to Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRASC-61: -- Labels: pull-request-available (was: ) > Add Release Audit Tool (RAT) plugin to Sidecar > -- > > Key: CASSANDRASC-61 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-61 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > Add the Release Audit Tool plugin to Cassandra Sidecar to automate the > {{check}} process and make it part of the regular Sidecar build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-61) Add Release Audit Tool (RAT) plugin to Sidecar
Francisco Guerrero created CASSANDRASC-61: - Summary: Add Release Audit Tool (RAT) plugin to Sidecar Key: CASSANDRASC-61 URL: https://issues.apache.org/jira/browse/CASSANDRASC-61 Project: Sidecar for Apache Cassandra Issue Type: Improvement Reporter: Francisco Guerrero Assignee: Francisco Guerrero Add the Release Audit Tool plugin to Cassandra Sidecar to automate the {{check}} process and make it part of the regular Sidecar build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15241) Virtual table to expose current running queries
[ https://issues.apache.org/jira/browse/CASSANDRA-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737750#comment-17737750 ] Caleb Rackliffe commented on CASSANDRA-15241: - [~mmuzaf] The Circle run looks fine. Unless [~frankgh] wants to take a final look at this, I can commit to 4.1. > Virtual table to expose current running queries > --- > > Key: CASSANDRA-15241 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15241 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Expose current running queries and their duration. > {code}cqlsh> select * from system_views.queries; > thread_id| duration_micros | task > --+-+- > Native-Transport-Requests-17 |6325 | QUERY > select * from system_views.queries; [pageSize = 100] > Native-Transport-Requests-4 | 14681 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > Native-Transport-Requests-6 | 14678 | EXECUTE > f4115f91190d4acf09e452637f1f2444 with 0 values at consistency LOCAL_ONE > ReadStage-10 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-13 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-14 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-19 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-20 | 11861 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-22 |7279 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-23 |4716 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-5 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-7 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000 > ReadStage-8 | 16535 | >SELECT * FROM basic.wide1 LIMIT 5000{code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14204) Remove unrepaired SSTables from garbage collection when only_purge_repaired_tombstones is true to avoid AssertionError in nodetool garbagecollect
[ https://issues.apache.org/jira/browse/CASSANDRA-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737747#comment-17737747 ] Stefan Miklosovic commented on CASSANDRA-14204: --- [~blambov] would you mind to take a look? I contacted Jeff and he is not working on Cassandra actively at the moment. > Remove unrepaired SSTables from garbage collection when > only_purge_repaired_tombstones is true to avoid AssertionError in nodetool > garbagecollect > - > > Key: CASSANDRA-14204 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14204 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Low > Fix For: 3.11.x, 4.0.x, 4.1.x, 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > When manually running a garbage collection compaction across a table with > unrepaired sstables and only_purge_repaired_tombstones set to true an > assertion error is thrown. This is because the unrepaired sstables aren't > being removed from the transaction as they are filtered out in > filterSSTables(). > ||3.11||trunk|| > |[branch|https://github.com/vincewhite/cassandra/commit/e13c822736edd3df3403c02e8ef90816f158cde2]|[branch|https://github.com/vincewhite/cassandra/commit/cc8828576404e72504d9b334be85f84c90e77aa7]| > The stacktrace: > {noformat} > -- StackTrace -- > java.lang.AssertionError > at > org.apache.cassandra.db.compaction.CompactionManager.parallelAllSSTableOperation(CompactionManager.java:339) > at > org.apache.cassandra.db.compaction.CompactionManager.performGarbageCollection(CompactionManager.java:476) > at > org.apache.cassandra.db.ColumnFamilyStore.garbageCollect(ColumnFamilyStore.java:1579) > at > org.apache.cassandra.service.StorageService.garbageCollect(StorageService.java:3069) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275) > at > com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112) > at > com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46) > at > com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237) > at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138) > at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252) > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819) > at > com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801) > at > javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468) > at > javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76) > at > javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309) > at > javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401) > at > javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357) > at sun.rmi.transport.Transport$1.run(Transport.java:200) > at sun.rmi.transport.Transport$1.run(Transport.java:197) > at java.security.AccessController.doPrivileged(Native Method) > at sun.rmi.transport.Transport.serviceCall(Transport.java:196) > at > sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568) > at > sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826) >
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737735#comment-17737735 ] Ekaterina Dimitrova commented on CASSANDRA-17992: - Thanks [~jlewandowski] ! So two things: - I noticed you pulled the patch from CASSANDRA-18180. Good call. But you are missing the bounty castle [patch|https://github.com/driftx/cassandra/commit/61c2863643f6ec85f73dbab4e1c3f37443a5c41c], which fixes the SSLFactory unit tests from this [issue|https://github.com/netty/netty/issues/10317] I mentioned earlier. - {quote} Otherwise, we may try to enable it explicitly, wdyt?{quote} We can allow it in tests probably to cover people who might still need it for legacy reasons {quote}We probably ought to do something similar to what we did in CASSANDRA-18540 {quote} or more like CASSANDRA-16848, but fixed for Netty (I haven't looked into what that is, though) > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18626) compaction_tombstone_warning_threshold and compaction_large_partition_warning_threshold cause deprecation warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-18626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña reassigned CASSANDRA-18626: - Assignee: Andres de la Peña > compaction_tombstone_warning_threshold and > compaction_large_partition_warning_threshold cause deprecation warnings > -- > > Key: CASSANDRA-18626 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18626 > Project: Cassandra > Issue Type: Bug > Components: Feature/Guardrails >Reporter: Brandon Williams >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > > If you start trunk without any changes you will see at startup: > {noformat} > WARN [main] 2023-06-26 15:59:36,613 YamlConfigurationLoader.java:426 - > [compaction_tombstone_warning_threshold, > compaction_large_partition_warning_threshold] parameters have been > deprecated. They have new names and/or value format; For more information, > please refer to NEWS.txt > {noformat} > We should give these the same treatment as CASSANDRA-18617, removing them > from the default yaml to stop the warnings, but still accepting them with > converters and @Replaces tags. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18494) Upgrade lucene-core library to the latest stable version
[ https://issues.apache.org/jira/browse/CASSANDRA-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737702#comment-17737702 ] Andres de la Peña commented on CASSANDRA-18494: --- Changes look good to me. The test failures on CI seem the same ones we already have on the base feature branch: * https://app.circleci.com/pipelines/github/adelapena/cassandra/2985/workflows/1f6289ab-1128-4375-8c48-bf406495ef0e * https://app.circleci.com/pipelines/github/adelapena/cassandra/2985/workflows/dbd5f110-1912-4813-9aae-a1dc88e23ecb I have left a couple of nits on the PR that can be addressed on commit. > Upgrade lucene-core library to the latest stable version > > > Key: CASSANDRA-18494 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18494 > Project: Cassandra > Issue Type: Task > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Jonathan Ellis >Priority: Normal > Fix For: NA > > Time Spent: 1h > Remaining Estimate: 0h > > The lucene-core library is currently at 7.5. This should be updated to > whatever the latest stable version of lucene is. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18494) Upgrade lucene-core library to the latest stable version
[ https://issues.apache.org/jira/browse/CASSANDRA-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18494: -- Fix Version/s: NA > Upgrade lucene-core library to the latest stable version > > > Key: CASSANDRA-18494 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18494 > Project: Cassandra > Issue Type: Task > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Jonathan Ellis >Priority: Normal > Fix For: NA > > Time Spent: 0.5h > Remaining Estimate: 0h > > The lucene-core library is currently at 7.5. This should be updated to > whatever the latest stable version of lucene is. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18494) Upgrade lucene-core library to the latest stable version
[ https://issues.apache.org/jira/browse/CASSANDRA-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18494: -- Status: Review In Progress (was: Patch Available) > Upgrade lucene-core library to the latest stable version > > > Key: CASSANDRA-18494 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18494 > Project: Cassandra > Issue Type: Task > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Jonathan Ellis >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > The lucene-core library is currently at 7.5. This should be updated to > whatever the latest stable version of lucene is. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18494) Upgrade lucene-core library to the latest stable version
[ https://issues.apache.org/jira/browse/CASSANDRA-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18494: -- Test and Documentation Plan: ||PR||CI|| |[cep-7-sai|https://github.com/apache/cassandra/pull/2451]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2984/workflows/5d173e63-b61e-4480-ab56-513adcc643a4] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2984/workflows/62f01841-6e91-491c-8331-ce4e7aff3107]| Status: Patch Available (was: Open) > Upgrade lucene-core library to the latest stable version > > > Key: CASSANDRA-18494 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18494 > Project: Cassandra > Issue Type: Task > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Jonathan Ellis >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > The lucene-core library is currently at 7.5. This should be updated to > whatever the latest stable version of lucene is. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18494) Upgrade lucene-core library to the latest stable version
[ https://issues.apache.org/jira/browse/CASSANDRA-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña reassigned CASSANDRA-18494: - Reviewers: Andres de la Peña Assignee: Jonathan Ellis (was: Andres de la Peña) > Upgrade lucene-core library to the latest stable version > > > Key: CASSANDRA-18494 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18494 > Project: Cassandra > Issue Type: Task > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Jonathan Ellis >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > The lucene-core library is currently at 7.5. This should be updated to > whatever the latest stable version of lucene is. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (f35e9b3f -> df43feb5)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard f35e9b3f generate docs for 898aa3ff new df43feb5 generate docs for 898aa3ff This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f35e9b3f) \ N -- N -- N refs/heads/asf-staging (df43feb5) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org