[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770627#comment-17770627 ] shylaja kokoori commented on CASSANDRA-18688: - Thank you very much for the input. I think I have addressed all the suggestions in the new commit. I have also tested the code with JDK versions 11, 12, 17, 20, 21 with & without the env variable set. I have a band around the warning since it was not visible otherwise. Is that ok? [~bereng] does GT mean greater than? > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.0.x > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18890) Test failure: org.apache.cassandra.repair.ConcurrentIrWithPreviewFuzzTest
[
https://issues.apache.org/jira/browse/CASSANDRA-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770609#comment-17770609
]
David Capwell commented on CASSANDRA-18890:
---
latest run had 2 failures and only on jdk17... I reran the seed + config +
jdk17 and the test takes 12s locally (M1 Mac)... Ill look into this more Monday
> Test failure: org.apache.cassandra.repair.ConcurrentIrWithPreviewFuzzTest
> -
>
> Key: CASSANDRA-18890
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18890
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test {{org.apache.cassandra.repair.ConcurrentIrWithPreviewFuzzTest}}
> is flaky in both 5.0 and trunk:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/3222/workflows/ecfca708-f183-429e-80e5-b2bfea8d25a0/jobs/80292/tests
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/3221/workflows/bb777ac0-6263-4d6e-aa54-35d6928e1e9b/jobs/80294
> {code}
> junit.framework.AssertionFailedError: Property error detected:
> Seed = 3695691971125975155
> Examples = 2
> Pure = false
> Error: property test did not complete within PT1M
> Values:
> at accord.utils.Property$Common.checkWithTimeout(Property.java:115)
> at accord.utils.Property$SingleBuilder.check(Property.java:223)
> at accord.utils.Property$ForBuilder.check(Property.java:124)
> at
> org.apache.cassandra.repair.ConcurrentIrWithPreviewFuzzTest.concurrentIrWithPreview(ConcurrentIrWithPreviewFuzzTest.java:46)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> Flakiness is around 6%. The CircleCI runs above have been generated with:
> {code}
> .circleci/generate.sh -p -s \
> -e
> REPEATED_UTESTS=org.apache.cassandra.repair.ConcurrentIrWithPreviewFuzzTest \
> -e REPEATED_UTESTS_COUNT=500
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18893) Upgrade hdrhistogram
[ https://issues.apache.org/jira/browse/CASSANDRA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18893: Test and Documentation Plan: [https://github.com/ekaterinadimitrova2/cassandra/tree/18893-5.0] [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18893-5.0] The only CI failure is test_failing_manual_rebuild_index - CASSANDRA-18361. Looking into the commits in the dependency repo, I see fixes, and in 2.1.12 there is added PackedHistogram ([https://www.javadoc.io/doc/org.hdrhistogram/HdrHistogram/latest/index.html]). So nothing that is breaking us? I suggest we port it also to 4.0, 4.1 or at least bump it to version 2.1.10 there. Not sure whether we need to hit the ML for pre-5.0 branches. Status: Patch Available (was: In Progress) > Upgrade hdrhistogram > > > Key: CASSANDRA-18893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18893 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > We are on 2.1.9, but some breaking changes for J9+ were introduced only in > 2.1.10 (we don't hit them in our CI but a user reported they saw NoClassFound > in some testing) > https://github.com/HdrHistogram/HdrHistogram/commit/c410c5c2699b69ce0eb026ff954fefc4045ec363 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18893) Upgrade hdrhistogram
[ https://issues.apache.org/jira/browse/CASSANDRA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770598#comment-17770598 ] Ekaterina Dimitrova edited comment on CASSANDRA-18893 at 9/29/23 10:34 PM: --- The only CI failure is test_failing_manual_rebuild_index - CASSANDRA-18361. Looking into the commits, I see fixes, and in 2.1.12 there is added PackedHistogram ([https://www.javadoc.io/doc/org.hdrhistogram/HdrHistogram/latest/index.html]). So nothing that is breaking us? I suggest we port it also to 4.0, 4.1 or at least bump it to version 2.1.10 there. Not sure whether we need to hit the ML for pre-5.0 branches. I will wait for a reviewer's feedback. [~brandon.williams] , [~toblin], do you mind reviewing? :) was (Author: e.dimitrova): The only CI failure is test_failing_manual_rebuild_index - CASSANDRA-18361. Looking into the commits, I see fixes, and in 2.1.12 there is added PackedHistogram ([https://www.javadoc.io/doc/org.hdrhistogram/HdrHistogram/latest/index.html]). So nothing that is breaking us? I suggest we port it also to 4.0, or at least version 2.1.10. Not sure whether we need to hit the ML for pre-5.0 branches. I will wait for a reviewer's feedback. [~brandon.williams] , [~toblin], do you mind reviewing? :) > Upgrade hdrhistogram > > > Key: CASSANDRA-18893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18893 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > We are on 2.1.9, but some breaking changes for J9+ were introduced only in > 2.1.10 (we don't hit them in our CI but a user reported they saw NoClassFound > in some testing) > https://github.com/HdrHistogram/HdrHistogram/commit/c410c5c2699b69ce0eb026ff954fefc4045ec363 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18893) Upgrade hdrhistogram
[ https://issues.apache.org/jira/browse/CASSANDRA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770598#comment-17770598 ] Ekaterina Dimitrova commented on CASSANDRA-18893: - The only CI failure is test_failing_manual_rebuild_index - CASSANDRA-18361. Looking into the commits, I see fixes, and in 2.1.12 there is added PackedHistogram ([https://www.javadoc.io/doc/org.hdrhistogram/HdrHistogram/latest/index.html]). So nothing that is breaking us? I suggest we port it also to 4.0, or at least version 2.1.10. Not sure whether we need to hit the ML for pre-5.0 branches. I will wait for a reviewer's feedback. [~brandon.williams] , [~toblin], do you mind reviewing? :) > Upgrade hdrhistogram > > > Key: CASSANDRA-18893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18893 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > We are on 2.1.9, but some breaking changes for J9+ were introduced only in > 2.1.10 (we don't hit them in our CI but a user reported they saw NoClassFound > in some testing) > https://github.com/HdrHistogram/HdrHistogram/commit/c410c5c2699b69ce0eb026ff954fefc4045ec363 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18805) Upgrade caffeine to 3.1.8
[ https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770595#comment-17770595 ] Ekaterina Dimitrova commented on CASSANDRA-18805: - Sure, I am waiting on [~jlewandowski] , [~yifanc] and [~skoppu] approval. :) > Upgrade caffeine to 3.1.8 > - > > Key: CASSANDRA-18805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18805 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > 3.1.8 is based on Java 11. This version is testing with newer JDK versions, > while 2.x versions are based on JDK8, and as I understand, only bug-fix > releases are expected. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18805) Upgrade caffeine to 3.1.8
[ https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18805: Reviewers: Ben Manes, Jacek Lewandowski, Shailaja Koppu, Yifan Cai (was: Ben Manes, Shailaja Koppu, Yifan Cai) > Upgrade caffeine to 3.1.8 > - > > Key: CASSANDRA-18805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18805 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > 3.1.8 is based on Java 11. This version is testing with newer JDK versions, > while 2.x versions are based on JDK8, and as I understand, only bug-fix > releases are expected. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-accord] branch trunk updated: Add support for repair coordinator to retry messages that timeout (#68)
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
The following commit(s) were added to refs/heads/trunk by this push:
new b1befa3c Add support for repair coordinator to retry messages that
timeout (#68)
b1befa3c is described below
commit b1befa3cc0a8496451bb48ec3bb1c0f56b8c7653
Author: dcapwell
AuthorDate: Fri Sep 29 15:16:00 2023 -0700
Add support for repair coordinator to retry messages that timeout (#68)
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18816
---
.../src/main/java/accord/utils/DefaultRandom.java | 11 +--
.../src/main/java/accord/utils/RandomSource.java | 5 ++
.../accord/burn/random/FrequentLargeRange.java | 21 -
...mRangeTest.java => FrequentLargeRangeTest.java} | 6 +-
.../src/test/java/accord/impl/basic/NodeSink.java | 4 +-
.../src/test/java/accord/utils/GenTest.java| 2 +-
accord-core/src/test/java/accord/utils/Gens.java | 8 +-
.../src/test/java/accord/utils/Property.java | 98 +-
8 files changed, 131 insertions(+), 24 deletions(-)
diff --git a/accord-core/src/main/java/accord/utils/DefaultRandom.java
b/accord-core/src/main/java/accord/utils/DefaultRandom.java
index 8efff223..5d00da38 100644
--- a/accord-core/src/main/java/accord/utils/DefaultRandom.java
+++ b/accord-core/src/main/java/accord/utils/DefaultRandom.java
@@ -20,25 +20,20 @@ package accord.utils;
import java.util.Random;
-public class DefaultRandom extends Random implements RandomSource
+public class DefaultRandom extends WrappedRandomSource
{
public DefaultRandom()
{
+super(new Random());
}
public DefaultRandom(long seed)
{
-super(seed);
+super(new Random(seed));
}
@Override
public DefaultRandom fork() {
return new DefaultRandom(nextLong());
}
-
-@Override
-public Random asJdkRandom()
-{
-return this;
-}
}
diff --git a/accord-core/src/main/java/accord/utils/RandomSource.java
b/accord-core/src/main/java/accord/utils/RandomSource.java
index da5033a5..3d4861e5 100644
--- a/accord-core/src/main/java/accord/utils/RandomSource.java
+++ b/accord-core/src/main/java/accord/utils/RandomSource.java
@@ -248,6 +248,11 @@ public interface RandomSource
}
}
+default T pick(T[] array)
+{
+return array[nextInt(array.length)];
+}
+
default T pick(List values)
{
return pick(values, 0, values.size());
diff --git
a/accord-core/src/test/java/accord/burn/random/FrequentLargeRange.java
b/accord-core/src/test/java/accord/burn/random/FrequentLargeRange.java
index 41cae465..7c77b972 100644
--- a/accord-core/src/test/java/accord/burn/random/FrequentLargeRange.java
+++ b/accord-core/src/test/java/accord/burn/random/FrequentLargeRange.java
@@ -31,11 +31,11 @@ public class FrequentLargeRange implements LongGen
private final LongGen small, large;
private final Gen runs;
-public FrequentLargeRange(LongGen small, LongGen large, double ratio)
+public FrequentLargeRange(LongGen small, LongGen large, double ratio, int
maxRuns)
{
this.small = small;
this.large = large;
-this.runs = Gens.bools().biasedRepeatingRuns(ratio);
+this.runs = Gens.bools().biasedRepeatingRuns(ratio, maxRuns);
}
@Override
@@ -54,6 +54,7 @@ public class FrequentLargeRange implements LongGen
{
private final RandomSource random;
private Double ratio;
+private Integer maxRuns;
private LongGen small, large;
public Builder(RandomSource random)
@@ -73,6 +74,18 @@ public class FrequentLargeRange implements LongGen
return this;
}
+public Builder maxRuns(int maxRuns)
+{
+this.maxRuns = maxRuns;
+return this;
+}
+
+public Builder maxRuns(int min, int max)
+{
+this.maxRuns = random.nextInt(min, max);
+return this;
+}
+
public Builder small(Duration min, Duration max)
{
small = create(min, max);
@@ -132,7 +145,9 @@ public class FrequentLargeRange implements LongGen
throw new IllegalStateException("Large range undefined");
if (ratio == null)
ratio(1, 11);
-return new FrequentLargeRange(small, large, ratio);
+if (maxRuns == null)
+maxRuns(3, 15);
+return new FrequentLargeRange(small, large, ratio, maxRuns);
}
}
}
diff --git
a/accord-core/src/test/java/accord/burn/random/SegmentedRandomRangeTest.java
b/accord-core/src/test/java/accord/burn/random/FrequentLargeRangeTest.java
similarity index 97%
rename from
accord-core/src/test/java/accord/burn/random/SegmentedRandomRangeTest.java
rename to
[jira] [Updated] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-18816: --- Labels: pull-request-available (was: ) > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 5.0-alpha2 > > Time Spent: 13h 10m > Remaining Estimate: 0h > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18896) ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based
[
https://issues.apache.org/jira/browse/CASSANDRA-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-18896:
Change Category: Semantic
Complexity: Low Hanging Fruit
Fix Version/s: 5.0.x
5.1
Status: Open (was: Triage Needed)
> ClientRequestSize metrics should not treat CONTAINS restrictions as being
> equality-based
>
>
> Key: CASSANDRA-18896
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18896
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.0.x, 5.1
>
>
> The following behavior needs to be changed to consider the column restricted
> by {{CONTAINS}} or {{CONTAINS KEY}} as "read", rather than "provided by the
> client". We already do this for things like range restrictions, and the
> current behavior is inconsistent.
> {noformat}
> @Test
> public void shouldRecordReadMetricsForContainsQuery() throws Throwable
> {
> createTable("CREATE TABLE %s (pk int, ck int, v set, PRIMARY KEY
> (pk, ck))");
> executeNet(CURRENT, "INSERT INTO %s (pk, ck, v) VALUES (1, 1, {1, 2, 3}
> )");
> executeNet(CURRENT, "INSERT INTO %s (pk, ck, v) VALUES (2, 2, {4, 5,
> 6})");
> executeNet(CURRENT, "SELECT * FROM %s WHERE v CONTAINS 1 ALLOW
> FILTERING");
> assertEquals(1, ClientRequestSizeMetrics.totalRowsRead.getCount());
> // The filtering term is provided by the client in the request, so we
> don't consider that column read.
> assertEquals(2, ClientRequestSizeMetrics.totalColumnsRead.getCount());
> }
> {noformat}
> The fix should be literally two lines, one in {{SingleRestriction}} and one
> in the test above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18896) ClientRequestSize metrics should not treat CONTAINS restrictions as being equality-based
Caleb Rackliffe created CASSANDRA-18896:
---
Summary: ClientRequestSize metrics should not treat CONTAINS
restrictions as being equality-based
Key: CASSANDRA-18896
URL: https://issues.apache.org/jira/browse/CASSANDRA-18896
Project: Cassandra
Issue Type: Improvement
Components: Observability/Metrics
Reporter: Caleb Rackliffe
Assignee: Caleb Rackliffe
The following behavior needs to be changed to consider the column restricted by
{{CONTAINS}} or {{CONTAINS KEY}} as "read", rather than "provided by the
client". We already do this for things like range restrictions, and the current
behavior is inconsistent.
{noformat}
@Test
public void shouldRecordReadMetricsForContainsQuery() throws Throwable
{
createTable("CREATE TABLE %s (pk int, ck int, v set, PRIMARY KEY (pk,
ck))");
executeNet(CURRENT, "INSERT INTO %s (pk, ck, v) VALUES (1, 1, {1, 2, 3} )");
executeNet(CURRENT, "INSERT INTO %s (pk, ck, v) VALUES (2, 2, {4, 5, 6})");
executeNet(CURRENT, "SELECT * FROM %s WHERE v CONTAINS 1 ALLOW FILTERING");
assertEquals(1, ClientRequestSizeMetrics.totalRowsRead.getCount());
// The filtering term is provided by the client in the request, so we don't
consider that column read.
assertEquals(2, ClientRequestSizeMetrics.totalColumnsRead.getCount());
}
{noformat}
The fix should be literally two lines, one in {{SingleRestriction}} and one in
the test above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (1ce5cedc -> f6731534)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1ce5cedc generate docs for bc8bfc13 new f6731534 generate docs for bc8bfc13 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1ce5cedc) \ N -- N -- N refs/heads/asf-staging (f6731534) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tools/nodetool/setcolumnindexsize.html | 3 ++- .../tools/nodetool/setcolumnindexsize.html | 3 ++- site-ui/build/ui-bundle.zip| Bin 4881412 -> 4881412 bytes 3 files changed, 4 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-21-tcm updated (e225ff7ca8 -> 4d6aab0324)
This is an automated email from the ASF dual-hosted git repository. marcuse pushed a change to branch cep-21-tcm in repository https://gitbox.apache.org/repos/asf/cassandra.git discard e225ff7ca8 [CEP-21] fix GossiperTest - this test now matches trunk discard 7b3292d7dc [CEP-21] CASSANDRA-18816 rebase fixes discard 72886b552b update dtest repo for cci discard a7b650a7dd [CEP-21] fix cqlshlib tests discard 9b5e6ab544 [CEP-21] remove authsetup discard 1ab867b39f [CEP-21] serialize MemtableParams when writing TableParams discard e187d7d616 [CEP-21] Upgrading a one node cluster to TCM fails attempting Gossip shadow round discard e332376df1 [CEP-21] Implement replacement with same address discard ebde83c2ea [CEP-21] fix nodetool bootstrap resume discard d9071b3f86 [CEP-21] Remove LEFT peers from system tables and exclude them during startup discard 396db98318 [CEP-21] Fix flaky distributed log test. While it fails very infrequently on CI, it consistently fails locally. discard fdc2297dba [CEP-21] Retry indefinitely for STARTUP messages. discard b147c48cf5 [CEP-21] Implement versioning for ranges discard b5de96fc46 [CEP-21] Handle case where removenode requires no streaming to restore RF discard d5bf9dfb64 [CEP-21] Remove redundant Keyspaces arg from SchemaTransformation::apply discard 0cac1679b9 [CEP-21] Don't trigger client warnings or guardrails when executing AlterSchema transformations discard b6089b248c [CEP-21] Validate schema alterations on coordinator discard 0eac2972e2 [CEP-21] Add a script for simulation running discard 0003c18243 [CEP-21] Add nextId to Directory serialization and make it possible to bump metadata serialization version discard 8e31d87922 [CEP-21] Add metric for CMS membership discard f769e462d6 [CEP-21] Reenable starting without joining (-Dcassandra.join_ring=false) discard 15cf99178d [CEP-21] Preparing DDL statements should capture the CQL string discard ad2380c29d rebase discard 0e66e6bf30 [CEP-21] Work with Storage Compatiblility Mode discard 14141d57ed storage_compat_mode: none discard 4301aa7b0a [CEP-21] Update tests which require the local node not to be joined by default discard 2030855d56 more test fixes discard 04abdd806e fix UnifiedCompactionStrategyTest discard 5f77d328cf rebase fix discard 2a439b075d Fix ByteBuddyExamplesTest discard 1baba286d5 rebase fixes discard 26cf755513 [CEP-21] Evict replaced endpoint from gossip discard 274095f0f8 [CEP-21] Avoid gossip deadlock by grabbing taskLock before runInGossipStageBlocking discard 8ab6865c73 [CEP-21] Python dtest fixes * maybe fix hintedhandoff test discard a43d41e84c [CEP-21] More in-jvm dtest fixes discard dc47281c94 [CEP-21] Use harry for generating data for coordinator path test discard 754809d889 [CEP-21] Various JVM Dtest fixes discard 5a285e24ed [CEP-21] Fix flaky consistentleave test discard bc972f0466 [CEP-21] Fix assassinate dtests discard 538e66bc98 [CEP-21] Fix MoveTest discard e7eb783490 [CEP-21] Fix paxos self execution tests discard 89fabd1456 [CEP-21] Fix IPMembershipTest discard b43848f597 [CEP-21] Fix reprepare tests discard d633faeecc [CEP-21] Reduce number of data harry writes to reduce flakiness discard d581f5c053 [CEP-21] Fix replacement tests discard a4c0337936 [CEP-21] Fix o.a.c.dht.BootstrapperTest discard 170eadae48 [CEP-21] Fix o.a.c.service.BootstrapTransientTest discard bfa4fa9ad2 [CEP-21] Fix o.a.c.db.StreamRequestTest discard 606c8845bc [CEP-21] Fix o.a.c.streaming.StreamRateLimiterTest discard 3f09c5d253 [CEP-21] Fix o.a.c.tools.TopPartitionsTest discard 0510917e60 [CEP-21] Fix o.a.c.io.sstable.format.RangeAwareSSTableWriterTest discard 019bc60c52 [CEP-21] Disable auto metadata snapshots during tests discard cd591e990f [CEP-21] Fix o.a.c.tcm.ownership.DeltaMapTest discard ca9a8faace [CEP-21] Syncronize processing of LocalLog in test code discard b73f125f16 [CEP-21] Fix MockSchema to use supplied keyspace name discard 72f0694eae [CEP-21] Fix o.a.c.db.view.ViewUtilsTest discard c1ffd969b5 [CEP-21] Fix o.a.c.service.reads.repair.[BlockingReadRepairTest|DiagEventsBlockingReadRepairTest] discard 82838e3aee [CEP-21] Restore previous behaviour when fetching effective ownership for a local system keyspace discard 0e9b3d27d3 [CEP-21] Fix o.a.c.db.CleanupTest discard 66dd732059 [CEP-21] Fix o.a.c.tcm.RemoteProcessorTest discard cd883b1051 [CEP-21] Remove obsolete o.a.c.locator.ReplicationStrategyEndpointCacheTest discard 3c676d0f8e [CEP-21] Fix o.a.c.locator.DynamicEndpointSnitchTest discard 024014a08e [CEP-21] Fix o.a.c.locator.ReplicaPlansTest discard aa93c0971d [CEP-21] Fix o.a.c.tcm.transformations.EventsMetadataTest discard 7e1a6ef181 [CEP-21] Fix o.a.c.tcm.transformations.PrepareLeaveTest discard c637a5efc8 [CEP-21] Fix o.a.c.cql3.KeyCacheCqlTest discard 068fc3db9b [CEP-21] Remove o.a.c.gms.ExpireEndpointTest.java (CMS updates now remove from gossip) discard 843416bb41 [CEP-21] Remove
[jira] [Commented] (CASSANDRA-18733) Waiting indefinitely on ReceivedMessage response in StreamSession#receive() can cause deadlock
[
https://issues.apache.org/jira/browse/CASSANDRA-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770548#comment-17770548
]
Jon Meredith commented on CASSANDRA-18733:
--
Reran with 5.0 -- clean after rerunning. Issues due to docker hub rather than
tests.
java11_separate_tests
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/960/workflows/6d34a65c-93cd-4b96-9f5f-171d13f326e8
clean except j17_jvm_dtests_repeat
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/960/workflows/6d34a65c-93cd-4b96-9f5f-171d13f326e8/jobs/20393/parallel-runs/22?filterBy=FAILED
-- 503 errors for docker hub on 14/25 pods.
rerun
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/960/workflows/108d649c-41a0-4073-871a-be5bca206bd1
java17_separate_tests
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/960/workflows/c41e05a6-a6cb-4e13-83fb-255f2a59d399
-- clean
> Waiting indefinitely on ReceivedMessage response in StreamSession#receive()
> can cause deadlock
> --
>
> Key: CASSANDRA-18733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18733
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Consistency/Streaming
>Reporter: Caleb Rackliffe
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.1.4, 5.0, 5.0-alpha1, 5.1
>
>
> I've observed in a recent stack trace from a node running 4.1 what looks like
> a deadlock around the {{StreamSession}} monitor lock when
> {{StreamSession#receive()}} waits via {{syncUninteruptibly()}} for a response
> to a control message.
> {noformat}
> "Messaging-EventLoop-3-10" #320 daemon prio=5 os_prio=0 cpu=57979617.98ms
> elapsed=5587916.03s tid=0x7f056e88ae00 nid=0x80ec waiting for monitor
> entry [0x7f056d277000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:524)
> - waiting to lock <0x0006816fae70> (a
> org.apache.cassandra.streaming.StreamSession)
> at
> org.apache.cassandra.streaming.StreamSession.onError(StreamSession.java:690)
> at
> org.apache.cassandra.streaming.async.StreamingMultiplexedChannel.onMessageComplete(StreamingMultiplexedChannel.java:264)
> at
> org.apache.cassandra.streaming.async.StreamingMultiplexedChannel.lambda$sendMessage$1(StreamingMultiplexedChannel.java:233)
> at
> org.apache.cassandra.streaming.async.StreamingMultiplexedChannel$$Lambda$2029/0x0008007a0c40.operationComplete(Unknown
> Source)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:134)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:148)
> at
> org.apache.cassandra.utils.concurrent.ListenerList$GenericFutureListenerList.notifySelf(ListenerList.java:190)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.lambda$notifyExclusive$0(ListenerList.java:124)
> at
> org.apache.cassandra.utils.concurrent.ListenerList$$Lambda$950/0x000800666040.accept(Unknown
> Source)
> at
> org.apache.cassandra.utils.concurrent.IntrusiveStack.forEach(IntrusiveStack.java:195)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyExclusive(ListenerList.java:124)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notify(ListenerList.java:96)
> at
> org.apache.cassandra.utils.concurrent.AsyncFuture.trySet(AsyncFuture.java:104)
> at
> org.apache.cassandra.utils.concurrent.AbstractFuture.tryFailure(AbstractFuture.java:148)
> at
> org.apache.cassandra.utils.concurrent.AsyncPromise.tryFailure(AsyncPromise.java:139)
> at
> io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetFailure(AbstractChannel.java:1009)
> at
> io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:870)
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1367)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:764)
> at
> io.netty.channel.AbstractChannelHandlerContext$WriteTask.run(AbstractChannelHandlerContext.java:1071)
> at
> io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384)
> at
>
[jira] [Commented] (CASSANDRA-18725) IsolatedJMX should not release all TCPEndpoints on instance shutdown
[ https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770521#comment-17770521 ] Jon Meredith commented on CASSANDRA-18725: -- Reran against 5.0 branch. Clean runs. java11_separate_tests https://app.circleci.com/pipelines/github/jonmeredith/cassandra/959/workflows/99204b8b-40a2-4ceb-becd-df6d3d0afdc2 java17_separate_tests https://app.circleci.com/pipelines/github/jonmeredith/cassandra/959/workflows/a1e6df8b-b61c-4359-aaef-9b3ff08ebbcd > IsolatedJMX should not release all TCPEndpoints on instance shutdown > > > Key: CASSANDRA-18725 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18725 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 3.11.17, 4.0.12, 4.1.4, 5.0-alpha, 5.x > > Time Spent: 3h 20m > Remaining Estimate: 0h > > In the original implementation of the JMX feature, we fixed some memory leaks > by clearing some internal state in Java’s TCPEndpoint. However, that > implementation was overly aggressive and cleared the whole map, vs. just > removing the endpoints created by the individual instances. This causes > issues when you remove a node from the cluster (as all of the endpoints are > cleared, not just the ones in use by that instance). > > In stead, we should check if the endpoint was created by the instance in > question and only remove it if it was. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18681) Internode legacy SSL storage port certificate is not hot reloaded on update
[
https://issues.apache.org/jira/browse/CASSANDRA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770519#comment-17770519
]
Jon Meredith commented on CASSANDRA-18681:
--
Reran against 5.0 branch. Clean runs.
java11_separate_tests
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/958/workflows/906a8642-f525-4d52-a981-eba879717aaa
java17_separate_tests
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/958/workflows/11af46d5-c996-409e-b9c2-4e1aea2a5881
> Internode legacy SSL storage port certificate is not hot reloaded on update
> ---
>
> Key: CASSANDRA-18681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18681
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.1.4, 5.0-alpha2
>
>
> In CASSANDRA-1 the SSLContext cache was changed to clear individual
> {{EncryptionOptions}} from the SslContext cache if they needed reloading to
> reduce resource consumption. Before the change if ANY cert needed hot
> reloading, the SSLContext cache would be cleared for ALL certs.
> If the legacy SSL storage port is configured, a new {{EncryptionOptions}}
> object is created in {{org.apache.cassandra.net.InboundSockets#addBindings}}
> just for binding the socket, but never gets cleared as the change in port
> means it no longer matches the configuration retrieved from
> {{DatabaseDescriptor}} in
> {{org.apache.cassandra.net.MessagingServiceMBeanImpl#reloadSslCertificates}}.
> This is unlikely to be an issue in practice as the legacy SSL internode
> socket is only used in mixed version clusters with pre-4.0 nodes, so the cert
> only needs to stay valid until all nodes upgrade to 4.x or above.
> One way to avoid this class of failures is to just check the entries present
> in the SSLContext cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770510#comment-17770510 ] Caleb Rackliffe commented on CASSANDRA-18816: - FWIW, I started using the public tooling after Java 17 support was added... > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0-alpha2 > > Time Spent: 13h 10m > Remaining Estimate: 0h > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-21-tcm updated (5cacbbcc75 -> e225ff7ca8)
This is an automated email from the ASF dual-hosted git repository. marcuse pushed a change to branch cep-21-tcm in repository https://gitbox.apache.org/repos/asf/cassandra.git omit 5cacbbcc75 [CEP-21] Work with Storage Compatiblility Mode omit 94df20b882 storage_compat_mode: none omit 22b585da62 [CEP-21] Update tests which require the local node not to be joined by default omit 4873bf13dc more test fixes omit 29b1f971ad fix UnifiedCompactionStrategyTest omit 28633375b8 rebase fix omit 395899a07d Fix ByteBuddyExamplesTest omit 5e7ed5cbda rebase fixes omit 98493555a9 [CEP-21] Evict replaced endpoint from gossip omit 9a425bae50 [CEP-21] Avoid gossip deadlock by grabbing taskLock before runInGossipStageBlocking omit 2943bfd47d [CEP-21] Python dtest fixes * maybe fix hintedhandoff test omit 54ee755239 [CEP-21] More in-jvm dtest fixes omit 4f2690d7e2 [CEP-21] Use harry for generating data for coordinator path test omit 8e759dfce9 [CEP-21] Various JVM Dtest fixes omit b8f8f55d99 [CEP-21] Fix flaky consistentleave test omit 120d5d049f [CEP-21] Fix assassinate dtests omit 34e8f3a9bb [CEP-21] Fix MoveTest omit 19645872d6 [CEP-21] Fix paxos self execution tests omit 24a722934e [CEP-21] Fix IPMembershipTest omit 59594c3133 [CEP-21] Fix reprepare tests omit 6a1565def6 [CEP-21] Reduce number of data harry writes to reduce flakiness omit c8f835c7ce [CEP-21] Fix replacement tests omit 750339d2c5 [CEP-21] Fix o.a.c.dht.BootstrapperTest omit 1c90e68550 [CEP-21] Fix o.a.c.service.BootstrapTransientTest omit 7ba7dbbf54 [CEP-21] Fix o.a.c.db.StreamRequestTest omit 13ddd1675e [CEP-21] Fix o.a.c.streaming.StreamRateLimiterTest omit 8ad79e07a3 [CEP-21] Fix o.a.c.tools.TopPartitionsTest omit b8ec6ce5c0 [CEP-21] Fix o.a.c.io.sstable.format.RangeAwareSSTableWriterTest omit 6fb1d4f2bb [CEP-21] Disable auto metadata snapshots during tests omit 8e5d352eb1 [CEP-21] Fix o.a.c.tcm.ownership.DeltaMapTest omit 5916b94039 [CEP-21] Syncronize processing of LocalLog in test code omit 51a1c7a25c [CEP-21] Fix MockSchema to use supplied keyspace name omit 1c1c797487 [CEP-21] Fix o.a.c.db.view.ViewUtilsTest omit 520882ee50 [CEP-21] Fix o.a.c.service.reads.repair.[BlockingReadRepairTest|DiagEventsBlockingReadRepairTest] omit 74e908dfd4 [CEP-21] Restore previous behaviour when fetching effective ownership for a local system keyspace omit 3980032cc2 [CEP-21] Fix o.a.c.db.CleanupTest omit e0db02c72c [CEP-21] Fix o.a.c.tcm.RemoteProcessorTest omit d7d937a58e [CEP-21] Remove obsolete o.a.c.locator.ReplicationStrategyEndpointCacheTest omit 2ff6997038 [CEP-21] Fix o.a.c.locator.DynamicEndpointSnitchTest omit 49de43c39b [CEP-21] Fix o.a.c.locator.ReplicaPlansTest omit 3f01f96eeb [CEP-21] Fix o.a.c.tcm.transformations.EventsMetadataTest omit 68ee1de3b4 [CEP-21] Fix o.a.c.tcm.transformations.PrepareLeaveTest omit f3be304f2e [CEP-21] Fix o.a.c.cql3.KeyCacheCqlTest omit 663fff7a91 [CEP-21] Remove o.a.c.gms.ExpireEndpointTest.java (CMS updates now remove from gossip) omit 80bee62d3e [CEP-21] Remove o.a.c.gms.PendingRangeCalculatorServiceTest omit 670de615d2 [CEP-21] Fix o.a.c.db.CleanupTransientTest omit 0865b9936b [CEP-21] Fix o.a.c.db.ColumnFamilyMetricTest omit 162b292a10 [CEP-21] Fix o.a.c.db.VerifyTest omit c16e117b36 [CEP-21] Fix o.a.c.db.compaction.writers.CompactionAwareWriterTest omit 0ab9c0d48f [CEP-21] Remove o.a.c.schema.RemoveWithoutDroppingTest omit e26e4508ad [CEP-21] Fix o.a.c.schema.SchemaKeyspaceTest omit d6c3d6c347 [CEP-21] Rewrite o.a.c.service.StorageServiceServerTest omit 66ab5bad76 [CEP-21] Fix o.a.c.gms.GossiperTest omit 16a0830881 [CEP-21] Fix o.a.c.tcm.ClusterMetadataTransformationTest omit 58c97fff0f [CEP-21] Fix o.a.c.tcm.RemoteProcessorTest omit 54029c3dc5 [CEP-21] Fix o.a.c.service.StorageProxyTest omit 27c6c8a875 [CEP-21] Additional tests which no longer need to manually create system_auth omit a5dd905907 [CEP-21] Fix o.a.c.service.StorageServiceServerM3PTest omit 6cbc474851 [CEP-21] Fix o.a.c.service.PartitionDenylistTest omit c7df550715 [CEP-21] Fix o.a.c.service.JoinTokenRingTest omit 236d3a2524 [CEP-21] Adjust test for GossipInfo now STATUS is removed omit a4868f8225 [CEP-21] Tests no longer need to manually create system_auth omit dca718b05f [CEP-21] Fix o.a.c.tools.StandaloneSplitterWithCQLTesterTest omit 0724f0666f [CEP-21] Fix o.a.c.tools.JMXCompatibilityTest omit 6cca495312 [CEP-21] Fix o.a.c.service.reads.range.TokenUpdater omit 7baf09a8e1 [CEP-21] Fix o.a.c.service.LegacyAuthFailTest omit 671a3c4554 [CEP-21] Fix o.a.c.db.virtual.StreamingVirtualTableTest omit 859c06f678 [CEP-21] Fix o.a.c.db.virtual.LocalRepairTablesTest omit b13b3a43cd [CEP-21] Fix o.a.c.db.virtual.JmxPermissionsCacheKeysTableTest omit 8d5c531e2e [CEP-21] fix
[jira] [Updated] (CASSANDRA-18895) Test failure: https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/
[
https://issues.apache.org/jira/browse/CASSANDRA-18895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18895:
Fix Version/s: 5.0.x
> Test failure:
> https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/
>
>
> Key: CASSANDRA-18895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18895
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0.x
>
>
> h3.
> {code:java}
> https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/{code}
> {code:java}
> Error Message
> Uncaught exceptions were thrown during test
> Stacktrace
> org.apache.cassandra.distributed.shared.ShutdownException: Uncaught
> exceptions were thrown during test at
> org.apache.cassandra.distributed.impl.AbstractCluster.checkAndResetUncaughtExceptions(AbstractCluster.java:1104)
> at
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1090)
> at
> org.apache.cassandra.distributed.test.MessageFiltersTest.hintSerializationTest(MessageFiltersTest.java:297)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Suppressed: java.lang.IllegalStateException: Can't use shutdown instances,
> delegate is null at
> org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.delegate(AbstractCluster.java:285)
> at
> org.apache.cassandra.distributed.impl.DelegatingInvokableInstance.transfer(DelegatingInvokableInstance.java:49)
> at
> org.apache.cassandra.distributed.api.IInvokableInstance.acceptsOnInstance(IInvokableInstance.java:49)
> at
> org.apache.cassandra.distributed.test.MessageFiltersTest.lambda$hintSerializationTest$11(MessageFiltersTest.java:287)
> at
> org.apache.cassandra.distributed.impl.MessageFilters$Filter.matches(MessageFilters.java:137)
> at
> org.apache.cassandra.distributed.impl.MessageFilters.permit(MessageFilters.java:61)
> at
> org.apache.cassandra.distributed.impl.MessageFilters.permitInbound(MessageFilters.java:37)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$registerInboundFilter$4(Instance.java:361)
> at org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:63)
> at org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:50)
> at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:97) at
> org.apache.cassandra.net.InboundSink.accept(InboundSink.java:45) at
> org.apache.cassandra.net.InboundMessageHandler$ProcessMessage.run(InboundMessageHandler.java:430)
> at
> org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:143) at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:833)
> {code}
>
> {code:java}
> ERROR 12:39:56 uncaught exception in thread
> Thread[node1_MemtablePostFlush:1,5,MemtablePostFlush]
> java.util.concurrent.RejectedExecutionException: MemtableReclaimMemory has
> shut down at
> org.apache.cassandra.concurrent.ThreadPoolExecutorBase.lambda$static$0(ThreadPoolExecutorBase.java:49)
> at
> org.apache.cassandra.concurrent.ThreadPoolExecutorJMXAdapter.lambda$rejectedExecutionHandler$0(ThreadPoolExecutorJMXAdapter.java:238)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:833)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1365)
> at
> org.apache.cassandra.concurrent.ThreadPoolExecutorPlus.addTask(ThreadPoolExecutorPlus.java:50)
> at
> org.apache.cassandra.concurrent.ThreadPoolExecutorPlus.execute(ThreadPoolExecutorPlus.java:57)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.safeExecute(ListenerList.java:166)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:157)
> at
> org.apache.cassandra.utils.concurrent.ListenerList$RunnableWithExecutor.notifySelf(ListenerList.java:345)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.lambda$notifyExclusive$0(ListenerList.java:124)
> at
> org.apache.cassandra.utils.concurrent.IntrusiveStack.forEach(IntrusiveStack.java:195)
> at
>
[jira] [Updated] (CASSANDRA-18895) Test failure: https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/
[
https://issues.apache.org/jira/browse/CASSANDRA-18895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18895:
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Component/s: Test/dtest/java
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> Test failure:
> https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/
>
>
> Key: CASSANDRA-18895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18895
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> h3.
> {code:java}
> https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/{code}
> {code:java}
> Error Message
> Uncaught exceptions were thrown during test
> Stacktrace
> org.apache.cassandra.distributed.shared.ShutdownException: Uncaught
> exceptions were thrown during test at
> org.apache.cassandra.distributed.impl.AbstractCluster.checkAndResetUncaughtExceptions(AbstractCluster.java:1104)
> at
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1090)
> at
> org.apache.cassandra.distributed.test.MessageFiltersTest.hintSerializationTest(MessageFiltersTest.java:297)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Suppressed: java.lang.IllegalStateException: Can't use shutdown instances,
> delegate is null at
> org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.delegate(AbstractCluster.java:285)
> at
> org.apache.cassandra.distributed.impl.DelegatingInvokableInstance.transfer(DelegatingInvokableInstance.java:49)
> at
> org.apache.cassandra.distributed.api.IInvokableInstance.acceptsOnInstance(IInvokableInstance.java:49)
> at
> org.apache.cassandra.distributed.test.MessageFiltersTest.lambda$hintSerializationTest$11(MessageFiltersTest.java:287)
> at
> org.apache.cassandra.distributed.impl.MessageFilters$Filter.matches(MessageFilters.java:137)
> at
> org.apache.cassandra.distributed.impl.MessageFilters.permit(MessageFilters.java:61)
> at
> org.apache.cassandra.distributed.impl.MessageFilters.permitInbound(MessageFilters.java:37)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$registerInboundFilter$4(Instance.java:361)
> at org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:63)
> at org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:50)
> at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:97) at
> org.apache.cassandra.net.InboundSink.accept(InboundSink.java:45) at
> org.apache.cassandra.net.InboundMessageHandler$ProcessMessage.run(InboundMessageHandler.java:430)
> at
> org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:143) at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:833)
> {code}
>
> {code:java}
> ERROR 12:39:56 uncaught exception in thread
> Thread[node1_MemtablePostFlush:1,5,MemtablePostFlush]
> java.util.concurrent.RejectedExecutionException: MemtableReclaimMemory has
> shut down at
> org.apache.cassandra.concurrent.ThreadPoolExecutorBase.lambda$static$0(ThreadPoolExecutorBase.java:49)
> at
> org.apache.cassandra.concurrent.ThreadPoolExecutorJMXAdapter.lambda$rejectedExecutionHandler$0(ThreadPoolExecutorJMXAdapter.java:238)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:833)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1365)
> at
> org.apache.cassandra.concurrent.ThreadPoolExecutorPlus.addTask(ThreadPoolExecutorPlus.java:50)
> at
> org.apache.cassandra.concurrent.ThreadPoolExecutorPlus.execute(ThreadPoolExecutorPlus.java:57)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.safeExecute(ListenerList.java:166)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:157)
> at
> org.apache.cassandra.utils.concurrent.ListenerList$RunnableWithExecutor.notifySelf(ListenerList.java:345)
> at
>
[jira] [Created] (CASSANDRA-18895) Test failure: https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/
Ekaterina Dimitrova created CASSANDRA-18895:
---
Summary: Test failure:
https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/
Key: CASSANDRA-18895
URL: https://issues.apache.org/jira/browse/CASSANDRA-18895
Project: Cassandra
Issue Type: Bug
Reporter: Ekaterina Dimitrova
h3.
{code:java}
https://ci-cassandra.apache.org/job/Cassandra-5.0/47/testReport/org.apache.cassandra.distributed.test/MessageFiltersTest/hintSerializationTest__jdk17/{code}
{code:java}
Error Message
Uncaught exceptions were thrown during test
Stacktrace
org.apache.cassandra.distributed.shared.ShutdownException: Uncaught exceptions
were thrown during test at
org.apache.cassandra.distributed.impl.AbstractCluster.checkAndResetUncaughtExceptions(AbstractCluster.java:1104)
at
org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1090)
at
org.apache.cassandra.distributed.test.MessageFiltersTest.hintSerializationTest(MessageFiltersTest.java:297)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Suppressed: java.lang.IllegalStateException: Can't use shutdown instances,
delegate is null at
org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.delegate(AbstractCluster.java:285)
at
org.apache.cassandra.distributed.impl.DelegatingInvokableInstance.transfer(DelegatingInvokableInstance.java:49)
at
org.apache.cassandra.distributed.api.IInvokableInstance.acceptsOnInstance(IInvokableInstance.java:49)
at
org.apache.cassandra.distributed.test.MessageFiltersTest.lambda$hintSerializationTest$11(MessageFiltersTest.java:287)
at
org.apache.cassandra.distributed.impl.MessageFilters$Filter.matches(MessageFilters.java:137)
at
org.apache.cassandra.distributed.impl.MessageFilters.permit(MessageFilters.java:61)
at
org.apache.cassandra.distributed.impl.MessageFilters.permitInbound(MessageFilters.java:37)
at
org.apache.cassandra.distributed.impl.Instance.lambda$registerInboundFilter$4(Instance.java:361)
at org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:63)
at org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:50) at
org.apache.cassandra.net.InboundSink.accept(InboundSink.java:97) at
org.apache.cassandra.net.InboundSink.accept(InboundSink.java:45) at
org.apache.cassandra.net.InboundMessageHandler$ProcessMessage.run(InboundMessageHandler.java:430)
at
org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:143) at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:833)
{code}
{code:java}
ERROR 12:39:56 uncaught exception in thread
Thread[node1_MemtablePostFlush:1,5,MemtablePostFlush]
java.util.concurrent.RejectedExecutionException: MemtableReclaimMemory has shut
down at
org.apache.cassandra.concurrent.ThreadPoolExecutorBase.lambda$static$0(ThreadPoolExecutorBase.java:49)
at
org.apache.cassandra.concurrent.ThreadPoolExecutorJMXAdapter.lambda$rejectedExecutionHandler$0(ThreadPoolExecutorJMXAdapter.java:238)
at
java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:833)
at
java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1365)
at
org.apache.cassandra.concurrent.ThreadPoolExecutorPlus.addTask(ThreadPoolExecutorPlus.java:50)
at
org.apache.cassandra.concurrent.ThreadPoolExecutorPlus.execute(ThreadPoolExecutorPlus.java:57)
at
org.apache.cassandra.utils.concurrent.ListenerList.safeExecute(ListenerList.java:166)
at
org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:157)
at
org.apache.cassandra.utils.concurrent.ListenerList$RunnableWithExecutor.notifySelf(ListenerList.java:345)
at
org.apache.cassandra.utils.concurrent.ListenerList.lambda$notifyExclusive$0(ListenerList.java:124)
at
org.apache.cassandra.utils.concurrent.IntrusiveStack.forEach(IntrusiveStack.java:195)
at
org.apache.cassandra.utils.concurrent.ListenerList.notifyExclusive(ListenerList.java:124)
at
org.apache.cassandra.utils.concurrent.ListenerList.notify(ListenerList.java:96)
at
org.apache.cassandra.utils.concurrent.AsyncFuture.trySet(AsyncFuture.java:104)
at
org.apache.cassandra.utils.concurrent.AbstractFuture.trySuccess(AbstractFuture.java:143)
at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
[jira] [Commented] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770466#comment-17770466 ] Andres de la Peña commented on CASSANDRA-18816: --- I'm not aware of any other flaky tests caused by those tickets. I haven't searched for all the affected tickets. I don't know where it was used nor when the issue started since it's a non-public tool. I'm mentioning those tickets for reference, and to show the need to review CI results, since tools can fail. > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0-alpha2 > > Time Spent: 13h 10m > Remaining Estimate: 0h > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770458#comment-17770458 ] Jon Meredith commented on CASSANDRA-18816: -- The bug in the script was my mistake. Thanks for catching it. I've searched JIRA and don't see any tickets for flaky tests filed against any of those issues except CASSANDRA-18733. Were you just mentioning the omission for future reference, or are you aware of any issues? I'll rerun the repeated tests against CASSANDRA-18681, CASSANDRA-18725 and CASSANDRA-18733 for completeness. > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0-alpha2 > > Time Spent: 13h 10m > Remaining Estimate: 0h > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18892) Distributed tests can return ordering columns that have not been selected
[
https://issues.apache.org/jira/browse/CASSANDRA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770459#comment-17770459
]
Mike Adamson commented on CASSANDRA-18892:
--
Patches and test runs are here:
|[4.0|https://github.com/apache/cassandra/pull/2753]|[CircleCI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/301/workflows/49fae50f-5a55-4d7b-8af7-13b6d2251648]|
|[4.1|https://github.com/apache/cassandra/pull/2754]|[CircleCI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/302/workflows/11e95c09-680b-4520-a3c4-b53223002ae7]|
|[5.0|https://github.com/apache/cassandra/pull/2750]|[CircleCI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/298/workflows/9f9294d8-0025-438a-a93b-0f8f5a06a900]|
|[trunk|https://github.com/apache/cassandra/pull/2752]|[CircleCI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/299/workflows/42674922-f4ca-4cb9-ad4e-d99d8f749a44]|
> Distributed tests can return ordering columns that have not been selected
> -
>
> Key: CASSANDRA-18892
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18892
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
>
> The following test fails
> {code:java}
> @Test
> public void incorrectClusteringColumnTest() throws IOException
> {
> try (Cluster cluster = init(Cluster.build(1).start()))
> {
> cluster.schemaChange(withKeyspace("CREATE TABLE %s.t (k int, c int, v
> int, primary key(k, c))"));
> cluster.coordinator(1).execute(withKeyspace("INSERT INTO %s.t (k, c,
> v) VALUES (0, 1, 2)"), ConsistencyLevel.QUORUM);
> String query = withKeyspace("SELECT v FROM %s.t WHERE k IN (0, 1)
> ORDER BY c LIMIT 10");
> assertRows(cluster.coordinator(1).execute(query,
> ConsistencyLevel.ONE), row(2));
> }
> }
> {code}
> The query is returning the clustering column c as well as the regular column
> v.
> The reason for the extra column being returned is that the RowUtil is using
> ResultMessage.Rows.result.metadata.names instead on
> ResultMessage.Rows.result.metadata.requestNames(). This last method removes
> columns that have not been requested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18891) Cassandra 4.0 - JNA 5.6.0 does not support arm64
[ https://issues.apache.org/jira/browse/CASSANDRA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770457#comment-17770457 ] Maxim Muzafarov commented on CASSANDRA-18891: - Sure, will take a look. Assigned to myself. > Cassandra 4.0 - JNA 5.6.0 does not support arm64 > > > Key: CASSANDRA-18891 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18891 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Thomas Steinmaurer >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.0.x > > > As discussed on Slack: > [https://the-asf.slack.com/archives/CJZLTM05A/p1684745250901489] > Created this ticket as clone of CASSANDRA-17019, to ask for considering a JNA > library upgrade in Cassandra 4.0, so that we could utilize ARM-based AWS > Gravition instances e.g. m7g already with Cassandra 4.0. > From linked ticket: > "Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native > binding into the C library. JNA 5.6.0 does not support arm64 architecture > (Apple M1 devices), causing cassandra to fail on bootstrap." -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18891) Cassandra 4.0 - JNA 5.6.0 does not support arm64
[ https://issues.apache.org/jira/browse/CASSANDRA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-18891: --- Assignee: Maxim Muzafarov > Cassandra 4.0 - JNA 5.6.0 does not support arm64 > > > Key: CASSANDRA-18891 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18891 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Thomas Steinmaurer >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.0.x > > > As discussed on Slack: > [https://the-asf.slack.com/archives/CJZLTM05A/p1684745250901489] > Created this ticket as clone of CASSANDRA-17019, to ask for considering a JNA > library upgrade in Cassandra 4.0, so that we could utilize ARM-based AWS > Gravition instances e.g. m7g already with Cassandra 4.0. > From linked ticket: > "Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native > binding into the C library. JNA 5.6.0 does not support arm64 architecture > (Apple M1 devices), causing cassandra to fail on bootstrap." -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18887) CEP-21 - Implement missing features and various other fixes
[ https://issues.apache.org/jira/browse/CASSANDRA-18887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770455#comment-17770455 ] Sam Tunnicliffe commented on CASSANDRA-18887: - +1 lgtm too > CEP-21 - Implement missing features and various other fixes > --- > > Key: CASSANDRA-18887 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18887 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > > [CEP-21] fix cqlshlib tests > https://github.com/krummas/cassandra/commit/31a4f59449 > Add cluster_metadata keyspace where needed > [CEP-21] remove authsetup > https://github.com/krummas/cassandra/commit/4cab51d76b > Avoid calling doAuthSetup twice > [CEP-21] serialize MemtableParams when writing TableParams > https://github.com/krummas/cassandra/commit/602c01a7b4 > Missed in earlier rebase, need to serialize MemtableParams when saving a > snapshot > [CEP-21] Upgrading a one node cluster to TCM fails attempting Gossip shadow > round > https://github.com/krummas/cassandra/commit/3feb3b1a58 > Upgrading fails due to first upgraded node waiting for gossip state from > peers. > [CEP-21] Implement replacement with same address > https://github.com/krummas/cassandra/commit/a05bbc4870 > Add back missing replace with same address feature > [CEP-21] fix nodetool bootstrap resume > https://github.com/krummas/cassandra/commit/061b835dae > Add back missing nodetool bootstrap resume feature > [CEP-21] Remove LEFT peers from system tables and exclude them during startup > https://github.com/krummas/cassandra/commit/4bc9dc674b > Avoid trying to gossip with LEFT peers > [CEP-21] Fix flaky distributed log test. While it fails very infrequently on > CI, it consistently fails locally. > https://github.com/krummas/cassandra/commit/f231e9dda9 > Test fix > [CEP-21] Retry indefinitely for STARTUP messages. > https://github.com/krummas/cassandra/commit/7f9e88857e > If the CMS is down and we try to upgrade an instance we should block until > the CMS comes back > [CEP-21] Implement versioning for ranges > https://github.com/krummas/cassandra/commit/a170b9f349 > To be able to know if the coordinator has the correct ring view we keep track > of when a range was last updated. If coordinator has not seen this update we > fail the request. > [CEP-21] Handle case where removenode requires no streaming to restore RF > https://github.com/krummas/cassandra/commit/68054d3ec0 > [CEP-21] Remove redundant Keyspaces arg from SchemaTransformation::apply > https://github.com/krummas/cassandra/commit/fe1c132946 > Code cleanup > [CEP-21] Don't trigger client warnings or guardrails when executing > AlterSchema transformations > https://github.com/krummas/cassandra/commit/dbbd96c9ad > Avoid getting multiple client warnings > [CEP-21] Validate schema alterations on coordinator > https://github.com/krummas/cassandra/commit/4711053513 > [CEP-21] Add a script for simulation running > https://github.com/krummas/cassandra/commit/94543e9230 > [CEP-21] Add nextId to Directory serialization and make it possible to bump > metadata serialization version > https://github.com/krummas/cassandra/commit/6d5d6a8bc6 > Previously, on bounce, each instance calculated which nodeId we should give a > new node by counting the number of instances in the cluster, this can diverge > so that different nodes have different ids. Fixed by serializing the current > nextId when storing snapshot. > [CEP-21] Add metric for CMS membership > https://github.com/krummas/cassandra/commit/bbdd165013 > [CEP-21] Reenable starting without joining (-Dcassandra.join_ring=false) > https://github.com/krummas/cassandra/commit/565c3747c5 > Add back missing join_ring=false feature. > [CEP-21] Preparing DDL statements should capture the CQL string > https://github.com/krummas/cassandra/commit/4608a74c64 > Avoid NPE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18891) Cassandra 4.0 - JNA 5.6.0 does not support arm64
[ https://issues.apache.org/jira/browse/CASSANDRA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770453#comment-17770453 ] Stefan Miklosovic commented on CASSANDRA-18891: --- [~mmuzaf] would you take a look at this if you have some time, please? I think we need to find out if 5.13 of jna is compatible with 4.0+. > Cassandra 4.0 - JNA 5.6.0 does not support arm64 > > > Key: CASSANDRA-18891 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18891 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Thomas Steinmaurer >Priority: Normal > Fix For: 4.0.x > > > As discussed on Slack: > [https://the-asf.slack.com/archives/CJZLTM05A/p1684745250901489] > Created this ticket as clone of CASSANDRA-17019, to ask for considering a JNA > library upgrade in Cassandra 4.0, so that we could utilize ARM-based AWS > Gravition instances e.g. m7g already with Cassandra 4.0. > From linked ticket: > "Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native > binding into the C library. JNA 5.6.0 does not support arm64 architecture > (Apple M1 devices), causing cassandra to fail on bootstrap." -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18742: -- Fix Version/s: 5.0-alpha2 5.1 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/b9f614f7e56b8b12149cb51f89558d0568901853 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.0-alpha2, 5.1 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (fbf6508940 -> fdbb975188)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from fbf6508940 ninja fix for CASSANDRA-18827 add b9f614f7e5 Remove deprecated properties in CompressionParams new fdbb975188 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + pylib/cqlshlib/cql3handling.py | 6 +- pylib/cqlshlib/test/test_keyspace_init.cql | 2 +- .../apache/cassandra/schema/CompressionParams.java | 74 +++--- .../apache/cassandra/distributed/util/PyDtest.java | 2 +- .../test/microbench/CachingBenchTest.java | 2 +- .../miscellaneous/CrcCheckChanceTest.java | 10 +-- .../cql3/validation/operations/AlterTest.java | 9 +-- .../cql3/validation/operations/CreateTest.java | 22 +-- .../GuardrailAllowUncompressedTablesTest.java | 8 +-- .../cassandra/io/compress/CQLCompressionTest.java | 14 ++-- tools/cqlstress-example.yaml | 2 +- .../cassandra/stress/settings/SettingsSchema.java | 4 +- 13 files changed, 39 insertions(+), 117 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (6de90bf75c -> b9f614f7e5)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 6de90bf75c Fix LongCompactionTest add b9f614f7e5 Remove deprecated properties in CompressionParams No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + NEWS.txt | 1 + pylib/cqlshlib/cql3handling.py | 6 +- pylib/cqlshlib/test/test_keyspace_init.cql | 2 +- .../apache/cassandra/schema/CompressionParams.java | 74 +++--- .../apache/cassandra/distributed/util/PyDtest.java | 2 +- .../test/microbench/CachingBenchTest.java | 2 +- .../miscellaneous/CrcCheckChanceTest.java | 10 +-- .../cql3/validation/operations/AlterTest.java | 9 +-- .../cql3/validation/operations/CreateTest.java | 22 +-- .../GuardrailAllowUncompressedTablesTest.java | 8 +-- .../cassandra/io/compress/CQLCompressionTest.java | 14 ++-- tools/cqlstress-example.yaml | 2 +- .../cassandra/stress/settings/SettingsSchema.java | 4 +- 14 files changed, 40 insertions(+), 117 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit fdbb9751886ab4be2f59e041c0e3354c1c786065 Merge: fbf6508940 b9f614f7e5 Author: Stefan Miklosovic AuthorDate: Fri Sep 29 15:19:20 2023 +0200 Merge branch 'cassandra-5.0' into trunk CHANGES.txt| 1 + pylib/cqlshlib/cql3handling.py | 6 +- pylib/cqlshlib/test/test_keyspace_init.cql | 2 +- .../apache/cassandra/schema/CompressionParams.java | 74 +++--- .../apache/cassandra/distributed/util/PyDtest.java | 2 +- .../test/microbench/CachingBenchTest.java | 2 +- .../miscellaneous/CrcCheckChanceTest.java | 10 +-- .../cql3/validation/operations/AlterTest.java | 9 +-- .../cql3/validation/operations/CreateTest.java | 22 +-- .../GuardrailAllowUncompressedTablesTest.java | 8 +-- .../cassandra/io/compress/CQLCompressionTest.java | 14 ++-- tools/cqlstress-example.yaml | 2 +- .../cassandra/stress/settings/SettingsSchema.java | 4 +- 13 files changed, 39 insertions(+), 117 deletions(-) diff --cc CHANGES.txt index 83ffa9a7d7,eb6b6779b9..78e7e350e9 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,8 -1,5 +1,9 @@@ -5.0-alpha2 +5.1 + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Remove deprecated properties in CompressionParams (CASSANDRA-18742) * Add support for repair coordinator to retry messages that timeout (CASSANDRA-18816) * Upgrade slf4j-api to 1.7.36 (CASSANDRA-18882) * Make the output of ON/OFF commands in cqlsh consistent (CASSANDRA-18547) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: CASSANDRA-18742 alignement
This is an automated email from the ASF dual-hosted git repository.
smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new d1a9bb32 CASSANDRA-18742 alignement
d1a9bb32 is described below
commit d1a9bb3295aabc7df4ad0b1dce29bdda9acc5fe7
Author: Stefan Miklosovic
AuthorDate: Mon Sep 18 15:46:53 2023 +0200
CASSANDRA-18742 alignement
patch by Stefan Miklosovic; reviewed by Maxim Muzafarov, Brandon Williams
for CASSANDRA-18742
---
configuration_test.py | 4 ++--
counter_test.py | 2 +-
cqlsh_tests/test_cqlsh.py | 2 +-
dtest.py | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/configuration_test.py b/configuration_test.py
index 2acf18ec..04eb220a 100644
--- a/configuration_test.py
+++ b/configuration_test.py
@@ -35,8 +35,8 @@ class TestConfiguration(Tester):
create_table_query = "CREATE TABLE test_table (row varchar, name
varchar, value int, PRIMARY KEY (row, name));"
alter_chunk_len_query = "ALTER TABLE test_table WITH " \
-"compression = {{'sstable_compression' :
'SnappyCompressor', " \
-"'chunk_length_kb' : {chunk_length}}};"
+"compression = {{'class' : 'SnappyCompressor',
" \
+"'chunk_length_in_kb' : {chunk_length}}};"
session.execute(create_table_query)
diff --git a/counter_test.py b/counter_test.py
index aa8215e0..44d37fcf 100644
--- a/counter_test.py
+++ b/counter_test.py
@@ -177,7 +177,7 @@ class TestCounters(Tester):
c counter
)
"""
-query = query + "WITH compression = { 'sstable_compression' :
'SnappyCompressor' }"
+query = query + "WITH compression = { 'class' : 'SnappyCompressor' }"
session.execute(query)
time.sleep(2)
diff --git a/cqlsh_tests/test_cqlsh.py b/cqlsh_tests/test_cqlsh.py
index ed64f358..044f9f44 100644
--- a/cqlsh_tests/test_cqlsh.py
+++ b/cqlsh_tests/test_cqlsh.py
@@ -624,7 +624,7 @@ CREATE TABLE has_all_types (
uuidcol uuid,
varcharcol varchar,
varintcol varint
-) WITH compression = {'sstable_compression':'LZ4Compressor'};
+) WITH compression = {'class':'LZ4Compressor'};
INSERT INTO has_all_types (num, intcol, asciicol, bigintcol, blobcol,
booleancol,
decimalcol, doublecol, floatcol, textcol,
diff --git a/dtest.py b/dtest.py
index 4a167e12..859922eb 100644
--- a/dtest.py
+++ b/dtest.py
@@ -335,7 +335,7 @@ def create_cf(session, name, key_type="varchar",
speculative_retry=None, read_re
query = '%s AND CLUSTERING ORDER BY (%s)' % (query, clustering)
if compression is not None:
-query = '%s AND compression = { \'sstable_compression\':
\'%sCompressor\' }' % (query, compression)
+query = '%s AND compression = { \'class\': \'%sCompressor\' }' %
(query, compression)
else:
# if a compression option is omitted, C* will default to lz4
compression
query += ' AND compression = {}'
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18742: -- Reviewers: Brandon Williams, Maxim Muzafarov Status: Review In Progress (was: Patch Available) > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18742: -- Status: Ready to Commit (was: Review In Progress) > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770434#comment-17770434 ] Stefan Miklosovic commented on CASSANDRA-18742: --- to be extra sure, more tests, j11 precommit (1) this (2) is 4.0 branch running dtests with the proposed dtest branch to check it will not break older branches (1) [https://app.circleci.com/pipelines/github/instaclustr/cassandra/3279/workflows/b67b1c59-10ae-4dfa-a559-a71a6571f4bc] (2) [https://app.circleci.com/pipelines/github/instaclustr/cassandra/3280/workflows/3048fb27-6dd5-4b52-89ff-5f9f472d9666] > Remove deprecated options in CompressionParams > -- > > Key: CASSANDRA-18742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18742 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These should go away (1). They were deprecated like 8 years ago in > CASSANDRA-9712 and CASSANDRA-9839. > We should also remove this (2). That is a little bit more tricky but nothing > special I would say ... > (1) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88 > (2) > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18892) Distributed tests can return ordering columns that have not been selected
[
https://issues.apache.org/jira/browse/CASSANDRA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770432#comment-17770432
]
Jeremiah Jordan commented on CASSANDRA-18892:
-
Looks good to me. Nice catch.
> Distributed tests can return ordering columns that have not been selected
> -
>
> Key: CASSANDRA-18892
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18892
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
>
> The following test fails
> {code:java}
> @Test
> public void incorrectClusteringColumnTest() throws IOException
> {
> try (Cluster cluster = init(Cluster.build(1).start()))
> {
> cluster.schemaChange(withKeyspace("CREATE TABLE %s.t (k int, c int, v
> int, primary key(k, c))"));
> cluster.coordinator(1).execute(withKeyspace("INSERT INTO %s.t (k, c,
> v) VALUES (0, 1, 2)"), ConsistencyLevel.QUORUM);
> String query = withKeyspace("SELECT v FROM %s.t WHERE k IN (0, 1)
> ORDER BY c LIMIT 10");
> assertRows(cluster.coordinator(1).execute(query,
> ConsistencyLevel.ONE), row(2));
> }
> }
> {code}
> The query is returning the clustering column c as well as the regular column
> v.
> The reason for the extra column being returned is that the RowUtil is using
> ResultMessage.Rows.result.metadata.names instead on
> ResultMessage.Rows.result.metadata.requestNames(). This last method removes
> columns that have not been requested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18894) Drop commitlog chain marker updates
Branimir Lambov created CASSANDRA-18894: --- Summary: Drop commitlog chain marker updates Key: CASSANDRA-18894 URL: https://issues.apache.org/jira/browse/CASSANDRA-18894 Project: Cassandra Issue Type: Improvement Components: Local/Commit Log Reporter: Branimir Lambov CASSANDRA-13987 added a periodic update of the last commit log chain marker in order to allow for data in memory-mapped segments to be recovered even if it was not part of a synced segment. A much simpler way to do this is something in the vein of CASSANDRA-16482, i.e. ignoring an empty sync marker for the last entry in the commit log. We could do this by default if the commit log is uncompressed (and possibly only if using memory mapping after CASSANDRA-18464). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18464) Enable Direct I/O For CommitLog Files
[ https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branimir Lambov updated CASSANDRA-18464: Reviewers: Branimir Lambov Status: Review In Progress (was: Patch Available) > Enable Direct I/O For CommitLog Files > - > > Key: CASSANDRA-18464 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18464 > Project: Cassandra > Issue Type: New Feature > Components: Local/Commit Log >Reporter: Josh McKenzie >Assignee: Amit Pawar >Priority: Normal > Fix For: 5.x > > Attachments: CommitLogStressTest.patch, > EnableDirectIOForCommitLogUsingNativeAPI.patch, > PeriodicCommitLogStressTest.tar.bz2, SetCommitLogFileSize.patch, > UseDirectIOFeatureForCommitLogFiles.patch, image-2023-06-29-01-12-49-382.png > > > Relocating from [dev@ email > thread.|https://lists.apache.org/thread/j6ny17q2rhkp7jxvwxm69dd6v1dozjrg] > > I shared my investigation about Commitlog I/O issue on large core count > system in my previous email dated July-22 and link to the thread is given > below. > [https://lists.apache.org/thread/xc5ocog2qz2v2gnj4xlw5hbthfqytx2n] > Basically, two solutions looked possible to improve the CommitLog I/O. > # Multi-threaded syncing > # Using Direct-IO through JNA > I worked on 2nd option considering the following benefit compared to the > first one > # Direct I/O read/write throughput is very high compared to non-Direct I/O. > Learnt through FIO benchmarking. > # Reduces kernel file cache uses which in-turn reduces kernel I/O activity > for Commitlog files only. > # Overall CPU usage reduced for flush activity. JVisualvm shows CPU usage < > 30% for Commitlog syncer thread with Direct I/O feature > # Direct I/O implementation is easier compared to multi-threaded > As per the community suggestion, less in code complex is good to have. Direct > I/O enablement looked promising but there was one issue. > Java version 8 does not have native support to enable Direct I/O. So, JNA > library usage is must. The same implementation should also work across other > versions of Java (like 11 and beyond). > I have completed Direct I/O implementation and summary of the attached patch > changes are given below. > # This implementation is not using Java file channels and file is opened > through JNA to use Direct I/O feature. > # New Segment are defined named “DirectIOSegment” for Direct I/O and > “NonDirectIOSegment” for non-direct I/O (NonDirectIOSegment is test purpose > only). > # JNA write call is used to flush the changes. > # New helper functions are defined in NativeLibrary.java and platform > specific file. Currently tested on Linux only. > # Patch allows user to configure optimum block size and alignment if > default values are not OK for CommitLog disk. > # Following configuration options are provided in Cassandra.yaml file > a. use_jna_for_commitlog_io : to use jna feature > b. use_direct_io_for_commitlog : to use Direct I/O feature. > c. direct_io_minimum_block_alignment: 512 (default) > d. nvme_disk_block_size: 32MiB (default and can be changed as per the > required size) > Test matrix is complex so CommitLog related testcases and TPCx-IOT benchmark > was tested. It works with both Java 8 and 11 versions. Compressed and > Encrypted based segments are not supported yet and it can be enabled later > based on the Community feedback. > Following improvement are seen with Direct I/O enablement. > # 32 cores >= ~15% > # 64 cores >= ~80% > Also, another observation would like to share here. Reading Commitlog files > with Direct I/O might help in reducing node bring-up time after the node > crash. > Tested with commit ID: 91f6a9aca8d3c22a03e68aa901a0b154d960ab07 > The attached patch enables Direct I/O feature for Commitlog files. Please > check and share your feedback. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18464) Enable Direct I/O For CommitLog Files
[ https://issues.apache.org/jira/browse/CASSANDRA-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770415#comment-17770415 ] Branimir Lambov commented on CASSANDRA-18464: - This patch is very valuable, and I support if going into 5.0 as well as 5.1. In separate tests we have often found a memory-mapped commit log to be a serious performance problem for a node with a lot of data. Even without DIRECT or JNA, not using `msync` is making a huge difference. Because of this most of the performance testing I personally do is done with compressed commit log. I added comments to [the latest published branch|https://github.com/driftx/cassandra/tree/CASSANDRA-18464-trunk] with some suggested changes. I am curious, if the NIO option is constructed correctly (with aligned direct buffers, possibly also issuing the writes to be page-aligned and containing whole pages), is it still copying to internal buffers? > Enable Direct I/O For CommitLog Files > - > > Key: CASSANDRA-18464 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18464 > Project: Cassandra > Issue Type: New Feature > Components: Local/Commit Log >Reporter: Josh McKenzie >Assignee: Amit Pawar >Priority: Normal > Fix For: 5.x > > Attachments: CommitLogStressTest.patch, > EnableDirectIOForCommitLogUsingNativeAPI.patch, > PeriodicCommitLogStressTest.tar.bz2, SetCommitLogFileSize.patch, > UseDirectIOFeatureForCommitLogFiles.patch, image-2023-06-29-01-12-49-382.png > > > Relocating from [dev@ email > thread.|https://lists.apache.org/thread/j6ny17q2rhkp7jxvwxm69dd6v1dozjrg] > > I shared my investigation about Commitlog I/O issue on large core count > system in my previous email dated July-22 and link to the thread is given > below. > [https://lists.apache.org/thread/xc5ocog2qz2v2gnj4xlw5hbthfqytx2n] > Basically, two solutions looked possible to improve the CommitLog I/O. > # Multi-threaded syncing > # Using Direct-IO through JNA > I worked on 2nd option considering the following benefit compared to the > first one > # Direct I/O read/write throughput is very high compared to non-Direct I/O. > Learnt through FIO benchmarking. > # Reduces kernel file cache uses which in-turn reduces kernel I/O activity > for Commitlog files only. > # Overall CPU usage reduced for flush activity. JVisualvm shows CPU usage < > 30% for Commitlog syncer thread with Direct I/O feature > # Direct I/O implementation is easier compared to multi-threaded > As per the community suggestion, less in code complex is good to have. Direct > I/O enablement looked promising but there was one issue. > Java version 8 does not have native support to enable Direct I/O. So, JNA > library usage is must. The same implementation should also work across other > versions of Java (like 11 and beyond). > I have completed Direct I/O implementation and summary of the attached patch > changes are given below. > # This implementation is not using Java file channels and file is opened > through JNA to use Direct I/O feature. > # New Segment are defined named “DirectIOSegment” for Direct I/O and > “NonDirectIOSegment” for non-direct I/O (NonDirectIOSegment is test purpose > only). > # JNA write call is used to flush the changes. > # New helper functions are defined in NativeLibrary.java and platform > specific file. Currently tested on Linux only. > # Patch allows user to configure optimum block size and alignment if > default values are not OK for CommitLog disk. > # Following configuration options are provided in Cassandra.yaml file > a. use_jna_for_commitlog_io : to use jna feature > b. use_direct_io_for_commitlog : to use Direct I/O feature. > c. direct_io_minimum_block_alignment: 512 (default) > d. nvme_disk_block_size: 32MiB (default and can be changed as per the > required size) > Test matrix is complex so CommitLog related testcases and TPCx-IOT benchmark > was tested. It works with both Java 8 and 11 versions. Compressed and > Encrypted based segments are not supported yet and it can be enabled later > based on the Community feedback. > Following improvement are seen with Direct I/O enablement. > # 32 cores >= ~15% > # 64 cores >= ~80% > Also, another observation would like to share here. Reading Commitlog files > with Direct I/O might help in reducing node bring-up time after the node > crash. > Tested with commit ID: 91f6a9aca8d3c22a03e68aa901a0b154d960ab07 > The attached patch enables Direct I/O feature for Commitlog files. Please > check and share your feedback. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail:
[jira] [Commented] (CASSANDRA-18887) CEP-21 - Implement missing features and various other fixes
[ https://issues.apache.org/jira/browse/CASSANDRA-18887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770390#comment-17770390 ] Alex Petrov commented on CASSANDRA-18887: - +1, lgtm > CEP-21 - Implement missing features and various other fixes > --- > > Key: CASSANDRA-18887 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18887 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > > [CEP-21] fix cqlshlib tests > https://github.com/krummas/cassandra/commit/31a4f59449 > Add cluster_metadata keyspace where needed > [CEP-21] remove authsetup > https://github.com/krummas/cassandra/commit/4cab51d76b > Avoid calling doAuthSetup twice > [CEP-21] serialize MemtableParams when writing TableParams > https://github.com/krummas/cassandra/commit/602c01a7b4 > Missed in earlier rebase, need to serialize MemtableParams when saving a > snapshot > [CEP-21] Upgrading a one node cluster to TCM fails attempting Gossip shadow > round > https://github.com/krummas/cassandra/commit/3feb3b1a58 > Upgrading fails due to first upgraded node waiting for gossip state from > peers. > [CEP-21] Implement replacement with same address > https://github.com/krummas/cassandra/commit/a05bbc4870 > Add back missing replace with same address feature > [CEP-21] fix nodetool bootstrap resume > https://github.com/krummas/cassandra/commit/061b835dae > Add back missing nodetool bootstrap resume feature > [CEP-21] Remove LEFT peers from system tables and exclude them during startup > https://github.com/krummas/cassandra/commit/4bc9dc674b > Avoid trying to gossip with LEFT peers > [CEP-21] Fix flaky distributed log test. While it fails very infrequently on > CI, it consistently fails locally. > https://github.com/krummas/cassandra/commit/f231e9dda9 > Test fix > [CEP-21] Retry indefinitely for STARTUP messages. > https://github.com/krummas/cassandra/commit/7f9e88857e > If the CMS is down and we try to upgrade an instance we should block until > the CMS comes back > [CEP-21] Implement versioning for ranges > https://github.com/krummas/cassandra/commit/a170b9f349 > To be able to know if the coordinator has the correct ring view we keep track > of when a range was last updated. If coordinator has not seen this update we > fail the request. > [CEP-21] Handle case where removenode requires no streaming to restore RF > https://github.com/krummas/cassandra/commit/68054d3ec0 > [CEP-21] Remove redundant Keyspaces arg from SchemaTransformation::apply > https://github.com/krummas/cassandra/commit/fe1c132946 > Code cleanup > [CEP-21] Don't trigger client warnings or guardrails when executing > AlterSchema transformations > https://github.com/krummas/cassandra/commit/dbbd96c9ad > Avoid getting multiple client warnings > [CEP-21] Validate schema alterations on coordinator > https://github.com/krummas/cassandra/commit/4711053513 > [CEP-21] Add a script for simulation running > https://github.com/krummas/cassandra/commit/94543e9230 > [CEP-21] Add nextId to Directory serialization and make it possible to bump > metadata serialization version > https://github.com/krummas/cassandra/commit/6d5d6a8bc6 > Previously, on bounce, each instance calculated which nodeId we should give a > new node by counting the number of instances in the cluster, this can diverge > so that different nodes have different ids. Fixed by serializing the current > nextId when storing snapshot. > [CEP-21] Add metric for CMS membership > https://github.com/krummas/cassandra/commit/bbdd165013 > [CEP-21] Reenable starting without joining (-Dcassandra.join_ring=false) > https://github.com/krummas/cassandra/commit/565c3747c5 > Add back missing join_ring=false feature. > [CEP-21] Preparing DDL statements should capture the CQL string > https://github.com/krummas/cassandra/commit/4608a74c64 > Avoid NPE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18856) Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
[
https://issues.apache.org/jira/browse/CASSANDRA-18856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18856:
-
Fix Version/s: 4.0.12
4.1.4
5.0-alpha2
5.1
(was: 5.x)
(was: 4.0.x)
(was: 4.1.x)
(was: 5.0.x)
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra-dtest/commit/e86a767ab82acd02322ad2004eb738e6df5f35b2
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Oops, sorry, I thought I had done a better job of linking that, but I did not.
Thanks, committed.
> Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
> -
>
> Key: CASSANDRA-18856
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18856
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-alpha2, 5.1
>
>
> https://app.circleci.com/pipelines/github/driftx/cassandra/1294/workflows/04464235-3bcf-433e-ae81-206aa2c9c874/jobs/54042/tests
> {quote}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-d94b6b54] 2023-09-15 16:04:30,685
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)', [node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-6f7e3946] 2023-09-15 16:04:30,687
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']"
> {quote}
> This is probably similar to CASSANDRA-18815
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands,
[cassandra-dtest] branch trunk updated: Ignore new streaming error in test_resumable_rebuild
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git The following commit(s) were added to refs/heads/trunk by this push: new e86a767a Ignore new streaming error in test_resumable_rebuild e86a767a is described below commit e86a767ab82acd02322ad2004eb738e6df5f35b2 Author: Brandon Williams AuthorDate: Mon Sep 18 09:13:52 2023 -0500 Ignore new streaming error in test_resumable_rebuild Patch by brandonwilliams; reviewed by bereng for CASSANDRA-18856 --- rebuild_test.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rebuild_test.py b/rebuild_test.py index 48e64e84..776e2b99 100644 --- a/rebuild_test.py +++ b/rebuild_test.py @@ -29,7 +29,9 @@ class TestRebuild(Tester): r'Exception encountered during startup', r'Streaming error occurred', # ignore streaming error during resumable tests -r'peer 127.0.0.3:7000 is probably down' +r'peer 127.0.0.3:7000 is probably down', +r'Error while reading sstable from stream', +r'failed to send a stream message/data to peer /127.0.0.2:7000' ) def test_simple_rebuild(self): - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18892) Distributed tests can return ordering columns that have not been selected
[
https://issues.apache.org/jira/browse/CASSANDRA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Adamson updated CASSANDRA-18892:
-
Test and Documentation Plan:
This is fix the in-tree distributed test code so adds a single test to confirm
the fix.
The current test run against 5.0 is here:
https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/297/workflows/c41159b6-57f2-4bce-a238-68e52b43fc2c
Status: Patch Available (was: In Progress)
> Distributed tests can return ordering columns that have not been selected
> -
>
> Key: CASSANDRA-18892
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18892
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
>
> The following test fails
> {code:java}
> @Test
> public void incorrectClusteringColumnTest() throws IOException
> {
> try (Cluster cluster = init(Cluster.build(1).start()))
> {
> cluster.schemaChange(withKeyspace("CREATE TABLE %s.t (k int, c int, v
> int, primary key(k, c))"));
> cluster.coordinator(1).execute(withKeyspace("INSERT INTO %s.t (k, c,
> v) VALUES (0, 1, 2)"), ConsistencyLevel.QUORUM);
> String query = withKeyspace("SELECT v FROM %s.t WHERE k IN (0, 1)
> ORDER BY c LIMIT 10");
> assertRows(cluster.coordinator(1).execute(query,
> ConsistencyLevel.ONE), row(2));
> }
> }
> {code}
> The query is returning the clustering column c as well as the regular column
> v.
> The reason for the extra column being returned is that the RowUtil is using
> ResultMessage.Rows.result.metadata.names instead on
> ResultMessage.Rows.result.metadata.requestNames(). This last method removes
> columns that have not been requested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18892) Distributed tests can return ordering columns that have not been selected
[
https://issues.apache.org/jira/browse/CASSANDRA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Adamson updated CASSANDRA-18892:
-
Source Control Link: https://github.com/apache/cassandra/pull/2750
> Distributed tests can return ordering columns that have not been selected
> -
>
> Key: CASSANDRA-18892
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18892
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
>
> The following test fails
> {code:java}
> @Test
> public void incorrectClusteringColumnTest() throws IOException
> {
> try (Cluster cluster = init(Cluster.build(1).start()))
> {
> cluster.schemaChange(withKeyspace("CREATE TABLE %s.t (k int, c int, v
> int, primary key(k, c))"));
> cluster.coordinator(1).execute(withKeyspace("INSERT INTO %s.t (k, c,
> v) VALUES (0, 1, 2)"), ConsistencyLevel.QUORUM);
> String query = withKeyspace("SELECT v FROM %s.t WHERE k IN (0, 1)
> ORDER BY c LIMIT 10");
> assertRows(cluster.coordinator(1).execute(query,
> ConsistencyLevel.ONE), row(2));
> }
> }
> {code}
> The query is returning the clustering column c as well as the regular column
> v.
> The reason for the extra column being returned is that the RowUtil is using
> ResultMessage.Rows.result.metadata.names instead on
> ResultMessage.Rows.result.metadata.requestNames(). This last method removes
> columns that have not been requested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18805) Upgrade caffeine to 3.1.8
[ https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18805: Reviewers: Ben Manes, Shailaja Koppu, Yifan Cai (was: Ben Manes, Berenguer Blasi, Shailaja Koppu, Yifan Cai) > Upgrade caffeine to 3.1.8 > - > > Key: CASSANDRA-18805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18805 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > 3.1.8 is based on Java 11. This version is testing with newer JDK versions, > while 2.x versions are based on JDK8, and as I understand, only bug-fix > releases are expected. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18733) Waiting indefinitely on ReceivedMessage response in StreamSession#receive() can cause deadlock
[
https://issues.apache.org/jira/browse/CASSANDRA-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770373#comment-17770373
]
Andres de la Peña commented on CASSANDRA-18733:
---
None of the above CircleCI runs contains the repeated runs of the modified
files ({{StreamDisconnectedWhileReceivingTest.java}}). I think this is due to a
bug in the non-public script used to generate the CircleCI config file.
Those repeated runs can be generated with the project's
[{{.circleci/generate.sh}}|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh]
script.
The absence of repeated runs can be easily detected by looking at the CI
results, in the workflow view. If the patch contains any changes on tests there
should be jobs named with the {{_repeat}} suffix. One can also check whether
the pushed {{.circleci/config.yml}} file contains the names of relevant tests.
> Waiting indefinitely on ReceivedMessage response in StreamSession#receive()
> can cause deadlock
> --
>
> Key: CASSANDRA-18733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18733
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Consistency/Streaming
>Reporter: Caleb Rackliffe
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.1.4, 5.0, 5.0-alpha1, 5.1
>
>
> I've observed in a recent stack trace from a node running 4.1 what looks like
> a deadlock around the {{StreamSession}} monitor lock when
> {{StreamSession#receive()}} waits via {{syncUninteruptibly()}} for a response
> to a control message.
> {noformat}
> "Messaging-EventLoop-3-10" #320 daemon prio=5 os_prio=0 cpu=57979617.98ms
> elapsed=5587916.03s tid=0x7f056e88ae00 nid=0x80ec waiting for monitor
> entry [0x7f056d277000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.cassandra.streaming.StreamSession.closeSession(StreamSession.java:524)
> - waiting to lock <0x0006816fae70> (a
> org.apache.cassandra.streaming.StreamSession)
> at
> org.apache.cassandra.streaming.StreamSession.onError(StreamSession.java:690)
> at
> org.apache.cassandra.streaming.async.StreamingMultiplexedChannel.onMessageComplete(StreamingMultiplexedChannel.java:264)
> at
> org.apache.cassandra.streaming.async.StreamingMultiplexedChannel.lambda$sendMessage$1(StreamingMultiplexedChannel.java:233)
> at
> org.apache.cassandra.streaming.async.StreamingMultiplexedChannel$$Lambda$2029/0x0008007a0c40.operationComplete(Unknown
> Source)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:134)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyListener(ListenerList.java:148)
> at
> org.apache.cassandra.utils.concurrent.ListenerList$GenericFutureListenerList.notifySelf(ListenerList.java:190)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.lambda$notifyExclusive$0(ListenerList.java:124)
> at
> org.apache.cassandra.utils.concurrent.ListenerList$$Lambda$950/0x000800666040.accept(Unknown
> Source)
> at
> org.apache.cassandra.utils.concurrent.IntrusiveStack.forEach(IntrusiveStack.java:195)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notifyExclusive(ListenerList.java:124)
> at
> org.apache.cassandra.utils.concurrent.ListenerList.notify(ListenerList.java:96)
> at
> org.apache.cassandra.utils.concurrent.AsyncFuture.trySet(AsyncFuture.java:104)
> at
> org.apache.cassandra.utils.concurrent.AbstractFuture.tryFailure(AbstractFuture.java:148)
> at
> org.apache.cassandra.utils.concurrent.AsyncPromise.tryFailure(AsyncPromise.java:139)
> at
> io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetFailure(AbstractChannel.java:1009)
> at
> io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:870)
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1367)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:764)
> at
> io.netty.channel.AbstractChannelHandlerContext$WriteTask.run(AbstractChannelHandlerContext.java:1071)
> at
> io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384)
> at
>
[jira] [Commented] (CASSANDRA-18725) IsolatedJMX should not release all TCPEndpoints on instance shutdown
[
https://issues.apache.org/jira/browse/CASSANDRA-18725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770375#comment-17770375
]
Andres de la Peña commented on CASSANDRA-18725:
---
None of the above CircleCI runs contains the repeated runs of the modified
files ({{ResourceLeakTest}}, {{JMXFeatureTest}} and {{JMXGetterCheckTest}}). I
think this is due to a bug in the non-public script used to generate the
CircleCI config file.
Those repeated runs can be generated with the project's
[{{.circleci/generate.sh}}|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh]
script.
The absence of repeated runs can be easily detected by looking at the CI
results, in the workflow view. If the patch contains any changes on tests there
should be jobs named with the {{_repeat}} suffix. One can also check whether
the pushed {{.circleci/config.yml}} file contains the names of relevant tests.
> IsolatedJMX should not release all TCPEndpoints on instance shutdown
>
>
> Key: CASSANDRA-18725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18725
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Fix For: 3.11.17, 4.0.12, 4.1.4, 5.0-alpha, 5.x
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> In the original implementation of the JMX feature, we fixed some memory leaks
> by clearing some internal state in Java’s TCPEndpoint. However, that
> implementation was overly aggressive and cleared the whole map, vs. just
> removing the endpoints created by the individual instances. This causes
> issues when you remove a node from the cluster (as all of the endpoints are
> cleared, not just the ones in use by that instance).
>
> In stead, we should check if the endpoint was created by the instance in
> question and only remove it if it was.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18722) Support Dynamic Port Allocation for in-jvm dtest framework
[
https://issues.apache.org/jira/browse/CASSANDRA-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770374#comment-17770374
]
Andres de la Peña commented on CASSANDRA-18722:
---
None of the above CircleCI runs contains the repeated runs of the modified
files ({{JMXFeatureTest.java}}). I think this is due to a bug in the non-public
script used to generate the CircleCI config file.
Those repeated runs can be generated with the project's
[{{.circleci/generate.sh}}|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh]
script.
The absence of repeated runs can be easily detected by looking at the CI
results, in the workflow view. If the patch contains any changes on tests there
should be jobs named with the {{_repeat}} suffix. One can also check whether
the pushed {{.circleci/config.yml}} file contains the names of relevant tests.
> Support Dynamic Port Allocation for in-jvm dtest framework
> --
>
> Key: CASSANDRA-18722
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18722
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0, 5.0-alpha1, 5.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently, {{INodeProvisionStrategy}} supports two strategies
> {{OneNetworkInterface}} and {{MultipleNetworkInterfaces}}. However the
> {{seedPort}}, {{storagePorts}}, {{nativeTransportPorts}}, and {{jmxPorts}}
> are always fixed or a function of the node number.
> In order to better support parallel test runs, we need to support dynamic
> port allocation for the {{seedPort}}, {{storagePorts}},
> {{nativeTransportPorts}}, and {{jmxPorts}}. This would enable us to more
> easily write tests that can run in parallel. This effort is only a stepping
> stone in what's required to run more tests in parallel, but it allows us to
> begin somewhere with the in-jvm dtest framework.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18681) Internode legacy SSL storage port certificate is not hot reloaded on update
[
https://issues.apache.org/jira/browse/CASSANDRA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770372#comment-17770372
]
Andres de la Peña commented on CASSANDRA-18681:
---
None of the above CircleCI runs contains the repeated runs of the modified
files ({{DefaultSslContextFactoryTest}}, {{PEMBasedSslContextFactoryTest}} and
{{SSLFactoryTest}}). I think this is due to a bug in the non-public script used
to generate the CircleCI config file.
Those repeated runs can be generated with the project's
[{{.circleci/generate.sh}}|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh]
script.
The absence of repeated runs can be easily detected by looking at the CI
results, in the workflow view. If the patch contains any changes on tests there
should be jobs named with the {{_repeat}} suffix. One can also check whether
the pushed {{.circleci/config.yml}} file contains the names of relevant tests.
> Internode legacy SSL storage port certificate is not hot reloaded on update
> ---
>
> Key: CASSANDRA-18681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18681
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.1.4, 5.0-alpha2
>
>
> In CASSANDRA-1 the SSLContext cache was changed to clear individual
> {{EncryptionOptions}} from the SslContext cache if they needed reloading to
> reduce resource consumption. Before the change if ANY cert needed hot
> reloading, the SSLContext cache would be cleared for ALL certs.
> If the legacy SSL storage port is configured, a new {{EncryptionOptions}}
> object is created in {{org.apache.cassandra.net.InboundSockets#addBindings}}
> just for binding the socket, but never gets cleared as the change in port
> means it no longer matches the configuration retrieved from
> {{DatabaseDescriptor}} in
> {{org.apache.cassandra.net.MessagingServiceMBeanImpl#reloadSslCertificates}}.
> This is unlikely to be an issue in practice as the legacy SSL internode
> socket is only used in mixed version clusters with pre-4.0 nodes, so the cert
> only needs to stay valid until all nodes upgrade to 4.x or above.
> One way to avoid this class of failures is to just check the entries present
> in the SSLContext cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[
https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770364#comment-17770364
]
Andres de la Peña commented on CASSANDRA-18816:
---
bq. So anyone using that script has not been running repeated tests before
commit since jdk17 was added?
That seems to be the case, for example:
* CASSANDRA-18681:
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/946/workflows/79250adf-d083-4164-bf64-8266455b2aba
* CASSANDRA-18733:
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/906/workflows/d977f977-e8ed-404c-8bb5-92a15916319c
* CASSANDRA-18722:
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/900/workflows/7ec4d4c3-c1a5-4683-8f2c-98bbeee18de8
* CASSANDRA-18725:
https://app.circleci.com/pipelines/github/jonmeredith/cassandra/893/workflows/0dae5a07-e555-4045-801a-677d9a8e7943
The absence of repeated runs can be easily detected by taking a quick look at
the CI results. If the patch contains any changes on tests there should be jobs
named with the {{_repeat}} suffix.
Reviewers can also check the {{.circleci/config.yml}} file to see if it
includes the relevant tests.
> Add support for repair coordinator to retry messages that timeout
> -
>
> Key: CASSANDRA-18816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18816
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.0-alpha2
>
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> Now that CASSANDRA-15399 is in, most of the repair messages have a state that
> they can check against to make message delivery idempotent, allowing the
> coordinator to retry such messages; a few of the most critical messages to
> retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and
> SYNC_RSP.
> With this I propose making the coordinator able to retry these key messages
> to try and make repair more resilient to ephemeral issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18856) Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
[
https://issues.apache.org/jira/browse/CASSANDRA-18856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-18856:
Status: Ready to Commit (was: Review In Progress)
> Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
> -
>
> Key: CASSANDRA-18856
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18856
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> https://app.circleci.com/pipelines/github/driftx/cassandra/1294/workflows/04464235-3bcf-433e-ae81-206aa2c9c874/jobs/54042/tests
> {quote}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-d94b6b54] 2023-09-15 16:04:30,685
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)', [node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-6f7e3946] 2023-09-15 16:04:30,687
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']"
> {quote}
> This is probably similar to CASSANDRA-18815
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18856) Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
[
https://issues.apache.org/jira/browse/CASSANDRA-18856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-18856:
Reviewers: Berenguer Blasi, Berenguer Blasi
Berenguer Blasi, Berenguer Blasi (was: Berenguer Blasi)
Status: Review In Progress (was: Patch Available)
> Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
> -
>
> Key: CASSANDRA-18856
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18856
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> https://app.circleci.com/pipelines/github/driftx/cassandra/1294/workflows/04464235-3bcf-433e-ae81-206aa2c9c874/jobs/54042/tests
> {quote}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-d94b6b54] 2023-09-15 16:04:30,685
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)', [node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-6f7e3946] 2023-09-15 16:04:30,687
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']"
> {quote}
> This is probably similar to CASSANDRA-18815
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18887) CEP-21 - Implement missing features and various other fixes
[ https://issues.apache.org/jira/browse/CASSANDRA-18887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769638#comment-17769638 ] Marcus Eriksson edited comment on CASSANDRA-18887 at 9/29/23 8:34 AM: -- https://app.circleci.com/pipelines/github/krummas/cassandra/904/workflows/36e0bc91-6b0b-47ce-8241-be10ad1109c6 23 failing unit tests 27 failing python dtests 11 failing jvm dtests was (Author: krummas): https://app.circleci.com/pipelines/github/krummas/cassandra/902/workflows/2f245ab5-801c-443e-b3a7-4205dc1c0026 23 failing unit tests 27 failing python dtests 11 failing jvm dtests > CEP-21 - Implement missing features and various other fixes > --- > > Key: CASSANDRA-18887 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18887 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > > [CEP-21] fix cqlshlib tests > https://github.com/krummas/cassandra/commit/31a4f59449 > Add cluster_metadata keyspace where needed > [CEP-21] remove authsetup > https://github.com/krummas/cassandra/commit/4cab51d76b > Avoid calling doAuthSetup twice > [CEP-21] serialize MemtableParams when writing TableParams > https://github.com/krummas/cassandra/commit/602c01a7b4 > Missed in earlier rebase, need to serialize MemtableParams when saving a > snapshot > [CEP-21] Upgrading a one node cluster to TCM fails attempting Gossip shadow > round > https://github.com/krummas/cassandra/commit/3feb3b1a58 > Upgrading fails due to first upgraded node waiting for gossip state from > peers. > [CEP-21] Implement replacement with same address > https://github.com/krummas/cassandra/commit/a05bbc4870 > Add back missing replace with same address feature > [CEP-21] fix nodetool bootstrap resume > https://github.com/krummas/cassandra/commit/061b835dae > Add back missing nodetool bootstrap resume feature > [CEP-21] Remove LEFT peers from system tables and exclude them during startup > https://github.com/krummas/cassandra/commit/4bc9dc674b > Avoid trying to gossip with LEFT peers > [CEP-21] Fix flaky distributed log test. While it fails very infrequently on > CI, it consistently fails locally. > https://github.com/krummas/cassandra/commit/f231e9dda9 > Test fix > [CEP-21] Retry indefinitely for STARTUP messages. > https://github.com/krummas/cassandra/commit/7f9e88857e > If the CMS is down and we try to upgrade an instance we should block until > the CMS comes back > [CEP-21] Implement versioning for ranges > https://github.com/krummas/cassandra/commit/a170b9f349 > To be able to know if the coordinator has the correct ring view we keep track > of when a range was last updated. If coordinator has not seen this update we > fail the request. > [CEP-21] Handle case where removenode requires no streaming to restore RF > https://github.com/krummas/cassandra/commit/68054d3ec0 > [CEP-21] Remove redundant Keyspaces arg from SchemaTransformation::apply > https://github.com/krummas/cassandra/commit/fe1c132946 > Code cleanup > [CEP-21] Don't trigger client warnings or guardrails when executing > AlterSchema transformations > https://github.com/krummas/cassandra/commit/dbbd96c9ad > Avoid getting multiple client warnings > [CEP-21] Validate schema alterations on coordinator > https://github.com/krummas/cassandra/commit/4711053513 > [CEP-21] Add a script for simulation running > https://github.com/krummas/cassandra/commit/94543e9230 > [CEP-21] Add nextId to Directory serialization and make it possible to bump > metadata serialization version > https://github.com/krummas/cassandra/commit/6d5d6a8bc6 > Previously, on bounce, each instance calculated which nodeId we should give a > new node by counting the number of instances in the cluster, this can diverge > so that different nodes have different ids. Fixed by serializing the current > nextId when storing snapshot. > [CEP-21] Add metric for CMS membership > https://github.com/krummas/cassandra/commit/bbdd165013 > [CEP-21] Reenable starting without joining (-Dcassandra.join_ring=false) > https://github.com/krummas/cassandra/commit/565c3747c5 > Add back missing join_ring=false feature. > [CEP-21] Preparing DDL statements should capture the CQL string > https://github.com/krummas/cassandra/commit/4608a74c64 > Avoid NPE -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18805) Upgrade caffeine to 3.1.8
[ https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770324#comment-17770324 ] Berenguer Blasi commented on CASSANDRA-18805: - I see you have plenty reviewers here and I have been following only lightly as I am onto sthg else as well. Feel free to move on without waiting for my +1 #collaborating > Upgrade caffeine to 3.1.8 > - > > Key: CASSANDRA-18805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18805 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > 3.1.8 is based on Java 11. This version is testing with newer JDK versions, > while 2.x versions are based on JDK8, and as I understand, only bug-fix > releases are expected. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18856) Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
[
https://issues.apache.org/jira/browse/CASSANDRA-18856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-18856:
Fix Version/s: 4.0.x
4.1.x
> Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
> -
>
> Key: CASSANDRA-18856
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18856
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> https://app.circleci.com/pipelines/github/driftx/cassandra/1294/workflows/04464235-3bcf-433e-ae81-206aa2c9c874/jobs/54042/tests
> {quote}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-d94b6b54] 2023-09-15 16:04:30,685
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)', [node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-6f7e3946] 2023-09-15 16:04:30,687
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']"
> {quote}
> This is probably similar to CASSANDRA-18815
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18856) Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
[
https://issues.apache.org/jira/browse/CASSANDRA-18856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770304#comment-17770304
]
Berenguer Blasi commented on CASSANDRA-18856:
-
If we're fixing one scenario here and the other one doesn't repro let's cash in
on the first one +1000. I think this is the
[link|https://github.com/driftx/cassandra-dtest/commit/46e722c2670ec5d331516eee8ac9d75e6e8cef6c]
I should be reviewing? if so +1
> Test failure: rebuild_test.TestRebuild.test_resumable_rebuild
> -
>
> Key: CASSANDRA-18856
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18856
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Streaming
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> https://app.circleci.com/pipelines/github/driftx/cassandra/1294/workflows/04464235-3bcf-433e-ae81-206aa2c9c874/jobs/54042/tests
> {quote}
> failed on teardown with "Unexpected error found in node logs (see stdout for
> full details). Errors: [[node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-d94b6b54] 2023-09-15 16:04:30,685
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)', [node3] 'ERROR
> [Stream-Deserializer-/127.0.0.2:7000-6f7e3946] 2023-09-15 16:04:30,687
> CassandraEntireSSTableStreamReader.java:146 - [Stream
> 8d7c61b0-53e1-11ee-a721-a91a3065a930] Error while reading sstable from stream
> for table = ks.cf\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.net.AsyncStreamingInputPlus.consume(AsyncStreamingInputPlus.java:139)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.write(SSTableZeroCopyWriter.java:218)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableZeroCopyWriter.writeComponent(SSTableZeroCopyWriter.java:207)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:124)\n\tat
>
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:87)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:50)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']"
> {quote}
> This is probably similar to CASSANDRA-18815
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
