[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808039#comment-17808039
]
Berenguer Blasi commented on CASSANDRA-19050:
-
Thanks for the review!
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-19097:
Fix Version/s: 4.0.12
4.1.4
(was: 4.0.x)
Since Version: 4.0
Source Control Link:
https://github.com/apache/cassandra-dtest/commit/15895d64238bc5e6d4469a07131110d5ad168c71
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-rc, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-19097:
Status: Ready to Commit (was: Review In Progress)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808038#comment-17808038
]
Berenguer Blasi commented on CASSANDRA-19097:
-
Tested locally test passes 4.0->trunk and committed. Thx for the review!
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.12, 4.1.4, 5.0-rc, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-dtest) branch trunk updated: Test Failure: bootstrap_test.TestBootstrap.*
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 15895d64 Test Failure: bootstrap_test.TestBootstrap.*
15895d64 is described below
commit 15895d64238bc5e6d4469a07131110d5ad168c71
Author: Bereng
AuthorDate: Wed Jan 17 10:07:16 2024 +0100
Test Failure: bootstrap_test.TestBootstrap.*
patch by Berenguer Blasi; reviewed by Brandon Williams for CASSANDRA-19097
---
bootstrap_test.py | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/bootstrap_test.py b/bootstrap_test.py
index 85e3779b..b7dac242 100644
--- a/bootstrap_test.py
+++ b/bootstrap_test.py
@@ -11,6 +11,7 @@ from distutils.version import LooseVersion
from cassandra import ConsistencyLevel
from cassandra.concurrent import execute_concurrent_with_args
+from cassandra.query import SimpleStatement
from ccmlib.node import NodeError, TimeoutError, ToolError, Node
import pytest
@@ -257,13 +258,14 @@ class BootstrapTester(Tester):
session = self.patient_cql_connection(node1)
stress_table = 'keyspace1.standard1'
-original_rows = list(session.execute("SELECT * FROM %s" %
(stress_table,)))
+query = SimpleStatement("SELECT * FROM %s" % (stress_table),
consistency_level=ConsistencyLevel.ALL)
+original_rows = list(session.execute(query))
node4 = new_node(cluster)
node4.start(wait_for_binary_proto=True)
session = self.patient_exclusive_cql_connection(node4)
-new_rows = list(session.execute("SELECT * FROM %s" % (stress_table,)))
+new_rows = list(session.execute(query))
assert original_rows == new_rows
@since('3.0')
@@ -525,7 +527,8 @@ class BootstrapTester(Tester):
session = self.patient_exclusive_cql_connection(node2)
stress_table = 'keyspace1.standard1'
-original_rows = list(session.execute("SELECT * FROM %s" %
stress_table))
+query = SimpleStatement("SELECT * FROM %s" % stress_table,
consistency_level=ConsistencyLevel.ALL)
+original_rows = list(session.execute(query))
# Add a new node
node3 = new_node(cluster, bootstrap=False)
@@ -533,7 +536,7 @@ class BootstrapTester(Tester):
node3.repair()
node1.cleanup()
-current_rows = list(session.execute("SELECT * FROM %s" % stress_table))
+current_rows = list(session.execute(query))
assert original_rows == current_rows
def test_local_quorum_bootstrap(self):
@@ -626,14 +629,15 @@ class BootstrapTester(Tester):
node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
session = self.patient_cql_connection(node1)
-original_rows = list(session.execute("SELECT * FROM
{}".format(stress_table,)))
+query = SimpleStatement("SELECT * FROM {}".format(stress_table),
consistency_level=ConsistencyLevel.ALL)
+original_rows = list(session.execute(query))
# Add a new node, bootstrap=True ensures that it is not a seed
node4 = new_node(cluster, bootstrap=True)
node4.start(wait_for_binary_proto=True)
session = self.patient_cql_connection(node4)
-assert original_rows == list(session.execute("SELECT * FROM
{}".format(stress_table,)))
+assert original_rows == list(session.execute(query))
# Stop the new node and wipe its data
node4.stop(gently=gently)
@@ -660,14 +664,15 @@ class BootstrapTester(Tester):
node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
session = self.patient_cql_connection(node1)
-original_rows = list(session.execute("SELECT * FROM
{}".format(stress_table,)))
+query = SimpleStatement("SELECT * FROM {}".format(stress_table),
consistency_level=ConsistencyLevel.ALL)
+original_rows = list(session.execute(query))
# Add a new node, bootstrap=True ensures that it is not a seed
node4 = new_node(cluster, bootstrap=True)
node4.start(wait_for_binary_proto=True)
session = self.patient_cql_connection(node4)
-assert original_rows == list(session.execute("SELECT * FROM
{}".format(stress_table,)))
+assert original_rows == list(session.execute(query))
# Decommission the new node and wipe its data
node4.decommission()
@@ -742,7 +747,7 @@ class BootstrapTester(Tester):
node1.flush()
session = self.patient_cql_connection(node1)
-original_rows = list(session.execute("SELECT * FROM
{}".format(stress_table,)))
+original_rows = list(session.execute("SELECT * FROM
{}".format(stress_table)))
# Add a new node, bootstrap=True ensures that it is not a seed
node2 = new_node(cluster, bootstrap=True)
-
[jira] [Updated] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-19050:
Fix Version/s: 5.0
(was: 5.0-rc)
Source Control Link:
https://github.com/apache/cassandra/commit/666f7df8034fbb10843be7ed61f869cc881c28c5
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-19050:
Status: Ready to Commit (was: Review In Progress)
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. bereng pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a42f922eed50d63d853c7bc054aee81f32c0b7d4 Merge: 14911e628b 666f7df803 Author: Bereng AuthorDate: Thu Jan 18 07:12:35 2024 +0100 Merge branch 'cassandra-5.0' into trunk * cassandra-5.0: Enhanced usage of test method names in CQLTester for better test debugging test/unit/org/apache/cassandra/cql3/CQLTester.java | 49 +++--- ...tabilityTest.java => JMXCompatibilityTest.java} | 3 +- 2 files changed, 45 insertions(+), 7 deletions(-) diff --cc test/unit/org/apache/cassandra/cql3/CQLTester.java index 965474a9c0,be3aa01dff..04b9b7b7e7 --- a/test/unit/org/apache/cassandra/cql3/CQLTester.java +++ b/test/unit/org/apache/cassandra/cql3/CQLTester.java @@@ -177,8 -184,13 +181,13 @@@ import static org.apache.cassandra.conf import static org.apache.cassandra.config.CassandraRelevantProperties.TEST_REUSE_PREPARED; import static org.apache.cassandra.config.CassandraRelevantProperties.TEST_ROW_CACHE_SIZE; import static org.apache.cassandra.config.CassandraRelevantProperties.TEST_USE_PREPARED; + import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.AGGREGATE; + import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.FUNCTION; + import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.MATERIALIZED_VIEW; + import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.TABLE; + import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.TYPE; -import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated: Enhanced usage of test method names in CQLTester for better test debugging
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-5.0 by this push:
new 666f7df803 Enhanced usage of test method names in CQLTester for better
test debugging
666f7df803 is described below
commit 666f7df8034fbb10843be7ed61f869cc881c28c5
Author: Bereng
AuthorDate: Mon Jan 15 09:35:22 2024 +0100
Enhanced usage of test method names in CQLTester for better test debugging
patch by Berenguer Blasi, Benjamin Lerer; reviewed by Benjamin Lerer for
CASSANDRA-19050
Co-authored-by: Benjamin Lerer
Co-authored-by: Berenguer Blasi
---
test/unit/org/apache/cassandra/cql3/CQLTester.java | 49 +++---
...tabilityTest.java => JMXCompatibilityTest.java} | 3 +-
2 files changed, 45 insertions(+), 7 deletions(-)
diff --git a/test/unit/org/apache/cassandra/cql3/CQLTester.java
b/test/unit/org/apache/cassandra/cql3/CQLTester.java
index 63f297dd51..be3aa01dff 100644
--- a/test/unit/org/apache/cassandra/cql3/CQLTester.java
+++ b/test/unit/org/apache/cassandra/cql3/CQLTester.java
@@ -39,6 +39,7 @@ import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
@@ -65,11 +66,14 @@ import com.google.common.base.Strings;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterables;
import org.apache.commons.lang3.ArrayUtils;
+import org.apache.commons.lang3.StringUtils;
import org.junit.After;
import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.rules.TestName;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -180,6 +184,11 @@ import static
org.apache.cassandra.config.CassandraRelevantProperties.TEST_DRIVE
import static
org.apache.cassandra.config.CassandraRelevantProperties.TEST_REUSE_PREPARED;
import static
org.apache.cassandra.config.CassandraRelevantProperties.TEST_ROW_CACHE_SIZE;
import static
org.apache.cassandra.config.CassandraRelevantProperties.TEST_USE_PREPARED;
+import static
org.apache.cassandra.cql3.SchemaElement.SchemaElementType.AGGREGATE;
+import static
org.apache.cassandra.cql3.SchemaElement.SchemaElementType.FUNCTION;
+import static
org.apache.cassandra.cql3.SchemaElement.SchemaElementType.MATERIALIZED_VIEW;
+import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.TABLE;
+import static org.apache.cassandra.cql3.SchemaElement.SchemaElementType.TYPE;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
@@ -197,6 +206,12 @@ public abstract class CQLTester
protected static final Logger logger =
LoggerFactory.getLogger(CQLTester.class);
+// We make the test method name available and also use it when creating
KS, table,...
+@Rule
+public final TestName testName = new TestName();
+// Some tests use hardcoded constants so we may want to disable it
+protected static volatile boolean decorateCQLWithTestNames = true;
+
public static final String KEYSPACE = "cql_test_keyspace";
public static final String KEYSPACE_PER_TEST = "cql_test_keyspace_alt";
protected static final boolean USE_PREPARED_VALUES =
TEST_USE_PREPARED.getBoolean();
@@ -903,14 +918,14 @@ public abstract class CQLTester
protected String createTypeName()
{
-String typeName = String.format("type_%02d",
seqNumber.getAndIncrement());
+String typeName = createSchemaElementName(TYPE, null);
types.add(typeName);
return typeName;
}
protected String createFunctionName(String keyspace)
{
-return String.format("%s.function_%02d", keyspace,
seqNumber.getAndIncrement());
+return createSchemaElementName(FUNCTION, keyspace);
}
protected void registerFunction(String functionName, String argTypes)
@@ -935,7 +950,7 @@ public abstract class CQLTester
protected String createAggregateName(String keyspace)
{
-return String.format("%s.aggregate_%02d", keyspace,
seqNumber.getAndIncrement());
+return createSchemaElementName(AGGREGATE, keyspace);
}
protected void registerAggregate(String aggregateName, String argTypes)
@@ -983,11 +998,27 @@ public abstract class CQLTester
protected String createKeyspaceName()
{
-String currentKeyspace = String.format("keyspace_%02d",
seqNumber.getAndIncrement());
+String currentKeyspace =
createSchemaElementName(SchemaElement.SchemaElementType.KEYSPACE, null);
keyspaces.add(currentKeyspace);
return currentKeyspace;
}
+private String createSchemaElementName(SchemaElement.Schema
(cassandra) branch trunk updated (14911e628b -> a42f922eed)
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from 14911e628b Merge branch 'cassandra-5.0' into trunk
new 666f7df803 Enhanced usage of test method names in CQLTester for better
test debugging
new a42f922eed Merge branch 'cassandra-5.0' into trunk
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
test/unit/org/apache/cassandra/cql3/CQLTester.java | 49 +++---
...tabilityTest.java => JMXCompatibilityTest.java} | 3 +-
2 files changed, 45 insertions(+), 7 deletions(-)
rename test/unit/org/apache/cassandra/tools/{JMXCompatabilityTest.java =>
JMXCompatibilityTest.java} (99%)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-website) branch asf-staging updated (81e88180a -> 29b284800)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 81e88180a generate docs for 8ea493af new 29b284800 generate docs for 8ea493af This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (81e88180a) \ N -- N -- N refs/heads/asf-staging (29b284800) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4883726 -> 4883726 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]
yifan-c commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456718177
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##
@@ -341,24 +341,31 @@ private CompletionStage>
createSnapshot(RingRespon
LOGGER.info("Creating snapshot on instance snapshotName={}
keyspace={} table={} datacenter={} fqdn={}",
snapshotName, maybeQuotedKeyspace,
maybeQuotedTable, datacenter, ringEntry.fqdn());
SidecarInstance sidecarInstance = new
SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort());
-createSnapshotFuture = sidecar
- .createSnapshot(sidecarInstance,
maybeQuotedKeyspace, maybeQuotedTable, snapshotName)
- .handle((resp, throwable) -> {
- if (throwable == null)
- {
- // Create snapshot succeeded
- return hint;
- }
-
- if (isExhausted(throwable))
- {
- LOGGER.warn("Failed to
create snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.DOWN;
- }
-
- LOGGER.error("Unexpected error
creating snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.UNKNOWN;
- });
+String resolvedSnapshotTtl = options.clearSnapshot() ?
options.effectiveSnapshotTtl() : null;
Review Comment:
my understanding is when clearSnapshot is true, the snapshot is cleared on
job completion; otherwise it sets a TTL and let Cassandra server to delete.
I'd wait for Saranya to clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]
frankgh commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456716322
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java:
##
@@ -146,6 +158,16 @@ public boolean clearSnapshot()
return clearSnapshot;
}
+public String userProvidedSnapshotTtl()
+{
+return userProvidedSnapshotTtl;
+}
+
+public String effectiveSnapshotTtl()
+{
+return effectiveSnapshotTtl;
+}
Review Comment:
The user provided option is used for logging:
```
if (!options.clearSnapshot() && options.userProvidedSnapshotTtl() != null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]
frankgh commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456715644
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##
@@ -341,24 +341,31 @@ private CompletionStage>
createSnapshot(RingRespon
LOGGER.info("Creating snapshot on instance snapshotName={}
keyspace={} table={} datacenter={} fqdn={}",
snapshotName, maybeQuotedKeyspace,
maybeQuotedTable, datacenter, ringEntry.fqdn());
SidecarInstance sidecarInstance = new
SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort());
-createSnapshotFuture = sidecar
- .createSnapshot(sidecarInstance,
maybeQuotedKeyspace, maybeQuotedTable, snapshotName)
- .handle((resp, throwable) -> {
- if (throwable == null)
- {
- // Create snapshot succeeded
- return hint;
- }
-
- if (isExhausted(throwable))
- {
- LOGGER.warn("Failed to
create snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.DOWN;
- }
-
- LOGGER.error("Unexpected error
creating snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.UNKNOWN;
- });
+String resolvedSnapshotTtl = options.clearSnapshot() ?
options.effectiveSnapshotTtl() : null;
Review Comment:
I think the condition here is correct. When clear snapshot is set, it allows
the snapshot TTL to be set. When clear snapshot is set to false, we don't want
the TTL to clear the snapshot at a later point. I think that's how I understand
it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]
yifan-c commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456714473
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##
@@ -341,24 +341,31 @@ private CompletionStage>
createSnapshot(RingRespon
LOGGER.info("Creating snapshot on instance snapshotName={}
keyspace={} table={} datacenter={} fqdn={}",
snapshotName, maybeQuotedKeyspace,
maybeQuotedTable, datacenter, ringEntry.fqdn());
SidecarInstance sidecarInstance = new
SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort());
-createSnapshotFuture = sidecar
- .createSnapshot(sidecarInstance,
maybeQuotedKeyspace, maybeQuotedTable, snapshotName)
- .handle((resp, throwable) -> {
- if (throwable == null)
- {
- // Create snapshot succeeded
- return hint;
- }
-
- if (isExhausted(throwable))
- {
- LOGGER.warn("Failed to
create snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.DOWN;
- }
-
- LOGGER.error("Unexpected error
creating snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.UNKNOWN;
- });
+String resolvedSnapshotTtl = options.clearSnapshot() ?
options.effectiveSnapshotTtl() : null;
+if (!options.clearSnapshot() &&
options.userProvidedSnapshotTtl() != null)
+{
+LOGGER.warn("Snapshot TTL option was provided along
with Clear Snapshot option, bulk reader" +
+"can honor only one of the 2. Clear
Snapshot takes precedence over Snapshot TTL, " +
+"hence snapshot {} will not be removed
after the specified snapshot TTL option", snapshotName);
+}
Review Comment:
The condition is reversed too. Beside that, I think the warning is best
emitted from `ClientConfig`, and only use the resolved value at the call-sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]
yifan-c commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456713939
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##
@@ -341,24 +341,31 @@ private CompletionStage>
createSnapshot(RingRespon
LOGGER.info("Creating snapshot on instance snapshotName={}
keyspace={} table={} datacenter={} fqdn={}",
snapshotName, maybeQuotedKeyspace,
maybeQuotedTable, datacenter, ringEntry.fqdn());
SidecarInstance sidecarInstance = new
SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort());
-createSnapshotFuture = sidecar
- .createSnapshot(sidecarInstance,
maybeQuotedKeyspace, maybeQuotedTable, snapshotName)
- .handle((resp, throwable) -> {
- if (throwable == null)
- {
- // Create snapshot succeeded
- return hint;
- }
-
- if (isExhausted(throwable))
- {
- LOGGER.warn("Failed to
create snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.DOWN;
- }
-
- LOGGER.error("Unexpected error
creating snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.UNKNOWN;
- });
+String resolvedSnapshotTtl = options.clearSnapshot() ?
options.effectiveSnapshotTtl() : null;
Review Comment:
The condition is reversed. The resolved snapshot ttl is set, when
`!options.clearSnapshot()`.
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java:
##
@@ -146,6 +158,16 @@ public boolean clearSnapshot()
return clearSnapshot;
}
+public String userProvidedSnapshotTtl()
+{
+return userProvidedSnapshotTtl;
+}
+
+public String effectiveSnapshotTtl()
+{
+return effectiveSnapshotTtl;
+}
Review Comment:
It looks like the `effectiveSnapshotTtl` is the resolved value on reading
from the map. It is confusing to expose both the raw and the resolved values.
Having `effectiveSnapshotTtl()` is suffice.
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##
@@ -341,24 +341,31 @@ private CompletionStage>
createSnapshot(RingRespon
LOGGER.info("Creating snapshot on instance snapshotName={}
keyspace={} table={} datacenter={} fqdn={}",
snapshotName, maybeQuotedKeyspace,
maybeQuotedTable, datacenter, ringEntry.fqdn());
SidecarInstance sidecarInstance = new
SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort());
-createSnapshotFuture = sidecar
- .createSnapshot(sidecarInstance,
maybeQuotedKeyspace, maybeQuotedTable, snapshotName)
- .handle((resp, throwable) -> {
- if (throwable == null)
- {
- // Create snapshot succeeded
- return hint;
- }
-
- if (isExhausted(throwable))
- {
- LOGGER.warn("Failed to
create snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.DOWN;
- }
-
- LOGGER.error("Unexpected error
creating snapshot on instance", throwable);
- return
PartitionedDataLayer.AvailabilityHint.UNKNOWN;
- });
+String resolvedSnapshotTtl = options.clearSnapshot() ?
options.effectiveSnapshotTtl() : null;
+if (!options.clearSnapshot() &&
options.userProvidedSnapshotTtl() != null)
+{
+LOGGER.warn("Snapshot TTL option was provided along
with Clear Snapshot option, bulk reader" +
+
[jira] [Comment Edited] (CASSANDRA-19273) Allow setting TTL for snapshots created by Analytics bulk reader
[ https://issues.apache.org/jira/browse/CASSANDRA-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807957#comment-17807957 ] Saranya Krishnakumar edited comment on CASSANDRA-19273 at 1/18/24 1:03 AM: --- Latest Circle CI green: [https://app.circleci.com/pipelines/github/sarankk/cassandra-analytics/31/workflows/0de00d4e-6cf8-4a8f-9dec-930278a6a5e4] was (Author: saranya_k): Latest Circle CI green: [https://app.circleci.com/pipelines/github/sarankk/cassandra-analytics?branch=add-snapshot-ttl] > Allow setting TTL for snapshots created by Analytics bulk reader > > > Key: CASSANDRA-19273 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19273 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > Analytics user can add an existing snapshot's name or create a new snapshot > through reader options, from which data is bulk read from. Incase of creating > new snapshot, we want to allow users to set TTL option and have a default > value for the TTL. This is to make sure, in case of job failures, the > snapshots are cleared, to release space. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19273) Allow setting TTL for snapshots created by Analytics bulk reader
[ https://issues.apache.org/jira/browse/CASSANDRA-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807957#comment-17807957 ] Saranya Krishnakumar commented on CASSANDRA-19273: -- Latest Circle CI green: [https://app.circleci.com/pipelines/github/sarankk/cassandra-analytics?branch=add-snapshot-ttl] > Allow setting TTL for snapshots created by Analytics bulk reader > > > Key: CASSANDRA-19273 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19273 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > Analytics user can add an existing snapshot's name or create a new snapshot > through reader options, from which data is bulk read from. Incase of creating > new snapshot, we want to allow users to set TTL option and have a default > value for the TTL. This is to make sure, in case of job failures, the > snapshots are cleared, to release space. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19273) Allow setting TTL for snapshots created by Analytics bulk reader
[ https://issues.apache.org/jira/browse/CASSANDRA-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807936#comment-17807936 ] Francisco Guerrero commented on CASSANDRA-19273: +1 on the patch. Can you please post the latest CI run? > Allow setting TTL for snapshots created by Analytics bulk reader > > > Key: CASSANDRA-19273 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19273 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > Analytics user can add an existing snapshot's name or create a new snapshot > through reader options, from which data is bulk read from. Incase of creating > new snapshot, we want to allow users to set TTL option and have a default > value for the TTL. This is to make sure, in case of job failures, the > snapshots are cleared, to release space. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19001:
Test and Documentation Plan:
[https://github.com/apache/cassandra/pull/3050/files] 5.0
The patch for trunk will be the same
was:
[Patch|https://github.com/ekaterinadimitrova2/cassandra/commit/613bb6d2cbc40924479eac044f78e0c4e584521b],
[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=19001-5.0-patch]
- 5.0, the patch will be the same for 5.1
Tested also locally with JDK/JRE 11 and 17
Status: Patch Available (was: In Progress)
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807935#comment-17807935
]
Ekaterina Dimitrova commented on CASSANDRA-19001:
-
Rebased the branch, squashed commits:
[https://github.com/apache/cassandra/pull/3050/files] --> this is the final PR
for 5.0
If there are no more concerns I will run CI for both 5.0 and trunk tomorrow.
(the patch will be the same for 5.0 and trunk)
We will consider there is 1 JDK/JRE set on the PATH or JAVA_HOME being set or
during development.
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19273) Allow setting TTL for snapshots created by Analytics bulk reader
[ https://issues.apache.org/jira/browse/CASSANDRA-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807924#comment-17807924 ] Saranya Krishnakumar commented on CASSANDRA-19273: -- Circle CI green: [https://app.circleci.com/pipelines/github/sarankk/cassandra-analytics?branch=add-snapshot-ttl] > Allow setting TTL for snapshots created by Analytics bulk reader > > > Key: CASSANDRA-19273 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19273 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > Analytics user can add an existing snapshot's name or create a new snapshot > through reader options, from which data is bulk read from. Incase of creating > new snapshot, we want to allow users to set TTL option and have a default > value for the TTL. This is to make sure, in case of job failures, the > snapshots are cleared, to release space. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19275) Flaky Host replacement tests and shrink tests
Saranya Krishnakumar created CASSANDRA-19275: Summary: Flaky Host replacement tests and shrink tests Key: CASSANDRA-19275 URL: https://issues.apache.org/jira/browse/CASSANDRA-19275 Project: Cassandra Issue Type: Bug Reporter: Saranya Krishnakumar During Circle CI runs there are some flaky integration tests, some noticed are * HostReplacementMultiDCTest * HostReplacementMultiDCFailureTest * HostReplacementFailureTest * LeavingSingleFailureTest Some of the error message I see in these tests are e.g. `java.lang.RuntimeException: java.lang.IllegalStateException: Can't load org.apache.cassandra.utils.concurrent.Ref$OnLeak. Instance class loader is already closed.` `java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Failed to bind port 42611 on 127.0.0.2.` On repeated run, these tests pass. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] [CASSANDRA-19272] Adds integration testing for blocklist handling [cassandra-analytics]
frankgh commented on PR #32: URL: https://github.com/apache/cassandra-analytics/pull/32#issuecomment-1897046961 Closed via https://github.com/apache/cassandra-analytics/commit/fa6df8e2c09ad3d27bfe8c0ce016c839094630f6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] [CASSANDRA-19272] Adds integration testing for blocklist handling [cassandra-analytics]
frankgh closed pull request #32: [CASSANDRA-19272] Adds integration testing for blocklist handling URL: https://github.com/apache/cassandra-analytics/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-19272: --- Fix Version/s: NA Source Control Link: https://github.com/apache/cassandra-analytics/commit/fa6df8e2c09ad3d27bfe8c0ce016c839094630f6 Resolution: Fixed Status: Resolved (was: Ready to Commit) > [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted > instances > --- > > Key: CASSANDRA-19272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19272 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Fix For: NA > > > Scope: > - Add default mechanism to load blocklist from configuration > - Relevant in-jvm-dtest based integration tests to validate the CL > validations for different CL combinations -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-analytics) branch trunk updated: CASSANDRA-19272 Add new writer option for blocklisted instances and corresponding integration tests
This is an automated email from the ASF dual-hosted git repository.
frankgh pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-analytics.git
The following commit(s) were added to refs/heads/trunk by this push:
new fa6df8e CASSANDRA-19272 Add new writer option for blocklisted
instances and corresponding integration tests
fa6df8e is described below
commit fa6df8e2c09ad3d27bfe8c0ce016c839094630f6
Author: Arjun Ashok
AuthorDate: Tue Jan 16 12:24:02 2024 -0800
CASSANDRA-19272 Add new writer option for blocklisted instances and
corresponding integration tests
Patch by Arjun Ashok; Reviewed by Francisco Guerrero, Yifan Cai for
CASSANDRA-19272
---
CHANGES.txt| 1 +
.../cassandra/spark/bulkwriter/BulkSparkConf.java | 9 ++
.../spark/bulkwriter/CassandraClusterInfo.java | 4 +-
.../cassandra/spark/bulkwriter/WriterOptions.java | 6 +
.../org/apache/cassandra/testing/TestUtils.java| 7 +-
.../cassandra/analytics/BlockedInstancesTest.java | 163 +
6 files changed, 187 insertions(+), 3 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 8c97f7a..0845191 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.0.0
+ * Add integration tests using in-jvm-dtest to cover blocklisted instances
(CASSANDRA-19272)
* Fix bulk writer consistency level validations for blocked instances
(CASSANDRA-19257)
* Column type mapping error for timestamp type during bulk writes
(CASSANDRA-19223)
* Speed up integration tests (CASSANDRA-19251)
diff --git
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java
index 22355a9..8c97b07 100644
---
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java
+++
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java
@@ -131,6 +131,7 @@ public class BulkSparkConf implements Serializable
protected final int userProvidedSidecarPort;
protected boolean useOpenSsl;
protected int ringRetryCount;
+protected final Set blockedInstances;
public BulkSparkConf(SparkConf conf, Map options)
{
@@ -167,9 +168,17 @@ public class BulkSparkConf implements Serializable
this.ttl = MapUtils.getOrDefault(options, WriterOptions.TTL.name(),
null);
this.timestamp = MapUtils.getOrDefault(options,
WriterOptions.TIMESTAMP.name(), null);
this.quoteIdentifiers = MapUtils.getBoolean(options,
WriterOptions.QUOTE_IDENTIFIERS.name(), false, "quote identifiers");
+this.blockedInstances = buildBlockedInstances(options);
validateEnvironment();
}
+private Set buildBlockedInstances(Map options)
+{
+String blockedInstances = MapUtils.getOrDefault(options,
WriterOptions.BLOCKED_CASSANDRA_INSTANCES.name(), "");
+return Arrays.stream(blockedInstances.split(","))
+ .collect(Collectors.toSet());
+}
+
protected Set buildSidecarInstances(Map options, int sidecarPort)
{
String sidecarInstances = MapUtils.getOrThrow(options,
WriterOptions.SIDECAR_INSTANCES.name(), "sidecar_instances");
diff --git
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java
index afc897b..edb5375 100644
---
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java
+++
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java
@@ -578,9 +578,9 @@ public class CassandraClusterInfo implements ClusterInfo,
Closeable
return ns.releaseVersion();
}
-protected boolean instanceIsBlocked(RingInstance ignored)
+protected boolean instanceIsBlocked(RingInstance instance)
{
-return false;
+return conf.blockedInstances.contains(instance.getIpAddress());
}
protected boolean instanceIsNormal(RingEntry ringEntry)
diff --git
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java
index b8688e7..075672f 100644
---
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java
+++
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java
@@ -50,4 +50,10 @@ public enum WriterOptions implements WriterOption
* support mixed case and reserved keyword names for these fields.
*/
QUOTE_IDENTIFIERS,
+/**
+ * Option to specify a comma separated list of Cassandra instances that
are blocked from receiving any
+ *
[jira] [Commented] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[
https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807912#comment-17807912
]
Francisco Guerrero commented on CASSANDRA-19272:
The PR itself not only adds tests for blocklist handling, but in addition, it
adds a new {{WriterOption}} that allows specifying blocklisted Cassandra
instances, so I think that deserves changing the jira description. What do you
think [~arjunashok] [~yifanc]?
> [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted
> instances
> ---
>
> Key: CASSANDRA-19272
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19272
> Project: Cassandra
> Issue Type: Task
> Components: Analytics Library
>Reporter: Arjun Ashok
>Assignee: Arjun Ashok
>Priority: Normal
>
> Scope:
> - Add default mechanism to load blocklist from configuration
> - Relevant in-jvm-dtest based integration tests to validate the CL
> validations for different CL combinations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19046) Paxos V2 does not update individual fields of readMetrics
[
https://issues.apache.org/jira/browse/CASSANDRA-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807911#comment-17807911
]
Brandon Williams edited comment on CASSANDRA-19046 at 1/17/24 9:56 PM:
---
I've been looking into the logging, but it hasn't been easy to locate where
that 'Paxos Commit' string is being set in v1.
As for the metrics,
bq. I'm honestly not 100% sure it's a great metric to have
I'm not sure it is either, how would you like to proceed with regard to this
ticket? If we don't want to add the metric then it should be possible to make
ClientMetricsTest not check them for v2.
bq. client_request_metrics_test.TestClientRequestMetrics is failing simply
because the metric isn't initialized until contention occurs
It turns out that v1 actually [does the same
thing|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageProxy.java#L442],
it's just that v2 doesn't encounter contention, so it's probably more correct
to fix the test. Unfortunately I don't think there's any way to detect the
paxos variant from the dtest or ccm, so that may be difficult, and I don't
think changing the test to cause contention will pan out either, so I'll have
to figure something out there.
was (Author: brandon.williams):
I've been looking into the logging, but it hasn't been easy to locate where
that 'Paxos Commit' string is being set in v1.
As for the metrics,
bq. I'm honestly not 100% sure it's a great metric to have
I'm not sure it is either, how would you like to proceed with regard to this
ticket? If we don't want to add the metric then it should be possible to make
ClientMetricsTest not check them for v2.
bq. client_request_metrics_test.TestClientRequestMetrics is failing simply
because the metric isn't initialized until contention occurs
It turns out that v1 actually [does the same
thing|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageProxy.java#L442],
it's just that v2 doesn't encounter contention, so it's probably more correct
to fix the test. Unfortunately I don't think there's any way to detect the
paxos variant from the dtest or ccm, so that may be difficult, and I don't
think changing the test to cause contention will pan out either, so I'll to
figure something out there.
> Paxos V2 does not update individual fields of readMetrics
> -
>
> Key: CASSANDRA-19046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19046
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Lightweight Transactions, Observability/Metrics
>Reporter: Branimir Lambov
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.0-rc, 5.x
>
>
> As a result, {{ClientRequestMetricsTest.testPaxosStatement}} is failing with
> {{{}paxos_variant: v2{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19046) Paxos V2 does not update individual fields of readMetrics
[
https://issues.apache.org/jira/browse/CASSANDRA-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807911#comment-17807911
]
Brandon Williams commented on CASSANDRA-19046:
--
I've been looking into the logging, but it hasn't been easy to locate where
that 'Paxos Commit' string is being set in v1.
As for the metrics,
bq. I'm honestly not 100% sure it's a great metric to have
I'm not sure it is either, how would you like to proceed with regard to this
ticket? If we don't want to add the metric then it should be possible to make
ClientMetricsTest not check them for v2.
bq. client_request_metrics_test.TestClientRequestMetrics is failing simply
because the metric isn't initialized until contention occurs
It turns out that v1 actually [does the same
thing|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageProxy.java#L442],
it's just that v2 doesn't encounter contention, so it's probably more correct
to fix the test. Unfortunately I don't think there's any way to detect the
paxos variant from the dtest or ccm, so that may be difficult, and I don't
think changing the test to cause contention will pan out either, so I'll to
figure something out there.
> Paxos V2 does not update individual fields of readMetrics
> -
>
> Key: CASSANDRA-19046
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19046
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Lightweight Transactions, Observability/Metrics
>Reporter: Branimir Lambov
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.0-rc, 5.x
>
>
> As a result, {{ClientRequestMetricsTest.testPaxosStatement}} is failing with
> {{{}paxos_variant: v2{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-19272: --- Status: Ready to Commit (was: Review In Progress) > [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted > instances > --- > > Key: CASSANDRA-19272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19272 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > > Scope: > - Add default mechanism to load blocklist from configuration > - Relevant in-jvm-dtest based integration tests to validate the CL > validations for different CL combinations -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] [CASSANDRASC-86] Startup Validation Failures when Checking Sidecar Connectivity [cassandra-analytics]
5 commented on code in PR #22:
URL:
https://github.com/apache/cassandra-analytics/pull/22#discussion_r1456527690
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/CassandraValidation.java:
##
@@ -29,7 +29,7 @@
*/
public class CassandraValidation implements StartupValidation
{
-private static final int TIMEOUT_SECONDS = 30;
+private static final int TIMEOUT_SECONDS = 300;
Review Comment:
Made timeouts for Sidecar/Cassandra startup validations configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-19272: -- Reviewers: Francisco Guerrero, Yifan Cai (was: Francisco Guerrero) > [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted > instances > --- > > Key: CASSANDRA-19272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19272 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > > Scope: > - Add default mechanism to load blocklist from configuration > - Relevant in-jvm-dtest based integration tests to validate the CL > validations for different CL combinations -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807892#comment-17807892 ] Arjun Ashok edited comment on CASSANDRA-19272 at 1/17/24 9:05 PM: -- PR: [https://github.com/apache/cassandra-analytics/pull/32] CI: [https://app.circleci.com/pipelines/github/arjunashok/cassandra-analytics/57/workflows/bb0e357f-1866-44e4-91a1-f627afb07d56] was (Author: JIRAUSER301082): PR: https://github.com/apache/cassandra-analytics/pull/32 CI: [https://app.circleci.com/pipelines/github/arjunashok/cassandra-analytics/57/workflows/bb0e357f-1866-44e4-91a1-f627afb07d56] > [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted > instances > --- > > Key: CASSANDRA-19272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19272 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > > Scope: > - Add default mechanism to load blocklist from configuration > - Relevant in-jvm-dtest based integration tests to validate the CL > validations for different CL combinations -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807892#comment-17807892 ] Arjun Ashok edited comment on CASSANDRA-19272 at 1/17/24 9:05 PM: -- PR: https://github.com/apache/cassandra-analytics/pull/32 CI: [https://app.circleci.com/pipelines/github/arjunashok/cassandra-analytics/57/workflows/bb0e357f-1866-44e4-91a1-f627afb07d56] was (Author: JIRAUSER301082): CI: https://app.circleci.com/pipelines/github/arjunashok/cassandra-analytics/57/workflows/bb0e357f-1866-44e4-91a1-f627afb07d56 > [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted > instances > --- > > Key: CASSANDRA-19272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19272 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > > Scope: > - Add default mechanism to load blocklist from configuration > - Relevant in-jvm-dtest based integration tests to validate the CL > validations for different CL combinations -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] (CASSANDRA-19257) [Analytics] Fix bulk writer consistency level validations for blocked instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19257 ] Arjun Ashok deleted comment on CASSANDRA-19257: - was (Author: JIRAUSER301082): CI: https://app.circleci.com/pipelines/github/arjunashok/cassandra-analytics/57/workflows/bb0e357f-1866-44e4-91a1-f627afb07d56 > [Analytics] Fix bulk writer consistency level validations for blocked > instances > --- > > Key: CASSANDRA-19257 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19257 > Project: Cassandra > Issue Type: Bug > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > Fix For: NA > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The analytics library bulk writer spark job performs consistency level > validations around write operations. > Currently, these validations incorrectly double count the number of blocked > instances for these validations resulting in valid scenarios failing CL > checks. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19097:
Reviewers: Brandon Williams (was: Brandon Williams, Ekaterina Dimitrova)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19050:
Reviewers: Benjamin Lerer, Michael Semb Wever (was: Michael Semb Wever)
Status: Review In Progress (was: Patch Available)
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19097:
Reviewers: Brandon Williams, Ekaterina Dimitrova
Status: Review In Progress (was: Patch Available)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-19097:
Fix Version/s: 5.1
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc, 5.1
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19095) Test Failure: org.apache.cassandra.index.sai.cql.VectorSegmentationTest.testMultipleSegmentsForCompaction
[
https://issues.apache.org/jira/browse/CASSANDRA-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807886#comment-17807886
]
Ekaterina Dimitrova commented on CASSANDRA-19095:
-
Hey [~mike_tr_adamson], just checking - do you plan to work on this one? You
mentioned you are investigating, but the ticket is not assigned so checking the
status and if it is open for someone else to work on it. Thanks
> Test Failure:
> org.apache.cassandra.index.sai.cql.VectorSegmentationTest.testMultipleSegmentsForCompaction
> -
>
> Key: CASSANDRA-19095
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19095
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> Seen in j11_utests_compression in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/259/workflows/f343d3e3-00cf-4e13-bb4d-bbfff1d3658c/jobs/21135/tests
> {noformat}
> junit.framework.AssertionFailedError:
> Expecting actual:
> 0.9667
> to be greater than or equal to:
> 0.99
> at
> org.apache.cassandra.index.sai.cql.VectorSegmentationTest.testMultipleSegmentsForCompaction(VectorSegmentationTest.java:107)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19274) Fix version in run-external.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807872#comment-17807872
]
Jaydeepkumar Chovatia commented on CASSANDRA-19274:
---
Thank you, [~ifesdjeen]
> Fix version in run-external.sh
> --
>
> Key: CASSANDRA-19274
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19274
> Project: Cassandra
> Issue Type: Bug
> Components: Test/fuzz
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Normal
>
> _run-external.sh_ has _0.0.1_ version for the
> {_}harry-integration-external-0.0.1-SNAPSHOT.jar{_}; however, pom.xml has
> 0.0.2. So in this ticket, fix the version in _run-external.sh_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19274) Fix version in run-external.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaydeepkumar Chovatia updated CASSANDRA-19274:
--
Reviewers: Alex Petrov
> Fix version in run-external.sh
> --
>
> Key: CASSANDRA-19274
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19274
> Project: Cassandra
> Issue Type: Bug
> Components: Test/fuzz
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Normal
>
> _run-external.sh_ has _0.0.1_ version for the
> {_}harry-integration-external-0.0.1-SNAPSHOT.jar{_}; however, pom.xml has
> 0.0.2. So in this ticket, fix the version in _run-external.sh_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19274) Fix version in run-external.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaydeepkumar Chovatia updated CASSANDRA-19274:
--
Resolution: Fixed
Status: Resolved (was: Triage Needed)
> Fix version in run-external.sh
> --
>
> Key: CASSANDRA-19274
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19274
> Project: Cassandra
> Issue Type: Bug
> Components: Test/fuzz
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Normal
>
> _run-external.sh_ has _0.0.1_ version for the
> {_}harry-integration-external-0.0.1-SNAPSHOT.jar{_}; however, pom.xml has
> 0.0.2. So in this ticket, fix the version in _run-external.sh_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19274) Fix version in run-external.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807868#comment-17807868
]
Alex Petrov commented on CASSANDRA-19274:
-
+1; merged
> Fix version in run-external.sh
> --
>
> Key: CASSANDRA-19274
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19274
> Project: Cassandra
> Issue Type: Bug
> Components: Test/fuzz
>Reporter: Jaydeepkumar Chovatia
>Assignee: Jaydeepkumar Chovatia
>Priority: Normal
>
> _run-external.sh_ has _0.0.1_ version for the
> {_}harry-integration-external-0.0.1-SNAPSHOT.jar{_}; however, pom.xml has
> 0.0.2. So in this ticket, fix the version in _run-external.sh_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-harry) branch trunk updated: Fix version in run-external.sh
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git The following commit(s) were added to refs/heads/trunk by this push: new d216a71 Fix version in run-external.sh d216a71 is described below commit d216a71049ab52f522e5ed7c64423bfa3f6658e8 Author: Jaydeepkumar Chovatia AuthorDate: Tue Jan 16 22:24:12 2024 -0800 Fix version in run-external.sh --- run-external.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run-external.sh b/run-external.sh index 6263110..d6a2efc 100755 --- a/run-external.sh +++ b/run-external.sh @@ -1,3 +1,3 @@ #!/bin/sh -java -Dlogback.configurationFile=test/conf/logback-dtest.xml -jar harry-integration-external/target/harry-integration-external-0.0.1-SNAPSHOT.jar conf/external.yaml +java -Dlogback.configurationFile=test/conf/logback-dtest.xml -jar harry-integration-external/target/harry-integration-external-0.0.2-SNAPSHOT.jar conf/external.yaml - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Allow setting TTL for snapshots created through reader [cassandra-analytics]
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456371369 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -91,6 +101,8 @@ private ClientConfig(Map options) this.datacenter = options.get(MapUtils.lowerCaseKey(DC_KEY)); this.createSnapshot = MapUtils.getBoolean(options, CREATE_SNAPSHOT_KEY, true); this.clearSnapshot = MapUtils.getBoolean(options, CLEAR_SNAPSHOT_KEY, createSnapshot); +this.userProvidedSnapshotTtl = MapUtils.getOrDefault(options, USER_PROVIDED_SNAPSHOT_TTL, null); +this.effectiveSnapshotTtl = this.userProvidedSnapshotTtl == null ? DEFAULT_SNAPSHOT_TTL : USER_PROVIDED_SNAPSHOT_TTL; Review Comment: Yes thanks for noticing that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807855#comment-17807855
]
Paulo Motta commented on CASSANDRA-19001:
-
{quote}If JAVA_HOME is not defined, Cassandra checks what is in PATH first. Do
we expect users to do more modifications to PATH to adhere? It sounds a bit
risky to me; I hope I do not overengineer it. WDYT?
{quote}
As far as I understand there is no reliable way to detect if there's a local
JDK other than check if javac exists in JAVA_HOME or PATH. So the only way to
figure out if the user is running on a JDK is to to check if javac exists in
JAVA_HOME/bin first, if not check on PATH - this does not look like
overengineering to me. What do you mean by "expect users to do more
modifications to PATH to adhere"?
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-92) Add restore SSTables from S3 into Cassandra feature to Cassandra Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807853#comment-17807853 ] Paulo Motta commented on CASSANDRASC-92: Thanks for the context [~frankgh] I plan to test this functionality at some point but please don't block this review on me. I'll add any comments later if needed. > Add restore SSTables from S3 into Cassandra feature to Cassandra Sidecar > > > Key: CASSANDRASC-92 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-92 > Project: Sidecar for Apache Cassandra > Issue Type: New Feature > Components: Rest API >Reporter: Saranya Krishnakumar >Assignee: Saranya Krishnakumar >Priority: Normal > > Through this proposal we want to add restore capability to Sidecar, for > Sidecar to allow restoring data from S3. As part of this patch we want to add > APIs for creating, updating and getting information about the restore jobs. > We also want to add background tasks for managing these restore jobs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19272) [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted instances
[ https://issues.apache.org/jira/browse/CASSANDRA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-19272: --- Reviewers: Francisco Guerrero Status: Review In Progress (was: Patch Available) > [Analytics] Add integration tests using in-jvm-dtest to cover blocklisted > instances > --- > > Key: CASSANDRA-19272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19272 > Project: Cassandra > Issue Type: Task > Components: Analytics Library >Reporter: Arjun Ashok >Assignee: Arjun Ashok >Priority: Normal > > Scope: > - Add default mechanism to load blocklist from configuration > - Relevant in-jvm-dtest based integration tests to validate the CL > validations for different CL combinations -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Adds integration testing for blocklist handling [cassandra-analytics]
arjunashok commented on code in PR #32:
URL:
https://github.com/apache/cassandra-analytics/pull/32#discussion_r1456276685
##
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/BlockedInstancesTest.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.analytics;
+
+import java.io.IOException;
+import java.lang.reflect.Method;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Set;
+
+import org.apache.commons.lang3.StringUtils;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInfo;
+
+import org.apache.cassandra.distributed.UpgradeableCluster;
+import org.apache.cassandra.distributed.api.Feature;
+import org.apache.cassandra.distributed.api.IInstance;
+import org.apache.cassandra.sidecar.testing.QualifiedName;
+import org.apache.cassandra.spark.bulkwriter.WriterOptions;
+import org.apache.cassandra.testing.TestVersion;
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
+import org.apache.spark.sql.SparkSession;
+
+import static com.datastax.driver.core.ConsistencyLevel.ALL;
+import static com.datastax.driver.core.ConsistencyLevel.ONE;
+import static com.datastax.driver.core.ConsistencyLevel.QUORUM;
+import static
org.apache.cassandra.testing.TestUtils.CREATE_TEST_TABLE_STATEMENT;
+import static org.apache.cassandra.testing.TestUtils.DC1_RF3;
+import static org.apache.cassandra.testing.TestUtils.ROW_COUNT;
+import static org.apache.cassandra.testing.TestUtils.TEST_KEYSPACE;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.catchThrowable;
+
+public class BlockedInstancesTest extends ResiliencyTestBase
+{
+Dataset df;
+Map> expectedInstanceData;
+
+@Test
+void testSingleBlockedNodeSucceeds(TestInfo testInfo)
+{
+TestConsistencyLevel cl = TestConsistencyLevel.of(QUORUM, QUORUM);
+QualifiedName table = new QualifiedName(TEST_KEYSPACE,
testInfo.getTestMethod().get().getName().toLowerCase());
+bulkWriterDataFrameWriter(df,
table).option(WriterOptions.BULK_WRITER_CL.name(), cl.writeCL.name())
+.option("blocked_instances",
"127.0.0.2")
+.save();
+expectedInstanceData.entrySet()
+.stream()
+.filter(e ->
e.getKey().broadcastAddress().getAddress().getHostAddress().equals("127.0.0.2"))
+.forEach(e -> e.setValue(Collections.emptySet()));
+validateNodeSpecificData(table, expectedInstanceData);
+validateData(table, cl.readCL, ROW_COUNT);
+
+}
+
+@Test
+void testSingleBlockedNodeWithWriteFailure(TestInfo testInfo)
+{
+TestConsistencyLevel cl = TestConsistencyLevel.of(ONE, ALL);
+QualifiedName table = new QualifiedName(TEST_KEYSPACE,
testInfo.getTestMethod().get().getName().toLowerCase());
+Throwable thrown = catchThrowable(() ->
+ bulkWriterDataFrameWriter(df,
table).option(WriterOptions.BULK_WRITER_CL.name(), cl.writeCL.name())
+
.option("blocked_instances", "127.0.0.2")
+
.save());
+validateFailedJob(table, cl, thrown);
+}
+
+@Test
+void testMultipleBlockedNodesWithWriteFailure(TestInfo testInfo)
+{
+TestConsistencyLevel cl = TestConsistencyLevel.of(QUORUM, QUORUM);
+QualifiedName table = new QualifiedName(TEST_KEYSPACE,
testInfo.getTestMethod().get().getName().toLowerCase());
+Throwable thrown = catchThrowable(() ->
+ bulkWriterDataFrameWriter(df,
table).option(WriterOptions.BULK_WRITER_CL.name(), cl.writeCL.name())
+
.option("blocked_instances", "127.0.0.2,127.0.0.3")
+
.save());
+validateFailedJob(table, cl, thro
[jira] [Updated] (CASSANDRA-19269) NPE in MetaStrategy.java when collecting metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-19269:
Reviewers: Alex Petrov, Sam Tunnicliffe
> NPE in MetaStrategy.java when collecting metrics
>
>
> Key: CASSANDRA-19269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19269
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Jon Haddad
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 5.x
>
> Attachments: ci_summary.html, result_details.tar.gz
>
>
> Now that the metrics exporter has been removed in CASSANDRA-18743, I thought
> I'd take a stab at setting up a metrics collector through DropWizard. I have
> a POC of an agent that exposes a Prometheus endpoint using the Prometheus
> simpleclient here:
> https://github.com/rustyrazorblade/cassandra-prometheus-exporter
> There's build instructions in the README - it's just a simple agent on a
> background thread.
> Unfortunately when trying to view the metrics, Cassandra throws an NPE
> exception, stack trace is here:
> {code:java}
> WARN [qtp104447770-28] 2024-01-12 14:26:50,102 ServletHandler.java:522 -
> /metrics
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.locator.MetaStrategy.getReplicationFactor(MetaStrategy.java:64)
> at
> org.apache.cassandra.metrics.KeyspaceMetrics.lambda$new$12(KeyspaceMetrics.java:224)
> at
> org.apache.cassandra.metrics.KeyspaceMetrics$1.getValue(KeyspaceMetrics.java:344)
> at
> org.apache.cassandra.metrics.KeyspaceMetrics$1.getValue(KeyspaceMetrics.java:338)
> at
> org.apache.cassandra.metrics.StorageMetrics.lambda$static$0(StorageMetrics.java:40)
> at
> org.apache.cassandra.metrics.StorageMetrics.lambda$createSummingGauge$2(StorageMetrics.java:55)
> at
> java.base/java.util.stream.ReferencePipeline$5$1.accept(ReferencePipeline.java:229)
> at
> com.google.common.collect.CollectSpliterators$1.lambda$forEachRemaining$1(CollectSpliterators.java:128)
> at
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
> at
> com.google.common.collect.CollectSpliterators$1.forEachRemaining(CollectSpliterators.java:128)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.base/java.util.stream.LongPipeline.reduce(LongPipeline.java:474)
> at java.base/java.util.stream.LongPipeline.sum(LongPipeline.java:432)
> at
> org.apache.cassandra.metrics.StorageMetrics.lambda$createSummingGauge$3(StorageMetrics.java:56)
> at
> io.prometheus.client.dropwizard.DropwizardExports.fromGauge(DropwizardExports.java:47)
> at
> io.prometheus.client.dropwizard.DropwizardExports.collect(DropwizardExports.java:133)
> at io.prometheus.client.Collector.collect(Collector.java:45)
> at
> io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.findNextElement(CollectorRegistry.java:204)
> at
> io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.(CollectorRegistry.java:162)
> at
> io.prometheus.client.CollectorRegistry.filteredMetricFamilySamples(CollectorRegistry.java:140)
> at
> io.prometheus.client.exporter.MetricsServlet.doGet(MetricsServlet.java:43)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:735)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:648)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1072)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:382)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1006)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:365)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:485)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:926)
> at
> org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.h
[jira] [Updated] (CASSANDRA-19269) NPE in MetaStrategy.java when collecting metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-19269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-19269:
Attachment: ci_summary.html
result_details.tar.gz
> NPE in MetaStrategy.java when collecting metrics
>
>
> Key: CASSANDRA-19269
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19269
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Jon Haddad
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 5.x
>
> Attachments: ci_summary.html, result_details.tar.gz
>
>
> Now that the metrics exporter has been removed in CASSANDRA-18743, I thought
> I'd take a stab at setting up a metrics collector through DropWizard. I have
> a POC of an agent that exposes a Prometheus endpoint using the Prometheus
> simpleclient here:
> https://github.com/rustyrazorblade/cassandra-prometheus-exporter
> There's build instructions in the README - it's just a simple agent on a
> background thread.
> Unfortunately when trying to view the metrics, Cassandra throws an NPE
> exception, stack trace is here:
> {code:java}
> WARN [qtp104447770-28] 2024-01-12 14:26:50,102 ServletHandler.java:522 -
> /metrics
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.locator.MetaStrategy.getReplicationFactor(MetaStrategy.java:64)
> at
> org.apache.cassandra.metrics.KeyspaceMetrics.lambda$new$12(KeyspaceMetrics.java:224)
> at
> org.apache.cassandra.metrics.KeyspaceMetrics$1.getValue(KeyspaceMetrics.java:344)
> at
> org.apache.cassandra.metrics.KeyspaceMetrics$1.getValue(KeyspaceMetrics.java:338)
> at
> org.apache.cassandra.metrics.StorageMetrics.lambda$static$0(StorageMetrics.java:40)
> at
> org.apache.cassandra.metrics.StorageMetrics.lambda$createSummingGauge$2(StorageMetrics.java:55)
> at
> java.base/java.util.stream.ReferencePipeline$5$1.accept(ReferencePipeline.java:229)
> at
> com.google.common.collect.CollectSpliterators$1.lambda$forEachRemaining$1(CollectSpliterators.java:128)
> at
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
> at
> com.google.common.collect.CollectSpliterators$1.forEachRemaining(CollectSpliterators.java:128)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.base/java.util.stream.LongPipeline.reduce(LongPipeline.java:474)
> at java.base/java.util.stream.LongPipeline.sum(LongPipeline.java:432)
> at
> org.apache.cassandra.metrics.StorageMetrics.lambda$createSummingGauge$3(StorageMetrics.java:56)
> at
> io.prometheus.client.dropwizard.DropwizardExports.fromGauge(DropwizardExports.java:47)
> at
> io.prometheus.client.dropwizard.DropwizardExports.collect(DropwizardExports.java:133)
> at io.prometheus.client.Collector.collect(Collector.java:45)
> at
> io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.findNextElement(CollectorRegistry.java:204)
> at
> io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.(CollectorRegistry.java:162)
> at
> io.prometheus.client.CollectorRegistry.filteredMetricFamilySamples(CollectorRegistry.java:140)
> at
> io.prometheus.client.exporter.MetricsServlet.doGet(MetricsServlet.java:43)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:735)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:648)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1072)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:382)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1006)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:365)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:485)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:926)
> at
> org.eclipse.jetty.server.AbstractHttpC
[jira] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688 ] Ekaterina Dimitrova deleted comment on CASSANDRA-18688: - was (Author: e.dimitrova): Test comment > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18688) Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out of that
[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807834#comment-17807834 ] Ekaterina Dimitrova commented on CASSANDRA-18688: - Test comment > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: shylaja kokoori >Priority: Normal > Fix For: 5.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19150) Align values in rows in CQLSH right for numbers, left for text
[
https://issues.apache.org/jira/browse/CASSANDRA-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-19150:
---
Description:
*Updated* Jan 17 2024 after dev discussion
Change CQLSH to left-align text while continue to right-align numbers. This
will match how Postgres shell and Excel treat alignment of text and number.
-
*Original*
We need to make this
[https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101]
configurable so values in columns are either all on left or on right side of
the column (basically change col.rjust to col.ljust).
By default, it would be like it is now but there would be configuration
property in cqlsh for that as well as a corresponding CQLSH command (optional),
something like
{code:java}
ALIGNMENT LEFT|RIGHT
{code}
cc [~bschoeni]
was:
We need to make this
https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101
configurable so values in columns are either all on left or on right side of
the column (basically change col.rjust to col.ljust).
By default, it would be like it is now but there would be configuration
property in cqlsh for that as well as a corresponding CQLSH command (optional),
something like
{code}
ALIGNMENT LEFT|RIGHT
{code}
cc [~bschoeni]
> Align values in rows in CQLSH right for numbers, left for text
> --
>
> Key: CASSANDRA-19150
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19150
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Assignee: Arun Ganesh
>Priority: Low
> Fix For: 5.x
>
> Attachments: Screenshot 2023-12-04 at 00.38.16.png, Screenshot
> 2023-12-09 at 16.58.25.png, signature.asc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Updated* Jan 17 2024 after dev discussion
> Change CQLSH to left-align text while continue to right-align numbers. This
> will match how Postgres shell and Excel treat alignment of text and number.
> -
> *Original*
> We need to make this
> [https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101]
> configurable so values in columns are either all on left or on right side of
> the column (basically change col.rjust to col.ljust).
> By default, it would be like it is now but there would be configuration
> property in cqlsh for that as well as a corresponding CQLSH command
> (optional), something like
> {code:java}
> ALIGNMENT LEFT|RIGHT
> {code}
> cc [~bschoeni]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19150) Align values in rows in CQLSH right for numbers, left for text
[
https://issues.apache.org/jira/browse/CASSANDRA-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-19150:
---
Summary: Align values in rows in CQLSH right for numbers, left for text
(was: Make alignment of values in rows in CQLSH configurable.)
> Align values in rows in CQLSH right for numbers, left for text
> --
>
> Key: CASSANDRA-19150
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19150
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Assignee: Arun Ganesh
>Priority: Low
> Fix For: 5.x
>
> Attachments: Screenshot 2023-12-04 at 00.38.16.png, Screenshot
> 2023-12-09 at 16.58.25.png, signature.asc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We need to make this
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101
> configurable so values in columns are either all on left or on right side of
> the column (basically change col.rjust to col.ljust).
> By default, it would be like it is now but there would be configuration
> property in cqlsh for that as well as a corresponding CQLSH command
> (optional), something like
> {code}
> ALIGNMENT LEFT|RIGHT
> {code}
> cc [~bschoeni]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19150) Make alignment of values in rows in CQLSH configurable.
[
https://issues.apache.org/jira/browse/CASSANDRA-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807797#comment-17807797
]
Stefan Miklosovic commented on CASSANDRA-19150:
---
yes, indeed.
> Make alignment of values in rows in CQLSH configurable.
> ---
>
> Key: CASSANDRA-19150
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19150
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Assignee: Arun Ganesh
>Priority: Low
> Fix For: 5.x
>
> Attachments: Screenshot 2023-12-04 at 00.38.16.png, Screenshot
> 2023-12-09 at 16.58.25.png, signature.asc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We need to make this
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101
> configurable so values in columns are either all on left or on right side of
> the column (basically change col.rjust to col.ljust).
> By default, it would be like it is now but there would be configuration
> property in cqlsh for that as well as a corresponding CQLSH command
> (optional), something like
> {code}
> ALIGNMENT LEFT|RIGHT
> {code}
> cc [~bschoeni]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19150) Make alignment of values in rows in CQLSH configurable.
[
https://issues.apache.org/jira/browse/CASSANDRA-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807790#comment-17807790
]
Brad Schoening commented on CASSANDRA-19150:
[~smiklosovic] is it ok to update this Jira to describe the proposal on the
mailing list which seemed to agree that right-align numbers and left-align is a
good solution here?
> Make alignment of values in rows in CQLSH configurable.
> ---
>
> Key: CASSANDRA-19150
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19150
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Stefan Miklosovic
>Assignee: Arun Ganesh
>Priority: Low
> Fix For: 5.x
>
> Attachments: Screenshot 2023-12-04 at 00.38.16.png, Screenshot
> 2023-12-09 at 16.58.25.png, signature.asc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We need to make this
> https://github.com/apache/cassandra/blob/trunk/pylib/cqlshlib/cqlshmain.py#L1101
> configurable so values in columns are either all on left or on right side of
> the column (basically change col.rjust to col.ljust).
> By default, it would be like it is now but there would be configuration
> property in cqlsh for that as well as a corresponding CQLSH command
> (optional), something like
> {code}
> ALIGNMENT LEFT|RIGHT
> {code}
> cc [~bschoeni]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807779#comment-17807779
]
Ekaterina Dimitrova commented on CASSANDRA-19001:
-
{quote}I think checking for 'javac' should be fine when JAVA_HOME is not
defined. If JAVA_HOME is defined, then we check for the existence of
"${JAVA_HOME}/bin/javac" to determine if it's running on a JDK. Would this fix
your edge case?
{quote}
If JAVA_HOME is not defined, Cassandra checks what is in PATH first. Do we
expect users to do more modifications to PATH to adhere? It sounds a bit risky
to me; I hope I do not overengineer it. WDYT?
https://github.com/apache/cassandra/blob/trunk/bin/cassandra.in.sh#L98-L111
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0-rc, 5.0.x, 5.x
>
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cep-15-accord updated (cc9f18b16f -> 7831ed8dfe)
This is an automated email from the ASF dual-hosted git repository.
aleksey pushed a change to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from cc9f18b16f Ninja: Added check that command.route is not null when SPL
is trying to inform, saw this event in CI and need more details to know what
happened
add 7831ed8dfe Pre-requisite changes for CASSANDRA-1
No new revisions were added by this update.
Summary of changes:
modules/accord | 2 +-
.../apache/cassandra/journal/ActiveSegment.java| 132 +---
.../apache/cassandra/journal/AsyncCallbacks.java | 45 ++
.../cassandra/journal/AsyncWriteCallback.java | 29 -
.../org/apache/cassandra/journal/Descriptor.java | 2 +-
.../apache/cassandra/journal/EntrySerializer.java | 6 +-
src/java/org/apache/cassandra/journal/Flusher.java | 77 +--
src/java/org/apache/cassandra/journal/Journal.java | 153 +++--
src/java/org/apache/cassandra/journal/Segment.java | 8 +-
.../org/apache/cassandra/journal/Segments.java | 210 +++---
.../apache/cassandra/journal/StaticSegment.java| 36 +-
src/java/org/apache/cassandra/net/Message.java | 21 +-
.../ResponseContext.java} | 13 +-
.../service/accord/AccordCommandStore.java | 8 +-
.../cassandra/service/accord/AccordJournal.java| 732 ++---
.../service/accord/AccordMessageSink.java | 52 +-
.../cassandra/service/accord/AccordService.java| 43 +-
.../service/accord/AccordVerbHandler.java | 50 +-
.../accord/serializers/ReadDataSerializers.java| 4 +-
.../distributed/test/accord/AccordTestBase.java| 1 -
.../test/AccordJournalSimulationTest.java | 40 +-
.../org/apache/cassandra/journal/JournalTest.java | 12 +-
.../org/apache/cassandra/journal/SegmentTest.java | 8 +-
.../cassandra/service/accord/AccordTestUtils.java | 4 +-
24 files changed, 1121 insertions(+), 567 deletions(-)
create mode 100644 src/java/org/apache/cassandra/journal/AsyncCallbacks.java
delete mode 100644
src/java/org/apache/cassandra/journal/AsyncWriteCallback.java
copy src/java/org/apache/cassandra/{repair/asymmetric/PreferedNodeFilter.java
=> net/ResponseContext.java} (79%)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra-accord) branch trunk updated: Pre-requisite changes for CASSANDRA-18888 (#74)
This is an automated email from the ASF dual-hosted git repository.
aleksey pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
The following commit(s) were added to refs/heads/trunk by this push:
new c524b6d Pre-requisite changes for CASSANDRA-1 (#74)
c524b6d is described below
commit c524b6d3de3923ccb6314715bd987f3b891348ab
Author: Aleksey Yeschenko
AuthorDate: Wed Jan 17 15:14:00 2024 +
Pre-requisite changes for CASSANDRA-1 (#74)
patch by Aleksey Yeschenko; reviewed by Ariel Weisberg for
CASSANDRA-1
---
.../src/main/java/accord/api/MessageSink.java | 2 +-
accord-core/src/main/java/accord/local/Node.java | 29 +++---
.../java/accord/messages/AbstractEpochRequest.java | 8 +-
.../src/main/java/accord/messages/Commit.java | 7 ++
.../java/accord/messages/InformHomeDurable.java| 6 ++
.../{LocalMessage.java => LocalRequest.java} | 19 +++-
.../src/main/java/accord/messages/MessageType.java | 114 -
.../src/main/java/accord/messages/Propagate.java | 32 +-
.../src/main/java/accord/messages/Request.java | 5 +-
.../src/main/java/accord/messages/TxnRequest.java | 8 +-
.../main/java/accord/messages/WaitOnCommit.java| 8 +-
accord-core/src/test/java/accord/Utils.java| 8 +-
.../accord/burn/BurnTestConfigurationService.java | 6 ++
.../src/test/java/accord/impl/basic/Cluster.java | 16 +--
.../test/java/accord/impl/list/ListRequest.java| 6 ++
.../test/java/accord/impl/mock/MockCluster.java| 4 +-
.../src/test/java/accord/local/CommandsTest.java | 6 ++
.../src/test/java/accord/utils/MessageTask.java| 6 ++
.../src/main/java/accord/maelstrom/Cluster.java| 4 +-
.../java/accord/maelstrom/MaelstromRequest.java| 6 ++
.../src/main/java/accord/maelstrom/Main.java | 4 +-
21 files changed, 208 insertions(+), 96 deletions(-)
diff --git a/accord-core/src/main/java/accord/api/MessageSink.java
b/accord-core/src/main/java/accord/api/MessageSink.java
index 47a3fa0..d05f304 100644
--- a/accord-core/src/main/java/accord/api/MessageSink.java
+++ b/accord-core/src/main/java/accord/api/MessageSink.java
@@ -28,7 +28,7 @@ import accord.messages.Request;
public interface MessageSink
{
void send(Id to, Request request);
-void send(Id to, Request request, AgentExecutor executor, Callback
callback);
+void send(Id to, Request request, AgentExecutor executor, Callback
callback);
void reply(Id replyingToNode, ReplyContext replyContext, Reply reply);
void replyWithUnknownFailure(Id replyingToNode, ReplyContext replyContext,
Throwable failure);
}
diff --git a/accord-core/src/main/java/accord/local/Node.java
b/accord-core/src/main/java/accord/local/Node.java
index 9e67cfa..6fc883e 100644
--- a/accord-core/src/main/java/accord/local/Node.java
+++ b/accord-core/src/main/java/accord/local/Node.java
@@ -65,7 +65,7 @@ import accord.coordinate.Persist;
import accord.coordinate.RecoverWithRoute;
import accord.messages.Apply;
import accord.messages.Callback;
-import accord.messages.LocalMessage;
+import accord.messages.LocalRequest;
import accord.messages.Reply;
import accord.messages.ReplyContext;
import accord.messages.Request;
@@ -147,7 +147,7 @@ public class Node implements ConfigurationService.Listener,
NodeTimeService
private final Id id;
private final MessageSink messageSink;
-private final LocalMessage.Handler localMessageHandler;
+private final LocalRequest.Handler localRequestHandler;
private final ConfigurationService configService;
private final TopologyManager topology;
private final CommandStores commandStores;
@@ -168,7 +168,7 @@ public class Node implements ConfigurationService.Listener,
NodeTimeService
// TODO (expected, liveness): monitor the contents of this collection for
stalled coordination, and excise them
private final Map> coordinating =
new ConcurrentHashMap<>();
-public Node(Id id, MessageSink messageSink, LocalMessage.Handler
localMessageHandler,
+public Node(Id id, MessageSink messageSink, LocalRequest.Handler
localRequestHandler,
ConfigurationService configService, LongSupplier nowSupplier,
ToLongFunction nowTimeUnit,
Supplier dataSupplier, ShardDistributor
shardDistributor, Agent agent, RandomSource random, Scheduler scheduler,
TopologySorter.Supplier topologySorter,
Function progressLogFactory,
CommandStores.Factory factory, Execute.Factory executionFactory,
Persist.Factory persistFactory, Apply.Factory applyFactory,
@@ -177,7 +177,7 @@ public class Node implements ConfigurationService.Listener,
NodeTimeService
this.id = id;
this.localConfig = localConfig;
this.messageSink = messageSink;
-this.localMessageHandler = localMessageHandler;
+this.localRequestHandler = localRequestHandler;
th
(cassandra) branch trunk updated (522baab6ed -> 14911e628b)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 522baab6ed Merge branch 'cassandra-5.0' into trunk new f54177bb0a Docker test container fixes: remove unused files/folders in image, and use envs instead of env-file new 14911e628b Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/docker/_docker_init_tests.sh | 8 .build/docker/run-tests.sh | 18 -- .build/docker/ubuntu2004_test.docker | 6 -- 3 files changed, 20 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 14911e628b70f5203a7f9cae7f9e3f92813c1b65 Merge: 522baab6ed f54177bb0a Author: Mick Semb Wever AuthorDate: Wed Jan 17 15:24:12 2024 +0100 Merge branch 'cassandra-5.0' into trunk * cassandra-5.0: Docker test container fixes: remove unused files/folders in image, and use envs instead of env-file .build/docker/_docker_init_tests.sh | 8 .build/docker/run-tests.sh | 18 -- .build/docker/ubuntu2004_test.docker | 6 -- 3 files changed, 20 insertions(+), 12 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated: Docker test container fixes: remove unused files/folders in image, and use envs instead of env-file
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-5.0 by this push:
new f54177bb0a Docker test container fixes: remove unused files/folders in
image, and use envs instead of env-file
f54177bb0a is described below
commit f54177bb0a549cdf5773c20f3453f7bb0f68b0ad
Author: Mick Semb Wever
AuthorDate: Mon Jan 8 23:29:57 2024 +0100
Docker test container fixes: remove unused files/folders in image, and use
envs instead of env-file
Adds warning and reduces container requested cpus if over docker daemon
limits.
patch by Mick Semb Wever; reviewed by Brandon Williams for INFRA-25202
---
.build/docker/_docker_init_tests.sh | 8
.build/docker/run-tests.sh | 18 --
.build/docker/ubuntu2004_test.docker | 6 --
3 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/.build/docker/_docker_init_tests.sh
b/.build/docker/_docker_init_tests.sh
index 7c90833582..1efbd87526 100755
--- a/.build/docker/_docker_init_tests.sh
+++ b/.build/docker/_docker_init_tests.sh
@@ -36,4 +36,12 @@ if [ -d "${DIST_DIR}/test/logs" ]; then
find "${DIST_DIR}/test/logs" -type f -name "*.log" | xargs xz -qq
fi
popd >/dev/null
+
+# check/clean containerfs (it can leak on host)
+if [ -d /home/cassandra-tmp/.m2/repository ]; then
+echo "WARN: /home/cassandra-tmp/.m2/repository exists"
+fi
+# these happen when the image hasn't pre-downloaded all the ccm versions used
in tests
+rm -rf /tmp/ccm-*.tar.gz
+
exit ${status}
\ No newline at end of file
diff --git a/.build/docker/run-tests.sh b/.build/docker/run-tests.sh
index 88a570b891..44fc82da06 100755
--- a/.build/docker/run-tests.sh
+++ b/.build/docker/run-tests.sh
@@ -146,6 +146,11 @@ case ${target} in
esac
docker_cpus=$(echo "scale=2; ${cores} / ( ${jenkins_executors} )" | bc)
+docker_cpus_limit=$(docker info | grep CPUs | cut -d" " -f3)
+if (( $(echo "${docker_cpus} > ${docker_cpus_limit}" |bc -l) )) ; then
+echo "WARNING: requested more cpus (${docker_cpus}) than docker cpu limit
(${docker_cpus_limit}), reducing cpus…"
+docker_cpus=${docker_cpus_limit}
+fi
# hack: long-test does not handle limited CPUs
if [ "${target}" == "long-test" ] ; then
@@ -156,7 +161,7 @@ else
docker_flags="--cpus=${docker_cpus} -m 5g --memory-swap 5g"
fi
-docker_flags="${docker_flags} --env-file build/env.list -d --rm"
+docker_flags="${docker_flags} -d --rm"
# make sure build_dir is good
mkdir -p ${build_dir}/tmp || true
@@ -186,14 +191,7 @@ else
fi
# the docker container's env
-touch build/env.list
-cat > build/env.list <
Re: [PR] Adds integration testing for blocklist handling [cassandra-analytics]
frankgh commented on code in PR #32: URL: https://github.com/apache/cassandra-analytics/pull/32#discussion_r1455673981 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java: ## @@ -50,4 +50,5 @@ public enum WriterOptions implements WriterOption * support mixed case and reserved keyword names for these fields. */ QUOTE_IDENTIFIERS, +BLOCKED_INSTANCES, Review Comment: on second thought these are actually Cassandra instances, correct? I think we should maybe explicitly call them `BLOCKED_CASSANDRA_INSTANCES` maybe? I don't think Sidecar itself is blocked, but rather specific Cassandra instances, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807731#comment-17807731
]
Brandon Williams commented on CASSANDRA-19097:
--
We have approximately zero traction without a reproduction, so +1 to the PR,
let's see how it goes.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19042) Repair fuzz tests fail with paxos_variant: v2
[
https://issues.apache.org/jira/browse/CASSANDRA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-19042:
-
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: User Report
Fix Version/s: 5.x
Severity: Normal
Status: Open (was: Triage Needed)
> Repair fuzz tests fail with paxos_variant: v2
> -
>
> Key: CASSANDRA-19042
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19042
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Feature/Lightweight Transactions,
> Test/fuzz
>Reporter: Branimir Lambov
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> Adding {{paxos_variant: v2}} to the test yaml causes all fuzz repair tests to
> fail with
> {code}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.gms.EndpointStateSerializer.serializedSize(EndpointState.java:337)
> at
> org.apache.cassandra.gms.EndpointStateSerializer.serializedSize(EndpointState.java:300)
> at
> org.apache.cassandra.service.paxos.cleanup.PaxosStartPrepareCleanup$RequestSerializer.serializedSize(PaxosStartPrepareCleanup.java:176)
> at
> org.apache.cassandra.service.paxos.cleanup.PaxosStartPrepareCleanup$RequestSerializer.serializedSize(PaxosStartPrepareCleanup.java:147)
> at
> org.apache.cassandra.net.Message$Serializer.payloadSize(Message.java:1067)
> at org.apache.cassandra.net.Message.payloadSize(Message.java:1114)
> at
> org.apache.cassandra.net.Message$Serializer.serializedSize(Message.java:750)
> at org.apache.cassandra.net.Message.serializedSize(Message.java:1094)
> ...
> {code}
> This happens for all three options of {{paxos_state_purging}} and both with
> and without {{storage_compatibility_mode: NONE}}.
> Tests still fail if {{PaxosStartPrepareCleanup}} is changed to use
> {{EndpointState.nullableSerializer}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-4.0 updated (ee9e418782 -> af752fcd53)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from ee9e418782 Skip version check if an endpoint is dead state in Gossiper#upgradeFromVersionSupplier add af752fcd53 Prepare debian changelog for 4.0.12 No new revisions were added by this update. Summary of changes: debian/changelog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 522baab6ed3ee70cdb36937adbf36b087246 Merge: ab142f8d28 e17373c5ee Author: Stefan Miklosovic AuthorDate: Wed Jan 17 12:52:04 2024 +0100 Merge branch 'cassandra-5.0' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-4.1 updated (fa6e06c933 -> 6d4942c703)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from fa6e06c933 Merge branch 'cassandra-4.0' into cassandra-4.1 add af752fcd53 Prepare debian changelog for 4.0.12 add 6d4942c703 Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch cassandra-5.0 updated (e077c93f0e -> e17373c5ee)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from e077c93f0e Merge branch 'cassandra-4.1' into cassandra-5.0 add af752fcd53 Prepare debian changelog for 4.0.12 add 6d4942c703 Merge branch 'cassandra-4.0' into cassandra-4.1 add e17373c5ee Merge branch 'cassandra-4.1' into cassandra-5.0 No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated (ab142f8d28 -> 522baab6ed)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from ab142f8d28 Put Harry upgrade test under upgrade directory add af752fcd53 Prepare debian changelog for 4.0.12 add 6d4942c703 Merge branch 'cassandra-4.0' into cassandra-4.1 add e17373c5ee Merge branch 'cassandra-4.1' into cassandra-5.0 new 522baab6ed Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
svn commit: r66648 - in /dev/cassandra/4.0.12/redhat: ./ noboolean/ noboolean/repodata/ repodata/
Author: smiklosovic Date: Wed Jan 17 11:16:32 2024 New Revision: 66648 Log: staging cassandra rpm packages for 4.0.12 Added: dev/cassandra/4.0.12/redhat/ dev/cassandra/4.0.12/redhat/cassandra-4.0.12-1.noarch.rpm (with props) dev/cassandra/4.0.12/redhat/cassandra-4.0.12-1.src.rpm (with props) dev/cassandra/4.0.12/redhat/cassandra-tools-4.0.12-1.noarch.rpm (with props) dev/cassandra/4.0.12/redhat/noboolean/ dev/cassandra/4.0.12/redhat/noboolean/cassandra-4.0.12-1.noarch.rpm (with props) dev/cassandra/4.0.12/redhat/noboolean/cassandra-4.0.12-1.src.rpm (with props) dev/cassandra/4.0.12/redhat/noboolean/cassandra-tools-4.0.12-1.noarch.rpm (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/ dev/cassandra/4.0.12/redhat/noboolean/repodata/0a1da854728b33c13d6ab960f85e494d60850102d4052f833b99501bd54f9efb-filelists.xml.gz (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/0a1da854728b33c13d6ab960f85e494d60850102d4052f833b99501bd54f9efb-filelists.xml.gz.asc dev/cassandra/4.0.12/redhat/noboolean/repodata/389a3621cfac88c257f556de033fb2c3990de3b5bc9c626dacbec4c29cb38b7a-other.xml.gz (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/389a3621cfac88c257f556de033fb2c3990de3b5bc9c626dacbec4c29cb38b7a-other.xml.gz.asc dev/cassandra/4.0.12/redhat/noboolean/repodata/5ea33539da927b048e2f538853005fd0c882bdc63164dcb3e65378a080a1e4b4-primary.xml.gz (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/5ea33539da927b048e2f538853005fd0c882bdc63164dcb3e65378a080a1e4b4-primary.xml.gz.asc dev/cassandra/4.0.12/redhat/noboolean/repodata/6505dbfab2b1768d9ca636221402153bf115207ac939fda98f8802f8d10f9dce-other.sqlite.bz2 (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/6505dbfab2b1768d9ca636221402153bf115207ac939fda98f8802f8d10f9dce-other.sqlite.bz2.asc dev/cassandra/4.0.12/redhat/noboolean/repodata/7fb13e43a38d2a5027ff318fcc1d7037e66500995b4bc425911871d29527a852-filelists.sqlite.bz2 (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/7fb13e43a38d2a5027ff318fcc1d7037e66500995b4bc425911871d29527a852-filelists.sqlite.bz2.asc dev/cassandra/4.0.12/redhat/noboolean/repodata/9a8187adf88b2ed7165b0c214f4bbb29e9980d87432c9b0474ad50e7fb734985-primary.sqlite.bz2 (with props) dev/cassandra/4.0.12/redhat/noboolean/repodata/9a8187adf88b2ed7165b0c214f4bbb29e9980d87432c9b0474ad50e7fb734985-primary.sqlite.bz2.asc dev/cassandra/4.0.12/redhat/noboolean/repodata/repomd.xml dev/cassandra/4.0.12/redhat/noboolean/repodata/repomd.xml.asc dev/cassandra/4.0.12/redhat/repodata/ dev/cassandra/4.0.12/redhat/repodata/0fcad434208d233472218d3f43f20945cc3127a9e443b8c9732468fd7a5bee6b-other.xml.gz (with props) dev/cassandra/4.0.12/redhat/repodata/0fcad434208d233472218d3f43f20945cc3127a9e443b8c9732468fd7a5bee6b-other.xml.gz.asc dev/cassandra/4.0.12/redhat/repodata/4b3e8bcfbcd6ed9c43011882b65c454f162affb734bd606749ff6659e61f9162-primary.xml.gz (with props) dev/cassandra/4.0.12/redhat/repodata/4b3e8bcfbcd6ed9c43011882b65c454f162affb734bd606749ff6659e61f9162-primary.xml.gz.asc dev/cassandra/4.0.12/redhat/repodata/71fb4f50bd85f279af7eea98a743c534d427db1f1881ccdbfbc7fea0bffdefd3-filelists.sqlite.bz2 (with props) dev/cassandra/4.0.12/redhat/repodata/71fb4f50bd85f279af7eea98a743c534d427db1f1881ccdbfbc7fea0bffdefd3-filelists.sqlite.bz2.asc dev/cassandra/4.0.12/redhat/repodata/c9051bac1d90a59d4db7006ae1abe28803cd5030dbcd1cba670e7e6197033b90-primary.sqlite.bz2 (with props) dev/cassandra/4.0.12/redhat/repodata/c9051bac1d90a59d4db7006ae1abe28803cd5030dbcd1cba670e7e6197033b90-primary.sqlite.bz2.asc dev/cassandra/4.0.12/redhat/repodata/dd92bdeee937f2adb8066eb98347259a844d09ee25791c68c2cf642a89be3d03-other.sqlite.bz2 (with props) dev/cassandra/4.0.12/redhat/repodata/dd92bdeee937f2adb8066eb98347259a844d09ee25791c68c2cf642a89be3d03-other.sqlite.bz2.asc dev/cassandra/4.0.12/redhat/repodata/f12d328fd3fdef83f7ae54babd7a9993cd48c54a545d7d043ab49917033411c4-filelists.xml.gz (with props) dev/cassandra/4.0.12/redhat/repodata/f12d328fd3fdef83f7ae54babd7a9993cd48c54a545d7d043ab49917033411c4-filelists.xml.gz.asc dev/cassandra/4.0.12/redhat/repodata/repomd.xml dev/cassandra/4.0.12/redhat/repodata/repomd.xml.asc Added: dev/cassandra/4.0.12/redhat/cassandra-4.0.12-1.noarch.rpm == Binary file - no diff available. Propchange: dev/cassandra/4.0.12/redhat/cassandra-4.0.12-1.noarch.rpm -- svn:mime-type = application/octet-stream Added: dev/cassandra/4.0.12/redhat/cassandra-4.0.12-1.src.rpm == Binary file - no diff available. Propchange: dev/cassandra/4.0.12/redhat/cassandra-4.0.12-1.src.rpm
svn commit: r66647 - in /dev/cassandra/4.0.12/debian: ./ dists/ dists/40x/ dists/40x/main/ dists/40x/main/binary-amd64/ dists/40x/main/binary-arm64/ dists/40x/main/binary-i386/ dists/40x/main/source/
Author: smiklosovic Date: Wed Jan 17 11:10:22 2024 New Revision: 66647 Log: staging cassandra debian packages for 4.0.12 Added: dev/cassandra/4.0.12/debian/ dev/cassandra/4.0.12/debian/cassandra-tools_4.0.12_all.deb (with props) dev/cassandra/4.0.12/debian/cassandra_4.0.12.dsc dev/cassandra/4.0.12/debian/cassandra_4.0.12.tar.gz (with props) dev/cassandra/4.0.12/debian/cassandra_4.0.12_all.deb (with props) dev/cassandra/4.0.12/debian/cassandra_4.0.12_amd64.buildinfo dev/cassandra/4.0.12/debian/cassandra_4.0.12_amd64.changes dev/cassandra/4.0.12/debian/dists/ dev/cassandra/4.0.12/debian/dists/40x/ dev/cassandra/4.0.12/debian/dists/40x/InRelease dev/cassandra/4.0.12/debian/dists/40x/Release dev/cassandra/4.0.12/debian/dists/40x/Release.gpg dev/cassandra/4.0.12/debian/dists/40x/main/ dev/cassandra/4.0.12/debian/dists/40x/main/binary-amd64/ dev/cassandra/4.0.12/debian/dists/40x/main/binary-amd64/Packages dev/cassandra/4.0.12/debian/dists/40x/main/binary-amd64/Packages.gz (with props) dev/cassandra/4.0.12/debian/dists/40x/main/binary-amd64/Release dev/cassandra/4.0.12/debian/dists/40x/main/binary-arm64/ dev/cassandra/4.0.12/debian/dists/40x/main/binary-arm64/Packages dev/cassandra/4.0.12/debian/dists/40x/main/binary-arm64/Packages.gz (with props) dev/cassandra/4.0.12/debian/dists/40x/main/binary-arm64/Release dev/cassandra/4.0.12/debian/dists/40x/main/binary-i386/ dev/cassandra/4.0.12/debian/dists/40x/main/binary-i386/Packages dev/cassandra/4.0.12/debian/dists/40x/main/binary-i386/Packages.gz (with props) dev/cassandra/4.0.12/debian/dists/40x/main/binary-i386/Release dev/cassandra/4.0.12/debian/dists/40x/main/source/ dev/cassandra/4.0.12/debian/dists/40x/main/source/Release dev/cassandra/4.0.12/debian/dists/40x/main/source/Sources.gz (with props) dev/cassandra/4.0.12/debian/pool/ dev/cassandra/4.0.12/debian/pool/main/ dev/cassandra/4.0.12/debian/pool/main/c/ dev/cassandra/4.0.12/debian/pool/main/c/cassandra/ dev/cassandra/4.0.12/debian/pool/main/c/cassandra/cassandra-tools_4.0.12_all.deb (with props) dev/cassandra/4.0.12/debian/pool/main/c/cassandra/cassandra_4.0.12.dsc dev/cassandra/4.0.12/debian/pool/main/c/cassandra/cassandra_4.0.12.tar.gz (with props) dev/cassandra/4.0.12/debian/pool/main/c/cassandra/cassandra_4.0.12_all.deb (with props) Added: dev/cassandra/4.0.12/debian/cassandra-tools_4.0.12_all.deb == Binary file - no diff available. Propchange: dev/cassandra/4.0.12/debian/cassandra-tools_4.0.12_all.deb -- svn:mime-type = application/octet-stream Added: dev/cassandra/4.0.12/debian/cassandra_4.0.12.dsc == --- dev/cassandra/4.0.12/debian/cassandra_4.0.12.dsc (added) +++ dev/cassandra/4.0.12/debian/cassandra_4.0.12.dsc Wed Jan 17 11:10:22 2024 @@ -0,0 +1,41 @@ +-BEGIN PGP SIGNED MESSAGE- +Hash: SHA512 + +Format: 1.0 +Source: cassandra +Binary: cassandra, cassandra-tools +Architecture: all +Version: 4.0.12 +Maintainer: Eric Evans +Uploaders: Sylvain Lebresne +Homepage: http://cassandra.apache.org +Standards-Version: 3.8.3 +Vcs-Browser: https://gitbox.apache.org/repos/asf?p=cassandra.git +Vcs-Git: https://gitbox.apache.org/repos/asf/cassandra.git +Build-Depends: debhelper (>= 11), openjdk-8-jdk-headless | openjdk-11-jdk-headless | java8-jdk | java11-jdk, ant (>= 1.10), ant-optional (>= 1.10), dh-python, python3-dev (>= 3.6), quilt, bash-completion +Package-List: + cassandra deb misc extra arch=all + cassandra-tools deb misc extra arch=all +Checksums-Sha1: + 509e1f06a0153aff9e982889502e8dfb74499216 12785900 cassandra_4.0.12.tar.gz +Checksums-Sha256: + 79d46edab9f07c5fc224c9bf237beef4919ffd1a656a550a609452c31762bde1 12785900 cassandra_4.0.12.tar.gz +Files: + ca43ed0da97208f89175cae8f5ff3359 12785900 cassandra_4.0.12.tar.gz + +-BEGIN PGP SIGNATURE- + +iQIzBAEBCgAdFiEEdGSq2QaCQcULpqJiMvNcsvVG2T4FAmWntYwACgkQMvNcsvVG +2T71uxAAzLTNrF1/kT1bd7dPq5YP6WJQDBVNgSjyrLo0eC9I+owXvS7voySgB8oL +e33/bEas2pvuTeUosTRtCXlFIOoE3LTUQ4BiozTB+8SfNDhB9DNuyrtV9vaEdwGS +iRIJojsSE9h6KhjGQCDXMSFckPpn65YQfLSLxRWtOuPc0vhyFXGNuBVXF2YurX8Q +PZhBfzB5hfMvxVy/3nBvYmCLFof/pZTYKdQZmHTnuqXSEfSIQyIQSEqnkkWCrHl5 +JxbDCi0B7i/9bWXnN/ZHlrDUMkTOZ0Bx4AdYELMXLa0V0fc3Kuc85KfTpzIANIS4 +HwD/FcF+rNafQWUdis5G8kcaeRIqlk3sxm+osoxvTuFaaIfA7Fvw4jicto6EBFe3 +0rbb8EFPN+lfCFL/rzJhvTo72WU11Na3ikcthV44LTYzQS8pyUuBG1pD+VE9uiEA +JXV3vp2MJ9Lp3sWtas146mUFGRaIJhdhbW0PNzzNbIzHq2CAC32P9gZY7Ra0arX3 ++nba8qUqE5NCVfahGhyMHaarzu6IFAjDzOEM8GdL5yLsO5E3mv0P2N3jxvsV/t4E +BQZSHysXsx2HSjAOLHtq0NArOuxCwJKl99VpRj358PVh3DJuudYgraYJEyUO91MI +NbwD+ESNlmNQ1XXH4rmCcE3ptE8WGbJzwUiqinYqXUJHCrCy62k= +=eBCH +-END PGP SIGNATURE- Added: dev/cassandra/4.0.12/debian/cassa
svn commit: r66646 - /dev/cassandra/4.0.12/
Author: smiklosovic Date: Wed Jan 17 11:06:22 2024 New Revision: 66646 Log: staging cassandra 4.0.12 Added: dev/cassandra/4.0.12/ dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz (with props) dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.asc dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha256 dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha512 dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz (with props) dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.asc dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.sha256 dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.sha512 Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz == Binary file - no diff available. Propchange: dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz -- svn:mime-type = application/octet-stream Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.asc == --- dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.asc (added) +++ dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.asc Wed Jan 17 11:06:22 2024 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEdGSq2QaCQcULpqJiMvNcsvVG2T4FAmWntB0ACgkQMvNcsvVG +2T6nXRAA2PL7xmW1FITdyMYtSN2uk4HNU+azcdnyZBpeNqNs2bsp1FhYc6zs2fqb +6YZA2rTm3+FMZtUh8QaZGyxk2oGi+AB25RD3K545gVCJgQy3jsYL+SCeHECMsgDY +5NYKx21Lj8Mzz2HmR4dVQiqHmY2oXCKsVgcjJ7DMajbZ48vdp09oTWgjxsN9zKOJ +06PJeV5+RYzmjlYoLaanPyvD4/czVu1A0M0AZIgDPaFFRWOIZ2TZdKgYBSSueKM0 +FHdyXQ4JG9nKIvHgWlA8kCiM6PSwDqU9B57C77atQKWVEMBhrIF0/Oi+HU7kDV9M +wHxVIE/2fdKS1oPcnbVsqOVxxfzTSbTiIZEif5xOu+qarFR6guX/IMqQ7dv129df +GOFQnVZUUkshirsMmEtUCR8TQKSewukqltg396ZxIEQQa/qF7jH+d/+LHjg9HMRF +qCqfkW6zMu8XuD3TqHakmDszMj75JwpymWaDw37swa6HWoV5FDDc+zbojfxWyM1X +K1ZPif9D+XaaPG2zxM+jEXQAkz6cLAyW1SHMr2Kp7aH/s/7bNqUKGf+L/3RWJQzl +O3K4uxV1I4YfMAq4jlYEYwAwjXV2V9Ls63abHAGNO3iNOYkcr/gNu2PQtBfFtedo +X3rUcfrzLnmvoMZDTQL1i3gSe626xOPGW9YrAid+g62YaYjaewM= +=z2ty +-END PGP SIGNATURE- Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha256 == --- dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha256 (added) +++ dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha256 Wed Jan 17 11:06:22 2024 @@ -0,0 +1 @@ +d9b8793f7b4eb0070dd1ef0dd48d81f3a343861f955cfec4e3af152e713f50b6 Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha512 == --- dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha512 (added) +++ dev/cassandra/4.0.12/apache-cassandra-4.0.12-bin.tar.gz.sha512 Wed Jan 17 11:06:22 2024 @@ -0,0 +1 @@ +65de9cc32f3d22d55f5c7c3b1417285a41aabb70fa8a4ae8d9d85a58e644f43151bf4f386cc45773b6ac317db38c4576b139ca6b6fcdbbd16993d09ee2a5c2b8 Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz == Binary file - no diff available. Propchange: dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz -- svn:mime-type = application/octet-stream Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.asc == --- dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.asc (added) +++ dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.asc Wed Jan 17 11:06:22 2024 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEdGSq2QaCQcULpqJiMvNcsvVG2T4FAmWntB8ACgkQMvNcsvVG +2T5uEQ/+PobMv8uqTqvs06UyBUr8nbXxF+rgfK88n9Gv4QhJSMMQsJ775qMx1BCZ +g4xqyN3cik7jGZU7YSKHN2LXUExeRd6aCda4U2NKsgQaOi9H23I7XMAkQCrLt4iI +0D9CiE4UHdKXknK18Aqler1tZ7rOWM+++Tgev8AQSoZiSAuChjc5hkwqTpeNMqSA +VPQzePDkxEg7xiQ8LaVgs1XP/txVlc7cbnuauj2fFysuHBhzF+R8yZYdpGJP0Bz0 +/G4FfRqK9q45cvLEnsrGFaUh1PvdqloqKcoxS68uNiUFq94jHvqv6TH6BdouJa89 +IeZ++qsEiROdOmndLrJ8KomAiqUT2/Gw4uxXydFC4J+N9gGPGd31lZpzYXD8Vjg7 +ZHmmoajEQBxvuwPQZ6EEn9QjDlokfZIL8naN11S+doxyxZtiqUYIjRVmRA0TZYPI +0UXATJ22+8UtOCHEf68D1gdfXgBrOyHv0Rwr8hk5DYDzCshJb2sJxeMd2CtPelSJ +HgwA5YV2kgMhEnk3Yrefu6+iXqZRMwEt9a6scm6jEeFtlWoSXN1R7NFMT+77ugRY +0N0nNXWs0mhWCQhRfZoImPkSHM0YCFyHWbOThd5A3F8uWXXRiZ3G8futFvOYELun +la5pvvECVroloA8MbSspaXgFdJ4R1iyH/6pJLwEScDtiedwUVek= +=6+6U +-END PGP SIGNATURE- Added: dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.sha256 == --- dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.sha256 (added) +++ dev/cassandra/4.0.12/apache-cassandra-4.0.12-src.tar.gz.sha256 Wed Jan 17 11:06:22 2024 @@ -0,0 +1 @@ +3f501489e585e680fbf668579a1687ca5fc2
(cassandra) 01/01: Prepare debian changelog for 4.0.12
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to tag 4.0.12-tentative in repository https://gitbox.apache.org/repos/asf/cassandra.git commit af752fcd535ccdac69b9fed88047b2dd7625801e Author: Stefan Miklosovic AuthorDate: Wed Jan 17 12:02:37 2024 +0100 Prepare debian changelog for 4.0.12 --- debian/changelog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/changelog b/debian/changelog index e362598842..758b62585c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,8 +1,8 @@ -cassandra (4.0.12) UNRELEASED; urgency=medium +cassandra (4.0.12) unstable; urgency=medium * New release - -- Stefan Miklosovic Tue, 18 Jul 2023 09:20:01 +0200 + -- Stefan Miklosovic Wed, 17 Jan 2024 12:02:18 +0100 cassandra (4.0.11) unstable; urgency=medium - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) tag 4.0.12-tentative created (now af752fcd53)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to tag 4.0.12-tentative in repository https://gitbox.apache.org/repos/asf/cassandra.git at af752fcd53 (commit) This tag includes the following new commits: new af752fcd53 Prepare debian changelog for 4.0.12 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807682#comment-17807682
]
Berenguer Blasi edited comment on CASSANDRA-19097 at 1/17/24 10:32 AM:
---
Writes and reads are happening at LOCAL_ONE on those tests. These are 4-node
tests so switching reads to CL.ALL is the best bet so far. We'll only know
after the merge as I didn't manage to repro. If we're happy with the suggested
PR I'd say we merge and keep an eye on them.
All failures both for upgrade and non-upgrade tests, which are all based off
the same base class, match the test methods I had to touch. I did run a 500
repeats CI run for one of the test methods to spare CI cycles , all other
methods are fixed in the same way.
was (Author: bereng):
Writes and reads are happening at LOCAL_ONE on those tests. These are 4-node
tests so switching reads to CL.ALL is the best bet so far. We'll only know
after the merge as I didn't manage to repro. If we're happy with the suggested
PR I'd say we merge and keep an eye on them.
All failures both for upgrade and non-upgrade tests, which are all based off
the same base class, match the test methods I had to touch.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xe
[jira] [Updated] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-19097:
Test and Documentation Plan: See PR
Status: Patch Available (was: In Progress)
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19097) Test Failure: bootstrap_test.TestBootstrap.*
[
https://issues.apache.org/jira/browse/CASSANDRA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807682#comment-17807682
]
Berenguer Blasi commented on CASSANDRA-19097:
-
Writes and reads are happening at LOCAL_ONE on those tests. These are 4-node
tests so switching reads to CL.ALL is the best bet so far. We'll only know
after the merge as I didn't manage to repro. If we're happy with the suggested
PR I'd say we merge and keep an eye on them.
All failures both for upgrade and non-upgrade tests, which are all based off
the same base class, match the test methods I had to touch.
> Test Failure: bootstrap_test.TestBootstrap.*
>
>
> Key: CASSANDRA-19097
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19097
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Michael Semb Wever
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0.x, 5.0-rc
>
>
> test_killed_wiped_node_cannot_join
> test_read_from_bootstrapped_node
> test_shutdown_wiped_node_cannot_join
> Seen in dtests_offheap in CASSANDRA-19034
> https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/258/workflows/cea7d697-ca33-40bb-8914-fb9fc662820a/jobs/21162/parallel-runs/38
> {noformat}
> self =
> def test_killed_wiped_node_cannot_join(self):
> > self._wiped_node_cannot_join_test(gently=False)
> bootstrap_test.py:608:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self = , gently = False
> def _wiped_node_cannot_join_test(self, gently):
> """
> @jira_ticket CASSANDRA-9765
> Test that if we stop a node and wipe its data then the node cannot
> join
> when it is not a seed. Test both a nice shutdown or a forced
> shutdown, via
> the gently parameter.
> """
> cluster = self.cluster
>
> cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
> 'True')
> cluster.populate(3)
> cluster.start()
>
> stress_table = 'keyspace1.standard1'
>
> # write some data
> node1 = cluster.nodelist()[0]
> node1.stress(['write', 'n=10K', 'no-warmup', '-rate', 'threads=8'])
>
> session = self.patient_cql_connection(node1)
> original_rows = list(session.execute("SELECT * FROM
> {}".format(stress_table,)))
>
> # Add a new node, bootstrap=True ensures that it is not a seed
> node4 = new_node(cluster, bootstrap=True)
> node4.start(wait_for_binary_proto=True)
>
> session = self.patient_cql_connection(node4)
> > assert original_rows == list(session.execute("SELECT * FROM
> > {}".format(stress_table,)))
> E assert [Row(key=b'PP...e9\xbb'), ...] == [Row(key=b'PP...e9\xbb'),
> ...]
> E At index 587 diff: Row(key=b'OP2656L630',
> C0=b"E02\xd2\x8clBv\tr\n\xe3\x01\xdd\xf2\x8a\x91\x7f-\x9dm'\xa5\xe7PH\xef\xc1xlO\xab+d",
>
> C1=b"\xb2\xc0j\xff\xcb'\xe3\xcc\x0b\x93?\x18@\xc4\xc7tV\xb7q\xeeF\x82\xa4\xd3\xdcFl\xd9\x87
> \x9a\xde\xdc\xa3",
> C2=b'\xed\xf8\x8d%\xa4\xa6LPs;\x98f\xdb\xca\x913\xba{M\x8d6XW\x01\xea-\xb5
> C3=b'\x9ec\xcf\xc7\xec\xa5\x85Z]\xa6\x19\xeb\xc4W\x1d%lyZj\xb9\x94I\x90\xebZ\xdba\xdd\xdc\x9e\x82\x95\x1c',
>
> C4=b'\xab\x9e\x13\x8b\xc6\x15D\x9b\xccl\xdcX\xb23\xd0\x8b\xa3\xba7\xc1c\xf7F\x1d\xf8e\xbd\x89\xcb\xd8\xd1)f\xdd')
> != Row(key=b'4LN78NONP0',
> C0=b"\xdf\x90\xb3/u\xc9/C\xcdOYG3\x070@#\xc3k\xaa$M'\x19\xfb\xab\xc0\x10]\xa6\xac\x1d\x81\xad",
>
> C1=b'\x8a\xb7j\x95\xf9\xbd?&\x11\xaaH\xcd\x87\xaa\xd2\x85\x08X\xea9\x94\xae8U\x92\xad\xb0\x1b9\xff\x87Z\xe81',
>
> C2=b'6\x1d\xa1-\xf77\xc7\xde+`\xb7\x89\xaa\xcd\xb5_\xe5\xb3\x04\xc7\xb1\x95e\x81s\t1\x8b\x16sc\x0eMm',
>
> C3=b'\xfbi\x08;\xc9\x94\x15}r\xfe\x1b\xae5\xf6v\x83\xae\xff\x82\x9b`J\xc2D\xa6k+\xf3\xd3\xff{C\xd0;',
>
> C4=b'\x8f\x87\x18\x0f\xfa\xadK"\x9e\x96\x87:tiu\xa5\x99\xe1_Ax\xa3\x12\xb4Z\xc9v\xa5\xad\xb8{\xc0\xa3\x93')
> E Left contains 2830 more items, first extra item:
> Row(key=b'5N7N172K30',
> C0=b'Y\x81\xa6\x02\x89\xa0hyp\x00O\xe9kFp$\x86u\xea\n\x7fK\x99\xe1\xf6G\xf77\xf7\xd7\xe1\xc7L\x...0\x87a\x03\xee',
>
> C4=b'\xe8\xd8\x17\xf3\x14\x16Q\x9d\\jb\xde=\x81\xc1B\x9c;T\xb1\xa2O-\x87zF=\x04`\x04\xbd\xc9\x95\xad')
> E Full diff:
> E [
> …
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19263) Fix tcm startup ExceptionInInitializerError when upgrade from 5.0-beta1 to trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-19263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-19263:
Bug Category: Parent values: Degradation(12984)Level 1 values: Other
Exception(12998)
Complexity: Normal
Discovered By: User Report
Reviewers: Marcus Eriksson
Severity: Normal
Status: Open (was: Triage Needed)
> Fix tcm startup ExceptionInInitializerError when upgrade from 5.0-beta1 to
> trunk
>
>
> Key: CASSANDRA-19263
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19263
> Project: Cassandra
> Issue Type: Bug
> Components: Transactional Cluster Metadata
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> 5.0-beta1 had set the storage_compatibility_mode: CASSANDRA_4 explicitly,
> However, the trunk has set storage_compatibility_mode: NONE recently.
> I just upgrade a test cluster from 5.0-beta1 to trunk only with source
> codes(not with conf)
> The trunk source code is incompatible with storage_compatibility_mode:
> CASSANDRA_4. we will get the following exceptions at the start up:
> {code:java}
> INFO [main] 2024-01-03 17:40:54,341 Startup.java:98 - Initializing as first
> CMS node in a new cluster
> Exception (java.lang.NoClassDefFoundError) encountered during startup: Could
> not initialize class org.apache.cassandra.net.MessagingService
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.cassandra.net.MessagingService
> at org.apache.cassandra.tcm.Commit$Handler.(Commit.java:304)
> at
> org.apache.cassandra.tcm.ClusterMetadataService.(ClusterMetadataService.java:181)
> at org.apache.cassandra.tcm.Startup.initializeAsNonCmsNode(Startup.java:146)
> at org.apache.cassandra.tcm.Startup.initialize(Startup.java:99)
> at org.apache.cassandra.tcm.Startup.initialize(Startup.java:86)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:268)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:726)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:876)
> ERROR [main] 2024-01-03 17:40:54,378 CassandraDaemon.java:898 - Exception
> encountered during startup
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.cassandra.net.MessagingService
> at org.apache.cassandra.tcm.Commit$Handler.(Commit.java:304)
> at
> org.apache.cassandra.tcm.ClusterMetadataService.(ClusterMetadataService.java:181)
> at org.apache.cassandra.tcm.Startup.initializeAsNonCmsNode(Startup.java:146)
> at org.apache.cassandra.tcm.Startup.initialize(Startup.java:99)
> at org.apache.cassandra.tcm.Startup.initialize(Startup.java:86)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:268)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:726)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:876)
> {code}
>
> After debugging, I found it was caused by the
> {*}_ExceptionInInitializerError_{*}, in the {_}*LINE-WITH-ISSUE*{_}(logger
> here is null). A circular dependency is here：
> _*(init)MessagingService -> Version(init its static block) ->
> logger.warn(requires the init of MessagingService)*_
>
> {code:java}
> public class MessagingService
> {
>
> private static final Logger logger =
> LoggerFactory.getLogger(MessagingService.class);
> public enum Version
> {
> static
> {
> if (DatabaseDescriptor.getStorageCompatibilityMode().isBefore(5))
> {
> // LINE-WITH-ISSUE
> logger.warn("Starting in storage compatibility mode " +
> DatabaseDescriptor.getStorageCompatibilityMode());
> CURRENT = VERSION_40;
> }
> else
> {
> CURRENT = VERSION_51;
> }
> }
> }
> public static final int current_version = Version.CURRENT.value;
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807668#comment-17807668
]
Benjamin Lerer commented on CASSANDRA-19050:
The patches look good to me.
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19270) Incorrect error type on oversized compound partition key
[
https://issues.apache.org/jira/browse/CASSANDRA-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807665#comment-17807665
]
Nadav Har'El commented on CASSANDRA-19270:
--
Yes, I ran my test on the latest (or so I thought) GA version, Cassandra 4.1.3.
I didn't think of testing on Cassandra 5 before reporting it, sorry.
Here are reproducers (in Scylla's Python-based test framework, but I'm sure you
can figure out what it does):
{{@pytest.fixture(scope="module")}}
{{def table2(cql, test_keyspace):}}
{{ with new_test_table(cql, test_keyspace, "p1 text, p2 text, c1 text, c2
text, PRIMARY KEY ((p1, p2), c1, c2)") as table:}}
{{ yield table}}
{{def test_insert_65k_pk_compound(cql, table2):}}
{{ stmt = cql.prepare(f'INSERT INTO \{table2} (p1, p2, c1, c2) VALUES
(?,?,?,?)')}}
{{ big = 'x'*(65*1024)}}
{{ with pytest.raises(InvalidRequest, match='Key length'):}}
{{ cql.execute(stmt, [big, 'dog', 'cat', 'mouse'])}}
{{ with pytest.raises(InvalidRequest, match='Key length'):}}
{{ cql.execute(stmt, ['dog', big, 'cat', 'mouse'])}}
{{def test_insert_65535_compound_pk(cql, table2):}}
{{ stmt = cql.prepare(f'INSERT INTO \{table2} (p1, p2, c1, c2) VALUES
(?,?,?,?)')}}
{{ length = 65535}}
{{ p1 = "hello" # not particularly long}}
{{ c1 = unique_key_string() # not particularly long}}
{{ c2 = unique_key_string() # not particularly long}}
{{ p2 = random_string(length=(length-len(p1)-100))}}
{{ cql.execute(stmt, [p1, p2, c1, c2])}}
{{ stmt = cql.prepare(f'SELECT * FROM \{table2} WHERE p1=? AND p2=?')}}
{{ assert list(cql.execute(stmt, [p1, p2])) == [(p1, p2, c1, c2)] }}
The first test instead of a clean InvalidRequest as the test expects, get a
NoHostAvailable with the strange message "'H' format requires
# 0 <= number <= 65535"
The second test fails in an even stranger way, with
java.lang.IllegalArgumentException. The compound partition key is 100 bytes
(roughly) shorter than the maximum, and still it doesn't work.
> Incorrect error type on oversized compound partition key
>
>
> Key: CASSANDRA-19270
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19270
> Project: Cassandra
> Issue Type: Bug
>Reporter: Nadav Har'El
>Priority: Normal
>
> Cassandra limits key lengths (partition and clustering) to 64 KB. If a user
> attempts to INSERT data with a partition key or clustering key exceeding that
> size, the result is a clear InvalidRequest error with a message like "{{{}Key
> length of 66560 is longer than maximum of 65535{}}}".
> There is one exception: If you have a *compound* partition key (i.e., two or
> more partition key components) and attempt to write one of them larger than
> 64 KB, then instead of an orderly InvalidRequest like you got when there was
> just one component, now you get a NoHostAvailable with the message:
> "{{{}error("'H' format requires 0 <= number <= 65535")}){}}}". This is not
> only uglier, it can also confuse the Cassandra driver to retry this request -
> because it doesn't realize that the request itself is broken and there is no
> point to repeat it.
> Interestingly, if there are multiple clustering key columns, this problem
> doesn't happen: we still get a nice InvalidRequest if any one of these is
> more than 64 KB.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
