yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456718177
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ########## @@ -341,24 +341,31 @@ private CompletionStage<Map<String, AvailabilityHint>> createSnapshot(RingRespon LOGGER.info("Creating snapshot on instance snapshotName={} keyspace={} table={} datacenter={} fqdn={}", snapshotName, maybeQuotedKeyspace, maybeQuotedTable, datacenter, ringEntry.fqdn()); SidecarInstance sidecarInstance = new SidecarInstanceImpl(ringEntry.fqdn(), sidecarClientConfig.effectivePort()); - createSnapshotFuture = sidecar - .createSnapshot(sidecarInstance, maybeQuotedKeyspace, maybeQuotedTable, snapshotName) - .handle((resp, throwable) -> { - if (throwable == null) - { - // Create snapshot succeeded - return hint; - } - - if (isExhausted(throwable)) - { - LOGGER.warn("Failed to create snapshot on instance", throwable); - return PartitionedDataLayer.AvailabilityHint.DOWN; - } - - LOGGER.error("Unexpected error creating snapshot on instance", throwable); - return PartitionedDataLayer.AvailabilityHint.UNKNOWN; - }); + String resolvedSnapshotTtl = options.clearSnapshot() ? options.effectiveSnapshotTtl() : null; Review Comment: my understanding is when clearSnapshot is true, the snapshot is cleared on job completion; otherwise it sets a TTL and let Cassandra server to delete. I'd wait for Saranya to clarify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org