[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402066#comment-17402066 ] Berenguer Blasi edited comment on CASSANDRA-16621 at 8/20/21, 10:19 AM: Ci on jenkins 4.0 lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1045/ CI on trunk lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1046/ I'll commit when I am back from OOO. I know if I merge now Murphy is going to do his thing and I will have to be fixing stuff during my OOO otherwise... was (Author: bereng): Ci on jenkins 4.0 lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1045/ CI on trunk gtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1046/ I'll commit when I am back from OOO. I know if I merge now Murphy is going to do his thing and I will have to be fixing stuff during my OOO otherwise... > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402066#comment-17402066 ] Berenguer Blasi edited comment on CASSANDRA-16621 at 8/20/21, 10:18 AM: Ci on jenkins 4.0 lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1045/ CI on trunk gtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1046/ I'll commit when I am back from OOO. I know if I merge now Murphy is going to do his thing and I will have to be fixing stuff during my OOO otherwise... was (Author: bereng): Ci on jenkins 4.0 lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1045/ > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402066#comment-17402066 ] Berenguer Blasi edited comment on CASSANDRA-16621 at 8/20/21, 6:39 AM: --- Ci on jenkins 4.0 lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1045/ was (Author: bereng): Ci on jenkins lgtm: https://ci-cassandra.apache.org/job/Cassandra-devbranch/1045/ Going to commit > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401508#comment-17401508 ] Berenguer Blasi edited comment on CASSANDRA-16621 at 8/19/21, 9:30 AM: --- I just thought we didn't run we didn't run compression, long, etc junits. Let me run a jenkins ci first to be on the safe side. Also next week I am OOO so I might commit when I am back preferably unless Andres beats me to it. Edit: compression & long tests lgtm on circle. But stress and other I'll wait for jenkins to be up again, it's down for maintenance now. was (Author: bereng): I just thought we didn't run we didn't run compression, long, etc junits. Let me run a jenkins ci first to be on the safe side. Also next week I am OOO so I might commit when I am back preferably unless Andres beats me to it. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383476#comment-17383476 ] Andres de la Peña edited comment on CASSANDRA-16621 at 7/19/21, 6:11 PM: - I'm not totally sure about how the poll interval affects {{ThreadPoolMetricsTest.testJMXEnabledThreadPoolMetricsWithBlockedThread}}, but I think that [the failing assert|https://github.com/apache/cassandra/blob/a9abf5accb2265c6394bf8134dc5496c5505375c/test/unit/org/apache/cassandra/metrics/ThreadPoolMetricsTest.java#L162] is wrong. The tasks {{task5}} and {{task6}} are asynchronously submitted to the the executor, so they can be executed in any order. I think that the test should consider that they can be submitted in any order, [this way|https://github.com/adelapena/cassandra/commit/4a47cb2f3e6267cd307d5ac907e8a45b9d6b8468]. As soon as we make this change the test seems to consistently pass independently of the poll interval ([j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/678/workflows/29642061-8a38-4c59-9e63-b1cb3f4d66eb/jobs/6885] and [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/678/workflows/29642061-8a38-4c59-9e63-b1cb3f4d66eb/jobs/6883]). Also, as mentioned before, I think it could be useful to have an optimistic poll delay of zero, independent of the poll interval, so tests like this one can have better execution times. For example, {{ThreadPoolMetricsTest}} with a poll delay of zero and poll interval of 100 passes in less than half a second, while with only the poll interval it needs around five seconds to finish. was (Author: adelapena): I'm not totally sure about how the poll interval affects {{ThreadPoolMetricsTest.testJMXEnabledThreadPoolMetricsWithBlockedThread}}, but I think that [the failing assert|https://github.com/apache/cassandra/blob/a9abf5accb2265c6394bf8134dc5496c5505375c/test/unit/org/apache/cassandra/metrics/ThreadPoolMetricsTest.java#L162] is wrong. The tasks {{task5}} and {{task6}} and asynchronously submitted to the the executor, so they can be executed in any order. I think that the test should consider that they can be submitted in any order, [this way|https://github.com/adelapena/cassandra/commit/4a47cb2f3e6267cd307d5ac907e8a45b9d6b8468]. As soon as we make this change the test seems to consistently pass independently of the poll interval ([j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/678/workflows/29642061-8a38-4c59-9e63-b1cb3f4d66eb/jobs/6885] and [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/678/workflows/29642061-8a38-4c59-9e63-b1cb3f4d66eb/jobs/6883]). Also, as mentioned before, I think it could be useful to have an optimistic poll delay of zero, independent of the poll interval, so tests like this one can have better execution times. For example, {{ThreadPoolMetricsTest}} with a poll delay of zero and poll interval of 100 passes in less than half a second, while with only the poll interval it needs around five seconds to finish. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383029#comment-17383029 ] Berenguer Blasi edited comment on CASSANDRA-16621 at 7/19/21, 8:28 AM: --- How weird. I compared your & my code and they are identical. Why would you get such errors and I wouldn't? Everything seems to start with this error which makes little sense to me atm: {noformat} [junit-timeout] Testcase: testRangeDeletionWithoutFlush[0](org.apache.cassandra.cql3.ViewComplexDeletionsTest): Caused an ERROR [junit-timeout] An unexpected protocol error occurred on host localhost/127.0.0.1:34141. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error occurred on host localhost/127.0.0.1:34141. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66) [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27) [junit-timeout] at com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35) [junit-timeout] at com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293) [junit-timeout] at com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:58) [junit-timeout] at com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:45) [junit-timeout] at org.apache.cassandra.cql3.CQLTester.executeNet(CQLTester.java:972) [junit-timeout] at org.apache.cassandra.cql3.ViewComplexTest.createView(ViewComplexTest.java:109) [junit-timeout] at org.apache.cassandra.cql3.ViewComplexDeletionsTest.testRangeDeletion(ViewComplexDeletionsTest.java:247) [junit-timeout] at org.apache.cassandra.cql3.ViewComplexDeletionsTest.testRangeDeletionWithoutFlush(ViewComplexDeletionsTest.java:236) [junit-timeout] Caused by: com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error occurred on host localhost/127.0.0.1:34141. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] at com.datastax.driver.core.Responses$Error.asException(Responses.java:154) [junit-timeout] at com.datastax.driver.core.DefaultResultSetFuture.onSet(DefaultResultSetFuture.java:215) [junit-timeout] at com.datastax.driver.core.RequestHandler.setFinalResult(RequestHandler.java:235) [junit-timeout] at com.datastax.driver.core.RequestHandler.access$2600(RequestHandler.java:61) [junit-timeout] at com.datastax.driver.core.RequestHandler$SpeculativeExecution.setFinalResult(RequestHandler.java:1011) [junit-timeout] at com.datastax.driver.core.RequestHandler$SpeculativeExecution.onSet(RequestHandler.java:814) [junit-timeout] at com.datastax.driver.core.Connection$Dispatcher.channelRead0(Connection.java:1290) [junit-timeout] at com.datastax.driver.core.Connection$Dispatcher.channelRead0(Connection.java:1208) [junit-timeout] at com.datastax.shaded.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:356) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:342) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:335) [junit-timeout] at com.datastax.shaded.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:356) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:342) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:335) [junit-timeout] at com.datastax.shaded.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:356) [junit-timeout] at com.datastax.shaded.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHan
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381622#comment-17381622 ] Jogesh Anand edited comment on CASSANDRA-16621 at 7/16/21, 3:55 AM: +1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly assumed that Awaitility would check the condition right before timeout, but that's clearly not the case. Updated to use a fixed poll interval of ~100ms in the PR. Thanks [~bereng] for sharing. was (Author: djanand): +1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly assumed that Awaitility would check the condition right before timeout, but that's clearly not the case. Updated to use a fixed poll interval of ~100ms in the PR. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375977#comment-17375977 ] Jogesh Anand edited comment on CASSANDRA-16621 at 7/7/21, 6:04 AM: --- [~bereng] - thanks! yeah there are some failures. When I run the failed tests locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they succeed on every run. The exception that I get on the [circle-ci|https://circleci.com/api/v1.1/project/github/djanand/cassandra/3/output/104/0?file=true&allocation-id=60deafb9c3492162b60b9b5e-0-build%2F58BCD97C] tests is: {code:java} com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error occurred on host localhost/127.0.0.1:36945. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66) [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27) [junit-timeout] at com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35) [junit-timeout] at com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293) {code} -When debugging locally, I see that DriverThrowables class loads from cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it.- -This leads me to believe that the build on circle-ci is using a different version of driver than local.- ps: I'm using the default .circleci/config.yml was (Author: djanand): [~bereng] - thanks! yeah there are some failures. When I run the failed tests locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they succeed on every run. The exception that I get on the [circle-ci|https://circleci.com/api/v1.1/project/github/djanand/cassandra/3/output/104/0?file=true&allocation-id=60deafb9c3492162b60b9b5e-0-build%2F58BCD97C] tests is: {code:java} com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error occurred on host localhost/127.0.0.1:36945. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66) [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27) [junit-timeout] at com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35) [junit-timeout] at com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293) {code} When debugging locally, I see that DriverThrowables class loads from cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it. This leads me to believe that the build on circle-ci is using a different version of driver than local. ps: I'm using the default .circleci/config.yml > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375977#comment-17375977 ] Jogesh Anand edited comment on CASSANDRA-16621 at 7/6/21, 7:50 PM: --- [~bereng] - thanks! yeah there are some failures. When I run the failed tests locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they succeed on every run. The exception that I get on the [circle-ci|https://circleci.com/api/v1.1/project/github/djanand/cassandra/3/output/104/0?file=true&allocation-id=60deafb9c3492162b60b9b5e-0-build%2F58BCD97C] tests is: {code:java} com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error occurred on host localhost/127.0.0.1:36945. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66) [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27) [junit-timeout] at com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35) [junit-timeout] at com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293) {code} When debugging locally, I see that DriverThrowables class loads from cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it. This leads me to believe that the build on circle-ci is using a different version of driver than local. ps: I'm using the default .circleci/config.yml was (Author: djanand): [~bereng] - thanks! yeah there are some failures. When I run the failed tests locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they succeed on every run. The exception that I get on the circle-ci tests is: {code:java} com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error occurred on host localhost/127.0.0.1:36945. This is a bug in this library, please report: Must not send frame with WARNING flag for native protocol version < 4 [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66) [junit-timeout] at com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27) [junit-timeout] at com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35) [junit-timeout] at com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293) {code} When debugging locally, I see that DriverThrowables class loads from cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it. This leads me to believe that the build on circle-ci is using a different version of driver than local. ps: I'm using the default .circleci/config.yml > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org