[jira] [Comment Edited] (CASSANDRA-17848) Fix incorrect resource name in LIST PERMISSION output

2022-12-05 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643631#comment-17643631
 ] 

Yifan Cai edited comment on CASSANDRA-17848 at 12/6/22 3:02 AM:


Committed in to cassandra-3.0 as 
[473656c1d53|https://github.com/apache/cassandra/commit/473656c1d53edb998aa60d414221e397797de52b]
 and merged up to trunk.


was (Author: yifanc):
Committed in to cassandra-3.0 as 
[473656c1d53https://github.com/apache/cassandra/commit/473656c1d53edb998aa60d414221e397797de52b]
 and merged up to trunk.

> Fix incorrect resource name in LIST PERMISSION output
> -
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When producing the resource name, it seems to assume that the content in the 
> `[]` is the function's input type, where it could also be part of the 
> function name, as long as it is quoted. Here is an example to reproduce. In 
> cqlsh,
> {code:java}
> > CREATE FUNCTION 
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input 
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
>  role  | username | resource| permission
> ---+--+-+
>  user  |user  |  |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long". 
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION 
> request always fails for the user with "ConfigurationException: Unable to 
> find abstract-type class".
> The bug is discovered by Piotr Sarna.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-17848) Fix incorrect resource name in LIST PERMISSION output

2022-12-04 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643139#comment-17643139
 ] 

Berenguer Blasi edited comment on CASSANDRA-17848 at 12/5/22 7:21 AM:
--

Hi [~yifanc],

thanks for resubmitting it. Iirc you only need one approval for the pre-commit 
workflow. It's mostly green but for a few in 4.1 and trunk which really sound 
like flakies to me. I would still open a ticket for the {{test_cleanup}} one 
and any other one you might consider worth it. But otherwise LGTM +1.


was (Author: bereng):
Hi [~yifanc],

thanks for resubmitting it. Iirc you only need one approval for the pre-commit 
workflow. It's mostly green but for a few in 4.1 and trunk which really sound 
like flakies to me. I would still open a ticket for the {{test_cleanup}} one 
and other one you might consider worth it. But otherwise LGTM +1.

> Fix incorrect resource name in LIST PERMISSION output
> -
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When producing the resource name, it seems to assume that the content in the 
> `[]` is the function's input type, where it could also be part of the 
> function name, as long as it is quoted. Here is an example to reproduce. In 
> cqlsh,
> {code:java}
> > CREATE FUNCTION 
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input 
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
>  role  | username | resource| permission
> ---+--+-+
>  user  |user  |  |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long". 
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION 
> request always fails for the user with "ConfigurationException: Unable to 
> find abstract-type class".
> The bug is discovered by Piotr Sarna.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-17848) Fix incorrect resource name in LIST PERMISSION output

2022-12-02 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642661#comment-17642661
 ] 

Yifan Cai edited comment on CASSANDRA-17848 at 12/2/22 10:21 PM:
-

The circleCI config was modified for convenience and efficiency, e.g. no need 
to click to approve the workflows. Running j11 test with the j8 built artifacts 
is less concerning. However, I just restored the CI configs to the provided one 
in tree for all 4.x branches and triggered new runs. 

--- Update ---

[~bereng], the results are mostly green.  


was (Author: yifanc):
The circleCI config was modified for convenience and efficiency, e.g. no need 
to click to approve the workflows. Running j11 test with the j8 built artifacts 
is less concerning. However, I just restored the CI configs to the provided one 
in tree for all 4.x branches and triggered new runs. 

> Fix incorrect resource name in LIST PERMISSION output
> -
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When producing the resource name, it seems to assume that the content in the 
> `[]` is the function's input type, where it could also be part of the 
> function name, as long as it is quoted. Here is an example to reproduce. In 
> cqlsh,
> {code:java}
> > CREATE FUNCTION 
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input 
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
>  role  | username | resource| permission
> ---+--+-+
>  user  |user  |  |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long". 
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION 
> request always fails for the user with "ConfigurationException: Unable to 
> find abstract-type class".
> The bug is discovered by Piotr Sarna.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-17848) Fix incorrect resource name in LIST PERMISSION output

2022-11-29 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640266#comment-17640266
 ] 

Yifan Cai edited comment on CASSANDRA-17848 at 11/30/22 12:03 AM:
--

||Branch||Source||Circle CI||
|cassandra-3.0|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.0-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.0-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|
|cassandra-3.11|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.11-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.11-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|
|cassandra-4.0|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.0-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.0-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|
|cassandra-4.1|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.1-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.1-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-trunk-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-trunk-CC2B132A-B8D3-4BFC-9DCC-56A4CEABCA33]|


was (Author: yifanc):
Starting commit

CI Results (pending):
||Branch||Source||Circle CI||
|cassandra-3.0|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.0-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.0-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-3.11|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.11-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.11-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-4.0|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.0-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.0-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-4.1|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.1-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.1-0BEEE733-4B08-4382-971F-77727647709C]|
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-trunk-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-trunk-0BEEE733-4B08-4382-971F-77727647709C]|


> Fix incorrect resource name in LIST PERMISSION output
> -
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When producing the resource name, it seems to assume that the content in the 
> `[]` is the function's input type, where it could also be part of the 
> function name, as long as it is quoted. Here is an example to reproduce. In 
> cqlsh,
> {code:java}
> > CREATE FUNCTION 
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input 
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
>  role  | username | resource| permission
> ---+--+-+
>  user  |user  |  |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long". 
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION 
> request always fails for the user with "Configurati

[jira] [Comment Edited] (CASSANDRA-17848) Fix incorrect resource name in LIST PERMISSION output

2022-11-28 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640266#comment-17640266
 ] 

Yifan Cai edited comment on CASSANDRA-17848 at 11/28/22 11:37 PM:
--

Starting commit

CI Results (pending):
||Branch||Source||Circle CI||
|cassandra-3.0|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.0-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.0-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-3.11|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.11-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.11-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-4.0|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.0-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.0-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-4.1|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.1-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.1-0BEEE733-4B08-4382-971F-77727647709C]|
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17848-trunk-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-trunk-0BEEE733-4B08-4382-971F-77727647709C]|



was (Author: yifanc):
Starting commit

CI Results (pending):
||Branch||Source||Circle CI||
|cassandra-3.0|[branch|https://github.com/yifan_cai/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.0-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan_cai/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.0-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-3.11|[branch|https://github.com/yifan_cai/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-3.11-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan_cai/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-3.11-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-4.0|[branch|https://github.com/yifan_cai/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.0-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan_cai/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.0-0BEEE733-4B08-4382-971F-77727647709C]|
|cassandra-4.1|[branch|https://github.com/yifan_cai/cassandra/tree/commit_remote_branch/CASSANDRA-17848-cassandra-4.1-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan_cai/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-cassandra-4.1-0BEEE733-4B08-4382-971F-77727647709C]|
|trunk|[branch|https://github.com/yifan_cai/cassandra/tree/commit_remote_branch/CASSANDRA-17848-trunk-0BEEE733-4B08-4382-971F-77727647709C]|[build|https://app.circleci.com/pipelines/github/yifan_cai/cassandra?branch=commit_remote_branch%2FCASSANDRA-17848-trunk-0BEEE733-4B08-4382-971F-77727647709C]|

 

> Fix incorrect resource name in LIST PERMISSION output
> -
>
> Key: CASSANDRA-17848
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17848
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL/Interpreter
>Reporter: Yifan Cai
>Assignee: Yifan Cai
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> When producing the resource name, it seems to assume that the content in the 
> `[]` is the function's input type, where it could also be part of the 
> function name, as long as it is quoted. Here is an example to reproduce. In 
> cqlsh,
> {code:java}
> > CREATE FUNCTION 
> > test."admin_created_udf[org.apache.cassandra.db.marshal.LongType]"(input 
> > int) RETURNS NULL ON NULL INPUT RETURNS int LANGUAGE java AS 'return 42;';
> > LIST EXECUTE OF user;
>  role  | username | resource| permission
> ---+--+-+
>  user  |user  |  |EXECUTE
> (1 rows)
> {code}
> The input should be "int", but in the output, it says "long". 
> If the content enclosed by "[]" is not a valid class, the LIST PERMISSION 
> request always fails for the user with "Co