[jira] [Comment Edited] (CASSANDRA-18285) Add JDK 11 upgrade tests for 4.0+ in CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730204#comment-17730204
]
Ekaterina Dimitrova edited comment on CASSANDRA-18285 at 6/7/23 5:01 PM:
-
I managed to reproduce the issue with JDK 11 upgrade tests locally by just
commenting out for now
{code:java}
@pytest.mark.skip("Fake skip so that this isn't run outside of a generated
class that removes this annotation"){code}
in upgrade_through_versions_test.py.
I can see in the logs
{code:java}
intx ThreadPriorityPolicy=42 is outside the allowed range [ 0 ... 1 ]
Improperly specified VM option 'ThreadPriorityPolicy=42.'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. The program will exit.
{code}
ThreadPriorityPolicy is an option we use with JDK8. The
upgrade_through_versions_test.py tests use [this multiupgrade
matrix|https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_through_versions_test.py#L903-L920]
which starts from versions that do not support JDK11
This issue is only with upgrade_through_versions.py, and it was not initially
seen in CASSANDRA-17869 because those are skipped to run at all in Jenkins and
up to now we were running upgrade tests with JDK8 in CircleCI. It appears from
the test runs that the rest of the tests are run with JDK 11 and the suitable
options(no issue around ThreadPriorityPolicy observed).
was (Author: e.dimitrova):
I managed to reproduce the issue with JDK 11 upgrade tests locally by just
commenting out for now
{code:java}
@pytest.mark.skip("Fake skip so that this isn't run outside of a generated
class that removes this annotation"){code}
in upgrade_through_versions_test.py.
I can see in the logs
{code:java}
intx ThreadPriorityPolicy=42 is outside the allowed range [ 0 ... 1 ]
Improperly specified VM option 'ThreadPriorityPolicy=42.'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. The program will exit.
{code}
ThreadPriorityPolicy is an option we use with JDK8. The
upgrade_through_versions_test.py tests use [this multiupgrade
matrix|https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_through_versions_test.py#L903-L920]
which starts from versions that do not support JDK11
This issue is only with upgrade_through_versions.py, and it was not initially
seen in CASSANDRA-17869 because those are skipped to run at all in Jenkins. It
appears from the test runs that the rest of the tests are run with JDK 11 and
the suitable options(no issue around ThreadPriorityPolicy observed).
> Add JDK 11 upgrade tests for 4.0+ in CircleCI
> -
>
> Key: CASSANDRA-18285
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18285
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Currently we test upgrades with Java 8, in preparation to drop it we need
> first to ensurer we test with 11. This has to be added not only in trunk,,
> but also 4.1
> I believe [~mck] has this ready to push in Jenkins at some point so this
> ticket should accommodate the addition of those upgrade tests in CircleCI for
> 4.1 and trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18285) Add JDK 11 upgrade tests for 4.0+ in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729866#comment-17729866 ] Ekaterina Dimitrova edited comment on CASSANDRA-18285 at 6/6/23 11:58 PM: -- I added for trunk JDK11 upgrade tests, removing JDK 8 upgrade tests - both Java and Python. Unfortunately, 16 new Python upgrade tests are failing in CircleCI. Those are skipped in Jenkins, similar to CASSANDRA-18499. Unfortunately, I cannot load the artifacts page in CircleCI or reproduce the failures locally. Even if I add --force-resource-intensive-tests as suggested in CASSANDRA-18499. What is weird is I found those running with JDK 8 in CircleCI, like for example here test_parallel_upgrade - it seems it was upgrading from 4.1 with JDK8 - [https://app.circleci.com/pipelines/github/bereng/cassandra/970/workflows/2e949ede-cae5-4ab8-a118-43ec6d722b0d/jobs/18811/artifacts] [~mck] do you mind to review if I am doing something stupid and there is some additional check or anything to be added? After we confirm I didn't break anything myself here, I will also go ahead and add JDK11 upgrade tests for 4.0 and 4.1 (without removing JDK 8 upgrade tests which will run all paths where that one is needed - upgrades from 3.0 and 3.11) [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2362/workflows/fcbacaf2-eacc-491b-a920-07316a9efc73/jobs/24111/tests], [Patch|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18285-trunk-3?expand=1] was (Author: e.dimitrova): I added for trunk JDK11 upgrade tests, removing JDK 8 upgrade tests - both Java and Python. Unfortunately, 16 new Python upgrade tests are failing in CircleCI. Those are skipped in Jenkins, similar to CASSANDRA-18499. Unfortunately, I cannot load the artifacts page in CircleCI and reproduce the failures locally. Even if I add --force-resource-intensive-tests as suggested in CASSANDRA-18499. What is weird is I found those running with JDK 8 in CircleCI, like for example here test_parallel_upgrade - it seems it was upgrading from 4.1 with JDK8 - [https://app.circleci.com/pipelines/github/bereng/cassandra/970/workflows/2e949ede-cae5-4ab8-a118-43ec6d722b0d/jobs/18811/artifacts] [~mck] do you mind to review if I am doing something stupid and there is some additional check or anything to be added? After we confirm I didn't break anything myself here, I will also go ahead and add JDK11 upgrade tests for 4.0 and 4.1 (without removing JDK 8 upgrade tests which will run all paths where that one is needed - upgrades from 3.0 and 3.11) [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2362/workflows/fcbacaf2-eacc-491b-a920-07316a9efc73/jobs/24111/tests], [Patch|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18285-trunk-3?expand=1] > Add JDK 11 upgrade tests for 4.0+ in CircleCI > - > > Key: CASSANDRA-18285 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18285 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > Currently we test upgrades with Java 8, in preparation to drop it we need > first to ensurer we test with 11. This has to be added not only in trunk,, > but also 4.1 > I believe [~mck] has this ready to push in Jenkins at some point so this > ticket should accommodate the addition of those upgrade tests in CircleCI for > 4.1 and trunk. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18285) Add JDK 11 upgrade tests for 4.0+ in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728521#comment-17728521 ] Ekaterina Dimitrova edited comment on CASSANDRA-18285 at 6/2/23 12:43 AM: -- [~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I suspect this is because we do not have any forward testing. If I add a test from 4.0 or 4.1 to 5.0, we will see in the test results also those being run with JDK11, the same way we see all upgrade tests in trunk run with 11? Though it seems in trunk, we should still see them run with 8 as it still needs to be dropped [here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115] What am I missing? It seems we reject 11 pre-5.0 [here| https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-356361c2d7de0e1c4cdb47dd6d81a80567abd7d6f47b09925710c508f5d79b8dR47] and I cannot recall why actually... This is probably because we do not have forward Java upgrade tests added now, but they are not prohibited in the code? We have a check if we upgrade to/*from* CURRENT [here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R198] and [here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R217] was (Author: e.dimitrova): [~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I suspect this is because we do not have any forward testing. If I add a test from 4.0 or 4.1 to 5.0, we will see in the test results also those being run with JDK11, the same way we see all upgrade tests in trunk run with 11? Though it seems in trunk, we should still see them run with 8 as it still needs to be dropped [here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115] What am I missing? It seems we reject 11 pre-5.0 [here| https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-356361c2d7de0e1c4cdb47dd6d81a80567abd7d6f47b09925710c508f5d79b8dR47] and I cannot recall why actually... This is probably because we do not have forward Java upgrade tests, but they are not prohibited in the code? We have a check if we upgrade to/*from* CURRENT [here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R198] and [here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R217] > Add JDK 11 upgrade tests for 4.0+ in CircleCI > - > > Key: CASSANDRA-18285 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18285 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > Currently we test upgrades with Java 8, in preparation to drop it we need > first to ensurer we test with 11. This has to be added not only in trunk,, > but also 4.1 > I believe [~mck] has this ready to push in Jenkins at some point so this > ticket should accommodate the addition of those upgrade tests in CircleCI for > 4.1 and trunk. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18285) Add JDK 11 upgrade tests for 4.0+ in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728521#comment-17728521 ] Ekaterina Dimitrova edited comment on CASSANDRA-18285 at 6/2/23 12:41 AM: -- [~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I suspect this is because we do not have any forward testing. If I add a test from 4.0 or 4.1 to 5.0, we will see in the test results also those being run with JDK11, the same way we see all upgrade tests in trunk run with 11? Though it seems in trunk, we should still see them run with 8 as it still needs to be dropped [here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115] What am I missing? It seems we reject 11 pre-5.0 [here| https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-356361c2d7de0e1c4cdb47dd6d81a80567abd7d6f47b09925710c508f5d79b8dR47] and I cannot recall why actually... This is probably because we do not have forward Java upgrade tests, but they are not prohibited in the code? We have a check if we upgrade to/*from* CURRENT [here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R198] and [here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R217] was (Author: e.dimitrova): [~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I suspect this is because we do not have any forward testing. If I add a test from 4.0 or 4.1 to 5.0, we will see in the test results also those being run with JDK11, the same way we see all upgrade tests in trunk run with 11? Though it seems in trunk, we should still see them run with 8 as it still needs to be dropped [here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115] What am I missing? > Add JDK 11 upgrade tests for 4.0+ in CircleCI > - > > Key: CASSANDRA-18285 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18285 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > Currently we test upgrades with Java 8, in preparation to drop it we need > first to ensurer we test with 11. This has to be added not only in trunk,, > but also 4.1 > I believe [~mck] has this ready to push in Jenkins at some point so this > ticket should accommodate the addition of those upgrade tests in CircleCI for > 4.1 and trunk. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18285) Add JDK 11 upgrade tests for 4.0+ in CircleCI
[ https://issues.apache.org/jira/browse/CASSANDRA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728521#comment-17728521 ] Ekaterina Dimitrova edited comment on CASSANDRA-18285 at 6/2/23 12:32 AM: -- [~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I suspect this is because we do not have any forward testing. If I add a test from 4.0 or 4.1 to 5.0, we will see in the test results also those being run with JDK11, the same way we see all upgrade tests in trunk run with 11? Though it seems in trunk, we should still see them run with 8 as it still needs to be dropped [here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115] What am I missing? was (Author: e.dimitrova): [~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I suspect this is because we do not have any forward testing. If I add a test from 4.0 or 4.1 to 5.0, we will see in the test results also those being run with JDK11, the same way we know all upgrade tests in the trunk run with 11? Though it seems in trunk, we should still see them run with 8 as it still needs to be dropped [here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115] What am I missing? > Add JDK 11 upgrade tests for 4.0+ in CircleCI > - > > Key: CASSANDRA-18285 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18285 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > Currently we test upgrades with Java 8, in preparation to drop it we need > first to ensurer we test with 11. This has to be added not only in trunk,, > but also 4.1 > I believe [~mck] has this ready to push in Jenkins at some point so this > ticket should accommodate the addition of those upgrade tests in CircleCI for > 4.1 and trunk. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
