[jira] [Comment Edited] (CASSANDRA-19201) Refactor cqlshmain global constants
[
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818075#comment-17818075
]
Stefan Miklosovic edited comment on CASSANDRA-19201 at 2/16/24 6:56 PM:
[CASSANDRA-19201|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19201]
{noformat}
java17_pre-commit_tests
✓ j17_build4m 51s
✓ j17_cqlsh_dtests_py3117m 6s
✓ j17_cqlsh_dtests_py311_vnode 7m 17s
✓ j17_cqlsh_dtests_py386m 33s
✓ j17_cqlsh_dtests_py38_vnode 7m 1s
✓ j17_cqlshlib_cython_tests7m 28s
✓ j17_cqlshlib_tests 6m 33s
✓ j17_dtests 34m 42s
✓ j17_dtests_vnode36m 16s
✕ j17_jvm_dtests 24m 24s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testOptionalMtlsModeDoNotAllowNonSSLConnections TIMEOUTED
org.apache.cassandra.fuzz.harry.integration.model.ConcurrentQuiescentCheckerIntegrationTest
testConcurrentReadWriteWorkload
✕ j17_jvm_dtests_vnode23m 17s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testOptionalMtlsModeDoNotAllowNonSSLConnections TIMEOUTED
✕ j17_unit_tests 14m 51s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_utests_oa 13m 45s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/6f0ca0b9-ff42-4639-bbe4-f3ed8effd14b]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/c06ee01c-d4ae-4d4d-9138-5a3e9c92bdeb]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/e1c9b219-ffd0-48d7-afd5-1e3ed219f002]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/f0ff1f5a-fcf3-4294-beae-c5ba8bb6fb6e]
this is the fix
https://github.com/instaclustr/cassandra/tree/CASSANDRA-19201
was (Author: smiklosovic):
[CASSANDRA-19201|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19201]
{noformat}
java17_pre-commit_tests
✓ j17_build4m 51s
✓ j17_cqlsh_dtests_py3117m 6s
✓ j17_cqlsh_dtests_py311_vnode 7m 17s
✓ j17_cqlsh_dtests_py386m 33s
✓ j17_cqlsh_dtests_py38_vnode 7m 1s
✓ j17_cqlshlib_cython_tests7m 28s
✓ j17_cqlshlib_tests 6m 33s
✓ j17_dtests 34m 42s
✓ j17_dtests_vnode36m 16s
✕ j17_jvm_dtests 24m 24s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testOptionalMtlsModeDoNotAllowNonSSLConnections TIMEOUTED
org.apache.cassandra.fuzz.harry.integration.model.ConcurrentQuiescentCheckerIntegrationTest
testConcurrentReadWriteWorkload
✕ j17_jvm_dtests_vnode23m 17s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testOptionalMtlsModeDoNotAllowNonSSLConnections TIMEOUTED
✕ j17_unit_tests 14m 51s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_utests_oa 13m 45s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/6f0ca0b9-ff42-4639-bbe4-f3ed8effd14b]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/c06ee01c-d4ae-4d4d-9138-5a3e9c92bdeb]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/e1c9b219-ffd0-48d7-afd5-1e3ed219f002]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3888/workflows/f0ff1f5a-fcf3-4294-beae-c5ba8bb6fb6e]
> Refactor cqlshmain global constants
> ---
>
> Key: CASSANDRA-19201
> URL:
[jira] [Comment Edited] (CASSANDRA-19201) Refactor cqlshmain global constants
[
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818038#comment-17818038
]
Stefan Miklosovic edited comment on CASSANDRA-19201 at 2/16/24 4:36 PM:
[~bschoeni] well, it helped, but there are few more failures (1)
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3887/workflows/f5e8d089-39ab-4760-a869-f480a948bbfd/jobs/193078/parallel-runs/21?filterBy=FAILED]
Please take a look, thank you very much
However, I think that it wont be so easy, because Python driver is using Shell
so it wont match the arguments which I fixed
{noformat}
✕ j17_cqlsh_dtests_py311 6m 52s
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy
test_round_trip_with_authentication
AssertionError: Failed to import 10 rows
STDOUT:
Warning: Using a password on the command line interface can be
insecure.
Recommendation: use the credentials file to securely provide the
password.
Using CQL driver:
Using connect timeout: 5 seconds
Using 'utf-8' encoding
Using ssl: False
Traceback (most recent call last):
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 779, in
onecmd
self.handle_statement(st, statementtext)
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 816, in
handle_statement
return custom_handler(parsed)
^^
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 1486, in
do_source
subshell = Shell(self.hostname, self.port, color=self.color,
^
TypeError: Shell.__init__() missing 1 required positional argument:
'config_file'
STDERR:
{noformat}
So, I think that we need to more CONFIG_FILE back as it was before ...
was (Author: smiklosovic):
[~bschoeni] well, it helped, but there are few more failures (1)
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3887/workflows/f5e8d089-39ab-4760-a869-f480a948bbfd/jobs/193078/parallel-runs/21?filterBy=FAILED]
Please take a look, thank you very much
> Refactor cqlshmain global constants
> ---
>
> Key: CASSANDRA-19201
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Low
> Fix For: 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Refactor global constants
> * move globals CASSANDRA_CQL_HTML and cqlruleset
> * move module level defaults (DEFAULT_) into Shell class
> * move setup_cqlruleset into cqlshhandling
> Remove unused exceptions
> * FunctionNotFound(Exception)
> * AggregateNotFound(Exception)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19201) Refactor cqlshmain global constants
[
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818038#comment-17818038
]
Stefan Miklosovic edited comment on CASSANDRA-19201 at 2/16/24 4:36 PM:
[~bschoeni] well, it helped, but there are few more failures (1)
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3887/workflows/f5e8d089-39ab-4760-a869-f480a948bbfd/jobs/193078/parallel-runs/21?filterBy=FAILED]
Please take a look, thank you very much
However, I think that it wont be so easy, because Python driver is using Shell
so it wont match the arguments which I fixed
{noformat}
✕ j17_cqlsh_dtests_py311 6m 52s
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy
test_round_trip_with_authentication
AssertionError: Failed to import 10 rows
STDOUT:
Warning: Using a password on the command line interface can be
insecure.
Recommendation: use the credentials file to securely provide the
password.
Using CQL driver:
Using connect timeout: 5 seconds
Using 'utf-8' encoding
Using ssl: False
Traceback (most recent call last):
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 779, in
onecmd
self.handle_statement(st, statementtext)
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 816, in
handle_statement
return custom_handler(parsed)
^^
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 1486, in
do_source
subshell = Shell(self.hostname, self.port, color=self.color,
^
TypeError: Shell.__init__() missing 1 required positional argument:
'config_file'
STDERR:
{noformat}
So, I think that we need to move CONFIG_FILE back as it was before ...
was (Author: smiklosovic):
[~bschoeni] well, it helped, but there are few more failures (1)
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3887/workflows/f5e8d089-39ab-4760-a869-f480a948bbfd/jobs/193078/parallel-runs/21?filterBy=FAILED]
Please take a look, thank you very much
However, I think that it wont be so easy, because Python driver is using Shell
so it wont match the arguments which I fixed
{noformat}
✕ j17_cqlsh_dtests_py311 6m 52s
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy
test_round_trip_with_authentication
AssertionError: Failed to import 10 rows
STDOUT:
Warning: Using a password on the command line interface can be
insecure.
Recommendation: use the credentials file to securely provide the
password.
Using CQL driver:
Using connect timeout: 5 seconds
Using 'utf-8' encoding
Using ssl: False
Traceback (most recent call last):
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 779, in
onecmd
self.handle_statement(st, statementtext)
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 816, in
handle_statement
return custom_handler(parsed)
^^
File
"/home/cassandra/cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 1486, in
do_source
subshell = Shell(self.hostname, self.port, color=self.color,
^
TypeError: Shell.__init__() missing 1 required positional argument:
'config_file'
STDERR:
{noformat}
So, I think that we need to more CONFIG_FILE back as it was before ...
> Refactor cqlshmain global constants
> ---
>
> Key: CASSANDRA-19201
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Low
> Fix For: 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Refactor global constants
> * move globals CASSANDRA_CQL_HTML and cqlruleset
> * move module level defaults (DEFAULT_) into Shell class
> * move setup_cqlruleset into cqlshhandling
> Remove unused exceptions
> * FunctionNotFound(Exception)
> * AggregateNotFound(Exception)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19201) Refactor cqlshmain global constants
[
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817963#comment-17817963
]
Stefan Miklosovic edited comment on CASSANDRA-19201 at 2/16/24 2:01 PM:
Well ... something went horribly wrong here
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/parallel-runs/5?filterBy=FAILED]
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/tests]
Try to fix this
{noformat}
pytest
--cassandra-dir=/home/fermat/dev/cassandra/cassandra-instaclustr/cassandra
cqlsh_tests/test_cqlsh_copy.py::TestCqlshCopy::test_copy_options_from_config_file
{noformat}
Then I think it will fix a lot of things automatically.
was (Author: smiklosovic):
Well ... something went horribly wrong here
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/parallel-runs/5?filterBy=FAILED]
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/tests
> Refactor cqlshmain global constants
> ---
>
> Key: CASSANDRA-19201
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Low
> Fix For: 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Refactor global constants
> * move globals CASSANDRA_CQL_HTML and cqlruleset
> * move module level defaults (DEFAULT_) into Shell class
> * move setup_cqlruleset into cqlshhandling
> Remove unused exceptions
> * FunctionNotFound(Exception)
> * AggregateNotFound(Exception)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19201) Refactor cqlshmain global constants
[ https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817963#comment-17817963 ] Stefan Miklosovic edited comment on CASSANDRA-19201 at 2/16/24 1:42 PM: Well ... something went horribly wrong here [https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/parallel-runs/5?filterBy=FAILED] https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/tests was (Author: smiklosovic): Well ... something went horribly wrong here https://app.circleci.com/pipelines/github/instaclustr/cassandra/3880/workflows/e293c020-1d32-4a98-aacf-a2b56d4c2810/jobs/192395/parallel-runs/5?filterBy=FAILED > Refactor cqlshmain global constants > --- > > Key: CASSANDRA-19201 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19201 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Low > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > Refactor global constants > * move globals CASSANDRA_CQL_HTML and cqlruleset > * move module level defaults (DEFAULT_) into Shell class > * move setup_cqlruleset into cqlshhandling > Remove unused exceptions > * FunctionNotFound(Exception) > * AggregateNotFound(Exception) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
