[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-17 Thread Jon Meredith (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085827#comment-17085827
 ] 

Jon Meredith commented on CASSANDRA-15709:
--

I think it's good to merge, as long as you're happy with it and a +1 from a 
non-committer is acceptable.

It just needs these two commits merged (fixup on the second) and the commit 
message updated to record David as the reviewer and you as the merger.
04e45f97377026b92fc42c2dc85633d1c54eac67
596e924a35e5513d9b8e72329f4a897c9631bcb9

I'm happy to do the squash/fixup comments and force-push up to the review 
branch if you'd like

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Assignee: Jon Meredith
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0-alpha
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-17 Thread Jira 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085665#comment-17085665
 ] 

Andres de la Peña commented on CASSANDRA-15709:
---

I can commit it if this is reviewed and ready.

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Assignee: Jon Meredith
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0-alpha
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-10 Thread Ekaterina Dimitrova (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080855#comment-17080855
 ] 

Ekaterina Dimitrova commented on CASSANDRA-15709:
-

[~djoshi], [~dcapwell], is there anything else we are looking for in this one?
Or only a committer? (I know David is not a committer, same as me :D ) 

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Assignee: Jon Meredith
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0-alpha
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-10 Thread David Capwell (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080643#comment-17080643
 ] 

David Capwell commented on CASSANDRA-15709:
---

update looks good, +1

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Assignee: Jon Meredith
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0-alpha
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-10 Thread David Capwell (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080632#comment-17080632
 ] 

David Capwell commented on CASSANDRA-15709:
---

Been running in a loop for awhile without issue.  Most of my comments are small 
or nits, so assuming you resolve them I am +1

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Assignee: Jon Meredith
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0-alpha
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-10 Thread David Capwell (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080625#comment-17080625
 ] 

David Capwell commented on CASSANDRA-15709:
---

patch mostly LGTM.  I am currently testing to see how flaky it is before/after. 
 

Without limiting resources I was able to cause it to fail quickly, running with 
your patch now.

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Assignee: Jon Meredith
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 4.0-alpha
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-09 Thread Jon Meredith (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080105#comment-17080105
 ] 

Jon Meredith commented on CASSANDRA-15709:
--

CircleCI - 
[Java8|https://circleci.com/workflow-run/100b06b5-508e-4a9a-949f-1ec67d84b232] 
[Java11|https://circleci.com/workflow-run/a613c680-0c80-41ac-bd6a-c66ff81e81fd]

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-09 Thread David Capwell (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079953#comment-17079953
 ] 

David Capwell commented on CASSANDRA-15709:
---

If it helps I use the following to slow things down 
https://issues.apache.org/jira/browse/CASSANDRA-15650?focusedCommentId=17064073=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17064073.
 

I saw this with HIGHER configs and Marcus saw it with HIGHER configs, so 
slowing down may not be desirable; sharing mostly as a FYI if it helps

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-15709) SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure

2020-04-09 Thread Jon Meredith (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079623#comment-17079623
 ] 

Jon Meredith commented on CASSANDRA-15709:
--

I'll try and reproduce - it's possible this is some unlucky scheduling on an 
otherwise busy machine. 

> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> ---
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest 
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout] 
> [junit-timeout] Testcase: 
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
>FAILED
> [junit-timeout] expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: expected: but 
> was:
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout]   at 
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout] 
> [junit-timeout] 
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org