[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677168#comment-17677168
]
Berenguer Blasi commented on CASSANDRA-18032:
-
Take 2 committed:
https://github.com/apache/cassandra/commit/f384e694825a2cd0a95debf30accb153f00e80b0
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676611#comment-17676611
]
Andres de la Peña commented on CASSANDRA-18032:
---
Thanks for preparing the patches for the other branches, they seem identical as
expected. I have tested them:
* Without manually specified env vars nor new tests to be automatically
detected.
* With manually specified env vars and without new tests to be automatically
detected.
* Without manually specified env vars and with new tests to be automatically
detected.
* With manually specified env vars and with new tests to be automatically
detected.
In all cases the written env vars are correct and the return code is zero, so
let's commit the proposed fix.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676470#comment-17676470
]
Berenguer Blasi commented on CASSANDRA-18032:
-
Ah that's not nice. I tested a few things manually but not this one. New PRs:
- [3.0|https://github.com/apache/cassandra/pull/2089]
- [3.11|https://github.com/apache/cassandra/pull/2090]
- [4.0|https://github.com/apache/cassandra/pull/2091]
- [4.1|https://github.com/apache/cassandra/pull/2092]
- [trunk|https://github.com/apache/cassandra/pull/2093]
I tested manually you can set an env var on all branches.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676274#comment-17676274
]
Andres de la Peña commented on CASSANDRA-18032:
---
[Here|https://github.com/apache/cassandra/compare/trunk...adelapena:18032-trunk-followup]
is a possible fix.
The problem was that [the calls to grep inside this
subshell|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh#L206-L211]
were returning 1 (not found) when the diff is empty, and the new {{set -e}}
was interrupting the execution due to that not-zero return code. The solution
is just suppressing that code, which can be done in multiple ways.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676248#comment-17676248
]
Brandon Williams commented on CASSANDRA-18032:
--
A non-zero error code is definitely be returned even upon success now.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676243#comment-17676243
]
Andres de la Peña commented on CASSANDRA-18032:
---
I'm afraid that, as reported by [~stefan.miklosovic], the {{set -e}} is
breaking the writing of env vars, including those used for test multiplexer.
For example, if you run:
{code:java}
.circleci/generate.sh -l -e
REPEATED_JVM_DTESTS=org.apache.cassandra.distributed.test.AuthTest
{code}
The {{REPEATED_JVM_DTESTS}} is not written:
{code:java}
Generating new config.yml file with low resources from config-2_1.yml
Detecting new or modified tests with git diff --diff-filter=AMR trunk...HEAD:
{code}
I suspect that [this
subshell|https://github.com/apache/cassandra/blob/trunk/.circleci/generate.sh#L206-L211]
is producing a not-zero output that immediately stops execution.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675825#comment-17675825
]
Berenguer Blasi commented on CASSANDRA-18032:
-
Thx for the reviews!
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675579#comment-17675579
]
Andres de la Peña commented on CASSANDRA-18032:
---
+1
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656596#comment-17656596
]
Berenguer Blasi commented on CASSANDRA-18032:
-
Added the rest of the PRs and tested manually on all of them that on a missing
circleci executable it fails properly.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656034#comment-17656034
]
Andres de la Peña commented on CASSANDRA-18032:
---
Looks good to me, +1
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656025#comment-17656025
]
Berenguer Blasi commented on CASSANDRA-18032:
-
I changed the PR to stick to a simple `set -e` to address [~adelapena]
comments. If it looks ok and sbdy can +1 then I'll push the other PRs.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632318#comment-17632318
]
Berenguer Blasi commented on CASSANDRA-18032:
-
Thx for the feedback. Yes I added a explicit check for the existence of circle
so we could print a nice message. Also it appeared to me if you don't have it
you wouldn't be using generate.sh at all. But I can change it and I can wait
sure.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632287#comment-17632287
]
Ekaterina Dimitrova commented on CASSANDRA-18032:
-
Thanks for handling this, can we wait not to commit it until we are done with
the last 4.1 blockers, please?
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632271#comment-17632271
]
Andres de la Peña commented on CASSANDRA-18032:
---
The PR adds that {{set -e}} option and also a check to verify that {{circleci}}
is available.
As mentioned above, {{circleci}} command is only [needed by the {{-a}}
option|https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md#updating-the-config],
and [also by {{{}-l{}}}, {{-m}} and
{{-h}}|https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md#switching-to-higher-resource-settings].
However, the proposed check doesn't verify which flags are run, so it prevents
users from exclusively detecting tests and/or setting environment vars with,
for example, {{{}.circleci/generate.sh -e REPEATED_UTESTS_COUNT=10{}}}.
I think we should do that check if any of the flags requiring {{circleci}} tool
is present. That would be in practice almost identical to using {{set -e}}
alone, just replacing the printed message.
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632175#comment-17632175
]
Berenguer Blasi commented on CASSANDRA-18032:
-
Tested locally. If we're happy with the approach I will put up the rest of the
PRs
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x
>
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631854#comment-17631854
]
Andres de la Peña commented on CASSANDRA-18032:
---
Indeed we should immediately fail if [CircleCI local
CLI|https://circleci.com/docs/local-cli/] is not installed. That tool is
[needed by the {{-a}}
option|https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md#updating-the-config],
and [also by {{{}-l{}}}, {{-m}} and
{{-h}}|https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md#switching-to-higher-resource-settings].
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Priority: Normal
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18032) When generate.sh fails its rc=0
[
https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631812#comment-17631812
]
Brandon Williams commented on CASSANDRA-18032:
--
//cc [~adelapena]
> When generate.sh fails its rc=0
> ---
>
> Key: CASSANDRA-18032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18032
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Priority: Normal
>
> {code}
> $ ./generate.sh -a
> Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES
> templates from config-2_1.yml
> ./generate.sh: line 171: circleci: command not found
> patching file ./config-2_1.yml
> Hunk #4 succeeded at 1511 (offset 9 lines).
> Hunk #5 succeeded at 1525 (offset 9 lines).
> Hunk #6 succeeded at 1540 (offset 9 lines).
> Hunk #7 succeeded at 1554 (offset 9 lines).
> Hunk #8 succeeded at 1569 (offset 9 lines).
> Hunk #9 succeeded at 1583 (offset 9 lines).
> Hunk #10 succeeded at 1598 (offset 9 lines).
> Hunk #11 succeeded at 1616 (offset 9 lines).
> Hunk #12 succeeded at 1631 (offset 9 lines).
> Hunk #13 succeeded at 1649 (offset 9 lines).
> Hunk #14 succeeded at 1664 (offset 9 lines).
> Hunk #15 succeeded at 1682 (offset 9 lines).
> Hunk #16 succeeded at 1697 (offset 9 lines).
> ./generate.sh: line 177: circleci: command not found
> patching file ./config-2_1.yml
> ./generate.sh: line 183: circleci: command not found
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
