[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679187#comment-17679187 ] Mike Adamson commented on CASSANDRA-18058: -- [~adelapena] Thanks for the information about the CI setup. I will update my CASSANDRA-18062 branch to use these settings. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: NA > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678754#comment-17678754 ] Andres de la Peña commented on CASSANDRA-18058: --- CI looks good to me. The [only failure|https://app.circleci.com/pipelines/github/adelapena/cassandra/2564/workflows/5b074e0f-6328-4397-8a2a-53dc58ebd0ff/jobs/25525] seems to be a known flaky, CASSANDRA-17708. If [~maedhroz] doesn't have anything else to add I think we are ready to merge. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[
https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678665#comment-17678665
]
Andres de la Peña commented on CASSANDRA-18058:
---
[~mike_tr_adamson] I think that the run is using the default CircleCI config,
which doesn't have enough resources to run dtests. That config is using
CircleCI on free tier.
Usually the config with more resources can be generated with:
{code:java}
.circleci/generate.sh -m
{code}
That script sets the resources, diffs the branch against its base branch,
detects and automatically sets the repeated runs of any modified tests.
However, in this case it seems that the number of modified tests is so large
that CircleCI rejects the config file. So I have prepared [a version of the
mid-resources
config|https://github.com/adelapena/cassandra/commit/420dd4970e78307d8398ed2f39788b00725fce55]
without the automatic detection of unit tests:
* j8:
[https://app.circleci.com/pipelines/github/adelapena/cassandra/2564/workflows/5b074e0f-6328-4397-8a2a-53dc58ebd0ff]
* j11:
[https://app.circleci.com/pipelines/github/adelapena/cassandra/2564/workflows/d8521983-64bf-4447-9af9-612ef2f09327]
> In-memory index and query path
> --
>
> Key: CASSANDRA-18058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18058
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Fix For: 5.x
>
>
> An in-memory index using the in-memory trie structure introduced with
> CASSANDRA-17240 along with a query path implementation to perform index
> queries from the in-memory index.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678640#comment-17678640 ] Mike Adamson commented on CASSANDRA-18058: -- [~maedhroz] [~adelapena] The latest test round is here: https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/93/workflows/d1e240c4-8aaa-4749-a097-dabefa938fa4. There seems to be a general problem with dtests atm on CI. I have taken a random sample of failing dtests and run them locally and they are passing. All unit tests are passing. We now have 2 approvals on the PR are you happy for this to be merged? > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678357#comment-17678357 ] Caleb Rackliffe commented on CASSANDRA-18058: - +1 Do we have a final test run? > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677990#comment-17677990 ] Caleb Rackliffe commented on CASSANDRA-18058: - I've only got one outstanding concern at this point: [https://github.com/maedhroz/cassandra/pull/6/files#r1072809299] Once we figure that out, I'll be able to approve... > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677475#comment-17677475 ] Mike Adamson commented on CASSANDRA-18058: -- [~maedhroz] [~adelapena] I have pushed to my branch again with the change requests up to the end of day. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676661#comment-17676661 ] Mike Adamson commented on CASSANDRA-18058: -- [~maedhroz] [~adelapena] I have completed my changes for both reviews, hopefully covering all requests. Please take another look and let me know if you want any further changes. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651675#comment-17651675 ] Mike Adamson commented on CASSANDRA-18058: -- [~maedhroz] Thanks for your review. I am away now for 2 weeks so will get on to this when I return. With regard to the deprecating IndexingQuerySupport. I have given this some serious thought but have the following reservations. IndexingQuerySupport uses a network session for queries in order to test limit and paging. This impacts performance and would make the large number of indexing type tests slower. I'm not sure of the impact of this but it is worth bearing in mind. This test framework has also highlighted a number of bugs that haven't shown up elsewhere. What might make sense would be to enhance IndexingTypeSupport to include any indexing variations (pk, ck, static), operations (ttl, deletions) and query variants that it doesn't already cover and restrict IndexingQuerySupport (probably renamed) to limit and paging. I would also be inclined to randomise this as well. I am very happy to do this but would prefer to leave it until we have the on-disk support added. This would give us a better idea of scope. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[
https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651421#comment-17651421
]
Caleb Rackliffe commented on CASSANDRA-18058:
-
[~mike_tr_adamson] [~adelapena] One thing we might want to resolve is whether
we think there's enough duplication between the {{IndexQuerySupport}}
(hand-crafted, covers stages of the write path, paging, fetch size, etc.) and
{{IndexingTypeSupport}} (randomized) frameworks that we can remove the former
entirely, or perhaps try to migrate enough to {{IndexingTypeSupport}} that we
can ditch {{IndexQuerySupport}}. They both try to cover all the relevant
indexable data types, and should be able to query data as it moves through the
write path from memory to disk, but they validate very differently. (IIRC, one
validates against equivalent filtering queries, while the other validates
against the randomly generated model.)
WDYT?
> In-memory index and query path
> --
>
> Key: CASSANDRA-18058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18058
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Fix For: 5.x
>
>
> An in-memory index using the in-memory trie structure introduced with
> CASSANDRA-17240 along with a query path implementation to perform index
> queries from the in-memory index.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651405#comment-17651405 ] Caleb Rackliffe commented on CASSANDRA-18058: - Just wrapped up my first pass at review and left a bunch of notes in the PR. 95% of the comments are pretty minor things, although there still might be some opportunities to trim bits that aren't tested yet (but I'm guessing would be once we get the on-disk formats in). I really appreciate the effort to break this down into something (more) manageable and reviewable ;) > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647566#comment-17647566 ] Mike Adamson commented on CASSANDRA-18058: -- [~adelapena] [~maedhroz] I have pushed 2 new commits to the PR. The first is a small refactoring around our use of the `com.carrotsearch.randomizedtesting` package following a discussion on the dev mailing list. The patch removes the use of the `RandomizedTest` base class in `SAIRandomizedTest` so all random testing in SAI now uses the `SAITester.Randomization` class for random data generation. The second commit removes the analyzers and filters from the code and leaves only the `NoOpAnalyzer`. The analyzers will now have their own ticket. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646267#comment-17646267 ] Caleb Rackliffe commented on CASSANDRA-18058: - [~adelapena] I'll start today or tomorrow, most likely. I've been wrapping up CASSANDRA-17719. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646255#comment-17646255 ] Andres de la Peña commented on CASSANDRA-18058: --- I have left a few additional minor suggestions, but overall the changes look good to me. Do we have CI results? [~maedhroz] will you have time to review? > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645303#comment-17645303 ] Andres de la Peña commented on CASSANDRA-18058: --- Great, thanks. I'll take a look in a bit. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645296#comment-17645296 ] Mike Adamson commented on CASSANDRA-18058: -- Thanks for your review. I have pushed a commit which I hope address all of your comments and suggestions. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643463#comment-17643463 ] Andres de la Peña commented on CASSANDRA-18058: --- I think I have finished my first round of review. I have left a bunch of suggestions on the PR, most things are quite minor. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641261#comment-17641261 ] Andres de la Peña commented on CASSANDRA-18058: --- Thanks, I'll take a look at the changes. I keep leaving batches of comments on the PR, I'll have completed the first review round very soon. So far it's looking good :) > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641240#comment-17641240 ] Mike Adamson commented on CASSANDRA-18058: -- [~adelapena] Please note that I have pushed a commit to help resolve some of the dtest failures. The SecondaryIndexManager was attempting to propagate index states when the Gossiper was not enabled. This resulted in exceptions being added to the logs which were being picked up as test failures. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640806#comment-17640806 ] Mike Adamson commented on CASSANDRA-18058: -- Sorry, I was not aware of the exact CI build job and hadn't run the eclipse_warnings. I have now addressed above issue as well and have a CI job running that has passed the JDK8 build phase. > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[
https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640749#comment-17640749
]
Andres de la Peña commented on CASSANDRA-18058:
---
Thanks for addressing the import issues. After that, there is another failure
on {{{}eclipse-warnings{}}}:
{code:java}
eclipse-warnings:
[mkdir] Created dir: /Users/adelapena/src/cassandra/trunk/build/ecj
[echo] Running Eclipse Code Analysis. Output logged to
/Users/adelapena/src/cassandra/trunk/build/ecj/eclipse_compiler_checks.txt
[java] --
[java] 1. ERROR in
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/index/sai/plan/StorageAttachedIndexSearcher.java
(at line 195)
[java] return iterator != null
[java]? iteratePartition(iterator)
[java]: endOfData();
[java]
^
[java] Potential resource leak: 'iterator' may not be closed at this
location
[java] --
[java] 1 problem (1 error)
{code}
Did you manage to build without problems or run CI? CI build job uses these Ant
targets:
{code:java}
ant clean realclean jar eclipse-warnings{code}
> In-memory index and query path
> --
>
> Key: CASSANDRA-18058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18058
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Fix For: 5.x
>
>
> An in-memory index using the in-memory trie structure introduced with
> CASSANDRA-17240 along with a query path implementation to perform index
> queries from the in-memory index.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639952#comment-17639952 ] Mike Adamson commented on CASSANDRA-18058: -- Apart from `StorageAttachedIndex` the rest of these classes are not touched by my patch. Is it appropriate for me to correct these on my patch? > In-memory index and query path > -- > > Key: CASSANDRA-18058 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18058 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.x > > > An in-memory index using the in-memory trie structure introduced with > CASSANDRA-17240 along with a query path implementation to perform index > queries from the in-memory index. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18058) In-memory index and query path
[
https://issues.apache.org/jira/browse/CASSANDRA-18058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638653#comment-17638653
]
Andres de la Peña commented on CASSANDRA-18058:
---
It seems that there is a build error due to {{checkstyle}} detecting some
unused imports:
{code:java}
checkstyle:
[mkdir] Created dir: /Users/adelapena/src/cassandra/trunk/build/checkstyle
[checkstyle] Running Checkstyle 8.40 on 2206 files
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/db/PartitionRangeReadCommand.java:51:8:
Unused import - org.apache.cassandra.schema.IndexMetadata. [UnusedImports]
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/db/TableWriteHandler.java:22:8:
Unused import - org.apache.cassandra.index.transactions.UpdateTransaction.
[UnusedImports]
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java:80:8:
Unused import - org.apache.cassandra.service.StorageService. [UnusedImports]
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/index/sasi/plan/SASIIndexSearcher.java:22:8:
Unused import - org.apache.cassandra.config.DatabaseDescriptor. [UnusedImports]
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/index/sasi/plan/SASIIndexSearcher.java:30:8:
Unused import - org.apache.cassandra.exceptions.RequestTimeoutException.
[UnusedImports]
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/index/sasi/plan/SASIIndexSearcher.java:35:15:
Unused import - java.util.concurrent.TimeUnit.MILLISECONDS. [UnusedImports]
[checkstyle] [ERROR]
/Users/adelapena/src/cassandra/trunk/src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:59:8:
Unused import - org.apache.cassandra.db.rows.SerializationHelper.
[UnusedImports]
{code}
That prevents us from running the patch on CI, that uses {{checkstyle}} on the
root build jobs.
> In-memory index and query path
> --
>
> Key: CASSANDRA-18058
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18058
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Fix For: 5.x
>
>
> An in-memory index using the in-memory trie structure introduced with
> CASSANDRA-17240 along with a query path implementation to perform index
> queries from the in-memory index.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
