[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815913#comment-13815913 ] Lyuben Todorov commented on CASSANDRA-4809: --- +1 from me. Looks good. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.3 > > Attachments: 4809-v5.txt, 4809.patch, 4809_v2.patch, 4809_v3.patch, > 4809_v4.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813120#comment-13813120 ] Jonathan Ellis commented on CASSANDRA-4809: --- v5 attached to encapsulate the to-replay logic and not require multiple passes for each mutation replayed. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.3 > > Attachments: 4809-v5.txt, 4809.patch, 4809_v2.patch, 4809_v3.patch, > 4809_v4.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800053#comment-13800053 ] Jonathan Ellis commented on CASSANDRA-4809: --- - Comment doesn't match code -- says "empty string array" but code is "array of empty string." I think there are existing examples of "provide ks+cf, otherwise default to everything." Suggest checking that out; the "" approach is a bit clunky. - Besides splitting the parameter, should trim leading + trailing spaces. Guarantee that will be a common form of user confusion otherwise. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch, 4809_v2.patch, 4809_v3.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789796#comment-13789796 ] Lyuben Todorov commented on CASSANDRA-4809: --- bq. I'm wondering why the keyspace checks have been moved inside of the loop They haven't, the while loop is for each of the supplied keyspace.columnfamily pairs we would want to restore (so we can restore more than 1 CF during the startup). The mutation loop is a bit further down. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch, 4809_v2.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788416#comment-13788416 ] Carl Yeksigian commented on CASSANDRA-4809: --- Sorry, missed the question before. Overall, the proposed updates to the patch look good (I had forgotten about the low quality of the first patch -- done during a meetup). I'm wondering why the keyspace checks have been moved inside of the loop, but the control flow is still a return. Seems like either we can check it once before the loop and exit the method, or we continue instead of return if we want to check each mutation. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch, 4809__v2.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788210#comment-13788210 ] Mike Bulman commented on CASSANDRA-4809: bq. and this does occur before thrift starts. Cool. Waiting for thrift to be available wfm bq. "List" approach is fine. +1 > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788199#comment-13788199 ] Jonathan Ellis commented on CASSANDRA-4809: --- The -D solution is a bit clunky but putting restore properties in the archive config file feels backwards too. And -D is maybe a bit less likely to be left enabled for multiple restarts by mistake, so let's go with that. "List" approach is fine. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788188#comment-13788188 ] Lyuben Todorov commented on CASSANDRA-4809: --- bq. is there a way to know that the restore is done? Once the replays complete you should get a message: *INFO 17:31:09,085 Log replay complete, 0 replayed mutations* As for the multiple kss/cfs we could do what we did in [4191|https://issues.apache.org/jira/browse/CASSANDRA-4191] where a list of ks.cf1 ks2.cf1 is supplied. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788157#comment-13788157 ] Mike Bulman commented on CASSANDRA-4809: Fwiw, it would be great if multiple keyspaces and/or column families could be specified. Requiring a restart of c* for each CF is.. tedious. If I wanted to restore multiple column families with the current patch, is there a way to know that the restore is done? (eg, once thrift is available?) > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[
https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788015#comment-13788015
]
Lyuben Todorov commented on CASSANDRA-4809:
---
The patch works as intended. To specify a particular ks/cf to be archived we
need to add parameters when starting cassandra.
{code}
./cassandra -Dcassandra.readKeyspaceCommitlog=exampleKS
-Dcassandra.readColumnFamilyCommitlog=exampleCF
{code}
Maybe it would be a better option to add restore_keyspace and
restore_columnfamily config options to commitlog_archiving.properties. If the
original setup is preferable I'll rebase the patch (it doesn't apply cleanly
because of other changes on the branch).
> Allow restoring specific column families from archived commitlog
>
>
> Key: CASSANDRA-4809
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4809
> Project: Cassandra
> Issue Type: Improvement
>Affects Versions: 1.2.0
>Reporter: Nick Bailey
>Assignee: Lyuben Todorov
> Labels: lhf
> Fix For: 2.0.2
>
> Attachments: 4809.patch
>
>
> Currently you can only restore the entire contents of a commit log archive.
> It would be useful to specify the keyspaces/column families you want to
> restore from an archived commitlog.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786504#comment-13786504 ] Jonathan Ellis commented on CASSANDRA-4809: --- Haven't heard back from Carl, I think you'd better go ahead and add that Lyuben. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Lyuben Todorov > Labels: lhf > Fix For: 2.0.2 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769380#comment-13769380 ] Lyuben Todorov commented on CASSANDRA-4809: --- [~carlyeks] Can you add a full example command please? > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Carl Yeksigian > Labels: lhf > Fix For: 2.0.1 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766317#comment-13766317 ] Jonathan Ellis commented on CASSANDRA-4809: --- [~lyubent], can you review? > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey >Assignee: Carl Yeksigian > Labels: lhf > Fix For: 2.0.1 > > Attachments: 4809.patch > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751743#comment-13751743 ] Greg DeAngelis commented on CASSANDRA-4809: --- Ok gotcha, I'll take the keyspaces and column families to replay as provided. > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey > Labels: lhf > Fix For: 2.0.1 > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751733#comment-13751733 ] Jonathan Ellis commented on CASSANDRA-4809: --- That doesn't sound like a great idea to me. What if there was a DROP KEYSPACE in there that you don't want replayed? > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey > Labels: lhf > Fix For: 2.0.1 > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4809) Allow restoring specific column families from archived commitlog
[ https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751695#comment-13751695 ] Greg DeAngelis commented on CASSANDRA-4809: --- Are there any special considerations for system tables? Should they always be replayed regardless of what the user specifies to replay? Should this should be available as a property in commitlog_archiving.properties and the restore jmx call? > Allow restoring specific column families from archived commitlog > > > Key: CASSANDRA-4809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4809 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Nick Bailey > Labels: lhf > Fix For: 2.0.1 > > > Currently you can only restore the entire contents of a commit log archive. > It would be useful to specify the keyspaces/column families you want to > restore from an archived commitlog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
