[jira] [Commented] (CASSANDRA-5403) Clean up ColumnFamily, ISortedColumns heirarchy
[ https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620374#comment-13620374 ] Carl Yeksigian commented on CASSANDRA-5403: --- LGTM; ship it :) For reference, merged in trunk and pushed to https://github.com/carlyeks/cassandra/tree/5403. Clean up ColumnFamily, ISortedColumns heirarchy --- Key: CASSANDRA-5403 URL: https://issues.apache.org/jira/browse/CASSANDRA-5403 Project: Cassandra Issue Type: Bug Reporter: Jonathan Ellis Assignee: Jonathan Ellis Fix For: 2.0 Attachments: Screen Shot 2013-04-01 at 12.00.09 PM.png CF wraps ISC but adds no real functionality of its own (post-supercolumn cleanup). This means that we're wasting allocations every time we create a CF/ISC pair when really one would do. Other things that would be nice to clean up: # We often create an empty CF as a placeholder that should not be modified, and rely on convention to avoid such modification. We could enforce this with a new CF/ISC subclass. # Many places still use TMBSC where ABSC would be adequate and cheaper # Other places still (ModificationStatement; others?) would be fine using a column container with no sorting requirement at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5403) Clean up ColumnFamily, ISortedColumns heirarchy
[ https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620387#comment-13620387 ] Jonathan Ellis commented on CASSANDRA-5403: --- Rebased + committed Clean up ColumnFamily, ISortedColumns heirarchy --- Key: CASSANDRA-5403 URL: https://issues.apache.org/jira/browse/CASSANDRA-5403 Project: Cassandra Issue Type: Bug Reporter: Jonathan Ellis Assignee: Jonathan Ellis Fix For: 2.0 Attachments: Screen Shot 2013-04-01 at 12.00.09 PM.png CF wraps ISC but adds no real functionality of its own (post-supercolumn cleanup). This means that we're wasting allocations every time we create a CF/ISC pair when really one would do. Other things that would be nice to clean up: # We often create an empty CF as a placeholder that should not be modified, and rely on convention to avoid such modification. We could enforce this with a new CF/ISC subclass. # Many places still use TMBSC where ABSC would be adequate and cheaper # Other places still (ModificationStatement; others?) would be fine using a column container with no sorting requirement at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5403) Clean up ColumnFamily, ISortedColumns heirarchy
[ https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618871#comment-13618871 ] Jonathan Ellis commented on CASSANDRA-5403: --- Rebased on top of trunk (post-5395-commit) and fixed some test errors: https://github.com/jbellis/cassandra/tree/5403-2 Clean up ColumnFamily, ISortedColumns heirarchy --- Key: CASSANDRA-5403 URL: https://issues.apache.org/jira/browse/CASSANDRA-5403 Project: Cassandra Issue Type: Bug Reporter: Jonathan Ellis Assignee: Jonathan Ellis Fix For: 2.0 CF wraps ISC but adds no real functionality of its own (post-supercolumn cleanup). This means that we're wasting allocations every time we create a CF/ISC pair when really one would do. Other things that would be nice to clean up: # We often create an empty CF as a placeholder that should not be modified, and rely on convention to avoid such modification. We could enforce this with a new CF/ISC subclass. # Many places still use TMBSC where ABSC would be adequate and cheaper # Other places still (ModificationStatement; others?) would be fine using a column container with no sorting requirement at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5403) Clean up ColumnFamily, ISortedColumns heirarchy
[ https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618906#comment-13618906 ] Jonathan Ellis commented on CASSANDRA-5403: --- According to YourKit, this takes the time in CF.addColumn from 50% of mutationsForKey to 10%. Clean up ColumnFamily, ISortedColumns heirarchy --- Key: CASSANDRA-5403 URL: https://issues.apache.org/jira/browse/CASSANDRA-5403 Project: Cassandra Issue Type: Bug Reporter: Jonathan Ellis Assignee: Jonathan Ellis Fix For: 2.0 CF wraps ISC but adds no real functionality of its own (post-supercolumn cleanup). This means that we're wasting allocations every time we create a CF/ISC pair when really one would do. Other things that would be nice to clean up: # We often create an empty CF as a placeholder that should not be modified, and rely on convention to avoid such modification. We could enforce this with a new CF/ISC subclass. # Many places still use TMBSC where ABSC would be adequate and cheaper # Other places still (ModificationStatement; others?) would be fine using a column container with no sorting requirement at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5403) Clean up ColumnFamily, ISortedColumns heirarchy
[ https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617483#comment-13617483 ] Jonathan Ellis commented on CASSANDRA-5403: --- Patchset pushed to https://github.com/jbellis/cassandra/tree/5403. (To save me rebase pain, it builds on the patches for CASSANDRA-5395, which are not yet committed, but you don't need to re-review those.) Clean up ColumnFamily, ISortedColumns heirarchy --- Key: CASSANDRA-5403 URL: https://issues.apache.org/jira/browse/CASSANDRA-5403 Project: Cassandra Issue Type: Bug Reporter: Jonathan Ellis Assignee: Jonathan Ellis CF wraps ISC but adds no real functionality of its own (post-supercolumn cleanup). This means that we're wasting allocations every time we create a CF/ISC pair when really one would do. Other things that would be nice to clean up: # We often create an empty CF as a placeholder that should not be modified, and rely on convention to avoid such modification. We could enforce this with a new CF/ISC subclass. # Many places still use TMBSC where ABSC would be adequate and cheaper # Other places still (ModificationStatement; others?) would be fine using a column container with no sorting requirement at all -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
