[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15553: Since Version: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/219d209651759cf702519a100c4f43595f7be8d7 Resolution: Fixed Status: Resolved (was: Ready to Commit) and committed, thanks! > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15553: -- Status: Ready to Commit (was: Changes Suggested) Blake and I both gave +1, so moving to ready to commit. > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15553: -- Reviewers: Blake Eggleston, David Capwell (was: Blake Eggleston) > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15553:
Status: Changes Suggested (was: Review In Progress)
looks good, I just have a few minor things:
* CassandraValidationIterator.java:61 - stray whitespace at top of class def
* LocalSessions$Listener - it would be nice to have a more descriptive method
name `onIncrementalStateChange` or something. We have at least a few listeners
with generic `onStateChange` methods
* RepairSession#stateChange - we should return after forcingShutdown.
Alternatively, we could use {{Iterables.any(ranges(), r ->
r.intersects(session.ranges)}} instead of iterating over the ranges.
* RepairSession#involvesTables - includesSSTables or containsSSTables might be
a better name
> Preview repair should include sstables from finalized incremental repair
> sessions
> -
>
> Key: CASSANDRA-15553
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15553
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> When running a preview repair we currently grab all repaired sstables,
> problem is that we depend on compaction to move the sstables from pending to
> repaired so we might have different data marked repaired on different nodes.
> Including any sstables from finalized incremental repair sessions as repaired
> will solve this.
> Another problem is that validations don't start at exactly the same time on
> different nodes, so if an incremental repair finishes while the preview
> repair is running we might also validate the wrong repaired set. We should
> fail the preview repair if an intersecting incremental repair finishes during
> the preview repair.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15553: Reviewers: Blake Eggleston, Blake Eggleston (was: Blake Eggleston) Blake Eggleston, Blake Eggleston (was: Blake Eggleston) Status: Review In Progress (was: Patch Available) > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15553: Test and Documentation Plan: new in-jvm dtests and cci runs Status: Patch Available (was: Open) [patch|https://github.com/krummas/cassandra/commits/marcuse/previewrepairfix], [cci|https://circleci.com/workflow-run/9ee445fb-8ac7-44e3-b74e-345734b312c3] Patch includes sstables from finalized sessions in the repaired set. Also adds a state change listener interface to `LocalSessions` which preview repair `RepairSession` listens to to fail any intersecting preview repairs. > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15553: Bug Category: Parent values: Correctness(12982)Level 1 values: Transient Incorrect Response(12987) Complexity: Low Hanging Fruit Discovered By: Adhoc Test Fix Version/s: 4.0-alpha Reviewers: Blake Eggleston Severity: Low Status: Open (was: Triage Needed) > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
