[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Fix Version/s: (was: 4.0-beta) (was: 3.11.x) (was: 3.0.x) (was: 2.2.x) 4.0-alpha 3.11.7 3.0.21 2.2.17 Source Control Link: https://github.com/apache/cassandra/commit/324267b3c0676ad31bd4f2fac0e2e673a9257a37 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed w/your version for trunk. > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15567: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell (was: David Capwell) Status: Review In Progress (was: Patch Available) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15567: -- Status: Ready to Commit (was: Review In Progress) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Status: In Progress (was: Changes Suggested) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Status: Patch Available (was: In Progress) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[
https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15567:
--
Status: Changes Suggested (was: Review In Progress)
Yep, confirmed our packaging puts this at the end:
https://github.com/apache/cassandra/blob/trunk/redhat/cassandra.in.sh#L22.
Also finished testing on trunk (sorry, got distracted)
{code}
git pull --rebase upstream trunk
curl
https://github.com/apache/cassandra/compare/trunk...driftx:CASSANDRA-15567.diff
| patch -p1
patch -p1 < debian/patches/cassandra_in.sh_dirs.diff
{code}
This then produced the following
{code}
...
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
for jar in "$CASSANDRA_HOME"/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
done
# Include EXTRA_CLASSPATH from /etc/default/cassandra
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
...
{code}
That could cause a problem, so can we update the diff so we don't double add
the EXTRA_CLASSPATH? Looks like redhat forks the file so only need to worry
about this with Debian?
[~brandon.williams] if you move to the end of the class path and update debian
then i'm +1
> Allow EXTRA_CLASSPATH to work in tarball/source installations
> -
>
> Key: CASSANDRA-15567
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15567
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Scripts
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Both the debian and redhat packaging modify cassandra.in.sh to support the
> EXTRA_CLASSPATH variable. It would be nice to just put this in
> cassandra.in.sh proper so people without a package installation can use it as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15567: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell Status: Review In Progress (was: Patch Available) marking myself as reviewer so I pick this up tomorrow. I looked at the patch (its so so big!); looks fine so will mostly just test. > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Test and Documentation Plan: none Status: Patch Available (was: Open) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Change Category: Operability Complexity: Normal Component/s: Local/Scripts Fix Version/s: 4.0-beta 3.11.x 3.0.x 2.2.x Status: Open (was: Triage Needed) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
