[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17194:
--
Fix Version/s: 5.0
(was: 5.x)
Source Control Link:
https://github.com/apache/cassandra/commit/b72da02611b62436100fa3fd66537c68461bcaf5
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-17194:
Status: Ready to Commit (was: Review In Progress)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-17194:
Reviewers: Berenguer Blasi, Maxwell Guo (was: Maxwell Guo)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-17194:
Test and Documentation Plan: ut
Status: Patch Available (was: In Progress)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-17194:
Status: Review In Progress (was: Patch Available)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17194:
--
Description:
Migrate the existing thresholds for compaction:
{code:java}
compaction_large_partition_warning_threshold_mb: 100
compaction_tombstone_warning_threshold: 10
{code}
To a new set of guardrails under the {{guardrails}} section, for example:
{code:java}
partition_size_warn_threshold: 50MiB
partition_size_fail_threshold: 100MiB
partition_tombstones_fail_threshold: 5
partition_tombstones_fail_threshold: 10
{code}
Note that since these guardrails would be attached to a background process
there wouldn't be abort/fail thresholds because we don't want to stop
compaction.
At the moment these thresholds are enabled by default, while guardrails are
globally disabled by default, so we should consider whether we want to globally
enable guardrails, or change these thresholds to disabled by default, or don't
migrate the thresholds.
was:
Migrate the existing thresholds for compaction:
{code:java}
compaction_large_partition_warning_threshold_mb: 100
compaction_tombstone_warning_threshold: 10
{code}
To a new guardrail under the {{guardrails}} section, for example:
{code:java}
guardrails:
...
compacted_partition_size_warn_threshold_mb: 100
compacted_partition_tombstone_warn_threshold: 10
{code}
Or maybe:
{code:java}
guardrails:
...
compacted_partition_size:
warn_threshold_mb: 100
compacted_partition_tombstones:
warn_threshold: 10
{code}
Note that since these guardrails would be attached to a background process
there wouldn't be abort/fail thresholds because we don't want to stop
compaction.
At the moment these thresholds are enabled by default, while guardrails are
globally disabled by default, so we should consider whether we want to globally
enable guardrails, or change these thresholds to disabled by default, or don't
migrate the thresholds.
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-17194:
Reviewers: Maxwell Guo
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new guardrail under the {{guardrails}} section, for example:
> {code:java}
> guardrails:
> ...
> compacted_partition_size_warn_threshold_mb: 100
> compacted_partition_tombstone_warn_threshold: 10
> {code}
> Or maybe:
> {code:java}
> guardrails:
> ...
> compacted_partition_size:
> warn_threshold_mb: 100
> compacted_partition_tombstones:
> warn_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17194:
--
Change Category: Operability
Complexity: Normal
Fix Version/s: 5.x
Status: Open (was: Triage Needed)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new guardrail under the {{guardrails}} section, for example:
> {code:java}
> guardrails:
> ...
> compacted_partition_size_warn_threshold_mb: 100
> compacted_partition_tombstone_warn_threshold: 10
> {code}
> Or maybe:
> {code:java}
> guardrails:
> ...
> compacted_partition_size:
> warn_threshold_mb: 100
> compacted_partition_tombstones:
> warn_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17194:
--
Description:
Migrate the existing thresholds for compaction:
{code:java}
compaction_large_partition_warning_threshold_mb: 100
compaction_tombstone_warning_threshold: 10
{code}
To a new guardrail under the {{guardrails}} section, for example:
{code:java}
guardrails:
...
compacted_partition_size_warn_threshold_mb: 100
compacted_partition_tombstone_warn_threshold: 10
{code}
Or maybe:
{code:java}
guardrails:
...
compacted_partition_size:
warn_threshold_mb: 100
compacted_partition_tombstones:
warn_threshold: 10
{code}
Note that since these guardrails would be attached to a background process
there wouldn't be abort/fail thresholds because we don't want to stop
compaction.
At the moment these thresholds are enabled by default, while guardrails are
globally disabled by default, so we should consider whether we want to globally
enable guardrails, or change these thresholds to disabled by default, or don't
migrate the thresholds.
was:
Migrate the existing thresholds for replica filtering protection:
{code:java}
compaction_large_partition_warning_threshold_mb: 100
compaction_tombstone_warning_threshold: 10
{code}
To a new guardrail under the {{guardrails}} section, for example:
{code:java}
guardrails:
...
compacted_partition_size_warn_threshold_mb: 100
compacted_partition_tombstone_warn_threshold: 10
{code}
Or maybe:
{code:java}
guardrails:
...
compacted_partition_size:
warn_threshold_mb: 100
compacted_partition_tombstones:
warn_threshold: 10
{code}
Note that since these guardrails would be attached to a background process
there wouldn't be abort/fail thresholds because we don't want to stop
compaction.
At the moment these thresholds are enabled by default, while guardrails are
globally disabled by default, so we should consider whether we want to globally
enable guardrails, or change these thresholds to disabled by default, or don't
migrate the thresholds.
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Priority: Normal
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new guardrail under the {{guardrails}} section, for example:
> {code:java}
> guardrails:
> ...
> compacted_partition_size_warn_threshold_mb: 100
> compacted_partition_tombstone_warn_threshold: 10
> {code}
> Or maybe:
> {code:java}
> guardrails:
> ...
> compacted_partition_size:
> warn_threshold_mb: 100
> compacted_partition_tombstones:
> warn_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
