[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335701011 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335700916 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrunalinikankariya commented on issue #2270: CLOUDSTACK-10085 : Upload volume from local fails when global config max.account.seconday.storage is set to -1
mrunalinikankariya commented on issue #2270: CLOUDSTACK-10085 : Upload volume from local fails when global config max.account.seconday.storage is set to -1 URL: https://github.com/apache/cloudstack/pull/2270#issuecomment-335691331 Code LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335689864 @rafaelweingartner thanks, good to see you reviewing. The issue is that during starting of a VM, we used hard coded nic unit numbers that caused the backend (vcenter side) to fail sometimes (well most the times, when number of nics > 7). I looked at the docs, and the unit number is not a mandatory attribute to use when adding new (nic) devices, which is the fix for the bug. In the specific method, we're still passing `deviceNumber` to be used as key when plugging in a dvswitch `nic` device, I removed the `setKey(30)` as `setKey` is again called, its usage is redundant and unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335687088 Looks like some trillian env issue, I'll rekick tests shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335682274 Packaging result: ?centos6 ?centos7 ?debian. JID-1148 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335670078 Trillian test result (tid-1575) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 7 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2288-t1575-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py Intermitten failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 40 look OK, 22 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 166.80 | test_vpc_vpn.py test_02_VPC_default_routes | `Failure` | 182.40 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | `Failure` | 212.76 | test_vpc_router_nics.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 546.81 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 520.04 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 595.19 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 328.59 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 363.83 | test_privategw_acl.py ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py test_change_service_offering_for_vm_with_snapshots | `Error` | 196.54 | test_vm_snapshots.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 383.84 | test_vm_snapshots.py ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestTemplates>:setup | `Error` | 0.00 | test_templates.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 182.32 | test_service_offerings.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 176.47 | test_routers_network_ops.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 171.44 | test_routers_network_ops.py test_02_routervm_iptables_policies | `Error` | 206.72 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 196.90 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 222.21 | test_routers_iptables_default_policy.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_04_rvpc_privategw_static_routes | `Error` | 605.47 | test_privategw_acl.py test_03_vpc_private
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335678948 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335678880 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on a change in pull request #2288: CLOUDSTACK-10107: For VMware
VMs add devices without unit number
URL: https://github.com/apache/cloudstack/pull/2288#discussion_r143916379
##
File path: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##
@@ -210,16 +208,13 @@ public static VirtualDevice
prepareDvNicDevice(VirtualMachineMO vmMo, ManagedObj
dvPortConnection.setPortgroupKey(morNetwork.getValue());
dvPortBacking.setPort(dvPortConnection);
nic.setBacking(dvPortBacking);
-nic.setKey(30);
connectInfo.setAllowGuestControl(true);
-connectInfo.setConnected(conntected);
+connectInfo.setConnected(connected);
connectInfo.setStartConnected(connectOnStart);
nic.setAddressType("Manual");
nic.setConnectable(connectInfo);
nic.setMacAddress(macAddress);
-
-nic.setUnitNumber(deviceNumber);
nic.setKey(-contextNumber);
Review comment:
@rafaelweingartner when I was trying to fix the bug, I thought too why we're
using negative values however, I could not find a reason. For backward
compatibilities sake and to reduce our test scopes, I chose to keep it that
way. IMO it's not a problem as long as the key is unique, being
negative/positive is not a problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335687088 Looks like some trillian env issue, I'll rekick tests shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335682274 Packaging result: ?centos6 ?centos7 ?debian. JID-1148 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations
blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-335680849 Trillian test result (tid-1572) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 70131 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2181-t1572-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 50 look OK, 13 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_07_resize_fail | `Failure` | 15.33 | test_volumes.py test_10_attachAndDetach_iso | `Failure` | 1513.09 | test_vm_life_cycle.py test_03_ssvm_internals | `Failure` | 3.60 | test_ssvm.py test_01_sys_vm_start | `Failure` | 0.06 | test_secondary_storage.py test_04_rvpc_privategw_static_routes | `Failure` | 785.50 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 397.02 | test_privategw_acl.py test_01_create_iso | `Failure` | 1514.68 | test_iso.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py test_06_download_detached_volume | `Error` | 20.29 | test_volumes.py test_08_migrate_vm | `Error` | 30.83 | test_vm_life_cycle.py test_04_extract_template | `Error` | 5.08 | test_templates.py test_03_delete_template | `Error` | 5.08 | test_templates.py test_01_create_template | `Error` | 80.64 | test_templates.py test_10_destroy_cpvm | `Error` | 5.16 | test_ssvm.py test_09_destroy_ssvm | `Error` | 5.16 | test_ssvm.py test_07_reboot_ssvm | `Error` | 305.58 | test_ssvm.py test_06_stop_cpvm | `Error` | 5.17 | test_ssvm.py test_05_stop_ssvm | `Error` | 5.19 | test_ssvm.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1845.55 | test_routers_network_ops.py ContextSuite context=TestISO>:setup | `Error` | 3035.35 | test_iso.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py test_05_add_annotation_for_invvalid_entityType | `Error` | 0.08 | test_host_annotations.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.01 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.14 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_list_ha_for_host_valid | Skipped | 0.04 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.05 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.04 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.04 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.06 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simula
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335678880 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335678948 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335670078 Trillian test result (tid-1575) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 7 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2288-t1575-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py Intermitten failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 40 look OK, 22 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 166.80 | test_vpc_vpn.py test_02_VPC_default_routes | `Failure` | 182.40 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | `Failure` | 212.76 | test_vpc_router_nics.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 546.81 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 520.04 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 595.19 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 328.59 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 363.83 | test_privategw_acl.py ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py test_change_service_offering_for_vm_with_snapshots | `Error` | 196.54 | test_vm_snapshots.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 383.84 | test_vm_snapshots.py ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestTemplates>:setup | `Error` | 0.00 | test_templates.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 182.32 | test_service_offerings.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 176.47 | test_routers_network_ops.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 171.44 | test_routers_network_ops.py test_02_routervm_iptables_policies | `Error` | 206.72 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 196.90 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 222.21 | test_routers_iptables_default_policy.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_04_rvpc_privategw_static_routes | `Error` | 605.47 | test_privategw_acl.py test_03_vpc_private
[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot
mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot URL: https://github.com/apache/cloudstack/pull/2081#issuecomment-335646633 Update: I can create a Basic Zone (using XenServer) with the 4.10.0.0 tag (9d2893d). It seems a problem has been introduced into master. I can e-mail the list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-335646586 Trillian test result (tid-1574) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53817 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2048-t1574-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 56 look OK, 6 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 75.72 | test_vpc_vpn.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 304.28 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 726.69 | test_privategw_acl.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1768.84 | test_routers_network_ops.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 78.84 | test_deploy_virtio_scsi_vm.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.01 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.06 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.03 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.02 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data
blueorangutan commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-335633303 Trillian test result (tid-1571) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56236 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2208-t1571-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 54 look OK, 8 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 81.11 | test_vpc_vpn.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 273.20 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 1073.73 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 245.41 | test_privategw_acl.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1863.90 | test_routers_network_ops.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py test_deploy_vm_from_iso | `Error` | 1515.26 | test_deploy_vm_iso.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 141.27 | test_affinity_groups_projects.py test_DeployVmAntiAffinityGroup | `Error` | 70.73 | test_affinity_groups.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.04 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.09 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.04 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.03 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.03 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.04 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.04 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.04 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot
mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot URL: https://github.com/apache/cloudstack/pull/2081#issuecomment-335600819 I tried again with the code from this PR and arrived at the same error. I then tried with master (specifically f1c01a5) and got the same error message. I wonder if somewhere along the line we have caused a problem on master with the creation of a basic zone? I don't see any networking issues on my side. I'm still investigating. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance
blueorangutan commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve performance URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-335599198 Trillian test result (tid-1567) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53827 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2282-t1567-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 56 look OK, 6 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 85.76 | test_vpc_vpn.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 514.08 | test_vpc_redundant.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 424.28 | test_routers_network_ops.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 290.66 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 646.37 | test_privategw_acl.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.01 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.07 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.02 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2189: CLOUDSTACK-10006: Internal DRS-like load balancing implementation for Vmware
rafaelweingartner commented on issue #2189: CLOUDSTACK-10006: Internal DRS-like load balancing implementation for Vmware URL: https://github.com/apache/cloudstack/pull/2189#issuecomment-335586546 @nvazquez some pieces of this code are a little familiar to me :) It is great your initiative, and from what I looked into the code of this PR, the ?management model? used here is similar to the one we have in our beta version of Autonomiccs [1], which was developed as a plugin for ACS. As I told you when you tested that solution for Autodesk, it does not scale well? So, we have a dataset [2] that we use to compare our management models, and we have compared this simple solution with a more comprehensive model that we developed a while ago. It turns out that this simple management approach can bring quite some problems in dynamic production environments. In some condition it will be worse than if you were not using anything at all. The dataset and the simulation tool to check the results are public [2], so anyone can check the results ;) The blue bar is one of our management models that was presented at IEEE SERVICES conference in the beginning of this year; the red line is the simple management model we made available at [1], which is similar to the one being introduced here; the yellow line is the unbalance of the cloud environment if one does not use anything at all (relying only on the allocation algorithm, the first fit was used), This figure presents the unbalance of RAM through out time in the dataset.  This figure presents the unbalance of CPU through out time in the dataset  The blue bar, which is one of our management models perform way better because it is a multi-dimensional management model. The message I want to send here is the following: use this solution on your cloud production environment with caution. [1] https://github.com/Autonomiccs/autonomiccs-platform [2] https://github.com/Autonomiccs/cloud-traces This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2189: CLOUDSTACK-10006: Internal DRS-like load balancing implementation for Vmware
rafaelweingartner commented on issue #2189: CLOUDSTACK-10006: Internal DRS-like load balancing implementation for Vmware URL: https://github.com/apache/cloudstack/pull/2189#issuecomment-335586546 @nvazquez some pieces of this code are a little familiar to me :) It is great your initiative, and from what I looked into the code of this PR, the ?management model? used here is similar to the one we have in our beta version of Autonomiccs [1], which was developed as a plugin for ACS. As I told you when you tested that solution for Autodesk, it does not scale well? So, we have a dataset [2] that we use to compare our management models, and we have compared this simple solution with a more comprehensive model that we developed a while ago. It turns out that this simple management approach can bring quite some problems in dynamic production environments. In some condition it will be worse than if you were not using anything at all. The dataset and the simulation tool to check the results are public [2], so anyone can check the results ;) The blue bar is one of our management models that was presented at IEEE SERVICES conference in the beginning of this year; the red line is the simple management model we made available at [1], which is similar to the one being introduced here; the yellow line is the unbalance of the cloud environment if one does not use anything at all (relying only on the allocation algorithm, the first fit was used), This figure presents the unbalance of RAM through out time in the dataset.  This figure presents the unbalance of CPU through out time in the dataset  The blue bar, which is one of our management models perform way better because it is a multi-dimensional management model. The message I want to send here is the following: use this solution on your cloud production environment with caution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.
blueorangutan commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings. URL: https://github.com/apache/cloudstack/pull/2250#issuecomment-335584723 Trillian test result (tid-1568) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50271 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2250-t1568-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 56 look OK, 6 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | `Failure` | 165.14 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | `Failure` | 56.16 | test_vpc_vpn.py test_router_dhcphosts | `Failure` | 104.43 | test_router_dhcphosts.py test_04_rvpc_privategw_static_routes | `Failure` | 654.88 | test_privategw_acl.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1848.34 | test_routers_network_ops.py ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 144.90 | test_router_dhcphosts.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.10 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.04 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.04 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.03 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.03 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.03 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.04 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.03 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.04 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.03 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2283: WIP CLOUDSTACK-10105: Maven standard
rafaelweingartner commented on issue #2283: WIP CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-335574676 @marcaurele I think it is good idea to squash into a single commit before merging (if we move this PR forward) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-335572278 Trillian test result (tid-1570) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41481 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2246-t1570-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 60 look OK, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 50.88 | test_vpc_vpn.py test_04_rvpc_privategw_static_routes | `Failure` | 568.65 | test_privategw_acl.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.03 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.04 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.09 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.03 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.03 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.04 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.04 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.04 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner opened a new pull request #2291: Fix validation for parameter "vm.password.length"
rafaelweingartner opened a new pull request #2291: Fix validation for parameter "vm.password.length" URL: https://github.com/apache/cloudstack/pull/2291 The description of the parameter was saying that the parameter has to be bigger than 6, however, in the code we were only accepting values bigger than 10. This PR changes the validation method to accept any number >= 6. We also change other inconsistencies in error messages presented to users. in near by validations This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9899 Url validation disabling (#2074)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 7ca5b53 CLOUDSTACK-9899 Url validation disabling (#2074)
7ca5b53 is described below
commit 7ca5b535a4a0ed573d9df60d28c95830fe13c119
Author: dahn
AuthorDate: Tue Oct 10 19:56:00 2017 +0200
CLOUDSTACK-9899 Url validation disabling (#2074)
* CLOUDSTACK-9899 adding a global setting for not checking URLs from the MS
* CLOUDSTACK-9899 refactor HttpTemplateDownloader contructor cleanup
* CLOUDSTACK-9899 refactor HttpTemplateDownloader.download() cleanup
* CLOUDSTACK-9899 add the new config key to configurable
* CLOUDSTACK-9899 refactor download method
* CLOUDSTACK-9899 less verbose setting comment
* CLOUDSTACK-9899 debug message to indicate checking happened
* CLOUDSTACK-9899 typi flase -> false
---
.../storage/template/HttpTemplateDownloader.java | 424 +
.../engine/orchestration/VolumeOrchestrator.java | 6 +-
.../com/cloud/storage/VolumeApiServiceImpl.java| 10 +-
3 files changed, 268 insertions(+), 172 deletions(-)
diff --git a/core/src/com/cloud/storage/template/HttpTemplateDownloader.java
b/core/src/com/cloud/storage/template/HttpTemplateDownloader.java
index bdf4990..d3c23a1 100644
--- a/core/src/com/cloud/storage/template/HttpTemplateDownloader.java
+++ b/core/src/com/cloud/storage/template/HttpTemplateDownloader.java
@@ -62,7 +62,7 @@ public class HttpTemplateDownloader extends
ManagedContextRunnable implements Te
private static final int CHUNK_SIZE = 1024 * 1024; //1M
private String downloadUrl;
private String toFile;
-public TemplateDownloader.Status status =
TemplateDownloader.Status.NOT_STARTED;
+public TemplateDownloader.Status status;
public String errorString = " ";
private long remoteSize = 0;
public long downloadTime = 0;
@@ -83,41 +83,38 @@ public class HttpTemplateDownloader extends
ManagedContextRunnable implements Te
String user, String password, Proxy proxy, ResourceType
resourceType) {
_storage = storageLayer;
this.downloadUrl = downloadUrl;
-setToDir(toDir);
-status = TemplateDownloader.Status.NOT_STARTED;
+this.toDir = toDir;
this.resourceType = resourceType;
this.maxTemplateSizeInBytes = maxTemplateSizeInBytes;
+completionCallback = callback;
+status = TemplateDownloader.Status.NOT_STARTED;
totalBytes = 0;
client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+try {
+request = createRequest(downloadUrl);
+checkTemporaryDestination(toDir);
+checkProxy(proxy);
+checkCredentials(user, password);
+} catch (Exception ex) {
+errorString = "Unable to start download -- check url? ";
+status = TemplateDownloader.Status.UNRECOVERABLE_ERROR;
+s_logger.warn("Exception in constructor -- " + ex.toString());
+} catch (Throwable th) {
+s_logger.warn("throwable caught ", th);
+}
+}
-myretryhandler = new HttpMethodRetryHandler() {
-@Override
-public boolean retryMethod(final HttpMethod method, final
IOException exception, int executionCount) {
-if (executionCount >= 2) {
-// Do not retry if over max retry count
-return false;
-}
-if (exception instanceof NoHttpResponseException) {
-// Retry if the server dropped connection on us
-return true;
-}
-if (!method.isRequestSent()) {
-// Retry if the request has not been sent fully or
-// if it's OK to retry methods that have been sent
-return true;
-}
-// otherwise do not retry
-return false;
-}
-};
+private GetMethod createRequest(String downloadUrl) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER,
myretryhandler);
+request.setFollowRedirects(true);
+return request;
+}
+private void checkTemporaryDestination(String toDir) {
try {
-request = new GetMethod(downloadUrl);
-request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER,
myretryhandler);
-completionCallback = callback;
-this.request.setFollowRedirects(true);
-
File f = File.createTempFile("dnld", "tmp_", new File(toDir));
if (_storage != null) {
@@ -125,15 +122,16 @@ public class HttpTemplateDownloader
[GitHub] DaanHoogland closed pull request #2074: CLOUDSTACK-9899 Url validation disabling
DaanHoogland closed pull request #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland closed pull request #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
DaanHoogland closed pull request #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-8308 automation test for Delta Snapshot
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 5636c9b CLOUDSTACK-8308 automation test for Delta Snapshot 5636c9b is described below commit 5636c9bcae7aa020006b605599aafd69f747f69a Author: Daan Hoogland AuthorDate: Mon Apr 24 11:35:10 2017 +0200 CLOUDSTACK-8308 automation test for Delta Snapshot --- .../testpaths/testpath_delta_snapshots.py | 540 + tools/marvin/marvin/codes.py | 1 + 2 files changed, 541 insertions(+) diff --git a/test/integration/testpaths/testpath_delta_snapshots.py b/test/integration/testpaths/testpath_delta_snapshots.py new file mode 100644 index 000..cb8461b --- /dev/null +++ b/test/integration/testpaths/testpath_delta_snapshots.py @@ -0,0 +1,540 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" Test cases for Delta Snapshots Test Path +""" + +from nose.plugins.attrib import attr +from marvin.cloudstackTestCase import cloudstackTestCase +from marvin.lib.utils import (cleanup_resources, + validateList, + is_snapshot_on_nfs) +from marvin.lib.base import (Account, + ServiceOffering, + Template, + VirtualMachine, + Volume, + Configurations, + Snapshot + ) +from marvin.lib.common import (get_domain, + get_zone, + get_template, + list_volumes, + createChecksum, + compareChecksum + ) +from marvin.sshClient import SshClient +from marvin.codes import (PASS, FAIL, BACKED_UP, ROOT, DATA) +import time + + +def checkIntegrityOfSnapshot( +self, snapshotsToRestore, checksumToCompare, disk_type=ROOT): +""" +Check integrity of snapshot created of ROOT or DATA Disk: + +If ROOT Disk: Deploy a Vm from a template created from the snapshot + and checking the contents of the ROOT disk. +If DATA Disk: Users can create a volume from the snapshot. + The volume can then be mounted to a VM and files + recovered as needed. + +Inputs: +1. snapshotsToRestore: Snapshots whose integrity is + to be checked. + +2. checksumToCompare: The contents of ROOT Disk to be compared. + +3. disk_type: The type of disk - ROOT or DATA Disk + of which snapshot was created. + +""" +if disk_type == ROOT: +# Create template from snapshot +template_from_snapshot = Template.create_from_snapshot( +self.apiclient, +snapshotsToRestore, +self.testdata["template_2"]) + +self.assertNotEqual( +template_from_snapshot, +None, +"Check if result exists in list item call" +) + +# Deploy VM +vm_from_temp = VirtualMachine.create( +self.apiclient, +self.testdata["small"], +templateid=template_from_snapshot.id, +accountid=self.account.name, +domainid=self.account.domainid, +serviceofferingid=self.service_offering.id, +zoneid=self.zone.id, +mode=self.zone.networktype +) + +self.assertNotEqual( +vm_from_temp, +None, +"Check if result exists in list item call" +) + +# Verify contents of ROOT disk match with snapshot + +compareChecksum( +self.apiclient, +service=self.testdata, +original_checksum=checksumToCompare, +disk_type="rootdiskdevice", +virt_machine=vm_from_temp +) + +vm_from_temp.delete(self.apiclient) +template_from_snapshot.delete(self.apiclient) +else: +volumeFormSnap
[GitHub] DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-296619771 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-298736574 Trillian test result (tid-1052) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37332 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2061-t1052-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Test completed. 49 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 522.30 | test_privategw_acl.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_01_vpc_site2site_vpn | Success | 221.18 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 86.26 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 326.18 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 284.72 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 678.81 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 559.15 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1366.76 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 663.19 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 813.01 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1443.08 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.50 | test_volumes.py test_08_resize_volume | Success | 156.43 | test_volumes.py test_07_resize_fail | Success | 161.47 | test_volumes.py test_06_download_detached_volume | Success | 156.29 | test_volumes.py test_05_detach_volume | Success | 150.69 | test_volumes.py test_04_delete_attached_volume | Success | 151.27 | test_volumes.py test_03_download_attached_volume | Success | 156.28 | test_volumes.py test_02_attach_volume | Success | 91.46 | test_volumes.py test_01_create_volume | Success | 713.64 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.17 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 126.57 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 179.30 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 373.35 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.97 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 35.91 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.86 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.83 | test_vm_life_cycle.py test_02_start_vm | Success | 10.19 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 231.84 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.21 | test_templates.py test_03_delete_template | Success | 5.15 | test_templates.py test_02_edit_template | Success | 90.16 | test_templates.py test_01_create_template | Success | 151.10 | test_templates.py test_10_destroy_cpvm | Success | 161.78 | test_ssvm.py test_09_destroy_ssvm | Success | 194.00 | test_ssvm.py test_08_reboot_cpvm | Success | 131.66 | test_ssvm.py test_07_reboot_ssvm | Success | 133.75 | test_ssvm.py test_06_stop_cpvm | Success | 166.99 | test_ssvm.py test_05_stop_ssvm | Success | 200.30 | test_ssvm.py test_04_cpvm_internals | Success | 1.68 | test_ssvm.py test_03_ssvm_internals | Success | 4.45 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py test_02_list_snapshots_with_removed_data_store | Success | 87.40 | test_snapshots.py test_01_snapshot_root_disk | Success | 16.24 | test_snapshots.py test_04_change_offering_small | Success | 239.76 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-296619887 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-298567456 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-298567810 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
blueorangutan commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-296625927 Packaging result: ?centos6 ?centos7 ?debian. JID-673 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)
blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-335550423 Trillian test result (tid-1573) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29725 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2281-t1573-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 41 look OK, 21 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | `Failure` | 15.40 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | `Failure` | 5.22 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Failure` | 10.65 | test_vpc_vpn.py test_04_rvpc_privategw_static_routes | `Failure` | 10.95 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 10.92 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 10.94 | test_privategw_acl.py test_01_vpc_privategw_acl | `Failure` | 11.02 | test_privategw_acl.py test_02_port_fwd_on_non_src_nat | `Failure` | 737.91 | test_network.py test_02_VPC_default_routes | `Error` | 10.96 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | `Error` | 10.94 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | `Error` | 10.96 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 10.99 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 5.93 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 10.96 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 15.97 | test_vpc_redundant.py ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 6.03 | test_vm_snapshots.py ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py ContextSuite context=TestTemplates>:setup | `Error` | 0.00 | test_templates.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 6.24 | test_service_offerings.py test_03_RVR_Network_check_router_state | `Error` | 0.28 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 5.44 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 0.27 | test_routers_network_ops.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 5.46 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 0.27 | test_routers_network_ops.py test_02_routervm_iptables_policies | `Error` | 5.32 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.28 | test_routers_iptables_default_policy.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | te
[GitHub] blueorangutan commented on issue #2257: CLOUDSTACK-10060:ListUsage API always displays the Virtual size as '0' for Usage type=9 (snapshot)
blueorangutan commented on issue #2257: CLOUDSTACK-10060:ListUsage API always displays the Virtual size as '0' for Usage type=9 (snapshot) URL: https://github.com/apache/cloudstack/pull/2257#issuecomment-335536892 Trillian test result (tid-1566) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40630 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2257-t1566-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 59 look OK, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 55.96 | test_vpc_vpn.py test_05_rvpc_multi_tiers | `Failure` | 255.88 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 358.66 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 356.21 | test_privategw_acl.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.11 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.02 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2290: WIP: add track id to async api calls
blueorangutan commented on issue #2290: WIP: add track id to async api calls URL: https://github.com/apache/cloudstack/pull/2290#issuecomment-335492525 Packaging result: ?centos6 ?centos7 ?debian. JID-1147 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2290: WIP: add track id to async api calls
DaanHoogland commented on a change in pull request #2290: WIP: add track id to
async api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r143742836
##
File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##
@@ -333,6 +333,7 @@ public boolean getStartVm() {
} catch (NumberFormatException e) {
throw new InvalidParameterValueException("Unable to
translate and find entity with networkId: " + ips.get("networkid"));
}
+// so no network found but a valid number as network id;
are we assuming exceptions thrown or lucky guessing?
Review comment:
I don't know yet, maybe an uncaught CloudRuntimeException is thrown
somewhere else, but you are right, we can throw it here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2290: WIP: add track id to async api calls
rafaelweingartner commented on a change in pull request #2290: WIP: add track
id to async api calls
URL: https://github.com/apache/cloudstack/pull/2290#discussion_r143740407
##
File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##
@@ -333,6 +333,7 @@ public boolean getStartVm() {
} catch (NumberFormatException e) {
throw new InvalidParameterValueException("Unable to
translate and find entity with networkId: " + ips.get("networkid"));
}
+// so no network found but a valid number as network id;
are we assuming exceptions thrown or lucky guessing?
Review comment:
@DaanHoogland so you are the one that makes the enlightened comments all
around ACS code base?! ahahaha
If the network ID is invalid (it was not found), it means that something
else further down the deployment process will break, right? If this is the
case, I think we could stop the processing here and throw a runtime exception.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2290: WIP: add track id to async api calls
blueorangutan commented on issue #2290: WIP: add track id to async api calls URL: https://github.com/apache/cloudstack/pull/2290#issuecomment-335484490 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2290: WIP: add track id to async api calls
DaanHoogland commented on issue #2290: WIP: add track id to async api calls URL: https://github.com/apache/cloudstack/pull/2290#issuecomment-335484114 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack
rafaelweingartner commented on a change in pull request #2284:
CLOUDSTACK-10103: Cloudian Connector for CloudStack
URL: https://github.com/apache/cloudstack/pull/2284#discussion_r143734478
##
File path:
plugins/integrations/cloudian/src/org/apache/cloudstack/cloudian/client/CloudianClient.java
##
@@ -0,0 +1,349 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.cloudian.client;
+
+import java.io.IOException;
+import java.net.SocketTimeoutException;
+import java.security.KeyManagementException;
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.X509TrustManager;
+
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.utils.security.SSLUtils;
+import org.apache.http.HttpHost;
+import org.apache.http.HttpResponse;
+import org.apache.http.HttpStatus;
+import org.apache.http.auth.AuthScope;
+import org.apache.http.auth.Credentials;
+import org.apache.http.auth.UsernamePasswordCredentials;
+import org.apache.http.client.AuthCache;
+import org.apache.http.client.CredentialsProvider;
+import org.apache.http.client.HttpClient;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.HttpDelete;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.client.methods.HttpPut;
+import org.apache.http.client.protocol.HttpClientContext;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.auth.BasicScheme;
+import org.apache.http.impl.client.BasicAuthCache;
+import org.apache.http.impl.client.BasicCredentialsProvider;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.nio.TrustAllManager;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.base.Strings;
+
+public class CloudianClient {
+private static final Logger LOG = Logger.getLogger(CloudianClient.class);
+
+private final HttpClient httpClient;
+private final HttpClientContext httpContext;
+private final String adminApiUrl;
+
+public CloudianClient(final String host, final Integer port, final String
scheme, final String username, final String password, final boolean
validateSSlCertificate, final int timeout) throws KeyStoreException,
NoSuchAlgorithmException, KeyManagementException {
+final CredentialsProvider provider = new BasicCredentialsProvider();
+provider.setCredentials(AuthScope.ANY, new
UsernamePasswordCredentials(username, password));
+final HttpHost adminHost = new HttpHost(host, port, scheme);
+final AuthCache authCache = new BasicAuthCache();
+authCache.put(adminHost, new BasicScheme());
+
+this.adminApiUrl = adminHost.toURI();
+this.httpContext = HttpClientContext.create();
+this.httpContext.setCredentialsProvider(provider);
+this.httpContext.setAuthCache(authCache);
+
+final RequestConfig config = RequestConfig.custom()
+.setConnectTimeout(timeout * 1000)
+.setConnectionRequestTimeout(timeout * 1000)
+.setSocketTimeout(timeout * 1000)
+.build();
+
+if (!validateSSlCertificate) {
+final SSLContext sslcontext = SSLUtils.getSSLContext();
+sslcontext.init(null, new X509TrustManager[]{new
TrustAllManager()}, new SecureRandom());
+final SSLConnectionSocketFactory factory = new
SSLConnectionSocketFactory(sslcontext, NoopHostnameVerifier.INSTANCE);
+this.httpClient = HttpClientBuilder.create()
+.setDefaultCredentialsProvider(provider)
+.setDefaultRequestConfig(config)
+.setSSLSocketFactory(factory)
+
[GitHub] rafaelweingartner commented on a change in pull request #2284: CLOUDSTACK-10103: Cloudian Connector for CloudStack
rafaelweingartner commented on a change in pull request #2284:
CLOUDSTACK-10103: Cloudian Connector for CloudStack
URL: https://github.com/apache/cloudstack/pull/2284#discussion_r143735439
##
File path:
plugins/integrations/cloudian/src/org/apache/cloudstack/cloudian/client/CloudianClient.java
##
@@ -0,0 +1,349 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.cloudian.client;
+
+import java.io.IOException;
+import java.net.SocketTimeoutException;
+import java.security.KeyManagementException;
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.X509TrustManager;
+
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.utils.security.SSLUtils;
+import org.apache.http.HttpHost;
+import org.apache.http.HttpResponse;
+import org.apache.http.HttpStatus;
+import org.apache.http.auth.AuthScope;
+import org.apache.http.auth.Credentials;
+import org.apache.http.auth.UsernamePasswordCredentials;
+import org.apache.http.client.AuthCache;
+import org.apache.http.client.CredentialsProvider;
+import org.apache.http.client.HttpClient;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.HttpDelete;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.client.methods.HttpPut;
+import org.apache.http.client.protocol.HttpClientContext;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.http.conn.ssl.NoopHostnameVerifier;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.auth.BasicScheme;
+import org.apache.http.impl.client.BasicAuthCache;
+import org.apache.http.impl.client.BasicCredentialsProvider;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.nio.TrustAllManager;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.base.Strings;
+
+public class CloudianClient {
+private static final Logger LOG = Logger.getLogger(CloudianClient.class);
+
+private final HttpClient httpClient;
+private final HttpClientContext httpContext;
+private final String adminApiUrl;
+
+public CloudianClient(final String host, final Integer port, final String
scheme, final String username, final String password, final boolean
validateSSlCertificate, final int timeout) throws KeyStoreException,
NoSuchAlgorithmException, KeyManagementException {
+final CredentialsProvider provider = new BasicCredentialsProvider();
+provider.setCredentials(AuthScope.ANY, new
UsernamePasswordCredentials(username, password));
+final HttpHost adminHost = new HttpHost(host, port, scheme);
+final AuthCache authCache = new BasicAuthCache();
+authCache.put(adminHost, new BasicScheme());
+
+this.adminApiUrl = adminHost.toURI();
+this.httpContext = HttpClientContext.create();
+this.httpContext.setCredentialsProvider(provider);
+this.httpContext.setAuthCache(authCache);
+
+final RequestConfig config = RequestConfig.custom()
+.setConnectTimeout(timeout * 1000)
+.setConnectionRequestTimeout(timeout * 1000)
+.setSocketTimeout(timeout * 1000)
+.build();
+
+if (!validateSSlCertificate) {
+final SSLContext sslcontext = SSLUtils.getSSLContext();
+sslcontext.init(null, new X509TrustManager[]{new
TrustAllManager()}, new SecureRandom());
+final SSLConnectionSocketFactory factory = new
SSLConnectionSocketFactory(sslcontext, NoopHostnameVerifier.INSTANCE);
+this.httpClient = HttpClientBuilder.create()
+.setDefaultCredentialsProvider(provider)
+.setDefaultRequestConfig(config)
+.setSSLSocketFactory(factory)
+
[GitHub] rafaelweingartner commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rafaelweingartner commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335476552 @rhtyd may I ask you something? I was looking at the code, and I see that you removed a variable called `deviceNumber` that did not seem to be used at the method `prepareDvNicDevice`. However, looking at the changes I did not understand how they modify the limit of NICs to be attached into a VM when using VMware hypervisor. Is it related to that `setKey(30)` that you removed there? BTW: long time I am not able to review or work much with you guys ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland opened a new pull request #2290: WIP: add track id to async api calls
DaanHoogland opened a new pull request #2290: WIP: add track id to async api calls URL: https://github.com/apache/cloudstack/pull/2290 API calls should be logging a more appropriate tracking id. It already exists but seems not be used consistently enough. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rafaelweingartner commented on a change in pull request #2288:
CLOUDSTACK-10107: For VMware VMs add devices without unit number
URL: https://github.com/apache/cloudstack/pull/2288#discussion_r143729189
##
File path: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##
@@ -210,16 +208,13 @@ public static VirtualDevice
prepareDvNicDevice(VirtualMachineMO vmMo, ManagedObj
dvPortConnection.setPortgroupKey(morNetwork.getValue());
dvPortBacking.setPort(dvPortConnection);
nic.setBacking(dvPortBacking);
-nic.setKey(30);
connectInfo.setAllowGuestControl(true);
-connectInfo.setConnected(conntected);
+connectInfo.setConnected(connected);
connectInfo.setStartConnected(connectOnStart);
nic.setAddressType("Manual");
nic.setConnectable(connectInfo);
nic.setMacAddress(macAddress);
-
-nic.setUnitNumber(deviceNumber);
nic.setKey(-contextNumber);
Review comment:
@rhtyd I know this is not your code, but there is something that called my
attention (maybe you know why this is the way it is). At first I thought it was
some dusty on my laptop screen... When the method `nic.setKey` is called, the
code does `-contextNumber`, converting the positive integer to a negative one.
I looked at the docs and the key is a unique ID of the NIC, but I reading the
docs I did not see any reasons to use negative value as IDs.
Do you understand why we are using negative values there?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rafaelweingartner commented on a change in pull request #2288:
CLOUDSTACK-10107: For VMware VMs add devices without unit number
URL: https://github.com/apache/cloudstack/pull/2288#discussion_r143729189
##
File path: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##
@@ -210,16 +208,13 @@ public static VirtualDevice
prepareDvNicDevice(VirtualMachineMO vmMo, ManagedObj
dvPortConnection.setPortgroupKey(morNetwork.getValue());
dvPortBacking.setPort(dvPortConnection);
nic.setBacking(dvPortBacking);
-nic.setKey(30);
connectInfo.setAllowGuestControl(true);
-connectInfo.setConnected(conntected);
+connectInfo.setConnected(connected);
connectInfo.setStartConnected(connectOnStart);
nic.setAddressType("Manual");
nic.setConnectable(connectInfo);
nic.setMacAddress(macAddress);
-
-nic.setUnitNumber(deviceNumber);
nic.setKey(-contextNumber);
Review comment:
@rhtyd I know this is not your code, but there is something that called my
attention (maybe you know why this is the way it is). At first I thought it was
some dusty on my laptop screen... When the method `nic.setKey` is called, the
code does `-contextNumber`, converting the positive integer to a negative one.
I looked at the docs and the key is a unique ID of the NIC, but I reading the
docs I did not see any reasons to use negative value as IDs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2287: CLOUDSTACK-9998: Prometheus Exporter for CloudStack
DaanHoogland commented on a change in pull request #2287: CLOUDSTACK-9998:
Prometheus Exporter for CloudStack
URL: https://github.com/apache/cloudstack/pull/2287#discussion_r143721874
##
File path:
plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
##
@@ -0,0 +1,612 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.metrics;
+
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
+import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
+import org.apache.log4j.Logger;
+
+import com.cloud.alert.AlertManager;
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.DomainJoinDao;
+import com.cloud.api.query.dao.HostJoinDao;
+import com.cloud.api.query.dao.StoragePoolJoinDao;
+import com.cloud.api.query.vo.DomainJoinVO;
+import com.cloud.api.query.vo.HostJoinVO;
+import com.cloud.api.query.vo.StoragePoolJoinVO;
+import com.cloud.capacity.Capacity;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.capacity.CapacityVO;
+import com.cloud.capacity.dao.CapacityDao;
+import com.cloud.capacity.dao.CapacityDaoImpl;
+import com.cloud.configuration.Resource;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.DataCenterIpAddressDao;
+import com.cloud.host.Host;
+import com.cloud.host.Status;
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.storage.ImageStore;
+import com.cloud.storage.StorageStats;
+import com.cloud.storage.Volume;
+import com.cloud.storage.VolumeVO;
+import com.cloud.storage.dao.VolumeDao;
+import com.cloud.utils.component.Manager;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.vm.VirtualMachine.State;
+import com.cloud.vm.dao.VMInstanceDao;
+import com.google.common.base.Strings;
+
+public class PrometheusExporterImpl extends ManagerBase implements
PrometheusExporter, Manager {
+private static final Logger LOG =
Logger.getLogger(PrometheusExporterImpl.class);
+
+private static final String USED = "used";
+private static final String ALLOCATED = "allocated";
+private static final String UNALLOCATED = "unallocated";
+private static final String TOTAL = "total";
+private static final String ONLINE = "online";
+private static final String OFFLINE = "offline";
+
+private static List metricsItems = new ArrayList<>();
+
+@Inject
+private DataCenterDao dcDao;
+@Inject
+private HostJoinDao hostJoinDao;
+@Inject
+private VMInstanceDao vmDao;
+@Inject
+private VolumeDao volumeDao;
+@Inject
+private IPAddressDao publicIpAddressDao;
+@Inject
+private DataCenterIpAddressDao privateIpAddressDao;
+@Inject
+private CapacityDao capacityDao;
+@Inject
+private StoragePoolJoinDao storagePoolJoinDao;
+@Inject
+private ImageStoreDao imageStoreDao;
+@Inject
+private DomainJoinDao domainDao;
+@Inject
+private AlertManager alertManager;
+
+public PrometheusExporterImpl() {
+super();
+}
+
+private void addHostMetrics(final List metricsList, final long dcId,
final String zoneName, final String zoneUuid) {
+int total = 0;
+int up = 0;
+int down = 0;
+for (final HostJoinVO host : hostJoinDao.listAll()) {
+if (host == null || host.getType() != Host.Type.Routing ||
host.getZoneId() != dcId) {
+continue;
+}
+total++;
+if (host.getStatus() == Status.Up) {
+up++;
+} else if (host.getStatus() == Status.Disconnected ||
host.getStatus() == Status.Down) {
+down++;
+}
+
+final String cpuFactor =
String.valueOf(CapacityManager.CpuOverprovisioningFactor.valueIn(host.getClusterId()));
+final CapacityVO cpuCapacity =
capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU);
+metricsList.add(new ItemHostCpu(zoneName, zoneUuid,
host.getName(), host.getUuid(), host.getPrivateIpAddress(),
[GitHub] DaanHoogland commented on a change in pull request #2287: CLOUDSTACK-9998: Prometheus Exporter for CloudStack
DaanHoogland commented on a change in pull request #2287: CLOUDSTACK-9998:
Prometheus Exporter for CloudStack
URL: https://github.com/apache/cloudstack/pull/2287#discussion_r143720620
##
File path:
plugins/integrations/prometheus/src/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
##
@@ -0,0 +1,612 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.metrics;
+
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
+import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
+import org.apache.log4j.Logger;
+
+import com.cloud.alert.AlertManager;
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.DomainJoinDao;
+import com.cloud.api.query.dao.HostJoinDao;
+import com.cloud.api.query.dao.StoragePoolJoinDao;
+import com.cloud.api.query.vo.DomainJoinVO;
+import com.cloud.api.query.vo.HostJoinVO;
+import com.cloud.api.query.vo.StoragePoolJoinVO;
+import com.cloud.capacity.Capacity;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.capacity.CapacityVO;
+import com.cloud.capacity.dao.CapacityDao;
+import com.cloud.capacity.dao.CapacityDaoImpl;
+import com.cloud.configuration.Resource;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.DataCenterIpAddressDao;
+import com.cloud.host.Host;
+import com.cloud.host.Status;
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.storage.ImageStore;
+import com.cloud.storage.StorageStats;
+import com.cloud.storage.Volume;
+import com.cloud.storage.VolumeVO;
+import com.cloud.storage.dao.VolumeDao;
+import com.cloud.utils.component.Manager;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.vm.VirtualMachine.State;
+import com.cloud.vm.dao.VMInstanceDao;
+import com.google.common.base.Strings;
+
+public class PrometheusExporterImpl extends ManagerBase implements
PrometheusExporter, Manager {
+private static final Logger LOG =
Logger.getLogger(PrometheusExporterImpl.class);
+
+private static final String USED = "used";
+private static final String ALLOCATED = "allocated";
+private static final String UNALLOCATED = "unallocated";
+private static final String TOTAL = "total";
+private static final String ONLINE = "online";
+private static final String OFFLINE = "offline";
+
+private static List metricsItems = new ArrayList<>();
+
+@Inject
+private DataCenterDao dcDao;
+@Inject
+private HostJoinDao hostJoinDao;
+@Inject
+private VMInstanceDao vmDao;
+@Inject
+private VolumeDao volumeDao;
+@Inject
+private IPAddressDao publicIpAddressDao;
+@Inject
+private DataCenterIpAddressDao privateIpAddressDao;
+@Inject
+private CapacityDao capacityDao;
+@Inject
+private StoragePoolJoinDao storagePoolJoinDao;
+@Inject
+private ImageStoreDao imageStoreDao;
+@Inject
+private DomainJoinDao domainDao;
+@Inject
+private AlertManager alertManager;
+
+public PrometheusExporterImpl() {
+super();
+}
+
+private void addHostMetrics(final List metricsList, final long dcId,
final String zoneName, final String zoneUuid) {
Review comment:
I would love to see this method split. It doesn't fit in my mind. Guess it
doesn't differ for the functionality.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] resmo commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
resmo commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335464884 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-335461368 Packaging result: ?centos6 ?centos7 ?debian. JID-1146 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2225: [master] Smoketest health checkrun
blueorangutan commented on issue #2225: [master] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-335461182 Packaging result: ?centos6 ?centos7 ?debian. JID-1145 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2289: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-335452324 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2225: [master] Smoketest health checkrun
blueorangutan commented on issue #2225: [master] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2225#issuecomment-335452097 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2225: [master] Smoketest health checkrun
rhtyd closed pull request #2225: [master] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2225 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2289: [4.11/master] Smoketest Health Check
rhtyd opened a new pull request #2289: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2289 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335447757 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335447559 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
DaanHoogland commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335446915 LGTM based on the code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335445966 Packaging result: ?centos6 ?centos7 ?debian. JID-1144 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r143700117
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
@rhtyd
1 We cannot reproduce the scenario directly, as it depends on usage events.
2 Duplicate usage occurs due to in correct database records and we may not
know which scenarios are populating the incorrect values.
Ideally it is good to fix the cases that are generating wrong database
records.
But there may be more then one cases that causes this error, fixing all
dependent systems is time consuming and complicated so better to handle here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
blueorangutan commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335440399 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number
rhtyd commented on issue #2288: CLOUDSTACK-10107: For VMware VMs add devices without unit number URL: https://github.com/apache/cloudstack/pull/2288#issuecomment-335440373 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-335416346 Packaging result: ?centos6 ?centos7 ?debian. JID-1143 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] HarikaPunna commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot
HarikaPunna commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot URL: https://github.com/apache/cloudstack/pull/2081#issuecomment-335415694 @mike-tutkowski, I don't think the creation of basic zone was failing because of these changes, can you try running it again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2)
blueorangutan commented on issue #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-335413095 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2281: CLOUDSTACK-10102: New network type (L2)
borisstoyanov commented on issue #2281: CLOUDSTACK-10102: New network type (L2) URL: https://github.com/apache/cloudstack/pull/2281#issuecomment-335412790 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP
resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-335409302 We seeing an issue after a VPC restart. After a VPC restart, only the last VPN will get established. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
blueorangutan commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-335409058 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.
borisstoyanov commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range. URL: https://github.com/apache/cloudstack/pull/2048#issuecomment-335409032 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-335394180 @rhtyd @wido restarted the blueoranutang, will merge if it looks succesful never mind ^^, will rebase This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-335394180 @rhtyd @wido restarted the blueoranutang, will merge if it looks succesful This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations
blueorangutan commented on issue #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-335393787 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations
DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-335393655 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-335384039 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-335380974 sorry @rohit, nice to see you anyway This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot
DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for Delta Snapshot URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-335380790 fine, regression tests on release will do. this is isolated enough from other functionality. merge, @rhtyd @borisstoyanov ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
