[GitHub] [cloudstack] jcshen007 commented on issue #2112: Add Datera CloudStack Storage Plugin 4.10.0.0
jcshen007 commented on issue #2112: Add Datera CloudStack Storage Plugin 4.10.0.0 URL: https://github.com/apache/cloudstack/pull/2112#issuecomment-486929762 Closing the outdated PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] jcshen007 closed pull request #2112: Add Datera CloudStack Storage Plugin 4.10.0.0
jcshen007 closed pull request #2112: Add Datera CloudStack Storage Plugin 4.10.0.0 URL: https://github.com/apache/cloudstack/pull/2112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] syed commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count
syed commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#discussion_r278754030 ## File path: engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDao.java ## @@ -30,6 +30,8 @@ List listByStoreId(long id, DataStoreRole role); +List listByStoreIdInReadyState(long id); Review comment: Both track different things. `SnapshotState` is more for the end snapshot object whereas `ObjectInDataStore` tracks the status of the snapshot on a particular storage pool This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-486835390 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
nvazquez commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-486835088 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-486813797 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
blueorangutan commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-486806921 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
nvazquez commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-486806600 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rafaelweingartner merged pull request #3183: Improvements after jquery update
rafaelweingartner merged pull request #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: Improvements after jquery update (#3183)
This is an automated email from the ASF dual-hosted git repository.
rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 89d5480 Improvements after jquery update (#3183)
89d5480 is described below
commit 89d548052b821ba1255c3c575f0c193894446371
Author: Nico Wohlfarth
AuthorDate: Thu Apr 25 21:09:43 2019 +0200
Improvements after jquery update (#3183)
* Add jQuery ui stylings to the project
* Adapt stylings to jquery ui stylings
- remove unnecessary (empty) style definitions
* Check if jquery autocomplete is initialized before destroying it
* Use dialog modal option instead of setting z-index styling
- set minimum heigth of dialog
* Swap removeAttr() for prop() since it's not longer recommended as of
jQuery 3.0
* Fix reccuring snapshots modal view
* Further style improvements
* More improvements on the instance-wizard (and multi-wizard in general)
* Raise input hints over modal z-index
* Adapt/fix stylings
- center buttons of create form modals
- fix width of select menu in service offerings
- fix width of modal in Network -> VPC -> configure -> static NAT -> aquire
new Ip -> enable static nat
* Adapt width of dynamic-input container
---
ui/css/cloudstack3.css | 557 +---
ui/index.html |1 +
ui/lib/jquery-ui/css/jquery-ui.css | 1151
ui/scripts/configuration.js|2 +-
ui/scripts/roles.js|5 +-
ui/scripts/system.js |8 +-
ui/scripts/ui-custom/instanceWizard.js | 11 +-
ui/scripts/ui/widgets/toolTip.js |2 +-
ui/scripts/vpc.js |2 +-
ui/scripts/zoneWizard.js | 16 +-
10 files changed, 1339 insertions(+), 416 deletions(-)
diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index ab0fd5a..cfad99d 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -17,9 +17,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-/*+clearfix {*/
div.toolbar:after,
-.multi-wizard .progress ul li:after,
.multi-wizard.zone-wizard .select-container .field .select-array-item:after {
content: ".";
display: block;
@@ -30,21 +28,16 @@ div.toolbar:after,
}
div.toolbar,
-.multi-wizard .progress ul li,
.multi-wizard.zone-wizard .select-container .field .select-array-item {
display: inline-block;
}
div.toolbar,
-.multi-wizard .progress ul li,
.multi-wizard.zone-wizard .select-container .field .select-array-item {
- /*\*/
display: block;
- /**/
- -height: 1px;
+ height: 1px;
}
-/*+}*/
body {
min-width: 1224px;
font-family: sans-serif;
@@ -938,9 +931,6 @@ div.list-view div.toolbar div.section-switcher
div.section-select label {
margin: auto;
}
-.install-wizard .step.intro {
-}
-
.install-wizard .step.intro iframe {
width: 99%;
height: 99%;
@@ -,9 +1101,6 @@ div.notification-box .container ul li.first {
border-top: none;
}
-div.notification-box .container ul li.last {
-}
-
div.notification-box .button {
float: left;
background: url(../images/buttons.png) no-repeat;
@@ -1243,9 +1230,6 @@ div.notification.corner-alert div.message span {
}
/*Tooltips*/
-.tooltip {
-}
-
.tooltip-info {
width: 239px;
min-height: 83px;
@@ -1528,9 +1512,6 @@ span.compact {
opacity: 0.35;
}
-.quick-view-tooltip > div.title span.title {
-}
-
.quick-view-tooltip .container {
border: 1px solid #9EA2A5;
background: #FF;
@@ -1547,9 +1528,6 @@ span.compact {
}
/*** Quick view detail view*/
-.quick-view-tooltip .detail-view {
-}
-
.quick-view-tooltip .detail-view .main-groups {
width: 456px;
height: 170px;
@@ -1567,9 +1545,6 @@ span.compact {
box-shadow: 0px 1px #E6E6E6;
}
-.quick-view-tooltip .detail-view .actions {
-}
-
.quick-view-tooltip .detail-view .tagger {
display: none;
}
@@ -1725,21 +1700,6 @@ span.compact {
padding: 0 0 0 14px;
}
-.ui-tabs ul.ui-tabs-nav {
- margin-top: 42px;
- display: block;
- width: 100%;
- height: 41px;
- float: left;
- border: none;
- overflow: hidden;
- z-index: 2;
- /*+placement:shift 0px 2px;*/
- position: relative;
- left: 0px;
- top: 2px;
-}
-
.ui-tabs .info {
background: #EFEFEF;
width: 91%;
@@ -1767,41 +1727,6 @@ span.compact {
color: #506273;
}
-.ui-tabs ul.ui-tabs-subnav li {
- display: block;
- float: left;
-}
-
-.ui-tabs li a {
- float: left;
- padding: 15px 10px;
- min-width: 91px;
- text-align: center;
- font-size: 11px;
- margin-right: 5px;
- color: #4E6070;
- text-decoration: none;
- /*+placement:shift 0px 2px;*/
- position: relative;
- left: 0px;
- top: 2px;
-}
-
-.ui-tabs li {
- float: left;
-}
-
-.ui-tabs ul
[GitHub] [cloudstack] rafaelweingartner commented on issue #3183: Improvements after jquery update
rafaelweingartner commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-486801078 People discussed, reviewed and approved the PR. It is pure JS and CSS changes. Therefore, the integration tests (that test Java code) are not relevant in this context. Thank you all for the reviews and code changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count
skattoju4 commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#discussion_r278619328 ## File path: engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDao.java ## @@ -30,6 +30,8 @@ List listByStoreId(long id, DataStoreRole role); +List listByStoreIdInReadyState(long id); Review comment: yup fixed. wasn't sure why state was mapped to ObjectInDataStoreStateMachine.State and not Snapshot.State .. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] syed commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count
syed commented on a change in pull request #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#discussion_r278606436 ## File path: engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDao.java ## @@ -30,6 +30,8 @@ List listByStoreId(long id, DataStoreRole role); +List listByStoreIdInReadyState(long id); Review comment: Can you make this a generic function `listByStoreIdAndState` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
nvazquez commented on a change in pull request #3239: [WIP DO NOT MERGE] KVM:
Fix agents dont reconnect post maintenance
URL: https://github.com/apache/cloudstack/pull/3239#discussion_r278593957
##
File path: test/integration/smoke/test_host_maintenance.py
##
@@ -290,3 +274,325 @@ def
test_02_cancel_host_maintenace_with_migration_jobs(self):
return
+class TestHostMaintenanceAgents(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestHostMaintenanceAgents,
cls).getClsTestClient()
+cls.apiclient = cls.testClient.getApiClient()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.dbclient = cls.testClient.getDbConnection()
+cls.zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+cls.pod = get_pod(cls.apiclient, cls.zone.id)
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.logger = logging.getLogger('TestHMAgents')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls._cleanup = []
+cls.hypervisorNotSupported = False
+if cls.hypervisor.lower() not in ['kvm', 'lxc']:
+cls.hypervisorNotSupported = True
+
+if not cls.hypervisorNotSupported:
+cls.initialsshvalue = cls.is_ssh_enabled()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.hypervisor
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.services["virtual_machine"]["hypervisor"] = cls.hypervisor
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["tiny"]
+)
+cls._cleanup.append(cls.service_offering)
+cls.network_offering = NetworkOffering.create(
+cls.apiclient,
+cls.services["l2-network_offering"],
+)
+cls.network_offering.update(cls.apiclient, state='Enabled')
+cls.services["network"]["networkoffering"] =
cls.network_offering.id
+cls.l2_network = Network.create(
+cls.apiclient,
+cls.services["l2-network"],
+zoneid=cls.zone.id,
+networkofferingid=cls.network_offering.id
+)
+cls._cleanup.append(cls.l2_network)
+cls._cleanup.append(cls.network_offering)
+
+@classmethod
+def tearDownClass(cls):
+try:
+if not cls.hypervisorNotSupported:
+# Revert setting value to the original
+cls.set_ssh_enabled(cls.initialsshvalue)
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+if not self.hypervisorNotSupported:
+self.host = self.get_enabled_host_connected_agent()
+self.cleanup = []
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+
+@classmethod
+def is_ssh_enabled(cls):
+conf = Configurations.list(cls.apiclient, name="kvm.ssh.to.agent")
+if not conf:
+return False
+else:
+return bool(strtobool(conf[0].value)) if conf[0].value else False
+
+@classmethod
+def set_ssh_enabled(cls, on):
+value = "true" if on else "false"
+sql = "update configuration set value = '%s' where name =
'kvm.ssh.to.agent';" % value
Review comment:
Done, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DagSonsteboSB opened a new issue #3295: GUI listPublicIPAddresses return not filtered for current network
DagSonsteboSB opened a new issue #3295: GUI listPublicIPAddresses return not filtered for current network URL: https://github.com/apache/cloudstack/issues/3295 # ISSUE TYPE * Bug Report # COMPONENT NAME * CloudStack GUI # CLOUDSTACK VERSION * ACS 4.11.2 # CONFIGURATION * Advanced zone * 2 x shared networks in "setup" state # OS / ENVIRONMENT * N/A # SUMMARY * GUI calls listPublicIPAddresses as follows and does not filter for current network when using the "change IP address" function: command=listPublicIpAddresses=json=false=01891a96-1a86-4401-948a-ed434c5be1ba=false * As a result all IP addresses from both shared networks are returned, allowing the end user to select an IP address which can not be assigned to the NIC in question * Checking http://cloudstack.apache.org/api/apidocs-4.11/apis/listPublicIpAddresses.html it seems the parameter "networkid" is not actually implemented, hence API call from GUI incorrect # STEPS TO REPRODUCE * Create two shared networks and make sure they are in "setup" state * Create VM with NIC assigned to shared net 1 * Try to use the "change IP" function in the GUI * Observe this returns a list of ALL shared IP addresses for both shared networks * For completeness sake try to assign an IP address on the second shared network and observe this failing whether VM is running or not # EXPECTED RESULTS * GUI should return only IP addresses on current shared network # ACTUAL RESULTS * GUI returns list of IP addresses from both shared networks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier closed pull request #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui
pbankonier closed pull request #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier commented on issue #3294: Set default service offering over api and ui
pbankonier commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-486661264 I opened a new PR because I had some conflicts when trying to push my changes to the old one. https://github.com/apache/cloudstack/pull/3198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier opened a new pull request #3294: Set default service offering over api and ui
pbankonier opened a new pull request #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294 ## Description This adds the possibility to add/change the defaultUse/unique name of system service offerings over the ui and api. The create and update command of the system service offerings now have an optional parameter for the default use. The default use parameter is a boolean value. When setting a a new service offering or when editing an existing one to be a default one, the unique name and default use value of the offering which currently had it gets set to NULL. The unique name depends on the system vm type, localstorage and defaultuse values. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots In the list it gets shown if the service offering is a default one.  You can now set the offering to a default one when creating a new system service offering.  You can set/unset the service offering as a default one in the edit view.   I also added the possibility to create a elastic lb here because it was missing.  ## How Has This Been Tested? Deployed this to our test environment and tested functionality. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates
blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-486582235 Trillian test result (tid-3527) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30587 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2995-t3527-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 66 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 192.91 | test_internal_lb.py test_04_extract_template | `Failure` | 128.30 | test_templates.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 321.25 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
