[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-507010340 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-507009371 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-507009330 @borisstoyanov pushed a fix for the outstanding error @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-506993158 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-506992228 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-506992224 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
nvazquez commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r298812981
##
File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
##
@@ -1353,46 +1353,57 @@ protected boolean setHostIntoMaintenance(HostVO host)
throws NoTransitionExcepti
return true;
}
-protected boolean setHostIntoPrepareForMaintenanceWithErrors(HostVO host)
throws NoTransitionException {
-s_logger.debug("Host " + host.getUuid() + " entering in
PrepareForMaintainenceWithErrors state");
+protected boolean setHostIntoPrepareForMaintenanceWithErrors(HostVO host,
List errorVms) throws NoTransitionException {
+s_logger.debug("Host " + host.getUuid() + " entering in
PrepareForMaintenanceWithErrors state");
+configureVncAccessForKVMHostFailedMigrations(host, errorVms);
resourceStateTransitTo(host, ResourceState.Event.UnableToMigrate,
_nodeId);
return true;
}
+protected boolean setHostIntoPrepareForMaintenanceAfterErrorsFixed(HostVO
host) throws NoTransitionException {
+s_logger.debug("Host " + host.getUuid() + " entering in
PrepareForMaintenance state as any previous corrections have been fixed");
+resourceStateTransitTo(host, ResourceState.Event.ErrorsCorrected,
_nodeId);
+return true;
+}
+
/**
* Return true if host goes into Maintenance mode, only when:
* - No Running, Migrating or Failed migrations (host_id = last_host_id)
for the host
*/
-protected boolean attemptMaintain(HostVO host) throws
NoTransitionException {
+private boolean attemptMaintain(HostVO host) throws NoTransitionException {
final long hostId = host.getId();
if (CollectionUtils.isEmpty(_vmDao.findByHostInStates(hostId,
State.Migrating, State.Running, State.Starting, State.Stopping, State.Error,
State.Unknown))) {
return setHostIntoMaintenance(host);
}
final List allVmsOnHost = _vmDao.listByHostId(hostId);
-final List migratingVms =
_vmDao.listVmsMigratingFromHost(hostId);
-final List failedMigrations =
_vmDao.listNonMigratingVmsByHostEqualsLastHost(hostId);
-boolean hasPendingWorkForVMs = false;
+boolean hasPendingMigrationWorks = false;
for (VMInstanceVO vmInstanceVO : allVmsOnHost) {
-if (_haMgr.hasPendingHaWork(vmInstanceVO.getId())) {
-hasPendingWorkForVMs = true;
+if (_haMgr.hasPendingMigrationsWork(vmInstanceVO.getId())) {
+hasPendingMigrationWorks = true;
break;
}
}
-if (!hasPendingWorkForVMs) {
-if ((CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId,
State.Running)) && CollectionUtils.isEmpty(migratingVms)) ||
-(CollectionUtils.isEmpty(_vmDao.findByHostInStates(hostId,
State.Running)) &&
-
CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId, State.Unknown,
State.Error, State.Shutdowned {
-return setHostIntoErrorInMaintenance(host, failedMigrations);
-}
+final List failedMigrations = new
ArrayList<>(_vmDao.listNonMigratingVmsByHostEqualsLastHost(hostId));
+final List errorVms = new
ArrayList<>(_vmDao.findByHostInStates(hostId, State.Unknown, State.Error,
State.Shutdowned));
+final boolean hasMigratingVms =
CollectionUtils.isNotEmpty(_vmDao.listVmsMigratingFromHost(hostId));
+final boolean hasRunningVms =
CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId, State.Running));
+final boolean hasFailedMigrations =
CollectionUtils.isNotEmpty(failedMigrations);
+final boolean hasVmsInFailureStates =
CollectionUtils.isNotEmpty(errorVms);
+errorVms.addAll(failedMigrations);
+
+if (!hasPendingMigrationWorks && (hasRunningVms || (!hasRunningVms &&
!hasMigratingVms && hasVmsInFailureStates))) {
+return setHostIntoErrorInMaintenance(host, errorVms);
+}
+
+if ((hasVmsInFailureStates || hasFailedMigrations) &&
(hasPendingMigrationWorks || hasMigratingVms ||
CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId, State.Stopping
{
Review comment:
Same as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
nvazquez commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r298812976
##
File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
##
@@ -1353,46 +1353,57 @@ protected boolean setHostIntoMaintenance(HostVO host)
throws NoTransitionExcepti
return true;
}
-protected boolean setHostIntoPrepareForMaintenanceWithErrors(HostVO host)
throws NoTransitionException {
-s_logger.debug("Host " + host.getUuid() + " entering in
PrepareForMaintainenceWithErrors state");
+protected boolean setHostIntoPrepareForMaintenanceWithErrors(HostVO host,
List errorVms) throws NoTransitionException {
+s_logger.debug("Host " + host.getUuid() + " entering in
PrepareForMaintenanceWithErrors state");
+configureVncAccessForKVMHostFailedMigrations(host, errorVms);
resourceStateTransitTo(host, ResourceState.Event.UnableToMigrate,
_nodeId);
return true;
}
+protected boolean setHostIntoPrepareForMaintenanceAfterErrorsFixed(HostVO
host) throws NoTransitionException {
+s_logger.debug("Host " + host.getUuid() + " entering in
PrepareForMaintenance state as any previous corrections have been fixed");
+resourceStateTransitTo(host, ResourceState.Event.ErrorsCorrected,
_nodeId);
+return true;
+}
+
/**
* Return true if host goes into Maintenance mode, only when:
* - No Running, Migrating or Failed migrations (host_id = last_host_id)
for the host
*/
-protected boolean attemptMaintain(HostVO host) throws
NoTransitionException {
+private boolean attemptMaintain(HostVO host) throws NoTransitionException {
final long hostId = host.getId();
if (CollectionUtils.isEmpty(_vmDao.findByHostInStates(hostId,
State.Migrating, State.Running, State.Starting, State.Stopping, State.Error,
State.Unknown))) {
return setHostIntoMaintenance(host);
}
final List allVmsOnHost = _vmDao.listByHostId(hostId);
-final List migratingVms =
_vmDao.listVmsMigratingFromHost(hostId);
-final List failedMigrations =
_vmDao.listNonMigratingVmsByHostEqualsLastHost(hostId);
-boolean hasPendingWorkForVMs = false;
+boolean hasPendingMigrationWorks = false;
for (VMInstanceVO vmInstanceVO : allVmsOnHost) {
-if (_haMgr.hasPendingHaWork(vmInstanceVO.getId())) {
-hasPendingWorkForVMs = true;
+if (_haMgr.hasPendingMigrationsWork(vmInstanceVO.getId())) {
+hasPendingMigrationWorks = true;
break;
}
}
-if (!hasPendingWorkForVMs) {
-if ((CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId,
State.Running)) && CollectionUtils.isEmpty(migratingVms)) ||
-(CollectionUtils.isEmpty(_vmDao.findByHostInStates(hostId,
State.Running)) &&
-
CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId, State.Unknown,
State.Error, State.Shutdowned {
-return setHostIntoErrorInMaintenance(host, failedMigrations);
-}
+final List failedMigrations = new
ArrayList<>(_vmDao.listNonMigratingVmsByHostEqualsLastHost(hostId));
+final List errorVms = new
ArrayList<>(_vmDao.findByHostInStates(hostId, State.Unknown, State.Error,
State.Shutdowned));
+final boolean hasMigratingVms =
CollectionUtils.isNotEmpty(_vmDao.listVmsMigratingFromHost(hostId));
+final boolean hasRunningVms =
CollectionUtils.isNotEmpty(_vmDao.findByHostInStates(hostId, State.Running));
+final boolean hasFailedMigrations =
CollectionUtils.isNotEmpty(failedMigrations);
+final boolean hasVmsInFailureStates =
CollectionUtils.isNotEmpty(errorVms);
+errorVms.addAll(failedMigrations);
+
+if (!hasPendingMigrationWorks && (hasRunningVms || (!hasRunningVms &&
!hasMigratingVms && hasVmsInFailureStates))) {
Review comment:
Maybe this could be a separate method with a javadoc to explain it? To
improve readability
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3446: Cannot deploy new vm in isolated network 4.11.3
ustcweizhou commented on issue #3446: Cannot deploy new vm in isolated network 4.11.3 URL: https://github.com/apache/cloudstack/issues/3446#issuecomment-506985344 @rhtyd I am not sure if it will break something. @richardlawley can you please have a look ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3446: Cannot deploy new vm in isolated network 4.11.3
rhtyd commented on issue #3446: Cannot deploy new vm in isolated network 4.11.3 URL: https://github.com/apache/cloudstack/issues/3446#issuecomment-506985081 Thanks @ustcweizhou I'll get back to you. Feel free to send a PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3446: Cannot deploy new vm in isolated network 4.11.3
ustcweizhou edited a comment on issue #3446: Cannot deploy new vm in isolated network 4.11.3 URL: https://github.com/apache/cloudstack/issues/3446#issuecomment-506984272 @rhtyd I think this is a blocker issue in 4.11.3 It is related to 2f268fbb52203cae96d0cff57c189600abab1390 It works if I revert the following line https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L521 ``` if self.get_type() in ["public"]: ``` back to ``` if self.get_type() in ["public"] and (len(self.iplist) == 1): ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3446: Cannot deploy new vm in isolated network 4.11.3
ustcweizhou commented on issue #3446: Cannot deploy new vm in isolated network 4.11.3 URL: https://github.com/apache/cloudstack/issues/3446#issuecomment-506984272 @rhtyd I think this is a blocker issue in 4.11.3 It is related to 2f268fbb52203cae96d0cff57c189600abab1390 It works if I revert the following line https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L521 back to ``` if self.get_type() in ["public"] and (len(self.iplist) == 1): ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new issue #3446: Cannot deploy new vm in isolated network 4.11.3
ustcweizhou opened a new issue #3446: Cannot deploy new vm in isolated network
4.11.3
URL: https://github.com/apache/cloudstack/issues/3446
When I did
(1) created an isolated network in 4.11.2.0, and associate some public IPs.
(2) upgraded cloudstack to 4.11.3.0,
(3) restart network with cleanup to get new virtual router,
(4) tried to deploy a new vm but failed
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
Virtual router
~~~
# CLOUDSTACK VERSION
~~~
4.11.3.0
~~~
# CONFIGURATION
~~~
isolated network in advanced zone
multiple public IPs in same subnet are used
~~~
# OS / ENVIRONMENT
# SUMMARY
# STEPS TO REPRODUCE
~~~
see the first lines
~~~
# EXPECTED RESULTS
~~~
deploy vm successfully
~~~
# ACTUAL RESULTS
~~~
exception when apply dhcp entry in virtual routers
2019-06-29 19:53:41,316 DEBUG [c.c.a.t.Request]
(AgentManager-Handler-15:null) (logid:) Seq 1-6565966781729472809: Processing:
{ Ans: , MgmtId: 2486323791686, via: 1, Ver: v1, Flags: 10,
[{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success:
Creating file in VR, with ip: 169.254.3.232, file:
vm_dhcp_entry.json.4a69380c-ed8f-4df3-a842-ac0634482a82","null - success:
Error: argument \"table\" is wrong: node type value is invalid\n\nRTNETLINK
answers: File exists\nError: argument \"table\" is wrong: node type value is
invalid\n\nRTNETLINK answers: File exists\nError: argument \"table\" is wrong:
node type value is invalid\n\nRTNETLINK answers: File exists\nError: argument
\"table\" is wrong: node type value is invalid\n\nRTNETLINK answers: File
exists\nError: argument \"table\" is wrong: node type value is
invalid\n\nRTNETLINK answers: File exists\nError: argument \"table\" is wrong:
node type value is invalid\n\nRTNETLINK answers: File
exists\n"],"result":true,"wait":0}}] }
~~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix)
ustcweizhou commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix) URL: https://github.com/apache/cloudstack/issues/3311#issuecomment-506982355 @rhtyd will do This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix)
rhtyd commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix) URL: https://github.com/apache/cloudstack/issues/3311#issuecomment-506981407 Thanks @ustcweizhou in that case can you send a PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix)
ustcweizhou edited a comment on issue #3311: Issues when multiple management IP
addresses are set in the KVM hypervisor (with fix)
URL: https://github.com/apache/cloudstack/issues/3311#issuecomment-506981342
@rhtyd
I tested the following java code in centos6, centos7, ubuntu12 and ubuntu16.
It lists all devices and ips in reverse order as "ip a".
So I think it is better to reverse the ip addresses as usually we use the
first ip of nics for communication.
ListNetworkAddresses.java
```
import java.net.InterfaceAddress;
import java.net.NetworkInterface;
import java.util.Collections;
import java.util.List;
public class ListNetworkAddresses {
public static void main(String[] args) throws Exception {
final List nics =
Collections.list(NetworkInterface.getNetworkInterfaces());
for (final NetworkInterface nic : nics) {
final List addrs = nic.getInterfaceAddresses();
if (addrs != null) {
for (final InterfaceAddress addr : addrs) {
System.out.println("network device name is " +
nic.getName() + ", ip is " + addr.getAddress().getHostAddress());
}
}
}
}
}
```
command
```
javac ListNetworkAddresses.java && java ListNetworkAddresses
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix)
ustcweizhou commented on issue #3311: Issues when multiple management IP
addresses are set in the KVM hypervisor (with fix)
URL: https://github.com/apache/cloudstack/issues/3311#issuecomment-506981342
@rhtyd
I tested the following java code in centos6, centos7, ubuntu12 and ubuntu16.
It lists all devices and ips in reverse order as "ip a".
So I think it is better to reverse the ip addresses as usually we use the
first ip of nics for communication.
ListNetworkAddresses.java
```
import java.net.InterfaceAddress;
import java.net.NetworkInterface;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
public class ListNetworkAddresses {
public static void main(String[] args) throws Exception {
final List nics =
Collections.list(NetworkInterface.getNetworkInterfaces());
for (final NetworkInterface nic : nics) {
final List addrs = nic.getInterfaceAddresses();
if (addrs != null) {
for (final InterfaceAddress addr : addrs) {
System.out.println("network device name is " +
nic.getName() + ", ip is " + addr.getAddress().getHostAddress());
}
}
}
}
}
```
command
```
javac ListNetworkAddresses.java && java ListNetworkAddresses
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
blueorangutan commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-506978533 Trillian test result (tid-64) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28502 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3319-t64-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 70 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_redundant_vpc_site2site_vpn | `Failure` | 380.76 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks
blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks URL: https://github.com/apache/cloudstack/pull/3439#issuecomment-506976676 Trillian test result (tid-62) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29798 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3439-t62-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 377.45 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3437: systemvm: don't fork to curl to save password
blueorangutan commented on issue #3437: systemvm: don't fork to curl to save password URL: https://github.com/apache/cloudstack/pull/3437#issuecomment-506975640 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3437: systemvm: don't fork to curl to save password
rhtyd commented on issue #3437: systemvm: don't fork to curl to save password URL: https://github.com/apache/cloudstack/pull/3437#issuecomment-506975578 Env issue rekicking @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks
blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks URL: https://github.com/apache/cloudstack/pull/3439#issuecomment-506971433 Trillian test result (tid-59) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34900 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3439-t59-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 65 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Error` | 14.52 | test_scale_vm.py test_04_extract_template | `Failure` | 128.35 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 139.76 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3437: systemvm: don't fork to curl to save password
blueorangutan commented on issue #3437: systemvm: don't fork to curl to save password URL: https://github.com/apache/cloudstack/pull/3437#issuecomment-506960511 Trillian test result (tid-63) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 15827 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3437-t63-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 50 look OK, 21 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_02_create_template_with_checksum_sha1 | `Error` | 65.47 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.48 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.47 | test_templates.py test_02_deploy_vm_from_direct_download_template | `Error` | 1.29 | test_templates.py test_03_deploy_vm_wrong_checksum | `Error` | 1.33 | test_templates.py ContextSuite context=TestTemplates>:setup | `Error` | 15.40 | test_templates.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.17 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.18 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.36 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.09 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.19 | test_service_offerings.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
[GitHub] [cloudstack] anuragaw commented on issue #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard
anuragaw commented on issue #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard URL: https://github.com/apache/cloudstack/pull/3336#issuecomment-506955948 I am afraid most of the entities targetted in the PR description have their own sortkey fields now in code after some recent PRs EXCEPT below- 1. affinityGroups 2. ISOs 3. sshkeyPairs by name 4. network: vpcs by name & networkOfferings by name This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3050: Sort list of templates in the deploy VM wizard
anuragaw commented on issue #3050: Sort list of templates in the deploy VM wizard URL: https://github.com/apache/cloudstack/issues/3050#issuecomment-506955693 Templates now support a sortkey in master and this issue is no longer needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #2724: Service Offering Sorting is broken in UI
anuragaw commented on issue #2724: Service Offering Sorting is broken in UI URL: https://github.com/apache/cloudstack/issues/2724#issuecomment-506955548 DB support for service offerings was existing but I discovered another bug while testing and fixed it in the above PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw opened a new pull request #3445: Fix sorting order bug in UI Code with usage of sortkey.algorithm global config
anuragaw opened a new pull request #3445: Fix sorting order bug in UI Code with usage of sortkey.algorithm global config URL: https://github.com/apache/cloudstack/pull/3445 Current master has sorting broken and the order reverses as opposed to what is set if sortkey.algorithm is set to true. The problem lies in the way the update APIs were being called by the UI. The code was agnostic to a global config that backend uses to set the order of the entities in the corresponding list APIs. We need to make UI aware of the global config and instead of changing sign of sort key pass proper numbers so that DB isn't confusing when some tables have positive sortkey and some have negative. The fix is in 2 steps- 1) Make use of sortkey name in place where it's relevant. Mere row index is not sufficient. 2) Reverse the sortkey if we are sorting by descending (when global config is false) ## Description Fix is general bugfix but I also verified that #2724 is also fixed after this change and verifiable. The DB support already existed. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506951389 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506950273 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags
rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506950206 Thanks @ustcweizhou @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags
ustcweizhou commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506950053 @rhtyd @anuragaw rebased with latest master, and added a separate commit to remove the methods not in use. If we need to fill more information to project response in the future, we can revert the commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix)
rhtyd commented on issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix) URL: https://github.com/apache/cloudstack/issues/3311#issuecomment-506947667 I checked the jdk docs, the order of the list of interfaces and addresses returned by `getInterfaceAddresses` is implementation and platform dependent so I'm not sure if the list need to be reversed. I think the workaround you've used @NuxRo is good enough. @ustcweizhou can you comment if reversing the order would make sense wrt Linux? For most users they can now use the software lb, by passing multiple mgmt server IPs to the host global setting. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3179: Redundant VRouter guest network on wrong interface
rhtyd commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-506946567 @DennisKonrad can you confirm if you managed to fix the issue? Are you using OVS with KVM? I could not reproduce the error on KVM/centos7 with standard Linux-bridge networking. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3071: strongswan - error during user VPN connection
rhtyd commented on issue #3071: strongswan - error during user VPN connection URL: https://github.com/apache/cloudstack/issues/3071#issuecomment-506946306 I couldn't reproduce this against latest master and on Ubuntu and Windows 10, will test again. In your tests, was an issue with pre-shared key @msinhore @DennisKonrad ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
rhtyd removed a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-506644452 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows
blueorangutan removed a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-506644653 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
blueorangutan commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-506946189 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-506946172 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3316: [WIP DO NOT MERGE] Fix private gateway ACLs
rhtyd commented on issue #3316: [WIP DO NOT MERGE] Fix private gateway ACLs URL: https://github.com/apache/cloudstack/pull/3316#issuecomment-506946066 @DennisKonrad please ping me when you think the PR is ready for testing and review, I'll help kick tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags
rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-506943344 I'll wait for your final change @ustcweizhou, then it it ready for merge. The latest tests LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3442: UserDispersingPlanner only counts Running vms on hosts.
rhtyd commented on issue #3442: UserDispersingPlanner only counts Running vms on hosts. URL: https://github.com/apache/cloudstack/issues/3442#issuecomment-506942804 UserDispersingPlanner can consider both VMs in running and starting states. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3306: server: reduce execution time while listing project if projects have many resource tags
anuragaw commented on a change in pull request #3306: server: reduce execution
time while listing project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#discussion_r298793354
##
File path: server/src/main/java/com/cloud/api/query/dao/ProjectJoinDaoImpl.java
##
@@ -101,14 +99,6 @@ public ProjectResponse newProjectResponse(ProjectJoinVO
proj) {
@Override
public ProjectResponse setProjectResponse(ProjectResponse rsp,
ProjectJoinVO proj) {
Review comment:
Sounds good. I think we should make this simple change then to make code
cleaner and easy to comprehend in this PR. CC/ @rhtyd
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3306: server: reduce execution time while listing project if projects have many resource tags
anuragaw commented on a change in pull request #3306: server: reduce execution
time while listing project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#discussion_r298793354
##
File path: server/src/main/java/com/cloud/api/query/dao/ProjectJoinDaoImpl.java
##
@@ -101,14 +99,6 @@ public ProjectResponse newProjectResponse(ProjectJoinVO
proj) {
@Override
public ProjectResponse setProjectResponse(ProjectResponse rsp,
ProjectJoinVO proj) {
Review comment:
Sounds good. I think we should make this simple change then to make code
cleaner and easy to comprehend in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3306: server: reduce execution time while listing project if projects have many resource tags
ustcweizhou commented on a change in pull request #3306: server: reduce
execution time while listing project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#discussion_r298793217
##
File path: server/src/main/java/com/cloud/api/query/dao/ProjectJoinDaoImpl.java
##
@@ -101,14 +99,6 @@ public ProjectResponse newProjectResponse(ProjectJoinVO
proj) {
@Override
public ProjectResponse setProjectResponse(ProjectResponse rsp,
ProjectJoinVO proj) {
Review comment:
@anuragaw
you are right.
Actually there is similar comment before
https://github.com/apache/cloudstack/pull/3306#issuecomment-502142160
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3306: server: reduce execution time while listing project if projects have many resource tags
anuragaw commented on a change in pull request #3306: server: reduce execution
time while listing project if projects have many resource tags
URL: https://github.com/apache/cloudstack/pull/3306#discussion_r298791786
##
File path: server/src/main/java/com/cloud/api/query/dao/ProjectJoinDaoImpl.java
##
@@ -101,14 +99,6 @@ public ProjectResponse newProjectResponse(ProjectJoinVO
proj) {
@Override
public ProjectResponse setProjectResponse(ProjectResponse rsp,
ProjectJoinVO proj) {
Review comment:
This method seems to be called in the following path -
`ViewResponseHelper#createProjectResponse() >
ApiDBUtils#fillProjectDetails() > ProjectJoinDaoImpl#setProjectResponse`
I am a little confused by the necessity of this method call at all. Read the
below method definitions-
```
ApiDBUtils {
public static ProjectResponse fillProjectDetails(ProjectResponse rsp,
ProjectJoinVO proj) {
return s_projectJoinDao.setProjectResponse(rsp, proj);
}
}
ViewResponseHelper {
public static List
createProjectResponse(ProjectJoinVO... projects) {
Hashtable prjDataList = new Hashtable();
// Initialise the prjdatalist with the input data
for (ProjectJoinVO p : projects) {
ProjectResponse pData = prjDataList.get(p.getId());
if (pData == null) {
// first time encountering this vm
pData = ApiDBUtils.newProjectResponse(p);
} else {
// update those 1 to many mapping fields
pData = ApiDBUtils.fillProjectDetails(pData, p);
}
prjDataList.put(p.getId(), pData);
}
return new ArrayList(prjDataList.values());
}
}
```
Why not simply delete this path and modify the ViewResponseHelper to
generate the projects response list at one go?
Apologies if I am missing something obvious?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks
blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks URL: https://github.com/apache/cloudstack/pull/3439#issuecomment-506932971 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3439: 4.11.3.0 RC2 Health Checks
rhtyd commented on issue #3439: 4.11.3.0 RC2 Health Checks URL: https://github.com/apache/cloudstack/pull/3439#issuecomment-506932963 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks
blueorangutan commented on issue #3439: 4.11.3.0 RC2 Health Checks URL: https://github.com/apache/cloudstack/pull/3439#issuecomment-506932886 Trillian test result (tid-58) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40310 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3439-t58-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 69 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: server: VPC redundant vrs run on same hypervisor (#3421)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 9ac32aa server: VPC redundant vrs run on same hypervisor (#3421)
9ac32aa is described below
commit 9ac32aae385457392aaa7dccd799624a669490e3
Author: Wei Zhou
AuthorDate: Sat Jun 29 08:39:36 2019 +0200
server: VPC redundant vrs run on same hypervisor (#3421)
For VPC supports redundant VRs, when start the second VR, the
pod/cluster/host of first VR should be added to avoid list. This provides
higher availability.
The network VRs have the same process already.
---
server/src/com/cloud/network/router/NetworkHelperImpl.java | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/server/src/com/cloud/network/router/NetworkHelperImpl.java
b/server/src/com/cloud/network/router/NetworkHelperImpl.java
index fa17e7b..1262158 100644
--- a/server/src/com/cloud/network/router/NetworkHelperImpl.java
+++ b/server/src/com/cloud/network/router/NetworkHelperImpl.java
@@ -375,8 +375,13 @@ public class NetworkHelperImpl implements NetworkHelper {
final List networkIds =
_routerDao.getRouterNetworks(router.getId());
DomainRouterVO routerToBeAvoid = null;
+List routerList = null;
if (networkIds.size() != 0) {
-final List routerList =
_routerDao.findByNetwork(networkIds.get(0));
+routerList = _routerDao.findByNetwork(networkIds.get(0));
+} else if (router.getVpcId() != null) {
+routerList = _routerDao.listByVpcId(router.getVpcId());
+}
+if (routerList != null) {
for (final DomainRouterVO rrouter : routerList) {
if (rrouter.getHostId() != null &&
rrouter.getIsRedundantRouter() && rrouter.getState() == State.Running) {
if (routerToBeAvoid != null) {
[GitHub] [cloudstack] rhtyd merged pull request #3421: RvR: VPC redundant vrs run on same hypervisor
rhtyd merged pull request #3421: RvR: VPC redundant vrs run on same hypervisor URL: https://github.com/apache/cloudstack/pull/3421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
