[GitHub] [cloudstack] shwstppr closed pull request #3606: [WIP DO NOT MERGE] VM ingestion
shwstppr closed pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr opened a new pull request #3606: [WIP DO NOT MERGE] VM ingestion
shwstppr opened a new pull request #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606
## Description
Documentation PR: https://github.com/apache/cloudstack-documentation/pull/84
FS Doc: https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Ingestion
VM ingestion feature allows CloudStack to discover, on-board, import
existing VMs in an infra. The feature currently works only for VMware, with a
hypervisor agnostic framework which may be extended for KVM and XenServer in
future.
Two new APIs have been added, `listUnmanagedInstances` and
`importUnmanagedInstance`.
### listUnmanagedInstances
API will list all unmanaged virtual machine for a give cluster. Optionally,
name for an existing unmanaged virtual machine can be given to retrieve VM
details.
**API request params -**
`clusterid`(UUID of cluster)
`name`(instance name)
**Response -**
`clusterid`
`hostid`
`name`
`osdisplayname`
`memory`
`powerstate`
`cpuCoresPerSocket`
`cpunumber`
`cpuspeed`
`disk`
- `id`
- `capacity`
- `controller`
- `controllerunit`
- `imagepath`
- `position`
`nic`
- `id`
- `macaddress`
- `networkname`
- `vlanid`
- `pcislot`
### importUnmanagedInstance
API will import an exisitng unmanaged virtual machine into CloudStack for a
given cluster and virtual machine name. Service offering for the VM, disk
offerings for volumes and networks for NICs of the VM can be mapped. Some
optional parameters like projectid, domainid, hostname, details, etc can also
be given. Appropritate networks, service offering and disk offerings need to be
present before import and cannot be created on the fly during the API call.
**API request params -**
`clusterid`(UUID of cluster)
`name`(instance name)
`displayname`
`hostname`
`domainid`
`projectid`
`templateid`
`serviceofferingid`
`diskofferingid`(UUID of disk offering for root disk)
`nicnetworklist`(Map for NIC ID and corresponding Network UUID)
`datadiskofferinglist`(Map for disk ID and corresponding disk offering UUID)
`details`(Map for VM details)
`migrateAllowed`(VM and its volumes are allowed to migrate to different
host/pool
**Response -**
Same response as that of `deployVirtualMachine` API
A python based script (scripts/vm/hypervisor/vmware/discover_networks.py)
has been created to aid migrations. It leverages VMware’s pyvmomi library
(https://github.com/vmware/pyvmomi) and allows listing all networks for a
vCenter host or cluster.
This script can take following arguments,
```
-h, --help show this help message and exit
-s HOST, --host HOST vSphere service to connect to
-o PORT, --port PORT Port to connect on
-u USER, --user USER User name to use
-p PASSWORD, --password PASSWORD Password to use
-c CLUSTER, --cluster CLUSTER Cluster for which discover networks
-S, --disable_ssl_verification Disable ssl host certificate verification
-d, --debug Debug log messages
```
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## API sample calls:
**List**
```
> list unmanagedinstances clusterid=079a19c2-2710-4ed6-9110-027dd5e0f262
{
"count": 2,
"unmanagedinstance": [
{
"clusterid": "079a19c2-2710-4ed6-9110-027dd5e0f262",
"cpucorespersocket": 1,
"cpunumber": 1,
"cpuspeed": 0,
"disk": [
{
"capacity": 2097152,
"controller": "ide",
"controllerunit": 0,
"id": "51-3001",
"imagepath": "[8aca30d6f7803420973f01cc91c1c011]
test-unmanaged/test-unmanaged_64.vmdk",
"label": "Hard disk 1",
"position": 1
},
{
"capacity": 5242880,
"controller": "scsi",
"controllerunit": 0,
"id": "51-2000",
"imagepath": "[8aca30d6f7803420973f01cc91c1c011]
test-unmanaged/test-unmanaged_63.vmdk",
"label": "Hard disk 2",
"position": 0
}
],
"hostid": "4ab4147a-7e40-4abe-a0e2-2fac1aa6f0bf",
"memory": 512,
"name": "test-unmanaged",
"nic": [
{
"id": "Network adapter 1",
"macaddress": "02:00:39:7c:00:24",
"networkname": "cloud.guest.1212.200.1-vSwitch1",
"vlanid": 1212
}
],
"osdisplayname": "CentOS 4/5 or later (64-bit)",
"powerstate": "POWERED_ON"
}
]
[GitHub] [cloudstack] nvazquez commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN
nvazquez commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN URL: https://github.com/apache/cloudstack/pull/3653#issuecomment-555320690 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN
blueorangutan commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN URL: https://github.com/apache/cloudstack/pull/3653#issuecomment-555320821 @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN
blueorangutan commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN URL: https://github.com/apache/cloudstack/pull/3653#issuecomment-555319948 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3653: Fix VR creation issue while creating VM on shared network using PVLAN
nvazquez opened a new pull request #3653: Fix VR creation issue while creating
VM on shared network using PVLAN
URL: https://github.com/apache/cloudstack/pull/3653
## Description
Fix VR creation issue when deploying VM on shared network using PVLAN.
Tested on KVM + Open vSwitch host
Error:
2019-10-28 13:37:19,217 DEBUG [c.c.a.t.Request]
(Work-Job-Executor-3:ctx-522095d0 job-29/job-30 ctx-22bff2f0) (logid:6771277e)
Seq 1-4072942913003192458: Received: { Ans: , MgmtId: 32988167473142, via:
1(ref-trl-218-k-m7-nvazquez-kvm1), Ver: v1, Flags: 10, { StartAnswer,
CheckSshAnswer, GetDomRVersionAnswer, NetworkUsageAnswer, Answer, Answer,
Answer } }
2019-10-28 13:37:19,224 DEBUG [o.a.c.n.t.AdvancedNetworkTopology]
(Work-Job-Executor-3:ctx-522095d0 job-29/job-30 ctx-22bff2f0) (logid:6771277e)
SETUP DHCP PVLAN RULES
2019-10-28 13:37:19,228 DEBUG [c.c.n.r.NetworkHelperImpl]
(Work-Job-Executor-3:ctx-522095d0 job-29/job-30 ctx-22bff2f0) (logid:6771277e)
Router requires upgrade. Unable to send command to router:4, router template
version : null, minimal required version : 4.10.0
2019-10-28 13:37:19,229 WARN [o.a.c.n.t.AdvancedNetworkVisitor]
(Work-Job-Executor-3:ctx-522095d0 job-29/job-30 ctx-22bff2f0) (logid:6771277e)
Timed Out
com.cloud.exception.ResourceUnavailableException: Resource [VirtualRouter:4]
is unreachable: Unable to send command. Router requires upgrade
at
com.cloud.network.router.NetworkHelperImpl.sendCommandsToRouter(NetworkHelperImpl.java:175)
at
org.apache.cloudstack.network.topology.AdvancedNetworkVisitor.visit(AdvancedNetworkVisitor.java:185)
at com.cloud.network.rules.DhcpPvlanRules.accept(DhcpPvlanRules.java:61)
at
org.apache.cloudstack.network.topology.AdvancedNetworkTopology.setupDhcpForPvlan(AdvancedNetworkTopology.java:131)
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.finalizeStart(VirtualNetworkApplianceManagerImpl.java:2073)
at
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1146)
Proposed fix:
- Move the VR template version insert into `domain_router` table before
iterating through the VR nics to setup PVLAN
Workaround:
- Disable the global setting: `router.version.check`
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
KVM + Open vSwitch bridging
- Create a Shared network providing:
- Primary VLAN ID
- Secondary VLAN ID
- Deploy user VM on network
Before this fix: Observe that VR creation fails -> user VM creation fails
After this fix: Successful VM deployment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN
blueorangutan commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN URL: https://github.com/apache/cloudstack/pull/3653#issuecomment-555316074 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez closed pull request #3653: Fix VR creation issue while creating VM on shared network using PVLAN
nvazquez closed pull request #3653: Fix VR creation issue while creating VM on shared network using PVLAN URL: https://github.com/apache/cloudstack/pull/3653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN
nvazquez commented on issue #3653: Fix VR creation issue while creating VM on shared network using PVLAN URL: https://github.com/apache/cloudstack/pull/3653#issuecomment-555315923 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-555281554 Trillian test result (tid-488) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38861 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3425-t488-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_cancel_host_maintenace_with_migration_jobs_ports_blocked | `Error` | 214.65 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-555266393 Trillian test result (tid-489) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34894 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3425-t489-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 179.09 | test_host_maintenance.py test_03_cancel_host_maintenace_with_migration_jobs_ports_blocked | `Error` | 192.82 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-555244102 Trillian test result (tid-484) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38827 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3425-t484-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Failure` | 42.97 | test_scale_vm.py test_03_cancel_host_maintenace_with_migration_jobs_ports_blocked | `Error` | 204.84 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555101797 @andrijapanicsb we test both thing but we dont encounter any problem. can you check this too? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555101284 @wido you are completely right. we will test it tomorrow. the main problem is we dont have the knowledge about the router internal scripts. you know? there is nobody who know where "cmdline" will be used. a grep inside a virtual router gave ~20 script where this variable will be used. i will repeat. we dont have the skills to change this. we can try to add the mtu value to the "cmdline" but we need help by the change of the router scripts? can you or @GabrielBrascher help? Cheers Sven This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shindere opened a new issue #3692: Accessibility issue: unable to get API and secret keys
shindere opened a new issue #3692: Accessibility issue: unable to get API and secret keys URL: https://github.com/apache/cloudstack/issues/3692 I am a blind user of CloudStack and have to administer several domains. Currently, I am unable to navigate the web interface to find out my API and secret keys (e.g. to use CloudMonkey) because of accessibility issues in the web interface. For instance at one stage I need to click on an image but can't do so becuase it has no alternative text associated to it. Are you guys interested in immproving Cloudstack's accessibility? Thanks, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3186: Add possibility to set KVM MTU size for all NIC
andrijapanicsb commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555100288 > @andrijapanicsb yes we tested it on a new 4.13 install. seems to work fine. I was speaking about upgrades, where the config key (older style of code) will not be executed during the upgrades and the setting will be missing completely. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3544: When scrolling down the VM settings, they keep on loading again and again endlessly
DaanHoogland commented on issue #3544: When scrolling down the VM settings, they keep on loading again and again endlessly URL: https://github.com/apache/cloudstack/issues/3544#issuecomment-555095817 #3690 and #3691 relate to this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] wido commented on issue #3186: Add possibility to set KVM MTU size for all NIC
wido commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555093052 @svenvogel Without sending the MTU parameter to the VR things like password resets and other metadata >1500 bytes would become a problem. During startup the 'cmdline' is send to the VR/SSVM which it uses to configure it's IPs and other network related. There we would need to add a parameter which also sets the MTU on those NIC(s). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new issue #3691: CS reports VM running from appliance, when it didn't start properly
DaanHoogland opened a new issue #3691: CS reports VM running from appliance, when it didn't start properly URL: https://github.com/apache/cloudstack/issues/3691 CS reports VM running from appliance but does not start properly - the reason is suspected to be missing configurations from the missing options as described in #3690 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMWARE ~~~ # CLOUDSTACK VERSION ~~~ 4.13 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new issue #3690: When importing a multi-disk OVA some options are missing in appliances created from it
DaanHoogland opened a new issue #3690: When importing a multi-disk OVA some options are missing in appliances created from it URL: https://github.com/apache/cloudstack/issues/3690 There missing "options" in appliances in Vmware - a direct import in vcenter displays more options than the CS instance wizard. # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMWARE ~~~ # CLOUDSTACK VERSION ~~~ 4.13 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555071361 >When a VR is deployed, the MTU is being correctly configured on the KVM (e.g. /run/libvirt/qemu/r-2293-VM.xml) but the VR OS is still configured with default MTU (1500). It still would be needed to pass this in 'cmdline' to the VR on boot to have VRs booted with correct MTU. @GabrielBrascher thanks for testing! we dont know about the router scripts in VPC or virtual router an how we can implement it. i think its not so easy. maybe you can implement it? @andrijapanicsb yes we tested it on a new 4.13 install. seems to work fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3186: Add possibility to set KVM MTU size for all NIC
GabrielBrascher commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-555027592 @mdominka @svenvogel @gmueller-ewerk thanks for the changes! Quick update on tests. I have been testing it and overall looks fine; however, it would be nice to have VRs automatically configured with the MTU. When a VR is deployed, the MTU is being correctly configured on the KVM (e.g. _/run/libvirt/qemu/r-2293-VM.xml_) but the VR OS is still configured with default MTU (1500). It still would be needed to pass this in 'cmdline' to the VR on boot to have VRs booted with correct MTU. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554974714 @anuragaw a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554974325 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554970123 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554962393 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554962077 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-554956879 @andrijapanicsb * for me its absolute okay to make it mandatory and remove the flag. if other storages dont have a problem with virtual size i would prefer your way. i think too its a good solution. if its necessary i will upgrade the documentation. should we do it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on a change in pull request #3371: Fix virtual template
size for managed storage for KVM / refactor cloud-install-sys-tmplt
URL: https://github.com/apache/cloudstack/pull/3371#discussion_r347297219
##
File path: scripts/storage/secondary/cloud-install-sys-tmplt
##
@@ -20,17 +19,33 @@
usage() {
- printf "Usage: %s: -m -f [-h ] [ -s ][-u ] [-F ] [-e ]
[-o ] [-r ] [-p ] [-d ]\n" $(basename $0) >&2
- printf "or\n" >&2
- printf "%s: -m -u [-h ] [ -s ]\n" $(basename $0) >&2
+ printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-f system vm
template file\n\t-h hypervisor name: kvm|vmware|xenserver|hyperv|ovm3\n\t-s
mgmt server secret key, if you specified any when running
cloudstack-setup-database, default is password\n\t-u Url to system vm
template\n\t-F clean up system templates of specified hypervisor\n\t-e Template
suffix, e.g vhd, ova, qcow2\n\t-o Database server hostname or ip, e.g
localhost\n\t-r Database user name, e.g root\n\t-p mysql database port\n\t-d
Database password. Followed by nothing if the password is empty\n\t-M Managed
Storage (QCOW2/KVM only)\n\n" $(basename $0) >&2
+ printf "\tor\n"
+ printf "\nUsage: %s:\n\t-m secondary storage mount point\n\t-u http url for
system vm template\n\t-h hypervisor name:
kvm|vmware|xenserver|hyperv|ovm3\n\t-s mgmt server secret key\n\n" $(basename
$0) >&2
}
+# Usage: e.g. failed $? "this is an error"
failed() {
- echo "Installation failed"
- exit $1
+ local returnval=$1
+ local returnmsg=$2
+
+ # check for an message, if there is no one dont print anything
Review comment:
i will change it like -> "check for a message, if there is none dont print
anything" . better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on a change in pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#discussion_r347296588 ## File path: scripts/storage/secondary/createtmplt.sh ## @@ -210,7 +210,6 @@ echo "filename=$tmpltname" > /$tmpltfs/template.properties echo "description=$descr" >> /$tmpltfs/template.properties # we need to rethink this property as it might get changed after download due to decompression # option is to recalcutate it here -echo "checksum=$cksum" >> /$tmpltfs/template.properties Review comment: in my first PR i tried to remove the "createtmplt.sh" file completely from creation but it is "ugly" in java code used. by this way i found an not used variable. i think checksum calculation was removed from Dan Hoogland #2246. it was forgotten. i can make a seperate PR if this is better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on a change in pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt
svenvogel commented on a change in pull request #3371: Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#discussion_r347296588 ## File path: scripts/storage/secondary/createtmplt.sh ## @@ -210,7 +210,6 @@ echo "filename=$tmpltname" > /$tmpltfs/template.properties echo "description=$descr" >> /$tmpltfs/template.properties # we need to rethink this property as it might get changed after download due to decompression # option is to recalcutate it here -echo "checksum=$cksum" >> /$tmpltfs/template.properties Review comment: in my first PR i tried to remove the "createtmplt.sh" file completely from creation but it is "ugly" in java code used. by this way i found an not used variable. i think checksum calculation was removed from Dan Hoogland #2246. it was forgotten. i can make a separate PR if this is better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-554921846 @weizhouapache Leaving https://github.com/apache/cloudstack/pull/2304 in place sounds good. To me it looks like the more stable approach. Do you think the changes to get the isolated networks up to speed require some heavy lifting? If theres something to test I can do so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
