[GitHub] [cloudstack] andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm
andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm URL: https://github.com/apache/cloudstack/pull/3721#issuecomment-569210824 > Simple change regarding moving code from `cleanupNics` to `removeNic`; I don't see any potential issue with that. > > Based on code review, LGTM. @weizhouapache this should not affect the previos fix you did, cleaning dhcp/dns when VM is expunged, right? About to test this one, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm
andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm URL: https://github.com/apache/cloudstack/pull/3721#issuecomment-569210376 @blueorangutan test centos7 vmware65u2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm
blueorangutan commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm URL: https://github.com/apache/cloudstack/pull/3721#issuecomment-569142850 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm
blueorangutan commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm URL: https://github.com/apache/cloudstack/pull/3721#issuecomment-569140590 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm
andrijapanicsb commented on issue #3721: network: cleanup dhcp/dns entries while remove a nic from vm URL: https://github.com/apache/cloudstack/pull/3721#issuecomment-569140488 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb opened a new issue #3788: dnsmasq.leases file is missing on the new VR after network restart
andrijapanicsb opened a new issue #3788: dnsmasq.leases file is missing on the new VR after network restart URL: https://github.com/apache/cloudstack/issues/3788 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VR / DHCP ~~~ # CLOUDSTACK VERSION ~~~ 4.11+ ~~~ **PROBLEM:** After the new VR is created as part of the network restart with cleanup, the new VR will have missing or empty "/var/lib/misc/dnsmasq.leases" file This will cause that the VM after 15 days of running (50% from the currently hardcoded 30d lease duration) will try to renew it's DHCP lease by sending DHCPREQUEST, but VR/dnsmasq is not aware of that lease (dnsmasq.leases missing/empty), so it will send DHCPNAK, so eventually DHPC client will fail back to the initialization process and start from scratch with DHCPDISCOVER and get its IP again. This doesn't mean network downtime, but on some older RHEL 6.x systems (that assumes CentOS 6.x as well), **the "initialization" process will remove any static routes added**, thus causing issues. We need to ensure that the content of the "/var/lib/misc/dnsmasq.leases" file is regenerated/populated with all the needed records on the new VR when restarting a network with cleanup. Alos, rebootRouter / startRouter API while "recreate.systemvm.enabled”=”true” also need to produce the same results This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3611: [WIP] Support for CentOS8
rhtyd opened a new pull request #3611: [WIP] Support for CentOS8 URL: https://github.com/apache/cloudstack/pull/3611 This adds support for CentOS8 packaging. The first would be to support CentOS8 as KVM host, and then as mgmt+usage server host. Tasks: - [ ] Create BO/docker container for packaging - [ ] Test/support packaging for management and usage server, on CentOS8 host - [ ] Test/support packaging for KVM agent, on CentOS8 KVM host - [ ] Depends on #3601 (jdk changes, mysql dependency support/version) ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3611: [WIP] Support for CentOS8
rhtyd closed pull request #3611: [WIP] Support for CentOS8 URL: https://github.com/apache/cloudstack/pull/3611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb opened a new issue #3787: The same IP address of Shared VR not re-used when VR is deleted/created
andrijapanicsb opened a new issue #3787: The same IP address of Shared VR not re-used when VR is deleted/created URL: https://github.com/apache/cloudstack/issues/3787 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VR ~~~ # CLOUDSTACK VERSION ~~~ Tested in 4.11.3 (to be confirmed in 4.13, but I expect the identical behaviour) ~~~ # CONFIGURATION Shared network with a running VR. # OS / ENVIRONMENT NA # SUMMARY when VR is manually destroyed and then created automatically again (when starting an existing/new VM) - the public IP of the VR will NOT be the one from the “placeholder” DB records but a new random Public IP # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ When a new VR for Shared network is created, it's "public/guest" interface is given some IP and this one should persist for the life time of the VR - i.e. when network is restarted with cleannup, a new VR will be created, but with the same IP - so that the existing user VMs can continue to use it as DHCP/DNS server. i.e  ~~~ # ACTUAL RESULTS ~~~ When network is restarted with cleanup, the IP for the new NIC for the new VR stays the same as the "placeholder" IP (see image above) But when VR is deleted, and then a new VM is created/existing VM is started, a new VR will be created, but it will not inherit the "placeholder" IP, and will instead get the new IP address - this needs fixing. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3698: If a zone has two public IPs range in different VLANs, ACS doesn't create a second northbound NIC if needed
andrijapanicsb commented on issue #3698: If a zone has two public IPs range in different VLANs, ACS doesn't create a second northbound NIC if needed URL: https://github.com/apache/cloudstack/issues/3698#issuecomment-569060648 This works fine in 4.13 per my memory (from a few days ago). Can you test @msinhore ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up
andrijapanicsb commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up URL: https://github.com/apache/cloudstack/issues/3757#issuecomment-569059850 Good one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3784: systemVM stuck in starting state
andrijapanicsb commented on issue #3784: systemVM stuck in starting state URL: https://github.com/apache/cloudstack/issues/3784#issuecomment-569059953 @DaanHoogland is this related to local storage, or in general? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-569012758 Trillian test result (tid-673) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51071 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t673-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 62 look OK, 15 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1517.63 | test_accounts.py test_04_extract_Iso | `Failure` | 1.06 | test_iso.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.16 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.16 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_04_extract_template | `Failure` | 1.07 | test_templates.py test_06_download_detached_volume | `Failure` | 11.32 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 447.12 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 508.61 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3950.41 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
