[GitHub] [cloudstack] andrijapanicsb commented on issue #3776: Fix HA config keys

[GitBox]

andrijapanicsb commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572434722
 
 
   @DaanHoogland can you please review briefly


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-primate] branch master updated: config: update offering access action (domain/zone) (#94)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new de6dede  config: update offering access action (domain/zone) (#94)
de6dede is described below

commit de6dedee4ebd445221148d16bc9361d06e5782f4
Author: Abhishek Kumar 
AuthorDate: Thu Jan 9 12:32:35 2020 +0530

config: update offering access action (domain/zone) (#94)

Update Offering Access action with the action form for:
Compute Offering
Storage Offering
Network Offering
VPC Offering

Fixes #91

Signed-off-by: Abhishek Kumar 
Co-authored-by: Rohit Yadav 
Signed-off-by: Rohit Yadav 
---
 src/config/section/offering.js  |  28 +++
 src/views/offering/UpdateOfferingAccess.vue | 294 
 2 files changed, 322 insertions(+)

diff --git a/src/config/section/offering.js b/src/config/section/offering.js
index d3a4c25..14d29de 100644
--- a/src/config/section/offering.js
+++ b/src/config/section/offering.js
@@ -48,6 +48,13 @@ export default {
 dataView: true,
 args: ['name', 'displaytext']
   }, {
+api: 'updateServiceOffering',
+icon: 'lock',
+label: 'Update Offering Access',
+dataView: true,
+popup: true,
+component: () => import('@/views/offering/UpdateOfferingAccess.vue')
+  }, {
 api: 'deleteServiceOffering',
 icon: 'delete',
 label: 'Delete Offering',
@@ -112,6 +119,13 @@ export default {
 dataView: true,
 args: ['name', 'displaytext']
   }, {
+api: 'updateDiskOffering',
+icon: 'lock',
+label: 'Update Offering Access',
+dataView: true,
+popup: true,
+component: () => import('@/views/offering/UpdateOfferingAccess.vue')
+  }, {
 api: 'deleteDiskOffering',
 icon: 'delete',
 label: 'Delete Offering',
@@ -164,6 +178,13 @@ export default {
   }
 }
   }, {
+api: 'updateNetworkOffering',
+icon: 'lock',
+label: 'Update Offering Access',
+dataView: true,
+popup: true,
+component: () => import('@/views/offering/UpdateOfferingAccess.vue')
+  }, {
 api: 'deleteNetworkOffering',
 icon: 'delete',
 label: 'Delete Offering',
@@ -222,6 +243,13 @@ export default {
   }
 }
   }, {
+api: 'updateVPCOffering',
+icon: 'lock',
+label: 'Update Offering Access',
+dataView: true,
+popup: true,
+component: () => import('@/views/offering/UpdateOfferingAccess.vue')
+  }, {
 api: 'deleteVPCOffering',
 icon: 'delete',
 label: 'Delete Offering',
diff --git a/src/views/offering/UpdateOfferingAccess.vue 
b/src/views/offering/UpdateOfferingAccess.vue
new file mode 100644
index 000..4f34602
--- /dev/null
+++ b/src/views/offering/UpdateOfferingAccess.vue
@@ -0,0 +1,294 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+
+  
+
+
+
+  
+
+  {{ opt.name || opt.description }}
+
+  
+
+
+
+  
+
+  {{ opt.name || opt.description }}
+
+  
+
+
+
+  {{ this.$t('Cancel') }}
+  {{ 
this.$t('OK') }}
+
+
+  
+
+  
+
+
+
+import { api } from '@/api'
+
+export default {
+  name: 'UpdateOfferingAccess',
+  props: {
+resource: {
+  type: Object,
+  required: true
+}
+  },
+  data () {
+return {
+  offeringType: '',
+  selectedDomains: [],
+  selectedZones: [],
+  offeringIsPublic: false,
+  domains: [],
+  domainLoading: false,
+  zones: [],
+  zoneLoading: false,
+  loading: false
+}
+  },
+  beforeCreate () {
+this.form = this.$form.createForm(this)
+  },
+  created () {
+this.zones = [
+  {
+id: 'all',
+name: this.$t('label.all.zone')
+  }
+]
+  },
+  mounted () {
+

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572417498
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-554


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-primate] branch master updated: config: offerings list recursively (#95)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new a12cea4  config: offerings list recursively (#95)
a12cea4 is described below

commit a12cea473caecfca2dfad48e6b287b0c75dd779c
Author: Abhishek Kumar 
AuthorDate: Thu Jan 9 12:04:49 2020 +0530

config: offerings list recursively (#95)

Existing code was not listing *offerings recursively due to which domain 
admin user was not being able to see all offerings in its domain. This PR fixes 
listing behaviour.

Signed-off-by: Abhishek Kumar 
---
 src/config/section/offering.js | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/config/section/offering.js b/src/config/section/offering.js
index 2483d9c..d3a4c25 100644
--- a/src/config/section/offering.js
+++ b/src/config/section/offering.js
@@ -26,6 +26,7 @@ export default {
   title: 'Compute Offerings',
   icon: 'cloud',
   permission: ['listServiceOfferings'],
+  params: { isrecursive: 'true' },
   columns: ['name', 'displaytext', 'cpunumber', 'cpuspeed', 'memory', 
'tags', 'domain', 'zone'],
   details: ['name', 'id', 'displaytext', 'offerha', 'provisioningtype', 
'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber', 'cpuspeed', 
'memory', 'tags', 'domain', 'zone', 'created'],
   related: [{
@@ -58,7 +59,7 @@ export default {
   title: 'System Offerings',
   icon: 'setting',
   permission: ['listServiceOfferings', 'listInfrastructure'],
-  params: { issystem: 'true' },
+  params: { issystem: 'true', isrecursive: 'true' },
   columns: ['name', 'systemvmtype', 'cpunumber', 'cpuspeed', 'memory', 
'storagetype', 'tags'],
   details: ['name', 'id', 'displaytext', 'systemvmtype', 
'provisioningtype', 'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber', 
'cpuspeed', 'memory', 'tags', 'domain', 'zone', 'created'],
   actions: [{
@@ -89,6 +90,7 @@ export default {
   title: 'Disk Offerings',
   icon: 'hdd',
   permission: ['listDiskOfferings'],
+  params: { isrecursive: 'true' },
   columns: ['name', 'displaytext', 'disksize', 'tags', 'domain', 'zone'],
   details: ['name', 'id', 'displaytext', 'disksize', 'provisioningtype', 
'storagetype', 'iscustomized', 'tags', 'domain', 'zone', 'created'],
   related: [{
@@ -121,6 +123,7 @@ export default {
   title: 'Network Offerings',
   icon: 'wifi',
   permission: ['listNetworkOfferings'],
+  params: { isrecursive: 'true' },
   columns: ['name', 'state', 'guestiptype', 'traffictype', 'networkrate', 
'tags', 'domain', 'zone'],
   details: ['name', 'id', 'displaytext', 'guestiptype', 'traffictype', 
'networkrate', 'ispersistent', 'egressdefaultpolicy', 'availability', 
'conservemode', 'specifyvlan', 'specifyipranges', 'supportspublicaccess', 
'supportsstrechedl2subnet', 'service', 'tags', 'domain', 'zone'],
   actions: [{
@@ -172,6 +175,7 @@ export default {
   title: 'VPC Offerings',
   icon: 'deployment-unit',
   permission: ['listVPCOfferings'],
+  params: { isrecursive: 'true' },
   resourceType: 'VpcOffering',
   columns: ['name', 'state', 'displaytext', 'domain', 'zone'],
   details: ['name', 'id', 'displaytext', 'distributedvpcrouter', 
'service', 'tags', 'domain', 'zone', 'created'],

[GitHub] [cloudstack] rhtyd commented on issue #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572409620
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-571934113
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-546


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-571926995
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572409803
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

rhtyd removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-571926935
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572376638
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

rhtyd removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572354078
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572382508
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-552


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling 
maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572405484
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-553


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling 
maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-57244
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

nvazquez commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572399986
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

shwstppr commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364568132
 
 

 ##
 File path: 
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDaoImpl.java
 ##
 @@ -43,9 +43,12 @@ protected NetworkOfferingJoinDaoImpl() {
 }
 
 @Override
-public List findByDomainId(long domainId) {
+public List findByDomainId(long domainId, Boolean 
includeAllDomainOffering) {
 SearchBuilder sb = createSearchBuilder();
 sb.and("domainId", sb.entity().getDomainId(), 
SearchCriteria.Op.FIND_IN_SET);
+if (includeAllDomainOffering) {
+sb.or("zId", sb.entity().getZoneId(), SearchCriteria.Op.NULL);
+}
 
 Review comment:
   Was copy-paste error, fixed this.
   When includeAllDomainOffering is true, it should return offerings which have 
domainId in DB and also offerings for which domain is not set as they will be 
available for all domains.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

shwstppr commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364568254
 
 

 ##
 File path: 
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDaoImpl.java
 ##
 @@ -54,9 +57,12 @@ protected NetworkOfferingJoinDaoImpl() {
 }
 
 @Override
-public List findByZoneId(long zoneId) {
+public List findByZoneId(long zoneId, Boolean 
includeAllZoneOffering) {
 SearchBuilder sb = createSearchBuilder();
 sb.and("zoneId", sb.entity().getZoneId(), 
SearchCriteria.Op.FIND_IN_SET);
+if (includeAllZoneOffering) {
+sb.or("zId", sb.entity().getZoneId(), SearchCriteria.Op.NULL);
+}
 
 Review comment:
   When includeAllZoneOffering is true, it should return offerings which have 
zoneId in DB and also offerings for which zone is not set as they will be 
available for all zones.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572382508
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-552


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572379333
 
 
   @DaanHoogland I've fixed the comments, the 
`systemvm/debian/opt/cloud/bin/getRouterAlerts.sh` change was to make it 
executable to be consistent with other scripts in the directory. Yes, the PR is 
ready for testing/review.
   
   I've also synced the systemvmtemplates/4.14 here: 
http://download.cloudstack.org/systemvm/4.14/
   cc @wido @GabrielBrascher @andrijapanicsb @PaulAngus @DaanHoogland 
@borisstoyanov 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] shwstppr commented on issue #3121: Paging isn't fully implemented in WebUI

[GitBox]

shwstppr commented on issue #3121: Paging isn't fully implemented in WebUI
URL: https://github.com/apache/cloudstack/issues/3121#issuecomment-572378619
 
 
   @andrijapanicsb will try to have a look at it during weekend or next week


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on a change in pull request #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r364553143
 
 

 ##
 File path: server/src/test/java/com/cloud/snapshot/SnapshotDaoTest.java
 ##
 @@ -34,12 +31,16 @@
 import com.cloud.storage.dao.SnapshotDaoImpl;
 import com.cloud.utils.component.ComponentContext;
 
+import junit.framework.Assert;
+import junit.framework.TestCase;
+
 @RunWith(SpringJUnit4ClassRunner.class)
 @ContextConfiguration(locations = "classpath:/SnapshotDaoTestContext.xml")
 public class SnapshotDaoTest extends TestCase {
 @Inject
 SnapshotDaoImpl dao;
 
+
 
 Review comment:
   Fixed, @Pearl1594 likes to put extra newlines :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on a change in pull request #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r364552951
 
 

 ##
 File path: server/src/test/java/com/cloud/user/AccountManagetImplTestBase.java
 ##
 @@ -210,6 +211,12 @@ public void cleanup() {
 CallContext.unregister();
 }
 
+@Test
 
 Review comment:
   Yes :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on a change in pull request #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r364552930
 
 

 ##
 File path: 
server/src/test/java/com/cloud/user/AccountManagerImplVolumeDeleteEventTest.java
 ##
 @@ -54,18 +57,25 @@
 import com.cloud.service.ServiceOfferingVO;
 import com.cloud.storage.Volume.Type;
 import com.cloud.storage.VolumeVO;
+import com.cloud.vm.UserVmManager;
 import com.cloud.vm.UserVmManagerImpl;
 import com.cloud.vm.UserVmVO;
 import com.cloud.vm.VirtualMachine;
 
+@RunWith(MockitoJUnitRunner.class)
 public class AccountManagerImplVolumeDeleteEventTest extends 
AccountManagetImplTestBase {
 
 private static final Long ACCOUNT_ID = 1l;
 private static final String VOLUME_UUID = "vol-11";
 
 @Spy
 @InjectMocks
-UserVmManagerImpl _vmMgr;
+private UserVmManagerImpl _vmMgr;
+
+@Mock
+   private UserVmManager userVmManager;
 
 Review comment:
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on a change in pull request #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r364552918
 
 

 ##
 File path: 
server/src/test/java/com/cloud/storage/listener/StoragePoolMonitorTest.java
 ##
 @@ -58,17 +60,18 @@ public void setUp() throws Exception {
 
 @Test
 public void testProcessConnectStoragePoolNormal() throws Exception {
-Mockito.when(poolDao.listBy(Mockito.anyLong(), Mockito.anyLong(), 
Mockito.anyLong(), 
Mockito.any(ScopeType.class))).thenReturn(Collections.singletonList(pool));
+Mockito.when(poolDao.listBy(nullable(Long.class), 
nullable(Long.class), nullable(Long.class), 
Mockito.any(ScopeType.class))).thenReturn(Collections.singletonList(pool));
 Mockito.when(poolDao.findZoneWideStoragePoolsByTags(Mockito.anyLong(), 
Mockito.any(String[].class))).thenReturn(Collections.emptyList());
 
Mockito.when(poolDao.findZoneWideStoragePoolsByHypervisor(Mockito.anyLong(), 
Mockito.any(Hypervisor.HypervisorType.class))).thenReturn(Collections.emptyList());
+
Mockito.doNothing().when(storageManager).connectHostToSharedPool(host.getId(), 
pool.getId());
 
 storagePoolMonitor.processConnect(host, cmd, false);
 
 Mockito.verify(storageManager, 
Mockito.times(1)).connectHostToSharedPool(Mockito.eq(host.getId()), 
Mockito.eq(pool.getId()));
 Mockito.verify(storageManager, 
Mockito.times(1)).createCapacityEntry(Mockito.eq(pool.getId()));
 }
 
-@Test(expected = ConnectionException.class)
+@Test
 
 Review comment:
   Yes I suppose. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572376638
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572376440
 
 
   Checked vmware env, on a re-run the failing test passed:
   ```
    Marvin Init Successful 
   === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS ===
   
   === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
   
   === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS ===
   
   ===final results are now copied to: 
/marvin//MarvinLogs/test_deploy_vm_root_resize_DWWKQF===
   ```
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572362343
 
 
   Trillian test result (tid-729)
   Environment: xenserver-74 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34125 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t729-xenserver-74.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 54 look OK, 23 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 0.89 | test_accounts.py
   test_forceDeleteDomain | `Error` | 0.87 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.10 | 
test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.26 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 
| test_deploy_vms_with_varied_deploymentplanners.py
   test_01_1_create_iso_with_checksum_sha1_negative | `Error` | 66.42 | 
test_iso.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.33 | test_iso.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.39 | test_iso.py
   test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.42 | 
test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.36 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.42 | test_iso.py
   test_03_1_create_iso_with_checksum_md5_negative | `Error` | 66.39 | 
test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.35 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.42 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.34 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.41 | test_iso.py
   test_01_create_iso | `Failure` | 1511.48 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3024.18 | test_iso.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | 
test_deploy_vm_with_userdata.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | 
test_diagnostics.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | 
test_loadbalance.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 3.40 | 
test_domain_service_offerings.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | 
test_list_ids_parameter.py
   test_list_vms_metrics | `Error` | 0.11 | test_metrics_api.py
   test_nic_secondaryip_add_remove | `Error` | 0.04 | 
test_multipleips_per_nic.py
   ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | 

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572362343
 
 
   Trillian test result (tid-729)
   Environment: xenserver-74 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34125 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t729-xenserver-74.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 54 look OK, 23 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 0.89 | test_accounts.py
   test_forceDeleteDomain | `Error` | 0.87 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.10 | 
test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.26 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 
| test_deploy_vms_with_varied_deploymentplanners.py
   test_01_1_create_iso_with_checksum_sha1_negative | `Error` | 66.42 | 
test_iso.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.33 | test_iso.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.39 | test_iso.py
   test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.42 | 
test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.36 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.42 | test_iso.py
   test_03_1_create_iso_with_checksum_md5_negative | `Error` | 66.39 | 
test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.35 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.42 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.34 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.41 | test_iso.py
   test_01_create_iso | `Failure` | 1511.48 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3024.18 | test_iso.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | 
test_deploy_vm_with_userdata.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | 
test_diagnostics.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | 
test_loadbalance.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 3.40 | 
test_domain_service_offerings.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | 
test_list_ids_parameter.py
   test_list_vms_metrics | `Error` | 0.11 | test_metrics_api.py
   test_nic_secondaryip_add_remove | `Error` | 0.04 | 
test_multipleips_per_nic.py
   ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | 

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572354224
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-564837655
 
 
   Trillian test result (tid-608)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41552 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t608-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_simulator.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 69 look OK, 8 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1518.23 | 
test_accounts.py
   runTest | `Error` | 0.00 | test_hostha_simulator.py
   test_04_extract_Iso | `Failure` | 1.07 | test_iso.py
   runTest | `Error` | 0.00 | test_outofbandmanagement.py
   test_04_extract_template | `Failure` | 1.06 | test_templates.py
   test_06_download_detached_volume | `Failure` | 10.40 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 369.16 | 
test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3815.17 | 
test_vpc_redundant.py
   runTest | `Error` | 0.00 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd opened a new pull request #3601: [WIP] JDK11 support

[GitBox]

rhtyd opened a new pull request #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601
 
 
   - [x] Make CloudStack build against JDK11 (with -Dmaven.test.skip=true)
   - [x] Run mgmt server, deploy db, work against simulator
   - [x] Upgrade mvn dependencies
   - [x] Fix compatible dependency issue  #3660 #3671 #3672 #3673 #3674 #3675 
#3676 
   - [x] Fix/support JDK11 in systemvmtemplate (make it work)
   - [x] Fix docker container packaging images to have jdk11
   - [x] Use jdk11 compatible mysql-connector via maven, instead of 
distro-provided
   - [x] Fix failing tests and runtime issues against JDK11
   - [x] Ready for smoketest matrix and testing
   
   This splits the Debian10 base/template changes to this PR 
https://github.com/apache/cloudstack/pull/3797
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan removed a comment on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572355050
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-551


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd closed pull request #3601: [WIP] JDK11 support

[GitBox]

rhtyd closed pull request #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572355050
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-551


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3601: [WIP] JDK11 support

[GitBox]

rhtyd commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572354078
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572354224
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3776: Fix HA config keys

[GitBox]

blueorangutan commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572335255
 
 
   Trillian test result (tid-728)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31217 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3776-t728-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] cl-k-takahashi commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.

[GitBox]

cl-k-takahashi commented on issue #3764: Refer pod_ip_range_map table instead 
of host_pod_ref.decription.
URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-572334926
 
 
   @wido Gentle ping...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3601: [WIP] JDK11 support

[GitBox]

blueorangutan commented on issue #3601: [WIP] JDK11 support
URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-572233123
 
 
   Trillian test result (tid-723)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40632 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t723-vmware-65u2.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 71 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_00_deploy_vm_root_resize | `Failure` | 293.62 | 
test_deploy_vm_root_resize.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys

[GitBox]

svenvogel commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572201928
 
 
   @DaanHoogland does we have the time to rebase it to 4.13.0.0 or we need to 
move it in 4.14.0.0?
   
   @mdominka tried it but it seems not easy. @DaanHoogland if you can help us 
how to rebase it and ensure that it will be forward merged into 4.14.0.0? this 
is important for us. 
   
   can you tell us some git commands how to rebase it.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling 
maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572200094
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-550


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

blueorangutan commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-572194887
 
 
   Trillian test result (tid-725)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30081 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3350-t725-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling 
maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572193220
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

nvazquez commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572193033
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling 
maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572191152
 
 
   Packaging result: ✖centos6 ✖centos7 ✔debian. JID-549


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

blueorangutan commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling 
maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572183844
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance

[GitBox]

nvazquez commented on issue #3610: [WIP DO NOT MERGE] KVM: Rolling maintenance
URL: https://github.com/apache/cloudstack/pull/3610#issuecomment-572183496
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3510: Allow additional configuration metadata to VMs

[GitBox]

andrijapanicsb commented on issue #3510: Allow additional configuration 
metadata to VMs
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-572158850
 
 
   
   Test Name | Steps | Expected Result | Status
   -- | -- | -- | --
   Add configuration when not enabled | Make sure that 
enable.additional.vm.configuration   is false and add extra configuration 
following the KVM example bellow. | VM Details are not being updated   
(localcloud)   SBCM5> > update virtualmachine   
id=26f88815-5e08-4ab1-ba0b-15658110ab40    
extraconfig='%3CmemoryBacking%3E%0A%20%20%3Chugepages%2F%3E%0A%3C%2FmemoryBacking%3E'
   filter=details,   {} | Passed
   Enable configuration | Set enable.additional.vm.configuration to True and   
add extra configuration following the KVM example bellow. | User is able to set 
configuration   (localcloud) SBCM5> > update virtualmachine   
id=26f88815-5e08-4ab1-ba0b-15658110ab40    
extraconfig='%3CmemoryBacking%3E%0A%20%20%3Chugepages%2F%3E%0A%3C%2FmemoryBacking%3E'
   filter=details,   {     “details": {       "extraconfig-1":   
"\n    \n"     }, | Passed
   KVM extra config | Deploy a VM and set extra config with the   following api 
call:deploy virtualmachine … 
extraconfig='%3CmemoryBacking%3E%0A%20%20%3Chugepages%2F%3E%0A%3C%2FmemoryBacking%3E'
 | Dump xml the domain on the kvm host and verify   that the extra settings are 
there    virsh   dumpxml 2   …     524288     
524288        
    … | Passed
   VMware extra config | Deploy a VM   Stop the VM   Update the VM with the 
following api command and   start it   update virtualmachine id=[vm-id] 
extraconfig=' hypervisor.cpuid.v0%3DFALSE' | Cat the vmx file on the primary 
storage and   observe that the specific setting is there  cat "$(esxcli vm 
process list \| grep i-2-8-VM   \| tail -1 \| awk '{print $3}')" \| grep -w 
'hypervisor.cpuid.v0 =   "FALSE"'hypervisor.cpuid.v0   = "FALSE" | Passed
   XenServer extra config | Deploy a VM   Stop the VM   Update the VM with the 
following api command and   start it   update virtualmachine id=[vm-id]   
extraconfig=' HVM-boot-policy%3D%0APV-bootloader%3Dpygrub%0APV-args%3Dhvc0' | 
On the Xen host us the ‘xe vm-param-get param-name’   command to get the 
specific parameter and observe it’s been set       xe   vm-param-get 
param-name=PV-bootloader uuid=f5b6ea53-b9dd-d118-a404-582675cc4345 pygrub   
    xe   vm-param-get param-name=PV-args 
uuid=f5b6ea53-b9dd-d118-a404-582675cc4345hvc0 | Passed
   KVM key list restriction | Remove all items from 
allow.additional.vm.configuration.list.kvm   Deploy a VM and set extra config 
with the   following api call:deploy virtualmachine …   
extraconfig='%3CmemoryBacking%3E%0A%20%20%3Chugepages%2F%3E%0A%3C%2FmemoryBacking%3E'
 | Exception appears that the item is not allowed.   Any of the child records 
of that xml node were not added as well       CloudstackAPIException:   Execute 
cmd: deployvirtualmachine failed, due to: errorCode: 530,   errorText:Extra 
config  is not on the   list of allowed keys for KVM hypervisor hosts | Passed
   VMware key list restriction | Remove all items from 
allow.additional.vm.configuration.list.vmware   global setting   Deploy a VM   
Stop the VM   Update the VM with the following api command and   start it   
update virtualmachine id=[vm-id] extraconfig='hypervisor.cpuid.v0%3DFALSE' | 
Exception appears that the item is not allowed.  CloudstackAPIException: 
Execute cmd:   deployvirtualmachine failed, due to: errorCode: 530, 
errorText:Extra config   hypervisor.cpuid.v0=FALSE is not on the list of 
allowed keys for VMware   hypervisor hosts. | Passed
   XenServer key list restriction | Remove all items from 
allow.additional.vm.configuration.list.xenserver   global setting   Deploy a VM 
  Stop the VM   Update the VM with the following api command and   start it   
update virtualmachine id=[vm-id] 
extraconfig='HVM-boot-policy%3D%0APV-bootloader%3Dpygrub%0APV-args%3Dhvc0' | 
Exception appears that the item is not allowed.  CloudstackAPIException: 
Execute cmd:   deployvirtualmachine failed, due to: errorCode: 530, 
errorText:Extra config   HVM-boot-policy= is not on the list of allowed keys 
for XenServer hypervisor   hosts. | Passed
   XenServer key mapping negative | Pass an argument that is not valid as per 
the   given pattern:       Test value:HVM-boot-policy=   
PV-bootloader=pygrub=failure   PV-args=hvc0 | Cloudstack throws an exception 
when validating the   map:       (localcloud)   SBCM5> > update virtualmachine 
id=afeb87cf-5a0a-4807-9c69-8644544ccdf9   
extraconfig=HVM-boot-policy%3D%0APV-bootloader%3Dpygrub%3Dfailure%0APV-args%3Dhvc0
    Error:   (HTTP 530, error code 4250) The passed extra config string 
'HVM-boot-policy=   PV-bootloader=pygrub=failure   PV-args=hvc0'   contains an 
invalid key/value pair pattern | Passed
   Clean extra config data | Stop the VMExecute update VM with 
‘cleanupdetails=true’   argument | Any 

[GitHub] [cloudstack] andrijapanicsb merged pull request #3510: Allow additional configuration metadata to VMs

[GitBox]

andrijapanicsb merged pull request #3510: Allow additional configuration 
metadata to VMs
URL: https://github.com/apache/cloudstack/pull/3510
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (dfd950c -> 70fcf75)

[andrijapanic]

This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from dfd950c  Add protocol number support for security group rules (#3736)
 add 70fcf75  Allow additional configuration metadata to VMs (#3510)

No new revisions were added by this update.

Summary of changes:
 .../api/command/user/vm/DeployVMCmd.java   |   5 +-
 .../api/command/user/vm/UpdateVMCmd.java   |   2 +-
 .../com/cloud/vm/VirtualMachineManagerImpl.java|  22 +-
 .../kvm/resource/LibvirtComputingResource.java |   6 +-
 .../xenserver/resource/CitrixResourceBase.java |  12 +-
 .../xenserver/ExtraConfigurationUtility.java   | 180 +++
 .../main/java/com/cloud/vm/UserVmManagerImpl.java  | 243 -
 .../java/com/cloud/vm/UserVmManagerImplTest.java   |  19 +-
 .../smoke/test_deploy_vm_extra_config_data.py  | 542 +
 9 files changed, 991 insertions(+), 40 deletions(-)
 create mode 100644 
plugins/hypervisors/xenserver/src/main/java/org/apache/cloudstack/hypervisor/xenserver/ExtraConfigurationUtility.java
 create mode 100644 test/integration/smoke/test_deploy_vm_extra_config_data.py

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

DaanHoogland commented on a change in pull request #3350: Get Diagnostics: 
Download logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364334861
 
 

 ##
 File path: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
 ##
 @@ -58,6 +58,30 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 scpTo(host, port, user, pemKeyFile, password, remoteTargetDirectory, 
data, remoteFileName, fileMode, DEFAULT_CONNECT_TIMEOUT, DEFAULT_KEX_TIMEOUT);
 }
 
+public static void scpFrom(String host, int port, String user, File 
permKeyFile, String localTargetDirectory, String remoteTargetFile) throws 
Exception {
 
 Review comment:
   :) yes, but one of my big frustrations (pokemon tirany) is going to last, 
i'm afraid. I agree however it is not one for this PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3783: Create volume or template from snapshot is broken

[GitBox]

DaanHoogland commented on issue #3783: Create volume or template from snapshot 
is broken
URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-572147921
 
 
   @NuxRo, can you give @shwstppr a review on/spin of his patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache closed issue #3044: protocol number support in security group rules

[GitBox]

weizhouapache closed issue #3044: protocol number support in security group 
rules
URL: https://github.com/apache/cloudstack/issues/3044
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3044: protocol number support in security group rules

[GitBox]

weizhouapache commented on issue #3044: protocol number support in security 
group rules
URL: https://github.com/apache/cloudstack/issues/3044#issuecomment-572143373
 
 
   this issue is fixed via #3736


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3776: Fix HA config keys

[GitBox]

blueorangutan commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572139343
 
 
   @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3776: Fix HA config keys

[GitBox]

andrijapanicsb removed a comment on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572134538
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3776: Fix HA config keys

[GitBox]

andrijapanicsb commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572138923
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3776: Fix HA config keys

[GitBox]

andrijapanicsb commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572134538
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] mdominka commented on issue #3776: Fix HA config keys

[GitBox]

mdominka commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572133643
 
 
   when will it be merged?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

blueorangutan commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-572132193
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-548


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

anuragaw commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-572123342
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

blueorangutan commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-572123381
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

anuragaw commented on a change in pull request #3350: Get Diagnostics: Download 
logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364289979
 
 

 ##
 File path: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
 ##
 @@ -58,6 +58,30 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 scpTo(host, port, user, pemKeyFile, password, remoteTargetDirectory, 
data, remoteFileName, fileMode, DEFAULT_CONNECT_TIMEOUT, DEFAULT_KEX_TIMEOUT);
 }
 
+public static void scpFrom(String host, int port, String user, File 
permKeyFile, String localTargetDirectory, String remoteTargetFile) throws 
Exception {
 
 Review comment:
   I think it's going to be large effort to fix this pattern as part of this 
PR. Given the length of time this PR has been kept open and testing already 
done on this code perhaps we can clean up this in a separate PR? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys

[GitBox]

svenvogel commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572119535
 
 
   @andrijapanicsb I can’t call additional test. For me looks good.
   
   
   __
   
   Sven Vogel
   Teamlead Platform
   
   EWERK DIGITAL GmbH
   Brühl 24, D-04109 Leipzig
   P +49 341 42649 - 99
   F +49 341 42649 - 98
   s.vo...@ewerk.com
   www.ewerk.com
   
   Geschäftsführer:
   Dr. Erik Wende, Hendrik Schubert, Frank Richter
   Registergericht: Leipzig HRB 9065
   
   Support:
   +49 341 42649 555
   
   Zertifiziert nach:
   ISO/IEC 27001:2013
   DIN EN ISO 9001:2015
   DIN ISO/IEC 2-1:2011
   
   ISAE 3402 Typ II Assessed
   
   EWERK-Blog | 
LinkedIn | 
Xing | 
Twitter | 
Facebook
   
   Mit Handelsregistereintragung vom 09.07.2019 ist die EWERK RZ GmbH auf die 
EWERK IT GmbH verschmolzen und firmiert nun gemeinsam unter dem Namen: EWERK 
DIGITAL GmbH, für weitere Informationen klicken Sie 
hier.
   
   Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
   
   Disclaimer Privacy:
   Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist 
vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der 
bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, 
Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte 
informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die 
E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen 
Dank.
   
   The contents of this e-mail (including any attachments) are confidential and 
may be legally privileged. If you are not the intended recipient of this 
e-mail, any disclosure, copying, distribution or use of its contents is 
strictly prohibited, and you should please notify the sender immediately and 
then delete it (including any attachments) from your system. Thank you.
   
   Am 03.01.2020 um 22:41 schrieb Andrija Panic :
   
   
   
   @blueorangutan package
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys

[GitBox]

svenvogel commented on issue #3776: Fix HA config keys
URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-572118023
 
 
   @andrijapanicsb so we need additional 
test or can we merge it?
   
   
   __
   
   Sven Vogel
   Teamlead Platform
   
   EWERK DIGITAL GmbH
   Brühl 24, D-04109 Leipzig
   P +49 341 42649 - 99
   F +49 341 42649 - 98
   s.vo...@ewerk.com
   www.ewerk.com
   
   Geschäftsführer:
   Dr. Erik Wende, Hendrik Schubert, Frank Richter
   Registergericht: Leipzig HRB 9065
   
   Support:
   +49 341 42649 555
   
   Zertifiziert nach:
   ISO/IEC 27001:2013
   DIN EN ISO 9001:2015
   DIN ISO/IEC 2-1:2011
   
   ISAE 3402 Typ II Assessed
   
   EWERK-Blog | 
LinkedIn | 
Xing | 
Twitter | 
Facebook
   
   Mit Handelsregistereintragung vom 09.07.2019 ist die EWERK RZ GmbH auf die 
EWERK IT GmbH verschmolzen und firmiert nun gemeinsam unter dem Namen: EWERK 
DIGITAL GmbH, für weitere Informationen klicken Sie 
hier.
   
   Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
   
   Disclaimer Privacy:
   Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist 
vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der 
bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, 
Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte 
informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die 
E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen 
Dank.
   
   The contents of this e-mail (including any attachments) are confidential and 
may be legally privileged. If you are not the intended recipient of this 
e-mail, any disclosure, copying, distribution or use of its contents is 
strictly prohibited, and you should please notify the sender immediately and 
then delete it (including any attachments) from your system. Thank you.
   
   Am 03.01.2020 um 22:41 schrieb Andrija Panic :
   
   
   
   @blueorangutan package
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (f2708d6 -> dfd950c)

[andrijapanic]

This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from f2708d6  Merge release branch 4.13 to master
 add dfd950c  Add protocol number support for security group rules (#3736)

No new revisions were added by this update.

Summary of changes:
 .../AuthorizeSecurityGroupIngressCmd.java  |   2 +-
 scripts/vm/network/security_group.py   |  21 +-
 .../network/security/SecurityGroupManagerImpl.java |  33 +-
 .../test_protocol_number_security_group.py | 460 +
 ui/scripts/network.js  | 114 -
 5 files changed, 608 insertions(+), 22 deletions(-)
 create mode 100644 
test/integration/component/test_protocol_number_security_group.py

[GitHub] [cloudstack] andrijapanicsb merged pull request #3736: Add protocol number support for security group rules

[GitBox]

andrijapanicsb merged pull request #3736: Add protocol number support for 
security group rules
URL: https://github.com/apache/cloudstack/pull/3736
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

anuragaw commented on a change in pull request #3350: Get Diagnostics: Download 
logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364276834
 
 

 ##
 File path: 
server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
 ##
 @@ -126,10 +185,336 @@ protected String prepareShellCmd(String cmdType, String 
ipAddress, String option
 }
 }
 
+private String zipFilesInSystemVm(VMInstanceVO vmInstance, List 
optionalFilesList) {
+List fileList = getFileListToBeRetrieved(optionalFilesList, 
vmInstance);
+
+if (CollectionUtils.isEmpty(fileList)) {
+throw new CloudRuntimeException("Failed to generate diagnostics 
file list for retrieval.");
+}
+
+final Answer zipFilesAnswer = 
prepareDiagnosticsFilesInSystemVm(vmInstance, fileList);
+
+if (zipFilesAnswer == null) {
+throw new CloudRuntimeException(String.format("Failed to generate 
diagnostics zip file in the system VM %s", vmInstance.getUuid()));
+}
+
+if (!zipFilesAnswer.getResult()) {
+throw new CloudRuntimeException(String.format("Failed to generate 
diagnostics zip file in VM %s due to: %s", vmInstance.getUuid(), 
zipFilesAnswer.getDetails()));
+}
+
+return zipFilesAnswer.getDetails().replace("\n", "");
+}
+
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_SYSTEM_VM_DIAGNOSTICS, 
eventDescription = "getting diagnostics files on system vm", async = true)
+public String getDiagnosticsDataCommand(GetDiagnosticsDataCmd cmd) {
+final Long vmId = cmd.getId();
+final List optionalFilesList = cmd.getFilesList();
+final VMInstanceVO vmInstance = getSystemVMInstance(vmId);
+final DataStore store = getImageStore(vmInstance.getDataCenterId());
+
+final String zipFileInSystemVm = zipFilesInSystemVm(vmInstance, 
optionalFilesList);
+final Long vmHostId = vmInstance.getHostId();
+copyZipFileToSecondaryStorage(vmInstance, vmHostId, zipFileInSystemVm, 
store);
+deleteDiagnosticsZipFileInsystemVm(vmInstance, zipFileInSystemVm);
+
+// Now we need to create the file download URL
+// Find ssvm of store
+final long zoneId = vmInstance.getDataCenterId();
+VMInstanceVO ssvm = getSecondaryStorageVmInZone(zoneId);
+if (ssvm == null) {
+throw new CloudRuntimeException("No SSVM found in zone with ID: " 
+ zoneId);
+}
+
+// Secondary Storage install path = 
"diagnostics_data/diagnostics_files_.tar
+String installPath = DIAGNOSTICS_DIRECTORY + File.separator + 
zipFileInSystemVm.replace("/root", "");
+return createFileDownloadUrl(store, ssvm.getHypervisorType(), 
installPath);
+}
+
+/**
+ * Copy retrieved diagnostics zip file from system vm to secondary storage
+ * For VMware use the mgmt server, and for Xen/KVM use the hyperhost of 
the target VM
+ * The strategy is to mount secondary storage on mgmt server or host and 
scp directly to /mnt/SecStorage/diagnostics_data
+ *
+ * @param fileToCopy zip file in system vm to be copied
+ * @param store  secondary storage to copy zip file to
+ */
+private Pair copyZipFileToSecondaryStorage(VMInstanceVO 
vmInstance, Long vmHostId, String fileToCopy, DataStore store) {
+String vmControlIp = getVMSshIp(vmInstance);
+if (StringUtils.isBlank(vmControlIp)) {
+return new Pair<>(false, "Unable to find system vm ssh/control IP 
for  vm with ID: " + vmInstance.getId());
+}
+Pair copyResult;
+if (vmInstance.getHypervisorType() == 
Hypervisor.HypervisorType.VMware) {
+copyResult = orchestrateCopyToSecondaryStorageVMware(store, 
vmControlIp, fileToCopy);
+} else {
+copyResult = orchestrateCopyToSecondaryStorageNonVMware(store, 
vmControlIp, fileToCopy, vmHostId);
+}
+
+if (!copyResult.first()) {
+throw new CloudRuntimeException(String.format("Failed to copy %s 
to secondary storage %s due to: %s.", fileToCopy, store.getUri(), 
copyResult.second()));
+}
+
+return copyResult;
+}
+
+private void configureNetworkElementCommand(NetworkElementCommand cmd, 
VMInstanceVO vmInstance) {
+Map accessDetails = 
networkManager.getSystemVMAccessDetails(vmInstance);
+if 
(StringUtils.isBlank(accessDetails.get(NetworkElementCommand.ROUTER_IP))) {
+throw new CloudRuntimeException("Unable to set system vm ControlIP 
for system vm with ID: " + vmInstance.getId());
+}
+cmd.setAccessDetail(accessDetails);
+}
+
+private Answer prepareDiagnosticsFilesInSystemVm(VMInstanceVO vmInstance, 
List fileList) {
+final PrepareFilesCommand cmd = new PrepareFilesCommand(fileList, 
DataRetrievalTimeout.value());
+configureNetworkElementCommand(cmd, 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

DaanHoogland commented on a change in pull request #3350: Get Diagnostics: 
Download logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364275273
 
 

 ##
 File path: 
server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
 ##
 @@ -126,10 +185,336 @@ protected String prepareShellCmd(String cmdType, String 
ipAddress, String option
 }
 }
 
+private String zipFilesInSystemVm(VMInstanceVO vmInstance, List 
optionalFilesList) {
+List fileList = getFileListToBeRetrieved(optionalFilesList, 
vmInstance);
+
+if (CollectionUtils.isEmpty(fileList)) {
+throw new CloudRuntimeException("Failed to generate diagnostics 
file list for retrieval.");
+}
+
+final Answer zipFilesAnswer = 
prepareDiagnosticsFilesInSystemVm(vmInstance, fileList);
+
+if (zipFilesAnswer == null) {
+throw new CloudRuntimeException(String.format("Failed to generate 
diagnostics zip file in the system VM %s", vmInstance.getUuid()));
+}
+
+if (!zipFilesAnswer.getResult()) {
+throw new CloudRuntimeException(String.format("Failed to generate 
diagnostics zip file in VM %s due to: %s", vmInstance.getUuid(), 
zipFilesAnswer.getDetails()));
+}
+
+return zipFilesAnswer.getDetails().replace("\n", "");
+}
+
+@Override
+@ActionEvent(eventType = EventTypes.EVENT_SYSTEM_VM_DIAGNOSTICS, 
eventDescription = "getting diagnostics files on system vm", async = true)
+public String getDiagnosticsDataCommand(GetDiagnosticsDataCmd cmd) {
+final Long vmId = cmd.getId();
+final List optionalFilesList = cmd.getFilesList();
+final VMInstanceVO vmInstance = getSystemVMInstance(vmId);
+final DataStore store = getImageStore(vmInstance.getDataCenterId());
+
+final String zipFileInSystemVm = zipFilesInSystemVm(vmInstance, 
optionalFilesList);
+final Long vmHostId = vmInstance.getHostId();
+copyZipFileToSecondaryStorage(vmInstance, vmHostId, zipFileInSystemVm, 
store);
+deleteDiagnosticsZipFileInsystemVm(vmInstance, zipFileInSystemVm);
+
+// Now we need to create the file download URL
+// Find ssvm of store
+final long zoneId = vmInstance.getDataCenterId();
+VMInstanceVO ssvm = getSecondaryStorageVmInZone(zoneId);
+if (ssvm == null) {
+throw new CloudRuntimeException("No SSVM found in zone with ID: " 
+ zoneId);
+}
+
+// Secondary Storage install path = 
"diagnostics_data/diagnostics_files_.tar
+String installPath = DIAGNOSTICS_DIRECTORY + File.separator + 
zipFileInSystemVm.replace("/root", "");
+return createFileDownloadUrl(store, ssvm.getHypervisorType(), 
installPath);
+}
+
+/**
+ * Copy retrieved diagnostics zip file from system vm to secondary storage
+ * For VMware use the mgmt server, and for Xen/KVM use the hyperhost of 
the target VM
+ * The strategy is to mount secondary storage on mgmt server or host and 
scp directly to /mnt/SecStorage/diagnostics_data
+ *
+ * @param fileToCopy zip file in system vm to be copied
+ * @param store  secondary storage to copy zip file to
+ */
+private Pair copyZipFileToSecondaryStorage(VMInstanceVO 
vmInstance, Long vmHostId, String fileToCopy, DataStore store) {
+String vmControlIp = getVMSshIp(vmInstance);
+if (StringUtils.isBlank(vmControlIp)) {
+return new Pair<>(false, "Unable to find system vm ssh/control IP 
for  vm with ID: " + vmInstance.getId());
+}
+Pair copyResult;
+if (vmInstance.getHypervisorType() == 
Hypervisor.HypervisorType.VMware) {
+copyResult = orchestrateCopyToSecondaryStorageVMware(store, 
vmControlIp, fileToCopy);
+} else {
+copyResult = orchestrateCopyToSecondaryStorageNonVMware(store, 
vmControlIp, fileToCopy, vmHostId);
+}
+
+if (!copyResult.first()) {
+throw new CloudRuntimeException(String.format("Failed to copy %s 
to secondary storage %s due to: %s.", fileToCopy, store.getUri(), 
copyResult.second()));
+}
+
+return copyResult;
+}
+
+private void configureNetworkElementCommand(NetworkElementCommand cmd, 
VMInstanceVO vmInstance) {
+Map accessDetails = 
networkManager.getSystemVMAccessDetails(vmInstance);
+if 
(StringUtils.isBlank(accessDetails.get(NetworkElementCommand.ROUTER_IP))) {
+throw new CloudRuntimeException("Unable to set system vm ControlIP 
for system vm with ID: " + vmInstance.getId());
+}
+cmd.setAccessDetail(accessDetails);
+}
+
+private Answer prepareDiagnosticsFilesInSystemVm(VMInstanceVO vmInstance, 
List fileList) {
+final PrepareFilesCommand cmd = new PrepareFilesCommand(fileList, 
DataRetrievalTimeout.value());
+configureNetworkElementCommand(cmd, 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

DaanHoogland commented on a change in pull request #3350: Get Diagnostics: 
Download logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#discussion_r364273757
 
 

 ##
 File path: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java
 ##
 @@ -58,6 +58,30 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 scpTo(host, port, user, pemKeyFile, password, remoteTargetDirectory, 
data, remoteFileName, fileMode, DEFAULT_CONNECT_TIMEOUT, DEFAULT_KEX_TIMEOUT);
 }
 
+public static void scpFrom(String host, int port, String user, File 
permKeyFile, String localTargetDirectory, String remoteTargetFile) throws 
Exception {
 
 Review comment:
   there is no issue with this PR but the SshHelper methods throwing a generic 
```Exception``` is not a good pattern. At least it should be a 
SshHelper-specific wrapper :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] NuxRo commented on issue #3783: Create volume or template from snapshot is broken

[GitBox]

NuxRo commented on issue #3783: Create volume or template from snapshot is 
broken
URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-572106504
 
 
   Definitely a case of #3716 for the template from snapshot issue, thanks. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3783: Create volume or template from snapshot is broken

[GitBox]

DaanHoogland commented on issue #3783: Create volume or template from snapshot 
is broken
URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-572103803
 
 
   @NuxRo sounds like a known bug addressed in #3767/#3723. can you check? 
issue #3716


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3647: fresh install 4.13.3 systemvm template fails to be recognized during upgrade

[GitBox]

DaanHoogland commented on issue #3647: fresh install 4.13.3 systemvm template 
fails to be recognized during upgrade
URL: https://github.com/apache/cloudstack/issues/3647#issuecomment-572068763
 
 
   @borisstoyanov as no one else reported this, is this an incident or a 
consistent error?
   
   Note: i saw no/missing schema-xxxtoyyy.sql files for the upgrade in any 
version branch


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

[GitBox]

DaanHoogland commented on issue #3477: RvR: Set up metadata/password/dhcp 
server on gateway IP instead of guest IP in RVR
URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-572067866
 
 
   @rhtyd @andrijapanicsb differnet errors at different environments above. as 
this had been reviewed and tested before, do we spend more time investigating?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland closed issue #3544: When scrolling down the VM settings, they keep on loading again and again endlessly

[GitBox]

DaanHoogland closed issue #3544: When scrolling down the VM settings, they keep 
on loading again and again endlessly
URL: https://github.com/apache/cloudstack/issues/3544
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (7ceb82c -> f2708d6)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 7ceb82c  Revert "Simulator: Better VR Redundant Status Behaviour 
(#3313)" (#3796)
 add 005019b  Endless settings on templates and instances (#3778)
 add f2708d6  Merge release branch 4.13 to master

No new revisions were added by this update.

Summary of changes:
 ui/scripts/instances.js | 7 +++
 ui/scripts/templates.js | 7 +++
 2 files changed, 14 insertions(+)

[GitHub] [cloudstack] DaanHoogland commented on issue #3544: When scrolling down the VM settings, they keep on loading again and again endlessly

[GitBox]

DaanHoogland commented on issue #3544: When scrolling down the VM settings, 
they keep on loading again and again endlessly
URL: https://github.com/apache/cloudstack/issues/3544#issuecomment-572063578
 
 
   merged in 4.13 and master


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.13 updated: Endless settings on templates and instances (#3778)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.13 by this push:
 new 005019b  Endless settings on templates and instances (#3778)
005019b is described below

commit 005019b0e6e13b3bbc97bfa7852813923c91bb2a
Author: Spaceman1984 <49917670+spaceman1...@users.noreply.github.com>
AuthorDate: Wed Jan 8 15:48:23 2020 +0200

Endless settings on templates and instances (#3778)

* Endless settings on templates and instances

* Removed unintentionaly committed file

* Fix indentation

Co-authored-by: Anurag Awasthi 
---
 ui/scripts/instances.js | 7 +++
 ui/scripts/templates.js | 7 +++
 2 files changed, 14 insertions(+)

diff --git a/ui/scripts/instances.js b/ui/scripts/instances.js
index 3e54a77..6d7e26f 100644
--- a/ui/scripts/instances.js
+++ b/ui/scripts/instances.js
@@ -3433,6 +3433,13 @@
custom: 
cloudStack.uiCustom.granularDetails({
 resourceType: 'UserVm',
dataProvider: 
function(args) {
+   // no paging for 
listVirtualMachines details
+   if (args.page > 1) {
+   
args.response.success({
+   data: []
+   });
+   return;
+   }
$.ajax({
url: 
createURL('listVirtualMachines=' + args.context.instances[0].id),

success: function(json) {
diff --git a/ui/scripts/templates.js b/ui/scripts/templates.js
index d15a2c1..9216733 100644
--- a/ui/scripts/templates.js
+++ b/ui/scripts/templates.js
@@ -2489,6 +2489,13 @@
custom: 
cloudStack.uiCustom.granularDetails({
 resourceType: 'Template',

dataProvider: function(args) {
+   // 
no paging for listTemplates details
+   if 
(args.page > 1) {
+   
args.response.success({
+   
data: []
+   
});
+   
return;
+   }

$.ajax({

url: createURL('listTemplates'),

data: {

[GitHub] [cloudstack] DaanHoogland merged pull request #3778: Endless settings on templates and instances

[GitBox]

DaanHoogland merged pull request #3778: Endless settings on templates and 
instances
URL: https://github.com/apache/cloudstack/pull/3778
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3778: Endless settings on templates and instances

[GitBox]

DaanHoogland commented on issue #3778: Endless settings on templates and 
instances
URL: https://github.com/apache/cloudstack/pull/3778#issuecomment-572060222
 
 
   ui issue and 2 approvals, will merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes 
Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-572045685
 
 
   @poussa glad you were able to get deployment working.
   Will fix the bug for noderootdisksize


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] poussa commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

poussa commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes 
Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-572043616
 
 
   @shwstppr Bug: You need to give non-mandatory `noderootdisksize` parameter 
in `cmk create kubernetescluster` (also in UI). Otherwise the system will 
return 503 and log entry:
   
   ```bash
   Jan 08 15:00:53 skull java[11443]: java.lang.NullPointerException
   Jan 08 15:00:53 skull java[11443]: at 
com.cloud.kubernetescluster.KubernetesClusterManagerImpl.validateKubernetesClusterCreatePrameters(KubernetesClusterManagerImpl.java:2022)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] poussa commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

poussa commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes 
Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-572033194
 
 
   @shwstppr Ubuntu firewall (ufw) was on and blocking my host network traffic. 
Once I turned it off I am able to create the cluster. It is now up and running 
and I can manage it via kubectl. Thanks for your help. 
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] NuxRo commented on issue #3783: Create volume or template from snapshot is broken

[GitBox]

NuxRo commented on issue #3783: Create volume or template from snapshot is 
broken
URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-572017571
 
 
   Here's a log containing (among others, sorry for verbosity) the output when 
create volume from snapshot fails.
   http://tmp.nux.ro/acsuifail.log
   
   Nothing happens in the logs when I try to create a template from the 
snapshot, it's like the button has no action linked to it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364173501
 
 

 ##
 File path: 
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDaoImpl.java
 ##
 @@ -54,9 +57,12 @@ protected NetworkOfferingJoinDaoImpl() {
 }
 
 @Override
-public List findByZoneId(long zoneId) {
+public List findByZoneId(long zoneId, Boolean 
includeAllZoneOffering) {
 SearchBuilder sb = createSearchBuilder();
 sb.and("zoneId", sb.entity().getZoneId(), 
SearchCriteria.Op.FIND_IN_SET);
+if (includeAllZoneOffering) {
+sb.or("zId", sb.entity().getZoneId(), SearchCriteria.Op.NULL);
+}
 
 Review comment:
   the idea is zId in set or null?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364173167
 
 

 ##
 File path: 
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDaoImpl.java
 ##
 @@ -43,9 +43,12 @@ protected NetworkOfferingJoinDaoImpl() {
 }
 
 @Override
-public List findByDomainId(long domainId) {
+public List findByDomainId(long domainId, Boolean 
includeAllDomainOffering) {
 SearchBuilder sb = createSearchBuilder();
 sb.and("domainId", sb.entity().getDomainId(), 
SearchCriteria.Op.FIND_IN_SET);
+if (includeAllDomainOffering) {
+sb.or("zId", sb.entity().getZoneId(), SearchCriteria.Op.NULL);
+}
 
 Review comment:
   so if we include "all domain offerings" the zone is allowed to be null?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364173114
 
 

 ##
 File path: 
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDao.java
 ##
 @@ -27,9 +27,9 @@
 
 public interface NetworkOfferingJoinDao extends 
GenericDao {
 
-List findByDomainId(long domainId);
+List findByDomainId(long domainId, Boolean 
includeAllDomainOffering);
 
 Review comment:
   can you please add javadoc to explain the parameters here. I found them not 
to be intuitive with the implementation in the dao impl


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364162651
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.NetworkOfferingJoinDao;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.NetworkOfferingJoinVO;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364162872
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.NetworkOfferingJoinDao;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.NetworkOfferingJoinVO;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364161878
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.NetworkOfferingJoinDao;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.NetworkOfferingJoinVO;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364162048
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.NetworkOfferingJoinDao;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.NetworkOfferingJoinVO;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364159675
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3061 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.VlanDao;
+import 

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3798: Fixed volume stats

[GitBox]

Spaceman1984 opened a new pull request #3798: Fixed volume stats
URL: https://github.com/apache/cloudstack/pull/3798
 
 
   ## Description
   
   This fixes a bug where the volume statistics for the physical size is 
incorrect
   
   
   
   
   
   
   Fixes: #3416 
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   This was tested by verifying that the vmdk file size in vcenter corresponds 
to the physical volume size in the ui of the management server. Please note 
that vcenter displays kilobytes where 
   Cloudstack management server displays kibibytes.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364147407
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3061 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.VlanDao;
+import 

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

shwstppr commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364098123
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3061 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.VlanDao;
+import 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364144182
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3061 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.VlanDao;
+import 

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

[GitBox]

DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE] 
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364143753
 
 

 ##
 File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetescluster/KubernetesClusterManagerImpl.java
 ##
 @@ -0,0 +1,3061 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.kubernetescluster;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.Socket;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import javax.inject.Inject;
+import javax.naming.ConfigurationException;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.acl.SecurityChecker;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.firewall.CreateFirewallRuleCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.CreateKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.DeleteKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.GetKubernetesClusterConfigCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ListKubernetesClustersCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.ScaleKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StartKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.StopKubernetesClusterCmd;
+import 
org.apache.cloudstack.api.command.user.kubernetescluster.UpgradeKubernetesClusterCmd;
+import org.apache.cloudstack.api.command.user.vm.StartVMCmd;
+import org.apache.cloudstack.api.response.KubernetesClusterConfigResponse;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.ca.CAManager;
+import org.apache.cloudstack.context.CallContext;
+import 
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import 
org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
+import org.apache.cloudstack.framework.ca.Certificate;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.utils.security.CertUtils;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.dao.TemplateJoinDao;
+import com.cloud.api.query.vo.TemplateJoinVO;
+import com.cloud.capacity.CapacityManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.ClusterDetailsVO;
+import com.cloud.dc.ClusterVO;
+import com.cloud.dc.DataCenter;
+import com.cloud.dc.DataCenterVO;
+import com.cloud.dc.Pod;
+import com.cloud.dc.Vlan;
+import com.cloud.dc.VlanVO;
+import com.cloud.dc.dao.ClusterDao;
+import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.VlanDao;
+import 

[GitHub] [cloudstack] shwstppr commented on issue #3783: Create volume or template from snapshot is broken

[GitBox]

shwstppr commented on issue #3783: Create volume or template from snapshot is 
broken
URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-571972002
 
 
   @NuxRo can you please share logs or screenshot of the error you are getting 
with web UI


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] shwstppr commented on issue #3791: [WIP] server: fix checking disk offering access for snapshot volume

[GitBox]

shwstppr commented on issue #3791: [WIP] server: fix checking disk offering 
access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-571971519
 
 
   @DaanHoogland didn't know that, will keep in mind for future. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox]

blueorangutan commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-571966545
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services