[GitHub] [cloudstack] harikrishna-patnala commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
harikrishna-patnala commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-610191309 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-610170060 Packaging result: ✔centos7 ✔debian. JID-1137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-610164019 @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] harikrishna-patnala commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
harikrishna-patnala commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-610163841 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610149382 @DaanHoogland @andrijapanicsb please ignore the previous test results. The issues that I got were related with SSVM not working (VM running, but agent was down). Therefore, those failures when deleting snapshot on secondary storage are not related with this PR. The fact that the deletion worked without any exception even with SSVM failing to delete de snapshot on secondary is a problem. It could lead to snapshot garbage issue on secondary storage. But that is not critical and we can (should) leave such issue for a future release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610143513 I did a few tests and it does not delete on secondary storage. Tests considered the following scenarios (with `snapshot.backup.to.secondary=TRUE`): 1. KVM + Ceph (primary) & NFS (scondary). Result: snapshot deleted properly on primary storage; snapshot stays on secondary. The snapshot state is Ready at table `snapshot_store_ref`. 2. KVM + NFS (primary & secondary). Result: snapshot deleted properly on primary storage; snapshot stays on secondary. The snapshot state is Destroying at table `snapshot_store_ref`. I am debugging and re-checking previous commits to find at which point this stopped working. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console integration
blueorangutan commented on issue #3967: noVNC console integration URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-610095506 Trillian test result (tid-1369) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36627 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3967-t1369-kvm-centos7.zip Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] tobin-landricombe commented on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
tobin-landricombe commented on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-610079741 With these two fixes plus hacking the correct mysql connectors in, my latest attempt is showing System VMs Agent State as "Up". Still no templates listed so I haven't actually started a VM yet but that can wait until tomorrow. Thanks, @Spaceman1984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610078296 Trillian test result (tid-1366) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37855 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3969-t1366-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 317.01 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 299.80 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 455.71 | test_privategw_acl.py test_11_migrate_vm | `Error` | 50.84 | test_vm_life_cycle.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4020: server: move UpdateDefaultNic to vm work job queue
ustcweizhou opened a new pull request #4020: server: move UpdateDefaultNic to vm work job queue URL: https://github.com/apache/cloudstack/pull/4020 ## Description While remove secondary nic from a Running vm, if update the default nic to the secondary nic before the nic is removed, the vm will not have default nic (and cannot be started) when both operations are completed. It is because UpdateDefaultNic api is not handled as a vm work job (AddNicToVMCmd and RemoveNicFromVMCmd are), it is processed before nic is removed. The result is that secondary nic becomes default nic and got removed. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? 1. remove secondary nic from a Running vm 2. update default nic to the secondary nic before step 1 is finished. 3. got an exception as below.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610024472 Trillian test result (tid-1365) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31944 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3969-t1365-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 185.43 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 220.51 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 280.49 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610019986 not gonna run ANY test or package rebuild after the last commit - a single word was changed in the comment/logging (from "backup" to "secondary") This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch snapshot-deletion-issues updated (20cb0b2 -> 0aa1190)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch snapshot-deletion-issues in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 20cb0b2 != instead of == add 0aa1190 secondary instead of backup storage No new revisions were added by this update. Summary of changes: .../org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3969: Snapshot deletion issues
andrijapanicsb edited a comment on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610018095 Tested the latest commit - to confirm proper logging: ## snapshot.backup.to.secondary=TRUE ### Normal case - 2 rows present, for both IMAGE/PRIMARY > 2020-04-06 20:14:44,739 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-2:ctx-4eecdad6 job-420 ctx-67c357b4) (logid:a8e3d3a0) Successfully deleted snapshot (id: 48) on primary storage. > 2020-04-06 20:14:44,739 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-2:ctx-4eecdad6 job-420 ctx-67c357b4) (logid:a8e3d3a0) Successfully deleted snapshot (id: 48) on secondary storage. ### case 1 - PRIMARY row manually removed from snapshot_store_ref table - only the IMAGE rows present (not normal, or otherwise possible to happen on it's own) > 2020-04-06 20:16:27,982 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) Snapshot (id: 49) **has been deleted on secondary storage.** > 2020-04-06 20:16:27,985 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) The snapshot (id: 49) **could not be found/deleted on primary storage.** > 2020-04-06 20:16:27,985 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) Successfully deleted snapshot (id: 49) on secondary storage. (and GC removed the IMAGE row - so all good, didn't break or something) ### case 2 - I removed manually the IMAGE row from snap_store_ref, only PRIMARY left > 2020-04-06 20:18:27,146 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-6:ctx-fd12e158 job-426 ctx-30f38c9c) (logid:13bbc143) Can't find snapshot [snapshot id: 50] on backup storage > ... > 2020-04-06 20:18:27,475 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-6:ctx-fd12e158 job-426 ctx-30f38c9c) (logid:13bbc143) Successfully deleted snapshot (id: 50) on primary storage. So all good. @GabrielBrascher after your testing, if you are happy, I plan to merge this one and shift any outstanding (DB garbage for PRIMARY in snap_store_ref) to a new use #4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610018095 Tested the latest commit - to confirm proper logging: ## snapshot.backup.to.secondary=TRUE ### Normal case - 2 rows present, for both IMAGE/PRIMARY > 2020-04-06 20:14:44,739 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-2:ctx-4eecdad6 job-420 ctx-67c357b4) (logid:a8e3d3a0) Successfully deleted snapshot (id: 48) on primary storage. > 2020-04-06 20:14:44,739 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-2:ctx-4eecdad6 job-420 ctx-67c357b4) (logid:a8e3d3a0) Successfully deleted snapshot (id: 48) on secondary storage. ### case 1 - PRIMARY row manually removed from snapshot_store_ref table - only the IMAGE rows present (not normal, or otherwise possible to happen on it's own) > 2020-04-06 20:16:27,982 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) Snapshot (id: 49) **has been deleted on secondary storage.** > 2020-04-06 20:16:27,985 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) The snapshot (id: 49) **could not be found/deleted on primary storage.** > 2020-04-06 20:16:27,985 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) Successfully deleted snapshot (id: 49) on secondary storage. (and GC removed the IMAGE row - so all good, didn't break or something) ### case 2 - I removed manually the IMAGE row from snap_store_ref, only PRIMARY left 2020-04-06 20:18:27,146 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-6:ctx-fd12e158 job-426 ctx-30f38c9c) (logid:13bbc143) Can't find snapshot [snapshot id: 50] on backup storage ... 2020-04-06 20:18:27,475 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-6:ctx-fd12e158 job-426 ctx-30f38c9c) (logid:13bbc143) Successfully deleted snapshot (id: 50) on primary storage. So all good. @GabrielBrascher after your testing, if you are happy, I plan to merge this one and shift any outstanding (DB garbage for PRIMARY in snap_store_ref) to a new use #4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4019: server: Move restoreVM to vm work job queue
ustcweizhou opened a new pull request #4019: server: Move restoreVM to vm work job queue URL: https://github.com/apache/cloudstack/pull/4019 ## Description When restore a Running vm twice, the vm cannot be started. Steps to reproduce the issue (1) deploy a vm (2) restore the vm twice by cloudmonkey cloudmonkey restore virtualmachine virtualmachineid= & cloudmonkey restore virtualmachine virtualmachineid=& The vm cannot be restarted again as there are two ROOT volumes.  ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? Same steps succeed with this PR (the vm will be restored twice). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3936: [HEALTH][master/4.14] Health Check Run
blueorangutan commented on issue #3936: [HEALTH][master/4.14] Health Check Run URL: https://github.com/apache/cloudstack/pull/3936#issuecomment-610016485 Packaging result: ✔centos7 ✔debian. JID-1136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610009843 Packaging result: ✔centos7 ✔debian. JID-1135 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-610008516 thanks @andrijapanicsb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4014: Improvement on build time and new quality profile
andrijapanicsb commented on issue #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014#issuecomment-610007647 Anyone OK with this one? I can't really comment on anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-610006944 3 x LGTM, automated tests fine (3 known issues in 4,13, fixed in 4,14), manual tests fine Merging This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb merged pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
andrijapanicsb merged pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed (#4002)
This is an automated email from the ASF dual-hosted git repository.
andrijapanic pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 6bf92fb server: Search zone-wide storage pool when allocation
algothrim is firstfitleastconsumed (#4002)
6bf92fb is described below
commit 6bf92fb13620b56a1d644840a42cd2590a4f4131
Author: Wei Zhou
AuthorDate: Mon Apr 6 22:01:40 2020 +0200
server: Search zone-wide storage pool when allocation algothrim is
firstfitleastconsumed (#4002)
---
.../java/com/cloud/capacity/dao/CapacityDao.java | 2 +-
.../com/cloud/capacity/dao/CapacityDaoImpl.java| 22 +
.../allocator/AbstractStoragePoolAllocator.java| 3 +-
.../allocator/ZoneWideStoragePoolAllocator.java| 38 ++
.../manager/allocator/impl/FirstFitAllocator.java | 3 +-
5 files changed, 58 insertions(+), 10 deletions(-)
diff --git
a/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java
b/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java
index fcccd56..f2735b8 100644
--- a/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java
+++ b/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java
@@ -56,5 +56,5 @@ public interface CapacityDao extends GenericDao {
float findClusterConsumption(Long clusterId, short capacityType, long
computeRequested);
-List orderHostsByFreeCapacity(Long clusterId, short capacityType);
+List orderHostsByFreeCapacity(Long zoneId, Long clusterId, short
capacityType);
}
diff --git
a/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
b/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
index 5b14bd4..72d5b07 100644
--- a/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
@@ -903,20 +903,28 @@ public class CapacityDaoImpl extends
GenericDaoBase implements
}
@Override
-public List orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+public List orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
TransactionLegacy txn = TransactionLegacy.currentTxn();
PreparedStatement pstmt = null;
List result = new ArrayList();
StringBuilder sql = new
StringBuilder(ORDER_HOSTS_BY_FREE_CAPACITY_PART1);
-if(clusterId != null) {
-sql.append("AND cluster_id = ?");
-}
-sql.append(ORDER_HOSTS_BY_FREE_CAPACITY_PART2);
+ if (zoneId != null) {
+ sql.append(" AND data_center_id = ?");
+ }
+ if (clusterId != null) {
+ sql.append(" AND cluster_id = ?");
+ }
+ sql.append(ORDER_HOSTS_BY_FREE_CAPACITY_PART2);
try {
pstmt = txn.prepareAutoCloseStatement(sql.toString());
pstmt.setShort(1, capacityTypeForOrdering);
- if(clusterId != null) {
-pstmt.setLong(2, clusterId);
+ int index = 2;
+ if (zoneId != null) {
+ pstmt.setLong(index, zoneId);
+ index ++;
+ }
+ if (clusterId != null) {
+ pstmt.setLong(index, clusterId);
}
ResultSet rs = pstmt.executeQuery();
diff --git
a/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
b/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
index ef5e21d..727d10a 100644
---
a/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
+++
b/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
@@ -94,6 +94,7 @@ public abstract class AbstractStoragePoolAllocator extends
AdapterBase implement
protected List reorderPoolsByCapacity(DeploymentPlan plan,
List pools) {
+Long zoneId = plan.getDataCenterId();
Long clusterId = plan.getClusterId();
short capacityType;
if(pools != null && pools.size() != 0){
@@ -102,7 +103,7 @@ public abstract class AbstractStoragePoolAllocator extends
AdapterBase implement
return null;
}
-List poolIdsByCapacity =
capacityDao.orderHostsByFreeCapacity(clusterId, capacityType);
+List poolIdsByCapacity =
capacityDao.orderHostsByFreeCapacity(zoneId, clusterId, capacityType);
if (s_logger.isDebugEnabled()) {
s_logger.debug("List of pools in descending order of free
capacity: "+ poolIdsByCapacity);
}
diff --git
a/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java
[GitHub] [cloudstack] weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-610005964 > @weizhouapache yes, tested in master and failed with this error: > > ``` > 2020-04-06 19:45:04,506 DEBUG [c.c.a.m.a.i.FirstFitAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7 FirstFitRoutingAllocator) (logid:bc36d8d1) Found a suitable host, adding to list: 1 > 2020-04-06 19:45:04,507 DEBUG [c.c.a.m.a.i.FirstFitAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7 FirstFitRoutingAllocator) (logid:bc36d8d1) Host Allocator returning 1 suitable hosts > 2020-04-06 19:45:04,510 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking suitable pools for volume (Id, Type): (129,ROOT) > 2020-04-06 19:45:04,510 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) We need to allocate new storagepool for this volume > 2020-04-06 19:45:04,510 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Calling StoragePoolAllocators to find suitable pools > 2020-04-06 19:45:04,511 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) LocalStoragePoolAllocator trying to find storage pool to fit the vm > 2020-04-06 19:45:04,511 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) ClusterScopeStoragePoolAllocator looking for storage pool > 2020-04-06 19:45:04,515 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Looking for pools in dc: 1 pod:1 cluster:1. Disabled pools will be ignored. > 2020-04-06 19:45:04,517 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Found pools matching tags: [] > 2020-04-06 19:45:04,517 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) No storage pools available for shared volume allocation, returning > 2020-04-06 19:45:04,518 DEBUG [o.a.c.s.a.ZoneWideStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) ZoneWideStoragePoolAllocator to find storage pool > 2020-04-06 19:45:04,521 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking if storage pool is suitable, name: null ,poolId: 2 > 2020-04-06 19:45:04,523 INFO [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Storage pool null (2) does not supply IOPS capacity, assuming enough capacity > 2020-04-06 19:45:04,531 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking pool 2 for storage, totalSize: 2164369915904, usedBytes: 1493502525440, usedPct: 0.6900403274253623, disable threshold: 0.85 > 2020-04-06 19:45:04,531 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Destination pool id: 2 > 2020-04-06 19:45:04,551 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Pool ID for the volume with ID 129 is null > 2020-04-06 19:45:04,554 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Found storage pool ps of type NetworkFilesystem with over-provisioning factor 2 > 2020-04-06 19:45:04,555 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Total over-provisioned capacity calculated is 2 * 2164369915904 > 2020-04-06 19:45:04,555 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Total capacity of the pool ps with ID 2 is 4328739831808 > 2020-04-06 19:45:04,559 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking pool: 2 for storage allocation , maxSize : 4328739831808, totalAllocatedSize : 12784435712, askingSize : 8589934592, allocated disable threshold: 0.85 > 2020-04-06 19:45:04,563 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) List of pools in descending order of free capacity: [] > 2020-04-06 19:45:04,563 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) No suitable pools found for volume: Vol[129|vm=123|ROOT] under cluster: 1 > 2020-04-06 19:45:04,563
[GitHub] [cloudstack] blueorangutan commented on issue #3936: [HEALTH][master/4.14] Health Check Run
blueorangutan commented on issue #3936: [HEALTH][master/4.14] Health Check Run URL: https://github.com/apache/cloudstack/pull/3936#issuecomment-610001807 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3936: [HEALTH][master/4.14] Health Check Run
DaanHoogland commented on issue #3936: [HEALTH][master/4.14] Health Check Run URL: https://github.com/apache/cloudstack/pull/3936#issuecomment-610001505 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
nvazquez commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-610001105 @weizhouapache yes, tested in master and failed with this error: 2020-04-06 19:45:04,506 DEBUG [c.c.a.m.a.i.FirstFitAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7 FirstFitRoutingAllocator) (logid:bc36d8d1) Found a suitable host, adding to list: 1 2020-04-06 19:45:04,507 DEBUG [c.c.a.m.a.i.FirstFitAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7 FirstFitRoutingAllocator) (logid:bc36d8d1) Host Allocator returning 1 suitable hosts 2020-04-06 19:45:04,510 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking suitable pools for volume (Id, Type): (129,ROOT) 2020-04-06 19:45:04,510 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) We need to allocate new storagepool for this volume 2020-04-06 19:45:04,510 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Calling StoragePoolAllocators to find suitable pools 2020-04-06 19:45:04,511 DEBUG [o.a.c.s.a.LocalStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) LocalStoragePoolAllocator trying to find storage pool to fit the vm 2020-04-06 19:45:04,511 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) ClusterScopeStoragePoolAllocator looking for storage pool 2020-04-06 19:45:04,515 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Looking for pools in dc: 1 pod:1 cluster:1. Disabled pools will be ignored. 2020-04-06 19:45:04,517 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Found pools matching tags: [] 2020-04-06 19:45:04,517 DEBUG [o.a.c.s.a.ClusterScopeStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) No storage pools available for shared volume allocation, returning 2020-04-06 19:45:04,518 DEBUG [o.a.c.s.a.ZoneWideStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) ZoneWideStoragePoolAllocator to find storage pool 2020-04-06 19:45:04,521 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking if storage pool is suitable, name: null ,poolId: 2 2020-04-06 19:45:04,523 INFO [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Storage pool null (2) does not supply IOPS capacity, assuming enough capacity 2020-04-06 19:45:04,531 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking pool 2 for storage, totalSize: 2164369915904, usedBytes: 1493502525440, usedPct: 0.6900403274253623, disable threshold: 0.85 2020-04-06 19:45:04,531 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Destination pool id: 2 2020-04-06 19:45:04,551 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Pool ID for the volume with ID 129 is null 2020-04-06 19:45:04,554 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Found storage pool ps of type NetworkFilesystem with over-provisioning factor 2 2020-04-06 19:45:04,555 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Total over-provisioned capacity calculated is 2 * 2164369915904 2020-04-06 19:45:04,555 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Total capacity of the pool ps with ID 2 is 4328739831808 2020-04-06 19:45:04,559 DEBUG [c.c.s.StorageManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) Checking pool: 2 for storage allocation , maxSize : 4328739831808, totalAllocatedSize : 12784435712, askingSize : 8589934592, allocated disable threshold: 0.85 2020-04-06 19:45:04,563 DEBUG [o.a.c.s.a.AbstractStoragePoolAllocator] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) List of pools in descending order of free capacity: [] 2020-04-06 19:45:04,563 DEBUG [c.c.d.DeploymentPlanningManagerImpl] (API-Job-Executor-1:ctx-acf00d62 job-1045 ctx-c26962c7) (logid:bc36d8d1) No suitable pools found for volume: Vol[129|vm=123|ROOT] under cluster: 1 2020-04-06 19:45:04,563 DEBUG [c.c.d.DeploymentPlanningManagerImpl]
[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3969: Snapshot deletion issues
DaanHoogland removed a comment on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-60763 yes should be !=, tnx (it's late) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3969: Snapshot deletion issues
DaanHoogland commented on a change in pull request #3969: Snapshot deletion
issues
URL: https://github.com/apache/cloudstack/pull/3969#discussion_r404344872
##
File path:
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
##
@@ -257,21 +257,23 @@ public boolean deleteSnapshot(Long snapshotId) {
return true;
}
-if (!Snapshot.State.BackedUp.equals(snapshotVO.getState()) &&
!Snapshot.State.Error.equals(snapshotVO.getState()) &&
+if (!Snapshot.State.BackedUp.equals(snapshotVO.getState()) &&
!Snapshot.State.Destroying.equals(snapshotVO.getState())) {
throw new InvalidParameterValueException("Can't delete
snapshotshot " + snapshotId + " due to it is in " + snapshotVO.getState() + "
Status");
}
-boolean deletedOnSecondary = deleteOnSecondaryIfNeeded(snapshotId);
+Boolean deletedOnSecondary = deleteOnSecondaryIfNeeded(snapshotId);
boolean deletedOnPrimary = deleteOnPrimaryIfNeeded(snapshotId);
if (deletedOnPrimary) {
s_logger.debug(String.format("Successfully deleted snapshot (id:
%d) on primary storage.", snapshotId));
-} else if (deletedOnSecondary) {
-s_logger.debug(String.format("The snapshot was deleted on
secondary storage. Could not find/delete snapshot (id: %d) on primary
storage.", snapshotId));
+} else {
+s_logger.debug(String.format("The snapshot (id: %d) could not be
found/deleted on primary storage.", snapshotId));
}
-
-return deletedOnSecondary || deletedOnPrimary;
+if (null == deletedOnSecondary && deletedOnSecondary) {
Review comment:
yes should be !=, tnx (it's late)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-60593 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-60930 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch snapshot-deletion-issues updated (1be6b99 -> 20cb0b2)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch snapshot-deletion-issues in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 1be6b99 return false on unexpected error or log when expected add 20cb0b2 != instead of == No new revisions were added by this update. Summary of changes: .../org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-60763 yes should be !=, tnx (it's late) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609985517 > LGTM > Tested manually on KVM env with zone-wide storage pool and `vm.allocation.algorithm = firstfitleastconsumed` @nvazquez thanks for approval. Have you tested without this PR ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3969: Snapshot deletion issues
GabrielBrascher commented on a change in pull request #3969: Snapshot deletion
issues
URL: https://github.com/apache/cloudstack/pull/3969#discussion_r404319082
##
File path:
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
##
@@ -257,21 +257,23 @@ public boolean deleteSnapshot(Long snapshotId) {
return true;
}
-if (!Snapshot.State.BackedUp.equals(snapshotVO.getState()) &&
!Snapshot.State.Error.equals(snapshotVO.getState()) &&
+if (!Snapshot.State.BackedUp.equals(snapshotVO.getState()) &&
!Snapshot.State.Destroying.equals(snapshotVO.getState())) {
throw new InvalidParameterValueException("Can't delete
snapshotshot " + snapshotId + " due to it is in " + snapshotVO.getState() + "
Status");
}
-boolean deletedOnSecondary = deleteOnSecondaryIfNeeded(snapshotId);
+Boolean deletedOnSecondary = deleteOnSecondaryIfNeeded(snapshotId);
boolean deletedOnPrimary = deleteOnPrimaryIfNeeded(snapshotId);
if (deletedOnPrimary) {
s_logger.debug(String.format("Successfully deleted snapshot (id:
%d) on primary storage.", snapshotId));
-} else if (deletedOnSecondary) {
-s_logger.debug(String.format("The snapshot was deleted on
secondary storage. Could not find/delete snapshot (id: %d) on primary
storage.", snapshotId));
+} else {
+s_logger.debug(String.format("The snapshot (id: %d) could not be
found/deleted on primary storage.", snapshotId));
}
-
-return deletedOnSecondary || deletedOnPrimary;
+if (null == deletedOnSecondary && deletedOnSecondary) {
Review comment:
I guess that instead of `null == deletedOnSecondary && deletedOnSecondary`
the it should be `null == deletedOnPrimary && deletedOnSecondary`, right? Or
`deletedOnSecondary != null && deletedOnSecondary`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609971789 Packaging result: ✔centos7 ✔debian. JID-1134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb opened a new issue #4018: Snapshots GC from DB - needs refractoring and fixing snapshot_store_ref garbage
andrijapanicsb opened a new issue #4018: Snapshots GC from DB - needs refractoring and fixing snapshot_store_ref garbage URL: https://github.com/apache/cloudstack/issues/4018 For details please see my comment: https://github.com/apache/cloudstack/pull/3969#issuecomment-609950065 The idea is that when the GC kicks in (setting storage.cleanup.interval) - it will remove SOME rows from the snapshot_store_ref table (IMAGE rows, where role_type=image) but not the PRIMARY (role_type=primary) and thus the garbage is left in the snapshot_stor_ref table. In the comment ^^^ I have explained in details what fields in DB tables are changed when deleting a snap, vs when GC kicks in, etc. Reproduce the issue: - set storage.cleanup.interval=60 (seconds), - set snapshot.backup.to.secondary=true, - spin a VM (1 or more volumes), any hypervisor - create snapshots - delete snapshots - wait for GC to kicks in:tail -f /var/log/cloudstack/management/management-server.log | grep "StorageManager-Scavenger" - check the snapshot_store_ref table - rows are left where role_type=primary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4017: [UI] Update ISO permissions
blueorangutan commented on issue #4017: [UI] Update ISO permissions URL: https://github.com/apache/cloudstack/pull/4017#issuecomment-609965663 Packaging result: ✔centos7 ✔debian. JID-1133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609963735 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609963113 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch snapshot-deletion-issues updated (ad26c8f -> 1be6b99)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch snapshot-deletion-issues in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ad26c8f refactor out separate handling methods for secondary and primary (reducing returns) add 1be6b99 return false on unexpected error or log when expected No new revisions were added by this update. Summary of changes: .../storage/snapshot/DefaultSnapshotStrategy.java| 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-)
[GitHub] [cloudstack] nvazquez commented on issue #4014: Improvement on build time and new quality profile
nvazquez commented on issue #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014#issuecomment-609960634 @DaanHoogland job finished: https://builds.apache.org/view/All/job/cloudstack-pr-analysis/10284/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4017: [UI] Update ISO permissions
blueorangutan commented on issue #4017: [UI] Update ISO permissions URL: https://github.com/apache/cloudstack/pull/4017#issuecomment-609951834 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #4017: [UI] Update ISO permissions
nvazquez commented on issue #4017: [UI] Update ISO permissions URL: https://github.com/apache/cloudstack/pull/4017#issuecomment-609951437 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #4017: [UI] Update ISO permissions
nvazquez opened a new pull request #4017: [UI] Update ISO permissions URL: https://github.com/apache/cloudstack/pull/4017 ## Description Add UI support for the existing `updateIsoPermissions` API. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate):  ## How Has This Been Tested? Register ISO -> Update ISO permissions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3969: Snapshot deletion issues
andrijapanicsb edited a comment on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609950065 Latest testing of the deletion stuff reports below (previously I have tested normal operations works fine - convert to this to that, revert (KVM only), etc, for all 3 hypervisors) ## snapshot.backup.to.secondary=FALSE Expected to work ONLY with KVM+Ceph (not other variants, not other hypervisors) (but the basic create/delete snap was tested with KVM+NFS to make sure nothing broken in that specific flow) create, delete snap works fine - GC kicks in, no exceptions - after GC runs, the "PRIMARY" (role_type=primary) row in snapshots_store_ref is left undeleted (with other snapshot.backup.to.secondary=TRUE testing as well) @rafaelweingartner please test with Ceph if possible ## snapshot.backup.to.secondary=TRUE - snaps can be created, operated with, deleted fine - deleted from file systems as expected (State changed to Destroyed in snapshots and snapshot_store_ref tables - "removed"date NOT set in the main "snapshots" table - GC will remove the IMAGE row (role_type=image) from the snapshot_store_ref table and set the "removed" date in the main "snapshots" table - GC will NOT remove the PRIMARY row from the snapshot_store_ref table (any of possibly many rows for the same volume (i.e. many different snapss of the same volume) - When a volume (root/data) is removed, then only first/latest (not sure) PRIMARY row in the snapshot_store_ref table- all other PRIMARY rows for a particular volume are left - i.e. DB garbage is left ### GC garbage workaround Remove rows from snapshot_store_ref table: > delete from snapshot_store_ref where snapshot_id in (select id from snapshots where status="Destroyed" and removed is NOT NULL); (removed not NULL = means that the GC has run and left the garbage behind) or the safer one (volume is removed) > delete from snapshot_store_ref where snapshot_id in (select id from snapshots where status="Destroyed" and removed is NOT NULL) and volume_id in (select id from volumes where state="Expunged" and removed is NOT NULL); This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609950065 Latest testing of the deletion stuff reports below (previously I have tested normal operations works fine - convert to this to that, revert (KVM only), etc, for all 3 hypervisors) ## snapshot.backup.to.secondary=FALSE Expected to work ONLY with KVM+Ceph (not other variants, not other hypervisors) (but the basic create/delete snap was tested with KVM+NFS to make sure nothing broken in that specific flow) create, delete snap works fine - GC kicks in, no exceptions - after GC runs, the "PRIMARY" (role_type=primary) row in snapshots_store_ref is left undeleted (with other snapshot.backup.to.secondary=TRUE testing as well) @rafaelweingartner please test with Ceph if possible ## snapshot.backup.to.secondary=TRUE - snaps can be created, operated with, deleted fine -- deleted from file systems as expected (State changed to Destroyed in snapshots and snapshot_store_ref tables - "removed"date NOT set in the main "snapshots" table --- GC will remove the IMAGE row (role_type=image) from the snapshot_store_ref table and set the "removed" date in the main "snapshots" table -- GC will NOT remove the PRIMARY row from the snapshot_store_ref table (any of possibly many rows for the same volume (i.e. many different snapss of the same volume) -- When a volume (root/data) is removed, then only first/latest (not sure) PRIMARY row in the snapshot_store_ref table- all other PRIMARY rows for a particular volume are left - i.e. DB garbage is left ### GC garbage workaround Remove rows from snapshot_store_ref table: > delete from snapshot_store_ref where snapshot_id in (select id from snapshots where status="Destroyed" and removed is NOT NULL); (removed not NULL = means that the GC has run and left the garbage behind) or the safer one (volume is removed) > delete from snapshot_store_ref where snapshot_id in (select id from snapshots where status="Destroyed" and removed is NOT NULL) and volume_id in (select id from volumes where state="Expunged" and removed is NOT NULL); This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3992: cks: use public links for templates and binaries iso for smoke tests
blueorangutan commented on issue #3992: cks: use public links for templates and binaries iso for smoke tests URL: https://github.com/apache/cloudstack/pull/3992#issuecomment-609856523 Packaging result: ✔centos7 ✔debian. JID-1132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 commented on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609843723 Seems like the System template is also old, should be `http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.3-kvm.qcow2.bz2` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609843723 Seems like the system template is also old, should be `http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.3-kvm.qcow2.bz2` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609831719 @hextht the guide is pointing to the 4.11 repo, did you change it to 4.13 when following? I think this may be an error in the guide. ``` [cloudstack] name=cloudstack baseurl=http://download.cloudstack.org/centos/7/4.11/ enabled=1 gpgcheck=0 ``` I'm thinking it should be ``` [cloudstack] name=cloudstack baseurl=http://download.cloudstack.org/centos/7/4.13/ enabled=1 gpgcheck=0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609831719 @hextht the guide is pointing to the 4.11 repo, did you change it to 4.13 when following? I think this may be an error in the guide. ``` name=cloudstack baseurl=http://download.cloudstack.org/centos/7/4.11/ enabled=1 gpgcheck=0 ``` I'm thinking it should be ``` name=cloudstack baseurl=http://download.cloudstack.org/centos/7/4.13/ enabled=1 gpgcheck=0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609831719 @hextht the guide is pointing to the 4.11 repo, did you change it to 4.13 when following? I think this may be an error in the guide. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 edited a comment on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609831719 @hextht the guide is pointing to the 4.11 repo, did you change it to 4.13 when following? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state.
Spaceman1984 commented on issue #3866: New installation of v 4.13 on Centos 7 completes successfully, but the svms end up in a non-healthy state. URL: https://github.com/apache/cloudstack/issues/3866#issuecomment-609831719 @hextht the guide is for 4.11, did you change 4.11 to 4.13 when following? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609815891 Packaging result: ✔centos7 ✔debian. JID-1131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3936: [HEALTH][master/4.14] Health Check Run
blueorangutan commented on issue #3936: [HEALTH][master/4.14] Health Check Run URL: https://github.com/apache/cloudstack/pull/3936#issuecomment-609813919 Trillian test result (tid-1363) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53049 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3936-t1363-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Smoke tests completed. 78 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_deploy_vm_from_iso | `Error` | 1511.58 | test_deploy_vm_iso.py test_01_create_iso_with_checksum_sha1 | `Error` | 65.34 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 5.11 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 65.36 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 5.09 | test_iso.py test_01_create_iso | `Failure` | 1511.43 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3024.00 | test_iso.py test_01_add_delete_kubernetes_supported_version | `Error` | 95.81 | test_kubernetes_supported_versions.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_13_attachAndDetach_iso | `Failure` | 1511.37 | test_vm_life_cycle.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
blueorangutan commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609805235 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
nvazquez commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609804894 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #4014: Improvement on build time and new quality profile
DaanHoogland commented on issue #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014#issuecomment-609788912 looks good, let's await the jenkins results and not forget to change the jovb according to thios PR afterwards. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console integration
blueorangutan commented on issue #3967: noVNC console integration URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609783747 @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez closed pull request #4014: Improvement on build time and new quality profile
nvazquez closed pull request #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #4014: Improvement on build time and new quality profile
nvazquez opened a new pull request #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014 ## Description Since PR #3956 has been merged the build time has increased drastically due to the quality tools added. This PR simply removes these tools from the default build execution and adds a new profile with name: `quality` to enable these tools. To enable this new profile, simply append: `-P quality` to the maven build command As a result, the default build time increases significantly, as shown in the 'How has this been tested' section ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? Tested on Ubuntu 19.10 laptop, 8x1.8Ghz CPU - 16GB RAM openjdk version "11.0.6" 2020-01-14 Apache Maven 3.6.1 Default build: $ mvn clean install -Dnoredist -P developer,systemvm -DskipTests -T4 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 06:21 min (Wall Clock) [INFO] Finished at: 2020-04-05T01:16:18-03:00 [INFO] Enabling quality tools (x2+ slower): mvn clean install -Dnoredist -P developer,systemvm,quality -U -DskipTests -T4 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 16:25 min (Wall Clock) [INFO] Finished at: 2020-04-05T01:42:07-03:00 [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console integration
vladimirpetrov commented on issue #3967: noVNC console integration URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609782902 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-609781665 Packaging result: ✖centos7 ✔debian. JID-1130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console integration
blueorangutan commented on issue #3967: noVNC console integration URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609770954 Packaging result: ✔centos7 ✔debian. JID-1129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
blueorangutan commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-609769512 @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] harikrishna-patnala commented on issue #4003: Logging framework to use only log4j and wrapper slf4j
harikrishna-patnala commented on issue #4003: Logging framework to use only log4j and wrapper slf4j URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-609768926 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console integration
blueorangutan commented on issue #3967: noVNC console integration URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609757971 @vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console integration
vladimirpetrov commented on issue #3967: noVNC console integration URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609757448 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3987: Exception in long running Java11/MySQL8 management server
rhtyd commented on issue #3987: Exception in long running Java11/MySQL8 management server URL: https://github.com/apache/cloudstack/issues/3987#issuecomment-609736581 Env details: ``` # lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 18.04.4 LTS Release: 18.04 Codename:bionic # uname -a Linux primate-develop 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux # java -version openjdk version "11.0.6" 2020-01-14 OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed mode, sharing) # mysql --version mysql Ver 14.14 Distrib 5.7.29, for Linux (x86_64) using EditLine wrapper ``` @andrijapanicsb @DaanHoogland please triage and decide severity/priority This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues
harikrishna-patnala commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609734614 Code changes on the last commit from @DaanHoogland looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609731651 > @weizhouapache which version should I test? @andrijapanicsb 4.13 or 4.14/master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609731418 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r404011883
##
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
-public List orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+public List orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
@DaanHoogland as I said, if we pass the cluster id, it lists only
cluster-wide storage pools.
To list zone-wide storage pools, we should pass the zoneId/data_center_id
(and cluster_id should be NULL).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609730934 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609729679 Packaging result: ✔centos7 ✔debian. JID-1128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #4014: Improvement on build time and new quality profile
shwstppr commented on issue #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014#issuecomment-609724801 @andrijapanicsb running test manually to check for any issue with the test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3969: Snapshot deletion issues
blueorangutan commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609722360 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609721773 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch snapshot-deletion-issues updated (e4bef7b -> ad26c8f)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch snapshot-deletion-issues in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e4bef7b Fix extra space add ad26c8f refactor out separate handling methods for secondary and primary (reducing returns) No new revisions were added by this update. Summary of changes: .../storage/snapshot/DefaultSnapshotStrategy.java | 67 +- 1 file changed, 40 insertions(+), 27 deletions(-)
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
DaanHoogland commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403993481
##
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
-public List orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+public List orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
if we pass the cluster and deduce the zone from that, or if we deliberately
pass another zone than the cluster we are looking to deploy in? I don't see how
can it ever be another zone,except for a bad bug. Or do you mean a storage pool
that is used for multiple zones? I have not seen that before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3987: Exception in long running Java11/MySQL8 management server
andrijapanicsb commented on issue #3987: Exception in long running Java11/MySQL8 management server URL: https://github.com/apache/cloudstack/issues/3987#issuecomment-609703639 @DaanHoogland we are NOT running the 8.x library, are we? Not sure our test-env makes any sense...? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403976998
##
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
-public List orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+public List orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
@DaanHoogland what if the storage pool is used for another zone ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4014: Improvement on build time and new quality profile
andrijapanicsb commented on issue #4014: Improvement on build time and new quality profile URL: https://github.com/apache/cloudstack/pull/4014#issuecomment-609702815 @shwstppr could you kindly see what is the issue with this Test - it was failing in some other PRs in master - we need this fix, please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330 > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ? @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. I'm happy to force delete the record after failing validation if you believe it's a better way to go? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609699076 @weizhouapache which version should I test? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330 > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ? @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. I'm happy to force delete the record after failing validation if you believe it's a better way to go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
DaanHoogland commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403971060
##
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
-public List orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+public List orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
yes, i read the code. Either zone_id or cluster_id should be null. What is
the use case of both being not null?
My point is; pass the cluster and find all storage pools for that cluster
either cluster wide or for the zone the cluster is in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330 > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ? @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. I thought to leave things this way, to keep some history until the gateway is removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted
Spaceman1984 edited a comment on issue #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330 > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ? @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point, which I think was the intention, but the delete method is also failing validation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted
Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609691330 > In the case as you said "When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state", could you add some changes to avoid it ? @weizhouapache The state of the route is changed to revoked after failing validation. The other option here would be to delete the record at this point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
andrijapanicsb commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609687894 @weizhouapache - I have not TRIED to reproduce the issue - but I can if you find it needed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4016: Fixed private gateway can't be deleted
Spaceman1984 commented on a change in pull request #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#discussion_r403958913 ## File path: engine/schema/src/main/java/com/cloud/network/vpc/dao/StaticRouteDao.java ## @@ -30,6 +30,8 @@ List listByVpcId(long vpcId); +List listByGatewayId(long vpcId); Review comment: Renamed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4016: Fixed private gateway can't be deleted
weizhouapache commented on a change in pull request #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#discussion_r403956830 ## File path: engine/schema/src/main/java/com/cloud/network/vpc/dao/StaticRouteDao.java ## @@ -30,6 +30,8 @@ List listByVpcId(long vpcId); +List listByGatewayId(long vpcId); Review comment: gatewayId This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted
Spaceman1984 commented on issue #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-609685570 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on issue #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed URL: https://github.com/apache/cloudstack/pull/4002#issuecomment-609682520 @andrijapanicsb if you cannot reproduce the issue, please do not merge this PR. ps: I am still able to reproduce the issue. We had the issue in 4.7 as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted
Spaceman1984 opened a new pull request #4016: Fixed private gateway can't be deleted URL: https://github.com/apache/cloudstack/pull/4016 ## Description When the static route service is not available on the VPC when a static route is created, the static route is created in a revoked state. Currently, the UI doesn't distinguish between active or revoked static routes. This PR adds the missing state filter to the list routes command and only lists active routes in the UI. It also ignores revoked routes when the private gateway is being removed but clears out the inactive routes after the gateway is removed. Fixes #2908 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This has been tested by creating a VPC with no services, adding a private gateway, adding a static route and deleting the gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4002: server: Search zone-wide storage pool when allocation algothrim is firstfitleastconsumed
weizhouapache commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403947541
##
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
-public List orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+public List orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
@DaanHoogland
please look at the code, there is only 'AND cluster_id = ' in the sql.
you can also execute the query in mysql
```
select * from op_host_capacity where capacity_type=3 and cluster_id=??
```
it lists only the cluster-wide storage pools.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #3969: Snapshot deletion issues
harikrishna-patnala commented on a change in pull request #3969: Snapshot
deletion issues
URL: https://github.com/apache/cloudstack/pull/3969#discussion_r403937237
##
File path:
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
##
@@ -285,7 +284,27 @@ public boolean deleteSnapshot(Long snapshotId) {
}
}
-boolean deletedOnPrimary = deleteSnapshotOnPrimary(snapshotId);
+boolean deletedOnPrimary = false;
+snapshotVO = snapshotDao.findById(snapshotId);
+SnapshotInfo snapshotOnPrimaryInfo =
snapshotDataFactory.getSnapshot(snapshotId, DataStoreRole.Primary);
+if (snapshotVO != null && snapshotVO.getState() ==
Snapshot.State.Destroyed) {
+deletedOnPrimary = deleteSnapshotOnPrimary(snapshotId,
snapshotOnPrimaryInfo);
+} else {
+// This is to handle snapshots which are created only on primary
when snapshot.backup.to.secondary is set to false.
Review comment:
There will be only 'Primary' store entry in snapshot_store_ref table for a
snapshot created when snapshot.backup.to.secondary is set to false. so deletion
of snapshot on secondary store will fail and it won't mark snapshot as
destroyed and then goes to 'else' case. In other case
(snapshot.backup.to.secondary is set to true) 'Image' and 'Primary' entries
will be there in which it goes to 'if' case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
