[GitHub] [cloudstack] ccycv commented on issue #4118: com.cloud.utils.exception.CloudRuntimeException: Failed to create storage pool - Ceph Storage - ACS 4.13

[GitBox]

ccycv commented on issue #4118:
URL: https://github.com/apache/cloudstack/issues/4118#issuecomment-648601852


   Hello,
   

   
  We fixed this, it was related to a stuck image, we have removed from db 
and from storage.  Please see all the details : 
https://github.com/apache/cloudstack/issues/4118
   

   
  Thank you!
   

   
   Regards,
   
   Cristian
   

   
   From: Rohit Yadav  
   Sent: Wednesday, June 24, 2020 6:11 AM
   To: apache/cloudstack 
   Cc: ccycv ; Mention 
   Subject: Re: [apache/cloudstack] 
com.cloud.utils.exception.CloudRuntimeException: Failed to create storage pool 
- Ceph Storage - ACS 4.13 (#4118)
   

   
   @ccycv   can you try on 4.13.1.0 or 4.14.1.0? Are 
the ceph credentials correct, or was the storage pool not created on Ceph; or 
removed out-of-band in ceph-mgr?
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub 
 , or 
unsubscribe 

 .  

 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

blueorangutan commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648600922


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

Pearl1594 commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648600651


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] div8cn opened a new issue #4169: local iso upload failed

[GitBox]

div8cn opened a new issue #4169:
URL: https://github.com/apache/cloudstack/issues/4169


   
   
   
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   SSVM
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.13
   4.14
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   
   
   After the default installation, users cannot upload ISO to cloudstack from 
the UI.
   Error ：
   Failed to upload file due to system misconfiguration. Please contact admin.
   
   I learned from the documentation 
(https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=39620237) 
that for ISO local upload, HTTPS must be used.
   
   By default (users do not enable cloudstack ssl), ssvm will use the 
*.realhostip.com certificate (this certificate has expired in 2017)
   Due to a certificate error, chrome(ie) will issue a warning and must be 
confirmed by the user before accessing the corresponding page.
   So if you want to implement local iso upload without configuring SSL, you 
must first use the browser to request the public IP of SSVM,
   For example: https://10.228.18.64
   Click Continue when the browser issues a warning.
   Then you can upload ISO on cloudstack ui.
   
   
   Can we remove this restriction on https? (For example, HTTPS is optional)
   I think many users will encounter this problem when they first deploy.
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   
   ~~~
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

Pearl1594 commented on a change in pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#discussion_r444640486



##
File path: server/src/main/java/com/cloud/api/ApiServlet.java
##
@@ -259,6 +259,22 @@ void processRequestInContext(final HttpServletRequest req, 
final HttpServletResp
 userId = (Long)session.getAttribute("userid");
 final String account = (String) 
session.getAttribute("account");
 final Object accountObj = session.getAttribute("accountobj");
+if (session.getAttribute(ApiConstants.SESSIONKEY) != null) {
+Cookie[] cookies = req.getCookies();
+if (cookies != null) {
+HttpSession finalSession = session;
+List sessionKeys = 
Arrays.stream(cookies).filter(cookie ->  
cookie.getName().equals(ApiConstants.SESSIONKEY)
+&& 
cookie.getValue().equals(finalSession.getAttribute(ApiConstants.SESSIONKEY))).collect(Collectors.toList());
+Cookie validCookie = sessionKeys.get(0);

Review comment:
   When there are 2 sessions opened (primate and legacy UI) to the same 
domain, there will be multiple sessionkey cookies





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579715


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani removed a comment on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

davidjumani removed a comment on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579715


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579421


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

rhtyd commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579290


   @blueorangutan test 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648576739


   Packaging result: ✔centos7 ✔debian. JID-1441



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

[GitBox]

blueorangutan commented on pull request #4040:
URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-648572317


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

[GitBox]

blueorangutan commented on pull request #4103:
URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-648572229


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4103: [VMware] Enable unmanaging guest VMs

[GitBox]

rhtyd commented on pull request #4103:
URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-648571925


   @blueorangutan test 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

[GitBox]

rhtyd commented on pull request #4040:
URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-648571822


   @blueorangutan test 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648571341


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

[GitBox]

blueorangutan commented on pull request #4040:
URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-648570901


   Packaging result: ✔centos7 ✔debian. JID-1440



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648570963


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

[GitBox]

blueorangutan commented on pull request #4103:
URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-648569621


   Packaging result: ✔centos7 ✔debian. JID-1439



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-primate] branch master updated: iam: Allow creating Compute/Disk offering as Domain admin (#446)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new 09bc734  iam: Allow creating Compute/Disk offering as Domain admin 
(#446)
09bc734 is described below

commit 09bc73422ed94db6b9ea19997ab57491a796691a
Author: Rakesh 
AuthorDate: Wed Jun 24 06:01:18 2020 +0200

iam: Allow creating Compute/Disk offering as Domain admin (#446)

Currently only "ROOT" admin can create compute and
disk offering. If we login as domain admin then we
cant create a compute and disk offering as domain
id's is not passed to the api. If we login as
domain admin we need to set "isPublic" to false
so that domain id list will be displayed

Co-authored-by: Rakesh Venkatesh 
---
 src/views/offering/AddComputeOffering.vue | 1 +
 src/views/offering/AddDiskOffering.vue| 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/views/offering/AddComputeOffering.vue 
b/src/views/offering/AddComputeOffering.vue
index 34c2f96..c58b69c 100644
--- a/src/views/offering/AddComputeOffering.vue
+++ b/src/views/offering/AddComputeOffering.vue
@@ -595,6 +595,7 @@ export default {
   this.isSystem = true
 }
 this.fetchData()
+this.isPublic = this.isAdmin()
   },
   methods: {
 fetchData () {
diff --git a/src/views/offering/AddDiskOffering.vue 
b/src/views/offering/AddDiskOffering.vue
index 021b967..c498326 100644
--- a/src/views/offering/AddDiskOffering.vue
+++ b/src/views/offering/AddDiskOffering.vue
@@ -348,6 +348,7 @@ export default {
   },
   mounted () {
 this.fetchData()
+this.isPublic = this.isAdmin()
   },
   methods: {
 fetchData () {

[GitHub] [cloudstack] blueorangutan commented on pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled

[GitBox]

blueorangutan commented on pull request #4148:
URL: https://github.com/apache/cloudstack/pull/4148#issuecomment-648563272


   Packaging result: ✔centos7 ✔debian. JID-1438



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

[GitBox]

blueorangutan commented on pull request #4040:
URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-648557170


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

blueorangutan commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648557262


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

rhtyd commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648556867


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

[GitBox]

rhtyd commented on pull request #4040:
URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-648556976


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4115: cks: fix k8s cluster deployment planner

[GitBox]

rhtyd commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-648556748


   @shwstppr can you club your cks PRs, and at least change base branch to 4.14?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4134: cks: fix k8s cluster network deletion

[GitBox]

rhtyd commented on pull request #4134:
URL: https://github.com/apache/cloudstack/pull/4134#issuecomment-648556654


   @shwstppr can you club your cks PRs, and at least change base branch to 4.14?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4116: cks: fix k8s cluster template retrieval

[GitBox]

rhtyd commented on pull request #4116:
URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-648556704


   @shwstppr can you club your cks PRs, and at least change base branch to 4.14?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4167: Adding missing fields to API responses

[GitBox]

rhtyd commented on pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648556391


   @shwstppr can you review this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4118: com.cloud.utils.exception.CloudRuntimeException: Failed to create storage pool - Ceph Storage - ACS 4.13

[GitBox]

rhtyd commented on issue #4118:
URL: https://github.com/apache/cloudstack/issues/4118#issuecomment-648555914


   @ccycv can you try on 4.13.1.0 or 4.14.1.0? Are the ceph credentials 
correct, or was the storage pool not created on Ceph; or removed out-of-band in 
ceph-mgr?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd edited a comment on issue #4163: health check gateways_check.py for redundant VR will fail for BACKUP router

[GitBox]

rhtyd edited a comment on issue #4163:
URL: https://github.com/apache/cloudstack/issues/4163#issuecomment-648554853


   @shwstppr can you have a look at this issue; we also might want to reduce 
the INFO logging on VR checks; check if any UI changes are necessary



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4163: health check gateways_check.py for redundant VR will fail for BACKUP router

[GitBox]

rhtyd commented on issue #4163:
URL: https://github.com/apache/cloudstack/issues/4163#issuecomment-648554853


   @shwstppr can you have a look at this issue; we also might want to reduce 
the INFO logging on VR checks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted

[GitBox]

rhtyd commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-648554497


   @Spaceman1984 this looks like deletes pg in CloudStack DB, have you verified 
if this would also cleanup rules on the VR properly?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download

[GitBox]

rhtyd commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r444618668



##
File path: 
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
##
@@ -489,6 +489,10 @@ public void handleTemplateSync(DataStore store) {
 s_logger.info("Removing leftover template 
" + uniqueName + " entry from template store table");
 // remove those leftover entries
 
_vmTemplateStoreDao.remove(tmpltStore.getId());
+// remove from zones
+
_vmTemplateZoneDao.deletePrimaryRecordsForTemplate(tmplt.getId());
+// remove template
+_templateDao.remove(tmplt.getId());

Review comment:
   @Spaceman1984 this probably needs checking, what if the templates are OK 
for other secondary storages within the same zone; and across zones?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

[GitBox]

blueorangutan commented on pull request #4103:
URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-648553763


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4103: [VMware] Enable unmanaging guest VMs

[GitBox]

rhtyd commented on pull request #4103:
URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-648553615


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4084: Added nfs minor version support on SSVM

[GitBox]

rhtyd commented on pull request #4084:
URL: https://github.com/apache/cloudstack/pull/4084#issuecomment-648553680


   ping @Spaceman1984 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

[GitBox]

rhtyd commented on pull request #4117:
URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-648553531


   @nvazquez can you check why test_ssvm is failing (this test generally does 
not fail), also if other tests failures are env related?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled

[GitBox]

blueorangutan commented on pull request #4148:
URL: https://github.com/apache/cloudstack/pull/4148#issuecomment-648553474


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled

[GitBox]

rhtyd commented on pull request #4148:
URL: https://github.com/apache/cloudstack/pull/4148#issuecomment-648553203


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

[GitBox]

rhtyd commented on pull request #4156:
URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-648552888


   @Spaceman1984 can you kick packaging and tests again; was purgeHost being 
called on a host already removed in DB? But how that does affect hosts that are 
already connected to a management server (i.e. host not removed in DB)?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

rhtyd commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648552507


   @davidjumani can you change the base branch to at least 4.14 and kick tests 
again? We want any bugfixes and API improvements (for Primate) to at least go 
into 4.14 branch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

rhtyd commented on a change in pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#discussion_r444288743



##
File path: 
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java
##
@@ -117,4 +121,8 @@ public void setPort(final int port) {
 public void setDomainId(final Long domainId) {
 this.domainId = domainId;
 }
+
+public boolean listAll() {
+return listAll == null ? false : listAll;

Review comment:
   nit - can be simplified as listAll != null && listAll





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4165: Allow renaming cluster, host, and storage

[GitBox]

rhtyd commented on pull request #4165:
URL: https://github.com/apache/cloudstack/pull/4165#issuecomment-648552178


   Renaming of cluster on VMware could cause a problem if the cluster on 
VCenter is not mapped; on XenServer I'm not sure if there'll be any 
side-effects. On KVM LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch master updated (029fc51 -> 5471802)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 029fc51  Merge remote-tracking branch 'origin/4.14'
 add 8010718  server: fix for wrong affinity group count (#4154)
 add 615ab4e  Merge remote-tracking branch 'origin/4.13' into 4.14
 new 5471802  Merge remote-tracking branch 'origin/4.14'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../java/com/cloud/api/query/QueryManagerImpl.java | 23 +-
 1 file changed, 14 insertions(+), 9 deletions(-)

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 5471802f862dd617f63d12eb56c9aa62759e4309
Merge: 029fc51 615ab4e
Author: Rohit Yadav 
AuthorDate: Wed Jun 24 08:24:29 2020 +0530

Merge remote-tracking branch 'origin/4.14'

 .../java/com/cloud/api/query/QueryManagerImpl.java | 23 +-
 1 file changed, 14 insertions(+), 9 deletions(-)

[cloudstack] branch 4.14 updated (5f23171 -> 615ab4e)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 5f23171  Merge remote-tracking branch 'origin/4.13' into 4.14
 add 8010718  server: fix for wrong affinity group count (#4154)
 new 615ab4e  Merge remote-tracking branch 'origin/4.13' into 4.14

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../java/com/cloud/api/query/QueryManagerImpl.java | 23 +-
 1 file changed, 14 insertions(+), 9 deletions(-)

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 615ab4ef2ced770ad0c19bf8d21d92bc2a348b0a
Merge: 5f23171 8010718
Author: Rohit Yadav 
AuthorDate: Wed Jun 24 08:23:43 2020 +0530

Merge remote-tracking branch 'origin/4.13' into 4.14

 .../java/com/cloud/api/query/QueryManagerImpl.java | 23 +-
 1 file changed, 14 insertions(+), 9 deletions(-)

[GitHub] [cloudstack] rhtyd commented on issue #4168: Problems when using multiple management servers.

[GitBox]

rhtyd commented on issue #4168:
URL: https://github.com/apache/cloudstack/issues/4168#issuecomment-648530929


   @gaaray2k no need to use external LB now as cloudstack has an internal 
software based LB, use comma separated list of mgmt IPs in the 'host' global 
settings. For existing kvm hosts, fix the same in agent.properties. See 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Multiple+Management+Servers+Support+on+agents
   and
   https://www.shapeblue.com/software-based-agent-lb-for-cloudstack/



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch 4.13 updated: server: fix for wrong affinity group count (#4154)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.13 by this push:
 new 8010718  server: fix for wrong affinity group count (#4154)
8010718 is described below

commit 801071887810dbeb68a24e94e36f117e911883bc
Author: Abhishek Kumar 
AuthorDate: Wed Jun 24 07:02:56 2020 +0530

server: fix for wrong affinity group count (#4154)

Fixes wrong count in listAffinityGroup API.
API was returning the count of AffinityGroupJoinVO records.

Signed-off-by: Abhishek Kumar 
---
 .../java/com/cloud/api/query/QueryManagerImpl.java | 23 +-
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java 
b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
index c41cd0e..bf30430 100644
--- a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
+++ b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
@@ -3625,25 +3625,30 @@ public class QueryManagerImpl extends 
MutualExclusiveIdsManagerBase implements Q
 if (domainId != null) {
 SearchCriteria scDomain = 
buildAffinityGroupSearchCriteria(null, isRecursive, new ArrayList(), 
listProjectResourcesCriteria, affinityGroupId,
 affinityGroupName, affinityGroupType, keyword);
-affinityGroups.addAll(listDomainLevelAffinityGroups(scDomain, 
searchFilter, domainId));
+Pair, Integer> groupsPair = 
listDomainLevelAffinityGroups(scDomain, searchFilter, domainId);
+affinityGroups.addAll(groupsPair.first());
+count += groupsPair.second();
 } else {
 
 for (Long permAcctId : permittedAccounts) {
 Account permittedAcct = _accountDao.findById(permAcctId);
 SearchCriteria scDomain = 
buildAffinityGroupSearchCriteria(null, isRecursive, new ArrayList(), 
listProjectResourcesCriteria, affinityGroupId,
 affinityGroupName, affinityGroupType, keyword);
-
-
affinityGroups.addAll(listDomainLevelAffinityGroups(scDomain, searchFilter, 
permittedAcct.getDomainId()));
+Pair, Integer> groupsPair = 
listDomainLevelAffinityGroups(scDomain, searchFilter, 
permittedAcct.getDomainId());
+affinityGroups.addAll(groupsPair.first());
+count += groupsPair.second();
 }
 }
 } else if (((permittedAccounts.isEmpty()) && (domainId != null) && 
isRecursive)) {
 // list all domain level affinity groups for the domain admin case
 SearchCriteria scDomain = 
buildAffinityGroupSearchCriteria(null, isRecursive, new ArrayList(), 
listProjectResourcesCriteria, affinityGroupId, affinityGroupName,
 affinityGroupType, keyword);
-affinityGroups.addAll(listDomainLevelAffinityGroups(scDomain, 
searchFilter, domainId));
+Pair, Integer> groupsPair = 
listDomainLevelAffinityGroups(scDomain, searchFilter, domainId);
+affinityGroups.addAll(groupsPair.first());
+count += groupsPair.second();
 }
 
-return new Pair, Integer>(affinityGroups, 
affinityGroups.size());
+return new Pair, Integer>(affinityGroups, 
count);
 
 }
 
@@ -3741,7 +3746,7 @@ public class QueryManagerImpl extends 
MutualExclusiveIdsManagerBase implements Q
 return new Pair, Integer>(ags, count);
 }
 
-private List 
listDomainLevelAffinityGroups(SearchCriteria sc, Filter 
searchFilter, long domainId) {
+private Pair, Integer> 
listDomainLevelAffinityGroups(SearchCriteria sc, Filter 
searchFilter, long domainId) {
 List affinityGroupIds = new ArrayList();
 Set allowedDomains = _domainMgr.getDomainParentIds(domainId);
 List maps = 
_affinityGroupDomainMapDao.listByDomain(allowedDomains.toArray());
@@ -3765,7 +3770,7 @@ public class QueryManagerImpl extends 
MutualExclusiveIdsManagerBase implements Q
 Integer count = uniqueGroupsPair.second();
 if (count.intValue() == 0) {
 // empty result
-return new ArrayList();
+return new Pair<>(new ArrayList(), 0);
 }
 List uniqueGroups = uniqueGroupsPair.first();
 Long[] vrIds = new Long[uniqueGroups.size()];
@@ -3774,9 +3779,9 @@ public class QueryManagerImpl extends 
MutualExclusiveIdsManagerBase implements Q
 vrIds[i++] = v.getId();
 }
 List vrs = 
_affinityGroupJoinDao.searchByIds(vrIds);
-return vrs;
+return new Pair<>(vrs, count);
 } else {
-return new ArrayList();
+return new Pair<>(new ArrayList(), 0);
 }
 }
 

[GitHub] [cloudstack] rhtyd merged pull request #4154: server: fix for wrong affinity group count

[GitBox]

rhtyd merged pull request #4154:
URL: https://github.com/apache/cloudstack/pull/4154


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4154: server: fix for wrong affinity group count

[GitBox]

rhtyd commented on pull request #4154:
URL: https://github.com/apache/cloudstack/pull/4154#issuecomment-648529261


   Test lgtm, failure unrelated to the PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

rhtyd commented on a change in pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#discussion_r444594221



##
File path: server/src/main/java/com/cloud/api/ApiServlet.java
##
@@ -259,6 +259,22 @@ void processRequestInContext(final HttpServletRequest req, 
final HttpServletResp
 userId = (Long)session.getAttribute("userid");
 final String account = (String) 
session.getAttribute("account");
 final Object accountObj = session.getAttribute("accountobj");
+if (session.getAttribute(ApiConstants.SESSIONKEY) != null) {
+Cookie[] cookies = req.getCookies();
+if (cookies != null) {
+HttpSession finalSession = session;
+List sessionKeys = 
Arrays.stream(cookies).filter(cookie ->  
cookie.getName().equals(ApiConstants.SESSIONKEY)
+&& 
cookie.getValue().equals(finalSession.getAttribute(ApiConstants.SESSIONKEY))).collect(Collectors.toList());
+Cookie validCookie = sessionKeys.get(0);

Review comment:
   Why is the first cookie assumed the valid one? Is the core problem that 
more than one instance of sessionkey cookie exists? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

blueorangutan commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648528361


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

rhtyd commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648527968


   @blueorangutan test 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

blueorangutan commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648460940


   Trillian test result (tid-1820)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41452 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4166-t1820-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 73 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 350.77 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 395.30 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 188.02 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 212.12 | 
test_internal_lb.py
   test_04_verify_guest_lspci | `Error` | 810.67 | test_deploy_virtio_scsi_vm.py
   test_06_verify_guest_lspci_again | `Error` | 810.72 | 
test_deploy_virtio_scsi_vm.py
   test_01_ping_in_vr_success | `Error` | 60.28 | test_diagnostics.py
   test_07_arping_in_vr | `Failure` | 5.17 | test_diagnostics.py
   test_08_arping_in_ssvm | `Failure` | 5.15 | test_diagnostics.py
   test_09_arping_in_cpvm | `Failure` | 5.14 | test_diagnostics.py
   test_02_vpc_privategw_static_routes | `Failure` | 186.69 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 176.18 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 248.58 | 
test_privategw_acl.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] gaaray2k opened a new issue #4168: Problems when using multiple management servers.

[GitBox]

gaaray2k opened a new issue #4168:
URL: https://github.com/apache/cloudstack/issues/4168


   CS version: 4.14
   setup:
   LB: haproxy
   2 management nodes
   2 compute nodes
   
   
   I am playing around with adding a second mgmt host to my setup. the problem 
is that when I configured the haproxy LB for port 8250, the management servers 
are seeing the compute node certificates but the mgmt servers are seeing the ip 
of the load balancer as the source of the request. because of this the 
connection is failing. the ip of the LB isnt listed in the cert therefore 
getting the error below. I changed the 'host' property to be the LB ip and I 
see the nodes trying to connect but they fail to do so. 
   how is a setup like supposed to be configured?
   
   
   
   log on management:
   2020-06-22 05:04:27,010 DEBUG [o.a.c.c.p.RootCACustomTrustManager] 
(pool-222-thread-1:null) (logid:) A client/agent attempting connection from 
address=10.0.0.45 has presented these certificate(s):
   Certificate [1] :
Serial: 71a519c2e7762bf4
 Not Before:Thu Jun 18 22:40:36 EDT 2020
 Not After:Sat Jun 19 10:40:36 EDT 2021
 Signature Algorithm:SHA256withRSA
 Version:3
 Subject DN:C=cloudstack, O=cloudstack, OU=cloudstack, CN=cs-compute-01
 Issuer DN:CN=ca.cloudstack.apache.org
 Alternative Names:[[7, fe80:0:0:0:3801:1f5e:9ab2:bc9e], [7, 
fe80:0:0:0:19c:6dc6:62e9:59cb], [7, fe80:0:0:0:20c:29ff:fecf:7565], [7, 
192.168.122.1], [7, 10.10.0.52], [7, fe80:0:0:0:c400:4519:2866:f915], [7, 
10.0.0.52], [2, 10.0.0.52]]
   Certificate [2] :
Serial: 7ab4d7014adc5901
 Not Before:Thu Jun 18 21:19:22 EDT 2020
 Not After:Sun Jun 12 09:19:22 EDT 2050
 Signature Algorithm:SHA256withRSA
 Version:3
 Subject DN:CN=ca.cloudstack.apache.org
 Issuer DN:CN=ca.cloudstack.apache.org
 Alternative Names:null
   2020-06-22 05:04:27,014 ERROR [o.a.c.c.p.RootCACustomTrustManager] 
(pool-222-thread-1:null) (logid:) Certificate ownership verification failed for 
client: 10.0.0.45
   2020-06-22 05:04:27,014 ERROR [c.c.u.n.Link] 
(AgentManager-SSLHandshakeHandler-79:null) (logid:) SSL error caught during 
wrap data: Certificate ownership verification failed for client: 10.0.0.45, for 
local address=/10.0.0.66:8250, remote address=/10.0.0.45:46844.
   2020-06-22 05:04:27,018 INFO  [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-12:null) (logid:) Connection from /10.0.0.45 closed but 
no cleanup was done.
   
   
   
   
   log on compute node:
   
   2020-06-23 16:25:36,084 INFO  [cloud.agent.Agent] (main:null) (logid:) 
Connecting to host:10.0.0.45
   2020-06-23 16:25:36,085 INFO  [utils.nio.NioClient] (main:null) (logid:) 
Connecting to 10.0.0.45:8250
   2020-06-23 16:25:36,086 INFO  [utils.nio.Link] (main:null) (logid:) Conf 
file found: /etc/cloudstack/agent/agent.properties
   2020-06-23 16:25:36,396 ERROR [utils.nio.Link] (main:null) (logid:) SSL 
error caught during unwrap data: Received fatal alert: certificate_unknown, for 
local address=/10.0.0.52:34340, remote address=/10.0.0.45:8250. The client may 
have invalid ca-certificates.
   2020-06-23 16:25:36,396 ERROR [utils.nio.NioClient] (main:null) (logid:) SSL 
Handshake failed while connecting to host: 10.0.0.45 port: 8250
   2020-06-23 16:25:36,397 ERROR [utils.nio.NioConnection] (main:null) (logid:) 
Unable to initialize the threads.
   java.io.IOException: SSL Handshake failed while connecting to host: 
10.0.0.45 port: 8250
   at com.cloud.utils.nio.NioClient.init(NioClient.java:67)
   at com.cloud.utils.nio.NioConnection.start(NioConnection.java:95)
   at com.cloud.agent.Agent.start(Agent.java:293)
   at com.cloud.agent.AgentShell.launchNewAgent(AgentShell.java:455)
   at 
com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:422)
   at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:406)
   at com.cloud.agent.AgentShell.start(AgentShell.java:512)
   at com.cloud.agent.AgentShell.main(AgentShell.java:547)
   2020-06-23 16:25:36,397 INFO  [utils.nio.NioClient] (main:null) (logid:) 
NioClient connection closed
   2020-06-23 16:25:36,398 INFO  [cloud.agent.Agent] (main:null) (logid:) 
Attempted to connect to the server, but received an unexpected exception, 
trying again...
   
   
   LB config:
   
   frontend agent_front
  mode tcp
  option forwardfor
  option tcplog
  cookie SESSIONID prefix
  bind 10.0.0.45:8250
  stats uri /haproxy?stats
  default_backend agent_back
   
   backend agent_back
   mode tcp
   balance source
   stats enable
   stats auth x:x
   server cs1-agent 10.0.0.66:8250 check cookie p
   server cs2-agent 10.0.0.64:8250 check cookie l
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries 

[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects

[GitBox]

blueorangutan commented on pull request #4128:
URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-648367828


   Trillian test result (tid-1817)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43935 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t1817-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_create_list_domain_account_project.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Smoke tests completed. 77 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   test_01_create_list_domain_account_project | `Error` | 1.00 | 
test_create_list_domain_account_project.py
   test_02_vpc_privategw_static_routes | `Failure` | 993.46 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 955.83 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1090.67 | 
test_privategw_acl.py
   test_02_cross_domain_account_add | `Error` | 1.11 | test_projects.py
   ContextSuite context=TestCrossDomainAccountAdd>:teardown | `Error` | 3.23 | 
test_projects.py
   test_03_delete_account_with_project | `Error` | 1.15 | test_projects.py
   ContextSuite context=TestDeleteAccountWithProject>:teardown | `Error` | 2.20 
| test_projects.py
   test_01_create_multiple_projects_by_account | `Error` | 2.26 | 
test_projects.py
   test_01_create_multiple_projects_by_account | `Error` | 2.28 | 
test_projects.py
   ContextSuite context=TestMultipleProjectCreation>:teardown | `Error` | 4.41 
| test_projects.py
   test_05_user_project_owner_promotion | `Error` | 1.11 | test_projects.py
   test_05_user_project_owner_promotion | `Error` | 1.13 | test_projects.py
   test_06_max_one_project_owner | `Error` | 1.46 | test_projects.py
   test_06_max_one_project_owner | `Error` | 1.47 | test_projects.py
   ContextSuite context=TestProjectOwners>:teardown | `Error` | 2.53 | 
test_projects.py
   test_07_project_resources_account_delete | `Error` | 1.10 | test_projects.py
   test_07_project_resources_account_delete | `Error` | 1.12 | test_projects.py
   test_08_cleanup_after_project_delete | `Error` | 1.42 | test_projects.py
   ContextSuite context=TestProjectResources>:teardown | `Error` | 3.54 | 
test_projects.py
   test_09_project_suspend | `Error` | 0.01 | test_projects.py
   test_10_project_activation | `Error` | 0.01 | test_projects.py
   ContextSuite context=TestProjectSuspendActivate>:teardown | `Error` | 0.02 | 
test_projects.py
   test_router_dhcphosts | `Failure` | 216.59 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 227.04 | 
test_router_dhcphosts.py
   test_router_dns_guestipquery | `Failure` | 613.73 | test_router_dns.py
   test_router_dns_guestipquery | `Failure` | 613.73 | test_router_dnsservice.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4154: server: fix for wrong affinity group count

[GitBox]

blueorangutan commented on pull request #4154:
URL: https://github.com/apache/cloudstack/pull/4154#issuecomment-648343564


   Trillian test result (tid-1818)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41435 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4154-t1818-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 70 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 194.35 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 179.49 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 247.06 | 
test_privategw_acl.py
   test_router_dhcphosts | `Failure` | 216.60 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 227.90 | 
test_router_dhcphosts.py
   test_router_dns_guestipquery | `Failure` | 613.62 | test_router_dns.py
   test_router_dns_guestipquery | `Failure` | 613.75 | test_router_dnsservice.py
   test_01_single_VPC_iptables_policies | `Error` | 932.10 | 
test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 
268.27 | test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 
267.17 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
295.71 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
299.61 | test_routers_network_ops.py
   test_01_service_offering_cpu_limit_use | `Error` | 811.17 | 
test_service_offerings.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher closed pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

GabrielBrascher closed pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

GabrielBrascher opened a new pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600


   ## Description
   
   This proposal allows Virtual Routers to be deployed on disabled 
zones/pods/clusters. It also gives the opportunity to deploy Admin VMs to be 
deployed on disabled resources.
   
   The default configuration is set to **false** for deploying Admin VMs on 
disabled resources and deploying system VMs on disabled resources. Both, 
`allow.router.on.disabled.resources` and 
`allow.admin.vm.on.disabled.resources`, are configurable and do not require 
management server restart when updated.
   
   The main goal of this implementation is to give flexibility and total 
control for system admins to decide either if they want or not to deploy System 
and/or Admin VMs in disabled resources. This implementation was encouraged 
after an issue related with a disabled Pod; it was not possible to reset 
networks in the Zone due to the fact that the VRs running on the disabled Pods 
would fail to be re-deployed.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648318939


   Packaging result: ✔centos7 ✔debian. JID-1437



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648315377


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

Pearl1594 commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648313713


   @blueorangutan test centos7 kvm-centos7 component/test_configdrive.py



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648309754


   Packaging result: ✔centos7 ✔debian. JID-1436



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648302137


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648301550


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648299420


   Packaging result: ✔centos7 ✖debian. JID-1435



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648294263


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

Pearl1594 commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648293593


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648292645


   Packaging result: ✖centos7 ✔debian. JID-1434



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

blueorangutan commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648284180


   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

GabrielBrascher edited a comment on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648280999


   @andrijapanicsb @DaanHoogland I just rebased and fixed all conflicts, the 
branch is good for master/4.15.
   
   Note: I have executed a batch of manual tests on a 4.15-SNAPSHOT Zone. All 
looking good!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648283519


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3600: Allow deploy Admin VMs and VRs in disabled zones/pods/clusters

[GitBox]

GabrielBrascher commented on pull request #3600:
URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-648280999


   @andrijapanicsb @DaanHoogland I just rebased and fixed all conflicts, branch 
good for master/4.15 now.
   
   Note: I have executed a batch of manual tests on a 4.15-SNAPSHOT Zone. All 
looking good!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648277785


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

Pearl1594 commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648277417


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

blueorangutan commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648235918


   Packaging result: ✔centos7 ✔debian. JID-1433



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

blueorangutan commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648218518


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements

[GitBox]

Pearl1594 commented on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648217775


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

rhtyd commented on a change in pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#discussion_r444288743



##
File path: 
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java
##
@@ -117,4 +121,8 @@ public void setPort(final int port) {
 public void setDomainId(final Long domainId) {
 this.domainId = domainId;
 }
+
+public boolean listAll() {
+return listAll == null ? false : listAll;

Review comment:
   can be simplified as listAll != null && listAll





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648180791


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

Pearl1594 commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648179438


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4167: Adding missing fields to API responses

[GitBox]

davidjumani commented on pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648130216


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses

[GitBox]

blueorangutan commented on pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648130558


   @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses

[GitBox]

blueorangutan commented on pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648128507


   Packaging result: ✔centos7 ✔debian. JID-1432



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648126845


   Packaging result: ✔centos7 ✔debian. JID-1431



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses

[GitBox]

blueorangutan commented on pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648115873


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4167: Adding missing fields to API responses

[GitBox]

davidjumani commented on pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648115404


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

blueorangutan commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648110131


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

[GitBox]

Pearl1594 commented on pull request #3976:
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-648109643


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

davidjumani commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648105886


   LGTM. Tested and able to login!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

DaanHoogland commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648091648


   @rhtyd casn you have a look as well?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on issue #4146: Kubernetes Service: Unable to add new Kubernetes cluster

[GitBox]

shwstppr commented on issue #4146:
URL: https://github.com/apache/cloudstack/issues/4146#issuecomment-648073614


   @ravening can you check cluster deployment using a prebuilt community 
Kubernetes version ISO, https://download.cloudstack.org/cks/
   while creating the ISO you are using k8s version as 1.16.3 but for weavenet 
you are passing 1.12.5. Not sure if that is the issue.
   Also, check if MS is able to SSH your cluster VMs.
   CKS will need SSH access for communicating with k8s cluster master VM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] davidjumani opened a new pull request #4167: Adding missing fields to API responses

[GitBox]

davidjumani opened a new pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167


   ## Description
   Adding missing fields in the following APIs
   `osdisplayname` in `listVirtualMachines`
   `vpcofferingname` in `listVpcs`
   `vpcname` in `listPublicIpAddresses`
   `vpcname` in `listPrivateGateways`
   `vpcname` in `listVpnGateways`
   `templatename, podname` in `listRouters`
   `templatename, podname` in `listSystemVms`
   
   Fixes: #4161 
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

blueorangutan commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648054570


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

Pearl1594 commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648053983


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

blueorangutan commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648053213


   Packaging result: ✔centos7 ✔debian. JID-1430



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

rhtyd commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648047819


   Add the fixes... Issue reference please 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

blueorangutan commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648043616


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #4166: Fixes issue b/w Legacy and Primate UI wrt SessionID

[GitBox]

Pearl1594 commented on pull request #4166:
URL: https://github.com/apache/cloudstack/pull/4166#issuecomment-648043050


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org