Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]
borisstoyanov commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2162485748 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: Configure config drive ISO with password file on reinstallation of VM with password-enabled template (#9113)
This is an automated email from the ASF dual-hosted git repository.
bstoyanov pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 0f770194df7 Configure config drive ISO with password file on
reinstallation of VM with password-enabled template (#9113)
0f770194df7 is described below
commit 0f770194df7962c5fbd66c06d57a120e7f591e04
Author: Pearl Dsilva
AuthorDate: Wed Jun 12 05:00:08 2024 -0400
Configure config drive ISO with password file on reinstallation of VM with
password-enabled template (#9113)
* Configure config drive ISO with password file on reinstallation of VM
with password-enabled template
* address comment
---
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
index d9484761998..4d966d8e745 100644
--- a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -7957,7 +7957,7 @@ public class UserVmManagerImpl extends ManagerBase
implements UserVmManager, Vir
}
if (needRestart) {
try {
-if (vm.getDetail(VmDetailConstants.PASSWORD) != null) {
+if (Objects.nonNull(password)) {
params = new HashMap<>();
params.put(VirtualMachineProfile.Param.VmPassword,
password);
}
Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]
borisstoyanov merged PR #9113: URL: https://github.com/apache/cloudstack/pull/9113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The corresponding Network Tier like vpc-XXX-privateNetwork cannot be automatically removed [cloudstack]
weizhouapache commented on issue #7891: URL: https://github.com/apache/cloudstack/issues/7891#issuecomment-2162464393 I am able to reproduce the issue in a zone with vxlan isolation when create a private gateway, there are two networks created for it ``` mysql> select * from networks where id in (441,442); +-++--++--+---+---+-+++-+-++---+---+-+---++--+--+-+-+---++--++++--+-+-+---++-+--+--+-++-+---+-++-+ | id | name | uuid | display_text | traffic_type | broadcast_domain_type | broadcast_uri | gateway | cidr | mode | network_offering_id | physical_network_id | data_center_id | guru_name | state | related | domain_id | account_id | dns1 | dns2 | ip6dns1 | ip6dns2 | guru_data | set_fields | acl_type | network_domain | reservation_id | guest_type | restart_required | created | removed | specify_ip_ranges | vpc_id | ip6_gateway | ip6_cidr | network_cidr | display_network | network_acl_id | streched_l2 | redundant | external_id | public_mtu | private_mtu | +-++--++--+---+---+-+++-+-++---+---+-+---++--+--+-+-+---++--++++--+-+-+---++-+--+--+-++-+---+-++-+ | 441 | vpc-vpc-001-privateNetwork | 163390b5-704e-44ff-a8cd-ea026880ebb1 | vpc-vpc-001-privateNetwork | Guest| Vlan | vlan://100 | 192.168.1.1 | 192.168.1.0/24 | Static | 5 | 200 | 1 | PrivateNetworkGuru| Setup | 441 | 1 | 2 | NULL | NULL | NULL| NULL| NULL | 0 | Account | NULL | NULL | Isolated |0 | 2024-06-12 08:43:19 | NULL| 0 | NULL | NULL| NULL | NULL | 1 | NULL | 0 | 0 | NULL | NULL |NULL | | 442 | vpc-vpc-001-privateNetwork | 8d90b099-04ba-42bd-9f21-0d230eb6ee2e | vpc-vpc-001-privateNetwork | Guest| Vxlan | vlan://100 | 192.168.1.1 | 192.168.1.0/24 | Dhcp | 5 | 200 | 1 | VxlanGuestNetworkGuru | Setup | 441 | 1 | 2 | NULL | NULL | NULL| NULL| NULL | 0 | Account | NULL | NULL | Isolated |0 | 2024-06-12 08:43:19 | NULL| 0 | 54 | NULL| NULL | NULL | 1 | NULL | 0 | 0 | NULL | 1500 |1500 | +-++--++--+---+---+-+++-+-++---+---+-+---++--+--+-+-+---++--++++--+-+-+---++-+--+--+-++-+---+-++-+ 2 rows in set (0.00 sec) ``` when private gateway is removed, only the 1 record is marked as removed. ``` mysql> select * from networks where id in (441,442); +-++--++--+---+---+-+++-+-++---+-+-+---++--+--+-+-+---++--+++--
Re: [PR] UI: ignore error host is already in the database when create a zone [cloudstack]
codecov[bot] commented on PR #9231: URL: https://github.com/apache/cloudstack/pull/9231#issuecomment-2162443031 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9231?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`1577218`)](https://app.codecov.io/gh/apache/cloudstack/commit/15772189990b2f65923178626ac0b57829714aab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`daa9515`)](https://app.codecov.io/gh/apache/cloudstack/commit/daa9515731a03faa8a1806b2514aeca111f8ef11?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on 4.19. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9231 +/- ## - Coverage 14.96% 4.30% -10.67% Files 5373 363 -5010 Lines469315 29314 -440001 Branches 598475119-54728 - Hits 702331261-68972 + Misses 391309 27910 -363399 + Partials 7773 143 -7630 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9231/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9231?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Disk offering doesn't change when resize operation is performed [cloudstack]
weizhouapache commented on issue #8413: URL: https://github.com/apache/cloudstack/issues/8413#issuecomment-2162436790 closing @kiranchavala as Hari mentioned, please use `changeOfferingForVolume` to change the disk offering of volume -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Disk offering doesn't change when resize operation is performed [cloudstack]
weizhouapache closed issue #8413: Disk offering doesn't change when resize operation is performed URL: https://github.com/apache/cloudstack/issues/8413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] UI: ignore error host is already in the database when create a zone [cloudstack]
weizhouapache opened a new pull request, #9231:
URL: https://github.com/apache/cloudstack/pull/9231
### Description
This PR fixes #8597
note
- I cannot reproduce the same issue that host is "already in the database"
- I was able to reproduce the issue that "Unable to add host" by renaming
/usr/sbin/kvm-ok on ubuntu 22.04 host. when I changed the string in this PR,
the issue is ignored.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]
blueorangutan commented on PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#issuecomment-2162422446 Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 9882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2162422445 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix options for host.allocators.order config [cloudstack]
blueorangutan commented on PR #8733: URL: https://github.com/apache/cloudstack/pull/8733#issuecomment-2162422448 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (15772189990 -> 4ec0f823cf3)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
from 15772189990 server,event: fix events for storage maintenance (#9056)
add 4ec0f823cf3 ScaleIO volume live migration - use usable bytes from
source disk to format the destination disk (#9174)
No new revisions were added by this update.
Summary of changes:
...meStatsAnswer.java => GetVolumeStatAnswer.java} | 42 +-
...StatsCommand.java => GetVolumeStatCommand.java} | 25
.../cloudstack/storage/to/VolumeObjectTO.java | 9 +++
.../LibvirtGetVolumeStatCommandWrapper.java| 66 ++
.../LibvirtMigrateVolumeCommandWrapper.java| 23 +---
.../hypervisor/kvm/storage/KVMStoragePool.java | 3 +
.../kvm/storage/KVMStorageProcessor.java | 2 +-
.../kvm/storage/ScaleIOStorageAdaptor.java | 15 -
.../hypervisor/kvm/storage/ScaleIOStoragePool.java | 5 ++
.../hypervisor/kvm/storage/StorageAdaptor.java | 5 ++
.../driver/ScaleIOPrimaryDataStoreDriver.java | 23 ++--
.../driver/ScaleIOPrimaryDataStoreDriverTest.java | 31 +++---
12 files changed, 198 insertions(+), 51 deletions(-)
copy core/src/main/java/com/cloud/agent/api/{GetVolumeStatsAnswer.java =>
GetVolumeStatAnswer.java} (61%)
copy core/src/main/java/com/cloud/agent/api/{GetVolumeStatsCommand.java =>
GetVolumeStatCommand.java} (70%)
create mode 100644
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVolumeStatCommandWrapper.java
Re: [PR] PowerFlex/ScaleIO volume live migration - use usable bytes from source disk to format the destination disk [cloudstack]
rohityadavcloud merged PR #9174: URL: https://github.com/apache/cloudstack/pull/9174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PowerFlex/ScaleIO volume live migration - use usable bytes from source disk to format the destination disk [cloudstack]
rohityadavcloud commented on PR #9174: URL: https://github.com/apache/cloudstack/pull/9174#issuecomment-2162413215 Changes LGTM, thanks for testing @kiranchavala Merging based on manual QA and smoketests and reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]
rohityadavcloud commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2162393074 @GutoVeronezi by your own admission I changed my stand, closed my PR to support Joao's, and built support and consensus with others on Joao's PR and merge his PR. I also don't appreciate some of your remarks and behaviour towards me. It's unfair to me when I'm genuinely trying to help and support everybody and anybody in the community. I don't see anything wrong with somebody changing their stand when presented with new information or convincing arguments. My reason for changing my stand wrt the default behaviour is that most users don't consume stats (outside of UI) via the list APIs, but many integrations such as Terraform provider, k8s-provider, CAPC, users ansible scripts etc (point of note that these integrations can't be changed) call the list VM APIs and can benefit from any potential speed up. @GutoVeronezi @JoaoJandre and anyone else - what are your reasons of changing your stand wrt the default behaviour now? For example, look at the two user reported issues that also contributed to change my stand: https://github.com/apache/cloudstack/issues/8975 https://github.com/apache/cloudstack/issues/7910 I think we introduced the behaviour, and we can discuss and agree if we want to change that if that is largely beneficial to users. I don't think it would detrimental for large number of users if they have gain speedups and still had a global setting to change the behaviour. That said, I don't have the energy or bandwidth to fight over this, if this is the only thing blocking this I can change the global setting. Have a look, review and advise - @JoaoJandre @DaanHoogland @weizhouapache @sureshanaparti @GutoVeronezi @shwstppr and others... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]
blueorangutan commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2162378625 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: remove username required condition for listVmsForImport [cloudstack]
shwstppr commented on PR #9124: URL: https://github.com/apache/cloudstack/pull/9124#issuecomment-2162376923 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS [cloudstack]
blueorangutan commented on PR #9222: URL: https://github.com/apache/cloudstack/pull/9222#issuecomment-2162366991 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]
blueorangutan commented on PR #9216: URL: https://github.com/apache/cloudstack/pull/9216#issuecomment-2162359541 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]
shwstppr commented on PR #9216: URL: https://github.com/apache/cloudstack/pull/9216#issuecomment-2162358466 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]
shwstppr commented on code in PR #9216:
URL: https://github.com/apache/cloudstack/pull/9216#discussion_r1636002052
##
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java:
##
@@ -2697,9 +2702,20 @@ public VDI getIsoVDIByURL(final Connection conn, final
String vmName, final Stri
} catch (final URISyntaxException e) {
throw new CloudRuntimeException("isoURL is wrong: " + isoURL);
}
-isoSR = getISOSRbyVmName(conn, vmName);
+isoSR = getISOSRbyVmName(conn, vmName, false);
if (isoSR == null) {
isoSR = createIsoSRbyURI(conn, uri, vmName, false);
+} else {
+try {
+String description = isoSR.getNameDescription(conn);
+if (description.endsWith(ConfigDrive.CONFIGDRIVEDIR)) {
+throw new CloudRuntimeException(String.format("VM %s
already has %s ISO attached. Please " +
+"stop-start VM for allowing attaching both ISOs",
vmName, ConfigDrive.CONFIGDRIVEDIR));
Review Comment:
```suggestion
"stop-start VM to allow attaching-detaching both
ISOs", vmName, ConfigDrive.CONFIGDRIVEDIR));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]
shwstppr commented on PR #9216: URL: https://github.com/apache/cloudstack/pull/9216#issuecomment-2162354851 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ensure marvin package version is PEP440 compliant [cloudstack]
codecov[bot] commented on PR #9230: URL: https://github.com/apache/cloudstack/pull/9230#issuecomment-2162354828 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9230?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`edf7394`)](https://app.codecov.io/gh/apache/cloudstack/commit/edf7394919fa29b2e0c2ebec5b624b5dde7dedf6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7cd62ca`)](https://app.codecov.io/gh/apache/cloudstack/commit/7cd62ca46cff2b5e82c170598eaf4234962ee06c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 2 commits behind head on 4.19. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9230 +/- ## - Coverage 14.96% 4.30% -10.67% Files 5373 363 -5010 Lines469311 29312 -43 Branches 574325118-52314 - Hits 702301261-68969 + Misses 391307 27908 -363399 + Partials 7774 143 -7631 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9230/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9230/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9230/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9230?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]
shwstppr closed pull request #9216: xenserver: attach regular iso with configdrive URL: https://github.com/apache/cloudstack/pull/9216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Host HA not working even after configured oob-management [cloudstack]
rohityadavcloud commented on issue #7543: URL: https://github.com/apache/cloudstack/issues/7543#issuecomment-2162354341 There is a known issue with ipmitool version on EL8 and EL9, it's worth checking if OOBM is working in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix resource count updated unmanage vm [cloudstack]
blueorangutan commented on PR #8169: URL: https://github.com/apache/cloudstack/pull/8169#issuecomment-2162341498 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix marvin version while building packages [cloudstack]
blueorangutan commented on PR #9230: URL: https://github.com/apache/cloudstack/pull/9230#issuecomment-2162341428 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix marvin version while building packages [cloudstack]
vishesh92 commented on PR #9230: URL: https://github.com/apache/cloudstack/pull/9230#issuecomment-2162340014 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix marvin version while building packages [cloudstack]
vishesh92 opened a new pull request, #9230:
URL: https://github.com/apache/cloudstack/pull/9230
### Description
Fixes #7927
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix resource count updated unmanage vm [cloudstack]
shwstppr commented on PR #8169: URL: https://github.com/apache/cloudstack/pull/8169#issuecomment-2162338061 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix resource count updated unmanage vm [cloudstack]
shwstppr commented on code in PR #8169:
URL: https://github.com/apache/cloudstack/pull/8169#discussion_r1635986410
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -8494,9 +8494,7 @@ private void postProcessingUnmanageVM(UserVmVO vm) {
UsageEventUtils.publishUsageEvent(EventTypes.EVENT_VM_STOP,
vm.getAccountId(), vm.getDataCenterId(),
vm.getId(), vm.getHostName(), vm.getServiceOfferingId(),
vm.getTemplateId(),
vm.getHypervisorType().toString(),
VirtualMachine.class.getName(), vm.getUuid(), vm.isDisplayVm());
-resourceCountDecrement(vm.getAccountId(), vm.isDisplayVm(), cpu,
ram);
Review Comment:
Same method is called later at line 8502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix resource count updated unmanage vm [cloudstack]
shwstppr closed pull request #8169: server: fix resource count updated unmanage vm URL: https://github.com/apache/cloudstack/pull/8169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Event state is incorrect when Maintenance mode is Enabled/Cancelled on a Primary storage [cloudstack]
shwstppr commented on issue #8495: URL: https://github.com/apache/cloudstack/issues/8495#issuecomment-2162335200 Fixed with #9056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] server: fix resource count updated unmanage vm [cloudstack]
shwstppr opened a new pull request, #8169:
URL: https://github.com/apache/cloudstack/pull/8169
### Description
Do not decrement resource count for a running VM twice while unmanaging.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Event state is incorrect when Maintenance mode is Enabled/Cancelled on a Primary storage [cloudstack]
shwstppr closed issue #8495: Event state is incorrect when Maintenance mode is Enabled/Cancelled on a Primary storage URL: https://github.com/apache/cloudstack/issues/8495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix resource count updated unmanage vm [cloudstack]
github-actions[bot] commented on PR #8169: URL: https://github.com/apache/cloudstack/pull/8169#issuecomment-2162334945 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cks: fix events [cloudstack]
blueorangutan commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2162329542 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server,event: fix events for storage maintenance [cloudstack]
DaanHoogland merged PR #9056: URL: https://github.com/apache/cloudstack/pull/9056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: server,event: fix events for storage maintenance (#9056)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 15772189990 server,event: fix events for storage maintenance (#9056)
15772189990 is described below
commit 15772189990b2f65923178626ac0b57829714aab
Author: Abhishek Kumar
AuthorDate: Wed Jun 12 13:13:13 2024 +0530
server,event: fix events for storage maintenance (#9056)
Signed-off-by: Abhishek Kumar
---
server/src/main/java/com/cloud/storage/StorageManagerImpl.java | 4
1 file changed, 4 insertions(+)
diff --git a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
index fd6813d9d38..adece636501 100644
--- a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
@@ -1924,6 +1924,8 @@ public class StorageManagerImpl extends ManagerBase
implements StorageManager, C
@Override
@DB
+@ActionEvent(eventType =
EventTypes.EVENT_MAINTENANCE_PREPARE_PRIMARY_STORAGE,
+eventDescription = "preparing storage pool for maintenance", async
= true)
public PrimaryDataStoreInfo preparePrimaryStorageForMaintenance(Long
primaryStorageId) throws ResourceUnavailableException,
InsufficientCapacityException {
StoragePoolVO primaryStorage = null;
primaryStorage = _storagePoolDao.findById(primaryStorageId);
@@ -1992,6 +1994,8 @@ public class StorageManagerImpl extends ManagerBase
implements StorageManager, C
@Override
@DB
+@ActionEvent(eventType =
EventTypes.EVENT_MAINTENANCE_CANCEL_PRIMARY_STORAGE,
+eventDescription = "canceling maintenance for primary storage
pool", async = true)
public PrimaryDataStoreInfo
cancelPrimaryStorageForMaintenance(CancelPrimaryStorageMaintenanceCmd cmd)
throws ResourceUnavailableException {
Long primaryStorageId = cmd.getId();
StoragePoolVO primaryStorage = null;
Re: [PR] cks: fix events [cloudstack]
DaanHoogland commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2162325805 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]
DaanHoogland commented on code in PR #9207:
URL: https://github.com/apache/cloudstack/pull/9207#discussion_r1635971625
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -599,13 +598,13 @@ public List>
getSecondaryStorageStoresUrlAndIdList(long dcId)
}
if (urlIdList.isEmpty()) {
-// we are using non-NFS image store, then use cache storage instead
-s_logger.info("Secondary storage is not NFS, we need to use
staging storage");
+// image stores doesn't have enough capacity or we are using
non-NFS image store, then use cache storage instead
Review Comment:
```suggestion
```
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -572,18 +571,18 @@ public Pair
getSecondaryStorageStoreUrlAndId(long dcId) {
}
if (secUrl == null) {
-// we are using non-NFS image store, then use cache storage instead
-s_logger.info("Secondary storage is not NFS, we need to use
staging storage");
+// image stores doesn't have enough capacity or we are using
non-NFS image store, then use cache storage instead
Review Comment:
```suggestion
```
this is already in the log statement, i think we can delete the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] engine-schema: fix options for host.allocators.order config [cloudstack]
blueorangutan commented on PR #8733: URL: https://github.com/apache/cloudstack/pull/8733#issuecomment-2162312414 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix options for host.allocators.order config [cloudstack]
shwstppr commented on PR #8733: URL: https://github.com/apache/cloudstack/pull/8733#issuecomment-2162310414 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]
blueorangutan commented on PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#issuecomment-2162309238 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2162305739 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]
shwstppr commented on PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#issuecomment-2162305798 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Event state is incorrect when vpc network is created [cloudstack]
kiranchavala closed issue #8496: Event state is incorrect when vpc network is created URL: https://github.com/apache/cloudstack/issues/8496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Event state is incorrect when vpc network is created [cloudstack]
kiranchavala commented on issue #8496: URL: https://github.com/apache/cloudstack/issues/8496#issuecomment-2162303597 Closing the issue as the PR is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
weizhouapache commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2162301703 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
weizhouapache commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1635956238
##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java:
##
@@ -0,0 +1,66 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.storage.resource;
+
+import com.cloud.utils.script.Script;
+import org.apache.log4j.Logger;
+
+public class IpTablesHelper {
+public static final Logger LOGGER = Logger.getLogger(IpTablesHelper.class);
+
+public static final String OUTPUT_CHAIN = "OUTPUT";
+public static final String INPUT_CHAIN = "INPUT";
+public static final String INSERT = " -I ";
+public static final String APPEND = " -A ";
+
+public static boolean needsAdding(String chain, String rule) {
+Script command = new Script("/bin/bash", LOGGER);
+command.add("-c");
+command.add("iptables -C " + chain + " " + rule);
+
+String commandOutput = command.execute();
+boolean needsAdding = (commandOutput != null &&
commandOutput.contains("iptables: Bad rule (does a matching rule exist in that
chain?)."));
+LOGGER.debug(String.format("Rule [%s], %s need adding to [%s] : %s",
+rule,
+needsAdding ? "does indeed" : "doesn't",
+chain,
+commandOutput
+));
+return needsAdding;
+}
+
+public static String addConditionally(String chain, boolean insert, String
rule, String errMsg) {
+LOGGER.info(String.format("Adding rule [%s] to [%s] if required.",
rule, chain));
+if (needsAdding(chain, rule)) {
+Script command = new Script("/bin/bash", LOGGER);
+command.add("-c");
+command.add("iptables" + (insert ? INSERT : APPEND) + chain + " "
+ rule);
+String result = command.execute();
+LOGGER.debug(String.format("Executed [%s] with result [%s]",
command, result));
+if (result != null) {
+LOGGER.warn(errMsg + result);
+return errMsg + result;
+}
+} else {
+LOGGER.warn("Rule already defined in SVM: " + rule);
Review Comment:
> I had the idea that this would/could be more generic code. Is it important?
@DaanHoogland
it is trivial.
ignore it then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] vpc,event: fix events for createVpc [cloudstack]
kiranchavala merged PR #9055: URL: https://github.com/apache/cloudstack/pull/9055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup startVM on simulator [cloudstack]
DaanHoogland closed pull request #9199: Fixup startVM on simulator URL: https://github.com/apache/cloudstack/pull/9199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (edf7394919f -> ca597200156)
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from edf7394919f server: search template name and display text if keyword is passed (#9215) add ca597200156 vpc,event: fix events for createVpc (#9055) No new revisions were added by this update. Summary of changes: api/src/main/java/com/cloud/network/vpc/VpcService.java | 2 ++ .../apache/cloudstack/api/command/user/vpc/CreateVPCCmd.java | 6 +- .../cloudstack/api/command/user/vpc/CreateVPCCmdTest.java | 5 ++--- .../src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 11 +++ 4 files changed, 16 insertions(+), 8 deletions(-)
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
DaanHoogland commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1635954603
##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java:
##
@@ -0,0 +1,66 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.storage.resource;
+
+import com.cloud.utils.script.Script;
+import org.apache.log4j.Logger;
+
+public class IpTablesHelper {
+public static final Logger LOGGER = Logger.getLogger(IpTablesHelper.class);
+
+public static final String OUTPUT_CHAIN = "OUTPUT";
+public static final String INPUT_CHAIN = "INPUT";
+public static final String INSERT = " -I ";
+public static final String APPEND = " -A ";
+
+public static boolean needsAdding(String chain, String rule) {
+Script command = new Script("/bin/bash", LOGGER);
+command.add("-c");
+command.add("iptables -C " + chain + " " + rule);
+
+String commandOutput = command.execute();
+boolean needsAdding = (commandOutput != null &&
commandOutput.contains("iptables: Bad rule (does a matching rule exist in that
chain?)."));
+LOGGER.debug(String.format("Rule [%s], %s need adding to [%s] : %s",
+rule,
+needsAdding ? "does indeed" : "doesn't",
+chain,
+commandOutput
+));
+return needsAdding;
+}
+
+public static String addConditionally(String chain, boolean insert, String
rule, String errMsg) {
+LOGGER.info(String.format("Adding rule [%s] to [%s] if required.",
rule, chain));
+if (needsAdding(chain, rule)) {
+Script command = new Script("/bin/bash", LOGGER);
+command.add("-c");
+command.add("iptables" + (insert ? INSERT : APPEND) + chain + " "
+ rule);
+String result = command.execute();
+LOGGER.debug(String.format("Executed [%s] with result [%s]",
command, result));
+if (result != null) {
+LOGGER.warn(errMsg + result);
+return errMsg + result;
+}
+} else {
+LOGGER.warn("Rule already defined in SVM: " + rule);
Review Comment:
thanks for the review @weizhouapache , I addressed the rest but hope to
leave this as is, as the changes may be usefull for any SVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] List volumes by service offering id [cloudstack]
blueorangutan commented on PR #9211: URL: https://github.com/apache/cloudstack/pull/9211#issuecomment-2162297910 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
DaanHoogland commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1635943766
##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java:
##
@@ -0,0 +1,66 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.storage.resource;
+
+import com.cloud.utils.script.Script;
+import org.apache.log4j.Logger;
+
+public class IpTablesHelper {
+public static final Logger LOGGER = Logger.getLogger(IpTablesHelper.class);
+
+public static final String OUTPUT_CHAIN = "OUTPUT";
+public static final String INPUT_CHAIN = "INPUT";
+public static final String INSERT = " -I ";
+public static final String APPEND = " -A ";
+
+public static boolean needsAdding(String chain, String rule) {
+Script command = new Script("/bin/bash", LOGGER);
+command.add("-c");
+command.add("iptables -C " + chain + " " + rule);
+
+String commandOutput = command.execute();
+boolean needsAdding = (commandOutput != null &&
commandOutput.contains("iptables: Bad rule (does a matching rule exist in that
chain?)."));
+LOGGER.debug(String.format("Rule [%s], %s need adding to [%s] : %s",
+rule,
+needsAdding ? "does indeed" : "doesn't",
+chain,
+commandOutput
+));
+return needsAdding;
+}
+
+public static String addConditionally(String chain, boolean insert, String
rule, String errMsg) {
+LOGGER.info(String.format("Adding rule [%s] to [%s] if required.",
rule, chain));
+if (needsAdding(chain, rule)) {
+Script command = new Script("/bin/bash", LOGGER);
+command.add("-c");
+command.add("iptables" + (insert ? INSERT : APPEND) + chain + " "
+ rule);
+String result = command.execute();
+LOGGER.debug(String.format("Executed [%s] with result [%s]",
command, result));
+if (result != null) {
+LOGGER.warn(errMsg + result);
+return errMsg + result;
+}
+} else {
+LOGGER.warn("Rule already defined in SVM: " + rule);
Review Comment:
I had the idea that this would/could be more generic code. Is it important?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
DaanHoogland commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1635937702
##
utils/src/main/java/com/cloud/utils/script/Script.java:
##
@@ -242,13 +242,20 @@ public String execute(OutputInterpreter interpreter) {
if (_process.waitFor(_timeout, TimeUnit.MILLISECONDS)) {
//process completed successfully
if (_process.exitValue() == 0) {
-_logger.debug("Execution is successful.");
+_logger.debug("Execution is successfullish.");
Review Comment:
sorry, had to check if I was testing new code ;) will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]
DaanHoogland commented on PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#issuecomment-2162277497 > @DaanHoogland Can I get this added to the 4.19.1 milestone, this PR is now sitting around for a few months now... You are free to do that yourself (as a committer) but I just did. @sureshanaparti will surely look at it ;) @slavkap is this alright by you now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: [UI] Add option to specify account/project while deploying VMs and creating networks (#8919)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 3fe2b46dd0b [UI] Add option to specify account/project while deploying
VMs and creating networks (#8919)
3fe2b46dd0b is described below
commit 3fe2b46dd0b00a2dbca8c2bb154e61fe436869cb
Author: Bryan Lima <42067040+bryanml...@users.noreply.github.com>
AuthorDate: Wed Jun 12 04:10:32 2024 -0300
[UI] Add option to specify account/project while deploying VMs and creating
networks (#8919)
---
ui/public/locales/en.json | 1 +
ui/public/locales/pt_BR.json | 1 +
ui/src/views/compute/AssignInstance.vue| 167 +
ui/src/views/compute/DeployVM.vue | 94 +++-
ui/src/views/compute/wizard/OwnershipSelection.vue | 257 +
ui/src/views/network/CreateIsolatedNetworkForm.vue | 171 +++---
ui/src/views/network/CreateL2NetworkForm.vue | 144 +++-
7 files changed, 421 insertions(+), 414 deletions(-)
diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json
index cb279c7a149..86a74384cb7 100644
--- a/ui/public/locales/en.json
+++ b/ui/public/locales/en.json
@@ -1557,6 +1557,7 @@
"label.ovmnetworklabel": "OVM traffic label",
"label.ovs": "OVS",
"label.owner.account": "Owner Account",
+"label.owner.type": "Owner type",
"label.owners": "Owners",
"label.pa": "Palo Alto",
"label.page": "page",
diff --git a/ui/public/locales/pt_BR.json b/ui/public/locales/pt_BR.json
index cc8e22d5e47..9d64cc27150 100644
--- a/ui/public/locales/pt_BR.json
+++ b/ui/public/locales/pt_BR.json
@@ -1155,6 +1155,7 @@
"label.ovmnetworklabel": "R\u00f3tulo de tr\u00e1fego OVM",
"label.ovs": "OVS",
"label.owner.account": "Dono da conta",
+"label.owner.type": "Tipo de dono",
"label.owners": "Donos",
"label.pa": "Palo Alto",
"label.page": "p\u00e1gina",
diff --git a/ui/src/views/compute/AssignInstance.vue
b/ui/src/views/compute/AssignInstance.vue
index 9726dc21577..873d10f5770 100644
--- a/ui/src/views/compute/AssignInstance.vue
+++ b/ui/src/views/compute/AssignInstance.vue
@@ -29,86 +29,7 @@
-
-{{ $t('label.accounttype') }}
-
- {{ $t('label.account')
}}
- {{ $t('label.project')
}}
-
-
-
-
-*{{
$t('label.domain') }}
-
-
-
-
-
- {{ domain.path || domain.name || domain.description }}
-
-
-
-
-
-
-
- *{{
$t('label.account') }}
-
-
-
-
-
-{{ account.name }}
-
-
-
- {{ $t('label.required')
}}
-
-
-
-
-
- *{{
$t('label.project') }}
-
-
-
-
-
-{{ project.name }}
-
-
-
- {{ $t('label.required')
}}
-
-
+
{{ $t('label.network') }}
@@ -146,6 +67,7 @@
import { api } from '@/api'
import ResourceIcon from '@/components/view/ResourceIcon'
+import OwnershipSelection from '@views/compute/wizard/OwnershipSelection'
export default {
name: 'AssignInstance',
@@ -156,7 +78,8 @@ export default {
}
},
components: {
-ResourceIcon
+ResourceIcon,
+OwnershipSelection
},
inject: ['parentFetchData'],
data () {
@@ -175,60 +98,13 @@ export default {
loading: false
}
},
- created () {
-this.fetchData()
- },
methods: {
-fetchData () {
- this.loading = true
- api('listDomains', {
-response: 'json',
-listAll: true,
-showicon: true,
-details: 'min'
- }).then(response => {
-this.domains = response.listdomainsresponse.domain || []
-this.selectedDomain = this.domains[0].id
-this.fetchAccounts()
-this.fetchProjects()
- }).catch(error => {
-this.$notifyError(error)
- }).finally(() => {
-this.loading = false
- })
-},
-fetchAccounts () {
- this.loading = true
- api('listAccounts', {
-response: 'json',
-domainId: this.selectedDomain,
-showicon: true,
-state: 'Enabled',
-isrecursive: false
- }).then(response => {
-this.accounts = response.listaccountsresponse.account || []
- }).catch(error => {
-this.$notifyError(error)
- }).finally(() => {
-this.loading = false
- })
-},
-fetchProjects () {
- this.loading = true
- api('listProjects', {
-response: 'json',
-domainId: this.selectedDomain,
-state: 'Active',
-showicon: true,
-
Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]
DaanHoogland merged PR #8919: URL: https://github.com/apache/cloudstack/pull/8919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] cloud-init not running after boot [cloudstack]
MartinEmrich commented on issue #8129: URL: https://github.com/apache/cloudstack/issues/8129#issuecomment-2162263937 Ok. IDK if the documented change would work, too, bud the `ds-identify.cfg` file works fine for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]
blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162259625 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS [cloudstack]
abh1sar commented on PR #9222: URL: https://github.com/apache/cloudstack/pull/9222#issuecomment-2162258634 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS [cloudstack]
blueorangutan commented on PR #9222: URL: https://github.com/apache/cloudstack/pull/9222#issuecomment-2162259568 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]
harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162257510 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
